[MSE][GStreamer] Enable QUOTA_EXCEEDED_ERR support for GStreamer
authoreocanha@igalia.com <eocanha@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Oct 2016 08:47:42 +0000 (08:47 +0000)
committereocanha@igalia.com <eocanha@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Oct 2016 08:47:42 +0000 (08:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=162922

Reviewed by Xabier Rodriguez-Calvar.

QUOTA_EXCEEDED_ERR should be reported by SourceBuffer when appropriate, at least on the
GStreamer implementation.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBufferInternal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@207890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/mediasource/SourceBuffer.cpp

index ac40c67..eacda94 100644 (file)
@@ -1,5 +1,18 @@
 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
 
+        [MSE][GStreamer] Enable QUOTA_EXCEEDED_ERR support for GStreamer
+        https://bugs.webkit.org/show_bug.cgi?id=162922
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        QUOTA_EXCEEDED_ERR should be reported by SourceBuffer when appropriate, at least on the
+        GStreamer implementation.
+
+        * Modules/mediasource/SourceBuffer.cpp:
+        (WebCore::SourceBuffer::appendBufferInternal):
+
+2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
+
         [MSE] Expose additional MediaSource methods to MediaSourcePrivate
         https://bugs.webkit.org/show_bug.cgi?id=162920
 
index 9b83784..0157d1d 100644 (file)
@@ -515,7 +515,7 @@ ExceptionOr<void> SourceBuffer::appendBufferInternal(const unsigned char* data,
     evictCodedFrames(size);
 
     // FIXME: enable this code when MSE libraries have been updated to support it.
-#if 0
+#if USE(GSTREAMER)
     // 5. If the buffer full flag equals true, then throw a QUOTA_EXCEEDED_ERR exception and abort these step.
     if (m_bufferFull) {
         LOG(MediaSource, "SourceBuffer::appendBufferInternal(%p) -  buffer full, failing with QUOTA_EXCEEDED_ERR error", this);