2011-02-04 Martin Robinson <mrobinson@igalia.com>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Feb 2011 04:17:32 +0000 (04:17 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Feb 2011 04:17:32 +0000 (04:17 +0000)
        Reviewed by Adam Barth.

        [GTK] plugins/plugin-document-back-forward.html fails
        https://bugs.webkit.org/show_bug.cgi?id=53833

        * platform/gtk/Skipped: Unskip test which is now passing.
2011-02-04  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Adam Barth.

        [GTK] plugins/plugin-document-back-forward.html fails
        https://bugs.webkit.org/show_bug.cgi?id=53833

        Add the new "alert on load" functionality for the Unix version of the
        test plugin. This functionality was originally introduced in r77706.

        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance): Add new plugin fuctionality.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/Skipped
Tools/ChangeLog
Tools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp

index f997d08cc7b13b30738e877520ee4d66a1605a1e..726efee77d030bd35ccd63af89cee8c9a6174953 100644 (file)
@@ -1,3 +1,12 @@
+2011-02-04  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Adam Barth.
+
+        [GTK] plugins/plugin-document-back-forward.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=53833
+
+        * platform/gtk/Skipped: Unskip test which is now passing.
+
 2011-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         Reviewed by Martin Robinson.
index e43cd2e6b2b2ba35ef19c74d7b433f065e351c30..a7d97becc6bc3bae74556a485930a05ff1f24da0 100644 (file)
@@ -4711,7 +4711,3 @@ http/tests/websocket/tests/url-with-credential.html
 http/tests/websocket/tests/url-with-empty-query.html
 http/tests/websocket/tests/simple.html
 http/tests/websocket/tests/cross-origin.html
-
-# The plugin doesn't seem to load at all...  Not sure what's going on.
-# https://bugs.webkit.org/show_bug.cgi?id=53833
-plugins/plugin-document-back-forward.html
index 1f042cabd283dd800d53537a9e9ea87548fa0338..d007aea8e8bfc343da7f849720ff2224a0d76fd8 100644 (file)
@@ -1,3 +1,16 @@
+2011-02-04  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Adam Barth.
+
+        [GTK] plugins/plugin-document-back-forward.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=53833
+
+        Add the new "alert on load" functionality for the Unix version of the
+        test plugin. This functionality was originally introduced in r77706.
+
+        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
+        (webkit_test_plugin_new_instance): Add new plugin fuctionality.
+
 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
 
         Reviewed by Andreas Kling.
index 2f7288a60c2263a9563bb4f3261a6d36fa3ee1d3..4936efd16134a3e2b71f887ec3283a61b2946889 100644 (file)
@@ -79,6 +79,9 @@ webkit_test_plugin_new_instance(NPMIMEType mimetype,
             else if (strcasecmp(argn[i], "src") == 0 &&
                      strcasecmp(argv[i], "data:application/x-webkit-test-netscape,returnerrorfromnewstream") == 0)
                 obj->returnErrorFromNewStream = TRUE;
+            else if (!strcasecmp(argn[i], "src")
+                     && !strcasecmp(argv[i], "data:application/x-webkit-test-netscape,alertwhenloaded"))
+                executeScript(obj, "alert('Plugin Loaded!')");
             else if (strcasecmp(argn[i], "logfirstsetwindow") == 0)
                 obj->logSetWindow = TRUE;
             else if (strcasecmp(argn[i], "testnpruntime") == 0)