Unreviewed, fix a few tests that became flaky after r230919.
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Apr 2018 02:30:20 +0000 (02:30 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Apr 2018 02:30:20 +0000 (02:30 +0000)
* fast/events/beforeunload-alert-handled-keydown.html:
* fast/events/beforeunload-alert-no-user-interaction.html:
* fast/events/beforeunload-alert-user-interaction.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@230939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/events/beforeunload-alert-handled-keydown.html
LayoutTests/fast/events/beforeunload-alert-no-user-interaction.html
LayoutTests/fast/events/beforeunload-alert-user-interaction.html

index e8032db..aeea6cc 100644 (file)
@@ -1,3 +1,11 @@
+2018-04-23  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed, fix a few tests that became flaky after r230919.
+
+        * fast/events/beforeunload-alert-handled-keydown.html:
+        * fast/events/beforeunload-alert-no-user-interaction.html:
+        * fast/events/beforeunload-alert-user-interaction.html:
+
 2018-04-23  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r230921, r230923, r230924, r230932,
 2018-04-23  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r230921, r230923, r230924, r230932,
index 8c8fceb..9448d0b 100644 (file)
@@ -20,8 +20,8 @@ onload = function() {
 
     setTimeout(function() {
         shouldBeEqualToString("testInput.value", "a");
 
     setTimeout(function() {
         shouldBeEqualToString("testInput.value", "a");
+        testFrame.onload = finishJSTest;
         testFrame.src = "about:blank";
         testFrame.src = "about:blank";
-        setTimeout(finishJSTest, 0);
     }, 0);
 };
 </script>
     }, 0);
 };
 </script>
index a6b9136..046b42d 100644 (file)
@@ -12,8 +12,8 @@ onload = function() {
         return "FAIL: a beforeunload alert was shown even though the user did not interact with the page.";
     };
     setTimeout(function() {
         return "FAIL: a beforeunload alert was shown even though the user did not interact with the page.";
     };
     setTimeout(function() {
+        testFrame.onload = finishJSTest;
         testFrame.src = "about:blank";
         testFrame.src = "about:blank";
-        setTimeout(finishJSTest, 0);
     }, 0);
 };
 </script>
     }, 0);
 };
 </script>
index 66a7c70..56f4b90 100644 (file)
@@ -17,8 +17,8 @@ onload = function() {
     if (window.eventSender)
         eventSender.keyDown("a");
     setTimeout(function() {
     if (window.eventSender)
         eventSender.keyDown("a");
     setTimeout(function() {
+        testFrame.onload = finishJSTest;
         testFrame.src = "about:blank";
         testFrame.src = "about:blank";
-        setTimeout(finishJSTest, 0);
     }, 0);
 };
 </script>
     }, 0);
 };
 </script>