2011-01-20 Ojan Vafai <ojan@chromium.org>

        Fix the review tool for image diffs. We would get a javascript error
        because image diffs don't have line numbers.

        * code-review.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index ee88f2842222c3145a34b90f8fca1db60c5a1f4b..31270550b63cabb40a86f811fb0b2ac710742d54 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,10 @@
+2011-01-20  Ojan Vafai  <ojan@chromium.org>
+
+        Fix the review tool for image diffs. We would get a javascript error
+        because image diffs don't have line numbers.
+
+        * code-review.js:
+
 2011-01-20  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Oliver Hunt.

diff --git a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
index b103819594b949fb652d30910273621e2f2412d8..f113c74fb1391dd798f6f7f4ee401af5189219b0 100644 (file)
--- a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
+++ b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
@@ -417,7 +417,7 @@ body {
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=28"></script>
+<script src="code-review.js?version=29"></script>
 EOF
 
     def self.revisionOrDescription(string)

diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index 45b4bc8b9fff914011f80a4694388dd34bee2fe3..79b4975550869ae39cf54a7b4c79d6f7f219339e 100644 (file)
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -346,6 +346,9 @@
 
   function firstLine(file_diff) {
     var container = $('.LineContainer:not(.context)', file_diff)[0];
+    if (!container)
+      return 0;
+
     var from = fromLineNumber(container);
     var to = toLineNumber(container);
     return from || to;