Remove never-implemented CSS3 text decoration-related properties
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Mar 2017 06:06:41 +0000 (06:06 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Mar 2017 06:06:41 +0000 (06:06 +0000)
https://bugs.webkit.org/show_bug.cgi?id=169009

Reviewed by Zalan Bujtas.

The following CSS properties were added many years ago based on an old CSS3 Text
draft (https://www.w3.org/TR/2003/CR-css3-text-20030514/), but never had any implementations.
Remove them.

    text-line-through
    text-line-through-color
    text-line-through-mode
    text-line-through-style
    text-line-through-width
    text-overline
    text-overline-color
    text-overline-mode
    text-overline-style
    text-overline-width
    text-underline
    text-underline-color
    text-underline-mode
    text-underline-style
    text-underline-width

* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSProperties.json:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/css/CSSComputedStyleDeclaration.cpp
Source/WebCore/css/CSSProperties.json
Source/WebCore/css/parser/CSSParserFastPaths.cpp

index b11c7e0..8c61625 100644 (file)
@@ -1,5 +1,39 @@
 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
 
+        Remove never-implemented CSS3 text decoration-related properties
+        https://bugs.webkit.org/show_bug.cgi?id=169009
+
+        Reviewed by Zalan Bujtas.
+
+        The following CSS properties were added many years ago based on an old CSS3 Text
+        draft (https://www.w3.org/TR/2003/CR-css3-text-20030514/), but never had any implementations.
+        Remove them.
+
+            text-line-through
+            text-line-through-color
+            text-line-through-mode
+            text-line-through-style
+            text-line-through-width
+            text-overline
+            text-overline-color
+            text-overline-mode
+            text-overline-style
+            text-overline-width
+            text-underline
+            text-underline-color
+            text-underline-mode
+            text-underline-style
+            text-underline-width
+
+        * WebCore.xcodeproj/project.pbxproj:
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::ComputedStyleExtractor::propertyValue):
+        * css/CSSProperties.json:
+        * css/parser/CSSParserFastPaths.cpp:
+        (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+
+2017-03-07  Simon Fraser  <simon.fraser@apple.com>
+
         Have fixedPositionCreatesStackingContext be on by default everywhere
         https://bugs.webkit.org/show_bug.cgi?id=169334
 
index 06910c0..fb26994 100644 (file)
                0F8B45731DC41DBA00443C3F /* JSIntersectionObserverCallback.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSIntersectionObserverCallback.cpp; sourceTree = "<group>"; };
                0F8B45741DC41DBA00443C3F /* JSIntersectionObserverCallback.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSIntersectionObserverCallback.h; sourceTree = "<group>"; };
                0F97A657155DA81E00FADD4C /* DisplayRefreshMonitorIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DisplayRefreshMonitorIOS.mm; sourceTree = "<group>"; };
+               0FA0852B1E6FB55A00975FDD /* CSSProperties.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = CSSProperties.json; sourceTree = "<group>"; };
                0FA24D77162DF91900A3F4C0 /* GraphicsLayerUpdater.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = GraphicsLayerUpdater.cpp; sourceTree = "<group>"; };
                0FA24D78162DF91900A3F4C0 /* GraphicsLayerUpdater.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GraphicsLayerUpdater.h; sourceTree = "<group>"; };
                0FA88EBC16A8D1BD00F99984 /* ScrollingStateFrameScrollingNodeMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollingStateFrameScrollingNodeMac.mm; sourceTree = "<group>"; };
                                A80E6CDB0A1989CA007FB8C5 /* CSSPrimitiveValue.cpp */,
                                A80E6CBC0A1989CA007FB8C5 /* CSSPrimitiveValue.h */,
                                E1ED8AC20CC49BE000BFC557 /* CSSPrimitiveValueMappings.h */,
+                               0FA0852B1E6FB55A00975FDD /* CSSProperties.json */,
                                A80E6CCD0A1989CA007FB8C5 /* CSSProperty.cpp */,
                                A80E6CD50A1989CA007FB8C5 /* CSSProperty.h */,
                                82E3D8DC122EA0D1003AE5BC /* CSSPropertySourceData.cpp */,
index 3210851..f8dd5e1 100644 (file)
@@ -3870,21 +3870,6 @@ RefPtr<CSSValue> ComputedStyleExtractor::propertyValue(CSSPropertyID propertyID,
         case CSSPropertyAll:
         case CSSPropertyAnimation:
         case CSSPropertyWebkitTextEmphasis:
-        case CSSPropertyTextLineThrough:
-        case CSSPropertyTextLineThroughColor:
-        case CSSPropertyTextLineThroughMode:
-        case CSSPropertyTextLineThroughStyle:
-        case CSSPropertyTextLineThroughWidth:
-        case CSSPropertyTextOverline:
-        case CSSPropertyTextOverlineColor:
-        case CSSPropertyTextOverlineMode:
-        case CSSPropertyTextOverlineStyle:
-        case CSSPropertyTextOverlineWidth:
-        case CSSPropertyTextUnderline:
-        case CSSPropertyTextUnderlineColor:
-        case CSSPropertyTextUnderlineMode:
-        case CSSPropertyTextUnderlineStyle:
-        case CSSPropertyTextUnderlineWidth:
             break;
 
         /* Directional properties are resolved by resolveDirectionAwareProperty() before the switch. */
index d20f523..42e14c9 100644 (file)
         },
         "text-line-through": {
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-line-through"
         },
         "text-line-through-color": {
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-line-through-color"
                 "continuous",
                 "skip-white-space"
             ],
+            "status": "removed",
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
             "specification": {
                 "category": "css3-text",
                 "dot-dot-dash",
                 "wave"
             ],
+            "status": "removed",
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
             "specification": {
                 "category": "css3-text",
         },
         "text-line-through-width": {
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-line-through-width"
         },
         "text-overline": {
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline"
         },
         "text-overline-color": {
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-color"
                 "skip-white-space"
             ],
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-mode"
                 "wave"
             ],
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-style"
         },
         "text-overline-width": {
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-width"
         },
         "text-underline": {
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline"
         },
         "text-underline-color": {
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-color"
                 "skip-white-space"
             ],
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-mode"
                 "wave"
             ],
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-style"
         },
         "text-underline-width": {
             "codegen-properties": {
-                "skip-builder": true
+                "skip-codegen": true
             },
+            "status": "removed",
             "specification": {
                 "category": "css3-text",
                 "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-width"
index eb9b8b8..e0440d6 100644 (file)
@@ -846,15 +846,9 @@ bool CSSParserFastPaths::isKeywordPropertyID(CSSPropertyID propertyId)
     case CSSPropertySpeak:
     case CSSPropertyTableLayout:
     case CSSPropertyTextAlign:
-    case CSSPropertyTextLineThroughMode:
-    case CSSPropertyTextLineThroughStyle:
     case CSSPropertyTextOverflow:
-    case CSSPropertyTextOverlineMode:
-    case CSSPropertyTextOverlineStyle:
     case CSSPropertyTextRendering:
     case CSSPropertyTextTransform:
-    case CSSPropertyTextUnderlineMode:
-    case CSSPropertyTextUnderlineStyle:
     case CSSPropertyTransformStyle:
     case CSSPropertyUnicodeBidi:
     case CSSPropertyVisibility: