2010-08-02 Rajiv Makhijani <rajivmakhijani@chromium.org>

        Reviewed by Adam Barth.

        Committed by Dirk Pranke.

        Added missing "if (window.layoutTestController)" check.
        Removed expectation for test case that should now pass with this bugfix.

        https://bugs.webkit.org/show_bug.cgi?id=38705

        * http/tests/security/sandbox-inherit-to-initial-document-2.html:
        * platform/chromium/test_expectations.txt:
2010-08-02  Rajiv Makhijani  <rajivmakhijani@chromium.org>

        Reviewed by Adam Barth.

        Committed by Dirk Pranke.

        Bug 38705 - [v8] chromium fails http/tests/sandbox-inherit-to-initial-document-2
        https://bugs.webkit.org/show_bug.cgi?id=38705

        WebCore::V8Proxy::retrieve(Frame* frame) calls WebCore::ScriptController::canExecuteScripts
        and returns 0 if canExecuteScripts is false. It should return the proxy regardless
        of whether the frame can execute scripts.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::retrieve): Removed canExecuteScripts check.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index e9b08eca9f6ba274956dfdf4b86a71e1a973576d..dd57c1112bd78ef28e12583560a0af221db47b3a 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,17 @@
+2010-08-02  Rajiv Makhijani  <rajivmakhijani@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Committed by Dirk Pranke.
+
+        Added missing "if (window.layoutTestController)" check.
+        Removed expectation for test case that should now pass with this bugfix.
+
+        https://bugs.webkit.org/show_bug.cgi?id=38705
+
+        * http/tests/security/sandbox-inherit-to-initial-document-2.html: 
+        * platform/chromium/test_expectations.txt: 
+
 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
 
         Reviewed by Xan Lopez.

diff --git a/LayoutTests/http/tests/security/sandbox-inherit-to-initial-document-2.html b/LayoutTests/http/tests/security/sandbox-inherit-to-initial-document-2.html
index 4743a33e1b9fbd1d99600a1d1ffb9b9e7bd7c093..cfc952a9633e84682ff9c105722d00b83bcc5612 100644 (file)
--- a/LayoutTests/http/tests/security/sandbox-inherit-to-initial-document-2.html
+++ b/LayoutTests/http/tests/security/sandbox-inherit-to-initial-document-2.html
@@ -35,7 +35,9 @@ function test()
         doc.body.appendChild(scr);
     } else {
         document.getElementById("result").innerHTML = "FAIL: no inner frame";
-        layoutTestController.notifyDone();
+        if (window.layoutTestController) {
+            layoutTestController.notifyDone();
+        }
     }
 }
 </script>

diff --git a/LayoutTests/platform/chromium/test_expectations.txt b/LayoutTests/platform/chromium/test_expectations.txt
index 372dfab267ef691044ebf2fa025d05e4d8fd25af..2fcadad751b9a991e21f7e28fad86d26772f1dda 100644 (file)
--- a/LayoutTests/platform/chromium/test_expectations.txt
+++ b/LayoutTests/platform/chromium/test_expectations.txt
@@ -2739,8 +2739,6 @@ BUG43963 LINUX : fast/forms/searchfield-heights.html = IMAGE+TEXT TEXT
 BUG43960 WIN LINUX : fast/css/input-search-padding.html = IMAGE+TEXT
 BUG43960 MAC : fast/css/input-search-padding.html = IMAGE
 
-BUGWK38705 : http/tests/security/sandbox-inherit-to-initial-document-2.html = TEXT
-
 // WebKit roll 58791:58807
 BUG43319 MAC : transforms/2d/zoom-menulist.html = IMAGE PASS
 BUG43319 MAC : fast/forms/select-empty-option-height.html = TIMEOUT IMAGE PASS

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index aac8d9fcad9e4f5209a2b0d659dad33550593584..d754bd9565f3dd2a366aebcd21b9d61c92ee2d0a 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2010-08-02  Rajiv Makhijani  <rajivmakhijani@chromium.org>
+
+        Reviewed by Adam Barth. 
+
+        Committed by Dirk Pranke.
+
+        Bug 38705 - [v8] chromium fails http/tests/sandbox-inherit-to-initial-document-2
+        https://bugs.webkit.org/show_bug.cgi?id=38705
+
+        WebCore::V8Proxy::retrieve(Frame* frame) calls WebCore::ScriptController::canExecuteScripts
+        and returns 0 if canExecuteScripts is false. It should return the proxy regardless
+        of whether the frame can execute scripts.
+
+        * bindings/v8/V8Proxy.cpp:
+        (WebCore::V8Proxy::retrieve): Removed canExecuteScripts check.
+
 2010-08-02  Brady Eidson  <beidson@apple.com>
 
         Reviewed by Anders Carlsson.

diff --git a/WebCore/bindings/v8/V8Proxy.cpp b/WebCore/bindings/v8/V8Proxy.cpp
index 3f72112b5078af13b2303bc5f02833e2b4ef2c7a..6ac920a96ed7aaa890b8e85997d8ebb899297c9a 100644 (file)
--- a/WebCore/bindings/v8/V8Proxy.cpp
+++ b/WebCore/bindings/v8/V8Proxy.cpp
@@ -627,7 +627,7 @@ V8Proxy* V8Proxy::retrieve(Frame* frame)
 {
     if (!frame)
         return 0;
-    return frame->script()->canExecuteScripts(NotAboutToExecuteScript) ? frame->script()->proxy() : 0;
+    return frame->script()->proxy();
 }
 
 V8Proxy* V8Proxy::retrieve(ScriptExecutionContext* context)