Follow-up fix: results.webkit.org: Color should be the worst result, count should...
authorjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Jul 2019 16:08:15 +0000 (16:08 +0000)
committerjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Jul 2019 16:08:15 +0000 (16:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=200127

Unreviewed follow-up fix.

* resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(Dot.toString): Use self instead of this in render callback.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@247863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js

index c497fe2bf288cf254efddda75325e32fdf25dc92..51cff9960d376c19569ce1058dd336205179a9bd 100644 (file)
@@ -1,3 +1,13 @@
+2019-07-26  Jonathan Bedard  <jbedard@apple.com>
+
+        Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
+        https://bugs.webkit.org/show_bug.cgi?id=200127
+
+        Unreviewed follow-up fix.
+
+        * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+        (Dot.toString): Use self instead of this in render callback.
+
 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
 
         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
index 8b940ff1fa3de54ce8419ae2a08a0d2f7aea7d44..4c484e62717a99e7f9172f7aeed0e1218a889e15 100644 (file)
@@ -204,7 +204,7 @@ class Dot {
 
         return render(`dot ${key}`, `<div class="tag" style="color:var(--boldInverseColor)">
                 ${function() {
-                    let percent = Math.ceil(this.failed / self.count * 100 - .5);
+                    let percent = Math.ceil(self.failed / self.count * 100 - .5);
                     if (percent > 0)
                         return percent;
                     return '<1';