HTMLButtonElement.prototype.click should be HTMLElement.prototype.click
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Sep 2016 23:33:58 +0000 (23:33 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Sep 2016 23:33:58 +0000 (23:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=161874

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-09-12
Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/dom/HTMLButtonElement/click.html

* html/HTMLButtonElement.idl:
Remove the unnecessary 'click' definition. It already exists in HTMLElement.
If this was needed for ObjC code generation on DOMHTMLButtonElement, then
the extra definition is no longer needed now that ObjC bindings have moved.

LayoutTests:

* fast/dom/HTMLButtonElement/click-expected.txt: Added.
* fast/dom/HTMLButtonElement/click.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@205839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/dom/HTMLButtonElement/click-expected.txt [new file with mode: 0644]
LayoutTests/fast/dom/HTMLButtonElement/click.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/html/HTMLButtonElement.idl

index 20dae4f..d66d48f 100644 (file)
@@ -1,3 +1,13 @@
+2016-09-12  Joseph Pecoraro  <pecoraro@apple.com>
+
+        HTMLButtonElement.prototype.click should be HTMLElement.prototype.click
+        https://bugs.webkit.org/show_bug.cgi?id=161874
+
+        Reviewed by Chris Dumez.
+
+        * fast/dom/HTMLButtonElement/click-expected.txt: Added.
+        * fast/dom/HTMLButtonElement/click.html: Added.
+
 2016-09-12  Ryan Haddad  <ryanhaddad@apple.com>
 
         Marking imported/w3c/web-platform-tests/dom/nodes/ProcessingInstruction-escapes-1.xhtml as flaky on mac.
diff --git a/LayoutTests/fast/dom/HTMLButtonElement/click-expected.txt b/LayoutTests/fast/dom/HTMLButtonElement/click-expected.txt
new file mode 100644 (file)
index 0000000..e1d36a9
--- /dev/null
@@ -0,0 +1,10 @@
+Tests HTMLButtonElement's click is just HTMLElement click
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS HTMLElement.prototype.click is HTMLButtonElement.prototype.click
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/fast/dom/HTMLButtonElement/click.html b/LayoutTests/fast/dom/HTMLButtonElement/click.html
new file mode 100644 (file)
index 0000000..7fbdb4c
--- /dev/null
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../../resources/js-test-pre.js"></script>
+<script>
+description("Tests HTMLButtonElement's click is just HTMLElement click");
+shouldBe("HTMLElement.prototype.click", "HTMLButtonElement.prototype.click");
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
index 940204f..17a5d77 100644 (file)
@@ -1,3 +1,17 @@
+2016-09-12  Joseph Pecoraro  <pecoraro@apple.com>
+
+        HTMLButtonElement.prototype.click should be HTMLElement.prototype.click
+        https://bugs.webkit.org/show_bug.cgi?id=161874
+
+        Reviewed by Chris Dumez.
+
+        Test: fast/dom/HTMLButtonElement/click.html
+
+        * html/HTMLButtonElement.idl:
+        Remove the unnecessary 'click' definition. It already exists in HTMLElement.
+        If this was needed for ObjC code generation on DOMHTMLButtonElement, then
+        the extra definition is no longer needed now that ObjC bindings have moved.
+
 2016-09-12  Alex Christensen  <achristensen@webkit.org>
 
         URLParser: Fix relative URLs containing only fragments
index 804c8ef..7e86ca4 100644 (file)
@@ -40,6 +40,4 @@ interface HTMLButtonElement : HTMLElement {
     void setCustomValidity(DOMString? error);
 
     readonly attribute NodeList labels;
-
-    void click();
 };