2009-09-25 Eric Seidel <eric@webkit.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Sep 2009 21:22:50 +0000 (21:22 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Sep 2009 21:22:50 +0000 (21:22 +0000)
        Reviewed by Simon Fraser.

        REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
        https://bugs.webkit.org/show_bug.cgi?id=28624

        No longer skip media tests now that we're disabling hardware compositing instead.
        Add leopard-specific results for 2 tests expected to fail with HW compositing disabled.

        * platform/mac-leopard/Skipped:
        * platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.checksum.
        * platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.png.
        * platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.txt.
        * platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.checksum.
        * platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.png.
        * platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.txt.
2009-09-27  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Darin Adler.

        run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
        https://bugs.webkit.org/show_bug.cgi?id=29771

        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac-leopard/Skipped
LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.png [new file with mode: 0644]
LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.png [new file with mode: 0644]
LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.txt [new file with mode: 0644]
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm

index c885d73..9a29436 100644 (file)
@@ -1,3 +1,21 @@
+2009-09-25  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Simon Fraser.
+
+        REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
+        https://bugs.webkit.org/show_bug.cgi?id=28624
+
+        No longer skip media tests now that we're disabling hardware compositing instead.
+        Add leopard-specific results for 2 tests expected to fail with HW compositing disabled.
+
+        * platform/mac-leopard/Skipped:
+        * platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.checksum.
+        * platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.png.
+        * platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.txt.
+        * platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.checksum.
+        * platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.png.
+        * platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.txt.
+
 2009-09-28  Shinichiro Hamaji  <hamaji@chromium.org>
 
         Reviewed by Darin Adler.
index 5c1c0d0..0f6caf2 100644 (file)
@@ -14,8 +14,3 @@ platform/mac/accessibility/table-multi-bodies.html
 # Tests of font features not supported by ATSUI
 platform/mac/fast/text/myanmar-shaping.html
 platform/mac/fast/text/thai-combining-mark-positioning.html
-
-# Intermittent crashes/hangs caused by <rdar://problem/7228836>
-# https://bugs.webkit.org/show_bug.cgi?id=28845
-media/controls-after-reload.html
-media/video-size-intrinsic-scale.html
diff --git a/LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.checksum b/LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.checksum
new file mode 100644 (file)
index 0000000..e212030
--- /dev/null
@@ -0,0 +1 @@
+7ac44bfeb28692ffe51680cd6bb1c20c
\ No newline at end of file
diff --git a/LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.png b/LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.png
new file mode 100644 (file)
index 0000000..382506d
Binary files /dev/null and b/LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.png differ
diff --git a/LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.txt b/LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.txt
new file mode 100644 (file)
index 0000000..aacc4a2
--- /dev/null
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x576
+      RenderBlock {P} at (0,0) size 784x36 [color=#008000]
+        RenderText {#text} at (0,0) size 778x36
+          text run at (0,0) width 778: "This text should be green. If running in a build of WebKit with 3d transforms, it will appear red (and this should not happen"
+          text run at (0,18) width 164: "while 3d is not supported)"
diff --git a/LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.checksum b/LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.checksum
new file mode 100644 (file)
index 0000000..ca551dd
--- /dev/null
@@ -0,0 +1 @@
+fc75f49470969d94d62523dc055eb6d7
\ No newline at end of file
diff --git a/LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.png b/LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.png
new file mode 100644 (file)
index 0000000..f1af37f
Binary files /dev/null and b/LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.png differ
diff --git a/LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.txt b/LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.txt
new file mode 100644 (file)
index 0000000..8541e23
--- /dev/null
@@ -0,0 +1,8 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x576
+      RenderBlock {P} at (0,0) size 784x18 [color=#008000]
+        RenderText {#text} at (0,0) size 626x18
+          text run at (0,0) width 626: "This text should be green if running in a build of WebKit with support for 2d but not 3d transforms."
index eb28c3f..67aeb4d 100644 (file)
 
 2009-09-25  Eric Seidel  <eric@webkit.org>
 
+        Reviewed by Simon Fraser.
+
+        REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
+        https://bugs.webkit.org/show_bug.cgi?id=28624
+
+        Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (resetDefaultsToConsistentValues):
+
+2009-09-25  Eric Seidel  <eric@webkit.org>
+
         Reviewed by Adam Barth.
 
         commit-queue should auto-retry patches which fail to commit due to out of date files
index e77587f..99cfae8 100644 (file)
@@ -425,6 +425,20 @@ static void resetDefaultsToConsistentValues()
     // So, turn it off for now, but we might want to turn it back on some day.
     [preferences setUsesPageCache:NO];
 
+#if defined(BUILDING_ON_LEOPARD)
+    // Disable hardware composititing to avoid timeouts and crashes from buggy CoreVideo teardown code.
+    // https://bugs.webkit.org/show_bug.cgi?id=28845 and rdar://problem/7228836
+    SInt32 qtVersion;
+    OSErr err = Gestalt(gestaltQuickTimeVersion, &qtVersion);
+    assert(err == noErr);
+    // Bug 7228836 exists in at least 7.6.3 and 7.6.4, hopefully it will be fixed in 7.6.5.
+    // FIXME: Once we know the exact versions of QuickTime affected, we can update this check.
+    if (qtVersion <= 0x07640000)
+        [preferences setAcceleratedCompositingEnabled:NO];
+    else
+#endif
+        [preferences setAcceleratedCompositingEnabled:YES];
+
     [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookieAcceptPolicy:NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain];
 }