Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691
* fast/repaint/slider-thumb-drag-release.html: Added.
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691
Test: fast/repaint/slider-thumb-drag-release.html
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure
that the thumb is repainted.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
+ https://bugs.webkit.org/show_bug.cgi?id=53691
+
+ * fast/repaint/slider-thumb-drag-release.html: Added.
+ * platform/mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
+ * platform/mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
+ * platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
+
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Update mac baselines. They pixel-rotted.
--- /dev/null
+<html>
+<head>
+<script>
+
+// Tests that the slider thumb is repainted correctly when the mouse that's
+// dragging it releases outside of the track. The result should be a thumb
+// painted in the released state.
+
+var ARBITRARY_DELTA = 50;
+
+function clickAndDragDiagonally(element)
+{
+ if (!window.eventSender)
+ return;
+
+ var maxX = element.offsetLeft + element.offsetWidth;
+ var x = maxX / 2;
+ var y = element.offsetTop + element.offsetHeight / 2;
+ eventSender.mouseMoveTo(x, y);
+ eventSender.mouseDown();
+ eventSender.mouseMoveTo(maxX, y + ARBITRARY_DELTA);
+ eventSender.mouseUp();
+}
+
+function runTest()
+{
+ clickAndDragDiagonally(document.getElementById('slider'));
+}
+
+</script>
+</head>
+<body onload="runTest()">
+<input id="slider" type="range" value="0">
+</body>
+</html>
--- /dev/null
+144924c0a226d7d46fd200572c130ea4
\ No newline at end of file
--- /dev/null
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderSlider {INPUT} at (2,2) size 129x15 [bgcolor=#FFFFFF]
+ RenderBlock {DIV} at (114,0) size 15x15
+ RenderText {#text} at (0,0) size 0x0
+2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
+ https://bugs.webkit.org/show_bug.cgi?id=53691
+
+ Test: fast/repaint/slider-thumb-drag-release.html
+
+ * html/shadow/SliderThumbElement.cpp:
+ (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure
+ that the thumb is repainted.
+
2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
if (Frame* frame = document()->frame())
frame->eventHandler()->setCapturingMouseEventsNode(0);
m_inDragMode = false;
+ if (renderer())
+ renderer()->setNeedsLayout(true);
}
void SliderThumbElement::defaultEventHandler(Event* event)