2011-01-12 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        show shared lines on both sides in code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52308

        We were appending the same DOM node twice. Instead, make
        the from column a clone of the original node.

        * code-review.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index 75942ab6fb306e8e29448998813b096cbf4c1c07..6e2ee04aec41948fa4133b10e1f583e0052cc917 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,15 @@
+2011-01-12  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        show shared lines on both sides in code review tool
+        https://bugs.webkit.org/show_bug.cgi?id=52308
+
+        We were appending the same DOM node twice. Instead, make
+        the from column a clone of the original node.
+
+        * code-review.js:
+
 2011-01-12  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index 6836be2db727b57c08c2bc9755331d1598b23245..b0786f703153ec8edffeddaf028828001b251797 100644 (file)
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -842,9 +842,13 @@
     var to_class = '';
     var from_attributes = '';
     var to_attributes = '';
-    var from_contents = contents;
+    // Clone the contents so we have two copies we can put back in the DOM.
+    var from_contents = contents.clone(true);
     var to_contents = contents;
 
+    var container_class = 'LineContainer';
+    var container_attributes = '';
+
     if (from && !to) { // This is a remove line.
       from_class = classNames;
       from_attributes = attributes;
@@ -853,11 +857,7 @@
       to_class = classNames;
       to_attributes = attributes;
       from_contents = '';
-    }
-
-    var container_class = 'LineContainer';
-    var container_attributes = '';
-    if (!to_attributes && !from_attributes) {
+    } else {
       container_attributes = attributes;
       container_class += ' Line ' + classNames;
     }