Reviewed by Simon Fraser.
<rdar://problem/
7414396> Leopard & Tiger: Support closed caption in <video> element
* css/mediaControls.css:
Define closed caption toggle button.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::updateControls):
Create closed caption toggle button in display order.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):
Don't require MediaControllerThemeQuickTime theme for captions toggle button.
No need to check if the movie has video, a closed captions track is a video
track.
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7414396> Leopard & Tiger: Support closed caption in <video> element
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7414396> Leopard & Tiger: Support closed caption in <video> element
Remove closed captions test from skipped list.
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2009-11-20 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
+
+ Remove closed captions test from skipped list.
+
+ * platform/mac-leopard/Skipped:
+ * platform/mac-tiger/Skipped:
+
2009-11-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
media/media-fullscreen-inline.html
media/media-fullscreen-not-in-document.html
-# Requires media engine closed caption support
-media/media-captions.html
-
# Tests of accessibility functionality not supported on Leopard
accessibility/aria-list-and-listitem.html
media/media-fullscreen-inline.html
media/media-fullscreen-not-in-document.html
-# Requires media engine closed caption support
-media/media-captions.html
-
# Tests of accessibility functionality not supported on Tiger
accessibility/aria-list-and-listitem.html
+2009-11-20 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
+
+ * css/mediaControls.css:
+ Define closed caption toggle button.
+
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::updateControls):
+ Create closed caption toggle button in display order.
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
+ Don't require MediaControllerThemeQuickTime theme for captions toggle button.
+ No need to check if the movie has video, a closed captions track is a video
+ track.
+
2009-11-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
}
audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button {
- display: none;
+ -webkit-appearance: media-toggle-closed-captions-button;
+ display: -webkit-box;
+ width: 16px;
+ height: 16px;
}
createRewindButton();
createPlayButton();
createReturnToRealtimeButton();
- createToggleClosedCaptionsButton();
createStatusDisplay();
createTimelineContainer();
if (m_timelineContainer) {
}
createSeekBackButton();
createSeekForwardButton();
+ createToggleClosedCaptionsButton();
createFullscreenButton();
createMuteButton();
createVolumeSliderContainer();
if (part == MediaToggleClosedCaptionsButtonPart) {
// We rely on QTKit to render captions so don't enable the button unless it will be able to do so.
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(element);
- if (mediaControllerTheme() != MediaControllerThemeQuickTime || !element->hasTagName(videoTag) || !mediaElement->hasVideo())
+ if (!element->hasTagName(videoTag))
return false;
}
+2009-11-20 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
+
+ * WebKitSystemInterface.h:
+ * libWebKitSystemInterfaceLeopard.a:
+ * libWebKitSystemInterfaceSnowLeopard.a:
+ * libWebKitSystemInterfaceTiger.a:
+
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
WKMediaUIPartSliderThumb,
WKMediaUIPartRewindButton,
WKMediaUIPartSeekToRealtimeButton,
- WKMediaUIPartToggleClosedCaptionsButton,
+ WKMediaUIPartShowClosedCaptionsButton,
+ WKMediaUIPartHideClosedCaptionsButton,
WKMediaUIPartUnMuteButton,
WKMediaUIPartPauseButton,
WKMediaUIPartBackground,