Test freshness page should use build time instead of commit time to determine the...
authordewei_zhu@apple.com <dewei_zhu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Dec 2017 22:55:43 +0000 (22:55 +0000)
committerdewei_zhu@apple.com <dewei_zhu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Dec 2017 22:55:43 +0000 (22:55 +0000)
https://bugs.webkit.org/show_bug.cgi?id=181156

Reviewed by Alexey Proskuryakov.

Build time is a better data point freshness indicator. Test freshness page is designed to highlight test failures.
Using commit time will result in including the compiling and test running time which does not quite match the
definition of data point fresshness.

* public/v3/pages/test-freshness-page.js:
(TestFreshnessPage.prototype._fetchTestResults): Use build time instead of commit time.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@226303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js

index 7fcb997c2b2a624b901a5c5255e04e5e149c1e8b..f66c43788633cfa889e882fa648e410445e640da 100644 (file)
@@ -1,3 +1,17 @@
+2017-12-26  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Test freshness page should use build time instead of commit time to determine the freshness of the data point.
+        https://bugs.webkit.org/show_bug.cgi?id=181156
+
+        Reviewed by Alexey Proskuryakov.
+
+        Build time is a better data point freshness indicator. Test freshness page is designed to highlight test failures.
+        Using commit time will result in including the compiling and test running time which does not quite match the
+        definition of data point fresshness.
+
+        * public/v3/pages/test-freshness-page.js:
+        (TestFreshnessPage.prototype._fetchTestResults): Use build time instead of commit time.
+
 2017-12-21  Dewei Zhu  <dewei_zhu@apple.com>
 
         Add UI for A/B testing on owned commits.
index 781c3f28a8aa2e81e34d80e19fae1ea8792991e6..bd50697bc272c1e55614193b8f549c22d6543eb0 100644 (file)
@@ -72,7 +72,7 @@ class TestFreshnessPage extends PageWithHeading {
 
                     let timeForLastDataPoint = startTime;
                     if (currentTimeSeries.lastPoint())
-                        timeForLastDataPoint = currentTimeSeries.lastPoint().time;
+                        timeForLastDataPoint = currentTimeSeries.lastPoint().build().buildTime();
 
                     lastDataPointByMetric.set(metric, {time: timeForLastDataPoint, hasCurrentDataPoint: !!currentTimeSeries.lastPoint()});
                     this.enqueueToRender();