2016-02-11 Ryosuke Niwa <rniwa@webkit.org>
+ AnalysisResultsViewer never uses this._smallerIsBetter
+ https://bugs.webkit.org/show_bug.cgi?id=154134
+
+ Reviewed by Chris Dumez.
+
+ Removed the unused instance variable _smallerIsBetter from AnalysisResultsViewer and TestGroupStackingBlock.
+
+ * public/v3/components/analysis-results-viewer.js:
+ (AnalysisResultsViewer): Removed the unused _smallerIsBetter.
+ (AnalysisResultsViewer.prototype.setSmallerIsBetter): Deleted.
+ (AnalysisResultsViewer.prototype.buildRowGroups):
+ (AnalysisResultsViewer.TestGroupStackingBlock): Removed the unused _smallerIsBetter.
+ * public/v3/pages/analysis-task-page.js:
+ (AnalysisTaskPage.prototype._didFetchTask):
+
+2016-02-11 Ryosuke Niwa <rniwa@webkit.org>
+
Build fix after r196440.
* public/v3/models/test-group.js:
constructor()
{
super('analysis-results-viewer');
- this._smallerIsBetter = false;
this._startPoint = null;
this._endPoint = null;
this._testGroups = null;
setTestGroupCallback(callback) { this._testGroupCallback = callback; }
- setSmallerIsBetter(smallerIsBetter)
- {
- this._smallerIsBetter = smallerIsBetter;
- this._shouldRenderTable = true;
- }
-
setCurrentTestGroup(testGroup)
{
this._currentTestGroup = testGroup;
var block = testGroupLayoutMap.get(testGroup);
if (!block) {
block = new AnalysisResultsViewer.TestGroupStackingBlock(
- testGroup, self._smallerIsBetter, self._classForTestGroup(testGroup), self._openStackingBlock.bind(self, testGroup));
+ testGroup, self._classForTestGroup(testGroup), self._openStackingBlock.bind(self, testGroup));
testGroupLayoutMap.set(testGroup, block);
}
block.addRowIndex(entry, rowIndex);
}
AnalysisResultsViewer.TestGroupStackingBlock = class {
- constructor(testGroup, smallerIsBetter, className, callback)
+ constructor(testGroup, className, callback)
{
this._testGroup = testGroup;
- this._smallerIsBetter = smallerIsBetter;
this._rootSetIndexRowIndexMap = [];
this._className = className;
this._label = null;
var formatter = metric.makeFormatter(4);
this._analysisResultsViewer.setValueFormatter(formatter);
- this._analysisResultsViewer.setSmallerIsBetter(metric.isSmallerBetter());
this._testGroupResultsTable.setValueFormatter(formatter);
this._chartPane.configure(platform.id(), metric.id());