AnalysisResultsViewer never uses this._smallerIsBetter
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Feb 2016 22:52:40 +0000 (22:52 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Feb 2016 22:52:40 +0000 (22:52 +0000)
https://bugs.webkit.org/show_bug.cgi?id=154134

Reviewed by Chris Dumez.

Removed the unused instance variable _smallerIsBetter from AnalysisResultsViewer and TestGroupStackingBlock.

* public/v3/components/analysis-results-viewer.js:
(AnalysisResultsViewer): Removed the unused _smallerIsBetter.
(AnalysisResultsViewer.prototype.setSmallerIsBetter): Deleted.
(AnalysisResultsViewer.prototype.buildRowGroups):
(AnalysisResultsViewer.TestGroupStackingBlock): Removed the unused _smallerIsBetter.
* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype._didFetchTask):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@196443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js
Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js

index 1554682..a1c39f0 100644 (file)
@@ -1,5 +1,22 @@
 2016-02-11  Ryosuke Niwa  <rniwa@webkit.org>
 
+        AnalysisResultsViewer never uses this._smallerIsBetter
+        https://bugs.webkit.org/show_bug.cgi?id=154134
+
+        Reviewed by Chris Dumez.
+
+        Removed the unused instance variable _smallerIsBetter from AnalysisResultsViewer and TestGroupStackingBlock.
+
+        * public/v3/components/analysis-results-viewer.js:
+        (AnalysisResultsViewer): Removed the unused _smallerIsBetter.
+        (AnalysisResultsViewer.prototype.setSmallerIsBetter): Deleted.
+        (AnalysisResultsViewer.prototype.buildRowGroups):
+        (AnalysisResultsViewer.TestGroupStackingBlock): Removed the unused _smallerIsBetter.
+        * public/v3/pages/analysis-task-page.js:
+        (AnalysisTaskPage.prototype._didFetchTask):
+
+2016-02-11  Ryosuke Niwa  <rniwa@webkit.org>
+
         Build fix after r196440.
 
         * public/v3/models/test-group.js:
index bdefa4e..1174f76 100644 (file)
@@ -3,7 +3,6 @@ class AnalysisResultsViewer extends ResultsTable {
     constructor()
     {
         super('analysis-results-viewer');
-        this._smallerIsBetter = false;
         this._startPoint = null;
         this._endPoint = null;
         this._testGroups = null;
@@ -16,12 +15,6 @@ class AnalysisResultsViewer extends ResultsTable {
 
     setTestGroupCallback(callback) { this._testGroupCallback = callback; }
 
-    setSmallerIsBetter(smallerIsBetter)
-    {
-        this._smallerIsBetter = smallerIsBetter;
-        this._shouldRenderTable = true;
-    }
-
     setCurrentTestGroup(testGroup)
     {
         this._currentTestGroup = testGroup;
@@ -104,7 +97,7 @@ class AnalysisResultsViewer extends ResultsTable {
                 var block = testGroupLayoutMap.get(testGroup);
                 if (!block) {
                     block = new AnalysisResultsViewer.TestGroupStackingBlock(
-                        testGroup, self._smallerIsBetter, self._classForTestGroup(testGroup), self._openStackingBlock.bind(self, testGroup));
+                        testGroup, self._classForTestGroup(testGroup), self._openStackingBlock.bind(self, testGroup));
                     testGroupLayoutMap.set(testGroup, block);
                 }
                 block.addRowIndex(entry, rowIndex);
@@ -308,10 +301,9 @@ AnalysisResultsViewer.RootSetInTestGroup = class {
 }
 
 AnalysisResultsViewer.TestGroupStackingBlock = class {
-    constructor(testGroup, smallerIsBetter, className, callback)
+    constructor(testGroup, className, callback)
     {
         this._testGroup = testGroup;
-        this._smallerIsBetter = smallerIsBetter;
         this._rootSetIndexRowIndexMap = [];
         this._className = className;
         this._label = null;
index ac5d5b2..c2f7a29 100644 (file)
@@ -68,7 +68,6 @@ class AnalysisTaskPage extends PageWithHeading {
 
         var formatter = metric.makeFormatter(4);
         this._analysisResultsViewer.setValueFormatter(formatter);
-        this._analysisResultsViewer.setSmallerIsBetter(metric.isSmallerBetter());
         this._testGroupResultsTable.setValueFormatter(formatter);
 
         this._chartPane.configure(platform.id(), metric.id());