Fix build errors and warnings for non-unified JSCOnly
authorross.kirsling@sony.com <ross.kirsling@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 9 May 2020 22:40:13 +0000 (22:40 +0000)
committerross.kirsling@sony.com <ross.kirsling@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 9 May 2020 22:40:13 +0000 (22:40 +0000)
https://bugs.webkit.org/show_bug.cgi?id=211655

Reviewed by Darin Adler and Yusuke Suzuki.

* bytecode/BytecodeDumper.cpp:
(JSC::isConstantRegisterIndex): Deleted.
Remove unused function.

* llint/LLIntEntrypoint.cpp:
* llint/LLIntThunks.cpp:
* llint/LLIntThunks.h:
* runtime/AggregateErrorConstructor.cpp:
* runtime/AggregateErrorPrototype.cpp:
* wasm/js/WebAssemblyFunction.cpp:
Fix includes.

* tools/JSDollarVM.cpp:
Deal with "unused constant" warnings for needsDestruction.

* wasm/WasmLLIntPlan.cpp:
* wasm/WasmSignature.cpp:
Remove unused constants.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@261441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/bytecode/BytecodeDumper.cpp
Source/JavaScriptCore/llint/LLIntEntrypoint.cpp
Source/JavaScriptCore/llint/LLIntThunks.cpp
Source/JavaScriptCore/llint/LLIntThunks.h
Source/JavaScriptCore/runtime/AggregateErrorConstructor.cpp
Source/JavaScriptCore/runtime/AggregateErrorPrototype.cpp
Source/JavaScriptCore/tools/JSDollarVM.cpp
Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp
Source/JavaScriptCore/wasm/WasmSignature.cpp
Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp

index f01b431..e12924a 100644 (file)
@@ -1,3 +1,29 @@
+2020-05-09  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Fix build errors and warnings for non-unified JSCOnly
+        https://bugs.webkit.org/show_bug.cgi?id=211655
+
+        Reviewed by Darin Adler and Yusuke Suzuki.
+
+        * bytecode/BytecodeDumper.cpp:
+        (JSC::isConstantRegisterIndex): Deleted.
+        Remove unused function.
+
+        * llint/LLIntEntrypoint.cpp:
+        * llint/LLIntThunks.cpp:
+        * llint/LLIntThunks.h:
+        * runtime/AggregateErrorConstructor.cpp:
+        * runtime/AggregateErrorPrototype.cpp:
+        * wasm/js/WebAssemblyFunction.cpp:
+        Fix includes.
+
+        * tools/JSDollarVM.cpp:
+        Deal with "unused constant" warnings for needsDestruction.
+
+        * wasm/WasmLLIntPlan.cpp:
+        * wasm/WasmSignature.cpp:
+        Remove unused constants.
+
 2020-05-08  Darin Adler  <darin@apple.com>
 
         Streamline MarkupAccumulator to improve efficiency a bit
index d91062c..f456b0b 100644 (file)
 
 namespace JSC {
 
-static ALWAYS_INLINE bool isConstantRegisterIndex(int index)
-{
-    return index >= FirstConstantRegisterIndex;
-}
-
 void BytecodeDumperBase::printLocationAndOp(InstructionStream::Offset location, const char* op)
 {
     m_currentLocation = location;
index 8b74678..6751930 100644 (file)
@@ -35,7 +35,6 @@
 #include "LowLevelInterpreter.h"
 #include "MaxFrameExtentForSlowPathCall.h"
 #include "StackAlignment.h"
-#include "VM.h"
 
 namespace JSC { namespace LLInt {
 
index 8e11b82..79e50f1 100644 (file)
@@ -38,7 +38,6 @@
 #include "LowLevelInterpreter.h"
 #include "ProtoCallFrame.h"
 #include "StackAlignment.h"
-#include "VM.h"
 #include "WasmCallingConvention.h"
 #include "WasmContextInlines.h"
 #include <wtf/NeverDestroyed.h>
index 28b3457..781e32d 100644 (file)
 #pragma once
 
 #include "MacroAssemblerCodeRef.h"
+#include "VM.h"
 #include <wtf/Scope.h>
 
 namespace JSC {
 
-class VM;
 struct ProtoCallFrame;
 typedef int64_t EncodedJSValue;
 
index bf013a8..00f0af9 100644 (file)
@@ -31,8 +31,9 @@
 #include "ExceptionScope.h"
 #include "GCAssertions.h"
 #include "JSCJSValueInlines.h"
-#include "JSCellInlines.h"
+#include "JSGlobalObjectInlines.h"
 #include "RuntimeType.h"
+#include "StructureInlines.h"
 #include "VMInlines.h"
 
 namespace JSC {
index 639aa3e..f47ecdf 100644 (file)
 
 #include "AggregateError.h"
 #include "CallFrame.h"
-#include "Error.h"
 #include "IdentifierInlines.h"
 #include "JSCJSValueInlines.h"
 #include "JSCell.h"
-#include "JSCellInlines.h"
 #include "JSGlobalObjectInlines.h"
-#include "JSObject.h"
+#include "JSObjectInlines.h"
 #include "ThrowScope.h"
 #include "VMInlines.h"
 #include <wtf/Locker.h>
index 2a838aa..f9b3271 100644 (file)
@@ -324,7 +324,6 @@ public:
     }
 
     typedef JSNonFinalObject Base;
-    static constexpr bool needsDestruction = false;
     template<typename CellType, SubspaceAccess>
     static CompleteSubspace* subspaceFor(VM& vm)
     {
@@ -535,6 +534,10 @@ public:
     typedef JSArray Base;
     static constexpr unsigned StructureFlags = Base::StructureFlags | OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | OverridesGetPropertyNames;
 
+IGNORE_WARNINGS_BEGIN("unused-const-variable")
+    static constexpr bool needsDestruction = false;
+IGNORE_WARNINGS_END
+
     template<typename CellType, SubspaceAccess>
     static CompleteSubspace* subspaceFor(VM& vm)
     {
@@ -560,8 +563,6 @@ public:
         static_cast<RuntimeArray*>(cell)->RuntimeArray::~RuntimeArray();
     }
 
-    static constexpr bool needsDestruction = false;
-
     static bool getOwnPropertySlot(JSObject* object, JSGlobalObject* globalObject, PropertyName propertyName, PropertySlot& slot)
     {
         DollarVMAssertScope assertScope;
index e7b9d5c..a3d4f61 100644 (file)
 
 namespace JSC { namespace Wasm {
 
-namespace WasmLLIntPlanInternal {
-static const bool verbose = false;
-}
-
 LLIntPlan::LLIntPlan(Context* context, Vector<uint8_t>&& source, AsyncWork work, CompletionTask&& task)
     : Base(context, WTFMove(source), work, WTFMove(task))
 {
index d6a1a49..ec97198 100644 (file)
 
 namespace JSC { namespace Wasm {
 
-namespace {
-namespace WasmSignatureInternal {
-static constexpr bool verbose = false;
-}
-}
-
 SignatureInformation* SignatureInformation::theOne { nullptr };
 std::once_flag SignatureInformation::signatureInformationFlag;
 
index 16ecdaa..7ca4e83 100644 (file)
@@ -41,7 +41,6 @@
 #include "LLIntThunks.h"
 #include "LinkBuffer.h"
 #include "ProtoCallFrameInlines.h"
-#include "VM.h"
 #include "WasmCallee.h"
 #include "WasmCallingConvention.h"
 #include "WasmContextInlines.h"