JavaScriptCore:
authorggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 May 2008 19:34:20 +0000 (19:34 +0000)
committerggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 May 2008 19:34:20 +0000 (19:34 +0000)
2008-05-23  Geoffrey Garen  <ggaren@apple.com>

        Rolled out r34073 because it caused lots of layout test crashes.

LayoutTests:

2008-05-23  Geoffrey Garen  <ggaren@apple.com>

        Rolled out r34073 because it caused lots of layout test crashes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore/ChangeLog
JavaScriptCore/VM/CodeGenerator.cpp
LayoutTests/ChangeLog
LayoutTests/fast/js/function-redefinition-expected.txt [deleted file]
LayoutTests/fast/js/function-redefinition.html [deleted file]

index 887cfa052a4b7fd5e9f52ec4d23dabf16934c35a..76392434c1877b83e5686f040cf4d33d405d435d 100644 (file)
@@ -1,3 +1,7 @@
+2008-05-23  Geoffrey Garen  <ggaren@apple.com>
+
+        Rolled out r34073 because it caused lots of layout test crashes.
+
 2008-05-23  Geoffrey Garen  <ggaren@apple.com>
 
         Rolled out r34085 because it measured as a 7.6% performance regression.
         * kjs/object.cpp:
         (KJS::JSObject::call):
 
-2008-05-23  Maciej Stachowiak  <mjs@apple.com>
-
-        Reviewed by Oliver.
-        
-        - fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
-
-        * VM/CodeGenerator.cpp:
-        (KJS::CodeGenerator::CodeGenerator): Delete any existing
-        properties before creating the function (this should really be
-        done at execution time not codegen time).
-
 2008-05-16  Alp Toker  <alp@nuanti.com>
 
         Build fix for gcc 3. Default constructor required in ExecState,
index d622b2dc116646880b20f60a75a486404ab303a1..8bf299c795dd6054d4b4f1b11537944197d339d5 100644 (file)
@@ -206,10 +206,6 @@ CodeGenerator::CodeGenerator(ProgramNode* programNode, const Debugger* debugger,
     if (canCreateVariables) {
         for (size_t i = 0; i < functionStack.size(); ++i) {
             FuncDeclNode* funcDecl = functionStack[i];
-            if (globalObject->hasProperty(exec, funcDecl->m_ident) || symbolTable->contains(funcDecl->m_ident.ustring().rep())) {
-                globalObject->putWithAttributes(exec, funcDecl->m_ident, jsUndefined(), 0);
-                globalObject->deleteProperty(exec, funcDecl->m_ident);
-            }
             emitNewFunction(addVar(funcDecl->m_ident, false), funcDecl);
         }
         
index f78ddcb6065057565a31e0a7a4ee9a05ca69d7db..b40ee08cd5874f0e7e89903c3d4a10e372525ff5 100644 (file)
@@ -1,11 +1,6 @@
-2008-05-23  Maciej Stachowiak  <mjs@apple.com>
+2008-05-23  Geoffrey Garen  <ggaren@apple.com>
 
-        Reviewed by Oliver.
-        
-        - test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
-
-        * fast/js/function-redefinition-expected.txt: Added.
-        * fast/js/function-redefinition.html: Added.
+        Rolled out r34073 because it caused lots of layout test crashes.
 
 2008-05-23  Mark Rowe  <mrowe@apple.com>
 
diff --git a/LayoutTests/fast/js/function-redefinition-expected.txt b/LayoutTests/fast/js/function-redefinition-expected.txt
deleted file mode 100644 (file)
index 359a1fe..0000000
+++ /dev/null
@@ -1,8 +0,0 @@
-PASS typeof test1 == 'function' is true
-PASS typeof test2 == 'function' is true
-PASS typeof test3 == 'function' is true
-PASS test3() is "SUCCESS"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
diff --git a/LayoutTests/fast/js/function-redefinition.html b/LayoutTests/fast/js/function-redefinition.html
deleted file mode 100644 (file)
index 9d610bc..0000000
+++ /dev/null
@@ -1,38 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<link rel="stylesheet" href="resources/js-test-style.css">
-<script src="resources/js-test-pre.js"></script>
-</head>
-<body>
-<p id="description"></p>
-<div id="console"></div>
-<script>
-test1 = "FAIL";
-var test2 = "FAIL"
-function test3() {
-     return "FAIL";
-}
-</script> 
-<script>
-function test1() { 
-    return "SUCCESS";
-}
-
-function test2() { 
-    return "SUCCESS";
-}
-
-function test3() { 
-    return "SUCCESS";
-}
-
-shouldBeTrue("typeof test1 == 'function'");
-shouldBeTrue("typeof test2 == 'function'");
-shouldBeTrue("typeof test3 == 'function'");
-shouldBe("test3()", '"SUCCESS"');
-var successfullyParsed = true; 
-</script>
-<script src="resources/js-test-post.js"></script>
-</body>
-</html>