Enable CSS grid layout LayoutTests on platform Mac
authortony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Jun 2012 20:37:36 +0000 (20:37 +0000)
committertony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Jun 2012 20:37:36 +0000 (20:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=90113

Reviewed by Ojan Vafai.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues): Reset the value to NO between tests.

LayoutTests:

Use 1 instead of true, since that's what WebView.mm expects.

* fast/css-grid-layout/containing-block-grids.html:
* fast/css-grid-layout/display-grid-set-get.html:
* fast/css-grid-layout/floating-empty-grids.html:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/grid-columns-rows-get-set.html:
* fast/css-grid-layout/grid-item-column-row-get-set.html:
* platform/mac/Skipped: Unskip tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/css-grid-layout/containing-block-grids.html
LayoutTests/fast/css-grid-layout/display-grid-set-get.html
LayoutTests/fast/css-grid-layout/floating-empty-grids.html
LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple.html
LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set.html
LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html
LayoutTests/platform/mac/Skipped
Tools/ChangeLog
Tools/DumpRenderTree/mac/DumpRenderTree.mm

index f4d8ceaca551afcc5df6889b1483d12a226b0190..3f4fb1513ff9a292bb015626adfce1b9fe11e0f2 100644 (file)
@@ -1,3 +1,20 @@
+2012-06-28  Tony Chang  <tony@chromium.org>
+
+        Enable CSS grid layout LayoutTests on platform Mac
+        https://bugs.webkit.org/show_bug.cgi?id=90113
+
+        Reviewed by Ojan Vafai.
+
+        Use 1 instead of true, since that's what WebView.mm expects.
+
+        * fast/css-grid-layout/containing-block-grids.html:
+        * fast/css-grid-layout/display-grid-set-get.html:
+        * fast/css-grid-layout/floating-empty-grids.html:
+        * fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
+        * fast/css-grid-layout/grid-columns-rows-get-set.html:
+        * fast/css-grid-layout/grid-item-column-row-get-set.html:
+        * platform/mac/Skipped: Unskip tests.
+
 2012-06-28  Stephen White  <senorblanco@chromium.org>
 
         Unreviewed gardening.
index 23850a4095566612854da40f044e0f726c9031fb..a6ae771a385e5b67f273050908ade8db12522f4c 100644 (file)
@@ -3,7 +3,7 @@
 <head>
     <script>
         if (window.testRunner)
-            testRunner.overridePreference("WebKitCSSGridLayoutEnabled", true);
+            testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
     </script>
     <style>
         div { width: 100px; height: 100px; }
index 3f994b894fb304fb4295701ae43fca18cfc25e9b..f3ac6464a80b02be7ce10338fa652d6eae842665 100755 (executable)
@@ -3,7 +3,7 @@
 <head>
 <script>
 if (window.testRunner)
-    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", true);
+    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
 </script>
 <style>
 .grid { display: -webkit-grid; }
index a6e7d137b147e4d45f9ef2c8e8dba74808fb23b7..ae6ac71014951b3c21b774890143f39f4baee9e8 100644 (file)
@@ -3,7 +3,7 @@
 <head>
     <script>
         if (window.testRunner)
-            testRunner.overridePreference("WebKitCSSGridLayoutEnabled", true);
+            testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
     </script>
     <style>
         span { width: 100px; height: 100px; }
index f6107352509124fe70889961827156ccf634a478..258b48e290dba7e4dfde70c99d4c619c6e383f0d 100755 (executable)
@@ -3,7 +3,7 @@
 <head>
 <script>
 if (window.testRunner)
-    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", true);
+    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
 </script>
 <style>
 .gridWithFixed {
index 618e36d1bb9ed9688d4c06f7128c68fd234220d5..2d49393a742c154186a65e5faeed254f93f7605a 100755 (executable)
@@ -3,7 +3,7 @@
 <head>
 <script>
 if (window.testRunner)
-    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", true);
+    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
 </script>
 <style>
 .grid {
index 81fbb4572eecb10fa3bdc8523b4bb006807a7011..77f3fe6fda71a01ac9b4891a0fbf491da95b51fd 100755 (executable)
@@ -3,7 +3,7 @@
 <head>
 <script>
 if (window.testRunner)
-    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", true);
+    testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
 </script>
 <style>
 .gridItemWithPositiveInteger {
index 202463aee3a1d2ce91e8c724b5a67bbe96aca4d4..c870915db3b01144b24411a4a22815bc742b1a77 100644 (file)
@@ -450,9 +450,6 @@ http/tests/media/video-cross-site.html
 # https://bugs.webkit.org/show_bug.cgi?id=63169
 webarchive/loading/mainresource-null-mimetype-crash.html
 
-# CSS Grid Layout is not yet enabled. http://webkit.org/b/60731
-fast/css-grid-layout
-
 # <style scoped> is not yet enabled. http://webkit.org/b/49142
 fast/css/style-scoped
 # CSS Regions tests for region styling and scoped styles
index e365c53305e956f849b2ea6d143e8297abf4b8ad..961d2678f10c7c0401f57b52a22f9f3ac4ac942b 100644 (file)
@@ -1,3 +1,13 @@
+2012-06-28  Tony Chang  <tony@chromium.org>
+
+        Enable CSS grid layout LayoutTests on platform Mac
+        https://bugs.webkit.org/show_bug.cgi?id=90113
+
+        Reviewed by Ojan Vafai.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (resetDefaultsToConsistentValues): Reset the value to NO between tests.
+
 2012-06-28  Mike Fenton  <mifenton@rim.com>
 
         [BlackBerry] Add watchlist options for Blackberry and editing.
index 271683f7a822758f57532f1b9941322c1cfd2141..247e33dd67fdc8fce40a16a63c1ec2795e4c5f5e 100644 (file)
@@ -661,6 +661,7 @@ static void resetDefaultsToConsistentValues()
 #endif
     [preferences setWebGLEnabled:NO];
     [preferences setCSSRegionsEnabled:YES];
+    [preferences setCSSGridLayoutEnabled:NO];
     [preferences setUsePreHTML5ParserQuirks:NO];
     [preferences setAsynchronousSpellCheckingEnabled:NO];
     [preferences setHixie76WebSocketProtocolEnabled:NO];