2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
authoralexis.menard@openbossa.org <alexis.menard@openbossa.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Jun 2011 21:02:07 +0000 (21:02 +0000)
committeralexis.menard@openbossa.org <alexis.menard@openbossa.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Jun 2011 21:02:07 +0000 (21:02 +0000)
        Reviewed by Andreas Kling.

        [Qt] Warning fixes on comparisons between a signed and an unsigned.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
        (DumpRenderTreeSupportQt::nodesFromRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp

index 4be19ff..8479b1b 100644 (file)
@@ -2,6 +2,16 @@
 
         Reviewed by Andreas Kling.
 
+        [Qt] Warning fixes on comparisons between a signed and an unsigned.
+
+        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
+        (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
+        (DumpRenderTreeSupportQt::nodesFromRect):
+
+2011-06-03  Alexis Menard  <alexis.menard@openbossa.org>
+
+        Reviewed by Andreas Kling.
+
         To support building namespaced Qt, we require that forward-declarations
         of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
 
index 43d338c..b55e08d 100644 (file)
@@ -585,7 +585,7 @@ QVariantMap DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo(const QWe
         return res;
 
     RefPtr<WebCore::CSSComputedStyleDeclaration> style = computedStyle(webElement, true);
-    for (int i = 0; i < style->length(); i++) {
+    for (unsigned i = 0; i < style->length(); i++) {
         QString name = style->item(i);
         QString value = (static_cast<WebCore::CSSStyleDeclaration*>(style.get()))->getPropertyValue(name);
         res[convertToPropertyName(name)] = QVariant(value);
@@ -990,7 +990,7 @@ QVariantList DumpRenderTreeSupportQt::nodesFromRect(const QWebElement& document,
     if (!doc)
         return res;
     RefPtr<NodeList> nodes = doc->nodesFromRect(x, y, top, right, bottom, left, ignoreClipping);
-    for (int i = 0; i < nodes->length(); i++) {
+    for (unsigned i = 0; i < nodes->length(); i++) {
         // QWebElement will be null if the Node is not an HTML Element
         if (nodes->item(i)->isHTMLElement())
             res << QVariant::fromValue(QWebElement(nodes->item(i)));