2010-10-06 Dirk Pranke <dpranke@chromium.org>
authordpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Oct 2010 23:18:08 +0000 (23:18 +0000)
committerdpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Oct 2010 23:18:08 +0000 (23:18 +0000)
        Reviewed by Kenneth Russell.

        Add a "FIXME" to clarify that all of the tests are currently marked
        "PASS FAIL" and hence we won't actually see any failures requiring
        new baselines (only crashes or timeouts).

        https://bugs.webkit.org/show_bug.cgi?id=47312

        * platform/chromium-gpu/test_expectations.txt:
2010-10-06  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Kenneth Russell.

        new-run-webkit-tests: fix typo in chromium-gpu that was trying to
        enable 'accelerated-composting' instead of 'accelerated-compositing'.

        https://bugs.webkit.org/show_bug.cgi?id=47312

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/chromium-gpu/test_expectations.txt
WebKitTools/ChangeLog
WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py

index 1ad92732b0ccb12dfdf290c69a418a438c9fcb9d..0156393d156f52372192af90e5b1e2e9d459cbf6 100644 (file)
@@ -1,3 +1,16 @@
+2010-10-06  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Kenneth Russell.
+
+        Add a "FIXME" to clarify that all of the tests are currently marked
+        "PASS FAIL" and hence we won't actually see any failures requiring
+        new baselines (only crashes or timeouts).
+
+        https://bugs.webkit.org/show_bug.cgi?id=47312
+
+
+        * platform/chromium-gpu/test_expectations.txt:
+
 2010-10-06  Kinuko Yasuda  <kinuko@chromium.org>
 
         Reviewed by David Levin.
index afec7be40f0f3c7ce115b690ba8941eb12bf6f9f..68c423b43e3010734197e790ed55aec2d409b077 100644 (file)
@@ -44,6 +44,10 @@ WONTFIX SKIP : http/tests/websocket = PASS FAIL
 WONTFIX SKIP : wml = PASS FAIL
 
 // (These are the tests we actually run and expect to pass)
+// We need to explicitly list fast/canvas and canvas/philip because the
+// parent directories are otherwise SKIPPed. We list compositing for completeness.
+//
+// FIXME: remove the FAILs from the following three lines.
 BUGNONE : compositing = PASS FAIL
 BUGNONE : fast/canvas = PASS FAIL
 BUGNONE : canvas/philip = PASS FAIL
index 964b346a4f950fae6e264baf720e858be6589686..4355aee8ed6f14e738ec8ae8e85ba9a6e36146a3 100644 (file)
@@ -1,3 +1,15 @@
+2010-10-06  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Kenneth Russell.
+
+        new-run-webkit-tests: fix typo in chromium-gpu that was trying to
+        enable 'accelerated-composting' instead of 'accelerated-compositing'.
+
+        https://bugs.webkit.org/show_bug.cgi?id=47312
+
+        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
+
 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
 
         Reviewed by Kenneth Rohde Christiansen.
index 80602d9a7ba478a69362489b5fb839fd36242984..505c9b58895b58bcab2cfadf232480f0e956981b 100644 (file)
@@ -66,7 +66,7 @@ def get(**kwargs):
 def _set_gpu_options(options):
     if options:
         if options.accelerated_compositing is None:
-            options.accelerated_composting = True
+            options.accelerated_compositing = True
         if options.accelerated_2d_canvas is None:
             options.accelerated_2d_canvas = True
 
index 5c79a3feb8f0a1b2927b11be60e674b118013124..1dd3eaed8ca4209d6720081437410e572f66f696 100644 (file)
@@ -29,6 +29,12 @@ import unittest
 import chromium_gpu
 
 
+class MockOptions(object):
+    def __init__(self):
+        self.accelerated_compositing = None
+        self.accelerated_2d_canvas = None
+
+
 class ChromiumGpuTest(unittest.TestCase):
     def test_get_chromium_gpu_linux(self):
         self.assertOverridesWorked('chromium-gpu-linux')
@@ -41,7 +47,9 @@ class ChromiumGpuTest(unittest.TestCase):
 
     def assertOverridesWorked(self, port_name):
         # test that we got the right port
-        port = chromium_gpu.get(port_name=port_name, options=None)
+        port = chromium_gpu.get(port_name=port_name, options=MockOptions())
+        self.assertTrue(port._options.accelerated_compositing)
+        self.assertTrue(port._options.accelerated_2d_canvas)
 
         # we use startswith() instead of Equal to gloss over platform versions.
         self.assertTrue(port.name().startswith(port_name))