Reviewed by Kenneth Russell.
Add a "FIXME" to clarify that all of the tests are currently marked
"PASS FAIL" and hence we won't actually see any failures requiring
new baselines (only crashes or timeouts).
https://bugs.webkit.org/show_bug.cgi?id=47312
* platform/chromium-gpu/test_expectations.txt:
2010-10-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kenneth Russell.
new-run-webkit-tests: fix typo in chromium-gpu that was trying to
enable 'accelerated-composting' instead of 'accelerated-compositing'.
https://bugs.webkit.org/show_bug.cgi?id=47312
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2010-10-06 Dirk Pranke <dpranke@chromium.org>
+
+ Reviewed by Kenneth Russell.
+
+ Add a "FIXME" to clarify that all of the tests are currently marked
+ "PASS FAIL" and hence we won't actually see any failures requiring
+ new baselines (only crashes or timeouts).
+
+ https://bugs.webkit.org/show_bug.cgi?id=47312
+
+
+ * platform/chromium-gpu/test_expectations.txt:
+
2010-10-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
WONTFIX SKIP : wml = PASS FAIL
// (These are the tests we actually run and expect to pass)
+// We need to explicitly list fast/canvas and canvas/philip because the
+// parent directories are otherwise SKIPPed. We list compositing for completeness.
+//
+// FIXME: remove the FAILs from the following three lines.
BUGNONE : compositing = PASS FAIL
BUGNONE : fast/canvas = PASS FAIL
BUGNONE : canvas/philip = PASS FAIL
+2010-10-06 Dirk Pranke <dpranke@chromium.org>
+
+ Reviewed by Kenneth Russell.
+
+ new-run-webkit-tests: fix typo in chromium-gpu that was trying to
+ enable 'accelerated-composting' instead of 'accelerated-compositing'.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47312
+
+ * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+ * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
+
2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
def _set_gpu_options(options):
if options:
if options.accelerated_compositing is None:
- options.accelerated_composting = True
+ options.accelerated_compositing = True
if options.accelerated_2d_canvas is None:
options.accelerated_2d_canvas = True
import chromium_gpu
+class MockOptions(object):
+ def __init__(self):
+ self.accelerated_compositing = None
+ self.accelerated_2d_canvas = None
+
+
class ChromiumGpuTest(unittest.TestCase):
def test_get_chromium_gpu_linux(self):
self.assertOverridesWorked('chromium-gpu-linux')
def assertOverridesWorked(self, port_name):
# test that we got the right port
- port = chromium_gpu.get(port_name=port_name, options=None)
+ port = chromium_gpu.get(port_name=port_name, options=MockOptions())
+ self.assertTrue(port._options.accelerated_compositing)
+ self.assertTrue(port._options.accelerated_2d_canvas)
# we use startswith() instead of Equal to gloss over platform versions.
self.assertTrue(port.name().startswith(port_name))