fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 30 Jan 2016 00:06:48 +0000 (00:06 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 30 Jan 2016 00:06:48 +0000 (00:06 +0000)
https://bugs.webkit.org/show_bug.cgi?id=153681

Reviewed by Antti Koivisto.

Source/WebCore:

The bug was caused by canHaveUserAgentShadowRoot() returning false on a meter element since it's disabled on iOS.
Override HTMLUnknownElement's canHaveUserAgentShadowRoot to return false for compatbility on iOS.

* html/HTMLUnknownElement.h:
(WebCore::HTMLUnknownElement::canHaveUserAgentShadowRoot):

LayoutTests:

Enable shadow DOM and custom elements tests on iOS; matches that's in platform/mac/TestExpectations.

* platform/ios-simulator/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@195863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/ios-simulator/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/html/HTMLUnknownElement.h

index 580331e..82d5489 100644 (file)
@@ -1,3 +1,14 @@
+2016-01-29  Ryosuke Niwa  <rniwa@webkit.org>
+
+        fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=153681
+
+        Reviewed by Antti Koivisto.
+
+        Enable shadow DOM and custom elements tests on iOS; matches that's in platform/mac/TestExpectations.
+
+        * platform/ios-simulator/TestExpectations:
+
 2016-01-29  Ryan Haddad  <ryanhaddad@apple.com>
 
         Missed one rebaseline for ios-simulator after r195740 in the last patch.
index b0ac430..dbc1175 100644 (file)
@@ -215,6 +215,13 @@ loader/stateobjects/pushstate-size-iframe.html [ Skip ]
 fast/loader/stateobjects/replacestate-frequency-with-user-gesture.html [ Skip ]
 fast/loader/stateobjects/pushstate-frequency-with-user-gesture.html [ Skip ]
 
+webkit.org/b/148695 fast/shadow-dom [ Pass ]
+webkit.org/b/149440 fast/shadow-dom/css-scoping-shadow-host-functional-rule.html [ ImageOnlyFailure ]
+webkit.org/b/149441 fast/shadow-dom/css-scoping-shadow-slotted-rule.html [ ImageOnlyFailure ]
+webkit.org/b/149441 fast/shadow-dom/css-scoping-shadow-slot-display-override.html [ ImageOnlyFailure ]
+
+webkit.org/b/150225 fast/custom-elements [ Pass ]
+
 ###
 # Known failures
 ##
index f44fb83..2b46c07 100644 (file)
@@ -1,3 +1,16 @@
+2016-01-29  Ryosuke Niwa  <rniwa@webkit.org>
+
+        fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=153681
+
+        Reviewed by Antti Koivisto.
+
+        The bug was caused by canHaveUserAgentShadowRoot() returning false on a meter element since it's disabled on iOS.
+        Override HTMLUnknownElement's canHaveUserAgentShadowRoot to return false for compatbility on iOS.
+
+        * html/HTMLUnknownElement.h:
+        (WebCore::HTMLUnknownElement::canHaveUserAgentShadowRoot):
+
 2016-01-29  Brady Eidson  <beidson@apple.com>
 
         Modern IDB: Getting records for key ranges with null keys aren't properly handled in SQLite backend
index c9da76b..31e1138 100644 (file)
@@ -47,6 +47,12 @@ private:
     {
     }
 
+#if ENABLE(METER_ELEMENT)
+    virtual bool canHaveUserAgentShadowRoot() const override final { return false; }
+#else
+    virtual bool canHaveUserAgentShadowRoot() const override final { return localName() == "meter"; }
+#endif
+
     virtual bool isHTMLUnknownElement() const override { return true; }
 };