2011-01-05 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        minor code cleanup for code review tool
        https://bugs.webkit.org/show_bug.cgi?id=51962

        Consolidates some queries to using shared functions.

        * code-review.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index d91322eb4df3572940c1cc0b8b27fe4e3176b41b..405c32a4e75ba075b546498dcc663adb0af600fa 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,14 @@
+2011-01-05  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        minor code cleanup for code review tool
+        https://bugs.webkit.org/show_bug.cgi?id=51962
+
+        Consolidates some queries to using shared functions.
+
+        * code-review.js:
+
 2011-01-05  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index 9163cf0499cf520530ae7dac55aa8edcb0f63b1d..ccdc4d88543ad6f2261a277b9b9e14e3c3dbe66f 100644 (file)
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -539,6 +539,10 @@
     return Number(line.querySelector('.to').textContent);
   }
 
+  function textContentsFor(line) {
+    return $('.text', line).text();
+  }
+
   function lineNumberForFirstNonContextLine(patched_file, line, prev_line, context, hunk_num) {
     if (context.length) {
       var prev_line_num = fromLineNumber(prev_line) - 1;
@@ -566,7 +570,7 @@
 
       for (var j = 0, lines_len = lines.length; j < lines_len; j++) {
         var line = lines[j];
-        var line_contents = line.querySelector('.text').textContent;
+        var line_contents = textContentsFor(line);
         if ($(line).hasClass('add')) {
           if (current_line == -1) {
             current_line = lineNumberForFirstNonContextLine(patched_file, line, lines[j-1], context, hunk_num);
@@ -789,8 +793,7 @@
         action = '+';
       else if ($(this).hasClass('remove'))
         action = '-';
-      var text = $(this).children('.text').text();
-      snippets.push(indent + action + text);
+      snippets.push(indent + action + textContentsFor(this));
     });
     return snippets.join('\n');
   }
@@ -805,7 +808,7 @@
 
   function snippetFor(line, indent) {
     var file_name = fileNameFor(line);
-    var line_number = line.hasClass('remove') ? '-' + line.children('.from').text() : line.children('.to').text();
+    var line_number = line.hasClass('remove') ? '-' + fromLineNumber(line[0]) : toLineNumber(line[0]);
     return indent + file_name + ':' + line_number + '\n' + contextSnippetFor(line, indent);
   }