Fix autoscroll test to work on iPad.
authormegan_gardner@apple.com <megan_gardner@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Oct 2019 14:18:07 +0000 (14:18 +0000)
committermegan_gardner@apple.com <megan_gardner@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Oct 2019 14:18:07 +0000 (14:18 +0000)
https://bugs.webkit.org/show_bug.cgi?id=203598
<rdar://problem/51863703>

Reviewed by Wenson Hsieh.

iPads are much taller than iPhones, so to test autoscrolling under a
software keyboard, we need to return several more times.
Also take the opportunity to make the test more robust to races.

* fast/events/autoscroll-with-software-keyboard.html:
* platform/ipad/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/events/autoscroll-with-software-keyboard.html
LayoutTests/platform/ipad/TestExpectations

index 9e8ff51..40a7012 100644 (file)
@@ -1,3 +1,18 @@
+2019-10-30  Megan Gardner  <megan_gardner@apple.com>
+
+        Fix autoscroll test to work on iPad.
+        https://bugs.webkit.org/show_bug.cgi?id=203598
+        <rdar://problem/51863703>
+
+        Reviewed by Wenson Hsieh.
+
+        iPads are much taller than iPhones, so to test autoscrolling under a
+        software keyboard, we need to return several more times.
+        Also take the opportunity to make the test more robust to races.
+
+        * fast/events/autoscroll-with-software-keyboard.html:
+        * platform/ipad/TestExpectations:
+
 2019-10-30  Frederic Wang  <fwang@igalia.com>
 
         Import WPT tests for scrollend and overscroll events
index bd8d75b..d76064d 100644 (file)
             return;
     
         var output = '';
-        var firstTargetRect = document.getElementById('editable').getBoundingClientRect();
-    
-        var pressPointX = firstTargetRect.x;
-        var pressPointY = firstTargetRect.y;
 
-    
-        await tapAtPoint(pressPointX,pressPointY);
-        await UIHelper.enterText("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nTest");
+        await UIHelper.activateElementAndWaitForInputSession(document.getElementById('editable'));
+        await UIHelper.enterText("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nTest");
 
         var firstPageOffset = window.pageYOffset;
         if (window.pageYOffset > 0)
@@ -31,7 +26,7 @@
             output += 'FAIL: page has failed to scroll when caret is behind software keyboard.';
         output += '<br>';
 
-        await UIHelper.enterText("\n\n\n\n\n\n\n\n\n\n\n\n\n\nTest");
+        await UIHelper.enterText("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nTest");
         if (window.pageYOffset > 0 && window.pageYOffset > firstPageOffset)
             output += 'PASS: page has continuted to scroll when caret is beyond the edge of the screen.';
         else
index 8747f2c..08f1fb1 100644 (file)
@@ -40,9 +40,6 @@ webkit.org/b/194259 fast/events/ios/rotation/resize-iframe-after-orientation-cha
 webkit.org/b/194259 fast/events/ios/rotation/safari-like-rotation.html [ Skip ]
 webkit.org/b/194259 fast/events/ios/viewport-no-width-value-allows-double-tap.html [ Skip ]
 
-# <rdar://problem/51863703> [ iPad Sim ] New Layout test fast/events/autoscroll-with-software-keyboard.html is failing on iOS 13 iPad Simulator testers
-fast/events/autoscroll-with-software-keyboard.html [ Failure ]
-
 # This tests an iphone-specific behavior so is expected to fail on iPad.
 fast/scrolling/ios/overflow-scrolling-touch-enabled-stacking.html [ ImageOnlyFailure ]