2010-08-17 Philippe Normand <pnormand@igalia.com>
authorphiln@webkit.org <philn@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Aug 2010 06:48:24 +0000 (06:48 +0000)
committerphiln@webkit.org <philn@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Aug 2010 06:48:24 +0000 (06:48 +0000)
        Reviewed by Martin Robinson.

        [GStreamer] media/invalid-media-url-crash.html fails
        https://bugs.webkit.org/show_bug.cgi?id=42960

        Implemented two ResourceHandleClient callbacks that need to notify
        downstream GStreamer elements of errors while accessing the
        resource.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (StreamingClient::wasBlocked):
        (StreamingClient::cannotShowURL):

LayoutTests:

2010-08-17  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] media/invalid-media-url-crash.html fails
        https://bugs.webkit.org/show_bug.cgi?id=42960

        * platform/gtk/Skipped: Unskip fixed test

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/Skipped
WebCore/ChangeLog
WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

index 696d80bb97321c482653353fcf3cca49ce15ec64..0b3638afb07d69a3fd677c73a23415894df7c2eb 100644 (file)
@@ -1,3 +1,12 @@
+2010-08-17  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GStreamer] media/invalid-media-url-crash.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=42960
+
+        * platform/gtk/Skipped: Unskip fixed test
+
 2010-08-16  Yuta Kitamura  <yutak@chromium.org>
 
         Unreviewed test expectation update.
index 8f5613891d8828822ed398619ab6c309987cf3cb..4ebc04cbb572283f34a43d766f389ebe0f2ac5ff 100644 (file)
@@ -44,7 +44,6 @@ http/tests/xmlhttprequest/XMLHttpRequestException.html
 http/tests/xmlhttprequest/connection-error-sync.html
 fast/xmlhttprequest/null-document-xmlhttprequest-open.html
 http/tests/misc/favicon-as-image.html
-media/invalid-media-url-crash.html
 media/unsupported-rtsp.html
 security/autocomplete-cleared-on-back.html
 http/tests/security/frameNavigation/cross-origin-opener.html
index 060bbe573f716798603eab9b79f3a68a167dfd47..ef8a91bd05ebe11d90f467ead2b18f339ab7bc8c 100644 (file)
@@ -1,3 +1,18 @@
+2010-08-17  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GStreamer] media/invalid-media-url-crash.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=42960
+
+        Implemented two ResourceHandleClient callbacks that need to notify
+        downstream GStreamer elements of errors while accessing the
+        resource.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (StreamingClient::wasBlocked):
+        (StreamingClient::cannotShowURL):
+
 2010-08-16  Gavin Barraclough  <barraclough@apple.com>
 
         Rubber stamped by Sam Weinig
index d3b5f1b137b0c668174f1ec2485e84ee3f4cde6c..1059b59eb6c0eacc493c932615055693df0343c5 100644 (file)
@@ -780,9 +780,13 @@ void StreamingClient::didFail(ResourceHandle*, const ResourceError& error)
 
 void StreamingClient::wasBlocked(ResourceHandle*)
 {
+    GST_ERROR_OBJECT(m_src, "Request was blocked");
+    GST_ELEMENT_ERROR(m_src, RESOURCE, OPEN_READ, ("Access to \"%s\" was blocked", m_src->priv->uri), (0));
 }
 
 void StreamingClient::cannotShowURL(ResourceHandle*)
 {
+    GST_ERROR_OBJECT(m_src, "Cannot show URL");
+    GST_ELEMENT_ERROR(m_src, RESOURCE, OPEN_READ, ("Can't show \"%s\"", m_src->priv->uri), (0));
 }