https://bugs.webkit.org/show_bug.cgi?id=163618
Reviewed by Ryosuke Niwa.
Update test case for change r206465 which added support for multiple summary pages.
Use deepStrictEqual instead of deepEqual as deepEqual will not complain in the case like 'deepEqual([],{})'.
Fix a test failure in tools-buildbot-triggerable-tests.js.
Fix a bug in generating manifest.
* config.json:
* public/include/manifest.php:
* server-tests/api-manifest.js:
(TestServer.remoteAPI.getJSON.string_appeared_here.then):
* server-tests/tools-buildbot-triggerable-tests.js:
(then):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@207492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2016-10-18 Dewei Zhu <dewei_zhu@apple.com>
+
+ Update test cases for change r206465.
+ https://bugs.webkit.org/show_bug.cgi?id=163618
+
+ Reviewed by Ryosuke Niwa.
+
+ Update test case for change r206465 which added support for multiple summary pages.
+ Use deepStrictEqual instead of deepEqual as deepEqual will not complain in the case like 'deepEqual([],{})'.
+ Fix a test failure in tools-buildbot-triggerable-tests.js.
+ Fix a bug in generating manifest.
+
+ * config.json:
+ * public/include/manifest.php:
+ * server-tests/api-manifest.js:
+ (TestServer.remoteAPI.getJSON.string_appeared_here.then):
+ * server-tests/tools-buildbot-triggerable-tests.js:
+ (then):
+
2016-09-27 Dewei Zhu <dewei_zhu@apple.com>
Extend perf dashboard to support multiple summary pages.
'builders' => (object)$this->builders(),
'bugTrackers' => (object)$this->bug_trackers($repositories_table),
'dashboards' => (object)config('dashboards'),
- 'summaryPages' => (object)config('summaryPages'),
+ 'summaryPages' => config('summaryPages'),
);
$this->manifest['elapsedTime'] = (microtime(true) - $start_time) * 1000;
it("should generate an empty manifest when database is empty", function (done) {
TestServer.remoteAPI().getJSON('/api/manifest').then(function (manifest) {
assert.deepEqual(Object.keys(manifest).sort(), ['all', 'bugTrackers', 'builders', 'dashboard', 'dashboards',
- 'elapsedTime', 'metrics', 'repositories', 'siteTitle', 'status', 'summary', 'tests']);
+ 'elapsedTime', 'metrics', 'repositories', 'siteTitle', 'status', 'summaryPages', 'tests']);
assert.equal(typeof(manifest.elapsedTime), 'number');
delete manifest.elapsedTime;
- assert.deepEqual(manifest, {
+ assert.deepStrictEqual(manifest, {
siteTitle: TestServer.testConfig().siteTitle,
all: {},
bugTrackers: {},
metrics: {},
repositories: {},
tests: {},
- summary: {},
+ summaryPages: [],
status: 'OK'
});
done();
}
start()
- {
+ {
let testConfigContent = this.testConfig();
fs.writeFileSync(this._testConfigPath, JSON.stringify(testConfigContent, null, ' '));
'clusterStart': [2000, 1, 1, 0, 0],
'clusterSize': [0, 2, 0],
'defaultDashboard': [[]],
- 'dashboards': {}
+ 'dashboards': {},
+ 'summaryPages': []
}
}
assert.equal(MockRemoteAPI.requests[2].url, '/builders/some-builder-1/force');
assert.deepEqual(MockRemoteAPI.requests[2].data, {'wk': '192736', 'os': '10.11 15A284', 'build-request-id': '701'});
MockRemoteAPI.requests[2].resolve('OK');
+ return MockRemoteAPI.waitForRequest();
}).then(function () {
assert.equal(MockRemoteAPI.requests.length, 4);
assert.equal(MockRemoteAPI.requests[3].method, 'GET');