2011-01-12 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        review tool formatted diff doesn't match the uploaded diff
        https://bugs.webkit.org/show_bug.cgi?id=51960

        PrettyPatch works just fine if there is no newline at the end of the file.

        * attachment.cgi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index 6b5f678b21b8d67c4f27e53f4110a5a752ccd3de..91789dd1603c79900660a63d02fca0ffd5ea43f7 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,14 @@
+2011-01-12  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        review tool formatted diff doesn't match the uploaded diff
+        https://bugs.webkit.org/show_bug.cgi?id=51960
+
+        PrettyPatch works just fine if there is no newline at the end of the file.
+
+        * attachment.cgi:
+
 2011-01-12  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/Websites/bugs.webkit.org/attachment.cgi b/Websites/bugs.webkit.org/attachment.cgi
index 90c279dc4a4dc0755fe640ea27dcad9b845a6133..2427b59ba2ccf5819f38ec7ccb18c8247872a114 100755 (executable)
--- a/Websites/bugs.webkit.org/attachment.cgi
+++ b/Websites/bugs.webkit.org/attachment.cgi
@@ -396,7 +396,7 @@ sub prettyPatch
     $ENV{'PATH'} = "/opt/local/bin:" . $ENV{'PATH'};
     open2(\*OUT, \*IN, "/usr/bin/ruby", "-I", "PrettyPatch", "PrettyPatch/prettify.rb", "--html-exceptions");
     $ENV{'PATH'} = $orig_path;
-    print IN $attachment->data . "\n";
+    print IN $attachment->data;
     close(IN);
     while (<OUT>) {
         print;