Classes marked final should not use protected access specifier
authorross.kirsling@sony.com <ross.kirsling@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Apr 2020 06:11:07 +0000 (06:11 +0000)
committerross.kirsling@sony.com <ross.kirsling@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Apr 2020 06:11:07 +0000 (06:11 +0000)
https://bugs.webkit.org/show_bug.cgi?id=210775

Reviewed by Daniel Bates.

Source/JavaScriptCore:

* API/JSAPIValueWrapper.h:
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
* b3/B3ExtractValue.h:
* bytecode/UnlinkedFunctionExecutable.h:
* inspector/JSGlobalObjectConsoleClient.h:
* inspector/JSInjectedScriptHost.h:
* inspector/JSJavaScriptCallFrame.h:
* jsc.cpp:
* runtime/AggregateError.h:
* runtime/AggregateErrorPrototype.h:
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.h:
* runtime/AsyncFunctionPrototype.h:
* runtime/AsyncGeneratorFunctionPrototype.h:
* runtime/AtomicsObject.h:
* runtime/BigIntConstructor.h:
* runtime/BigIntObject.h:
* runtime/BigIntPrototype.h:
* runtime/BooleanConstructor.h:
* runtime/BooleanPrototype.h:
* runtime/ConsoleObject.h:
* runtime/DateConstructor.h:
* runtime/DatePrototype.h:
* runtime/ErrorConstructor.h:
* runtime/ErrorPrototype.h:
* runtime/FileBasedFuzzerAgent.h:
* runtime/FunctionPrototype.h:
* runtime/FunctionRareData.h:
* runtime/GeneratorFunctionPrototype.h:
* runtime/GenericTypedArrayView.h:
* runtime/InspectorInstrumentationObject.h:
* runtime/IntlCollator.h:
* runtime/IntlCollatorConstructor.h:
* runtime/IntlCollatorPrototype.h:
* runtime/IntlDateTimeFormat.h:
* runtime/IntlDateTimeFormatConstructor.h:
* runtime/IntlDateTimeFormatPrototype.h:
* runtime/IntlNumberFormat.h:
* runtime/IntlNumberFormatConstructor.h:
* runtime/IntlNumberFormatPrototype.h:
* runtime/IntlPluralRules.h:
* runtime/IntlPluralRulesConstructor.h:
* runtime/IntlPluralRulesPrototype.h:
* runtime/IntlRelativeTimeFormatConstructor.h:
* runtime/IntlRelativeTimeFormatPrototype.h:
* runtime/JSArrayBuffer.h:
* runtime/JSArrayBufferConstructor.h:
* runtime/JSArrayBufferPrototype.h:
* runtime/JSAsyncGenerator.h:
* runtime/JSBoundFunction.h:
* runtime/JSCustomGetterSetterFunction.h:
* runtime/JSDataView.h:
* runtime/JSDataViewPrototype.h:
* runtime/JSGenerator.h:
* runtime/JSGenericTypedArrayView.h:
* runtime/JSGenericTypedArrayViewConstructor.h:
* runtime/JSGenericTypedArrayViewPrototype.h:
* runtime/JSGlobalLexicalEnvironment.h:
* runtime/JSModuleLoader.h:
* runtime/JSModuleNamespaceObject.h:
* runtime/JSNativeStdFunction.h:
* runtime/JSONObject.h:
* runtime/JSObject.h:
* runtime/JSTemplateObjectDescriptor.h:
* runtime/JSTypedArrayViewConstructor.h:
* runtime/JSTypedArrayViewPrototype.h:
* runtime/MathObject.h:
* runtime/NativeExecutable.h:
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.h:
* runtime/PredictionFileCreatingFuzzerAgent.h:
* runtime/ReflectObject.h:
* runtime/RegExp.h:
* runtime/RegExpConstructor.h:
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.h:
* runtime/StringPrototype.h:
* runtime/Structure.h:
* runtime/Symbol.h:
* runtime/SymbolConstructor.h:
* runtime/SymbolObject.h:
* runtime/SymbolPrototype.h:
* runtime/VMTraps.cpp:
* testRegExp.cpp:
* wasm/WasmBBQPlan.h:
* wasm/WasmLLIntPlan.h:
* wasm/WasmWorklist.cpp:
* wasm/js/JSWebAssembly.h:
* wasm/js/JSWebAssemblyCompileError.h:
* wasm/js/JSWebAssemblyInstance.h:
* wasm/js/JSWebAssemblyLinkError.h:
* wasm/js/JSWebAssemblyRuntimeError.h:
* wasm/js/WebAssemblyCompileErrorConstructor.h:
* wasm/js/WebAssemblyCompileErrorPrototype.h:
* wasm/js/WebAssemblyGlobalConstructor.h:
* wasm/js/WebAssemblyGlobalPrototype.h:
* wasm/js/WebAssemblyInstanceConstructor.h:
* wasm/js/WebAssemblyInstancePrototype.h:
* wasm/js/WebAssemblyLinkErrorConstructor.h:
* wasm/js/WebAssemblyLinkErrorPrototype.h:
* wasm/js/WebAssemblyMemoryConstructor.h:
* wasm/js/WebAssemblyMemoryPrototype.h:
* wasm/js/WebAssemblyModuleConstructor.h:
* wasm/js/WebAssemblyModulePrototype.h:
* wasm/js/WebAssemblyRuntimeErrorConstructor.h:
* wasm/js/WebAssemblyRuntimeErrorPrototype.h:
* wasm/js/WebAssemblyTableConstructor.h:
* wasm/js/WebAssemblyTablePrototype.h:
* wasm/js/WebAssemblyWrapperFunction.h:

Source/WebCore:

* Modules/applepay/ApplePayPaymentMethodSelectedEvent.h:
* Modules/applepay/ApplePayValidateMerchantEvent.h:
* Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h:
* Modules/webaudio/BiquadDSPKernel.h:
* Modules/webaudio/WaveShaperDSPKernel.h:
* Modules/websockets/WebSocketChannel.h:
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
* Modules/webxr/WebXRSession.h:
* Modules/webxr/WebXRSystem.h:
* accessibility/AccessibilityARIAGridCell.h:
* accessibility/AccessibleSetValueEvent.h:
* animation/CSSAnimation.h:
* bindings/js/ReadableStream.h:
* bridge/objc/objc_runtime.h:
* bridge/runtime_array.h:
* css/CSSImageSetValue.h:
* html/HTMLKeygenElement.cpp:
* html/canvas/WebGLBuffer.h:
* html/canvas/WebGLFramebuffer.h:
* html/canvas/WebGLProgram.h:
* html/canvas/WebGLQuery.h:
* html/canvas/WebGLRenderbuffer.h:
* html/canvas/WebGLSampler.h:
* html/canvas/WebGLSync.h:
* html/canvas/WebGLTransformFeedback.h:
* html/canvas/WebGLUniformLocation.h:
* html/shadow/TextControlInnerElements.h:
* inspector/InspectorStyleSheet.h:
* inspector/WebInjectedScriptManager.h:
* loader/cache/CachedCSSStyleSheet.h:
* page/Frame.h:
* page/FrameView.h:
* page/PageConsoleClient.h:
* page/animation/KeyframeAnimation.h:
* page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.h:
* platform/audio/AudioBus.h:
* platform/cocoa/PlaybackSessionModelMediaElement.h:
* platform/graphics/BitmapImage.h:
* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/NamedImageGeneratedImage.h:
* platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
* platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h:
* platform/graphics/ca/win/PlatformCAAnimationWin.h:
* platform/graphics/cg/ImageDecoderCG.h:
* platform/graphics/iso/ISOOriginalFormatBox.h:
* platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
* platform/graphics/iso/ISOSchemeInformationBox.h:
* platform/graphics/iso/ISOSchemeTypeBox.h:
* platform/graphics/iso/ISOTrackEncryptionBox.h:
* platform/graphics/iso/ISOVTTCue.cpp:
* platform/graphics/iso/ISOVTTCue.h:
* platform/graphics/win/ImageDecoderDirect2D.h:
* platform/mediastream/mac/AVCaptureDeviceManager.h:
* platform/mock/mediasource/MockBox.h:
* platform/mock/mediasource/MockSourceBufferPrivate.cpp:
* rendering/RenderFullScreen.h:
* rendering/RenderGrid.h:
* rendering/RenderMultiColumnSet.h:
* rendering/RenderRuby.h:
* rendering/RenderScrollbarPart.h:
* rendering/RenderScrollbarTheme.h:
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.h:
* rendering/RenderThemeIOS.h:
* rendering/RenderView.h:
* rendering/svg/RenderSVGResourceClipper.h:
* svg/SVGTextPathElement.h:
* workers/WorkerConsoleClient.h:
* worklets/Worklet.h:

Source/WebKit:

* Shared/API/APIDictionary.h:
* WebProcess/GPU/media/TextTrackPrivateRemote.h:
* WebProcess/Plugins/Netscape/JSNPMethod.h:
* WebProcess/Plugins/Netscape/JSNPObject.h:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.h:

Source/WebKitLegacy/win:

* DefaultDownloadDelegate.h:
* DefaultPolicyDelegate.h:
* MemoryStream.h:
* WebApplicationCache.h:
* WebArchive.h:
* WebBackForwardList.h:
* WebCache.h:
* WebCoreStatistics.h:
* WebDataSource.h:
* WebElementPropertyBag.h:
* WebError.h:
* WebFrame.h:
* WebFramePolicyListener.h:
* WebHTMLRepresentation.h:
* WebHistoryItem.h:
* WebJavaScriptCollector.h:
* WebKitClassFactory.h:
* WebKitStatistics.h:
* WebMutableURLRequest.h:
* WebNotification.h:
* WebNotificationCenter.h:
* WebPreferences.h:
* WebResource.h:
* WebURLAuthenticationChallenge.h:
* WebURLCredential.h:
* WebURLProtectionSpace.h:
* WebURLResponse.h:

Tools:

* DumpRenderTree/win/DefaultPolicyDelegate.h:
* DumpRenderTree/win/UIDelegate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@260415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

222 files changed:
Source/JavaScriptCore/API/JSAPIValueWrapper.h
Source/JavaScriptCore/API/JSCallbackConstructor.h
Source/JavaScriptCore/API/JSCallbackObject.h
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/b3/B3ExtractValue.h
Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h
Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.h
Source/JavaScriptCore/inspector/JSInjectedScriptHost.h
Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h
Source/JavaScriptCore/jsc.cpp
Source/JavaScriptCore/runtime/AggregateError.h
Source/JavaScriptCore/runtime/AggregateErrorPrototype.h
Source/JavaScriptCore/runtime/ArrayConstructor.h
Source/JavaScriptCore/runtime/ArrayPrototype.h
Source/JavaScriptCore/runtime/AsyncFunctionPrototype.h
Source/JavaScriptCore/runtime/AsyncGeneratorFunctionPrototype.h
Source/JavaScriptCore/runtime/AtomicsObject.h
Source/JavaScriptCore/runtime/BigIntConstructor.h
Source/JavaScriptCore/runtime/BigIntObject.h
Source/JavaScriptCore/runtime/BigIntPrototype.h
Source/JavaScriptCore/runtime/BooleanConstructor.h
Source/JavaScriptCore/runtime/BooleanPrototype.h
Source/JavaScriptCore/runtime/ConsoleObject.h
Source/JavaScriptCore/runtime/DateConstructor.h
Source/JavaScriptCore/runtime/DatePrototype.h
Source/JavaScriptCore/runtime/ErrorConstructor.h
Source/JavaScriptCore/runtime/ErrorPrototype.h
Source/JavaScriptCore/runtime/FileBasedFuzzerAgent.h
Source/JavaScriptCore/runtime/FunctionPrototype.h
Source/JavaScriptCore/runtime/FunctionRareData.h
Source/JavaScriptCore/runtime/GeneratorFunctionPrototype.h
Source/JavaScriptCore/runtime/GenericTypedArrayView.h
Source/JavaScriptCore/runtime/InspectorInstrumentationObject.h
Source/JavaScriptCore/runtime/IntlCollator.h
Source/JavaScriptCore/runtime/IntlCollatorConstructor.h
Source/JavaScriptCore/runtime/IntlCollatorPrototype.h
Source/JavaScriptCore/runtime/IntlDateTimeFormat.h
Source/JavaScriptCore/runtime/IntlDateTimeFormatConstructor.h
Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.h
Source/JavaScriptCore/runtime/IntlNumberFormat.h
Source/JavaScriptCore/runtime/IntlNumberFormatConstructor.h
Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.h
Source/JavaScriptCore/runtime/IntlPluralRules.h
Source/JavaScriptCore/runtime/IntlPluralRulesConstructor.h
Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.h
Source/JavaScriptCore/runtime/IntlRelativeTimeFormatConstructor.h
Source/JavaScriptCore/runtime/IntlRelativeTimeFormatPrototype.h
Source/JavaScriptCore/runtime/JSArrayBuffer.h
Source/JavaScriptCore/runtime/JSArrayBufferConstructor.h
Source/JavaScriptCore/runtime/JSArrayBufferPrototype.h
Source/JavaScriptCore/runtime/JSAsyncGenerator.h
Source/JavaScriptCore/runtime/JSBoundFunction.h
Source/JavaScriptCore/runtime/JSCustomGetterSetterFunction.h
Source/JavaScriptCore/runtime/JSDataView.h
Source/JavaScriptCore/runtime/JSDataViewPrototype.h
Source/JavaScriptCore/runtime/JSGenerator.h
Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h
Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructor.h
Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototype.h
Source/JavaScriptCore/runtime/JSGlobalLexicalEnvironment.h
Source/JavaScriptCore/runtime/JSModuleLoader.h
Source/JavaScriptCore/runtime/JSModuleNamespaceObject.h
Source/JavaScriptCore/runtime/JSNativeStdFunction.h
Source/JavaScriptCore/runtime/JSONObject.h
Source/JavaScriptCore/runtime/JSObject.h
Source/JavaScriptCore/runtime/JSTemplateObjectDescriptor.h
Source/JavaScriptCore/runtime/JSTypedArrayViewConstructor.h
Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.h
Source/JavaScriptCore/runtime/MathObject.h
Source/JavaScriptCore/runtime/NativeExecutable.h
Source/JavaScriptCore/runtime/NumberConstructor.h
Source/JavaScriptCore/runtime/NumberPrototype.h
Source/JavaScriptCore/runtime/ObjectConstructor.h
Source/JavaScriptCore/runtime/ObjectPrototype.h
Source/JavaScriptCore/runtime/PredictionFileCreatingFuzzerAgent.h
Source/JavaScriptCore/runtime/ReflectObject.h
Source/JavaScriptCore/runtime/RegExp.h
Source/JavaScriptCore/runtime/RegExpConstructor.h
Source/JavaScriptCore/runtime/RegExpObject.h
Source/JavaScriptCore/runtime/RegExpPrototype.h
Source/JavaScriptCore/runtime/StringPrototype.h
Source/JavaScriptCore/runtime/Structure.h
Source/JavaScriptCore/runtime/Symbol.h
Source/JavaScriptCore/runtime/SymbolConstructor.h
Source/JavaScriptCore/runtime/SymbolObject.h
Source/JavaScriptCore/runtime/SymbolPrototype.h
Source/JavaScriptCore/runtime/VMTraps.cpp
Source/JavaScriptCore/testRegExp.cpp
Source/JavaScriptCore/wasm/WasmBBQPlan.h
Source/JavaScriptCore/wasm/WasmLLIntPlan.h
Source/JavaScriptCore/wasm/WasmWorklist.cpp
Source/JavaScriptCore/wasm/js/JSWebAssembly.h
Source/JavaScriptCore/wasm/js/JSWebAssemblyCompileError.h
Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h
Source/JavaScriptCore/wasm/js/JSWebAssemblyLinkError.h
Source/JavaScriptCore/wasm/js/JSWebAssemblyRuntimeError.h
Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorConstructor.h
Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorPrototype.h
Source/JavaScriptCore/wasm/js/WebAssemblyGlobalConstructor.h
Source/JavaScriptCore/wasm/js/WebAssemblyGlobalPrototype.h
Source/JavaScriptCore/wasm/js/WebAssemblyInstanceConstructor.h
Source/JavaScriptCore/wasm/js/WebAssemblyInstancePrototype.h
Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorConstructor.h
Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorPrototype.h
Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.h
Source/JavaScriptCore/wasm/js/WebAssemblyMemoryPrototype.h
Source/JavaScriptCore/wasm/js/WebAssemblyModuleConstructor.h
Source/JavaScriptCore/wasm/js/WebAssemblyModulePrototype.h
Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorConstructor.h
Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorPrototype.h
Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.h
Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.h
Source/JavaScriptCore/wasm/js/WebAssemblyWrapperFunction.h
Source/WebCore/ChangeLog
Source/WebCore/Modules/applepay/ApplePayPaymentMethodSelectedEvent.h
Source/WebCore/Modules/applepay/ApplePayValidateMerchantEvent.h
Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h
Source/WebCore/Modules/webaudio/BiquadDSPKernel.h
Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h
Source/WebCore/Modules/websockets/WebSocketChannel.h
Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h
Source/WebCore/Modules/webxr/WebXRSession.h
Source/WebCore/Modules/webxr/WebXRSystem.h
Source/WebCore/accessibility/AccessibilityARIAGridCell.h
Source/WebCore/accessibility/AccessibleSetValueEvent.h
Source/WebCore/animation/CSSAnimation.h
Source/WebCore/bindings/js/ReadableStream.h
Source/WebCore/bridge/objc/objc_runtime.h
Source/WebCore/bridge/runtime_array.h
Source/WebCore/css/CSSImageSetValue.h
Source/WebCore/html/HTMLKeygenElement.cpp
Source/WebCore/html/canvas/WebGLBuffer.h
Source/WebCore/html/canvas/WebGLFramebuffer.h
Source/WebCore/html/canvas/WebGLProgram.h
Source/WebCore/html/canvas/WebGLQuery.h
Source/WebCore/html/canvas/WebGLRenderbuffer.h
Source/WebCore/html/canvas/WebGLSampler.h
Source/WebCore/html/canvas/WebGLSync.h
Source/WebCore/html/canvas/WebGLTransformFeedback.h
Source/WebCore/html/canvas/WebGLUniformLocation.h
Source/WebCore/html/shadow/TextControlInnerElements.h
Source/WebCore/inspector/InspectorStyleSheet.h
Source/WebCore/inspector/WebInjectedScriptManager.h
Source/WebCore/loader/cache/CachedCSSStyleSheet.h
Source/WebCore/page/Frame.h
Source/WebCore/page/FrameView.h
Source/WebCore/page/PageConsoleClient.h
Source/WebCore/page/animation/KeyframeAnimation.h
Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.h
Source/WebCore/platform/audio/AudioBus.h
Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h
Source/WebCore/platform/graphics/BitmapImage.h
Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h
Source/WebCore/platform/graphics/NamedImageGeneratedImage.h
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
Source/WebCore/platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h
Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.h
Source/WebCore/platform/graphics/cg/ImageDecoderCG.h
Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h
Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.h
Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.h
Source/WebCore/platform/graphics/iso/ISOSchemeTypeBox.h
Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.h
Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp
Source/WebCore/platform/graphics/iso/ISOVTTCue.h
Source/WebCore/platform/graphics/win/ImageDecoderDirect2D.h
Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.h
Source/WebCore/platform/mock/mediasource/MockBox.h
Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp
Source/WebCore/rendering/RenderFullScreen.h
Source/WebCore/rendering/RenderGrid.h
Source/WebCore/rendering/RenderMultiColumnSet.h
Source/WebCore/rendering/RenderRuby.h
Source/WebCore/rendering/RenderScrollbarPart.h
Source/WebCore/rendering/RenderScrollbarTheme.h
Source/WebCore/rendering/RenderTableCell.h
Source/WebCore/rendering/RenderTableSection.h
Source/WebCore/rendering/RenderThemeIOS.h
Source/WebCore/rendering/RenderView.h
Source/WebCore/rendering/svg/RenderSVGResourceClipper.h
Source/WebCore/svg/SVGTextPathElement.h
Source/WebCore/workers/WorkerConsoleClient.h
Source/WebCore/worklets/Worklet.h
Source/WebKit/ChangeLog
Source/WebKit/Shared/API/APIDictionary.h
Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.h
Source/WebKit/WebProcess/Plugins/Netscape/JSNPMethod.h
Source/WebKit/WebProcess/Plugins/Netscape/JSNPObject.h
Source/WebKitLegacy/ChangeLog
Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h
Source/WebKitLegacy/win/ChangeLog
Source/WebKitLegacy/win/DefaultDownloadDelegate.h
Source/WebKitLegacy/win/DefaultPolicyDelegate.h
Source/WebKitLegacy/win/MemoryStream.h
Source/WebKitLegacy/win/WebApplicationCache.h
Source/WebKitLegacy/win/WebArchive.h
Source/WebKitLegacy/win/WebBackForwardList.h
Source/WebKitLegacy/win/WebCache.h
Source/WebKitLegacy/win/WebCoreStatistics.h
Source/WebKitLegacy/win/WebDataSource.h
Source/WebKitLegacy/win/WebElementPropertyBag.h
Source/WebKitLegacy/win/WebError.h
Source/WebKitLegacy/win/WebFrame.h
Source/WebKitLegacy/win/WebFramePolicyListener.h
Source/WebKitLegacy/win/WebHTMLRepresentation.h
Source/WebKitLegacy/win/WebHistoryItem.h
Source/WebKitLegacy/win/WebJavaScriptCollector.h
Source/WebKitLegacy/win/WebKitClassFactory.h
Source/WebKitLegacy/win/WebKitStatistics.h
Source/WebKitLegacy/win/WebMutableURLRequest.h
Source/WebKitLegacy/win/WebNotification.h
Source/WebKitLegacy/win/WebNotificationCenter.h
Source/WebKitLegacy/win/WebPreferences.h
Source/WebKitLegacy/win/WebResource.h
Source/WebKitLegacy/win/WebURLAuthenticationChallenge.h
Source/WebKitLegacy/win/WebURLCredential.h
Source/WebKitLegacy/win/WebURLProtectionSpace.h
Source/WebKitLegacy/win/WebURLResponse.h
Tools/ChangeLog
Tools/DumpRenderTree/win/DefaultPolicyDelegate.h
Tools/DumpRenderTree/win/UIDelegate.h

index 1f78229..6705ecb 100644 (file)
@@ -57,7 +57,7 @@ public:
         return wrapper;
     }
 
-protected:
+private:
     void finishCreation(VM& vm, JSValue value)
     {
         Base::finishCreation(vm);
@@ -65,7 +65,6 @@ protected:
         ASSERT(!value.isCell());
     }
 
-private:
     JSAPIValueWrapper(VM& vm)
         : JSCell(vm, vm.apiWrapperStructure.get())
     {
index 6e3c356..fbd2431 100644 (file)
@@ -62,11 +62,10 @@ public:
         return Structure::create(vm, globalObject, proto, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
+private:
     JSCallbackConstructor(JSGlobalObject*, Structure*, JSClassRef, JSObjectCallAsConstructorCallback);
     void finishCreation(JSGlobalObject*, JSClassRef);
 
-private:
     friend struct APICallbackFunction;
 
     static ConstructType getConstructData(JSCell*, ConstructData&);
index 92ca924..e643513 100644 (file)
@@ -123,13 +123,6 @@ public:
     
 template <class Parent>
 class JSCallbackObject final : public Parent {
-protected:
-    JSCallbackObject(JSGlobalObject*, Structure*, JSClassRef, void* data);
-    JSCallbackObject(VM&, JSClassRef, Structure*);
-
-    void finishCreation(JSGlobalObject*);
-    void finishCreation(VM&);
-
 public:
     using Base = Parent;
     static constexpr unsigned StructureFlags = Base::StructureFlags | ProhibitsPropertyCaching | OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | ImplementsHasInstance | OverridesGetPropertyNames | OverridesGetCallData;
@@ -190,6 +183,12 @@ public:
     using Parent::methodTable;
 
 private:
+    JSCallbackObject(JSGlobalObject*, Structure*, JSClassRef, void* data);
+    JSCallbackObject(VM&, JSClassRef, Structure*);
+
+    void finishCreation(JSGlobalObject*);
+    void finishCreation(VM&);
+
     static IsoSubspace* subspaceForImpl(VM&, SubspaceAccess);
     static String className(const JSObject*, VM&);
     static String toStringName(const JSObject*, JSGlobalObject*);
index 73da29d..eb9494e 100644 (file)
@@ -1,3 +1,123 @@
+2020-04-20  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Classes marked final should not use protected access specifier
+        https://bugs.webkit.org/show_bug.cgi?id=210775
+
+        Reviewed by Daniel Bates.
+
+        * API/JSAPIValueWrapper.h:
+        * API/JSCallbackConstructor.h:
+        * API/JSCallbackObject.h:
+        * b3/B3ExtractValue.h:
+        * bytecode/UnlinkedFunctionExecutable.h:
+        * inspector/JSGlobalObjectConsoleClient.h:
+        * inspector/JSInjectedScriptHost.h:
+        * inspector/JSJavaScriptCallFrame.h:
+        * jsc.cpp:
+        * runtime/AggregateError.h:
+        * runtime/AggregateErrorPrototype.h:
+        * runtime/ArrayConstructor.h:
+        * runtime/ArrayPrototype.h:
+        * runtime/AsyncFunctionPrototype.h:
+        * runtime/AsyncGeneratorFunctionPrototype.h:
+        * runtime/AtomicsObject.h:
+        * runtime/BigIntConstructor.h:
+        * runtime/BigIntObject.h:
+        * runtime/BigIntPrototype.h:
+        * runtime/BooleanConstructor.h:
+        * runtime/BooleanPrototype.h:
+        * runtime/ConsoleObject.h:
+        * runtime/DateConstructor.h:
+        * runtime/DatePrototype.h:
+        * runtime/ErrorConstructor.h:
+        * runtime/ErrorPrototype.h:
+        * runtime/FileBasedFuzzerAgent.h:
+        * runtime/FunctionPrototype.h:
+        * runtime/FunctionRareData.h:
+        * runtime/GeneratorFunctionPrototype.h:
+        * runtime/GenericTypedArrayView.h:
+        * runtime/InspectorInstrumentationObject.h:
+        * runtime/IntlCollator.h:
+        * runtime/IntlCollatorConstructor.h:
+        * runtime/IntlCollatorPrototype.h:
+        * runtime/IntlDateTimeFormat.h:
+        * runtime/IntlDateTimeFormatConstructor.h:
+        * runtime/IntlDateTimeFormatPrototype.h:
+        * runtime/IntlNumberFormat.h:
+        * runtime/IntlNumberFormatConstructor.h:
+        * runtime/IntlNumberFormatPrototype.h:
+        * runtime/IntlPluralRules.h:
+        * runtime/IntlPluralRulesConstructor.h:
+        * runtime/IntlPluralRulesPrototype.h:
+        * runtime/IntlRelativeTimeFormatConstructor.h:
+        * runtime/IntlRelativeTimeFormatPrototype.h:
+        * runtime/JSArrayBuffer.h:
+        * runtime/JSArrayBufferConstructor.h:
+        * runtime/JSArrayBufferPrototype.h:
+        * runtime/JSAsyncGenerator.h:
+        * runtime/JSBoundFunction.h:
+        * runtime/JSCustomGetterSetterFunction.h:
+        * runtime/JSDataView.h:
+        * runtime/JSDataViewPrototype.h:
+        * runtime/JSGenerator.h:
+        * runtime/JSGenericTypedArrayView.h:
+        * runtime/JSGenericTypedArrayViewConstructor.h:
+        * runtime/JSGenericTypedArrayViewPrototype.h:
+        * runtime/JSGlobalLexicalEnvironment.h:
+        * runtime/JSModuleLoader.h:
+        * runtime/JSModuleNamespaceObject.h:
+        * runtime/JSNativeStdFunction.h:
+        * runtime/JSONObject.h:
+        * runtime/JSObject.h:
+        * runtime/JSTemplateObjectDescriptor.h:
+        * runtime/JSTypedArrayViewConstructor.h:
+        * runtime/JSTypedArrayViewPrototype.h:
+        * runtime/MathObject.h:
+        * runtime/NativeExecutable.h:
+        * runtime/NumberConstructor.h:
+        * runtime/NumberPrototype.h:
+        * runtime/ObjectConstructor.h:
+        * runtime/ObjectPrototype.h:
+        * runtime/PredictionFileCreatingFuzzerAgent.h:
+        * runtime/ReflectObject.h:
+        * runtime/RegExp.h:
+        * runtime/RegExpConstructor.h:
+        * runtime/RegExpObject.h:
+        * runtime/RegExpPrototype.h:
+        * runtime/StringPrototype.h:
+        * runtime/Structure.h:
+        * runtime/Symbol.h:
+        * runtime/SymbolConstructor.h:
+        * runtime/SymbolObject.h:
+        * runtime/SymbolPrototype.h:
+        * runtime/VMTraps.cpp:
+        * testRegExp.cpp:
+        * wasm/WasmBBQPlan.h:
+        * wasm/WasmLLIntPlan.h:
+        * wasm/WasmWorklist.cpp:
+        * wasm/js/JSWebAssembly.h:
+        * wasm/js/JSWebAssemblyCompileError.h:
+        * wasm/js/JSWebAssemblyInstance.h:
+        * wasm/js/JSWebAssemblyLinkError.h:
+        * wasm/js/JSWebAssemblyRuntimeError.h:
+        * wasm/js/WebAssemblyCompileErrorConstructor.h:
+        * wasm/js/WebAssemblyCompileErrorPrototype.h:
+        * wasm/js/WebAssemblyGlobalConstructor.h:
+        * wasm/js/WebAssemblyGlobalPrototype.h:
+        * wasm/js/WebAssemblyInstanceConstructor.h:
+        * wasm/js/WebAssemblyInstancePrototype.h:
+        * wasm/js/WebAssemblyLinkErrorConstructor.h:
+        * wasm/js/WebAssemblyLinkErrorPrototype.h:
+        * wasm/js/WebAssemblyMemoryConstructor.h:
+        * wasm/js/WebAssemblyMemoryPrototype.h:
+        * wasm/js/WebAssemblyModuleConstructor.h:
+        * wasm/js/WebAssemblyModulePrototype.h:
+        * wasm/js/WebAssemblyRuntimeErrorConstructor.h:
+        * wasm/js/WebAssemblyRuntimeErrorPrototype.h:
+        * wasm/js/WebAssemblyTableConstructor.h:
+        * wasm/js/WebAssemblyTablePrototype.h:
+        * wasm/js/WebAssemblyWrapperFunction.h:
+
 2020-04-20  Peng Liu  <peng.liu6@apple.com>
 
         Fix build failures when video fullscreen and picture-in-picture is disabled
index 99384d9..2125b7b 100644 (file)
@@ -42,7 +42,7 @@ public:
     B3_SPECIALIZE_VALUE_FOR_FIXED_CHILDREN(1)
     B3_SPECIALIZE_VALUE_FOR_FINAL_SIZE_FIXED_CHILDREN
 
-protected:
+private:
     void dumpMeta(CommaPrinter&, PrintStream&) const override;
 
     static Opcode opcodeFromConstructor(Origin, Type, Value*, int32_t) { return Extract; }
@@ -53,7 +53,6 @@ protected:
     {
     }
 
-private:
     friend class Procedure;
     friend class Value;
 
index 6c721eb..8ffe300 100644 (file)
@@ -232,6 +232,8 @@ private:
     UnlinkedFunctionExecutable(VM&, Structure*, const SourceCode&, FunctionMetadataNode*, UnlinkedFunctionKind, ConstructAbility, JSParserScriptMode, Optional<CompactVariableMap::Handle>,  JSC::DerivedContextType, JSC::NeedsClassFieldInitializer, bool isBuiltinDefaultClassConstructor);
     UnlinkedFunctionExecutable(Decoder&, const CachedFunctionExecutable&);
 
+    static void visitChildren(JSCell*, SlotVisitor&);
+
     void decodeCachedCodeBlocks(VM&);
 
     bool codeBlockEdgeMayBeWeak() const
@@ -294,9 +296,6 @@ private:
 
     std::unique_ptr<RareData> m_rareData;
 
-protected:
-    static void visitChildren(JSCell*, SlotVisitor&);
-
 public:
     static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue proto)
     {
index 3e4a1ff..e172793 100644 (file)
@@ -47,7 +47,7 @@ public:
     void setInspectorDebuggerAgent(InspectorDebuggerAgent* agent) { m_debuggerAgent = agent; }
     void setInspectorScriptProfilerAgent(InspectorScriptProfilerAgent* agent) { m_scriptProfilerAgent = agent; }
 
-protected:
+private:
     void messageWithTypeAndLevel(MessageType, MessageLevel, JSC::JSGlobalObject*, Ref<ScriptArguments>&&) override;
     void count(JSC::JSGlobalObject*, const String& label) override;
     void countReset(JSC::JSGlobalObject*, const String& label) override;
@@ -62,7 +62,6 @@ protected:
     void recordEnd(JSC::JSGlobalObject*, Ref<ScriptArguments>&&) override;
     void screenshot(JSC::JSGlobalObject*, Ref<ScriptArguments>&&) override;
 
-private:
     void warnUnimplemented(const String& method);
     void internalAddMessage(MessageType, MessageLevel, JSC::JSGlobalObject*, Ref<ScriptArguments>&&);
 
index 9ecab8c..b9f6883 100644 (file)
@@ -83,11 +83,9 @@ public:
     JSC::JSValue queryInstances(JSC::JSGlobalObject*, JSC::CallFrame*);
     JSC::JSValue queryHolders(JSC::JSGlobalObject*, JSC::CallFrame*);
 
-protected:
-    void finishCreation(JSC::VM&);
-
 private:
     JSInjectedScriptHost(JSC::VM&, JSC::Structure*, Ref<InjectedScriptHost>&&);
+    void finishCreation(JSC::VM&);
 
     Ref<InjectedScriptHost> m_wrapped;
 };
index b0228ef..1b05f46 100644 (file)
@@ -86,12 +86,10 @@ public:
     static constexpr unsigned short GLOBAL_LEXICAL_ENVIRONMENT_SCOPE = 5;
     static constexpr unsigned short NESTED_LEXICAL_SCOPE = 6;
 
-protected:
-    void finishCreation(JSC::VM&);
-
 private:
     JSJavaScriptCallFrame(JSC::VM&, JSC::Structure*, Ref<JavaScriptCallFrame>&&);
     ~JSJavaScriptCallFrame();
+    void finishCreation(JSC::VM&);
 
     JavaScriptCallFrame* m_impl;
 };
index 3814d69..b34f01e 100644 (file)
@@ -460,11 +460,8 @@ static inline String stringFromUTF(const Vector& utf8)
 }
 
 class GlobalObject final : public JSGlobalObject {
-private:
-    GlobalObject(VM&, Structure*);
-
 public:
-    typedef JSGlobalObject Base;
+    using Base = JSGlobalObject;
 
     static GlobalObject* create(VM& vm, Structure* structure, const Vector<String>& arguments)
     {
@@ -483,7 +480,9 @@ public:
 
     static RuntimeFlags javaScriptRuntimeFlags(const JSGlobalObject*) { return RuntimeFlags::createAllEnabled(); }
 
-protected:
+private:
+    GlobalObject(VM&, Structure*);
+
     void finishCreation(VM& vm, const Vector<String>& arguments)
     {
         Base::finishCreation(vm);
index 7a22964..8b875dd 100644 (file)
@@ -81,10 +81,9 @@ public:
         return m_errors;
     }
 
-protected:
+private:
     explicit AggregateError(VM&, Structure*, const MarkedArgumentBuffer& errors);
 
-private:
     Vector<WriteBarrier<Unknown>> m_errors;
 };
 
index 7145b25..37830fd 100644 (file)
@@ -37,9 +37,6 @@
 namespace JSC {
 
 class AggregateErrorPrototype final : public ErrorPrototypeBase {
-private:
-    AggregateErrorPrototype(VM&, Structure*);
-
 public:
     using Base = ErrorPrototypeBase;
 
@@ -62,7 +59,8 @@ public:
         return prototype;
     }
 
-protected:
+private:
+    AggregateErrorPrototype(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
 
index 119fea0..530e634 100644 (file)
@@ -49,11 +49,9 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(InternalFunctionType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&, JSGlobalObject*, ArrayPrototype*, GetterSetter* speciesSymbol);
-
 private:
     ArrayConstructor(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*, ArrayPrototype*, GetterSetter* speciesSymbol);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(ArrayConstructor, InternalFunction);
 
index a520154..53ef69a 100644 (file)
@@ -25,9 +25,6 @@
 namespace JSC {
 
 class ArrayPrototype final : public JSArray {
-private:
-    ArrayPrototype(VM&, Structure*);
-
 public:
     using Base = JSArray;
 
@@ -46,7 +43,8 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(DerivedArrayType, StructureFlags), info(), ArrayClass);
     }
 
-protected:
+private:
+    ArrayPrototype(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(ArrayPrototype, ArrayPrototype::Base);
index afb9a22..47e6725 100644 (file)
@@ -54,11 +54,9 @@ public:
         return Structure::create(vm, globalObject, proto, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&);
-
 private:
     AsyncFunctionPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 47d4644..935b710 100644 (file)
@@ -54,11 +54,9 @@ public:
         return Structure::create(vm, globalObject, proto, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&);
-
 private:
     AsyncGeneratorFunctionPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 523a578..086f5ed 100644 (file)
@@ -30,9 +30,6 @@
 namespace JSC {
 
 class AtomicsObject final : public JSNonFinalObject {
-private:
-    AtomicsObject(VM&, Structure*);
-
 public:
     using Base = JSNonFinalObject;
 
@@ -49,7 +46,8 @@ public:
     
     static Structure* createStructure(VM&, JSGlobalObject*, JSValue);
 
-protected:
+private:
+    AtomicsObject(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
 
index 18c4606..1b911b9 100644 (file)
@@ -52,11 +52,9 @@ public:
         return Structure::create(vm, globalObject, proto, TypeInfo(InternalFunctionType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&, BigIntPrototype*);
-
 private:
     BigIntConstructor(VM&, Structure*);
+    void finishCreation(VM&, BigIntPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(BigIntConstructor, InternalFunction);
 
index deccfde..e259567 100644 (file)
@@ -55,7 +55,7 @@ public:
 
     static String toStringName(const JSObject*, JSGlobalObject*);
 
-protected:
+private:
     JS_EXPORT_PRIVATE void finishCreation(VM&, JSValue);
     JS_EXPORT_PRIVATE BigIntObject(VM&, Structure*);
 };
index d9e5f3e..7c52e4b 100644 (file)
@@ -56,11 +56,9 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&, JSGlobalObject*);
-
 private:
     BigIntPrototype(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*);
 };
 
 } // namespace JSC
index efafca8..e63b950 100644 (file)
@@ -45,11 +45,9 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(InternalFunctionType, StructureFlags), info()); 
     }
 
-protected:
-    void finishCreation(VM&, BooleanPrototype*);
-
 private:
     BooleanConstructor(VM&, Structure*);
+    void finishCreation(VM&, BooleanPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(BooleanConstructor, InternalFunction);
 
index 2d2008c..0aab055 100644 (file)
@@ -43,11 +43,9 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&, JSGlobalObject*);
-
 private:
     BooleanPrototype(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(BooleanPrototype, BooleanObject);
 
index 4671942..4ddaa5d 100644 (file)
@@ -30,9 +30,6 @@
 namespace JSC {
 
 class ConsoleObject final : public JSNonFinalObject {
-private:
-    ConsoleObject(VM&, Structure*);
-
 public:
     using Base = JSNonFinalObject;
 
@@ -57,7 +54,8 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
+private:
+    ConsoleObject(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
 
index 92b8ed3..b324e05 100644 (file)
@@ -46,11 +46,9 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(InternalFunctionType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&, DatePrototype*);
-
 private:
     DateConstructor(VM&, Structure*);
+    void finishCreation(VM&, DatePrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(DateConstructor, InternalFunction);
 
index a8886b1..eeaad37 100644 (file)
@@ -27,9 +27,6 @@ namespace JSC {
 class ObjectPrototype;
 
 class DatePrototype final : public JSNonFinalObject {
-private:
-    DatePrototype(VM&, Structure*);
-
 public:
     using Base = JSNonFinalObject;
     static constexpr unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
@@ -55,7 +52,8 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
+private:
+    DatePrototype(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
 
index 9a5a463..6e1beaa 100644 (file)
@@ -45,15 +45,12 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(InternalFunctionType, StructureFlags), info()); 
     }
 
-protected:
+private:
+    ErrorConstructor(VM&, Structure*);
     void finishCreation(VM&, ErrorPrototype*);
 
     static bool put(JSCell*, JSGlobalObject*, PropertyName, JSValue, PutPropertySlot&);
     static bool deleteProperty(JSCell*, JSGlobalObject*, PropertyName, DeletePropertySlot&);
-
-private:
-    ErrorConstructor(VM&, Structure*);
-
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(ErrorConstructor, InternalFunction);
 
index ba1e5b5..25be087 100644 (file)
@@ -62,7 +62,7 @@ public:
         return prototype;
     }
 
-protected:
+private:
     ErrorPrototype(VM&, Structure*);
 };
 
index c92911f..75e0335 100644 (file)
@@ -37,7 +37,7 @@ class FileBasedFuzzerAgent final : public FileBasedFuzzerAgentBase {
 public:
     FileBasedFuzzerAgent(VM&);
 
-protected:
+private:
     SpeculatedType getPredictionInternal(CodeBlock*, PredictionTarget&, SpeculatedType original) override;
 };
 
index 96b034a..56b2754 100644 (file)
@@ -46,11 +46,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&, const String& name);
-
 private:
     FunctionPrototype(VM&, Structure*);
+    void finishCreation(VM&, const String& name);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(FunctionPrototype, InternalFunction);
 
index de5e0b0..8ea6ac0 100644 (file)
@@ -138,13 +138,12 @@ public:
     Watchpoint* createAllocationProfileClearingWatchpoint();
     class AllocationProfileClearingWatchpoint;
 
-protected:
-    explicit FunctionRareData(VM&, ExecutableBase*);
-    ~FunctionRareData();
-
 private:
     friend class LLIntOffsetsExtractor;
 
+    explicit FunctionRareData(VM&, ExecutableBase*);
+    ~FunctionRareData();
+
     // Ideally, there would only be one allocation profile for subclassing but due to Reflect.construct we
     // have two. There are some pros and cons in comparison to our current system to using the same profile
     // for both JS constructors and subclasses of builtin constructors:
index 48ebfd3..657ab06 100644 (file)
@@ -56,11 +56,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     GeneratorFunctionPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 81ed08a..4f864ed 100644 (file)
@@ -32,9 +32,6 @@ namespace JSC {
 
 template<typename Adaptor>
 class GenericTypedArrayView final : public ArrayBufferView {
-protected:
-    GenericTypedArrayView(RefPtr<ArrayBuffer>&&, unsigned byteOffset, unsigned length);
-
 public:
     static Ref<GenericTypedArrayView> create(unsigned length);
     static Ref<GenericTypedArrayView> create(const typename Adaptor::Type* array, unsigned length);
@@ -119,6 +116,9 @@ public:
     }
 
     JSArrayBufferView* wrap(JSGlobalObject*, JSGlobalObject*) override;
+
+private:
+    GenericTypedArrayView(RefPtr<ArrayBuffer>&&, unsigned byteOffset, unsigned length);
 };
 
 } // namespace JSC
index 6d6e1ff..93236a1 100644 (file)
@@ -30,9 +30,6 @@
 namespace JSC {
 
 class InspectorInstrumentationObject final : public JSNonFinalObject {
-private:
-    InspectorInstrumentationObject(VM&, Structure*);
-
 public:
     using Base = JSNonFinalObject;
     static constexpr unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
@@ -62,7 +59,8 @@ public:
     void disable(VM&);
     bool isEnabled(VM&) const;
 
-protected:
+private:
+    InspectorInstrumentationObject(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
 
index 7bfaef7..48a5371 100644 (file)
@@ -62,12 +62,11 @@ public:
     JSBoundFunction* boundCompare() const { return m_boundCompare.get(); }
     void setBoundCompare(VM&, JSBoundFunction*);
 
-protected:
+private:
     IntlCollator(VM&, Structure*);
     void finishCreation(VM&);
     static void visitChildren(JSCell*, SlotVisitor&);
 
-private:
     enum class Usage : uint8_t { Sort, Search };
     enum class Sensitivity : uint8_t { Base, Accent, Case, Variant };
     enum class CaseFirst : uint8_t { Upper, Lower, False };
index f77abee..7901b2f 100644 (file)
@@ -45,11 +45,9 @@ public:
 
     Structure* collatorStructure(VM&) const { return globalObject()->collatorStructure(); }
 
-protected:
-    void finishCreation(VM&, IntlCollatorPrototype*);
-
 private:
     IntlCollatorConstructor(VM&, Structure*);
+    void finishCreation(VM&, IntlCollatorPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(IntlCollatorConstructor, InternalFunction);
 
index e05fc8d..a41cb59 100644 (file)
@@ -47,11 +47,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     IntlCollatorPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index d845514..e5c94e9 100644 (file)
@@ -62,12 +62,11 @@ public:
     JSBoundFunction* boundFormat() const { return m_boundFormat.get(); }
     void setBoundFormat(VM&, JSBoundFunction*);
 
-protected:
+private:
     IntlDateTimeFormat(VM&, Structure*);
     void finishCreation(VM&);
     static void visitChildren(JSCell*, SlotVisitor&);
 
-private:
     enum class Weekday : uint8_t { None, Narrow, Short, Long };
     enum class Era : uint8_t { None, Narrow, Short, Long };
     enum class Year : uint8_t { None, TwoDigit, Numeric };
index 2a061ec..5500c3d 100644 (file)
@@ -45,11 +45,9 @@ public:
 
     Structure* dateTimeFormatStructure(VM&) const { return globalObject()->dateTimeFormatStructure(); }
 
-protected:
-    void finishCreation(VM&, IntlDateTimeFormatPrototype*);
-
 private:
     IntlDateTimeFormatConstructor(VM&, Structure*);
+    void finishCreation(VM&, IntlDateTimeFormatPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(IntlDateTimeFormatConstructor, InternalFunction);
 
index 0e410da..df12d43 100644 (file)
@@ -47,11 +47,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     IntlDateTimeFormatPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 1a9bc61..f5c62ad 100644 (file)
@@ -66,12 +66,11 @@ public:
 
     static void formatToPartsInternal(JSGlobalObject*, double, const String& formatted, UFieldPositionIterator*, JSArray*, JSString* unit = nullptr);
 
-protected:
+private:
     IntlNumberFormat(VM&, Structure*);
     void finishCreation(VM&);
     static void visitChildren(JSCell*, SlotVisitor&);
 
-private:
     enum class Style : uint8_t { Decimal, Percent, Currency };
     enum class CurrencyDisplay : uint8_t { Code, Symbol, Name };
 
index 5b52002..c9c005e 100644 (file)
@@ -45,11 +45,9 @@ public:
 
     Structure* numberFormatStructure(VM&) const { return globalObject()->numberFormatStructure(); }
 
-protected:
-    void finishCreation(VM&, IntlNumberFormatPrototype*);
-
 private:
     IntlNumberFormatConstructor(VM&, Structure*);
+    void finishCreation(VM&, IntlNumberFormatPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(IntlNumberFormatConstructor, InternalFunction);
 
index 69de245..6175f9d 100644 (file)
@@ -47,11 +47,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     IntlNumberFormatPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index c5ea635..708d79b 100644 (file)
@@ -57,12 +57,11 @@ public:
     JSValue select(JSGlobalObject*, double value);
     JSObject* resolvedOptions(JSGlobalObject*);
 
-protected:
+private:
     IntlPluralRules(VM&, Structure*);
     void finishCreation(VM&);
     static void visitChildren(JSCell*, SlotVisitor&);
 
-private:
     struct UPluralRulesDeleter {
         void operator()(UPluralRules*) const;
     };
index 92237d1..7f3d03f 100644 (file)
@@ -45,11 +45,9 @@ public:
 
     Structure* pluralRulesStructure(VM&) const { return globalObject()->pluralRulesStructure(); }
 
-protected:
-    void finishCreation(VM&, IntlPluralRulesPrototype*);
-
 private:
     IntlPluralRulesConstructor(VM&, Structure*);
+    void finishCreation(VM&, IntlPluralRulesPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(IntlPluralRulesConstructor, InternalFunction);
 
index 9a1c2f1..6faa3a4 100644 (file)
@@ -47,11 +47,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     IntlPluralRulesPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index c8ccff2..96ae75b 100644 (file)
@@ -44,11 +44,9 @@ public:
 
     Structure* relativeTimeFormatStructure(VM&) const { return globalObject()->relativeTimeFormatStructure(); }
 
-protected:
-    void finishCreation(VM&, IntlRelativeTimeFormatPrototype*);
-
 private:
     IntlRelativeTimeFormatConstructor(VM&, Structure*);
+    void finishCreation(VM&, IntlRelativeTimeFormatPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(IntlRelativeTimeFormatConstructor, InternalFunction);
 
index ccbaea8..e00ebf0 100644 (file)
@@ -46,11 +46,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     IntlRelativeTimeFormatPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index ba2e672..6bea4cf 100644 (file)
@@ -40,12 +40,7 @@ public:
     {
         return vm.arrayBufferSpace<mode>();
     }
-    
-protected:
-    JSArrayBuffer(VM&, Structure*, RefPtr<ArrayBuffer>&&);
-    void finishCreation(VM&, JSGlobalObject*);
-    
-public:
+
     // This function will register the new wrapper with the vm's TypedArrayController.
     JS_EXPORT_PRIVATE static JSArrayBuffer* create(VM&, Structure*, RefPtr<ArrayBuffer>&&);
 
@@ -61,10 +56,12 @@ public:
     // This is the default DOM unwrapping. It calls toUnsharedArrayBuffer().
     static ArrayBuffer* toWrapped(VM&, JSValue);
     
-protected:
+private:
+    JSArrayBuffer(VM&, Structure*, RefPtr<ArrayBuffer>&&);
+    void finishCreation(VM&, JSGlobalObject*);
+
     static size_t estimatedSize(JSCell*, VM&);
 
-private:
     ArrayBuffer* m_impl;
 };
 
index 43139f6..f65e020 100644 (file)
@@ -38,13 +38,6 @@ class JSGenericArrayBufferConstructor final : public InternalFunction {
 public:
     using Base = InternalFunction;
 
-protected:
-    JSGenericArrayBufferConstructor(VM&, Structure*);
-    void finishCreation(VM&, JSArrayBufferPrototype*, GetterSetter* speciesSymbol);
-
-    static EncodedJSValue JSC_HOST_CALL constructArrayBuffer(JSGlobalObject*, CallFrame*);
-
-public:
     static JSGenericArrayBufferConstructor* create(VM& vm, Structure* structure, JSArrayBufferPrototype* prototype, GetterSetter* speciesSymbol)
     {
         JSGenericArrayBufferConstructor* result =
@@ -57,6 +50,12 @@ public:
     
     static const ClassInfo s_info; // This is never accessed directly, since that would break linkage on some compilers.
     static const ClassInfo* info();
+
+private:
+    JSGenericArrayBufferConstructor(VM&, Structure*);
+    void finishCreation(VM&, JSArrayBufferPrototype*, GetterSetter* speciesSymbol);
+
+    static EncodedJSValue JSC_HOST_CALL constructArrayBuffer(JSGlobalObject*, CallFrame*);
 };
 
 using JSArrayBufferConstructor = JSGenericArrayBufferConstructor<ArrayBufferSharingMode::Default>;
index fb44487..c00cb71 100644 (file)
@@ -40,16 +40,15 @@ public:
         return &vm.plainObjectSpace;
     }
 
-protected:
-    JSArrayBufferPrototype(VM&, Structure*);
-    void finishCreation(VM&, JSGlobalObject*, ArrayBufferSharingMode);
-
-public:
     static JSArrayBufferPrototype* create(VM&, JSGlobalObject*, Structure*, ArrayBufferSharingMode = ArrayBufferSharingMode::Default);
     
     DECLARE_INFO;
     
     static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
+
+private:
+    JSArrayBufferPrototype(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*, ArrayBufferSharingMode);
 };
 
 } // namespace JSC
index 27d5279..6a90e97 100644 (file)
@@ -97,7 +97,7 @@ public:
 
     static void visitChildren(JSCell*, SlotVisitor&);
 
-protected:
+private:
     JSAsyncGenerator(VM&, Structure*);
     void finishCreation(VM&);
 };
index d8d16c8..e642ae3 100644 (file)
@@ -80,13 +80,11 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    static void visitChildren(JSCell*, SlotVisitor&);
-
 private:
     JSBoundFunction(VM&, NativeExecutable*, JSGlobalObject*, Structure*, JSObject* targetFunction, JSValue boundThis, JSImmutableButterfly* boundArgs, JSString* nameMayBeNull, int length);
-    
+
     void finishCreation(VM&, NativeExecutable*, int length);
+    static void visitChildren(JSCell*, SlotVisitor&);
 
     WriteBarrier<JSObject> m_targetFunction;
     WriteBarrier<Unknown> m_boundThis;
index 86385b4..2e0c745 100644 (file)
@@ -56,12 +56,10 @@ public:
 
     DECLARE_EXPORT_INFO;
 
-protected:
-    static void visitChildren(JSCell*, SlotVisitor&);
-
 private:
     JSCustomGetterSetterFunction(VM&, NativeExecutable*, JSGlobalObject*, Structure*, Type, const PropertyName&);
     void finishCreation(VM&, NativeExecutable*, CustomGetterSetter*, const String&);
+    static void visitChildren(JSCell*, SlotVisitor&);
 
     static EncodedJSValue JSC_HOST_CALL customGetterSetterFunctionCall(JSGlobalObject*, CallFrame*);
 
index 98a8cc8..edf61d5 100644 (file)
@@ -40,11 +40,7 @@ public:
     {
         return vm.dataViewSpace<mode>();
     }
-    
-protected:
-    JSDataView(VM&, ConstructionContext&, ArrayBuffer*);
-    
-public:
+
     JS_EXPORT_PRIVATE static JSDataView* create(
         JSGlobalObject*, Structure*, RefPtr<ArrayBuffer>&&, unsigned byteOffset,
         unsigned byteLength);
@@ -68,7 +64,13 @@ public:
     
     static const TypedArrayType TypedArrayStorageType = TypeDataView;
 
-protected:
+    static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
+    
+    DECLARE_EXPORT_INFO;
+
+private:
+    JSDataView(VM&, ConstructionContext&, ArrayBuffer*);
+
     static bool getOwnPropertySlot(JSObject*, JSGlobalObject*, PropertyName, PropertySlot&);
     static bool put(JSCell*, JSGlobalObject*, PropertyName, JSValue, PutPropertySlot&);
     static bool defineOwnProperty(JSObject*, JSGlobalObject*, PropertyName, const PropertyDescriptor&, bool shouldThrow);
@@ -76,12 +78,6 @@ protected:
 
     static void getOwnNonIndexPropertyNames(JSObject*, JSGlobalObject*, PropertyNameArray&, EnumerationMode);
 
-public:
-    static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
-    
-    DECLARE_EXPORT_INFO;
-
-private:
     ArrayBuffer* m_buffer;
 };
 
index 5b68504..912f7a3 100644 (file)
@@ -41,17 +41,15 @@ public:
         return &vm.plainObjectSpace;
     }
 
-protected:
-    JSDataViewPrototype(VM&, Structure*);
-
-    void finishCreation(VM&);
-
-public:
     static JSDataViewPrototype* create(VM&, Structure*);
     
     DECLARE_INFO;
     
     static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
+
+private:
+    JSDataViewPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 6d61ab5..fc4c2e5 100644 (file)
@@ -96,7 +96,7 @@ public:
 
     static void visitChildren(JSCell*, SlotVisitor&);
 
-protected:
+private:
     JSGenerator(VM&, Structure*);
     void finishCreation(VM&);
 };
index 3b7bbde..3064be5 100644 (file)
@@ -99,11 +99,7 @@ public:
     static constexpr unsigned StructureFlags = Base::StructureFlags | OverridesGetPropertyNames | OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero;
 
     static constexpr unsigned elementSize = sizeof(typename Adaptor::Type);
-    
-protected:
-    JSGenericTypedArrayView(VM&, ConstructionContext&);
-    
-public:
+
     static JSGenericTypedArrayView* create(JSGlobalObject*, Structure*, unsigned length);
     static JSGenericTypedArrayView* createWithFastVector(JSGlobalObject*, Structure*, unsigned length, void* vector);
     static JSGenericTypedArrayView* createUninitialized(JSGlobalObject*, Structure*, unsigned length);
@@ -297,9 +293,11 @@ public:
     // This is the default DOM unwrapping. It calls toUnsharedNativeTypedView().
     static RefPtr<typename Adaptor::ViewType> toWrapped(VM&, JSValue);
     
-protected:
+private:
     friend struct TypedArrayClassInfos;
 
+    JSGenericTypedArrayView(VM&, ConstructionContext&);
+
     static EncodedJSValue throwNeuteredTypedArrayTypeError(JSGlobalObject*, EncodedJSValue, PropertyName);
 
     static bool getOwnPropertySlot(JSObject*, JSGlobalObject*, PropertyName, PropertySlot&);
@@ -316,7 +314,6 @@ protected:
     static size_t estimatedSize(JSCell*, VM&);
     static void visitChildren(JSCell*, SlotVisitor&);
 
-private:
     // Returns true if successful, and false on error; it will throw on error.
     template<typename OtherAdaptor>
     bool setWithSpecificType(
index 1fb60cb..4dc4aea 100644 (file)
@@ -32,13 +32,8 @@ namespace JSC {
 template<typename ViewClass>
 class JSGenericTypedArrayViewConstructor final : public InternalFunction {
 public:
-    typedef InternalFunction Base;
+    using Base = InternalFunction;
 
-protected:
-    JSGenericTypedArrayViewConstructor(VM&, Structure*);
-    void finishCreation(VM&, JSGlobalObject*, JSObject* prototype, const String& name, FunctionExecutable* privateAllocator);
-
-public:
     static JSGenericTypedArrayViewConstructor* create(
         VM&, JSGlobalObject*, Structure*, JSObject* prototype, const String& name, FunctionExecutable* privateAllocator);
 
@@ -48,6 +43,10 @@ public:
     IGNORE_CLANG_WARNINGS_END
 
     static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
+
+private:
+    JSGenericTypedArrayViewConstructor(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*, JSObject* prototype, const String& name, FunctionExecutable* privateAllocator);
 };
 
 } // namespace JSC
index 329dd43..6feacb8 100644 (file)
@@ -41,11 +41,6 @@ public:
         return &vm.plainObjectSpace;
     }
 
-protected:
-    JSGenericTypedArrayViewPrototype(VM&, Structure*);
-    void finishCreation(VM&, JSGlobalObject*);
-
-public:
     static JSGenericTypedArrayViewPrototype* create(
         VM&, JSGlobalObject*, Structure*);
 
@@ -55,6 +50,10 @@ public:
     IGNORE_CLANG_WARNINGS_END
     
     static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
+
+private:
+    JSGenericTypedArrayViewPrototype(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*);
 };
 
 } // namespace JSC
index 36feb90..8beb9ed 100644 (file)
@@ -66,7 +66,7 @@ public:
         return Structure::create(vm, globalObject, jsNull(), TypeInfo(GlobalLexicalEnvironmentType, StructureFlags), info());
     }
 
-protected:
+private:
     JSGlobalLexicalEnvironment(VM& vm, Structure* structure, JSScope* scope)
         : Base(vm, structure, scope)
     {
index 7d49fae..1e06b77 100644 (file)
@@ -36,8 +36,6 @@ class JSModuleRecord;
 class SourceCode;
 
 class JSModuleLoader final : public JSNonFinalObject {
-private:
-    JSModuleLoader(VM&, Structure*);
 public:
     using Base = JSNonFinalObject;
     static constexpr unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
@@ -93,7 +91,8 @@ public:
     JSModuleNamespaceObject* getModuleNamespaceObject(JSGlobalObject*, JSValue moduleRecord);
     JSArray* dependencyKeysIfEvaluated(JSGlobalObject*, JSValue key);
 
-protected:
+private:
+    JSModuleLoader(VM&, Structure*);
     void finishCreation(JSGlobalObject*, VM&);
 };
 
index 811364d..f8107ed 100644 (file)
@@ -69,11 +69,9 @@ public:
 
     AbstractModuleRecord* moduleRecord() { return m_moduleRecord.get(); }
 
-protected:
-    JS_EXPORT_PRIVATE void finishCreation(JSGlobalObject*, AbstractModuleRecord*, Vector<std::pair<Identifier, AbstractModuleRecord::Resolution>>&&);
-    JS_EXPORT_PRIVATE JSModuleNamespaceObject(VM&, Structure*);
-
 private:
+    JS_EXPORT_PRIVATE JSModuleNamespaceObject(VM&, Structure*);
+    JS_EXPORT_PRIVATE void finishCreation(JSGlobalObject*, AbstractModuleRecord*, Vector<std::pair<Identifier, AbstractModuleRecord::Resolution>>&&);
     static void visitChildren(JSCell*, SlotVisitor&);
     bool getOwnPropertySlotCommon(JSGlobalObject*, PropertyName, PropertySlot&);
 
index 304a0f9..0a2360f 100644 (file)
@@ -62,13 +62,10 @@ public:
 
     const NativeStdFunction& function() { return m_function; }
 
-protected:
-    static void visitChildren(JSCell*, SlotVisitor&);
-
-    void finishCreation(VM&, NativeExecutable*, int length, const String& name);
-
 private:
     JSNativeStdFunction(VM&, NativeExecutable*, JSGlobalObject*, Structure*, NativeStdFunction&&);
+    void finishCreation(VM&, NativeExecutable*, int length, const String& name);
+    static void visitChildren(JSCell*, SlotVisitor&);
 
     NativeStdFunction m_function;
 };
index ca97e7e..90af372 100644 (file)
@@ -55,11 +55,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     JSONObject(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 JS_EXPORT_PRIVATE JSValue JSONParse(JSGlobalObject*, const String&);
index 1fd12b0..a6878a6 100644 (file)
@@ -1167,24 +1167,23 @@ public:
 
     DECLARE_EXPORT_INFO;
 
-protected:
-    void visitChildrenCommon(SlotVisitor&);
-        
-    void finishCreation(VM& vm)
-    {
-        Base::finishCreation(vm);
-        ASSERT(structure(vm)->totalStorageCapacity() == structure(vm)->inlineCapacity());
-        ASSERT(classInfo(vm));
-    }
-
 private:
     friend class LLIntOffsetsExtractor;
 
+    void visitChildrenCommon(SlotVisitor&);
+
     explicit JSFinalObject(VM& vm, Structure* structure, Butterfly* butterfly = nullptr)
         : JSObject(vm, structure, butterfly)
     {
         gcSafeZeroMemory(inlineStorageUnsafe(), structure->inlineCapacity() * sizeof(EncodedJSValue));
     }
+
+    void finishCreation(VM& vm)
+    {
+        Base::finishCreation(vm);
+        ASSERT(structure(vm)->totalStorageCapacity() == structure(vm)->inlineCapacity());
+        ASSERT(classInfo(vm));
+    }
 };
 
 JS_EXPORT_PRIVATE EncodedJSValue JSC_HOST_CALL objectPrivateFuncInstanceOf(JSGlobalObject*, CallFrame*);
index b8cffb4..40b56fb 100644 (file)
@@ -57,12 +57,11 @@ public:
 
     int endOffset() const { return m_endOffset; }
 
-protected:
-    static void destroy(JSCell*);
-
 private:
     JSTemplateObjectDescriptor(VM&, Ref<TemplateObjectDescriptor>&&, int);
 
+    static void destroy(JSCell*);
+
     Ref<TemplateObjectDescriptor> m_descriptor;
     int m_endOffset { 0 };
 };
index 34a806a..aa8cde5 100644 (file)
@@ -34,13 +34,8 @@ class GetterSetter;
 
 class JSTypedArrayViewConstructor final : public InternalFunction {
 public:
-    typedef InternalFunction Base;
+    using Base = InternalFunction;
 
-protected:
-    JSTypedArrayViewConstructor(VM&, Structure*);
-    void finishCreation(VM&, JSGlobalObject*, JSTypedArrayViewPrototype*, GetterSetter* speciesSymbol);
-
-public:
     static JSTypedArrayViewConstructor* create(VM& vm, JSGlobalObject* globalObject, Structure* structure, JSTypedArrayViewPrototype* prototype, GetterSetter* speciesSymbol)
     {
         JSTypedArrayViewConstructor* result = new (NotNull, allocateCell<JSTypedArrayViewConstructor>(vm.heap)) JSTypedArrayViewConstructor(vm, structure);
@@ -51,6 +46,10 @@ public:
     DECLARE_INFO;
 
     static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
+
+private:
+    JSTypedArrayViewConstructor(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*, JSTypedArrayViewPrototype*, GetterSetter* speciesSymbol);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(JSTypedArrayViewConstructor, InternalFunction);
     
index d38d8b9..72bb934 100644 (file)
@@ -40,16 +40,15 @@ public:
         return &vm.plainObjectSpace;
     }
 
-protected:
-    JSTypedArrayViewPrototype(VM&, Structure*);
-    void finishCreation(VM&, JSGlobalObject*);
-
-public:
     static JSTypedArrayViewPrototype* create(VM&, JSGlobalObject*, Structure*);
 
     DECLARE_INFO;
 
     static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
+
+private:
+    JSTypedArrayViewPrototype(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*);
 };
 
 EncodedJSValue JSC_HOST_CALL typedArrayViewPrivateFuncIsTypedArrayView(JSGlobalObject*, CallFrame*);
index e5f2ff1..cd4e647 100644 (file)
@@ -25,9 +25,6 @@
 namespace JSC {
 
 class MathObject final : public JSNonFinalObject {
-private:
-    MathObject(VM&, Structure*);
-
 public:
     using Base = JSNonFinalObject;
 
@@ -52,7 +49,8 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
+private:
+    MathObject(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
 
index 9f043fa..766c96a 100644 (file)
@@ -76,11 +76,9 @@ public:
     const DOMJIT::Signature* signatureFor(CodeSpecializationKind) const;
     Intrinsic intrinsic() const;
 
-protected:
-    void finishCreation(VM&, Ref<JITCode>&& callThunk, Ref<JITCode>&& constructThunk, const String& name);
-
 private:
     NativeExecutable(VM&, TaggedNativeFunction, TaggedNativeFunction constructor);
+    void finishCreation(VM&, Ref<JITCode>&& callThunk, Ref<JITCode>&& constructThunk, const String& name);
 
     TaggedNativeFunction m_function;
     TaggedNativeFunction m_constructor;
index 0657c1f..f299afb 100644 (file)
@@ -57,11 +57,9 @@ public:
         return std::isfinite(number) && trunc(number) == number;
     }
 
-protected:
-    void finishCreation(VM&, NumberPrototype*);
-
 private:
     NumberConstructor(VM&, Structure*);
+    void finishCreation(VM&, NumberPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(NumberConstructor, InternalFunction);
 
index 2acfd11..3e083ea 100644 (file)
@@ -43,11 +43,9 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(NumberObjectType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&, JSGlobalObject*);
-
 private:
     NumberPrototype(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(NumberPrototype, NumberObject);
 
index 6aab6d7..de436c8 100644 (file)
@@ -53,11 +53,9 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(InternalFunctionType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&, JSGlobalObject*, ObjectPrototype*);
-
 private:
     ObjectConstructor(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*, ObjectPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(ObjectConstructor, InternalFunction);
 
index 56b5cb0..2df6d6e 100644 (file)
@@ -45,11 +45,9 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&, JSGlobalObject*);
-
 private:
     ObjectPrototype(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*);
 };
 
 JS_EXPORT_PRIVATE EncodedJSValue JSC_HOST_CALL objectProtoFuncToString(JSGlobalObject*, CallFrame*);
index d422ead..617028d 100644 (file)
@@ -37,7 +37,7 @@ class PredictionFileCreatingFuzzerAgent final : public FileBasedFuzzerAgentBase
 public:
     PredictionFileCreatingFuzzerAgent(VM&);
 
-protected:
+private:
     SpeculatedType getPredictionInternal(CodeBlock*, PredictionTarget&, SpeculatedType original) override;
 };
 
index 7438e48..7411947 100644 (file)
@@ -30,9 +30,6 @@
 namespace JSC {
 
 class ReflectObject final : public JSNonFinalObject {
-private:
-    ReflectObject(VM&, Structure*);
-
 public:
     using Base = JSNonFinalObject;
     static constexpr unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
@@ -58,7 +55,8 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
+private:
+    ReflectObject(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
 
index faf0289..dd2e1ef 100644 (file)
@@ -139,12 +139,10 @@ public:
 
     RegExpKey key() { return RegExpKey(m_flags, m_patternString); }
 
-protected:
-    void finishCreation(VM&);
-
 private:
     friend class RegExpCache;
     RegExp(VM&, const String&, OptionSet<Yarr::Flags>);
+    void finishCreation(VM&);
 
     static RegExp* createWithoutCaching(VM&, const String&, OptionSet<Yarr::Flags>);
 
index c405ebe..ef79889 100644 (file)
@@ -49,11 +49,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&, RegExpPrototype*, GetterSetter* species);
-
 private:
     RegExpConstructor(VM&, Structure*);
+    void finishCreation(VM&, RegExpPrototype*, GetterSetter* species);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(RegExpConstructor, InternalFunction);
 
index 857ca2e..71bf98b 100644 (file)
@@ -128,7 +128,7 @@ public:
         return sizeof(RegExpObject);
     }
 
-protected:
+private:
     JS_EXPORT_PRIVATE RegExpObject(VM&, Structure*, RegExp*);
     JS_EXPORT_PRIVATE void finishCreation(VM&);
 
@@ -150,7 +150,6 @@ protected:
     JS_EXPORT_PRIVATE static void getGenericPropertyNames(JSObject*, JSGlobalObject*, PropertyNameArray&, EnumerationMode);
     JS_EXPORT_PRIVATE static bool defineOwnProperty(JSObject*, JSGlobalObject*, PropertyName, const PropertyDescriptor&, bool shouldThrow);
 
-private:
     MatchResult matchInline(JSGlobalObject*, JSString*);
 
     uintptr_t m_regExpAndLastIndexIsNotWritableFlag { 0 };
index f6d51ec..fe12c9c 100644 (file)
@@ -51,10 +51,8 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
-    RegExpPrototype(VM&, Structure*);
-
 private:
+    RegExpPrototype(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
 
index 537b0d1..d1321b5 100644 (file)
@@ -30,9 +30,6 @@ class RegExp;
 class RegExpObject;
 
 class StringPrototype final : public StringObject {
-private:
-    StringPrototype(VM&, Structure*);
-
 public:
     using Base = StringObject;
     static constexpr unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
@@ -46,7 +43,8 @@ public:
 
     DECLARE_INFO;
 
-protected:
+private:
+    StringPrototype(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*, JSString*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(StringPrototype, StringObject);
index 1dbdc0c..5ba3d97 100644 (file)
@@ -146,7 +146,7 @@ public:
 
     JS_EXPORT_PRIVATE static bool isValidPrototype(JSValue);
 
-protected:
+private:
     void finishCreation(VM& vm)
     {
         Base::finishCreation(vm);
index 530fe52..49898ad 100644 (file)
@@ -71,7 +71,7 @@ public:
         return OBJECT_OFFSETOF(Symbol, m_privateName);
     }
 
-protected:
+private:
     static void destroy(JSCell*);
 
     Symbol(VM&);
index 194a44e..639537d 100644 (file)
@@ -52,11 +52,9 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(InternalFunctionType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(VM&, SymbolPrototype*);
-
 private:
     SymbolConstructor(VM&, Structure*);
+    void finishCreation(VM&, SymbolPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(SymbolConstructor, InternalFunction);
 
index 9ce480c..9772ab3 100644 (file)
@@ -64,7 +64,7 @@ public:
 
     static String toStringName(const JSObject*, JSGlobalObject*);
 
-protected:
+private:
     JS_EXPORT_PRIVATE void finishCreation(VM&, Symbol*);
     JS_EXPORT_PRIVATE SymbolObject(VM&, Structure*);
 };
index e235f12..88a2d7d 100644 (file)
@@ -58,7 +58,7 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
+private:
     SymbolPrototype(VM&, Structure*);
     void finishCreation(VM&, JSGlobalObject*);
 };
index 8449d45..4fc907a 100644 (file)
@@ -244,7 +244,7 @@ public:
 
     VMTraps& traps() { return m_vm.traps(); }
 
-protected:
+private:
     PollResult poll(const AbstractLocker&) override
     {
         if (traps().m_isShuttingDown)
@@ -288,8 +288,6 @@ protected:
         }
         return WorkResult::Continue;
     }
-    
-private:
 
     VM& m_vm;
 };
index 67b1553..b2db66d 100644 (file)
@@ -103,9 +103,6 @@ struct RegExpTest {
 };
 
 class GlobalObject final : public JSGlobalObject {
-private:
-    GlobalObject(VM&, Structure*, const Vector<String>& arguments);
-
 public:
     using Base = JSGlobalObject;
 
@@ -124,7 +121,9 @@ public:
         return Structure::create(vm, 0, prototype, TypeInfo(GlobalObjectType, StructureFlags), info());
     }
 
-protected:
+private:
+    GlobalObject(VM&, Structure*, const Vector<String>& arguments);
+
     void finishCreation(VM& vm, const Vector<String>& arguments)
     {
         Base::finishCreation(vm);
index 5e2dfdf..294a743 100644 (file)
@@ -75,12 +75,11 @@ public:
         return Base::parseAndValidateModule(m_source.data(), m_source.size());
     }
 
-protected:
+private:
     bool prepareImpl() override;
     void compileFunction(uint32_t functionIndex) override;
     void didCompleteCompilation(const AbstractLocker&) override;
 
-private:
     std::unique_ptr<InternalFunction> compileFunction(uint32_t functionIndex, CompilationContext&, Vector<UnlinkedWasmToWasmCall>&, TierUpCount*);
 
     Vector<std::unique_ptr<InternalFunction>> m_wasmInternalFunctions;
index 42de813..9335b3a 100644 (file)
@@ -75,12 +75,11 @@ public:
 
     bool didReceiveFunctionData(unsigned, const FunctionData&) override;
 
-protected:
+private:
     bool prepareImpl() override;
     void compileFunction(uint32_t functionIndex) override;
     void didCompleteCompilation(const AbstractLocker&) override;
 
-private:
     Vector<std::unique_ptr<FunctionCodeBlock>> m_wasmInternalFunctions;
     const Ref<LLIntCallee>* m_callees { nullptr };
     Vector<Ref<LLIntCallee>> m_calleesVector;
index 4b596d1..fcab441 100644 (file)
@@ -63,7 +63,7 @@ public:
 
     }
 
-protected:
+private:
     PollResult poll(const AbstractLocker&) override
     {
         auto& queue = worklist.m_queue;
index 6a7f73c..36f72d5 100644 (file)
@@ -53,11 +53,9 @@ public:
     JS_EXPORT_PRIVATE static void webAssemblyModuleInstantinateAsync(JSGlobalObject*, JSPromise*, Vector<uint8_t>&&, JSObject*);
     static JSValue instantiate(JSGlobalObject*, JSPromise*, const Identifier&, JSValue);
 
-protected:
-    void finishCreation(VM&, JSGlobalObject*);
-
 private:
     JSWebAssembly(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*);
 };
 
 EncodedJSValue JSC_HOST_CALL webAssemblyCompileStreamingInternal(JSGlobalObject*, CallFrame*);
index 9f4ad88..72fd04e 100644 (file)
@@ -43,7 +43,7 @@ public:
 
     DECLARE_INFO;
 
-protected:
+private:
     JSWebAssemblyCompileError(VM&, Structure*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(JSWebAssemblyCompileError, ErrorInstance);
index b2cc2af..bf47d06 100644 (file)
@@ -101,12 +101,11 @@ public:
     static size_t offsetOfGlobalObject() { return OBJECT_OFFSETOF(JSWebAssemblyInstance, m_globalObject); }
     static size_t offsetOfVM() { return OBJECT_OFFSETOF(JSWebAssemblyInstance, m_vm); }
 
-protected:
+private:
     JSWebAssemblyInstance(VM&, Structure*, Ref<Wasm::Instance>&&);
     void finishCreation(VM&, JSWebAssemblyModule*, JSModuleNamespaceObject*);
     static void visitChildren(JSCell*, SlotVisitor&);
 
-private:
     Ref<Wasm::Instance> m_instance;
     VM* m_vm;
 
index 55b1d08..71737dc 100644 (file)
@@ -43,7 +43,7 @@ public:
 
     DECLARE_INFO;
 
-protected:
+private:
     JSWebAssemblyLinkError(VM&, Structure*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(JSWebAssemblyLinkError, ErrorInstance);
index 15ef9b7..d40bbd0 100644 (file)
@@ -39,7 +39,7 @@ public:
 
     DECLARE_INFO;
 
-protected:
+private:
     JSWebAssemblyRuntimeError(VM&, Structure*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(JSWebAssemblyRuntimeError, ErrorInstance);
index 32b028c..05db48c 100644 (file)
@@ -44,11 +44,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&, WebAssemblyCompileErrorPrototype*);
-
 private:
     WebAssemblyCompileErrorConstructor(VM&, Structure*);
+    void finishCreation(VM&, WebAssemblyCompileErrorPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(WebAssemblyCompileErrorConstructor, InternalFunction);
 
index a6c3d44..56dd482 100644 (file)
@@ -49,11 +49,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     WebAssemblyCompileErrorPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 7fcfee4..a0fe783 100644 (file)
@@ -44,11 +44,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&, WebAssemblyGlobalPrototype*);
-
 private:
     WebAssemblyGlobalConstructor(VM&, Structure*);
+    void finishCreation(VM&, WebAssemblyGlobalPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(WebAssemblyGlobalConstructor, InternalFunction);
 
index 2a98456..ac5be8a 100644 (file)
@@ -48,11 +48,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&, JSGlobalObject*);
-
 private:
     WebAssemblyGlobalPrototype(VM&, Structure*);
+    void finishCreation(VM&, JSGlobalObject*);
 };
 
 } // namespace JSC
index cd1ebe3..1da1c80 100644 (file)
@@ -48,11 +48,9 @@ public:
 
     static JSWebAssemblyInstance* createInstance(JSGlobalObject*, JSWebAssemblyModule*, JSObject* importObject, Structure*);
 
-protected:
-    void finishCreation(VM&, WebAssemblyInstancePrototype*);
-
 private:
     WebAssemblyInstanceConstructor(VM&, Structure*);
+    void finishCreation(VM&, WebAssemblyInstancePrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(WebAssemblyInstanceConstructor, InternalFunction);
 
index 2712b27..515b0cd 100644 (file)
@@ -49,11 +49,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     WebAssemblyInstancePrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 5937ba7..4265731 100644 (file)
@@ -44,11 +44,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&, WebAssemblyLinkErrorPrototype*);
-
 private:
     WebAssemblyLinkErrorConstructor(VM&, Structure*);
+    void finishCreation(VM&, WebAssemblyLinkErrorPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(WebAssemblyLinkErrorConstructor, InternalFunction);
 
index 18310c3..e9f922e 100644 (file)
@@ -49,11 +49,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     WebAssemblyLinkErrorPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 3ebe3d4..a9ccb1b 100644 (file)
@@ -44,11 +44,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&, WebAssemblyMemoryPrototype*);
-
 private:
     WebAssemblyMemoryConstructor(VM&, Structure*);
+    void finishCreation(VM&, WebAssemblyMemoryPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(WebAssemblyMemoryConstructor, InternalFunction);
 
index 8260276..fe4557f 100644 (file)
@@ -49,11 +49,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     WebAssemblyMemoryPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 51d545e..29c9c6b 100644 (file)
@@ -49,11 +49,9 @@ public:
 
     static JSWebAssemblyModule* createModule(JSGlobalObject*, CallFrame*, Vector<uint8_t>&& buffer);
 
-protected:
-    void finishCreation(VM&, WebAssemblyModulePrototype*);
-
 private:
     WebAssemblyModuleConstructor(VM&, Structure*);
+    void finishCreation(VM&, WebAssemblyModulePrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(WebAssemblyModuleConstructor, InternalFunction);
 
index 7196d1e..1dbca99 100644 (file)
@@ -49,11 +49,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     WebAssemblyModulePrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 7614f28..f312cff 100644 (file)
@@ -44,11 +44,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&, WebAssemblyRuntimeErrorPrototype*);
-
 private:
     WebAssemblyRuntimeErrorConstructor(VM&, Structure*);
+    void finishCreation(VM&, WebAssemblyRuntimeErrorPrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(WebAssemblyRuntimeErrorConstructor, InternalFunction);
 
index a1420bd..32fd63c 100644 (file)
@@ -49,11 +49,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     WebAssemblyRuntimeErrorPrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index cfff691..2370450 100644 (file)
@@ -44,11 +44,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&, WebAssemblyTablePrototype*);
-
 private:
     WebAssemblyTableConstructor(VM&, Structure*);
+    void finishCreation(VM&, WebAssemblyTablePrototype*);
 };
 STATIC_ASSERT_ISO_SUBSPACE_SHARABLE(WebAssemblyTableConstructor, InternalFunction);
 
index b71bd9c..921dd36 100644 (file)
@@ -49,11 +49,9 @@ public:
 
     DECLARE_INFO;
 
-protected:
-    void finishCreation(VM&);
-
 private:
     WebAssemblyTablePrototype(VM&, Structure*);
+    void finishCreation(VM&);
 };
 
 } // namespace JSC
index 5298eb1..ede93ad 100644 (file)
@@ -56,13 +56,10 @@ public:
     WasmToWasmImportableFunction importableFunction() const { return m_importableFunction; }
     JSObject* function() { return m_function.get(); }
 
-protected:
-    static void visitChildren(JSCell*, SlotVisitor&);
-
-    void finishCreation(VM&, NativeExecutable*, unsigned length, const String& name, JSObject*, JSWebAssemblyInstance*);
-
 private:
     WebAssemblyWrapperFunction(VM&, NativeExecutable*, JSGlobalObject*, Structure*, WasmToWasmImportableFunction);
+    void finishCreation(VM&, NativeExecutable*, unsigned length, const String& name, JSObject*, JSWebAssemblyInstance*);
+    static void visitChildren(JSCell*, SlotVisitor&);
 
     WriteBarrier<JSObject> m_function;
     // It's safe to just hold the raw WasmToWasmImportableFunction because we have a reference
index 3f6b74a..021b590 100644 (file)
@@ -1,3 +1,81 @@
+2020-04-20  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Classes marked final should not use protected access specifier
+        https://bugs.webkit.org/show_bug.cgi?id=210775
+
+        Reviewed by Daniel Bates.
+
+        * Modules/applepay/ApplePayPaymentMethodSelectedEvent.h:
+        * Modules/applepay/ApplePayValidateMerchantEvent.h:
+        * Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h:
+        * Modules/webaudio/BiquadDSPKernel.h:
+        * Modules/webaudio/WaveShaperDSPKernel.h:
+        * Modules/websockets/WebSocketChannel.h:
+        * Modules/websockets/WorkerThreadableWebSocketChannel.h:
+        * Modules/webxr/WebXRSession.h:
+        * Modules/webxr/WebXRSystem.h:
+        * accessibility/AccessibilityARIAGridCell.h:
+        * accessibility/AccessibleSetValueEvent.h:
+        * animation/CSSAnimation.h:
+        * bindings/js/ReadableStream.h:
+        * bridge/objc/objc_runtime.h:
+        * bridge/runtime_array.h:
+        * css/CSSImageSetValue.h:
+        * html/HTMLKeygenElement.cpp:
+        * html/canvas/WebGLBuffer.h:
+        * html/canvas/WebGLFramebuffer.h:
+        * html/canvas/WebGLProgram.h:
+        * html/canvas/WebGLQuery.h:
+        * html/canvas/WebGLRenderbuffer.h:
+        * html/canvas/WebGLSampler.h:
+        * html/canvas/WebGLSync.h:
+        * html/canvas/WebGLTransformFeedback.h:
+        * html/canvas/WebGLUniformLocation.h:
+        * html/shadow/TextControlInnerElements.h:
+        * inspector/InspectorStyleSheet.h:
+        * inspector/WebInjectedScriptManager.h:
+        * loader/cache/CachedCSSStyleSheet.h:
+        * page/Frame.h:
+        * page/FrameView.h:
+        * page/PageConsoleClient.h:
+        * page/animation/KeyframeAnimation.h:
+        * page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.h:
+        * platform/audio/AudioBus.h:
+        * platform/cocoa/PlaybackSessionModelMediaElement.h:
+        * platform/graphics/BitmapImage.h:
+        * platform/graphics/CrossfadeGeneratedImage.h:
+        * platform/graphics/NamedImageGeneratedImage.h:
+        * platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
+        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+        * platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h:
+        * platform/graphics/ca/win/PlatformCAAnimationWin.h:
+        * platform/graphics/cg/ImageDecoderCG.h:
+        * platform/graphics/iso/ISOOriginalFormatBox.h:
+        * platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
+        * platform/graphics/iso/ISOSchemeInformationBox.h:
+        * platform/graphics/iso/ISOSchemeTypeBox.h:
+        * platform/graphics/iso/ISOTrackEncryptionBox.h:
+        * platform/graphics/iso/ISOVTTCue.cpp:
+        * platform/graphics/iso/ISOVTTCue.h:
+        * platform/graphics/win/ImageDecoderDirect2D.h:
+        * platform/mediastream/mac/AVCaptureDeviceManager.h:
+        * platform/mock/mediasource/MockBox.h:
+        * platform/mock/mediasource/MockSourceBufferPrivate.cpp:
+        * rendering/RenderFullScreen.h:
+        * rendering/RenderGrid.h:
+        * rendering/RenderMultiColumnSet.h:
+        * rendering/RenderRuby.h:
+        * rendering/RenderScrollbarPart.h:
+        * rendering/RenderScrollbarTheme.h:
+        * rendering/RenderTableCell.h:
+        * rendering/RenderTableSection.h:
+        * rendering/RenderThemeIOS.h:
+        * rendering/RenderView.h:
+        * rendering/svg/RenderSVGResourceClipper.h:
+        * svg/SVGTextPathElement.h:
+        * workers/WorkerConsoleClient.h:
+        * worklets/Worklet.h:
+
 2020-04-20  Peng Liu  <peng.liu6@apple.com>
 
         Fix build failures when video fullscreen and picture-in-picture is disabled
index 817c21e..106c1fa 100644 (file)
@@ -46,13 +46,12 @@ public:
 
     const ApplePayPaymentMethod& paymentMethod() { return m_paymentMethod; }
 
-protected:
+private:
     ApplePayPaymentMethodSelectedEvent(const AtomString& type, const PaymentMethod&);
 
     // Event.
     EventInterface eventInterface() const override;
 
-private:
     const ApplePayPaymentMethod m_paymentMethod;
 };
 
index 0380c71..5c9986d 100644 (file)
@@ -44,13 +44,12 @@ public:
 
     const String& validationURL() const { return m_validationURL.string(); }
 
-protected:
+private:
     ApplePayValidateMerchantEvent(const AtomString& type, URL&& validationURL);
 
     // Event.
     EventInterface eventInterface() const override;
 
-private:
     const URL m_validationURL;
 };
 
index bc777f0..fe53459 100644 (file)
@@ -48,7 +48,7 @@ public:
     bool update(Uint8Array*, RefPtr<Uint8Array>&, unsigned short&, uint32_t&) override;
     RefPtr<ArrayBuffer> cachedKeyForKeyID(const String&) const override;
 
-protected:
+private:
     LegacyCDMSessionClient* m_client;
     RefPtr<Uint8Array> m_initData;
     HashMap<String, Vector<uint8_t>> m_cachedKeys;
index aef8d67..7ae161a 100644 (file)
@@ -55,7 +55,7 @@ public:
     double tailTime() const override;
     double latencyTime() const override;
 
-protected:
+private:
     Biquad m_biquad;
     BiquadProcessor* biquadProcessor() { return static_cast<BiquadProcessor*>(processor()); }
 
index 41e367e..19797de 100644 (file)
@@ -48,7 +48,7 @@ public:
     // Oversampling requires more resources, so let's only allocate them if needed.
     void lazyInitializeOversampling();
 
-protected:
+private:
     // Apply the shaping curve.
     void processCurve(const float* source, float* dest, size_t framesToProcess);
 
index b159303..99601a0 100644 (file)
@@ -126,13 +126,12 @@ public:
 
     Document* document();
     
-protected:
-    void refThreadableWebSocketChannel() override { ref(); }
-    void derefThreadableWebSocketChannel() override { deref(); }
-
 private:
     WEBCORE_EXPORT WebSocketChannel(Document&, WebSocketChannelClient&, SocketProvider&);
 
+    void refThreadableWebSocketChannel() override { ref(); }
+    void derefThreadableWebSocketChannel() override { deref(); }
+
     bool appendToBuffer(const char* data, size_t len);
     void skipBuffer(size_t len);
     bool processBuffer();
index 354877c..373e70e 100644 (file)
@@ -107,11 +107,10 @@ public:
     using RefCounted<WorkerThreadableWebSocketChannel>::ref;
     using RefCounted<WorkerThreadableWebSocketChannel>::deref;
 
-protected:
+private:
     void refThreadableWebSocketChannel() override { ref(); }
     void derefThreadableWebSocketChannel() override { deref(); }
 
-private:
     // Bridge for Peer.  Running on the worker thread.
     class Bridge : public RefCounted<Bridge> {
     public:
index 78c21ca..f011501 100644 (file)
@@ -73,7 +73,7 @@ public:
 
     bool ended() const { return m_ended; }
 
-protected:
+private:
     // EventTarget
     EventTargetInterface eventTargetInterface() const override { return WebXRSessionEventTargetInterfaceType; }
     ScriptExecutionContext* scriptExecutionContext() const override { return ActiveDOMObject::scriptExecutionContext(); }
index e9ab15d..d0bd54b 100644 (file)
@@ -55,7 +55,7 @@ public:
     void isSessionSupported(XRSessionMode, IsSessionSupportedPromise&&);
     void requestSession(XRSessionMode, const XRSessionInit&, RequestSessionPromise&&);
 
-protected:
+private:
     WebXRSystem(ScriptExecutionContext&);
 
     // EventTarget
index e7fae92..474ecd6 100644 (file)
@@ -37,15 +37,14 @@ public:
     static Ref<AccessibilityARIAGridCell> create(RenderObject*);
     virtual ~AccessibilityARIAGridCell();
 
-protected:
+private:
+    explicit AccessibilityARIAGridCell(RenderObject*);
+
     // Returns the start location and row span of the cell.
     std::pair<unsigned, unsigned> rowIndexRange() const override;
     // Returns the start location and column span of the cell.
     std::pair<unsigned, unsigned> columnIndexRange() const override;
 
-private:
-    explicit AccessibilityARIAGridCell(RenderObject*);
-
     AccessibilityTable* parentTable() const override;
     AccessibilityObject* parentRowGroup() const;
     unsigned axRowSpanWithRowIndex(unsigned index) const;
index f7d3b32..3e9bcf0 100644 (file)
@@ -41,13 +41,12 @@ public:
 
     const AtomString& value() const { return m_value; }
 
-protected:
+private:
     AccessibleSetValueEvent(const AtomString& type, const AtomString& value);
 
     // Event.
     EventInterface eventInterface() const override { return AccessibleSetValueEventInterfaceType; }
 
-private:
     const AtomString m_value;
 };
 
index cbe0b42..0358bef 100644 (file)
@@ -46,13 +46,12 @@ public:
     ExceptionOr<void> bindingsPlay() final;
     ExceptionOr<void> bindingsPause() final;
 
-protected:
-    void syncPropertiesWithBackingAnimation() final;
-    Ref<AnimationEventBase> createEvent(const AtomString& eventType, double elapsedTime, const String& pseudoId, Optional<Seconds> timelineTime) final;
-
 private:
     CSSAnimation(Element&, const Animation&);
 
+    void syncPropertiesWithBackingAnimation() final;
+    Ref<AnimationEventBase> createEvent(const AtomString& eventType, double elapsedTime, const String& pseudoId, Optional<Seconds> timelineTime) final;
+
     String m_animationName;
     bool m_stickyPaused { false };
 };
index 9fa4d99..a43389c 100644 (file)
@@ -52,7 +52,7 @@ public:
 
     JSReadableStream* readableStream() const { return guarded(); }
 
-protected:
+private:
     ReadableStream(JSDOMGlobalObject& globalObject, JSReadableStream& readableStream) : DOMGuarded<JSReadableStream>(globalObject, readableStream) { }
 };
 
index 6229636..069abe2 100644 (file)
@@ -124,11 +124,10 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     }
 
-protected:
-    void finishCreation(JSGlobalObject*);
-
 private:
     ObjcFallbackObjectImp(JSGlobalObject*, Structure*, ObjcInstance*, const String& propertyName);
+    void finishCreation(JSGlobalObject*);
+
     static void destroy(JSCell*);
     static bool getOwnPropertySlot(JSObject*, JSGlobalObject*, PropertyName, PropertySlot&);
     static bool put(JSCell*, JSGlobalObject*, PropertyName, JSValue, PutPropertySlot&);
index 29812a6..c9f6f0d 100644 (file)
@@ -84,11 +84,10 @@ public:
         return Structure::create(vm, globalObject, prototype, TypeInfo(DerivedArrayType, StructureFlags), info(), ArrayClass);
     }
 
-protected:
-    void finishCreation(VM&, Bindings::Array*);
-
 private:
     RuntimeArray(VM&, Structure*);
+    void finishCreation(VM&, Bindings::Array*);
+
     static EncodedJSValue lengthGetter(JSGlobalObject*, EncodedJSValue, PropertyName);
     static JSC::IsoSubspace* subspaceForImpl(JSC::VM&);
 
index 04e7892..01ea4c5 100644 (file)
@@ -63,12 +63,11 @@ public:
 
     Ref<CSSImageSetValue> imageSetWithStylesResolved(Style::BuilderState&);
 
-protected:
-    ImageWithScale bestImageForScaleFactor();
-
 private:
     CSSImageSetValue();
 
+    ImageWithScale bestImageForScaleFactor();
+
     void fillImageSet();
     static inline bool compareByScaleFactor(ImageWithScale first, ImageWithScale second) { return first.scaleFactor < second.scaleFactor; }
 
index ae1aaed..780b791 100644 (file)
@@ -53,7 +53,7 @@ public:
         return adoptRef(*new KeygenSelectElement(document));
     }
 
-protected:
+private:
     KeygenSelectElement(Document& document)
         : HTMLSelectElement(selectTag, document, 0)
     {
@@ -61,7 +61,6 @@ protected:
         setPseudo(pseudoId);
     }
 
-private:
     Ref<Element> cloneElementWithoutAttributesAndChildren(Document& targetDocument) override
     {
         return create(targetDocument);
index 767e4bc..1f62cb3 100644 (file)
@@ -66,12 +66,11 @@ public:
 
     bool hasEverBeenBound() const { return object() && m_target; }
 
-protected:
+private:
     WebGLBuffer(WebGLRenderingContextBase&);
 
     void deleteObjectImpl(GraphicsContextGLOpenGL*, PlatformGLObject) override;
 
-private:
     GCGLenum m_target { 0 };
 
     RefPtr<JSC::ArrayBuffer> m_elementArrayBuffer;
index 3423ce6..63d63cf 100644 (file)
@@ -105,12 +105,11 @@ public:
 
     GCGLenum getDrawBuffer(GCGLenum);
 
-protected:
+private:
     WebGLFramebuffer(WebGLRenderingContextBase&);
 
     void deleteObjectImpl(GraphicsContextGLOpenGL*, PlatformGLObject) override;
 
-private:
     WebGLAttachment* getAttachment(GCGLenum) const;
 
     // Return false if framebuffer is incomplete.
index 8c8ad28..8936b69 100644 (file)
@@ -70,12 +70,11 @@ public:
     bool attachShader(WebGLShader*);
     bool detachShader(WebGLShader*);
 
-protected:
+private:
     WebGLProgram(WebGLRenderingContextBase&);
 
     void deleteObjectImpl(GraphicsContextGLOpenGL*, PlatformGLObject) override;
 
-private:
     void cacheActiveAttribLocations(GraphicsContextGLOpenGL*);
     void cacheInfoIfNeeded();
 
index 76189e1..4bd6f1c 100644 (file)
@@ -40,11 +40,10 @@ public:
 
     void makeResultAvailable() { m_isResultAvailable = true; }
 
-protected:
+private:
     explicit WebGLQuery(WebGLRenderingContextBase&);
     void deleteObjectImpl(GraphicsContextGLOpenGL*, PlatformGLObject) override;
 
-private:
     bool m_isResultAvailable { false };
 };
 
index 31e9102..b559741 100644 (file)
@@ -62,12 +62,11 @@ public:
 
     void setHasEverBeenBound() { m_hasEverBeenBound = true; }
 
-protected:
+private:
     WebGLRenderbuffer(WebGLRenderingContextBase&);
 
     void deleteObjectImpl(GraphicsContextGLOpenGL*, PlatformGLObject) override;
 
-private:
     bool isRenderbuffer() const override { return true; }
 
     GCGLenum m_internalFormat;
index 1f0f77d..a3270a1 100644 (file)
@@ -36,7 +36,7 @@ public:
     static Ref<WebGLSampler> create(WebGLRenderingContextBase&);
     virtual ~WebGLSampler();
 
-protected:
+private:
     explicit WebGLSampler(WebGLRenderingContextBase&);
     void deleteObjectImpl(GraphicsContextGLOpenGL*, PlatformGLObject) final;
 };
index f917c7a..df6b365 100644 (file)
@@ -37,7 +37,7 @@ public:
 
     static Ref<WebGLSync> create(WebGLRenderingContextBase&);
 
-protected:
+private:
     WebGLSync(WebGLRenderingContextBase&);
 
     void deleteObjectImpl(GraphicsContextGLOpenGL*, PlatformGLObject) override;
index 819b3db..f702aec 100644 (file)
@@ -37,7 +37,7 @@ public:
 
     static Ref<WebGLTransformFeedback> create(WebGLRenderingContextBase&);
 
-protected:
+private:
     WebGLTransformFeedback(WebGLRenderingContextBase&);
 
     void deleteObjectImpl(GraphicsContextGLOpenGL*, PlatformGLObject) override;
index 9325f1a..db448b4 100644 (file)
@@ -45,10 +45,9 @@ public:
     
     GCGLenum type() const;
 
-protected:
+private:
     WebGLUniformLocation(WebGLProgram*, GCGLint location, GCGLenum type);
 
-private:
     RefPtr<WebGLProgram> m_program;
     GCGLint m_location;
     unsigned m_linkCount;
index 6e1cb5f..eccf943 100644 (file)
@@ -37,7 +37,7 @@ class TextControlInnerContainer final : public HTMLDivElement {
     WTF_MAKE_ISO_ALLOCATED(TextControlInnerContainer);
 public:
     static Ref<TextControlInnerContainer> create(Document&);
-protected:
+private:
     TextControlInnerContainer(Document&);
     RenderPtr<RenderElement> createElementRenderer(RenderStyle&&, const RenderTreePosition&) override;
     Optional<Style::ElementStyle> resolveCustomStyle(const RenderStyle& parentStyle, const RenderStyle* shadowHostStyle) override;
@@ -48,11 +48,10 @@ class TextControlInnerElement final : public HTMLDivElement {
 public:
     static Ref<TextControlInnerElement> create(Document&);
 
-protected:
+private:
     TextControlInnerElement(Document&);
     Optional<Style::ElementStyle> resolveCustomStyle(const RenderStyle& parentStyle, const RenderStyle* shadowHostStyle) override;
 
-private:
     bool isMouseFocusable() const override { return false; }
 };
 
index 7785217..73d3618 100644 (file)
@@ -236,7 +236,7 @@ public:
     ExceptionOr<String> text() const final;
     CSSStyleDeclaration* styleForId(const InspectorCSSId& id) const final { ASSERT_UNUSED(id, !id.ordinal()); return &inlineStyle(); }
 
-protected:
+private:
     InspectorStyleSheetForInlineStyle(InspectorPageAgent*, const String& id, Ref<StyledElement>&&, Inspector::Protocol::CSS::StyleSheetOrigin, Listener*);
 
     Document* ownerDocument() const final;
@@ -249,7 +249,6 @@ protected:
     ExceptionOr<void> setStyleText(CSSStyleDeclaration*, const String&) final;
     Vector<size_t> lineEndings() const final;
 
-private:
     CSSStyleDeclaration& inlineStyle() const;
     const String& elementStyleText() const;
     Ref<CSSRuleSourceData> ruleSourceData() const;
index cad9989..16119e5 100644 (file)
@@ -48,10 +48,9 @@ public:
 
     void discardInjectedScriptsFor(DOMWindow*);
 
-protected:
+private:
     void didCreateInjectedScript(const Inspector::InjectedScript&) override;
 
-private:
     RefPtr<CommandLineAPIHost> m_commandLineAPIHost;
 };
 
index 5e1ad86..ad30f81 100644 (file)
@@ -60,7 +60,6 @@ private:
 
     void setBodyDataFrom(const CachedResource&) final;
 
-protected:
     void checkNotify() final;
 
     RefPtr<TextResourceDecoder> m_decoder;
index 3d43a94..f2ae078 100644 (file)
@@ -371,7 +371,6 @@ private:
     bool m_hasHadUserInteraction { false };
     unsigned m_localStoragePrewarmingCount { 0 };
 
-protected:
     UniqueRef<EventHandler> m_eventHandler;
 };
 
index 1161f96..313517b 100644 (file)
@@ -669,7 +669,9 @@ public:
 
     String debugDescription() const final;
 
-protected:
+private:
+    explicit FrameView(Frame&);
+
     bool scrollContentsFastPath(const IntSize& scrollDelta, const IntRect& rectToScroll, const IntRect& clipRect) final;
     void scrollContentsSlowPath(const IntRect& updateRect) final;
     
@@ -678,9 +680,6 @@ protected:
     bool isVerticalDocument() const final;
     bool isFlippedDocument() const final;
 
-private:
-    explicit FrameView(Frame&);
-
     void reset();
     void init();
 
index 4929b42..521707a 100644 (file)
@@ -65,7 +65,7 @@ public:
     void addMessage(MessageSource, MessageLevel, const String& message, Ref<Inspector::ScriptCallStack>&&);
     void addMessage(MessageSource, MessageLevel, const String& message, unsigned long requestIdentifier = 0, Document* = nullptr);
 
-protected:
+private:
     void messageWithTypeAndLevel(MessageType, MessageLevel, JSC::JSGlobalObject*, Ref<Inspector::ScriptArguments>&&) override;
     void count(JSC::JSGlobalObject*, const String& label) override;
     void countReset(JSC::JSGlobalObject*, const String& label) override;
@@ -80,7 +80,6 @@ protected:
     void recordEnd(JSC::JSGlobalObject*, Ref<Inspector::ScriptArguments>&&) override;
     void screenshot(JSC::JSGlobalObject*, Ref<Inspector::ScriptArguments>&&) override;
 
-private:
     Page& m_page;
 };
 
index a1c3e66..492e391 100644 (file)
@@ -65,7 +65,10 @@ public:
 
     Optional<Seconds> timeToNextService() override;
 
-protected:
+private:
+    KeyframeAnimation(const Animation&, Element&, CompositeAnimation&, const RenderStyle& unanimatedStyle);
+    virtual ~KeyframeAnimation();
+
     void onAnimationStart(double elapsedTime) override;
     void onAnimationIteration(double elapsedTime) override;
     void onAnimationEnd(double elapsedTime) override;
@@ -94,10 +97,6 @@ protected:
 #endif
     void checkForMatchingColorFilterFunctionLists();
     bool checkForMatchingFilterFunctionLists(CSSPropertyID, const std::function<const FilterOperations& (const RenderStyle&)>&) const;
-
-private:
-    KeyframeAnimation(const Animation&, Element&, CompositeAnimation&, const RenderStyle& unanimatedStyle);
-    virtual ~KeyframeAnimation();
     
     // Get the styles for the given property surrounding the current animation time and the progress between them.
     void fetchIntervalEndpointsForProperty(CSSPropertyID, const RenderStyle*& fromStyle, const RenderStyle*& toStyle, double& progress) const;
index 58dff45..359e025 100644 (file)
@@ -45,7 +45,7 @@ public:
 
     ScrollingNodeID overflowScrollingNodeID() const { return m_overflowScrollingNodeID; }
 
-protected:
+private:
     ScrollingTreeOverflowScrollProxyNode(ScrollingTree&, ScrollingNodeID);
 
     void commitStateBeforeChildren(const ScrollingStateNode&) override;
index 2243747..1680347 100644 (file)
@@ -149,7 +149,7 @@ public:
 
     static RefPtr<AudioBus> loadPlatformResource(const char* name, float sampleRate);
 
-protected:
+private:
     AudioBus() { }
 
     AudioBus(unsigned numberOfChannels, size_t length, bool allocate);
index d41ec37..7d6b97f 100644 (file)
@@ -98,10 +98,9 @@ public:
     bool isPictureInPictureSupported() const final;
     bool isPictureInPictureActive() const final;
 
-protected:
+private:
     WEBCORE_EXPORT PlaybackSessionModelMediaElement();
 
-private:
     void progressEventTimerFired();
     static const Vector<WTF::AtomString>& observedEventNames();
     const WTF::AtomString& eventNameAll();
index 5c96bdc..1a9a4b5 100644 (file)
@@ -143,7 +143,7 @@ public:
     void imageFrameAvailableAtIndex(size_t);
     void decode(Function<void()>&&);
 
-protected:
+private:
     WEBCORE_EXPORT BitmapImage(NativeImagePtr&&, ImageObserver* = nullptr);
     WEBCORE_EXPORT BitmapImage(ImageObserver* = nullptr);
 
@@ -195,7 +195,6 @@ protected:
     RetainPtr<CFDataRef> tiffRepresentation(const Vector<NativeImagePtr>&);
 #endif
 
-private:
     void clearTimer();
     void startTimer(Seconds delay);
     SubsamplingLevel subsamplingLevelForScaleFactor(GraphicsContext&, const FloatSize& scaleFactor);
index 45765c8..b8be807 100644 (file)
@@ -46,13 +46,12 @@ public:
 
     FloatSize size(ImageOrientation = ImageOrientation::FromImage) const override { return m_crossfadeSize; }
 
-protected:
+private:
     ImageDrawResult draw(GraphicsContext&, const FloatRect& dstRect, const FloatRect& srcRect, const ImagePaintingOptions& = { }) override;
     void drawPattern(GraphicsContext&, const FloatRect& dstRect, const FloatRect& srcRect, const AffineTransform& patternTransform, const FloatPoint& phase, const FloatSize& spacing, const ImagePaintingOptions& = { }) override;
 
     CrossfadeGeneratedImage(Image& fromImage, Image& toImage, float percentage, const FloatSize& crossfadeSize, const FloatSize&);
 
-private:
     bool isCrossfadeGeneratedImage() const override { return true; }
     void dump(WTF::TextStream&) const override;
     
index 0285e1f..5978c73 100644 (file)
@@ -38,13 +38,12 @@ public:
         return adoptRef(*new NamedImageGeneratedImage(name, size));
     }
 
-protected:
+private:
     ImageDrawResult draw(GraphicsContext&, const FloatRect& dstRect, const FloatRect& srcRect, const ImagePaintingOptions& = { }) override;
     void drawPattern(GraphicsContext&, const FloatRect& dstRect, const FloatRect& srcRect, const AffineTransform& patternTransform, const FloatPoint& phase, const FloatSize& spacing, const ImagePaintingOptions& = { }) override;
 
     NamedImageGeneratedImage(String name, const FloatSize&);
 
-private:
     bool isNamedImageGeneratedImage() const override { return true; }
     void dump(WTF::TextStream&) const override;
 
index 5d8e250..4318c1b 100644 (file)
@@ -54,7 +54,7 @@ public:
 
     void playerDidReceiveError(NSError *);
 
-protected:
+private:
     WeakPtr<MediaPlayerPrivateAVFoundationObjC> m_parent;
     LegacyCDMSessionClient* m_client;
     String m_sessionId;
index 4909fdd..be8fc3a 100644 (file)
@@ -403,7 +403,7 @@ public:
     bool isAudio() const override { return m_isAudio; }
     bool isText() const override { return m_isText; }
     
-protected:
+private:
     MediaDescriptionAVFObjC(AVAssetTrack* track)
         : m_isVideo([track hasMediaCharacteristic:AVMediaCharacteristicVisual])
         , m_isAudio([track hasMediaCharacteristic:AVMediaCharacteristicAudible])
index 51ea833..29bde5e 100644 (file)
@@ -123,11 +123,10 @@ public:
     void setTimingFunctions(const Vector<const TimingFunction*>&, bool reverse = false) override;
     void copyTimingFunctionsFrom(const PlatformCAAnimation&) override;
 
-protected:
+private:
     PlatformCAAnimationCocoa(AnimationType, const String& keyPath);
     PlatformCAAnimationCocoa(PlatformAnimationRef);
 
-private:
     RetainPtr<CAPropertyAnimation> m_animation;
 };
 
index 162d626..08bb7a4 100644 (file)
@@ -113,11 +113,10 @@ public:
     void setTimingFunctions(const Vector<const TimingFunction*>&, bool reverse = false) override;
     void copyTimingFunctionsFrom(const PlatformCAAnimation&) override;
 
-protected:
+private:
     PlatformCAAnimationWin(AnimationType, const String& keyPath);
     PlatformCAAnimationWin(PlatformAnimationRef);
 
-private:
     RetainPtr<CACFAnimationRef> m_animation;
 };
 
index acd0efc..448753d 100644 (file)
@@ -67,7 +67,7 @@ public:
     bool isAllDataReceived() const final { return m_isAllDataReceived; }
     void clearFrameBufferCache(size_t) final { }
 
-protected:
+private:
     bool m_isAllDataReceived { false };
     RetainPtr<CGImageSourceRef> m_nativeDecoder;
 };
index 1883ba4..221cb67 100644 (file)
@@ -35,7 +35,7 @@ public:
 
     FourCC dataFormat() const { return m_dataFormat; }
 
-protected:
+private:
     bool parse(JSC::DataView&, unsigned& offset) override;
 
     FourCC m_dataFormat { uint32_t { 0 } };
index 8e5673e..a6a242b 100644 (file)
@@ -40,7 +40,7 @@ public:
     const ISOSchemeTypeBox* schemeTypeBox() const { return m_schemeTypeBox.get(); }
     const ISOSchemeInformationBox* schemeInformationBox() const { return m_schemeInformationBox.get(); }
 
-protected:
+private:
     bool parse(JSC::DataView&, unsigned& offset) override;
 
     ISOOriginalFormatBox m_originalFormatBox;
index e8ec0c4..8936f33 100644 (file)
@@ -35,7 +35,7 @@ public:
 
     const ISOBox* schemeSpecificData() const { return m_schemeSpecificData.get(); }
 
-protected:
+private:
     bool parse(JSC::DataView&, unsigned& offset) override;
 
     std::unique_ptr<ISOBox> m_schemeSpecificData;
index 4b8f263..1b6afce 100644 (file)
@@ -36,7 +36,7 @@ public:
     FourCC schemeType() const { return m_schemeType; }
     uint32_t schemeVersion() const { return m_schemeVersion; }
 
-protected:
+private:
     bool parse(JSC::DataView&, unsigned& offset) override;
 
     FourCC m_schemeType { uint32_t { 0 } };
index 47fa497..8239742 100644 (file)
@@ -40,7 +40,7 @@ public:
     Vector<uint8_t> defaultKID() const { return m_defaultKID; }
     Vector<uint8_t> defaultConstantIV() const { return m_defaultConstantIV; }
 
-protected:
+private:
     bool parse(JSC::DataView&, unsigned& offset) override;
 
     Optional<int8_t> m_defaultCryptByteBlock;
index 737dc24..aac2bac 100644 (file)
@@ -39,7 +39,7 @@ class ISOStringBox final : public ISOBox {
 public:
     const String& contents() { return m_contents; }
 
-protected:
+private:
     bool parse(JSC::DataView& view, unsigned& offset) override
     {
         unsigned localOffset = offset;
index 9d46456..7fa63c7 100644 (file)
@@ -118,7 +118,7 @@ public:
         }};
     }
 
-protected:
+private:
     bool parse(JSC::DataView&, unsigned& offset) override;
 
     MediaTime m_presentationTime;
index 4b6bd42..76d7aca 100644 (file)
@@ -80,7 +80,7 @@ public:
 
     static IWICImagingFactory2* systemImagingFactory();
 
-protected:
+private:
     bool m_isAllDataReceived { false };
     mutable IntSize m_size;
     COMPtr<IWICBitmapDecoder> m_nativeDecoder;
index 5ff4a3a..abde3a9 100644 (file)
@@ -53,7 +53,7 @@ public:
 
     void refreshCaptureDevices();
 
-protected:
+private:
     static bool isAvailable();
 
     AVCaptureDeviceManager();
index 2cc530f..be21015 100644 (file)
@@ -79,7 +79,7 @@ public:
     enum TrackKind { Audio, Video, Text };
     TrackKind kind() const { return m_kind; }
 
-protected:
+private:
     uint8_t m_trackID;
     String m_codec;
     TrackKind m_kind;
@@ -102,7 +102,7 @@ public:
     MediaTime duration() const { return m_duration; }
     const Vector<MockTrackBox>& tracks() const { return m_tracks; }
 
-protected:
+private:
     MediaTime m_duration;
     Vector<MockTrackBox> m_tracks;
 };
@@ -157,7 +157,7 @@ public:
     bool isDelayed() const { return m_flags & IsDelayed; }
     bool isNonDisplaying() const { return m_flags & IsNonDisplaying; }
 
-protected:
+private:
     MediaTime m_presentationTimestamp;
     MediaTime m_decodeTimestamp;
     MediaTime m_duration;
index 3286915..f4dad03 100644 (file)
@@ -113,7 +113,7 @@ public:
     bool isAudio() const override { return m_box.kind() == MockTrackBox::Audio; }
     bool isText() const override { return m_box.kind() == MockTrackBox::Text; }
 
-protected:
+private:
     MockMediaDescription(const MockTrackBox& box) : m_box(box) { }
     MockTrackBox m_box;
 };
index 1e51395..03455d8 100644 (file)
@@ -52,7 +52,6 @@ private:
     bool isRenderFullScreen() const override { return true; }
     bool isFlexibleBoxImpl() const override { return true; }
 
-protected:
     WeakPtr<RenderBlock> m_placeholder;
 };
 
index bd4437a..d7278b2 100644 (file)
@@ -81,14 +81,13 @@ public:
 
     StyleContentAlignmentData contentAlignment(GridTrackSizingDirection) const;
 
-protected:
+private:
     ItemPosition selfAlignmentNormalBehavior(const RenderBox* child = nullptr) const override
     {
         ASSERT(child);
         return child->isRenderReplaced() ? ItemPosition::Start : ItemPosition::Stretch;
     }
 
-private:
     const char* renderName() const override;
     bool isRenderGrid() const override { return true; }
     void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const override;
index ef9c05e..f73bf90 100644 (file)
@@ -129,10 +129,9 @@ public:
     LayoutRect columnRectAt(unsigned index) const;
     unsigned columnCount() const;
 
-protected:
+private:
     void addOverflowFromChildren() override;
     
-private:
     bool isRenderMultiColumnSet() const override { return true; }
     void layout() override;
 
index e0f1721..a3a1c02 100644 (file)
@@ -56,10 +56,9 @@ public:
     RenderRubyAsInline(Element&, RenderStyle&&);
     virtual ~RenderRubyAsInline();
 
-protected:
+private:
     void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
 
-private:
     bool isRubyInline() const final { return true; }
     const char* renderName() const override { return "RenderRuby (inline)"; }
     bool createsAnonymousWrapper() const override { return true; }
@@ -74,10 +73,9 @@ public:
 
     Element& element() const { return downcast<Element>(nodeForNonAnonymous()); }
 
-protected:
+private:
     void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
 
-private:
     bool isRubyBlock() const final { return true; }
     const char* renderName() const override { return "RenderRuby (block)"; }
     bool createsAnonymousWrapper() const override { return true; }
index 8f8b9e9..7dfc4b3 100644 (file)
@@ -55,11 +55,10 @@ public:
 
     RenderBox* rendererOwningScrollbar() const;
 
-protected:
+private:
     void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
     void imageChanged(WrappedImagePtr, const IntRect* = nullptr) override;
 
-private:
     bool isRenderScrollbarPart() const override { return true; }
     void computePreferredLogicalWidths() override;
 
index 61c76f8..9ccef46 100644 (file)
@@ -59,7 +59,7 @@ public:
     
     static RenderScrollbarTheme* renderScrollbarTheme();
 
-protected:
+private:
     bool hasButtons(Scrollbar&) override;
     bool hasThumb(Scrollbar&) override;
 
index 25ab635..fdff45d 100644 (file)
@@ -134,11 +134,10 @@ public:
     void invalidateHasEmptyCollapsedBorders();
     void setHasEmptyCollapsedBorder(CollapsedBorderSide, bool empty) const;
 
-protected:
+private:
     void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
     void computePreferredLogicalWidths() override;
 
-private:
     static RenderPtr<RenderTableCell> createTableCellWithStyle(Document&, const RenderStyle&);
 
     const char* renderName() const override { return (isAnonymous() || isPseudoElement()) ? "RenderTableCell (anonymous)" : "RenderTableCell"; }
index f8a9ffe..e3f9467 100644 (file)
@@ -149,10 +149,9 @@ public:
 
     void willInsertTableRow(RenderTableRow& child, RenderObject* beforeChild);
 
-protected:
+private:
     void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
 
-private:
     static RenderPtr<RenderTableSection> createTableSectionWithStyle(Document&, const RenderStyle&);
 
     enum ShouldIncludeAllIntersectingCells {
index 5a461bb..7e208c2 100644 (file)
@@ -67,7 +67,7 @@ public:
 
     WEBCORE_EXPORT static void setFocusRingColor(const Color&);
 
-protected:
+private:
     LengthBox popupInternalPaddingBox(const RenderStyle&) const override;
     
     FontCascadeDescription& cachedSystemFontDescription(CSSValueID systemFontID) const override;
index f083b52..bca1b1d 100644 (file)
@@ -201,13 +201,12 @@ public:
     const HashSet<const RenderBox*>& boxesWithScrollSnapPositions() { return m_boxesWithScrollSnapPositions; }
 #endif
 
-protected:
+private:
     void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags, bool* wasFixed) const override;
     const RenderObject* pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&) const override;
     void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) const override;
     bool requiresColumns(int desiredColumnCount) const override;
 
-private:
     void computeColumnCountAndWidth() override;
 
     bool shouldRepaint(const LayoutRect&) const;
@@ -219,7 +218,6 @@ private:
 
     Node* nodeForHitTest() const override;
 
-private:
     FrameView& m_frameView;
 
     // Include this RenderView.
index 02f7f6a..55d9e34 100644 (file)
@@ -54,10 +54,9 @@ public:
 
     SVGUnitTypes::SVGUnitType clipPathUnits() const { return clipPathElement().clipPathUnits(); }
 
-protected:
+private:
     bool selfNeedsClientInvalidation() const override { return (everHadLayout() || m_clipper.size()) && selfNeedsLayout(); }
 
-private:
     struct ClipperData {
         FloatRect objectBoundingBox;
         AffineTransform absoluteTransform;
index 78f07f0..6a2248c 100644 (file)
@@ -119,13 +119,12 @@ public:
     SVGAnimatedEnumeration& methodAnimated() { return m_method; }
     SVGAnimatedEnumeration& spacingAnimated() { return m_spacing; }
 
-protected:
-    void didFinishInsertingNode() override;
-
 private:
     SVGTextPathElement(const QualifiedName&, Document&);
     virtual ~SVGTextPathElement();
 
+    void didFinishInsertingNode() override;
+
     using PropertyRegistry = SVGPropertyOwnerRegistry<SVGTextPathElement, SVGTextContentElement, SVGURIReference>;
     const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; }
 
index db3e937..977b07d 100644 (file)
@@ -41,7 +41,7 @@ public:
     explicit WorkerConsoleClient(WorkerGlobalScope&);
     virtual ~WorkerConsoleClient();
 
-protected:
+private:
     void messageWithTypeAndLevel(MessageType, MessageLevel, JSC::JSGlobalObject*, Ref<Inspector::ScriptArguments>&&) override;
     void count(JSC::JSGlobalObject*, const String& label) override;
     void countReset(JSC::JSGlobalObject*, const String& label) override;
@@ -56,7 +56,6 @@ protected:
     void recordEnd(JSC::JSGlobalObject*, Ref<Inspector::ScriptArguments>&&) override;
     void screenshot(JSC::JSGlobalObject*, Ref<Inspector::ScriptArguments>&&) override;
 
-private:
     WorkerGlobalScope& m_workerGlobalScope;
 };
 
index c928ec3..b0c325c 100644 (file)
@@ -40,7 +40,7 @@ public:
     
     void addModule(Document&, const String& moduleURL);
 
-protected:
+private:
     Worklet();
 };
 
index a233fba..9ff92a4 100644 (file)
@@ -1,3 +1,15 @@
+2020-04-20  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Classes marked final should not use protected access specifier
+        https://bugs.webkit.org/show_bug.cgi?id=210775
+
+        Reviewed by Daniel Bates.
+
+        * Shared/API/APIDictionary.h:
+        * WebProcess/GPU/media/TextTrackPrivateRemote.h:
+        * WebProcess/Plugins/Netscape/JSNPMethod.h:
+        * WebProcess/Plugins/Netscape/JSNPObject.h:
+
 2020-04-20  Peng Liu  <peng.liu6@apple.com>
 
         Fix build failures when video fullscreen and picture-in-picture is disabled
index 9e5505e..e6832e2 100644 (file)
@@ -82,7 +82,7 @@ public:
 
     const MapType& map() const { return m_map; }
 
-protected:
+private:
     explicit Dictionary(MapType);
 
     MapType m_map;
index b95034b..b7cedb7 100644 (file)
@@ -98,7 +98,7 @@ public:
     bool isEasyToRead() const final { return m_isEasyToRead; }
     bool isDefault() const final { return m_isDefault; }
 
-protected:
+private:
     TextTrackPrivateRemote(MediaPlayerPrivateRemote&, TrackPrivateRemoteIdentifier, TextTrackPrivateRemoteConfiguration&&);
 
     MediaPlayerPrivateRemote& m_player;
index 1130604..9769027 100644 (file)
@@ -60,13 +60,11 @@ public:
 
     NPIdentifier npIdentifier() const { return m_npIdentifier; }
 
-protected:
-    void finishCreation(JSC::VM&, const String& name);
-
 private:
     static JSC::IsoSubspace* subspaceForImpl(JSC::VM&);
     
     JSNPMethod(JSC::JSGlobalObject*, JSC::Structure*, NPIdentifier);
+    void finishCreation(JSC::VM&, const String& name);
 
     static JSC::Structure* createStructure(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype)
     {
index 4803c0b..fa98432 100644 (file)
@@ -76,13 +76,11 @@ public:
 
     NPObject* npObject() const { return m_npObject; }
 
-protected:
-    void finishCreation(JSC::JSGlobalObject*);
-
 private:
     static JSC::IsoSubspace* subspaceForImpl(JSC::VM&);
     
     JSNPObject(JSC::JSGlobalObject*, JSC::Structure*, NPRuntimeObjectMap*, NPObject*);
+    void finishCreation(JSC::JSGlobalObject*);
     
     static JSC::Structure* createStructure(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype)
     {
index e81e7da..fa032ac 100644 (file)
@@ -1,3 +1,12 @@
+2020-04-20  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Classes marked final should not use protected access specifier
+        https://bugs.webkit.org/show_bug.cgi?id=210775
+
+        Reviewed by Daniel Bates.
+
+        * WebCoreSupport/WebResourceLoadScheduler.h:
+
 2020-04-20  Darin Adler  <darin@apple.com>
 
         Use #import instead of #include in Objective-C and don't use #pragma once
index 756a003..20fb487 100644 (file)
@@ -71,10 +71,9 @@ public:
     bool isOnLine() const final;
     void addOnlineStateChangeListener(WTF::Function<void(bool)>&&) final;
 
-protected:
+private:
     virtual ~WebResourceLoadScheduler();
 
-private:
     void scheduleLoad(WebCore::ResourceLoader*);
     void scheduleServePendingRequests();
     void requestTimerFired();
index 2af2ef8..8afb315 100644 (file)
@@ -1,3 +1,38 @@
+2020-04-20  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Classes marked final should not use protected access specifier
+        https://bugs.webkit.org/show_bug.cgi?id=210775
+
+        Reviewed by Daniel Bates.
+
+        * DefaultDownloadDelegate.h:
+        * DefaultPolicyDelegate.h:
+        * MemoryStream.h:
+        * WebApplicationCache.h:
+        * WebArchive.h:
+        * WebBackForwardList.h:
+        * WebCache.h:
+        * WebCoreStatistics.h:
+        * WebDataSource.h:
+        * WebElementPropertyBag.h:
+        * WebError.h:
+        * WebFrame.h:
+        * WebFramePolicyListener.h:
+        * WebHTMLRepresentation.h:
+        * WebHistoryItem.h:
+        * WebJavaScriptCollector.h:
+        * WebKitClassFactory.h:
+        * WebKitStatistics.h:
+        * WebMutableURLRequest.h:
+        * WebNotification.h:
+        * WebNotificationCenter.h:
+        * WebPreferences.h:
+        * WebResource.h:
+        * WebURLAuthenticationChallenge.h:
+        * WebURLCredential.h:
+        * WebURLProtectionSpace.h:
+        * WebURLResponse.h:
+
 2020-04-18  Rob Buis  <rbuis@igalia.com>
 
         Reduce parameter list of the FrameLoadRequest constructor
index 8855b7c..fb4cc7b 100644 (file)
@@ -37,10 +37,7 @@ class DefaultDownloadDelegate final : public IWebDownloadDelegate
 public:
     static DefaultDownloadDelegate* sharedInstance();
     static DefaultDownloadDelegate* createInstance();
-private:
-    DefaultDownloadDelegate();
-    ~DefaultDownloadDelegate();
-public:
+
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -63,7 +60,11 @@ public:
     // DefaultDownloadDelegate
     void registerDownload(IWebDownload*);
     void unregisterDownload(IWebDownload*);
-protected:
+
+private:
+    DefaultDownloadDelegate();
+    ~DefaultDownloadDelegate();
+
     ULONG m_refCount { 0 };
 
     HashSet<IWebDownload*> m_downloads;
index a2b6664..a96eaf7 100644 (file)
@@ -32,10 +32,7 @@ class DefaultPolicyDelegate final : public IWebPolicyDelegate {
 public:
     static DefaultPolicyDelegate* sharedInstance();
     static DefaultPolicyDelegate* createInstance();
-private:
-    DefaultPolicyDelegate();
-    ~DefaultPolicyDelegate();
-public:
+
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -53,7 +50,10 @@ public:
     
     virtual HRESULT STDMETHODCALLTYPE unableToImplementPolicyWithError(_In_opt_ IWebView*, _In_opt_ IWebError*, _In_opt_ IWebFrame*);
 
-protected:
+private:
+    DefaultPolicyDelegate();
+    ~DefaultPolicyDelegate();
+
     ULONG m_refCount { 0 };
 };
 
index 19f8248..2ba7da9 100644 (file)
@@ -37,11 +37,6 @@ class MemoryStream final : public IStream
 public:
     static COMPtr<MemoryStream> createInstance(RefPtr<WebCore::SharedBuffer>&&);
 
-protected:
-    MemoryStream(RefPtr<WebCore::SharedBuffer>&&);
-    ~MemoryStream();
-public:
-
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -79,7 +74,10 @@ public:
     virtual HRESULT STDMETHODCALLTYPE Stat(_Out_ STATSTG*, DWORD grfStatFlag);
     virtual HRESULT STDMETHODCALLTYPE Clone(_COM_Outptr_ IStream** ppstm);
 
-protected:
+private:
+    MemoryStream(RefPtr<WebCore::SharedBuffer>&&);
+    ~MemoryStream();
+
     RefPtr<WebCore::SharedBuffer> m_buffer;
     size_t m_pos { 0 };
     ULONG m_refCount { 0 };
index 8e56d05..cfd0ba1 100644 (file)
@@ -38,11 +38,6 @@ public:
 
     static WebCore::ApplicationCacheStorage& storage();
 
-protected:
-    WebApplicationCache();
-    ~WebApplicationCache();
-
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -62,7 +57,10 @@ public:
 
     virtual HRESULT STDMETHODCALLTYPE originsWithCache(/*[out, retval]*/ IPropertyBag**);
 
-protected:
+private:
+    WebApplicationCache();
+    ~WebApplicationCache();
+
     ULONG m_refCount;
 };
 
index 8672dea..0504e3a 100644 (file)
@@ -39,11 +39,7 @@ class WebArchive final : public IWebArchive
 public:
     static WebArchive* createInstance();
     static WebArchive* createInstance(RefPtr<WebCore::LegacyWebArchive>&&);
-protected:
-    WebArchive(RefPtr<WebCore::LegacyWebArchive>&&);
-    ~WebArchive();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -60,7 +56,10 @@ public:
     virtual HRESULT STDMETHODCALLTYPE  subframeArchives(_COM_Outptr_opt_ IEnumVARIANT**);
     virtual HRESULT STDMETHODCALLTYPE  data(_COM_Outptr_opt_ IStream**);
 
-protected:
+private:
+    WebArchive(RefPtr<WebCore::LegacyWebArchive>&&);
+    ~WebArchive();
+
     ULONG m_refCount { 0 };
 #if USE(CF)
     RefPtr<WebCore::LegacyWebArchive> m_archive;
index 7bc7c41..afae8e4 100644 (file)
@@ -37,11 +37,7 @@ class WebBackForwardList final : public IWebBackForwardList, IWebBackForwardList
 {
 public:
     static WebBackForwardList* createInstance(RefPtr<BackForwardList>&&);
-protected:
-    WebBackForwardList(RefPtr<BackForwardList>&&);
-    ~WebBackForwardList();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -67,7 +63,10 @@ public:
     // IWebBackForwardListPrivate
     virtual HRESULT STDMETHODCALLTYPE removeItem(_In_opt_ IWebHistoryItem*);
 
-protected:
+private:
+    WebBackForwardList(RefPtr<BackForwardList>&&);
+    ~WebBackForwardList();
+
     ULONG m_refCount { 0 };
     RefPtr<BackForwardList> m_backForwardList;
 };
index 393f83c..1959e74 100644 (file)
@@ -32,11 +32,7 @@ class WebCache final : public IWebCache
 {
 public:
     static WebCache* createInstance();
-protected:
-    WebCache();
-    ~WebCache();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -50,7 +46,10 @@ public:
     virtual HRESULT STDMETHODCALLTYPE cacheFolder(__deref_out_opt BSTR* location);
     virtual HRESULT STDMETHODCALLTYPE setCacheFolder(_In_ BSTR location);
 
-protected:
+private:
+    WebCache();
+    ~WebCache();
+
     ULONG m_refCount { 0 };
 };
 
index 0d6e888..b445445 100644 (file)
 class WebCoreStatistics final : public IWebCoreStatistics {
 public:
     static WebCoreStatistics* createInstance();
-protected:
-    WebCoreStatistics();
-    ~WebCoreStatistics();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -68,7 +64,10 @@ public:
     virtual HRESULT STDMETHODCALLTYPE cachedPageCount(_Out_ INT*);
     virtual HRESULT STDMETHODCALLTYPE cachedFrameCount(_Out_ INT*);
 
-protected:
+private:
+    WebCoreStatistics();
+    ~WebCoreStatistics();
+
     ULONG m_refCount { 0 };
 };
 
index 70a7f45..5529794 100644 (file)
@@ -39,11 +39,7 @@ class WebDataSource final : public IWebDataSource, public IWebDataSourcePrivate
 {
 public:
     static WebDataSource* createInstance(WebDocumentLoader*);
-protected:
-    WebDataSource(WebDocumentLoader*);
-    ~WebDataSource();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -76,7 +72,10 @@ public:
     // WebDataSource
     WebDocumentLoader* documentLoader() const;
 
-protected:
+private:
+    WebDataSource(WebDocumentLoader*);
+    ~WebDataSource();
+
     ULONG m_refCount { 0 };
     RefPtr<WebDocumentLoader> m_loader;
     COMPtr<IWebDocumentRepresentation> m_representation;
index 2dfaa91..dd6919d 100644 (file)
@@ -37,11 +37,6 @@ class WebElementPropertyBag final : public IPropertyBag
 public:
     static WebElementPropertyBag* createInstance(const WebCore::HitTestResult&);
 
-protected:
-    WebElementPropertyBag(const WebCore::HitTestResult&);
-    ~WebElementPropertyBag();
-
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -52,6 +47,9 @@ public:
     virtual HRESULT STDMETHODCALLTYPE Write(_In_ LPCOLESTR pszPropName, _In_ VARIANT* pVar);
 
 private:
+    WebElementPropertyBag(const WebCore::HitTestResult&);
+    ~WebElementPropertyBag();
+
     std::unique_ptr<WebCore::HitTestResult> m_result;
     ULONG m_refCount { 0 };
 };
index f7c67eb..e4dde97 100644 (file)
@@ -34,11 +34,7 @@ class WebError final : public IWebError, IWebErrorPrivate {
 public:
     static WebError* createInstance(const WebCore::ResourceError&, IPropertyBag* userInfo = 0);
     static WebError* createInstance();
-protected:
-    WebError(const WebCore::ResourceError&, IPropertyBag* userInfo);
-    ~WebError();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -63,6 +59,9 @@ public:
     const WebCore::ResourceError& resourceError() const;
 
 private:
+    WebError(const WebCore::ResourceError&, IPropertyBag* userInfo);
+    ~WebError();
+
     ULONG m_refCount { 0 };
     COMPtr<IPropertyBag> m_userInfo;
 #if USE(CFURLCONNECTION)
index 8520507..7672741 100644 (file)
@@ -79,11 +79,7 @@ class DECLSPEC_UUID("{A3676398-4485-4a9d-87DC-CB5A40E6351D}") WebFrame final : p
 {
 public:
     static WebFrame* createInstance();
-protected:
-    WebFrame();
-    ~WebFrame();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -199,7 +195,10 @@ public:
 
     COMPtr<IAccessible> accessible() const;
 
-protected:
+private:
+    WebFrame();
+    ~WebFrame();
+
     void loadHTMLString(_In_ BSTR string, _In_ BSTR baseURL, _In_ BSTR unreachableURL);
     void loadData(Ref<WebCore::SharedBuffer>&&, BSTR mimeType, BSTR textEncodingName, BSTR baseURL, BSTR failingURL);
     const Vector<WebCore::IntRect>& computePageRects(HDC printDC);
@@ -210,7 +209,6 @@ protected:
     void drawHeader(PlatformGraphicsContext* pctx, IWebUIDelegate*, const WebCore::IntRect& pageRect, float headerHeight);
     void drawFooter(PlatformGraphicsContext* pctx, IWebUIDelegate*, const WebCore::IntRect& pageRect, UINT page, UINT pageCount, float headerHeight, float footerHeight);
 
-protected:
     ULONG m_refCount { 0 };
     class WebFramePrivate;
     WebFramePrivate* d;
index 170de95..545a7c9 100644 (file)
@@ -38,11 +38,7 @@ namespace WebCore {
 class WebFramePolicyListener final : public IWebPolicyDecisionListener, public IWebFormSubmissionListener {
 public:
     static WebFramePolicyListener* createInstance(RefPtr<WebCore::Frame>&&);
-protected:
-    WebFramePolicyListener(RefPtr<WebCore::Frame>&&);
-    ~WebFramePolicyListener();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -61,6 +57,9 @@ public:
     void invalidate();
 
 private:
+    WebFramePolicyListener(RefPtr<WebCore::Frame>&&);
+    ~WebFramePolicyListener();
+
     ULONG m_refCount { 0 };
     RefPtr<WebCore::Frame> m_frame;
 };
index cb9e4d7..1fd0c7e 100644 (file)
@@ -34,10 +34,6 @@ class WebHTMLRepresentation final : public IWebHTMLRepresentation, IWebDocumentR
 {
 public:
     static WebHTMLRepresentation* createInstance(WebFrame* frame);
-protected:
-    WebHTMLRepresentation();
-    ~WebHTMLRepresentation();
-public:
 
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
@@ -72,7 +68,10 @@ public:
     virtual HRESULT STDMETHODCALLTYPE documentSource(__deref_opt_out BSTR*);
     virtual HRESULT STDMETHODCALLTYPE title(__deref_opt_out BSTR*);
 
-protected:
+private:
+    WebHTMLRepresentation();
+    ~WebHTMLRepresentation();
+
     ULONG m_refCount { 0 };
     WebFrame* m_frame { nullptr };
 };
index 920b34c..51f5a96 100644 (file)
@@ -43,11 +43,7 @@ class WebHistoryItem final : public IWebHistoryItem, IWebHistoryItemPrivate
 public:
     static WebHistoryItem* createInstance();
     static WebHistoryItem* createInstance(RefPtr<WebCore::HistoryItem>&&);
-protected:
-    WebHistoryItem(RefPtr<WebCore::HistoryItem>&&);
-    ~WebHistoryItem();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -92,7 +88,10 @@ public:
     // WebHistoryItem
     WebCore::HistoryItem* historyItem() const;
 
-protected:
+private:
+    WebHistoryItem(RefPtr<WebCore::HistoryItem>&&);
+    ~WebHistoryItem();
+
     ULONG m_refCount { 0 };
 
     RefPtr<WebCore::HistoryItem> m_historyItem;
index 300c856..dc67135 100644 (file)
@@ -32,11 +32,7 @@ class WebJavaScriptCollector final : public IWebJavaScriptCollector
 {
 public:
     static WebJavaScriptCollector* createInstance();
-protected:
-    WebJavaScriptCollector();
-    ~WebJavaScriptCollector();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -47,7 +43,10 @@ public:
     virtual HRESULT STDMETHODCALLTYPE collectOnAlternateThread(BOOL waitUntilDone);
     virtual HRESULT STDMETHODCALLTYPE objectCount(_Out_ UINT*);
 
-protected:
+private:
+    WebJavaScriptCollector();
+    ~WebJavaScriptCollector();
+
     ULONG m_refCount { 0 };
 };
 
index 77230f6..bb436e5 100644 (file)
@@ -43,7 +43,7 @@ public:
     virtual HRESULT STDMETHODCALLTYPE CreateInstance(_In_opt_ IUnknown* pUnkOuter, _In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual HRESULT STDMETHODCALLTYPE LockServer(BOOL);
 
-protected:
+private:
     ULONG m_refCount { 0 };
     CLSID m_targetClass;
 };
index 889bb1a..bd2747d 100644 (file)
 class WebKitStatistics final : public IWebKitStatistics {
 public:
     static WebKitStatistics* createInstance();
-protected:
-    WebKitStatistics();
-    ~WebKitStatistics();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -53,7 +49,10 @@ public:
     virtual HRESULT STDMETHODCALLTYPE comClassCount(_Out_ int*);
     virtual HRESULT STDMETHODCALLTYPE comClassNameCounts(__deref_out_opt BSTR*);
 
-protected:
+private:
+    WebKitStatistics();
+    ~WebKitStatistics();
+
     ULONG m_refCount { 0 };
 };
 
index 94cd2b4..57d0f69 100644 (file)
@@ -53,11 +53,7 @@ public:
 
     static WebMutableURLRequest* createImmutableInstance();
     static WebMutableURLRequest* createImmutableInstance(const WebCore::ResourceRequest&);
-protected:
-    WebMutableURLRequest(bool isMutable);
-    ~WebMutableURLRequest();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -105,7 +101,11 @@ public:
     const WebCore::HTTPHeaderMap& httpHeaderFields() const;
 
     const WebCore::ResourceRequest& resourceRequest() const;
-protected:
+
+private:
+    WebMutableURLRequest(bool isMutable);
+    ~WebMutableURLRequest();
+
     ULONG m_refCount { 0 };
     bool m_isMutable;
     WebCore::ResourceRequest m_request;
index 930db8a..0a207c2 100644 (file)
@@ -32,11 +32,7 @@ class WebNotification final : public IWebNotification
 {
 public:
     static WebNotification* createInstance(BSTR name = 0, IUnknown* anObject = 0, IPropertyBag* userInfo = 0);
-protected:
-    WebNotification(BSTR name, IUnknown* anObject, IPropertyBag* userInfo);
-    ~WebNotification();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -48,7 +44,10 @@ public:
     virtual HRESULT STDMETHODCALLTYPE getObject(_COM_Outptr_opt_ IUnknown** result);
     virtual HRESULT STDMETHODCALLTYPE userInfo(_COM_Outptr_opt_ IPropertyBag ** result);
 
-protected:
+private:
+    WebNotification(BSTR name, IUnknown* anObject, IPropertyBag* userInfo);
+    ~WebNotification();
+
     ULONG m_refCount { 0 };
     BSTR m_name { nullptr };
     IUnknown* m_anObject;
index f149812..066940f 100644 (file)
@@ -35,11 +35,6 @@ class WebNotificationCenter final : public IWebNotificationCenter {
 public:
     static WebNotificationCenter* createInstance();
 
-protected:
-    WebNotificationCenter();
-    ~WebNotificationCenter();
-
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -56,7 +51,10 @@ public:
     static IWebNotificationCenter* defaultCenterInternal();
     void postNotificationInternal(IWebNotification* notification, BSTR notificationName, IUnknown* anObject);
 
-protected:
+private:
+    WebNotificationCenter();
+    ~WebNotificationCenter();
+
     ULONG m_refCount { 0 };
     std::unique_ptr<WebNotificationCenterPrivate> d;
     static IWebNotificationCenter* m_defaultCenter;
index a31ba03..fa5794b 100644 (file)
 class WebPreferences final : public IWebPreferences, public IWebPreferencesPrivate8 {
 public:
     static WebPreferences* createInstance();
-protected:
-    WebPreferences();
-    ~WebPreferences();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -334,7 +330,10 @@ public:
 
     HRESULT postPreferencesChangesNotification();
 
-protected:
+private:
+    WebPreferences();
+    ~WebPreferences();
+
 #if USE(CF)
     void setValueForKey(CFStringRef key, CFPropertyListRef value);
     RetainPtr<CFPropertyListRef> valueForKey(CFStringRef key);
@@ -360,7 +359,6 @@ protected:
     void copyWebKitPreferencesToCFPreferences(CFDictionaryRef);
 #endif
 
-protected:
     ULONG m_refCount { 0 };
     WebCore::BString m_identifier;
     bool m_autoSaves { false };
index 055b5e8..b6eb86f 100644 (file)
 class WebResource final : public IWebResource {
 public:
     static WebResource* createInstance(RefPtr<WebCore::SharedBuffer>&&, const WebCore::ResourceResponse&);
-protected:
-    WebResource(IStream* data, const WTF::URL& url, const WTF::String& mimeType, const WTF::String& textEncodingName, const WTF::String& frameName);
-    ~WebResource();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -56,6 +52,9 @@ public:
     virtual HRESULT STDMETHODCALLTYPE frameName(__deref_opt_out BSTR* name);
 
 private:
+    WebResource(IStream* data, const WTF::URL&, const WTF::String& mimeType, const WTF::String& textEncodingName, const WTF::String& frameName);
+    ~WebResource();
+
     ULONG m_refCount { 0 };
     COMPtr<IStream> m_data;
     WTF::URL m_url;
index 9133bdb..4a79515 100644 (file)
@@ -34,10 +34,7 @@ class DECLSPEC_UUID("FD3B2381-0BB6-4B59-AF09-0E599C8901CF") WebURLAuthentication
 public:
     static WebURLAuthenticationChallenge* createInstance(const WebCore::AuthenticationChallenge&);
     static WebURLAuthenticationChallenge* createInstance(const WebCore::AuthenticationChallenge&, IWebURLAuthenticationChallengeSender*);
-private:
-    WebURLAuthenticationChallenge(const WebCore::AuthenticationChallenge&, IWebURLAuthenticationChallengeSender*);
-    ~WebURLAuthenticationChallenge();
-public:
+
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -57,7 +54,10 @@ public:
     // WebURLAuthenticationChallenge
     const WebCore::AuthenticationChallenge& authenticationChallenge() const;
 
-protected:
+private:
+    WebURLAuthenticationChallenge(const WebCore::AuthenticationChallenge&, IWebURLAuthenticationChallengeSender*);
+    ~WebURLAuthenticationChallenge();
+
     ULONG m_refCount { 0 };
 
     WebCore::AuthenticationChallenge m_authenticationChallenge;
index 33bd051..becfd36 100644 (file)
@@ -34,10 +34,7 @@ class WebURLCredential final : public IWebURLCredential
 public:
     static WebURLCredential* createInstance();
     static WebURLCredential* createInstance(const WebCore::Credential&);
-private:
-    WebURLCredential(const WebCore::Credential&);
-    ~WebURLCredential();
-public:
+
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -53,7 +50,10 @@ public:
     // WebURLCredential
     const WebCore::Credential& credential() const;
 
-protected:
+private:
+    WebURLCredential(const WebCore::Credential&);
+    ~WebURLCredential();
+
     ULONG m_refCount { 0 };
     WebCore::Credential m_credential;
 };
index e2ac83f..b325adc 100644 (file)
@@ -34,10 +34,7 @@ class WebURLProtectionSpace final : public IWebURLProtectionSpace
 public:
     static WebURLProtectionSpace* createInstance();
     static WebURLProtectionSpace* createInstance(const WebCore::ProtectionSpace&);
-private:
-    WebURLProtectionSpace(const WebCore::ProtectionSpace&);
-    ~WebURLProtectionSpace();
-public:
+
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -58,7 +55,10 @@ public:
     // WebURLProtectionSpace
     const WebCore::ProtectionSpace& protectionSpace() const;
 
-protected:
+private:
+    WebURLProtectionSpace(const WebCore::ProtectionSpace&);
+    ~WebURLProtectionSpace();
+
     ULONG m_refCount { 0 };
     WebCore::ProtectionSpace m_protectionSpace;
 };
index 93410cd..33d0a9b 100644 (file)
@@ -33,11 +33,7 @@ class WebURLResponse final : public IWebHTTPURLResponse, IWebURLResponsePrivate
 public:
     static WebURLResponse* createInstance();
     static WebURLResponse* createInstance(const WebCore::ResourceResponse& response);
-protected:
-    WebURLResponse();
-    ~WebURLResponse();
 
-public:
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -62,14 +58,16 @@ public:
     
     const WebCore::ResourceResponse& resourceResponse() const;
 
-protected:
+private:
+    WebURLResponse();
+    ~WebURLResponse();
+
     HRESULT suggestedFileExtension(BSTR* result);
 
 #if USE(CFURLCONNECTION)
     CFDictionaryRef certificateDictionary() const;
 #endif
 
-protected:
     ULONG m_refCount { 0 };
     WebCore::ResourceResponse m_response;
 
index 06a1fff..2d6ed5c 100644 (file)
@@ -1,3 +1,13 @@
+2020-04-20  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Classes marked final should not use protected access specifier
+        https://bugs.webkit.org/show_bug.cgi?id=210775
+
+        Reviewed by Daniel Bates.
+
+        * DumpRenderTree/win/DefaultPolicyDelegate.h:
+        * DumpRenderTree/win/UIDelegate.h:
+
 2020-04-20  Peng Liu  <peng.liu6@apple.com>
 
         Fix build failures when video fullscreen and picture-in-picture is disabled
index 9621091..054085a 100644 (file)
@@ -32,10 +32,7 @@ class DefaultPolicyDelegate final : public IWebPolicyDelegate {
 public:
     static DefaultPolicyDelegate* sharedInstance();
     static DefaultPolicyDelegate* createInstance();
-private:
-    DefaultPolicyDelegate();
-    ~DefaultPolicyDelegate();
-public:
+
     // IUnknown
     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
     virtual ULONG STDMETHODCALLTYPE AddRef();
@@ -53,7 +50,10 @@ public:
     
     virtual HRESULT STDMETHODCALLTYPE unableToImplementPolicyWithError(_In_opt_ IWebView*, _In_opt_ IWebError*, _In_opt_ IWebFrame*);
 
-protected:
+private:
+    DefaultPolicyDelegate();
+    ~DefaultPolicyDelegate();
+
     ULONG m_refCount { 0 };
 };
 
index f4f8d5d..cd6d347 100644 (file)
@@ -118,7 +118,7 @@ public:
     virtual HRESULT STDMETHODCALLTYPE decidePolicyForGeolocationRequest(_In_opt_ IWebView* sender, _In_opt_ IWebFrame*, _In_opt_ IWebSecurityOrigin*, _In_opt_ IWebGeolocationPolicyListener*);
     virtual HRESULT STDMETHODCALLTYPE didPressMissingPluginButton(_In_opt_ IDOMElement*);
 
-protected:
+private:
     // IWebUIDelegatePrivate
     virtual HRESULT STDMETHODCALLTYPE unused1() { return E_NOTIMPL; }
     virtual HRESULT STDMETHODCALLTYPE unused2() { return E_NOTIMPL; }
@@ -140,7 +140,6 @@ protected:
 
     ULONG m_refCount { 1 };
 
-private:
     RECT m_frame;
     std::unique_ptr<DRTUndoManager> m_undoManager;