Analysis task page on v3 show progression as regressions

https://bugs.webkit.org/show_bug.cgi?id=154045

Reviewed by Chris Dumez.

The bug was caused by TestGroup.compareTestResults referring to undefined _smallerIsBetter.
Retrieve it from the associated metric object via the owner analysis task.

* public/v3/models/test-group.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@196333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 6c9e40c013e8961b940d2a78ef4780c98c6cdedd..dc59a4095b12d09e436edae1bb9a1b666e675b74 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,15 @@
+2016-02-09  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Analysis task page on v3 show progression as regressions
+        https://bugs.webkit.org/show_bug.cgi?id=154045
+
+        Reviewed by Chris Dumez.
+
+        The bug was caused by TestGroup.compareTestResults referring to undefined _smallerIsBetter.
+        Retrieve it from the associated metric object via the owner analysis task.
+
+        * public/v3/models/test-group.js:
+
 2016-02-05  Ryosuke Niwa  <rniwa@webkit.org>
 
         Testing with remote server cache is unusably slow

diff --git a/Websites/perf.webkit.org/public/v3/models/test-group.js b/Websites/perf.webkit.org/public/v3/models/test-group.js
index 47b17504424aaec2afb222d29f42c81308780482..fe87ed264fa88dd19866b9a024bef0af806589aa 100644 (file)
--- a/Websites/perf.webkit.org/public/v3/models/test-group.js
+++ b/Websites/perf.webkit.org/public/v3/models/test-group.js
@@ -71,10 +71,14 @@ class TestGroup extends LabeledObject {
         var beforeMean = Statistics.sum(beforeValues) / beforeValues.length;
         var afterMean = Statistics.sum(afterValues) / afterValues.length;
 
+        var metric = AnalysisTask.findById(this._taskId).metric();
+        console.assert(metric);
+
         var result = {changeType: null, status: 'failed', label: 'Failed', fullLabel: 'Failed', isStatisticallySignificant: false};
         if (beforeValues.length && afterValues.length) {
             var diff = afterMean - beforeMean;
-            result.changeType = diff < 0 == this._smallerIsBetter ? 'better' : 'worse';
+            var smallerIsBetter = metric.isSmallerBetter();
+            result.changeType = diff < 0 == smallerIsBetter ? 'better' : 'worse';
             result.label = Math.abs(diff / beforeMean * 100).toFixed(2) + '% ' + result.changeType;
             result.isStatisticallySignificant = Statistics.testWelchsT(beforeValues, afterValues);
             result.status = result.isStatisticallySignificant ? result.changeType : 'unchanged';