2008-06-15 Darin Adler <darin@apple.com>
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 15 Jun 2008 22:10:32 +0000 (22:10 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 15 Jun 2008 22:10:32 +0000 (22:10 +0000)
commitfb32d42d6d916df9a461c2270170604246ce9ebd
treede195b8dcf0f0f0802ca8a9f95e4aef75815e414
parent3feb4c33e55f5315c241123e70128dba8aeea5af
2008-06-15  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19556
          REGRESSION (r34544): Crash while visiting bigglook.com

        This fix eliminates the crash, but the logic remaining seems a little strange.
        We create an IconRecord and then immediately destroy it. Worth taking another
        look at this later.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::setIconDataForIconURL): Added code to remove the icon
        just as in the other cases where we might be holding the single reference to it.
        (WebCore::IconDatabase::setIconURLForPageURL): Fixed comment typo.
        (WebCore::IconDatabase::writeToDatabase): Removed unused local variable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog
WebCore/loader/icon/IconDatabase.cpp