Make cleanup more robust and minor code cleaning in run benchmark script.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Aug 2015 23:44:10 +0000 (23:44 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Aug 2015 23:44:10 +0000 (23:44 +0000)
commitb2a1b7af7e6c0dc640bac4b2abb7d58274e9fea5
tree02a86690d4ecc6b1f64cc9ec11c8d02ac9cb2627
parentb7a98e4f41a54754d9a095871d2f4afbcb417a9c
Make cleanup more robust and minor code cleaning in run benchmark script.
https://bugs.webkit.org/show_bug.cgi?id=147800

Patch by Dewei Zhu <dewei_zhu@apple.com> on 2015-08-10
Reviewed by Ryosuke Niwa.

Use 'finnaly' block to make sure cleanup code is always executed.

* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(built_benchmark):
(built_benchmark.__init__):
(built_benchmark.__enter__):
(built_benchmark.__exit__):
(test_environment):
(test_environment.__init__):
(test_environment.__enter__):
(test_environment.__exit__):
(BenchmarkRunner.__init__):
(BenchmarkRunner.execute):
(BenchmarkRunner._dump):
(BenchmarkRunner._wrap):
(BenchmarkRunner): Deleted.
(BenchmarkRunner._cleanup): Deleted.
* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver.close_browsers):
(BrowserDriver):
(BrowserDriver.restore_env):
* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@188237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py
Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py