2010-06-11 Luiz Agostini <luiz.agostini@openbossa.org>, Kenneth Rohde Christiansen...
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Jun 2010 14:25:44 +0000 (14:25 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Jun 2010 14:25:44 +0000 (14:25 +0000)
commita4343b769ab08e8c82b02a3ad1d20762e012d194
treefd20c0060a76c9014e1db67e174d27effe776345
parentdd927772d4c4f4937fc1df73b80533a156be692e
2010-06-11  Luiz Agostini  <luiz.agostini@openbossa.org>, Kenneth Rohde Christiansen <kenneth@webkit.org>

        Reviewed by Antti Koivisto.

        CSS3 Media Queries are not serialized according to CSSOM
        https://bugs.webkit.org/show_bug.cgi?id=39220

        Added test for testing the serialization, plus updated current
        tests to take serialization into account.

        * fast/css/insertRule-media-expected.txt:
        * fast/css/insertRule-media.html:
        * fast/css/resources/insertRule-media.js:
        * fast/media/media-query-serialization-expected.txt: Added.
        * fast/media/media-query-serialization.html: Added.
2010-06-11  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Antti Koivisto.

        CSS3 Media Queries are not serialized according to CSSOM
        https://bugs.webkit.org/show_bug.cgi?id=39220

        MediaQuery serialization according to specification
        http://dev.w3.org/csswg/cssom/#serializing-media-queries.

        MediaQuery objects now ignore duplicated expressions. MediaQueryEvaluator::eval()
        now does not proccess MediaQuery objects that are known to be invalid.

        Test: fast/media/media-query-serialization.html

        * css/MediaQuery.cpp:
        (WebCore::stringCompare):
        (WebCore::MediaQuery::serialize):
        (WebCore::MediaQuery::MediaQuery):
        (WebCore::MediaQuery::~MediaQuery):
        (WebCore::MediaQuery::operator==):
        (WebCore::MediaQuery::cssText):
        (WebCore::MediaQuery::append):
        * css/MediaQuery.h:
        (WebCore::MediaQuery::ignored):
        (WebCore::MediaQuery::begin):
        (WebCore::MediaQuery::end):
        * css/MediaQueryExp.cpp:
        (WebCore::MediaQueryExp::serialize):
        * css/MediaQueryExp.h:
        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
12 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/css/insertRule-media-expected.txt
LayoutTests/fast/css/insertRule-media.html
LayoutTests/fast/css/resources/insertRule-media.js
LayoutTests/fast/media/media-query-serialization-expected.txt [new file with mode: 0644]
LayoutTests/fast/media/media-query-serialization.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/css/MediaQuery.cpp
WebCore/css/MediaQuery.h
WebCore/css/MediaQueryEvaluator.cpp
WebCore/css/MediaQueryExp.cpp
WebCore/css/MediaQueryExp.h