Remove support for legacy Notifications
authorweinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 May 2017 20:56:00 +0000 (20:56 +0000)
committerweinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 May 2017 20:56:00 +0000 (20:56 +0000)
commit9efea6adbc2b1932bb9df551e5b3255f930e7c17
treed2101a80d8082d8eb13806d2c01249627c87d26f
parent3768f3146c6673612fa767f83119a16b3ce162e0
Remove support for legacy Notifications
https://bugs.webkit.org/show_bug.cgi?id=171487

Reviewed by Jon Lee.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

Source/WebCore:

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
Remove files.

* Configurations/FeatureDefines.xcconfig:
Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

* DerivedSources.make:
Remove IDL files.

* Modules/notifications/DOMWindowNotifications.cpp: Removed.
* Modules/notifications/DOMWindowNotifications.h: Removed.
* Modules/notifications/DOMWindowNotifications.idl: Removed.
* Modules/notifications/NotificationCenter.cpp: Removed.
* Modules/notifications/NotificationCenter.h: Removed.
* Modules/notifications/NotificationCenter.idl: Removed.
* Modules/notifications/NotificationClient.h:
* Modules/notifications/NotificationController.cpp:
* Modules/notifications/NotificationController.h:
* Modules/notifications/WorkerGlobalScopeNotifications.cpp: Removed.
* Modules/notifications/WorkerGlobalScopeNotifications.h: Removed.
* Modules/notifications/WorkerGlobalScopeNotifications.idl: Removed.
* Modules/notifications/Notification.idl:
* Modules/notifications/Notification.cpp:
* Modules/notifications/Notification.h:
* dom/EventTargetFactory.in:
* page/DOMWindow.cpp:
* workers/WorkerThread.h:
Remove code legacy Notification code. Replace use of NotificationCenter with direct
calls to the NotificationClient.

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:
Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
* WebCoreSupport/WebNotificationClient.h:
* WebCoreSupport/WebNotificationClient.mm:
* WebView/WebNotification.mm:
* WebView/WebNotificationInternal.h:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _notificationIDForTesting:]):
Remove legacy notification specific code.

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::WebChromeClient):
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
Remove legacy notification specific code.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
* Shared/WebProcessCreationParameters.cpp:
* Shared/WebProcessCreationParameters.h:
* UIProcess/WebProcessPool.cpp:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
* WebProcess/Notifications/NotificationPermissionRequestManager.h:
* WebProcess/Notifications/WebNotificationManager.cpp:
* WebProcess/Notifications/WebNotificationManager.h:
* WebProcess/WebCoreSupport/WebNotificationClient.cpp:
* WebProcess/WebCoreSupport/WebNotificationClient.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebProcess.cpp:
Remove legacy notification specific code.

Source/WTF:

* wtf/FeatureDefines.h:
Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

Tools:

* DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
(DRTDesktopNotificationPresenter::checkNotificationPermission):
* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.

LayoutTests:

- Remove fast/notifications/. It was skipped on all platforms and use legacy Notifications API.
- Remove http/notifications/legacy. It tested the legacy API.
- Update two tests in fast/history to use the non-legacy API to test page cache + notifications.
- Update TestExpectations for removals.

* TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
* fast/history/page-cache-notification-non-suspendable.html:
* fast/history/page-cache-notification-suspendable.html:
* fast/notifications: Removed.
* fast/notifications/notification-after-close-expected.txt: Removed.
* fast/notifications/notification-after-close.html: Removed.
* fast/notifications/notification-permisssion-deletable-expected.txt: Removed.
* fast/notifications/notification-permisssion-deletable.html: Removed.
* fast/notifications/notifications-cancel-request-permission-expected.txt: Removed.
* fast/notifications/notifications-cancel-request-permission.html: Removed.
* fast/notifications/notifications-check-permission-expected.txt: Removed.
* fast/notifications/notifications-check-permission.html: Removed.
* fast/notifications/notifications-click-event-expected.txt: Removed.
* fast/notifications/notifications-click-event-focus-expected.txt: Removed.
* fast/notifications/notifications-click-event-focus.html: Removed.
* fast/notifications/notifications-click-event.html: Removed.
* fast/notifications/notifications-constructor-request-permission-expected.txt: Removed.
* fast/notifications/notifications-constructor-request-permission.html: Removed.
* fast/notifications/notifications-constructor-with-permission-expected.txt: Removed.
* fast/notifications/notifications-constructor-with-permission.html: Removed.
* fast/notifications/notifications-constructor-without-permission-expected.txt: Removed.
* fast/notifications/notifications-constructor-without-permission.html: Removed.
* fast/notifications/notifications-display-close-events-expected.txt: Removed.
* fast/notifications/notifications-display-close-events.html: Removed.
* fast/notifications/notifications-document-close-crash-expected.txt: Removed.
* fast/notifications/notifications-document-close-crash.html: Removed.
* fast/notifications/notifications-event-stop-propagation-expected.txt: Removed.
* fast/notifications/notifications-event-stop-propagation.html: Removed.
* fast/notifications/notifications-multi-events-expected.txt: Removed.
* fast/notifications/notifications-multi-events.html: Removed.
* fast/notifications/notifications-no-icon-expected.txt: Removed.
* fast/notifications/notifications-no-icon.html: Removed.
* fast/notifications/notifications-permission-expected.txt: Removed.
* fast/notifications/notifications-permission.html: Removed.
* fast/notifications/notifications-replace-expected.txt: Removed.
* fast/notifications/notifications-replace.html: Removed.
* fast/notifications/notifications-request-permission-expected.txt: Removed.
* fast/notifications/notifications-request-permission-optional-expected.txt: Removed.
* fast/notifications/notifications-request-permission-optional.html: Removed.
* fast/notifications/notifications-request-permission.html: Removed.
* fast/notifications/notifications-rtl-expected.txt: Removed.
* fast/notifications/notifications-rtl.html: Removed.
* fast/notifications/notifications-sandbox-permission-expected.txt: Removed.
* fast/notifications/notifications-sandbox-permission.html: Removed.
* fast/notifications/notifications-window-close-crash-expected.txt: Removed.
* fast/notifications/notifications-window-close-crash.html: Removed.
* fast/notifications/notifications-with-permission-expected.txt: Removed.
* fast/notifications/notifications-with-permission.html: Removed.
* fast/notifications/notifications-without-permission-expected.txt: Removed.
* fast/notifications/notifications-without-permission.html: Removed.
* fast/notifications/request-notification-permission-while-reloading-expected.txt: Removed.
* fast/notifications/request-notification-permission-while-reloading.html: Removed.
* fast/notifications/resources: Removed.
* fast/notifications/resources/notifications-cancel-request-permission.html: Removed.
* fast/notifications/resources/notifications-iframe.html: Removed.
* http/tests/notifications/legacy: Removed.
* http/tests/notifications/legacy/double-show-expected.txt: Removed.
* http/tests/notifications/legacy/double-show.html: Removed.
* http/tests/notifications/legacy/events-expected.txt: Removed.
* http/tests/notifications/legacy/events.html: Removed.
* http/tests/notifications/legacy/notification-request-permission-then-navigate-expected.txt: Removed.
* http/tests/notifications/legacy/notification-request-permission-then-navigate.html: Removed.
* http/tests/notifications/legacy/request-expected.txt: Removed.
* http/tests/notifications/legacy/request-no-callback-expected.txt: Removed.
* http/tests/notifications/legacy/request-no-callback.html: Removed.
* http/tests/notifications/legacy/request.html: Removed.
* http/tests/notifications/legacy/resources: Removed.
* http/tests/notifications/legacy/resources/notify-opener-done.html: Removed.
* http/tests/notifications/legacy/resources/request-permission-then-navigate.html: Removed.
* http/tests/notifications/legacy/show-expected.txt: Removed.
* http/tests/notifications/legacy/show.html: Removed.
* http/tests/notifications/legacy/window-show-on-click-expected.txt: Removed.
* http/tests/notifications/legacy/window-show-on-click.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@216206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
138 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/history/page-cache-notification-non-suspendable.html
LayoutTests/fast/history/page-cache-notification-suspendable.html
LayoutTests/fast/notifications/notification-after-close-expected.txt [deleted file]
LayoutTests/fast/notifications/notification-after-close.html [deleted file]
LayoutTests/fast/notifications/notification-permisssion-deletable-expected.txt [deleted file]
LayoutTests/fast/notifications/notification-permisssion-deletable.html [deleted file]
LayoutTests/fast/notifications/notifications-cancel-request-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-cancel-request-permission.html [deleted file]
LayoutTests/fast/notifications/notifications-check-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-check-permission.html [deleted file]
LayoutTests/fast/notifications/notifications-click-event-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-click-event-focus-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-click-event-focus.html [deleted file]
LayoutTests/fast/notifications/notifications-click-event.html [deleted file]
LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-constructor-request-permission.html [deleted file]
LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-constructor-with-permission.html [deleted file]
LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-constructor-without-permission.html [deleted file]
LayoutTests/fast/notifications/notifications-display-close-events-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-display-close-events.html [deleted file]
LayoutTests/fast/notifications/notifications-document-close-crash-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-document-close-crash.html [deleted file]
LayoutTests/fast/notifications/notifications-event-stop-propagation-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-event-stop-propagation.html [deleted file]
LayoutTests/fast/notifications/notifications-multi-events-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-multi-events.html [deleted file]
LayoutTests/fast/notifications/notifications-no-icon-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-no-icon.html [deleted file]
LayoutTests/fast/notifications/notifications-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-permission.html [deleted file]
LayoutTests/fast/notifications/notifications-replace-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-replace.html [deleted file]
LayoutTests/fast/notifications/notifications-request-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-request-permission-optional-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-request-permission-optional.html [deleted file]
LayoutTests/fast/notifications/notifications-request-permission.html [deleted file]
LayoutTests/fast/notifications/notifications-rtl-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-rtl.html [deleted file]
LayoutTests/fast/notifications/notifications-sandbox-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-sandbox-permission.html [deleted file]
LayoutTests/fast/notifications/notifications-window-close-crash-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-window-close-crash.html [deleted file]
LayoutTests/fast/notifications/notifications-with-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-with-permission.html [deleted file]
LayoutTests/fast/notifications/notifications-without-permission-expected.txt [deleted file]
LayoutTests/fast/notifications/notifications-without-permission.html [deleted file]
LayoutTests/fast/notifications/request-notification-permission-while-reloading-expected.txt [deleted file]
LayoutTests/fast/notifications/request-notification-permission-while-reloading.html [deleted file]
LayoutTests/fast/notifications/resources/notifications-cancel-request-permission.html [deleted file]
LayoutTests/fast/notifications/resources/notifications-iframe.html [deleted file]
LayoutTests/http/tests/notifications/legacy/double-show-expected.txt [deleted file]
LayoutTests/http/tests/notifications/legacy/double-show.html [deleted file]
LayoutTests/http/tests/notifications/legacy/events-expected.txt [deleted file]
LayoutTests/http/tests/notifications/legacy/events.html [deleted file]
LayoutTests/http/tests/notifications/legacy/notification-request-permission-then-navigate-expected.txt [deleted file]
LayoutTests/http/tests/notifications/legacy/notification-request-permission-then-navigate.html [deleted file]
LayoutTests/http/tests/notifications/legacy/request-expected.txt [deleted file]
LayoutTests/http/tests/notifications/legacy/request-no-callback-expected.txt [deleted file]
LayoutTests/http/tests/notifications/legacy/request-no-callback.html [deleted file]
LayoutTests/http/tests/notifications/legacy/request.html [deleted file]
LayoutTests/http/tests/notifications/legacy/resources/notify-opener-done.html [deleted file]
LayoutTests/http/tests/notifications/legacy/resources/request-permission-then-navigate.html [deleted file]
LayoutTests/http/tests/notifications/legacy/show-expected.txt [deleted file]
LayoutTests/http/tests/notifications/legacy/show.html [deleted file]
LayoutTests/http/tests/notifications/legacy/window-show-on-click-expected.txt [deleted file]
LayoutTests/http/tests/notifications/legacy/window-show-on-click.html [deleted file]
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/ios/TestExpectations
LayoutTests/platform/mac/TestExpectations
LayoutTests/platform/win/TestExpectations
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WTF/ChangeLog
Source/WTF/wtf/FeatureDefines.h
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/DerivedSources.cpp
Source/WebCore/DerivedSources.make
Source/WebCore/Modules/notifications/DOMWindowNotifications.cpp [deleted file]
Source/WebCore/Modules/notifications/DOMWindowNotifications.h [deleted file]
Source/WebCore/Modules/notifications/DOMWindowNotifications.idl [deleted file]
Source/WebCore/Modules/notifications/Notification.cpp
Source/WebCore/Modules/notifications/Notification.h
Source/WebCore/Modules/notifications/Notification.idl
Source/WebCore/Modules/notifications/NotificationCenter.cpp [deleted file]
Source/WebCore/Modules/notifications/NotificationCenter.h [deleted file]
Source/WebCore/Modules/notifications/NotificationCenter.idl [deleted file]
Source/WebCore/Modules/notifications/NotificationClient.h
Source/WebCore/Modules/notifications/NotificationController.cpp
Source/WebCore/Modules/notifications/NotificationController.h
Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.cpp [deleted file]
Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.h [deleted file]
Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.idl [deleted file]
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/dom/EventTargetFactory.in
Source/WebCore/page/DOMWindow.cpp
Source/WebCore/workers/WorkerThread.h
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
Source/WebKit/mac/WebCoreSupport/WebNotificationClient.h
Source/WebKit/mac/WebCoreSupport/WebNotificationClient.mm
Source/WebKit/mac/WebView/WebNotification.mm
Source/WebKit/mac/WebView/WebNotificationInternal.h
Source/WebKit/mac/WebView/WebView.mm
Source/WebKit/win/ChangeLog
Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp
Source/WebKit/win/WebCoreSupport/WebChromeClient.h
Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.cpp
Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h
Source/WebKit2/ChangeLog
Source/WebKit2/Configurations/FeatureDefines.xcconfig
Source/WebKit2/Shared/WebProcessCreationParameters.cpp
Source/WebKit2/Shared/WebProcessCreationParameters.h
Source/WebKit2/UIProcess/WebProcessPool.cpp
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp
Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.h
Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp
Source/WebKit2/WebProcess/Notifications/WebNotificationManager.h
Source/WebKit2/WebProcess/WebCoreSupport/WebNotificationClient.cpp
Source/WebKit2/WebProcess/WebCoreSupport/WebNotificationClient.h
Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Source/WebKit2/WebProcess/WebProcess.cpp
Source/cmake/OptionsMac.cmake
Source/cmake/OptionsWin.cmake
Source/cmake/WebKitFeatures.cmake
Source/cmake/tools/vsprops/FeatureDefines.props
Source/cmake/tools/vsprops/FeatureDefinesCairo.props
Tools/ChangeLog
Tools/DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp
Tools/Scripts/webkitperl/FeatureList.pm
Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig