REGRESSION: A problem with Voiceover and finding links
authorcfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Jan 2011 20:27:48 +0000 (20:27 +0000)
committercfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Jan 2011 20:27:48 +0000 (20:27 +0000)
commit99abb088d52355bf949358887e09376fbd90e104
tree1428172ac37b7d5173d5e4cfa4c4dfcc60a47c3f
parentb6d7b24d19f9753206477eb8a69a664b98742e7e
REGRESSION: A problem with Voiceover and finding links
https://bugs.webkit.org/show_bug.cgi?id=52324

Reviewed by Darin Adler.

Source/WebCore:

Fallout from recent change to make WebCore return its own scroll view.
   1) There were two scroll views in the hierarchy, one which no needed to be ignored.
   2) Hit tests for sub frames needed to be offset.
   3) The check for whether an attachment is ignored must happen earlier than using
      the helpText to determine if an element should be ignored.

Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper scrollViewParent]):

Source/WebKit/mac:

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView accessibilityIsIgnored]):

LayoutTests:

* platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
* platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/accessibility/iframe-with-title-correct-hierarchy.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/accessibility/AccessibilityObject.cpp
Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm