2009-09-25 Adam Barth <abarth@webkit.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Sep 2009 16:36:57 +0000 (16:36 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Sep 2009 16:36:57 +0000 (16:36 +0000)
commit7d959a09d339519b2ecbf7f52610f7184a7b23da
tree097f2bb991c96c7f72b2557757a470aa02b22ced
parent46199db9ba24202c8f17ed8db92753c8fa38f765
2009-09-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Teach ScheduledAction::execute about isolated worlds
        https://bugs.webkit.org/show_bug.cgi?id=27703

        Test a strange error condition after clearing a setInterval
        timer.  The key point is not to crash on this test.

        * fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Added.
        * fast/dom/timer-clear-interval-in-handler-and-generate-error.html: Added.
2009-09-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Teach ScheduledAction::execute about isolated worlds
        https://bugs.webkit.org/show_bug.cgi?id=27703

        When setTimeout is called with a string argument in an isolated
        world, we now compile the string in the isolated world.

        Last time we tried this change, we got a lot of crashes.  This
        time we're using a fresh local handle as our context to avoid
        trouble if the peristent handle gets disposed before we leave
        the context.

        Test: fast/dom/timer-clear-interval-in-handler-and-generate-error.html

        * bindings/v8/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt [new file with mode: 0644]
LayoutTests/fast/dom/timer-clear-interval-in-handler-and-generate-error.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/bindings/v8/ScheduledAction.cpp