2010-09-08 MORITA Hajime <morrita@google.com>
authormorrita@google.com <morrita@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Sep 2010 02:05:26 +0000 (02:05 +0000)
committermorrita@google.com <morrita@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Sep 2010 02:05:26 +0000 (02:05 +0000)
commit7b51c895153695bedeba7b4c2bd312533428279b
treef060835bd696f709385c454fa1fd6fa81679443d
parent11b68db93e6c81224637008e13e44680c48d5e09
2010-09-08  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        spelling underline gets lost on backspace
        https://bugs.webkit.org/show_bug.cgi?id=41423

        * editing/spelling/script-tests/TEMPLATE.html: Copied from LayoutTests/editing/selection/script-tests/TEMPLATE.html.
        * editing/spelling/script-tests/spelling-backspace-between-lines.js: Added.
        * editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
        * editing/spelling/spelling-backspace-between-lines.html: Added.
2010-09-08  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        spelling underline gets lost on backspace
        https://bugs.webkit.org/show_bug.cgi?id=41423

        moveParagraphs() did make a DOM range by serializing source range
        and deserializing it back, and markers are gone during the process.
        This change marks that DOM range again.

        Test: editing/spelling/spelling-backspace-between-lines.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs):
        * editing/Editor.cpp:
        (WebCore::Editor::clearMisspellingsAndBadGrammar): Added.
        (WebCore::Editor::markMisspellingsAndBadGrammar): Added.
        * editing/Editor.h:
2010-09-08  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        spelling underline gets lost on backspace
        https://bugs.webkit.org/show_bug.cgi?id=41423

        Switched to use a anchorNode of the selection instead of a focused
        node for finer control of node selection in spellingNode():
        With the focused node, we cannot select other nodes but the first
        child of that node. In some case, we need to inspect these.

        The API is only for LayoutTests, and the change is compatible for
        existing test cases.

        * WebView/WebFrame.mm:
        (spellingNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/editing/spelling/script-tests/TEMPLATE.html [new file with mode: 0644]
LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js [new file with mode: 0644]
LayoutTests/editing/spelling/spelling-backspace-between-lines-expected.txt [new file with mode: 0644]
LayoutTests/editing/spelling/spelling-backspace-between-lines.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/editing/CompositeEditCommand.cpp
WebCore/editing/Editor.cpp
WebCore/editing/Editor.h
WebKit/mac/ChangeLog
WebKit/mac/WebView/WebFrame.mm