JavaScriptCore:
authormjs@apple.com <mjs@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 30 May 2008 05:45:16 +0000 (05:45 +0000)
committermjs@apple.com <mjs@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 30 May 2008 05:45:16 +0000 (05:45 +0000)
commit7374be5ddd27bb07200dedf17362914fedcd8b61
treeca24c93ef6dd08efd567ec541f4b2c383e5d5f20
parentfef55edfcb6e9e29315c9b86e260e564f566cc02
JavaScriptCore:

2008-05-29  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver.

        - fixed <rdar://problem/5972943> REGRESSION(r33979): Flash clips do not play on cnn.com

        Finally blocks could clobber registers that had to remain live
        until they returned. This patch takes a conservative approach and
        makes sure that finally blocks do not reuse any registers that
        were previously allocated for the function. In the future this
        could probably be tightened up to be less profligate with the
        register allocation.

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::highestUsedRegister):
        * VM/CodeGenerator.h:
        * kjs/nodes.cpp:
        (KJS::TryNode::emitCode):

LayoutTests:

2008-05-29  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver. Test by Geoff Garen.

        - fixed <rdar://problem/5972943> REGRESSION(r33979): Flash clips do not play on cnn.com

        * fast/js/finally-codegen-failure-expected.txt: Added.
        * fast/js/finally-codegen-failure.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JavaScriptCore/ChangeLog
JavaScriptCore/VM/CodeGenerator.cpp
JavaScriptCore/VM/CodeGenerator.h
JavaScriptCore/kjs/nodes.cpp
LayoutTests/ChangeLog
LayoutTests/fast/js/finally-codegen-failure-expected.txt [new file with mode: 0644]
LayoutTests/fast/js/finally-codegen-failure.html [new file with mode: 0644]