2010-10-04 Dirk Pranke <dpranke@chromium.org>
authordpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Oct 2010 04:19:16 +0000 (04:19 +0000)
committerdpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Oct 2010 04:19:16 +0000 (04:19 +0000)
commit5acfea350abf4bc21005e2f2841ab2e0f4fbcd04
treed2e6464bd0dba79d48a5e18c559b3241dab26e74
parent162742f259ffcd120086c82d1eb5db3cc4055fbd
2010-10-04  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        aroben's change in r68792 actually broke new-run-webkit-tests when
        running the DRT code path. His change was intended to fix the
        way we were converting windows paths to URIs when running under
        Cygwin (the paths were getting one too many "/" on the front).
        However, the change ended up breaking the chromium_win port, which
        had slightly different logic.

        This patch removes the port-specific code and adds tests to make
        sure we're getting the behavior we expect. The Port object no longer
        exposes a get_absolute_path() method that can be used outside of
        of converting test filenames, because it's unreliable otherwise
        (we don't have the right context to know which conversion is intended).

        https://bugs.webkit.org/show_bug.cgi?id=47140

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKitTools/ChangeLog
WebKitTools/Scripts/webkitpy/layout_tests/port/base.py
WebKitTools/Scripts/webkitpy/layout_tests/port/base_unittest.py
WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win.py
WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py