2010-06-03 Abhishek Arya <inferno@chromium.org>
authortkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jun 2010 06:16:55 +0000 (06:16 +0000)
committertkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jun 2010 06:16:55 +0000 (06:16 +0000)
commit56756e23160464776cbeffda83b773a7fd11821b
treee72c0d2c0d1970951773fecf11b3e39c859d5a1e
parent126f3e7c7f64c36d8bfe9da1a6126dda643c4119
2010-06-03  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Carlson.

        Tests that invalid media src url does not result in crash.

        * media/invalid-media-url-crash-expected.txt: Added.
        * media/invalid-media-url-crash.html: Added.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:

2010-06-03  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Carlson.

        Fix a crash when trying to use an invalid media src url by
        moving the isValid url checks to a central location in
        isSafeToLoadURL function. Also added an empty string check
        in DocumentLoader::didTellClientAboutLoad.

        Test: media/invalid-media-url-crash.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::isSafeToLoadURL):
        (WebCore::HTMLMediaElement::selectNextSourceChild):
        (WebCore::HTMLMediaElement::getPluginProxyParams):
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::didTellClientAboutLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/media/invalid-media-url-crash-expected.txt [new file with mode: 0644]
LayoutTests/media/invalid-media-url-crash.html [new file with mode: 0644]
LayoutTests/platform/gtk/Skipped
LayoutTests/platform/qt/Skipped
WebCore/ChangeLog
WebCore/html/HTMLMediaElement.cpp
WebCore/loader/DocumentLoader.h