2011-01-06 Eric Seidel <eric@webkit.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Jan 2011 21:30:15 +0000 (21:30 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Jan 2011 21:30:15 +0000 (21:30 +0000)
commit43d636fed1899a45dd8ce62feb6e5d6066e299b3
tree8197a42ee723f27294afd98e2afadce188c1a37c
parent9d728f26e8fc1d7faa8d0c5788acae92fcdac21d
2011-01-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Mihai Parparita.

        commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
        https://bugs.webkit.org/show_bug.cgi?id=52002

        See an example of this here:
        https://bugs.webkit.org/show_bug.cgi?id=51314#c2

        It's due to the fact that we pass around TestFailure() instance
        objects and yet expect them to all compare to be the same.

        This is bad.  We should either have shared instances of these values
        or we should just pass around the class names.  There are already hacks
        in place to make TestFailure objects pass equality tests, I just added
        a __hash__ implementation so they can be used in sets as expected.

        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py
Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py
Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py