WebCore:
authormjs@apple.com <mjs@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Mar 2008 05:36:30 +0000 (05:36 +0000)
committermjs@apple.com <mjs@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Mar 2008 05:36:30 +0000 (05:36 +0000)
commit283503e2bf45d85a812fae06817b031490fe8843
treedc9c2eaf8c80d07094ec72565830650296d7f63c
parentd9c2f0e2a36eda598e8b4acdef18866b08931df2
WebCore:

2008-03-23  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Eric.

        - fixed "SVGTextElement.getNumberOfChars is broken for altGlyph (affects Acid3 test 79)"
        http://bugs.webkit.org/show_bug.cgi?id=17062

        * svg/SVGAltGlyphElement.cpp: Added. Implementation for new element.
        (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
        (WebCore::SVGAltGlyphElement::~SVGAltGlyphElement):
        (WebCore::SVGAltGlyphElement::setGlyphRef):
        (WebCore::SVGAltGlyphElement::glyphRef):
        (WebCore::SVGAltGlyphElement::setFormat):
        (WebCore::SVGAltGlyphElement::format):
        (WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
        (WebCore::SVGAltGlyphElement::createRenderer): For now, this just renders as a tspan,
        which is right for everything besides the alternate glyph substitution itself.
        * svg/SVGAltGlyphElement.h: Added. Header for new element.
        (WebCore::SVGAltGlyphElement::contextElement):
        * svg/SVGAltGlyphElement.idl: Added. Interface for new element.
        * svg/SVGTSpanElement.cpp:
        (WebCore::SVGTSpanElement::childShouldCreateRenderer): Allow altGlyph to render here.
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::childShouldCreateRenderer): ditto
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::childShouldCreateRenderer): ditto
        * svg/svgtags.in: Add altGlyph
        * DerivedSources.make: Add new files
        * GNUmakefile.am: ditto
        * WebCore.SVG.exp: Add new ObjC DOM class
        * WebCore.pro: Add new files
        * WebCore.vcproj/WebCore.vcproj: ditto
        * WebCore.xcodeproj/project.pbxproj: ditto
        * bindings/js/JSSVGElementWrapperFactory.cpp: Handle altGlyph
        * bindings/objc/DOM.mm:
        (WebCore::createElementClassMap): ditto
        * bindings/objc/DOMInternal.h: Include altGlyph header
        * bindings/objc/DOMSVG.h: Include altGlyph header

LayoutTests:

2008-03-23  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Eric.

        - updated test results for "SVGTextElement.getNumberOfChars is broken for altGlyph (affects Acid3 test 79)"
        http://bugs.webkit.org/show_bug.cgi?id=17062

        * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/text/text-altglyph-01-b-expected.txt:
        * svg/dom/altGlyph-dom-expected.txt: Added.
        * svg/dom/altGlyph-dom.xhtml: Added.
        * svg/dom/resources/altGlyph-dom.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
24 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt
LayoutTests/platform/mac/svg/text/text-altglyph-01-b-expected.txt
LayoutTests/svg/dom/altGlyph-dom-expected.txt [new file with mode: 0644]
LayoutTests/svg/dom/altGlyph-dom.xhtml [new file with mode: 0644]
LayoutTests/svg/dom/resources/altGlyph-dom.js [new file with mode: 0644]
WebCore/ChangeLog
WebCore/DerivedSources.make
WebCore/GNUmakefile.am
WebCore/WebCore.SVG.exp
WebCore/WebCore.pro
WebCore/WebCore.vcproj/WebCore.vcproj
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/bindings/js/JSSVGElementWrapperFactory.cpp
WebCore/bindings/objc/DOM.mm
WebCore/bindings/objc/DOMInternal.h
WebCore/bindings/objc/DOMSVG.h
WebCore/svg/SVGAltGlyphElement.cpp [new file with mode: 0644]
WebCore/svg/SVGAltGlyphElement.h [new file with mode: 0644]
WebCore/svg/SVGAltGlyphElement.idl [new file with mode: 0644]
WebCore/svg/SVGTSpanElement.cpp
WebCore/svg/SVGTextElement.cpp
WebCore/svg/SVGTextPathElement.cpp
WebCore/svg/svgtags.in