2011-02-04 Jer Noble <jer.noble@apple.com>
authorjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Feb 2011 23:48:25 +0000 (23:48 +0000)
committerjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Feb 2011 23:48:25 +0000 (23:48 +0000)
commit25fd6126b282399557887e44ee277486a5a087f8
tree2e3434f60cb1b116678b9dbac452285fd55c1fd3
parent383e15410943bba51b7fd92af63f3c33b0ab5f22
2011-02-04  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Frame accurate seeking isn't always accurate
        https://bugs.webkit.org/show_bug.cgi?id=52697

        New pixel test that seeks to specific currentTimes and records the rendered frame.

        * media/content/test-25fps.mp4: Added.
        * media/content/test-25fps.ogv: Added.
        * media/video-frame-accurate-seek-expected.txt: Added.
        * media/video-frame-accurate-seek.html: Added.
        * platform/mac/media/video-frame-accurate-seek-expected.checksum: Added.
        * platform/mac/media/video-frame-accurate-seek-expected.png: Added.
2011-02-04  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Frame accurate seeking isn't always accurate
        https://bugs.webkit.org/show_bug.cgi?id=52697

        Test: media/video-frame-accurate-seek.html

        Make seeking slightly more accurate by rounding instead of truncating
        when converting from seconds-in-float to time/timeScale.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::createQTTime):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue):
        * platform/graphics/win/QTMovie.cpp:
        (QTMovie::setCurrentTime):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/media/content/test-25fps.mp4 [new file with mode: 0644]
LayoutTests/media/content/test-25fps.ogv [new file with mode: 0644]
LayoutTests/media/video-frame-accurate-seek-expected.txt [new file with mode: 0644]
LayoutTests/media/video-frame-accurate-seek.html [new file with mode: 0644]
LayoutTests/platform/mac/media/video-frame-accurate-seek-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/media/video-frame-accurate-seek-expected.png [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm
Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp
Source/WebCore/platform/graphics/win/QTMovie.cpp