[Settings] Remove all custom code from Settings.h/cpp
[WebKit.git] / Source / WebCore / ChangeLog
index 2c951ed..bb67f97 100644 (file)
@@ -1,3 +1,57 @@
+2017-10-16  Sam Weinig  <sam@webkit.org>
+
+        [Settings] Remove all custom code from Settings.h/cpp
+        https://bugs.webkit.org/show_bug.cgi?id=178330
+
+        Reviewed by Simon Fraser.
+
+        Removes the two remaining functions out of Settings paving the way
+        for the file to be generated.
+        
+        - pageDestroyed was moved down into SettingsBase.
+        - effectiveFrameFlattening was moved to FrameView (to reduce the need
+          for additional includes, the FrameFlattening enum was converted to
+          an enum class to allow it to be forward declared).
+          
+        Also moves default values into SettingsDefaultValues.h
+
+        * WebCore.xcodeproj/project.pbxproj:
+        
+            Add new files.
+        
+        * page/FrameView.cpp:
+        * page/FrameView.h:
+
+            Move effectiveFrameFlattening function here from Settings.
+
+        * page/Settings.cpp:
+        * page/Settings.h:
+
+            Move effectiveFrameFlattening, pageDestroyed and default values out.
+
+        * page/Settings.in:
+        
+            Update for turning FrameFlattening into an enum class.
+        
+        * page/SettingsBase.h:
+
+            Turn FrameFlattening into an enum class and move pageDestroyed here.
+
+        * page/SettingsDefaultValues.h: Added.
+
+            Move all the default values from Settings here.
+
+        * rendering/RenderFrameSet.cpp:
+        * rendering/RenderIFrame.cpp:
+        * rendering/RenderView.cpp:
+
+            Get effectiveFrameFlattening from the FrameView.
+
+        * testing/InternalSettings.cpp:
+        * testing/InternalSettings.h:
+        
+            Update now that FrameFlattening is an enum class.
+
 2017-10-16  Maureen Daum  <mdaum@apple.com>
 
         If we fail to delete any database file, don't remove its information from the tracker database