2016-03-30 Dewei Zhu Extend animometer timeout for slow CPUs. https://bugs.webkit.org/show_bug.cgi?id=156047 Reviewed by Ryosuke Niwa. Extend animometer timeout to 30 minutes for slow device. * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: 2016-03-30 Daniel Bates run-webkit-tests must create parent directory of user's cache directory before running tests https://bugs.webkit.org/show_bug.cgi?id=156009 Reviewed by Alexey Proskuryakov. The script run-webkit-tests must create the parent directory of the user's cache directory before running tests because a WebKit2 child process expects that this directory exists when it starts. The script run-webkit-tests influences the path chosen by a WebKit2 child process for the user's temporary directory and user's cache directory via the environment variable DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it as part of setting up the test environment. But run-webkit-tests does not create the user's cache directory. Therefore there is race between the time AppKit creates it and when the launched WebContent and Network processes query for the path to the user's cache directory such that the OS may return the empty string to the WebContent and Network processes if queried for this directory before AppKit creates it. * Scripts/webkitpy/port/base.py: (Port._path_to_user_cache_directory): Added. Base class implementation that returns the empty string. We will override this method for the OS X port to return the path to the user's cache directory with the specified suffix. (Port.remove_cache_directory): Deleted. * Scripts/webkitpy/port/driver.py: (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory to the suffix to use for the user's temporary and cache directories and the path to the user's cache directory, respectively. (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX to self._driver_user_directory_suffix. (Driver._start): Compute the user directory suffix and the path to the user's cache directory. Create the user's cache directory (if applicable). (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable). * Scripts/webkitpy/port/mac.py: (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory(). (MacPort.remove_cache_directory): Deleted. 2016-03-29 Benjamin Poulain [WTF] Removing a smart pointer from HashTable issues two stores to the same location https://bugs.webkit.org/show_bug.cgi?id=155676 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/HashMap.cpp: * TestWebKitAPI/Tests/WTF/HashSet.cpp: 2016-03-29 Srinivasan Vijayaraghavan Add machine-readable results for JSC stress tests https://bugs.webkit.org/show_bug.cgi?id=155771 Reviewed by Darin Adler and Dean Johnson Add an option to output JSC stress test results to a user-specified file in JSON format. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Add JSON output support (readAllLines): Remove trailing newline from the end of each item 2016-03-29 Alex Christensen Fix Windows build. * TestWebKitAPI/PlatformWin.cmake: 2016-03-29 Timothy Hatcher Update WebKit nightly to have a red needle to better match Safari https://bugs.webkit.org/show_bug.cgi?id=155983 Reviewed by Joseph Pecoraro. * WebKitLauncher/webkit.icns: 2016-03-28 Joanmarie Diggs Adding myself as a reviewer. Unreviewed. * Scripts/webkitpy/common/config/contributors.json: 2016-03-25 Dewei Zhu Dromaeo patch used by run-benchmark should not include an invalid address. https://bugs.webkit.org/show_bug.cgi?id=155910 Reviewed by Ryosuke Niwa. Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test. * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: 2016-03-25 Daniel Bates Add WebKitSystemInterface for iOS 9.3 https://bugs.webkit.org/show_bug.cgi?id=155893 Rubber-stamped by Alexey Proskuryakov. * Scripts/copy-webkitlibraries-to-product-directory: 2016-03-25 Daniel Bates Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK() in copy-webkitlibraries-to-product-directory https://bugs.webkit.org/show_bug.cgi?id=155869 Reviewed by Alexey Proskuryakov. It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command line argument. * Scripts/copy-webkitlibraries-to-product-directory: 2016-03-25 Konstantin Tokarev Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port. https://bugs.webkit.org/show_bug.cgi?id=155882 Reviewed by Michael Catanzaro. It was already enabled in all trunk ports, and is required for WebInspectorUI to work. * Scripts/webkitperl/FeatureList.pm: 2016-03-24 Jeremy Zerfas Improve update-webkit-dependency script. https://bugs.webkit.org/show_bug.cgi?id=155576 Reviewed by Brent Fulgham. * Scripts/update-webkit-dependency: -Updated script to also use ETags for helping to determine whether dependency is up to date. -Updated script so it usually won't need to download the entire dependency each time it is ran. -Updated script to ensure zip file contains expected directories before trying to install. -Added some more error checking and improved error messages. (lastModifiedToUnixTime): Deleted. * Scripts/update-webkit-wincairo-libs: -Corrected comment about what script does. 2016-03-24 Bill Ming Fix webkitpy tests after r198617 https://bugs.webkit.org/show_bug.cgi?id=155827 Reviewed by Alex Christensen. * Scripts/webkitpy/tool/steps/confirmdiff.py: (ConfirmDiff._show_pretty_diff): 2016-03-23 Bill Ming webkit-patch failed to open pretty diff on Windows https://bugs.webkit.org/show_bug.cgi?id=155827 Reviewed by Alex Christensen. * Scripts/webkitpy/tool/steps/confirmdiff.py: (ConfirmDiff._show_pretty_diff): 2016-03-23 Jer Noble [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing https://bugs.webkit.org/show_bug.cgi?id=155764 Reviewed by Eric Carlson. Remove the requirement for media elements to have webkit-playsinline attributes on iOS. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): 2016-03-23 Anders Carlsson Crash when using KVO from within -[WebView initWithCoder:] https://bugs.webkit.org/show_bug.cgi?id=155816 rdar://problem/17073265 Reviewed by Dan Bernstein. Add test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added. (-[EarlyKVOCrashResponder initWithWebView:]): (-[EarlyKVOCrashResponder initWithCoder:]): (-[EarlyKVOCrashResponder dealloc]): (-[EarlyKVOCrashResponder encodeWithCoder:]): (TestWebKitAPI::TEST): 2016-03-23 Lucas Forschler Teach kill-old-processes about perl 5.18. Reviewed by Alexey Proskuryakov * BuildSlaveSupport/kill-old-processes: (main): 2016-03-22 Keith Rollin Unreviewed: add Keith Rollin to the committers list. * Scripts/webkitpy/common/config/contributors.json: 2016-03-22 Per Arne Vollan [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround https://bugs.webkit.org/show_bug.cgi?id=141499 Reviewed by Brent Fulgham. As we have moved on to VS2015, this workaround is no longer needed. * DumpRenderTree/cg/ImageDiffCG.cpp: (main): * DumpRenderTree/win/DumpRenderTree.cpp: (main): * DumpRenderTree/win/ImageDiffCairo.cpp: (main): * MiniBrowser/win/Common.cpp: (DllMain): * TestWebKitAPI/win/main.cpp: (main): * win/DLLLauncher/DLLLauncherMain.cpp: (wWinMain): 2016-03-22 Yusuke Suzuki [JSC] ASMBench cannot be run without JSBENCH_PATH https://bugs.webkit.org/show_bug.cgi?id=155751 Reviewed by Saam Barati. Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files. * Scripts/run-jsc-benchmarks: 2016-03-21 Brent Fulgham [Win] SharedBuffer::copy() can cause a segmentation fault. https://bugs.webkit.org/show_bug.cgi?id=155739 Reviewed by Ryosuke Niwa. * TestWebKitAPI/PlatformWin.cmake: Build and run the SharedBuffer tests. 2016-03-22 Csaba Osztrogonác [buildbot] Move ARM Linux bots to JSCOnly port https://bugs.webkit.org/show_bug.cgi?id=155655 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (ConfigureBuild.__init__): (appendCustomBuildFlags): (CompileJSCOnly): (Factory.__init__): (BuildAndRemoteJSCTestsFactory): (BuildAndRemoteJSCTestsFactory.__init__): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: * BuildSlaveSupport/clean-build: (main): 2016-03-21 Brent Fulgham Improve SharedBuffer testing https://bugs.webkit.org/show_bug.cgi?id=93078 Reviewed by Ryosuke Niwa. Based on a Blink patch by Huang Dongsung . Add three test cases from the Blink project that cover various append, copy, and createArrayBuffer calls. * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: (TestWebKitAPI::TEST_F): 2016-03-21 Hyungwook Lee [Win] Connect layoutTestController.findString() to support testing https://bugs.webkit.org/show_bug.cgi?id=50234 Reviewed by Alex Christensen. Implement TestRunner::findString(). * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::findString): 2016-03-20 Dan Bernstein [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR https://bugs.webkit.org/show_bug.cgi?id=155707 Reviewed by Darin Adler. * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET. * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version. Similarly for these projects: * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/Base.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebEditingTester/Configurations/Base.xcconfig: * WebEditingTester/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 2016-03-20 Dan Bernstein Update build settings Rubber-stamped by Andy Estes. * ContentExtensionTester/Configurations/DebugRelease.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source. * WebEditingTester/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: * asan/asan.xcconfig: 2016-03-18 Sam Weinig Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost https://bugs.webkit.org/show_bug.cgi?id=155621 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger): (TestWebKitAPI::testMovingUsingEnsure): (TestWebKitAPI::testMovingUsingAdd): Add tests ensuring that objects moved into a map using ensure don't have extra ref-churn. 2016-03-17 Tim Horton Fix some deprecation warnings in WebEditingTester https://bugs.webkit.org/show_bug.cgi?id=155601 Reviewed by Simon Fraser. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate showOperations:]): (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]): 2016-03-17 Tim Horton Find-in-page indicator in Mail viewer is the wrong scale and cut off https://bugs.webkit.org/show_bug.cgi?id=155605 Reviewed by Simon Fraser. * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: (TEST): Add a test that ensures that the find result image is correctly @2x. The NSImage size should be in points. 2016-03-16 Commit Queue Unreviewed, rolling out r198187. https://bugs.webkit.org/show_bug.cgi?id=155564 Potentially break testing on iOS (Requested by Guest23 on #webkit). Reverted changeset: "Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled." https://bugs.webkit.org/show_bug.cgi?id=154667 http://trac.webkit.org/changeset/198187 2016-03-16 David Kilzer check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI Reviewed by Darin Adler. * Scripts/webkitpy/style/checker.py: (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks on TestWebKitAPI since this project uses a config.h header as of r95188. Also remove references to WebKitAPITest, which ceased to exist in r95944. * Scripts/webkitpy/style/checker_unittest.py: (GlobalVariablesTest.test_path_rules_specifier): Add tests. Remove reference to WebKitAPITest project. 2016-03-16 Tim Horton [mac] Printing test snapshots are upside-down after r198242 https://bugs.webkit.org/show_bug.cgi?id=155543 Reviewed by Simon Fraser. * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createPagedBitmapContext): Flip printing snapshots in DRT so that everything is right-side-up. 2016-03-16 Alexey Proskuryakov Update unit test for iOS debug queues. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: 2016-03-16 Jiewen Tan URL Parsing should signal failure for illegal IDN https://bugs.webkit.org/show_bug.cgi?id=154945 Reviewed by Brent Fulgham. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetch:]): * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: (TestWebKitAPI::TEST): 2016-03-15 Tim Horton [iOS Simulator] Test result snapshots are upside down https://bugs.webkit.org/show_bug.cgi?id=154761 Reviewed by Simon Fraser. * WebKitTestRunner/cg/TestInvocationCG.cpp: (WTR::createCGContextFromImage): (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): In r97104, Simon added code to take WindowServer snapshots, which came in flipped, and added code to flip them back. At this point, WindowServer snapshots got flipped, and software snapshots did not. In r140067, Simon noticed that WindowServer ref test images were upside-down on Mac (not sure why this changed), so turned off the flipping code (but didn't delete it!). Now, WindowServer snapshots and software snapshots both are not flipped. In r190304, Carlos added an enum for the source of the snapshot ("WebView" for window server snapshots, and "WebContent" for software snapshots), and - critically - changed the flipping logic to flip software snapshots! We didn't notice this on Mac because at this point we've made it so that we *always* have WindowServer snapshots, but on iOS we still don't have WindowServer snapshots, so now they're flipped. And that's how we got here. To restore the behavior from r140067, and correctly unflip snapshots on iOS, just delete this code. 2016-03-15 Alexey Proskuryakov run-api-tests doesn't print test name when the test crashes https://bugs.webkit.org/show_bug.cgi?id=155476 Reviewed by Daniel Bates. * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output doesn't contain the test name yet. Changed test name output to always be before raw stdout for clarity. 2016-03-15 Chris Dumez Unreviewed, rolling out r198203. Favorites view is no longer loading on iOS Reverted changeset: "URL Parsing should signal failure for illegal IDN" https://bugs.webkit.org/show_bug.cgi?id=154945 http://trac.webkit.org/changeset/198203 2016-03-15 Jiewen Tan URL Parsing should signal failure for illegal IDN https://bugs.webkit.org/show_bug.cgi?id=154945 Reviewed by Brent Fulgham. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetch:]): * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: (TestWebKitAPI::TEST): 2016-03-14 Chris Dumez Unreviewed, rolling out r197981. Caused a massive PLT regression on Mac. Reverted changeset: "Font antialiasing (smoothing) changes when elements are rendered into compositing layers" https://bugs.webkit.org/show_bug.cgi?id=23364 http://trac.webkit.org/changeset/197981 2016-03-14 Dewei Zhu Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled. https://bugs.webkit.org/show_bug.cgi?id=154667 Reviewed by Ryosuke Niwa and Simon Fraser. Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled. Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: (ServerControl.render_POST): Deleted. * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook.find_module): (AutoinstallImportHook._install_twisted_15_5_0): * Scripts/webkitpy/thirdparty/__init___unittest.py: (ThirdpartyTest.test_imports): 2016-03-14 Mark Lam Need to distinguish between Symbol() and Symbol(""). https://bugs.webkit.org/show_bug.cgi?id=155438 Reviewed by Saam Barati. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): - Test that the a symbol with an empty string is not equivalent to a null symbol. 2016-03-14 David Kilzer Remove blank lines after #include "config.h" Follow-up fix from review comments on Bug 155394. * TestWebKitAPI/PlatformUtilities.cpp: * TestWebKitAPI/Tests/WTF/RefLogger.cpp: 2016-03-14 Frederic Wang Unreviewed: Add my professional email address. * Scripts/webkitpy/common/config/contributors.json: 2016-03-14 Youenn Fablet Web platform test server should not try to launch servers on already bound sockets https://bugs.webkit.org/show_bug.cgi?id=141157 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json. (base_url): Refactored to use wpt_config_json routine. (WebPlatformTestServer.__init__): Fill port mappings according WPT config. 2016-03-13 Joseph Pecoraro Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards https://bugs.webkit.org/show_bug.cgi?id=155417 Reviewed by Yusuke Suzuki. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-03-13 Dean Jackson DRT should enable WebGL by default on Mac https://bugs.webkit.org/show_bug.cgi?id=155419 Reviewed by Sam Weinig. For some reason, lost in time, WebGL was enabled by default on trunk, but disabled by default in DumpRenderTree when using WebKit 1. This was very annoying, because each test had an explicit command to enable it. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Deleted WebGL line. 2016-03-13 Konstantin Tokarev Added new port JSCOnly. https://bugs.webkit.org/show_bug.cgi?id=154512 Reviewed by Michael Catanzaro. This port allows to build JavaScriptCore engine with minimal dependencies. * Scripts/build-jsc: * Scripts/webkitdirs.pm: (argumentsForConfiguration): (executableProductDir): (determinePortName): (isJSCOnly): (wrapperPrefixIfNeeded): (generateBuildSystemFromCMakeProject): (buildCMakeGeneratedProject): 2016-03-13 David Kilzer TestWebKitAPI: fix linker warnings Reviewed by Darin Adler. * TestWebKitAPI/CMakeLists.txt: - Add RefLogger.cpp source file. - Add other missing cross-platform source files. - Add FIXMEs about RunLoop.cpp and about missing platform-specific source files. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: - Add RefLogger.cpp source file. * TestWebKitAPI/Counters.cpp: (DeleterCounter::deleterCount): Move specific declaration here to fix linker warning. * TestWebKitAPI/Counters.h: (DeleterCounter::deleterCount): Remove declaration of global template variable. * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added. (TestWebKitAPI::log): Added. Move inline definition in RefLogger.h to here to fix linker warning. * TestWebKitAPI/Tests/WTF/RefLogger.h: (TestWebKitAPI::log): Replace inline function with declaration. 2016-03-12 David Kilzer REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to "Test.h" to fix incorrect case. This was discovered when adding WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394. 2016-03-12 David Kilzer run-webkit-tests: handle Darwin framework/library environment variables more consistently Reviewed by Daniel Bates. These changes will make it possible to pass through environment variables from the run-webkit-tests command-line. * Scripts/webkitpy/port/base.py: (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH, __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the list of variables to keep from the run-webkit-test environment. * Scripts/webkitpy/port/driver.py: (Driver._append_environment_variable_path): Add method to append a path to an environment variable, or set the path if the variable doesn't exist. (Driver._setup_environ_for_driver): Extract build_root_path into a local variable. Use Driver._append_environment_variable_path to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH, DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of overwriting them. * Scripts/webkitpy/port/driver_unittest.py: (DriverTest.test__append_environment_variable_path): Add test method to test Driver._append_environment_variable_path. 2016-03-11 Alexey Proskuryakov [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out https://bugs.webkit.org/show_bug.cgi?id=155276 [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out https://bugs.webkit.org/show_bug.cgi?id=155345 [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll https://bugs.webkit.org/show_bug.cgi?id=153997 TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty Rubber-stamped by Filip Pizlo. * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout. * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on iOS again. 2016-03-11 Jer Noble [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting https://bugs.webkit.org/show_bug.cgi?id=155365 Reviewed by Darin Adler. Allow tests running on iOS simulator to play video inline, avoiding this assert. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): 2016-03-11 Frederic Wang [jhbuild] Disable LLVM OCaml bindings. https://bugs.webkit.org/show_bug.cgi?id=153274 Reviewed by Michael Catanzaro. * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM. 2016-03-11 Commit Queue Unreviewed, rolling out r197495. https://bugs.webkit.org/show_bug.cgi?id=155369 LLVM is needed to run update-webkitgtk-libs reliably (Requested by mcatanzaro on #webkit). Reverted changeset: "[jhbuild] Remove LLVM dependency." https://bugs.webkit.org/show_bug.cgi?id=153274 http://trac.webkit.org/changeset/197495 2016-03-11 Youenn Fablet WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings https://bugs.webkit.org/show_bug.cgi?id=153419 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringOperators.cpp: (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase. 2016-03-10 Simon Fraser Font antialiasing (smoothing) changes when elements are rendered into compositing layers https://bugs.webkit.org/show_bug.cgi?id=23364 Reviewed by Tim Horton. Turn off smoothed layer text because it affects many layout test results. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): 2016-03-10 Jer Noble Partial roll-out of r197953; test fails because encode/decode support of those properties were never added. * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): Deleted. 2016-03-10 Myles C. Maxfield [OS X] Main frame scrollbars should appear on the left on RTL systems https://bugs.webkit.org/show_bug.cgi?id=155149 Reviewed by Simon Fraser. Setting the volatile default needs to be done early, so it is plumbed through the injected bundle's initialization routine. Control of RTL scrollbars is handled by putting the string on the first line of a test. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::shouldUseRTLScrollbars): (WTR::InjectedBundle::platformInitialize): * WebKitTestRunner/TestController.cpp: (WTR::TestController::generatePageConfiguration): (WTR::updateTestOptionsFromTestHeader): (WTR::TestController::getInjectedBundleInitializationUserData): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::viewSupportsOptions): 2016-03-08 Jer Noble Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally https://bugs.webkit.org/show_bug.cgi?id=155141 Reviewed by Beth Dakin. Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture" to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture". Add a new test of WK2 user gesture requirement preferences. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added. (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): (RequiresUserActionForPlaybackTest::SetUp): (RequiresUserActionForPlaybackTest::createWebView): (RequiresUserActionForPlaybackTest::testVideoWithAudio): (RequiresUserActionForPlaybackTest::testVideoWithoutAudio): (RequiresUserActionForPlaybackTest::testAudioOnly): (TEST_F): * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): 2016-03-10 Brian Burg Web Inspector: should be able to run protocol and input generator scripts from any directory https://bugs.webkit.org/show_bug.cgi?id=155307 Reviewed by Joseph Pecoraro. * Scripts/webkitpy/inspector/main.py: (InspectorGeneratorTests.main): * Scripts/webkitpy/replay/main.py: (InputGeneratorTests.main): Compute the current SCM based on the location of the script being executed, not the $CWD which could be anything. There's rarely a good reason to use $CWD. 2016-03-10 David Kilzer [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL Reviewed by Brent Fulgham. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::inspectorTestStubURL): Always return nullptr for PLATFORM(IOS). This matches what we did in r192604 for WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm. 2016-03-10 Frederic Wang [GTK] Add support for WOFF2 https://bugs.webkit.org/show_bug.cgi?id=152616 Reviewed by Carlos Garcia Campos. * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2. 2016-03-09 Ryosuke Niwa Add runtime flags for shadow DOM and custom elements https://bugs.webkit.org/show_bug.cgi?id=155213 Reviewed by Dean Jackson. Always enable shadow DOM and custom elements during testing. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setShadowDOMEnabled): Added. * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-03-09 Brent Fulgham Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage https://bugs.webkit.org/show_bug.cgi?id=155265 Reviewed by Andy Estes. WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default. Tests that confirm blocking localStorage manually set the flag to "False" in the test. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): Set the default state to the correct value. 2016-03-09 David Kilzer check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files Reviewed by Andy Estes. * Scripts/webkitpy/style/checkers/cpp.py: (check_spacing_for_function_call): Ignore @catch lines. (check_braces): Ditto. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_brace_at_begin_of_line): Add test case. 2016-03-09 Jason Marcell Removing reference to Dashboard.Repository.Internal.trac from open source unit tests. https://bugs.webkit.org/show_bug.cgi?id=155274 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an error in the unit tests. 2016-03-09 Aakash Jain use ulimit command to check process limit in webkitpy https://bugs.webkit.org/show_bug.cgi?id=155260 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of launchctl limit maxproc command. 2016-03-09 Alexey Proskuryakov Stop building armv7 on iOS device builders https://bugs.webkit.org/show_bug.cgi?id=155246 Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions elsewhere. * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want EWS configuration to be verified by buildbot queues. * Scripts/webkitdirs.pm: * Scripts/webkitpy/port/ios.py: Changed default to arm64. I think that the default is probably not used in any practical scenarios, but it's nice to make it more sensible. 2016-03-09 Alexey Proskuryakov Add iOS Simulator EWS to bot watcher's dashboard https://bugs.webkit.org/show_bug.cgi?id=155220 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: 2016-03-09 Brent Fulgham Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked https://bugs.webkit.org/show_bug.cgi?id=155185 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: (TestWebKitAPI::TEST): Allow local file accesss to run test. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: (TEST): Ditto. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: (TEST): Ditto. 2016-03-09 Tim Horton Removing and re-adding a script message handler with the same name results in an unusable message handler https://bugs.webkit.org/show_bug.cgi?id=155223 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: (TEST): Add a test ensuring that it is possible to remove and re-add a script message handler with the same name and still dispatch messages to it. 2016-03-08 Alexey Proskuryakov Fix iOS Simulator EWS. Unreviewed build fix. * Scripts/webkitpy/common/config/ports.py: 2016-03-08 Aakash Jain Booting multiple iOS simulator parallely fails sometimes https://bugs.webkit.org/show_bug.cgi?id=155208 Reviewed by Darin Adler. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent simulator boot. 2016-03-08 Alexey Proskuryakov Add iOS debug testers to flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=155206 Reviewed by Darin Adler. * TestResultServer/static-dashboards/builders.jsonp: 2016-03-08 Oliver Hunt Start moving to separated writable and executable mappings in the JIT https://bugs.webkit.org/show_bug.cgi?id=155178 Reviewed by Fil Pizlo. Making run-jsc-benchmarks slightly happier on my machine. * Scripts/run-jsc-benchmarks: 2016-03-08 Anders Carlsson Use NSUInteger instead of NSWindowStyleMask. * MiniBrowser/mac/MiniBrowser_Prefix.pch: 2016-03-08 Anders Carlsson Fix build. We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want MiniBrowser to build without WTF. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]): * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): * MiniBrowser/mac/MiniBrowser_Prefix.pch: 2016-03-08 Alexey Proskuryakov Add iOS simulator EWS that runs tests https://bugs.webkit.org/show_bug.cgi?id=155175 Reviewed by Lucas Forschler. * QueueStatusServer/config/queues.py: * Scripts/webkitpy/common/config/ews.json: * Scripts/webkitpy/common/config/ports.py: 2016-03-08 Commit Queue Unreviewed, rolling out r197793 and r197799. https://bugs.webkit.org/show_bug.cgi?id=155195 something weird happened while landing this and everything broke (Requested by olliej on #webkit). Reverted changesets: "Start moving to separated writable and executable mappings in the JIT" https://bugs.webkit.org/show_bug.cgi?id=155178 http://trac.webkit.org/changeset/197793 "arm64 build fix after r197793." http://trac.webkit.org/changeset/197799 2016-03-08 Oliver Hunt Start moving to separated writable and executable mappings in the JIT https://bugs.webkit.org/show_bug.cgi?id=155178 Reviewed by Filip Pizlo. Making run-jsc-benchmarks slightly happier on my machine. * Scripts/run-jsc-benchmarks: 2016-03-08 Daniel Bates Support iterating over an OptionSet and checking if it is empty https://bugs.webkit.org/show_bug.cgi?id=154941 Reviewed by Darin Adler. Add tests to ensure that we do not regression both iteration of an OptionSet and determining whether an OptionSet is empty. * TestWebKitAPI/Test.h: (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality. * TestWebKitAPI/Tests/WTF/OptionSet.cpp: (TestWebKitAPI::TEST): 2016-03-08 Alexey Proskuryakov Add debug iOS Simulator bots to the dashboard https://bugs.webkit.org/show_bug.cgi?id=155157 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: 2016-03-08 Alejandro G. Castro Unreviewed EFL build fix after r197752. * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM compilation by default until EFL bumps gstreamer to 1.6. 2016-03-08 Alejandro G. Castro [GTK] [EFL] Avoid running mediastream tests by default until we compile by default https://bugs.webkit.org/show_bug.cgi?id=153540 Reviewed by Philippe Normand. After bumping gstreamer to 1.6.3 in r196804 we can enable again compilation of mediastream and running the tests. * Scripts/run-gtk-tests: (TestRunner): Enable again the UserMedia API test. * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the mediastream by default. * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules file. * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we are currently using. 2016-03-07 Jon Lee Update perf bot configuration for Animometer https://bugs.webkit.org/show_bug.cgi?id=155134 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch to work with the latest version of the harness. * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout, and use the latest version of the harness. 2016-03-07 Joanmarie Diggs [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0 https://bugs.webkit.org/show_bug.cgi?id=154839 Reviewed by Michael Catanzaro. Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos. * gtk/jhbuild-webrtc.modules: * gtk/jhbuild.modules: * gtk/jhbuildrc: 2016-03-07 Aakash Jain webkitpy should verify timestamp from CrashLogs while collecting all crash logs https://bugs.webkit.org/show_bug.cgi?id=155000 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/system/crashlogs.py: (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected time range, because file modification time is not always accurate. (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs. * Scripts/webkitpy/common/system/crashlogs_unittest.py: (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function. 2016-03-06 Alexey Proskuryakov build-webkit prints an error on iOS simulator bots https://bugs.webkit.org/show_bug.cgi?id=155078 Reviewed by Dan Bernstein. This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK. * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because XcodeOptions() already passes SDKROOT as appropriate. * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset any other configuration variables that were derived from its initial value, like $portName. 2016-03-05 Tim Horton Create a DOMHTMLVideoElement when wrapping