BuildRequest should have a method to fetch all in-progress and pending requests for...

[WebKit.git] / Websites / perf.webkit.org / ChangeLog

2016-03-30  Ryosuke Niwa  <rniwa@webkit.org>

        BuildRequest should have a method to fetch all in-progress and pending requests for a triggerable
        https://bugs.webkit.org/show_bug.cgi?id=156008

        Reviewed by Darin Adler.

        Add a method to BuildRequest that fetches all pending and in-progress requests for a triggerable.

        Now, new syncing scripts must be able to figure out the build slave the first build requests in
        a given test group had used in order to schedule subsequent build requests in the test group.

        For this purpose, /api/build-requests has been modified to return all build requests whose test
        group had not finished yet. A test group is finished if all build requests in the test group had
        finished (completed, failed, or canceled).

        * public/include/build-requests-fetcher.php:
        (BuildRequestFetcher::fetch_incomplete_requests_for_triggerable): Return all build requests in test
        groups that have not been finished.
        * public/v3/models/build-request.js:
        (BuildRequest):
        (BuildRequest.prototype.testGroupId): Added.
        (BuildRequest.prototype.isPending): Renamed from hasPending to fix a bad grammar.
        (BuildRequest.fetchForTriggerable): Added.
        (BuildRequest.constructBuildRequestsFromData): Extracted from _createModelsFromFetchedTestGroups in
        TestGroup.
        * public/v3/models/manifest.js:
        (Manifest.fetch): Use the full path from root so that it works in server tests.
        * public/v3/models/test-group.js:
        (TestGroup.hasPending):
        (TestGroup._createModelsFromFetchedTestGroups):
        * server-tests/api-build-requests-tests.js: Added tests to ensure all build requests for a test group
        is present in the response returned by /api/build-requests iff any build request in the group had not
        finished yet.
        (.addMockData):
        (.addAnotherMockTestGroup): Added.
        * unit-tests/test-groups-tests.js:

2016-03-29  Ryosuke Niwa  <rniwa@webkit.org>

        Make dependency injection in unit tests more explicit
        https://bugs.webkit.org/show_bug.cgi?id=156006

        Reviewed by Joseph Pecoraro.

        Make the dependency injection of model objects in unit tests explicit so that server tests that create
        "real" model objects won't create these mock objects. Now each test that uses mock model objects would call
        MockModels.inject() to inject before / beforeEach and access each object using a property on MockModels
        instead of them being implicitly defined on the global object.

        Similarly, MockRemoteAPI now only replaces global.RemoteAPI during each test so that server tests can use
        real RemoteAPI to access the test Apache server.

        * unit-tests/analysis-task-tests.js:
        * unit-tests/buildbot-syncer-tests.js:
        (createSampleBuildRequest):
        * unit-tests/measurement-adaptor-tests.js:
        * unit-tests/measurement-set-tests.js:
        * unit-tests/resources/mock-remote-api.js:
        (MockRemoteAPI.getJSONWithStatus):
        (MockRemoteAPI.inject): Added. Override RemoteAPI on the global object during each test.
        * unit-tests/resources/mock-v3-models.js:
        (MockModels.inject): Added. Create mock model objects before each test, and clear all static maps of
        various v3 model classes (to remove all singleton objects for those model classes).
        * unit-tests/test-groups-tests.js:

2016-03-29  Ryosuke Niwa  <rniwa@webkit.org>

        BuildbotSyncer should be able to fetch JSON from buildbot
        https://bugs.webkit.org/show_bug.cgi?id=155921

        Reviewed by Joseph Pecoraro.

        Added BuildbotSyncer.pullBuildbot which fetches pending, in-progress, and finished builds from buildbot
        with lots of unit tests as this has historically been a source of subtle bugs in the old script.

        New implementation fixes a subtle bug in the old pythons script which overlooked the possibility that
        the state of some builds may change between each HTTP request. In the old script, we fetched the list
        of the pending builds, and requested -1, -2, etc... builds for N times. But between each request,
        a pending build may start running or an in-progress build finish and shift the offset by one. The new
        script avoids this problem by first requesting all pending builds, then all in-progress and finished
        builds in a single HTTP request. The results are then merged so that entries for in-progress and
        finished builds would override the entries for pending builds if they overlap.

        Also renamed RemoteAPI.fetchJSON to RemoteAPI.getJSON to match v3 UI's RemoteAPI. This change makes
        the class interchangeable between frontend (public/v3/remote.js) and backend (tools/js/remote.js).

        * server-tests/api-build-requests-tests.js:
        * server-tests/api-manifest.js:
        * tools/js/buildbot-syncer.js:
        (BuildbotBuildEntry): Removed the unused argument "type". Store the syncer as an instance variable as
        we'd need to query for the buildbot URL. Also fixed a bug that _isInProgress was true for finished
        builds as 'currentStep' is always defined but null in those builds.
        (BuildbotBuildEntry.prototype.buildNumber): Added.
        (BuildbotBuildEntry.prototype.isPending): Added.
        (BuildbotBuildEntry.prototype.hasFinished): Added.
        (BuildbotSyncer.prototype.pullBuildbot): Added. Fetches pending builds first and then finished builds.
        (BuildbotSyncer.prototype._pullRecentBuilds): Added. Fetches in-progress and finished builds.
        (BuildbotSyncer.prototype.urlForPendingBuildsJSON): Added.
        (BuildbotSyncer.prototype.urlForBuildJSON): Added.
        (BuildbotSyncer.prototype.url): Added.
        (BuildbotSyncer.prototype.urlForBuildNumber): Added.
        * tools/js/remote.js:
        (RemoteAPI.prototype.getJSON): Renamed from fetchJSON.
        (RemoteAPI.prototype.getJSONWithStatus): Renamed from fetchJSONWithStatus.
        * tools/js/v3-models.js: Load tools/js/remote.js instead of public/v3/remote.js inside node.
        * unit-tests/buildbot-syncer-tests.js: Added a lot of unit tests for BuildbotSyncer.pullBuildbot
        (samplePendingBuild):
        (sampleInProgressBuild): Added.
        (sampleFinishedBuild): Added.
        * unit-tests/resources/mock-remote-api.js:
        (global.RemoteAPI.getJSON): Use the same mock as getJSONWithStatus.

2016-03-24  Ryosuke Niwa  <rniwa@webkit.org>

        Migrate admin-regenerate-manifest.js to mocha.js and test v3 UI code
        https://bugs.webkit.org/show_bug.cgi?id=155863

        Reviewed by Joseph Pecoraro.

        Replaced admin-regenerate-manifest.js by a new mocha.js tests using the new server testing capability
        added in r198642 and tested v3 UI code (parsing manifest.json and creating models). Also removed
        /admin/regenerate-manifest since it has been superseded by /api/manifest.

        This patch also extracts manifest.js out of main.js so that it could be used and tested without the
        DOM support in node.

        * public/admin/regenerate-manifest.php: Deleted.
        * public/include/db.php: Fixed a regression from r198642 since CONFIG_DIR now doesn't end with
        a trailing backslash.
        * public/include/manifest.php:
        (ManifestGenerator::bug_trackers): Avoid a warning message when there are no repositories.
        * public/v3/index.html:
        * public/v3/main.js:
        (main):
        * public/v3/models/bug-tracker.js:
        (BugTracker.prototype.newBugUrl): Added.
        (BugTracker.prototype.repositories): Added.
        * public/v3/models/manifest.js: Added. Extracted from main.js.
        (Manifest.fetch): Moved from main.js' fetchManifest.
        (Manifest._didFetchManifest): Moved from main.js' didFetchManifest.
        * public/v3/models/platform.js:
        (Platform.prototype.hasTest): Fixed the bug that "test" here was shadowing the function parameter of
        the same name. This is tested by the newly added test cases.
        * server-tests/api-build-requests-tests.js:
        * server-tests/api-manifest.js: Added. Migrated test cases from tests/admin-regenerate-manifest.js
        with additional assertions for v3 UI model objects.
        * server-tests/resources/test-server.js:
        (TestServer.prototype.start):
        (TestServer.prototype.testConfig): Renamed from _constructTestConfig now that this is a public API.
        Also no longer takes dataDirectory as an argument since it's always the same.
        (TestServer.prototype._ensureDataDirectory): Fixed a bug that we weren't making public/data.
        (TestServer.prototype.cleanDataDirectory): Added. Remove all files inside public/data between tests.
        (TestServer.prototype.inject): Added. Calls before, etc... because always calling before had an
        unintended side effect of slowing down unit tests even through they don't need Postgres or Apache.
        * tests/admin-regenerate-manifest.js: Removed.
        * tools/js/database.js:
        * tools/js/v3-models.js:

2016-03-23  Ryosuke Niwa  <rniwa@webkit.org>

        Add mocha server tests for /api/build-requests
        https://bugs.webkit.org/show_bug.cgi?id=155831

        Reviewed by Chris Dumez.

        Added the new mocha.js based server-tests for /api/build-requests. The new harness automatically:
         - starts a new Apache instance
         - switches the database during testing via setting an environmental variable 
         - backups and restores public/data directory during testing

        As a result, developer no longer has to manually setup Apache, edit config.json manually to use
        a testing database, or run /api/manifest.php to re-generate the manifest file after testing.

        This patch also makes ID resolution optional on /api/build-requests so that v3 model based syncing
        scripts can re-use the same code as the v3 UI to process the JSON. tools/sync-with-buildbot.py has
        been modified to use this option (useLegacyIdResolution).

        * config.json: Added configurations for the test httpd server.
        * init-database.sql: Don't error when tables and types don't exist (when database is empty).
        * public/api/build-requests.php:
        (main): Made the ID resolution optional with useLegacyIdResolution. Also removed "updates" from the
        results JSON since it's never used.
        * public/include/build-requests-fetcher.php:
        (BuildRequestsFetcher::__construct):
        (BuildRequestsFetcher::fetch_roots_for_set_if_needed): Fixed the bug that we would include the same
        commit multiple times for each root set.
        * public/include/db.php:
        (config): If present, use ORG_WEBKIT_PERF_CONFIG_PATH instead of Websites/perf.webkit.org/config.json.
        * server-tests: Added.
        * server-tests/api-build-requests-tests.js: Added. Tests for /api/build-requests.
        (.addMockData):
        * server-tests/resources: Added.
        * server-tests/resources/test-server.conf: Added. Apache configuration file for testing.
        * server-tests/resources/test-server.js: Added.
        (TestSever): Added.
        (TestSever.prototype.start): Added.
        (TestSever.prototype.stop): Added.
        (TestSever.prototype.remoteAPI): Added. Configures RemoteAPI to be used with the test sever.
        (TestSever.prototype.database): Added. Returns Database configured to use the test database.
        (TestSever.prototype._constructTestConfig): Creates config.json for testing. The file is generated by
        _start and db.php's config() reads it from the environmental variable: ORG_WEBKIT_PERF_CONFIG_PATH.
        (TestSever.prototype._ensureDataDirectory): Renames public/data to public/original-data if exists,
        and creates a new empty public/data.
        (TestSever.prototype._restoreDataDirectory): Deletes public/data and renames public/original-data
        back to public/data.
        (TestSever.prototype._ensureTestDatabase): Drops the test database if exists and creates a new one.
        (TestSever.prototype.initDatabase): Run init-database.sql to start each test with a consistent state.
        (TestSever.prototype._executePgsqlCommand): Executes a postgres command line tool such as psql.
        (TestSever.prototype._determinePgsqlDirectory): Finds the directory that contains psql.
        (TestSever.prototype._startApache): Starts an Apache instance for testing.
        (TestSever.prototype._stopApache): Stops the Apache instance for testing.
        (TestSever.prototype._waitForPid): Waits for the Apache pid file to appear or disappear.
        (before): Start the test server at the beginning.
        (beforeEach): Re-initialize all tables before each test.
        (after): Stop the test server at the end.
        * tools/js/config.js:
        (Config.prototype.path):
        (Config.prototype.serverRoot): Added. The path to Websites/perf.webkit.org/public/.
        (Config.prototype.pathFromRoot): Added. Resolves a path from Websites/perf.webkit.org.
        * tools/js/database.js:
        (Database): Now optionally takes the database name to use a different database during testing.
        (Database.prototype.connect):
        (Database.prototype.query): Added.
        (Database.prototype.insert): Added.
        (tableToPrefixMap): Maps table name to its prefix. Used by Database.insert.
        * tools/js/remote.js: Added.
        (RemoteAPI): Added. This is node.js equivalent of RemoteAPI in public/v3/remote.js.
        (RemoteAPI.prototype.configure): Added.
        (RemoteAPI.prototype.fetchJSON): Added.
        (RemoteAPI.prototype.fetchJSONWithStatus): Added.
        (RemoteAPI.prototype.sendHttpRequest): Added.
        * tools/sync-with-buildbot.py:
        (main): Use useLegacyIdResolution as this script relies on the legacy behavior.
        * unit-tests/checkconfig.js: pg was never directly used in this test.

2016-03-23  Ryosuke Niwa  <rniwa@webkit.org>

        Delete a file that was supposed to be removed in r198614 for real.

        * unit-tests/resources/v3-models.js: Removed.

2016-03-23  Ryosuke Niwa  <rniwa@webkit.org>

        Add a model for parsing buildbot JSON with unit tests
        https://bugs.webkit.org/show_bug.cgi?id=155814

        Reviewed by Joseph Pecoraro.

        Added BuildbotSyncer and BuildbotBuildEntry classes to parse buildbot JSON files with unit tests.
        They will be used in the new syncing scripts to improve A/B testing.

        * public/v3/models/build-request.js:
        (BuildRequest):
        * tools/js/buildbot-syncer.js: Added.
        (BuildbotBuildEntry): Added.
        (BuildbotBuildEntry.prototype.slaveName): Added.
        (BuildbotBuildEntry.prototype.buildRequestId): Added.
        (BuildbotBuildEntry.prototype.isInProgress): Added.
        (BuildbotSyncer): Added.
        (BuildbotSyncer.prototype.testPath): Added.
        (BuildbotSyncer.prototype.builderName): Added.
        (BuildbotSyncer.prototype.platformName): Added.
        (BuildbotSyncer.prototype.fetchPendingRequests): Added.
        (BuildbotSyncer.prototype._propertiesForBuildRequest): Added.
        (BuildbotSyncer.prototype._revisionSetFromRootSetWithExclusionList): Added.
        (BuildbotSyncer._loadConfig): Added.
        (BuildbotSyncer._validateAndMergeConfig): Added.
        (BuildbotSyncer._validateAndMergeProperties): Added.
        * tools/js/v3-models.js: Copied from unit-tests/resources/v3-models.js.
        (beforeEach): Deleted since this only defined inside mocha.
        * unit-tests/analysis-task-tests.js:
        * unit-tests/buildbot-syncer-tests.js: Added.
        (sampleiOSConfig):
        (createSampleBuildRequest):
        (.smallConfiguration):
        * unit-tests/measurement-adaptor-tests.js:
        * unit-tests/measurement-set-tests.js:
        * unit-tests/resources/mock-v3-models.js: Renamed from unit-tests/resources/v3-models.js.
        (beforeEach):
        * unit-tests/test-groups-tests.js:
        (sampleTestGroup):

2016-03-22  Ryosuke Niwa  <rniwa@webkit.org>

        Add unit tests for test-group.js
        https://bugs.webkit.org/show_bug.cgi?id=155781

        Reviewed by Joseph Pecoraro.

        Added unit tests for test-group.js that would have caught regressions fixed in r198503.

        * public/v3/components/chart-pane-base.js:
        (ChartPaneBase.prototype._renderAnnotations): Added a forgotten break statement.
        * public/v3/models/build-request.js:
        (BuildRequest.prototype.setResult):
        (BuildRequest):
        * public/v3/models/test-group.js:
        * unit-tests/measurement-set-tests.js: Use ./resources/v3-models.js to reduce the code duplication.
        * unit-tests/resources/v3-models.js: Import more stuff from v3 models.
        (beforeEach):
        * unit-tests/test-groups-tests.js: Added. Added some unit tests for TestGroup.
        (sampleTestGroup):
        (.testGroupWithStatusList):

2016-03-22  Ryosuke Niwa  <rniwa@webkit.org>

        Fix a typo.

        * config.json:

2016-03-21  Ryosuke Niwa  <rniwa@webkit.org>

        Commit log viewer repaints too frequently after r198499
        https://bugs.webkit.org/show_bug.cgi?id=155732

        Reviewed by Joseph Pecoraro.

        The bug was caused by InteractiveTimeSeriesChart invoking onchange callback whenever mouse moved even
        if the current point didn't change. Fixed the bug by avoiding the work if the indicator hadn't changed
        and avoiding work in the commit log viewer when the requested repository and the revision range were
        the same as those of the last request.

        * public/v3/components/commit-log-viewer.js:
        (CommitLogViewer):
        (CommitLogViewer.prototype.currentRepository): Exit early when repository and the revision range are
        identical to the one we already have to avoid repaints and issuing multiple network requests.
        * public/v3/components/interactive-time-series-chart.js:
        (InteractiveTimeSeriesChart.prototype._mouseMove): Don't invoke _notifyIndicatorChanged if the current
        indicator hadn't changed.
        * public/v3/pages/chart-pane.js:
        (ChartPane.prototype._indicatorDidChange): Fixed the bug that unlocking the indicator wouldn't update
        the URL. We need to check whether the lock state had changed. The old condition was also redundant
        since _mainChartIndicatorWasLocked is always identically equal to isLocked per the prior assignment.

2016-03-21  Ryosuke Niwa  <rniwa@webkit.org>

        Fix A/B testing after r198503.

        * public/include/build-requests-fetcher.php:

2016-03-21  Ryosuke Niwa  <rniwa@webkit.org>

        Analysis task page is broken after r198479
        https://bugs.webkit.org/show_bug.cgi?id=155735

        Rubber-stamped by Chris Dumez.

        * public/api/measurement-set.php:
        (AnalysisResultsFetcher::fetch_commits): We need to emit the commit ID as done for regular data.
        * public/include/build-requests-fetcher.php:
        (BuildRequestsFetcher::fetch_roots_for_set_if_needed): Ditto. Don't use a fake ID after r198479.
        * public/v3/models/commit-log.js:
        (CommitLog): Assert that all commit log IDs are integers to catch regressions like this in future.
        * public/v3/models/root-set.js:
        (RootSet): Don't resolve Repository here as doing so would modify the shared "root" entry in the JSON
        we fetched, and subsequent construction of RootSet would fail since this line would blow up trying to
        find the repository with "[object]" as the ID.
        * public/v3/models/test-group.js:
        (TestGroup._createModelsFromFetchedTestGroups): Resolve Repository here.

2016-03-21  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI sometimes don't update the list of revisions on the commit log viewer
        https://bugs.webkit.org/show_bug.cgi?id=155729

        Rubber-stamped by Chris Dumez.

        Fixed multiple bugs that were affecting the list of blame range and commit logs for the range weren't
        updated in some cases on v3 UI. Also, the commit log viewer state is now a part of the URL state so
        opening and closing the commit log viewer will persist across page loads.

        Also fixed a regression from r198479 that Test object can't be created for a top level test.

        * public/v3/components/chart-pane-base.js:
        (ChartPaneBase.prototype.configure):
        (ChartPaneBase.prototype._mainSelectionDidChange): Fixed the bug that the list of blame range nor the
        commit log viewer don't get updated when the selected range changes.
        (ChartPaneBase.prototype._indicatorDidChange):
        (ChartPaneBase.prototype._didFetchData):
        (ChartPaneBase.prototype._updateStatus): Extracted from _indicatorDidChange and _didFetchData.
        (ChartPaneBase.prototype._requestOpeningCommitViewer): Renamed from _openCommitViewer.

        * public/v3/components/chart-status-view.js:
        (ChartStatusView.prototype.updateStatusIfNeeded): Fixed the bug that the blame range doesn't get set
        on the initial page load when the selection range is set but the chart data hadn't been fetched yet.

        * public/v3/components/commit-log-viewer.js:
        (CommitLogViewer.prototype.view): Fixed the bug that we don't clear out the old list of commits while
        loading the next set of commits to show as it looked as if the list was never updated.
        (CommitLogViewer.prototype.render): Fixed the bug that the view always show the last repository name
        even if there were nothing being fetched or commits to show.

        * public/v3/components/pane-selector.js:
        (PaneSelector.prototype.focus): Removed superfluous call to console.log.

        * public/v3/models/data-model.js:
        (DataModelObject.listForStaticMap): Generalized the code for all to fix the bug in Test.
        (DataModelObject.all):

        * public/v3/models/test.js:
        (Test): Fixed the bug that this code was relying on the static map to be an array.
        (Test.topLevelTests): Use newly added listForStaticMap to convert the dictionary to an array.

        * public/v3/pages/chart-pane-status-view.js:
        (ChartPaneStatusView): Always initialize _usedRevisionRange as a triple to simplify code elsewhere.
        (ChartPaneStatusView.prototype.render): Invoke _revisionCallback when user clicks on a repository
        expansion mark (>>). Also fixed click handler from the row since this made selecting revision range
        on the view cumbersome. Now user has to explicitly click on the expansion mark (>>).
        (ChartPaneStatusView.prototype._setRevisionRange): Now takes shouldNotify, from, and to as arguments
        as this function must not invoke_revisionCallback inside _updateRevisionListForNewCurrentRepository.
        (ChartPaneStatusView.prototype.moveRepositoryWithNotification): Use newly added setCurrentRepository
        instead of manually invoking setCurrentRepository and updateRevisionListWithNotification.
        (ChartPaneStatusView.prototype.setCurrentRepository): Fixed the bug that we weren't updating the
        blame list here.
        (ChartPaneStatusView.prototype.updateRevisionList): Renamed from updateRevisionListWithNotification
        since we no longer call _revisionCallback. In general, callbacks are only meant to communicate user
        initiated actions, and not program induced updates like this API so this was a bad pattern anyway.
        ChartPane now explicitly updates the commit log viewer instead of relying on this function calling
        _requestOpeningCommitViewer implicitly.
        (ChartPaneStatusView.prototype._updateRevisionListForNewCurrentRepository): Extracted from
        updateRevisionListWithNotification so that setCurrentRepository can also call this function.

        * public/v3/pages/chart-pane.js:
        (ChartPane.prototype._requestOpeningCommitViewer): Overrides ChartPaneBase's method. Open the same
        repository in other panes via ChartsPage.setOpenRepository.
        (ChartPane.prototype.setOpenRepository): This method is called when the user selected a repository in
        another pane. Open the same repository in this pane if it wasn't already open.

        * public/v3/pages/charts-page.js:
        (ChartsPage): Added this._currentRepositoryId.
        (ChartsPage.prototype.serializeState): Serialize _currentRepositoryId.
        (ChartsPage.prototype.updateFromSerializedState): Set the commit log viewer's 
        (ChartsPage.prototype.setOpenRepository): Added.

        * tests/api-measurement-set.js: Fixed a test after r198479.

2016-03-21  Ryosuke Niwa  <rniwa@webkit.org>

        V3 Perf Dashboard should automatically select initial range when creating a new task
        https://bugs.webkit.org/show_bug.cgi?id=155677

        Reviewed by Joseph Pecoraro.

        Select the entire range of points for which the analysis task is created by default so that creating
        a test group to confirm the regression / progression is easy.

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage): Added a boolean flag which indicates the user had modified main chart's selection.
        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage.prototype.render): Set the main chart's selection to the entire range of points in
        the analysis task if the user had never modified selection.
        (AnalysisTaskPage.prototype._chartSelectionDidChange): This callback is invoked only when the user had
        modified the selection so set _selectionWasModifiedByUser true here unconditionally.

2016-03-19  Ryosuke Niwa  <rniwa@webkit.org>

        Associated commits don't immediately show up on an analysis task page
        https://bugs.webkit.org/show_bug.cgi?id=155692

        Reviewed by Darin Adler.

        The bug was caused by resolveCommits in AnalysisTask._constructAnalysisTasksFromRawData not being
        able to find the matching commit log if the commit log had been created by the charts which don't
        set the remote identifiers on each CommitLog objects.

        Fixed the bug by modifying /api/measurement-set to include the commit ID, and making CommitLog
        use the real database ID as its ID instead of a fake ID we create from repository and revision.

        Also added a bunch of Mocha unit tests for AnalysisTask.fetchAll.

        * public/api/measurement-set.php:
        (MeasurementSetFetcher::execute_query): Fetch commit_id.
        (MeasurementSetFetcher::format_run): Use pass-by-reference to avoid making a copy of the row.
        (MeasurementSetFetcher::parse_revisions_array): Include commit_id as the first item in the result.
        * public/v3/instrumentation.js:
        * public/v3/models/analysis-task.js:
        (AnalysisTask): Fixed a bug that _buildRequestCount and _finishedBuildRequestCount could be kept
        as strings and hasPendingRequests() could return a wrong result because it would perform string
        inequality instead of numerical inequality.
        (AnalysisTask.prototype.updateSingleton): Ditto.
        (AnalysisTask.prototype.dissociateCommit):
        (AnalysisTask._constructAnalysisTasksFromRawData):
        (AnalysisTask._constructAnalysisTasksFromRawData.resolveCommits): Use findById now that CommitLog
        objects all use the same id as the database id.
        * public/v3/models/commit-log.js:
        (CommitLog):
        (CommitLog.prototype.remoteId): Deleted since we no longer create a fake id for commit logs for
        measurement sets.
        (CommitLog.findByRemoteId): Deleted.
        (CommitLog.ensureSingleton): Deleted.
        (CommitLog.fetchBetweenRevisions):

        * public/v3/models/data-model.js:
        (DataModelObject.clearStaticMap): Added to aid unit testing.
        (DataModelObject.ensureNamedStaticMap): Fixed a typo. Each map is a dictionary, not an array.
        * public/v3/models/metric.js:
        * public/v3/models/platform.js:
        * public/v3/models/root-set.js:
        (RootSet): Updated per the interface change in CommitLog.ensureSingleton.
        (MeasurementRootSet): Updated per /api/measurement-set change. Use the first value as the id.
        * public/v3/models/test.js:
        * unit-tests/analysis-task-tests.js: Added.
        (sampleAnalysisTask):
        (measurementCluster):
        * unit-tests/checkconfig.js: Added some assertion message to help aid diagnosing the failure.
        * unit-tests/measurement-adaptor-tests.js: Updated the sample data per the API change in
        /api/measurement-set and also added assertions for commit log ids.
        * unit-tests/measurement-set-tests.js:
        (beforeEach):
        * unit-tests/resources: Added.
        * unit-tests/resources/mock-remote-api.js: Added. Extracted from measurement-set-tests.js to be
        used in analysis-task-tests.js.
        (assert.notReached.assert.notReached):
        (global.RemoteAPI.getJSON):
        (global.RemoteAPI.getJSONWithStatus):
        (beforeEach):
        * unit-tests/resources/v3-models.js: Added. Extracted from measurement-set-tests.js to be used in
        analysis-task-tests.js and added more imports as needed.
        (importFromV3):
        (beforeEach):

2016-03-18  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r198464.

        * public/v3/components/analysis-results-viewer.js:
        (AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):

2016-03-18  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r198234.

        * public/api/commits.php:
        (main): Typo: fetch_latest_reported -> fetch_last_reported.
        * public/include/commit-log-fetcher.php:
        (CommitLogFetcher::format_single_commit): commits should be an array.

2016-03-18  Ryosuke Niwa  <rniwa@webkit.org>

        Perf Dashboard v3 confuses better and worse on A/B task page
        https://bugs.webkit.org/show_bug.cgi?id=155675
        <rdar://problem/25208723>

        Reviewed by Joseph Pecoraro.

        The analysis results viewer on v3 UI sometimes treats regressions as progressions and vice versa when
        the first set (i.e. set A) of the revisions used in an A/B testing never appears in the original graph,
        and its latest commit time matches that of the second set, which appears in the original graph.

        Because the analysis results viewer compares results in the increasing row number, this results in
        B to be compared to A instead of A to be compared to B. Fixed the bug by preventing the wrong ordering
        to occur in _buildRowsForPointsAndTestGroups by always inserting a root set A before B when B appears
        and A doesn't appear in the original graph.

        * public/v3/components/analysis-results-viewer.js:
        (AnalysisResultsViewer.prototype._collectRootSetsInTestGroups): Remember the succeeding root set B
        when creating an entry for root set A.
        (AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups): Fixed the bug. Also un-duplicated
        the code to create a new row.
        (AnalysisResultsViewer.RootSetInTestGroup): Now takes a succeeding root set. e.g. it's B for A and
        undefined for B in A/B testing.
        (AnalysisResultsViewer.RootSetInTestGroup.prototype.succeedingRootSet): Added.
        * public/v3/components/time-series-chart.js:
        (TimeSeriesChart.computeTimeGrid): Fixed the bug that we would end up showing 0 AM instead of dates
        when both dates and months change.

2016-03-18  Ryosuke Niwa  <rniwa@webkit.org>

        Add unit tests for measurement-set.js and measurement-adapter.js
        https://bugs.webkit.org/show_bug.cgi?id=155673

        Reviewed by Daniel Bates.

        Add tests which were supposed to be added in r198462.

        * unit-tests/measurement-adaptor-tests.js: Added.
        * unit-tests/measurement-set-tests.js: Added.
        (assert.notReached): Added.
        (global.RemoteAPI.getJSON): Added.
        (global.RemoteAPI.getJSONWithStatus): Added. A mock.

2016-03-18  Ryosuke Niwa  <rniwa@webkit.org>

        Add unit tests for measurement-set.js and measurement-adapter.js
        https://bugs.webkit.org/show_bug.cgi?id=155673

        Reviewed by Darin Adler.

        Added mocha unit tests for MeasurementSet and MeasurementAdapter classes along with the necessary
        refactoring to run these tests in node.

        getJSON and getJSONStatus are now under RemoteAPI so that unit tests can mock them.

        Removed the dependency on v2 UI's TimeSeries and Measurement class by adding a new implementation
        of TimeSeries in v3 and removing the dependency on Measurement in chart-pane-status-view.js with
        new helper methods on Build and CommitLog.

        Many js files now use 'use strict' (node doesn't support class syntax in non-strict mode) and
        module.exports to export symbols in node's require function.

        * public/v3/index.html:
        * public/v3/main.js:
        * public/v3/models/analysis-results.js:
        (AnalysisResults.fetch):
        * public/v3/models/analysis-task.js:
        (AnalysisTask.fetchAll):
        * public/v3/models/builder.js:
        (Build):
        (Build.prototype.builder): Added. Used by ChartPaneStatusView.
        (Build.prototype.buildNumber): Ditto.
        (Build.prototype.buildTime): Ditto.
        * public/v3/models/commit-log.js:
        (CommitLog.prototype.diff): Ditto.
        (CommitLog.fetchBetweenRevisions):
        * public/v3/models/data-model.js:
        (DataModelObject.cachedFetch):
        * public/v3/models/measurement-adaptor.js:
        (MeasurementAdaptor.prototype.applyToAnalysisResults): Renamed from adoptToAnalysisResults.
        (MeasurementAdaptor.prototype.applyTo): Renamed from adoptToSeries. Now shares a lot more
        code with applyToAnalysisResults. The code to set 'series' and 'seriesIndex' has been moved
        to TimeSeries.append. 'measurement' is no longer needed as this patch removes its only use
        in ChartPaneStatusView.
        * public/v3/models/measurement-cluster.js:
        (MeasurementCluster.prototype.addToSeries): Use TimeSeries.append instead of directly mutating
        series._series.
        * public/v3/models/measurement-set.js:
        (Array.prototype.includes): Added a polyfill for node.
        (MeasurementSet.prototype._fetchSecondaryClusters): Removed a bogus assertion. When fetchBetween
        is called with a mixture of clusters that have been fetched and not fetched, this assertion fails.
        (MeasurementSet.prototype._fetch):
        (TimeSeries.prototype.findById): Moved to time-series.js.
        (TimeSeries.prototype.dataBetweenPoints): Ditto.
        (TimeSeries.prototype.firstPoint): Ditto.
        (TimeSeries.prototype.fetchedTimeSeries): Moved the code to extend the last point to TimeSeries'
        extendToFuture.
        * public/v3/models/repository.js:
        * public/v3/models/root-set.js:
        (MeasurementRootSet): Ignore repositories that had not been defined (e.g. it could be added after
        manifest.json had been downloaded but before a given root set is created for an A/B testing).
        * public/v3/models/time-series.js:
        (TimeSeries): Added.
        (TimeSeries.prototype.append): Added.
        (TimeSeries.prototype.extendToFuture): Added.
        (TimeSeries.prototype.firstPoint): Moved from measurement-set.js.
        (TimeSeries.prototype.lastPoint): Added.
        (TimeSeries.prototype.previousPoint): Added.
        (TimeSeries.prototype.nextPoint): Added.
        (TimeSeries.prototype.findPointByIndex): Added.
        (TimeSeries.prototype.findById): Moved from measurement-set.js.
        (TimeSeries.prototype.findPointAfterTime): Added.
        (TimeSeries.prototype.dataBetweenPoints): Moved from measurement-set.js.
        * public/v3/pages/chart-pane-status-view.js:
        (ChartPaneStatusView.prototype.render): Use newly added helper functions on Build.
        (ChartPaneStatusView.prototype._formatTime): Added.
        (ChartPaneStatusView.prototype.setCurrentRepository):
        (ChartPaneStatusView.prototype.computeChartStatusLabels): Rewrote the code using RootSet object on
        currentPoint and previousPoint instead of Measurement class from v2 UI. Also sort the results using
        sortByNamePreferringOnesWithURL.
        * public/v3/remote.js:
        (RemoteAPI.getJSON): Moved under RemoteAPI.
        (RemoteAPI.getJSONWithStatus): Ditto.
        (PrivilegedAPI):
        (PrivilegedAPI.requestCSRFToken):

2016-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Add unit tests for config.json and statistics.js
        https://bugs.webkit.org/show_bug.cgi?id=155626

        Reviewed by Darin Adler.

        Added mocha unit tests for statistics.js and validating config.json. For segmentations, I've extracted
        real data from our internal perf dashboard.

        Also fixed some bugs covered by these new tests.

        * public/shared/statistics.js:
        (Statistics.movingAverage): Fixed a bug that forwardWindowSize was never used.
        (Statistics.exponentialMovingAverage): Fixed the bug that the moving average starts at 0. It should
        start at the first value instead.
        (.splitIntoSegmentsUntilGoodEnough): Fixed the bug that we may try to segment a time series into
        more parts than there are data points. Clearly, that doesn't make any sense.
        (.findOptimalSegmentation): Renamed local variables so that they're more descriptive, and rewrote
        the debugging code was the old code was emitting some useless data. Also fixed the bug that the length
        of "segmentation" was off by one (we need segmentCount + 1 elements in the array sine we always
        include the start of the first segment = 0 and the end of the last segment = values.length).
        (.SampleVarianceUpperTriangularMatrix):
        (Statistics): Modernized the export code.
        * tools/js: Added.
        * tools/js/config.js: Added.
        (Config): Added.
        (Config.prototype.configFilePath): Added.
        (Config.prototype.value): Added.
        (Config.prototype.path): Added.
        * tools/js/database.js: Added.
        (Database): Added.
        (Database.prototype.connect): Added.
        (Database.prototype.disconnect): Added.
        * unit-tests: Added.
        * unit-tests/checkconfig.js: Added. Validates config.json. This is useful while setting up
        a local instance of the perf dashboard.
        * unit-tests/statistics-tests.js: Added.
        (assert.almostEqual): Added. Asserts that two floating values are within a given significant digits.
        (.stdev):
        (.delta):
        (.computeWelchsT):

2016-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Fix a typo which was supposed to be fixed in r198351.

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage.prototype.render):

2016-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        An analysis task should be closed if a progression cause is identified
        https://bugs.webkit.org/show_bug.cgi?id=155549

        Reviewed by Chris Dumez.

        Since a progression is desirable, we should close an analysis task once its cause is identified.

        Also fix some typos.

        * init-database.sql: Fixed a typo.
        * public/api/analysis-tasks.php:
        * public/v3/models/analysis-task.js:
        (AnalysisTask.prototype.dissociateBug): Renamed from dissociateBug.
        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage.prototype.render):
        (AnalysisTaskPage.prototype._dissociateBug): Renamed from _dissociateBug.
        (AnalysisTaskPage.prototype._dissociateCommit): Fixed the typo in the alert.

2016-03-16  Ryosuke Niwa  <rniwa@webkit.org>

        Analysis task page should allow specifying commits that caused or fixed a regression or a progression
        https://bugs.webkit.org/show_bug.cgi?id=155529

        Reviewed by Chris Dumez.

        Added the capability to associate revisions that caused or fixed a progression or a regression for which
        an analysis task was created. Added task_commits that stores this relationship and added the backend
        support to retrieve this table in /api/analysis-tasks and an privileged API to update this table at
        /privileged-api/associate-commit.

        Also extracted a new component, MutableListView, out of AnalysisTaskPage to render and manipulate a list
        of mutable items, and used it to render the list of associated bugs and commits. The view takes a list of
        kinds (e.g. repositories or bug trackers), and accepts a pair of a kind and arbitrary text as a new item
        value.

        * init-database.sql: Added task_commits table.

        * public/api/analysis-tasks.php:
        (main):
        (fetch_associated_data_for_tasks): Renamed from fetch_and_push_bugs_to_tasks now that it also fetches
        the list of commits associated with each analysis task by calling CommitLogFetcher::fetch_for_tasks.
        Also fixe the bug that we were not taking 
        (format_task): No longer sets 'category' since the computation of category now depends on the list of
        commits associated with this analysis task which aren't available until fetch_associated_data_for_tasks.
        (determine_category): Added. Categorize any analysis tasks with "fixes" commits as "closed" and "causes"
        commits as "identified".

        * public/include/commit-log-fetcher.php:
        (CommitLogFetcher::__construct): Remove the unused instance variable.
        (CommitLogFetcher::fetch_for_tasks): Added. Fetches all commits associated with a list of analysis tasks.
        Assumes the caller (fetch_associated_data_for_tasks) had setup "fixes" and "causes" fields on each task.

        * public/privileged-api/associate-commit.php: Added. Updates task_commits table to associate or disassociate
        a commit with an analysis task. When the specified analysis task and the specified commit are already
        associated, we simply update the table instead of adding a duplicating entry or error. For dissociation,
        the front-end specifies the commit ID.
        (main): Added.

        * public/v3/index.html:
        * public/v3/components/mutable-list-view.js: Added. Used by the list associated bugs and commits.
        (MutableListView): Added.
        (MutableListView.prototype.setList): Added.
        (MutableListView.prototype.setKindList): Added.
        (MutableListView.prototype.setAddCallback): Added. This callback is invoked when the user tries to add
        a new item to the list.
        (MutableListView.prototype.render): Added.
        (MutableListView.prototype._submitted): Added.
        (MutableListView.cssTemplate):
        (MutableListView.htmlTemplate):
        (MutableListItem): Added. RemovalLink could be a hyperlink or a callback and gets involved when the user
        tries to delete this item.
        (MutableListItem.prototype.content):

        * public/v3/models/analysis-task.js:
        (AnalysisTask): Added the support of the list of commits that fixed and caused changes.
        (AnalysisTask.prototype.updateSingleton): Ditto.
        (AnalysisTask.prototype.causes): Added.
        (AnalysisTask.prototype.fixes): Added.
        (AnalysisTask.prototype.associateCommit): Added. Use the API added at /privileged-api/associate-commit
        to associate a new commit with this analysis task. Each commit has either caused or fixed the change.
        (AnalysisTask.prototype.dissociateCommit): Added. Use the same API to disassociate each commit.
        (AnalysisTask._constructAnalysisTasksFromRawData): Find all commits associated with each analysis task.
        Because commit log objects use a fake ID fdue to /api/measurement-set not providing commit IDs, we must
        use CommitLog.findByRemoteId to find each commit instead of usual CommitLog.findById.
        (AnalysisTask._constructAnalysisTasksFromRawData.resolveCommits): Added.

        * public/v3/models/build-request.js:
        (BuildRequest.prototype.hasFinished): Renamed from hasCompleted since it was confusing for this._status
        being "completed" wasn't a necessary condition for this function to return true.

        * public/v3/models/commit-log.js:
        (CommitLog): Added the static map for actual commit ID instead of a fake ID created in ensureSingleton.
        (CommitLog.prototype.remoteId): Added. Returns the real commit ID.
        (CommitLog.findByRemoteId): Added. Finds an CommitLog object using the real ID.

        * public/v3/models/test-group.js:
        (TestGroup.prototype.hasFinished): Renamed from hasCompleted to match the rename in BuildRequest.

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage): Added lists for the commits that fixed and caused the change using MutableListView.
        Also adopted MutableListView for the list of associated bugs.
        (AnalysisTaskPage.prototype.render): Added the code to populate the newly added lists.
        (AnalysisTaskPage.prototype._makeCommitListItem): Added.
        (AnalysisTaskPage.prototype._associateBug): Now this is a callback from MutableListView.
        (AnalysisTaskPage.prototype._associateCommit): Added.
        (AnalysisTaskPage.prototype._dissociateCommit): Added.
        (AnalysisTaskPage.htmlTemplate):
        (AnalysisTaskPage.cssTemplate):

        * public/v3/remote.js:
        (getJSON): Spit out the entire responseText when JSON failed to parse to make debugging easier.

2016-03-15  Ryosuke Niwa  <rniwa@webkit.org>

        Extract the code to format commit logs into its own PHP file
        https://bugs.webkit.org/show_bug.cgi?id=155514

        Rubber-stamped by Chris Dumez.

        Extracted CommitLogFetcher out of /api/commits so that it could be used in analysis-tasks.php
        in the future to support associating cause/fix for each analysis task.

        * public/api/commits.php:
        * public/include/commit-log-fetcher.php: Added.
        (CommitLogFetcher)
        (CommitLogFetcher::__construct): Added.
        (CommitLogFetcher::repository_id_from_name): Added.
        (CommitLogFetcher::fetch_between): Added.
        (CommitLogFetcher::fetch_oldest): Added.
        (CommitLogFetcher::fetch_latest): Added.
        (CommitLogFetcher::fetch_last_reported): Added.
        (CommitLogFetcher::fetch_revision): Added.
        (CommitLogFetcher::commit_for_revision): Added.
        (CommitLogFetcher::format_single_commit): Added.
        (CommitLogFetcher::format_commit): Added.

2016-03-09  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r196870.

        * public/include/report-processor.php:

2016-03-09  Ryosuke Niwa  <rniwa@webkit.org>

        Add Size metric to perf dashboard
        https://bugs.webkit.org/show_bug.cgi?id=155266

        Reviewed by Chris Dumez.

        Added the "Size" metric and use bytes as its unit.

        * public/js/helper-classes.js:
        (PerfTestRuns):
        * public/v2/data.js:
        (RunsData.unitFromMetricName):

2016-02-20  Ryosuke Niwa  <rniwa@webkit.org>

        Add the support for universal slave password
        https://bugs.webkit.org/show_bug.cgi?id=154476

        Reviewed by David Kilzer.

        Added the support for universalSlavePassword.

        * config.json:
        * public/include/report-processor.php:
        (ReportProcessor::process):
        (ReportProcessor::authenticate_and_construct_build_data): Extracted from process().

2016-02-19  Ryosuke Niwa  <rniwa@webkit.org>

        Analysis tasks page complains about missing repository but with a wrong name
        https://bugs.webkit.org/show_bug.cgi?id=154468

        Reviewed by Chris Dumez.

        Fixed the bug by using the right variable in the template literal.

        * public/v3/components/customizable-test-group-form.js:
        (CustomizableTestGroupForm.prototype._computeRootSetMap): Use querySelector here since Chrome doesn't have
        getElementsByClassName on ShadowRoot.
        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage.prototype._createTestGroupAfterVerifyingRootSetList): Use name which is the name of
        repository here.

2016-02-18  Ryosuke Niwa  <rniwa@webkit.org>

        Revert an unintended change made in the previous commit.

        * init-database.sql:

2016-02-18  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should let user cancel pending A/B testing and hide failed ones
        https://bugs.webkit.org/show_bug.cgi?id=154433

        Reviewed by Chris Dumez.

        Added a button to hide a test group in the details view (the bottom table) in the analysis task page, and
        "Show hidden tests" link to show the hidden test groups on demand. When a test group is hidden, all pending
        requests in the group will also be canceled since a common scenario of using this feature is that the user
        had triggered an useless A/B testing; e.g. all builds will fail, wrong, etc... We can revisit and add the
        capability to just cancel the pending requests and leaving the group visible later if necessary.

        Run `ALTER TYPE build_request_status_type ADD VALUE 'canceled';` to add the new type.

        * init-database.sql: Added testgroup_hidden column to analysis_test_groups table and added 'canceled'
        as a value to build_request_status_type table.
        * public/api/test-groups.php:
        (format_test_group): Added 'hidden' field in the JSON result.
        * public/privileged-api/update-test-group.php:
        (main): Added the support for updating testgroup_hidden column. When this column is set to true, also
        cancel all pending build requests (by setting its request_status to 'canceled' which will be ignore by
        the syncing script).
        * public/v3/components/test-group-results-table.js:
        (TestGroupResultsTable.prototype.setTestGroup): Reset _renderedTestGroup here so that the next call to
        render() will update the table; e.g. when build requests' status change from 'Pending' to 'Canceled'.
        * public/v3/models/build-request.js:
        (BuildRequest.prototype.hasCompleted): A build request is considered complete/finished if it's canceled.
        (BuildRequest.prototype.hasPending): Added.
        (BuildRequest.prototype.statusLabel): Handle 'canceled' status.
        * public/v3/models/test-group.js:
        (TestGroup):
        (TestGroup.prototype.updateSingleton): Added to update 'hidden' field.
        (TestGroup.prototype.isHidden): Added.
        (TestGroup.prototype.hasPending): Added.
        (TestGroup.prototype.hasPending): Added.
        (TestGroup.prototype.updateHiddenFlag): Added. Uses the privileged API to update testgroup_hidden column.
        The JSON API also updates the status of the 'pending' build requests in the group to 'canceled'.
        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage): Added _showHiddenTestGroups and _filteredTestGroups as instance variables.
        (AnalysisTaskPage.prototype._didFetchTestGroups):
        (AnalysisTaskPage.prototype._showAllTestGroups): Added.
        (AnalysisTaskPage.prototype._didUpdateTestGroupHiddenState): Extracted from _didFetchTestGroups.
        (AnalysisTaskPage.prototype._renderTestGroupList): Use the filtered list of test groups to show the list
        of test groups. When all test groups are shown, we would first show the hidden ones after the regular ones.
        (AnalysisTaskPage.prototype._createTestGroupListItem): Extracted from _renderTestGroupList.
        (AnalysisTaskPage.prototype._renderTestGroupDetails): Update the text inside the button to hide the test
        group. Also show a warning text that the pending requests will be canceled if there are any.
        (AnalysisTaskPage.prototype._hideCurrentTestGroup): Added.
        (AnalysisTaskPage.cssTemplate): Updated the style.

2016-02-18  Ryosuke Niwa  <rniwa@webkit.org>

        The rows in the analysis results table should be expandable
        https://bugs.webkit.org/show_bug.cgi?id=154427

        Reviewed by Chris Dumez.

        Added "(Expand)" link between rows that have hidden points. Upon click it inserts the hidden rows.

        We insert around five rows at a time when there are hundreds of hidden points but we also avoid leaving
        behind expandable rows of less than two rows.

        Also fixed a bug in CustomizableTestGroupForm that getElementsById would throw in the shipping Safari
        because getElementsById doesn't exist on Element.prototype by using class name instead.

        * public/v3/components/analysis-results-viewer.js:
        (AnalysisResultsViewer):
        (AnalysisResultsViewer.prototype.setCurrentTestGroup): Removed superfluous call to render().
        (AnalysisResultsViewer.prototype.setPoints): Always show the start and the end points.
        (AnalysisResultsViewer.prototype.buildRowGroups):
        (AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups): Add an instance of ExpandableRow which
        shows a "(Expand)" link to show hidden rows here.
        (AnalysisResultsViewer.prototype._expandBetween): Added. Expands rows between two points.
        (AnalysisResultsViewer.cssTemplate): Added rules for "(Expand)" links.
        (AnalysisResultsViewer.ExpandableRow): Added.
        (AnalysisResultsViewer.ExpandableRow.prototype.resultContent): Added. Overrides what's in the results column.
        (AnalysisResultsViewer.ExpandableRow.prototype.heading): Added. Generates "(Expand)" link.

        * public/v3/components/customizable-test-group-form.js:
        (CustomizableTestGroupForm.prototype._computeRootSetMap): Use getElementsByClassName instead of
        getElementById.
        (CustomizableTestGroupForm.prototype._classForLabelAndRepository): Renamed from _idForLabelAndRepository.
        (CustomizableTestGroupForm._constructRevisionRadioButtons): Set class name instead of id.

        * public/v3/components/results-table.js:
        (ResultsTable.prototype.render): Don't generate radio buttons to select a row when root set is missing;
        e.g. for rows that show "(Expand)" links.

2016-02-18  Ryosuke Niwa  <rniwa@webkit.org>

        Statistically significant A/B testing results should be color coded in details view
        https://bugs.webkit.org/show_bug.cgi?id=154414

        Reviewed by Chris Dumez.

        Color code the statistically significant comparisions in TestGroupResultsTable as done in the analysis
        results viewer.

        * public/v3/components/customizable-test-group-form.js:
        (CustomizableTestGroupForm.cssTemplate): Build fix after r196768.
        * public/v3/components/test-group-results-table.js:
        (TestGroupResultsTable.prototype.buildRowGroups): Add the status as a class name.
        (TestGroupResultsTable.cssTemplate): Added styles to color-code statistically significant results.

2016-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI should allow custom revisions for A/B testing
        https://bugs.webkit.org/show_bug.cgi?id=154379

        Reviewed by Chris Dumez.

        Added the capability to customize revisions selected in the overview chart and the results viewer.

        Newly added CustomizableTestGroupForm is responsible for allowing users to modify the set of revisions in
        a new A/B testing group. Unlike TestGroupForm which doesn't know anything about which revisions are selected
        for each project/repository, CustomizableTestGroupForm is aware of the list of revisions used in each set.

        The list of revisions used in each set is represented by RootSet if users had not customized them, and
        CustomRootSet otherwise; the latter was added since regular RootSet object requires CommitLog and other
        DataModelObjects which are hard to create without corresponding database entries.

        * public/v3/components/customizable-test-group-form.js: Added.
        (CustomizableTestGroupForm): Added.
        (CustomizableTestGroupForm.prototype.setRootSetMap): Added.
        (CustomizableTestGroupForm.prototype._submitted): Overrides the superclass' method.
        (CustomizableTestGroupForm.prototype._customize): Ditto. Unlike TestGroupForm's callback, this class'
        callback passes in a root set map as the third argument.
        (CustomizableTestGroupForm.prototype._computeRootSetMap): Added. Returns this._rootSetMap, which is set by
        AnalysisTaskPage if user had not customized the root sets. Otherwise return a new map with CustomRootSet's.
        (CustomizableTestGroupForm.prototype.render): Added. Creates a table to allow customization of root sets.
        (CustomizableTestGroupForm._constructRevisionRadioButtons): Added.
        (CustomizableTestGroupForm._createRadioButton): Added.
        (CustomizableTestGroupForm.cssTemplate): Added.
        (CustomizableTestGroupForm.formContent): Added. This method is called by TestGroupForm.htmlTemplate.
        * public/v3/components/test-group-form.js:
        (TestGroupForm): Updated the various methods to not directly mutate DOM. Store the state in instance
        variables and update DOM in render() as done elsewhere.
        (TestGroupForm.prototype.setNeedsName): Deleted. We no longer need this flag since TestGroupForm which is
        used for retries never needs a name and CustomizableTestGroupForm which is used to create a new test group
        always requires a name.
        (TestGroupForm.prototype.setDisabled):
        (TestGroupForm.prototype.setLabel):
        (TestGroupForm.prototype.setRepetitionCount):
        (TestGroupForm.prototype.render): Added.
        (TestGroupForm.prototype._submitted): Moved the code to prevent the default action has been moved to the
        constructor since this method is overridden by CustomizableTestGroupForm.
        (TestGroupForm.cssTemplate): Added.
        (TestGroupForm.htmlTemplate):
        (TestGroupForm.formContent): Extracted from htmlTemplate.
        * public/v3/index.html:
        * public/v3/models/repository.js:
        (Repository.sortByNamePreferringOnesWithURL): Added.
        * public/v3/models/root-set.js:
        (RootSet.prototype.revisionForRepository): Added so that _createTestGroupAfterVerifyingRootSetList can retrieve
        the revision information from CustomRootSet without going through CommitLog objects since CustomRootSet doesn't
        have associated CommitLog objects.
        (CustomRootSet): Added. Used by CustomizableTestGroupForm to create a custom root map since regular RootSet
        requires CommitLog and other related objects which are hard to create without database entries.
        (CustomRootSet.prototype.setRevisionForRepository): Added.
        (CustomRootSet.prototype.repositories): Added.
        (CustomRootSet.prototype.revisionForRepository): Added.
        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage):
        (AnalysisTaskPage.prototype.render): Removed the reference to v2 UI since v3 UI is now strictly more powerful
        than v2 UI. Also update the root set maps in each form here.
        (AnalysisTaskPage.prototype._retryCurrentTestGroup): No longer takes unused name argument as it got removed
        from TestGroupForm.
        (AnalysisTaskPage.prototype._chartSelectionDidChange): No longer updates the disabled-ness here since it's now
        done in render() via setRootSetMap().
        (AnalysisTaskPage.prototype._createNewTestGroupFromChart): Now takes rootSetMap as an argument.
        (AnalysisTaskPage.prototype._selectedRowInAnalysisResultsViewer): No longer updates the disabled-ness here
        since it's now done in render() via setRootSetMap().
        (AnalysisTaskPage.prototype._createNewTestGroupFromViewer): Now takes rootSetMap as an argument.
        (AnalysisTaskPage.prototype._createTestGroupAfterVerifyingRootSetList): Take a dictionary of root set labels
        such as A and B, which maps to a RootSet or a newly-added CustomRootSet.
        (AnalysisTaskPage.htmlTemplate): Use customizable-test-group-form for creating a new A/B testing group. Retry
        form will continue to use TestGroupForm since customizing revisions is non-sensical in retries.
        (AnalysisTaskPage.cssTemplate): Updated the style.

2016-02-16  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI has the capability to schedule an A/B testing in a specific range
        https://bugs.webkit.org/show_bug.cgi?id=154329

        Reviewed by Chris Dumez.

        Extended AnalysisTaskChartPane and ResultsTable so that users can select a range of points in either
        the overview chart pane and the results viewer table. Extracted TestGroupForm out of the analysis task
        page and used right below those two components in the analysis task page.

        * public/v3/components/results-table.js:
        (ResultsTable):
        (ResultsTable.prototype.setRangeSelectorLabels): Added.
        (ResultsTable.prototype.setRangeSelectorCallback): Added.
        (ResultsTable.prototype.selectedRange): Added.
        (ResultsTable.prototype._rangeSelectorClicked): Added.
        (ResultsTable.prototype.render): Generate radio boxes to select a range.

        * public/v3/components/test-group-form.js:
        (TestGroupForm):
        (TestGroupForm.prototype.setStartCallback): Added.
        (TestGroupForm.prototype.setNeedsName): Added.
        (TestGroupForm.prototype.setDisabled): Added.
        (TestGroupForm.prototype.setLabel): Added.
        (TestGroupForm.prototype.setRepetitionCount): Added.
        (TestGroupForm.prototype._submitted): Added.
        (TestGroupForm.htmlTemplate): Extracted from AnalysisTaskPage.htmlTemplate.

        * public/v3/index.html:

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskChartPane.prototype._mainSelectionDidChange): Added. Delegates the work to AnalysisTaskPage.
        (AnalysisTaskChartPane.prototype.selectedPoints): Added.
        (AnalysisTaskPage):
        (AnalysisTaskPage.prototype.title):
        (AnalysisTaskPage.prototype.render):
        (AnalysisTaskPage.prototype._renderTestGroupDetails): Use TestGroupForm's methods instead of mutating DOM. 
        (AnalysisTaskPage.prototype._retryCurrentTestGroup):
        (AnalysisTaskPage.prototype._chartSelectionDidChange): Added.
        (AnalysisTaskPage.prototype._createNewTestGroupFromChart): Added.
        (AnalysisTaskPage.prototype._selectedRowInAnalysisResultsViewer): Added.
        (AnalysisTaskPage.prototype._createNewTestGroupFromViewer): Added.
        (AnalysisTaskPage.prototype._createRetryNameForTestGroup):
        (AnalysisTaskPage.prototype._createTestGroupAfterVerifyingRootSetList): Extracted from _retryCurrentTestGroup
        so that we can call it in _createNewTestGroupFromChart and _createNewTestGroupFromViewer.
        (AnalysisTaskPage.htmlTemplate):

2016-02-15  Ryosuke Niwa  <rniwa@webkit.org>

        Extract the code specific to v2 UI out of shared statistics.js
        https://bugs.webkit.org/show_bug.cgi?id=154277

        Reviewed by Chris Dumez.

        Extracted statistics-strategies.js out of statistics.js for v2 UI and detect-changes.js. The intent is to
        deprecate this file once we implement refined statistics tools in v3 UI and adopt it in detect-changes.js.

        * public/shared/statistics.js:
        (Statistics.movingAverage): Extracted from the "Simple Moving Average" strategy.
        (Statistics.cumultaiveMovingAverage): Extracted from the "Cumulative Moving Average" strategy.
        (Statistics.exponentialMovingAverage): Extracted from the "Exponential Moving Average" strategy.
        Use a temporary "movingAverage" to keep the last moving average instead of relying on the previous
        entry in "averages" array to avoid special casing an array of length 1 and starting the loop at i = 1.
        (Statistics.segmentTimeSeriesGreedyWithStudentsTTest): Extracted from "Segmentation: Recursive t-test"
        strategy. Don't create the list of averages to match segmentTimeSeriesByMaximizingSchwarzCriterion here.
        It's done in newly added averagesFromSegments.
        (Statistics.segmentTimeSeriesByMaximizingSchwarzCriterion): Extracted from
        "Segmentation: Schwarz criterion" strategy.
        (.recursivelySplitIntoTwoSegmentsAtMaxTIfSignificantlyDifferent): Just store the start index to match
        * public/v2/app.js:
        (App.Pane.updateStatisticsTools):
        (App.Pane._computeMovingAverageAndOutliers):
        * public/v2/data.js:
        * public/v2/index.html:
        * public/v2/statistics-strategies.js: Added.
        (StatisticsStrategies.MovingAverageStrategies): Added.
        (averagesFromSegments): Extracted from "Segmentation: Schwarz criterion" strategy. Now used by both
        "Segmentation: Recursive t-test" and "Segmentation: Schwarz criterion" strategies.
        (StatisticsStrategies.EnvelopingStrategies): Moved from Statistics.EnvelopingStrategies.
        (StatisticsStrategies.TestRangeSelectionStrategies): Moved from Statistics.TestRangeSelectionStrategies.
        (createWesternElectricRule): Moved from statistics.js.
        (countValuesOnSameSide): Ditto.
        (StatisticsStrategies.executeStrategy): Moved from Statistics.executeStrategy.
        * tools/detect-changes.js:
        (computeRangesForTesting):

2016-02-15  Ryosuke Niwa  <rniwa@webkit.org>

        v1 UI and v2 UI should share statistics.js
        https://bugs.webkit.org/show_bug.cgi?id=154262

        Reviewed by Chris Dumez.

        Share statistics.js between v1 and v2 UI.

        * public/index.html:
        * public/js/shared.js: Deleted.
        * public/js/statistics.js: Removed.
        * public/shared: Added.
        * public/shared/statistics.js: Moved from Websites/perf.webkit.org/public/v2/js/statistics.js.
        * public/v2/index.html:
        * public/v2/js/statistics.js: Removed.
        * public/v3/index.html:
        * tools/detect-changes.js:

2016-02-13  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI sometimes shows same dates twice on the x-axis of time series charts
        https://bugs.webkit.org/show_bug.cgi?id=154210

        Reviewed by Chris Dumez.

        The bug was caused by the label generation code in TimeSeriesChart.computeTimeGrid never emitting hours.

        Use hours instead of dates as labels when the current time's date is same as the previous label's date.
        Always include dates before entering this mode to avoid just having hours as labels on the entire x-axis.

        * public/v3/components/time-series-chart.js:
        (TimeSeriesChart.prototype._renderXAxis): Slightly increase the "average" width of x-axis label.
        (TimeSeriesChart.computeTimeGrid): See above. Also assert that the number of labels we generate never
        exceeds maxLabels as a sanity check.
        (TimeSeriesChart._timeIterators): Added an iterator that increments by two hours for zoomed graphs.

2016-02-13  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI should show status and associated bugs on analysis task pages
        https://bugs.webkit.org/show_bug.cgi?id=154212

        Reviewed by Chris Dumez.

        Added the capability to see and modify the status and the list of associated of bugs on analysis task pages.

        Also added the list of related tasks, which are analysis tasks associated with the same bug or have
        overlapping time ranges with the same test metric but on a potentially different platform.

        In addition, categorize analysis tasks with the status of "no change" or "inconclusive" as "closed" as no
        further action can be taken (users can bring them back to non-closed state without any restrictions).

        * public/api/analysis-tasks.php:
        (format_task): Categorize 'unchanged' and 'inconclusive' analysis tasks as closed.

        * public/privileged-api/associate-bug.php:
        (main): Added shouldDelete as a new mechanism to disassociate a bug since v3 UI shares a single Bug object
        between multiple analysis tasks (as it should have been in the first place).

        * public/v3/components/chart-pane-base.js:
        (ChartPaneBase):
        (ChartPaneBase.prototype._fetchAnalysisTasks): Since each analysis task's change type (status/result) could
        change, we need to create annotation objects during each render() call.
        (ChartPaneBase.prototype.render):
        (ChartPaneBase.prototype._renderAnnotations): Extracted from ChartPaneBase.prototype._fetchAnalysisTasks to
        do that. I was afraid of the perf impact of this but it doesn't seem to be an issue in my testing.
        (ChartPaneBase.cssTemplate): Removed superfluous margins (moved to ChartPane.cssTemplate) around the charts
        since they are only useful in the charts page.

        * public/v3/models/analysis-task.js:
        (AnalysisTask):
        (AnalysisTask.prototype.updateSingleton): Added a comment as to why object.result cannot be renamed to
        object.changeType in the JSON API.
        (AnalysisTask.prototype.updateName): Added.
        (AnalysisTask.prototype.updateChangeType): Added.
        (AnalysisTask.prototype._updateRemoteState): Added.
        (AnalysisTask.prototype.associateBug): Added.
        (AnalysisTask.prototype.disassociateBug): Added.
        (AnalysisTask.fetchRelatedTasks): Added. See above for the criteria of related-ness.

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage):
        (AnalysisTaskPage.prototype.updateFromSerializedState):
        (AnalysisTaskPage.prototype._fetchRelatedInfoForTaskId): Extracted from updateFromSerializedState.
        (AnalysisTaskPage.prototype._didFetchRelatedAnalysisTasks): Added.
        (AnalysisTaskPage.prototype.render): Render the list of associated bugs, the list of bug trackers (so that
        users can use it to associate with a new bug), and the list of related analysis tasks.
        (AnalysisTaskPage.prototype._renderTestGroupList): Extracted from render since it was getting too long.
        (AnalysisTaskPage.prototype._renderTestGroupDetails): Ditto.
        (AnalysisTaskPage.prototype._updateChangeType): Added.
        (AnalysisTaskPage.prototype._associateBug): Added.
        (AnalysisTaskPage.prototype._disassociateBug): Added.
        (AnalysisTaskPage.htmlTemplate): Added various elements to show and modify the status, associate bugs,
        and a list of related analysis tasks.
        (AnalysisTaskPage.cssTemplate): Added various styles for those form controls.

        * public/v3/pages/chart-pane.js:
        (ChartPane.cssTemplate): Moved the margins from ChartPaneBase.cssTemplate.

2016-02-12  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should allow renaming analysis tasks and test groups
        https://bugs.webkit.org/show_bug.cgi?id=154200

        Reviewed by Chris Dumez.

        Allow editing names of analysis tasks and A/B testing groups in the v3 UI.

        Added the support for updating the name to the privileged API at /privileged-api/update-analysis-task
        and added a new prevailed API to update A/B testing groups at /privileged-api/update-test-group.

        * public/privileged-api/update-analysis-task.php: Added the support for renaming the analysis task.
        (main):

        * public/privileged-api/update-test-group.php: Added. Supports updating the test group's name.
        (main):

        * public/v3/components/editable-text.js: Added.
        (EditableText): Added. A new editable text label control. It looks like a text node with "(Edit)" link
        at the end which allow users to go into the "editing mode", which reveals an input element.
        The user can exit the editing mode by either moving the focus away from the control or clicking on
        "(Save)" at the end. It calls _updateCallback in the latter case.
        (EditableText.prototype.editedText): Returns the current value of the input element user.
        (EditableText.prototype.setText): Sets the label. This does not live-update the input element until
        the user exists the current editing mode and re-enters it.
        (EditableText.prototype.setStartedEditingCallback): Sets a callback which gets called when the user
        requested to enter the editing mode. Since EditableText relies on AnalysisTaskPage to render, this
        callback only exits to call EditableText.render() in AnalysisTask._didStartEditingTaskName.
        (EditableText.prototype.setUpdateCallback): Sets a callback which gets called when the user exits
        the editing mode by activating the "(Save)" link. This callback MUST return a promise upon resolution
        of which the control gets out of the editing mode. While the promise is in flight, the input element
        becomes readonly.
        (EditableText.prototype.render): Updates various states of the elements. When _updatingPromise is not
        falsy, we make the input element readonly and show '(...)' on the link. Don't show the action link
        if the label is empty (e.g. analysis task or test group is still being fetched).
        (EditableText.prototype._didClick): Called when the user clicked on the action link. Enter the editing
        mode or save the edited label via _updateCallback.
        (EditableText.prototype._didBlur): Exit the editing mode without saving if the input element is not
        focused, there is no inflight promise returned by _updateCallback, and the action link "(Save)" does
        not have the focus.
        (EditableText.prototype._didUpdate): Called when exiting the editing mode.
        (EditableText.htmlTemplate):
        (EditableText.cssTemplate):

        * public/v3/index.html: Include newly added editable-text.js.

        * public/v3/models/analysis-task.js:
        (AnalysisTask.prototype.updateSingleton): Added.
        (AnalysisTask.prototype.updateName): Added. Uses PrivilegedAPI to update the name and re-fetches
        the analysis task from the sever.
        (AnalysisTask._constructAnalysisTasksFromRawData): Use ensureSingleton instead of manually calling
        findById since we need to update the name of the singleton object we found (via updateSingleton).

        * public/v3/models/bug.js:
        (Bug.ensureSingleton): Moved the code to compute the synthetic id from AnalysisTask's
        _constructAnalysisTasksFromRawData.
        (Bug.prototype.updateSingleton): Added. Just assert that nothing changes.

        * public/v3/models/build-request.js:
        (BuildRequest.prototype.updateSingleton): Added. Assert that the intrinsic values of a build request
        doesn't change and update status text, status url, and build id as they could change.

        * public/v3/models/commit-log.js:
        (CommitLog): Made the constructor argument conform to the convention of id, object pair so that we can
        use DataModelObject.ensureSingleton.
        (CommitLog.ensureSingleton): 
        (CommitLog.prototype.updateSingleton): Extracted from CommitLog.ensureSingleton.

        * public/v3/models/data-model.js:
        (DataModelObject.ensureSingleton): Call newly added updateSingleton.
        (DataModelObject.prototype.updateSingleton):
        (LabeledObject): Removed the name map since it's never used (findByName is never called anywhere).
        (LabeledObject.prototype.updateSingleton): Added. Updates _name.
        (LabeledObject.findByName): Deleted.

        * public/v3/models/test-group.js:
        (TestGroup.prototype.updateName): Added. Uses PrivilegedAPI to update the name and re-fetches
        the test group from the sever.
        (TestGroup._createModelsFromFetchedTestGroups): Removed bogus code. A root set doesn't have a test
        group associated with it since multiple test groups can share a single root set (this property doesn't
        even exist).

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage): Removed useless _taskId and added this._testGroupLabelMap and this._taskNameLabel.
        (AnalysisTaskPage.prototype.updateFromSerializedState): Cleanup.
        (AnalysisTaskPage.prototype._didFetchTask): Assert that this function is called exactly once.
        (AnalysisTaskPage.prototype.render): Use this._task.id() to show the v2 link. Use EditableText to show
        the names of the analysis task and the associated test groups. Hide the overview chart and the list of
        test groups (along with the retry/confirm button) when the analysis task failed to fetch. We always
        update the names of the analysis task and the associated test groups since they could be updated by
        the server.
        (AnalysisTaskPage.prototype._didStartEditingTaskName): Added.
        (AnalysisTaskPage.prototype._updateTaskName): Added.
        (AnalysisTaskPage.prototype._updateTestGroupName): Added.
        (AnalysisTaskPage.htmlTemplate): Updated the style.

2016-02-11  Ryosuke Niwa  <rniwa@webkit.org>

        Land the change that was supposed to be the part of r196463.

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage.prototype._didFetchTestGroups): Select the latest test group by default.

2016-02-11  Ryosuke Niwa  <rniwa@webkit.org>

        Refine v3 UI's analysis task page
        https://bugs.webkit.org/show_bug.cgi?id=154152

        Reviewed by Chris Dumez.

        This patch makes the following refinements to the analysis task page:
         - Always show the relative different of in-progress A/B testing.
         - Make the annotations (colored bars) in the chart open other analysis tasks.
         - Order the A/B testing groups in the reverse chronological order.
         - Select the time range corresponding to the current test group.

        * public/v3/components/analysis-results-viewer.js:
        (AnalysisResultsViewer.cssTemplate): Fixed the bug that pending and running testing groups are no longer
        colored after r196440. Use a slightly more opaque color for currently running groups compared to pending ones.

        * public/v3/components/chart-pane-base.js:
        (ChartPaneBase.prototype.setMainSelection): Added.
        (ChartPaneBase.prototype._openAnalysisTask): Moved the code from ChartPane._openAnalysisTask so that it can be
        reused in both AnalysisTaskChartPane and ChartPane (in charts page).
        (ChartPaneBase.prototype.router): Added. Overridden by each subclass.

        * public/v3/components/test-group-results-table.js:
        (TestGroupResultsTable.prototype.buildRowGroups): Always show the summary (relative difference of A to B) as
        long as there are some results in each set.

        * public/v3/models/test-group.js:
        (TestGroup.prototype.compareTestResults): Always set .label and .fullLabel with the relative change as long as
        there are some values. Keep using "pending" and "running" in .status since that would determine the color of
        stacking blocks representing those A/B testing groups. 

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskChartPane):
        (AnalysisTaskChartPane.prototype.setPage): Added.
        (AnalysisTaskChartPane.prototype.router): Added.
        (AnalysisTaskPage):
        (AnalysisTaskPage.prototype.render): Show the list of A/B testing groups in the reverse chronological order.
        Also set the main chart's selection to the time range of the current test group.

        * public/v3/pages/chart-pane.js:
        (ChartPane.prototype.router): Added.
        (ChartPane.prototype._openAnalysisTask): Moved to ChartPaneBase.prototype._openAnalysisTask.

2016-02-11  Ryosuke Niwa  <rniwa@webkit.org>

        Add a script to process backlogs created while perf dashboard was in the maintenance mode
        https://bugs.webkit.org/show_bug.cgi?id=154140

        Reviewed by Chris Dumez.

        Added a script to process the backlog JSONs created while the perf dashboard was put in the maintenance mode.
        It re-submits each JSON file to the perf dashboard using the same server config file used by syncing scripts.

        * public/include/report-processor.php:
        (TestRunsGenerator::test_value_list_to_values_by_iterations): Fixed a bug in the error message code. It was
        referencing an undeclared variable.
        * tools/process-maintenance-backlog.py: Added.

2016-02-11  Ryosuke Niwa  <rniwa@webkit.org>

        AnalysisResultsViewer never uses this._smallerIsBetter
        https://bugs.webkit.org/show_bug.cgi?id=154134

        Reviewed by Chris Dumez.

        Removed the unused instance variable _smallerIsBetter from AnalysisResultsViewer and TestGroupStackingBlock.

        * public/v3/components/analysis-results-viewer.js:
        (AnalysisResultsViewer): Removed the unused _smallerIsBetter.
        (AnalysisResultsViewer.prototype.setSmallerIsBetter): Deleted.
        (AnalysisResultsViewer.prototype.buildRowGroups):
        (AnalysisResultsViewer.TestGroupStackingBlock): Removed the unused _smallerIsBetter.
        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage.prototype._didFetchTask):

2016-02-11  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r196440.

        * public/v3/models/test-group.js:
        (TestGroup.prototype.addBuildRequest): Clear the map instead of setting the property to null.

2016-02-10  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should have UI to retry A/B testing
        https://bugs.webkit.org/show_bug.cgi?id=154090

        Reviewed by Chris Dumez.

        Added a button to re-try an existing A/B testing group with a custom repetition count. The same button functions
        as a way of confirming the progression/regression when there have been no A/B testing scheduled in the task.

        Also fixed the bug that A/B testing groups that have been waiting for other test groups will be shown as "running".

        * public/v3/components/results-table.js:
        (ResultsTable.cssTemplate): Don't pad the list of extra repositories when it's empty.

        * public/v3/components/test-group-results-table.js:
        (TestGroupResultsTable.prototype.buildRowGroups): Use TestGroup.labelForRootSet instead of manually
        computing the letter for each configuration set.

        * public/v3/models/build-request.js:
        (BuildRequest.prototype.hasStarted): Added.

        * public/v3/models/data-model.js:
        (DataModelObject.ensureSingleton): Added.
        (DataModelObject.cachedFetch): Added noCache option. This is used when re-fetching the test groups after
        creating one.

        * public/v3/models/measurement-cluster.js:
        (MeasurementCluster.prototype.startTime): Added.

        * public/v3/models/measurement-set.js:
        (MeasurementSet.prototype.hasFetchedRange): Added. Returns true only if there are no "holes" (cluster
        yet to be fetched) between the specified time range. This was added to fix a bug in AnalysisTaskPage's
        _didFetchMeasurement.

        * public/v3/models/test-group.js:
        (TestGroup): Added this._rootSetToLabel.
        (TestGroup.prototype.addBuildRequest): Reset this._rootSetToLabel along with this._requestedRootSets. 
        (TestGroup.prototype.repetitionCount): Added. Returns the number of iterations executed per set. We assume that
        every root set in the test group shares a single repetition count.
        (TestGroup.prototype.requestedRootSets): Now populates this._rootSetToLabel for labelForRootSet.
        (TestGroup.prototype.labelForRootSet): Added.
        (TestGroup.prototype.hasStarted): Added.
        (TestGroup.prototype.compareTestResults): Use 'running' and 'pending' to differentiate test groups that are waiting
        for other groups to finish running from the ones that are actually running ('incomplete' before this patch).
        (TestGroup.fetchByTask):
        (TestGroup.createAndRefetchTestGroups): Added. Creates a new test group using the privileged-api/create-test-group
        and fetches the list of test groups for the specified analysis task.
        (TestGroup._createModelsFromFetchedTestGroups): Extracted from TestGroup.fetchByTask.

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage): Initialize _renderedCurrentTestGroup to undefined so that we'd always can differentiate
        the initial call to AnalysisTaskPage.render and subsequent calls in which it's identical to _currentTestGroup.
        (AnalysisTaskPage.prototype._didFetchMeasurement): Fixed a bug that we don't exit early even when some
        clusters in between startPoint and endPoint are still being fetched via newly added hasFetchedRange.
        (AnalysisTaskPage.prototype.render): Update the default repetition count based on the current test group.
        Also update the label of the button to "Confirm the change" if there is no A/B testing in this task.
        (AnalysisTaskPage.prototype._retryCurrentTestGroup): Added. Re-triggers an existing A/B testing group or creates
        the A/B testing for the entire range of the analysis task.
        (AnalysisTaskPage.prototype._hasDuplicateTestGroupName): Added.
        (AnalysisTaskPage.prototype._createRetryNameForTestGroup): Added.
        (AnalysisTaskPage.htmlTemplate): Added form controls to re-trigger A/B testing.
        (AnalysisTaskPage.cssTemplate): Updated the style.

2016-02-10  Ryosuke Niwa  <rniwa@webkit.org>

        Removed the duplicated definition of ChartPaneBase.

        * public/v3/components/chart-pane-base.js:

2016-02-09  Ryosuke Niwa  <rniwa@webkit.org>

        Analysis task page on v3 UI should show charts
        https://bugs.webkit.org/show_bug.cgi?id=154057

        Reviewed by Chris Dumez.

        Extracted ChartPaneBase out of ChartPane and added an instance of its new subclass, AnalysisTaskChartPane,
        to the analysis task page. The main difference is that ChartPaneBase doesn't depend on the presence of
        this._chartsPage unlike ChartPane. It also doesn't have the header with toolbar (to show breakdown, etc...).

        * public/v3/components/base.js:
        (ComponentBase.prototype._constructShadowTree): Call htmlTemplate() and cssTemplate() with the right "this".

        * public/v3/components/chart-pane-base.js: Added.
        (ChartPaneBase): Extracted from ChartPane.
        (ChartPaneBase.prototype.configure): Extracted from the constructor. Separating this function allows the
        component to be instantiated inside a HTML template.
        (ChartPaneBase.prototype._fetchAnalysisTasks): Moved from ChartPane._fetchAnalysisTasks.
        (ChartPaneBase.prototype.platformId): Ditto.
        (ChartPaneBase.prototype.metricId): Ditto.
        (ChartPaneBase.prototype.setOverviewDomain): Ditto.
        (ChartPaneBase.prototype.setMainDomain): Ditto.
        (ChartPaneBase.prototype._overviewSelectionDidChange): Extracted from the constructor. This is overridden in
        ChartPane and unused in AnalysisTaskChartPane.
        (ChartPaneBase.prototype._mainSelectionDidChange): Extracted from ChartPane._mainSelectionDidChange.
        (ChartPaneBase.prototype._mainSelectionDidZoom): Extracted from ChartPane._mainSelectionDidZoom.
        (ChartPaneBase.prototype._indicatorDidChange): Extracted from ChartPane._indicatorDidChange.
        (ChartPaneBase.prototype._didFetchData): Moved from ChartPane._fetchAnalysisTasks.
        (ChartPaneBase.prototype._openAnalysisTask): Ditto.
        (ChartPaneBase.prototype._openCommitViewer): Ditto. Also fixed a bug that we don't show the spinner while
        waiting for the data to be fetched by calling this.render() here.
        (ChartPaneBase.prototype._keyup): Moved from ChartPane._keyup. Also fixed the bug that the revisions list
        doesn't update by calling this.render() here.
        (ChartPaneBase.prototype.render): Extracted from ChartPane.render.
        (ChartPaneBase.htmlTemplate): Extracted from ChartPane.htmlTemplate.
        (ChartPaneBase.paneHeaderTemplate): Added. This is overridden in ChartPane and unused in AnalysisTaskChartPane.
        (ChartPaneBase.cssTemplate): Extracted from ChartPane.htmlTemplate.

        * public/v3/components/chart-styles.js: Renamed from public/v3/pages/page-with-charts.js.
        (PageWithCharts): Renamed from PageWithCharts since it no longer extends PageWithHeading.
        (ChartStyles.createChartSourceList):

        * public/v3/components/commit-log-viewer.js:
        (CommitLogViewer.prototype.view): Set this._repository right away instead of waiting for the fetched data
        so that spinner will be shown while the data is being fetched.

        * public/v3/index.html:

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskChartPane): Added extends ChartPaneBase.
        (AnalysisTaskPage): Added. this._chartPane.
        (AnalysisTaskPage.prototype._didFetchTask): Initialize this._chartPane with a domain.
        (AnalysisTaskPage.prototype.render): Render this._chartPane.
        (AnalysisTaskPage.htmlTemplate):

        * public/v3/pages/chart-pane-status-view.js:
        (ChartPaneStatusView): Removed the unused router from the argument list.
        (ChartPaneStatusView.prototype.pointsRangeForAnalysis): Renamed from analyzeData() since it was ambiguous.
        (ChartPaneStatusView.prototype.moveRepositoryWithNotification): Fixed the bug that we don't update the list
        of the revisions here.
        (ChartPaneStatusView.prototype.computeChartStatusLabels):

        * public/v3/pages/chart-pane.js:
        (ChartPane): Now extends ChartPaneBase. 
        (ChartPane.prototype._overviewSelectionDidChange): Extracted from the constructor.
        (ChartPane.prototype._mainSelectionDidChange): 
        (ChartPane.prototype._mainSelectionDidZoom):
        (ChartPane.prototype._indicatorDidChange):
        (ChartPane.prototype.render):
        (ChartPane.prototype._renderActionToolbar):
        (ChartPane.paneHeaderTemplate): Extracted from htmlTemplate.
        (ChartPane.cssTemplate):
        (ChartPane.overviewOptions.selection.onchange): Deleted.
        (ChartPane.prototype._fetchAnalysisTasks): Deleted.
        (ChartPane.prototype.platformId): Deleted.
        (ChartPane.prototype.metricId): Deleted.
        (ChartPane.prototype.setOverviewDomain): Deleted.
        (ChartPane.prototype.setMainDomain): Deleted.
        (ChartPane.prototype._openCommitViewer): Deleted.
        (ChartPane.prototype._didFetchData): Deleted.
        (ChartPane.prototype._keyup): Deleted.

        * public/v3/pages/charts-page.js:
        (ChartsPage):
        (ChartsPage.createDomainForAnalysisTask): Extracted by createDomainForAnalysisTask; used to set the domain
        of the charts in the analysis task page.
        (ChartsPage.createStateForAnalysisTask):

        * public/v3/pages/dashboard-page.js:
        (DashboardPage):
        (DashboardPage.prototype._createChartForCell):

2016-02-10  Ryosuke Niwa  <rniwa@webkit.org>

        Add the support for maintenance mode
        https://bugs.webkit.org/show_bug.cgi?id=154072

        Reviewed by Chris Dumez.

        Added the crude support for maintenance mode whereby which the reports are stored in the filesystem
        instead of the database.

        * config.json: Added maintenanceMode and maintenanceDirectory as well as forgotten siteTitle and
        remoteServer.httpdMutexDir.
        * public/api/report.php:
        (main): Don't connect to the database or modify database when maintenanceMode is set.
        * public/include/json-header.php:
        (ensure_privileged_api_data): Exit with InMaintenanceMode when maintenanceMode is set. This prevents
        privileged API such as creating analysis tasks and new A/B testing groups from modifying the database.

2016-02-09  Ryosuke Niwa  <rniwa@webkit.org>

        Analysis task page on v3 show progression as regressions
        https://bugs.webkit.org/show_bug.cgi?id=154045

        Reviewed by Chris Dumez.

        The bug was caused by TestGroup.compareTestResults referring to undefined _smallerIsBetter.
        Retrieve it from the associated metric object via the owner analysis task.

        * public/v3/models/test-group.js:

2016-02-05  Ryosuke Niwa  <rniwa@webkit.org>

        Testing with remote server cache is unusably slow
        https://bugs.webkit.org/show_bug.cgi?id=153928

        Reviewed by Chris Dumez.

        Don't use the single process mode of httpd as it's way too slow even for testing.
        Also we'll hit a null pointer crash (http://svn.apache.org/viewvc?view=revision&revision=1711479)

        Since httpd exits immediately when launched in multi-process mode, remote-cache-server.py (renamed from
        run-with-remote-server.py) now has "start" and "stop" commands to start/stop the Apache. Also added
        "reset" command to reset the cache for convenience.

        * Install.md: Updated the instruction.
        * config.json: Fixed a typo: httpdErro*r*Log.
        * tools/remote-cache-server.py: Copied from Websites/perf.webkit.org/tools/run-with-remote-server.py.
        Now takes one of the following commands: "start", "stop", and "reset".
        (main):
        (start_httpd): Extracted from main.
        (stop_httpd): Added.
        * tools/remote-server-relay.conf: Removed redundant (duplicate) LoadModule's.
        * tools/run-with-remote-server.py: Removed.

2016-02-04  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should have a script to setup database
        https://bugs.webkit.org/show_bug.cgi?id=153906

        Reviewed by Chris Dumez.

        Added tools/setup-database.py to setup the database. It retrieves the database name, username, password
        and initializes a database at the specified location.

        * Install.md: Updated instruction to setup postgres to use setup-database.py.
        * tools/setup-database.py: Added.
        (main):
        (load_database_config):
        (determine_psql_dir):
        (start_or_stop_database):
        (execute_psql_command):

2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>

        buildbot syncing scripts sometimes schedule more than one requests per builder
        https://bugs.webkit.org/show_bug.cgi?id=153047

        Reviewed by Chris Dumez.

        The bug was caused by the check for singularity of scheduledRequests being conducted per configuration
        instead of per builder. So if there were multiple test configurations (e.g. Speedometer and Octane) that
        both used the same builder, then we may end up scheduling both at once.

        Fixed the bug by sharing a single set to keep track of the scheduled requests for all configurations per
        builder.

        * tools/sync-with-buildbot.py:
        (load_config): Share a set amongst test configurations for each builder.
        (find_request_updates): Instead of creating a new set for each configuration, reuse the existing sets to
        share a single set agmonst test configurations for each builder.

2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>

        Analysis results viewer sometimes doesn't show the correct relative difference
        https://bugs.webkit.org/show_bug.cgi?id=152930

        Reviewed by Chris Dumez.

        The bug was caused by single A/B testing result associated with multiple rows when there are multiple data
        points with the same root set which matches that of an A/B testing.

        Fixed the bug by detecting such a case, and only associating each A/B testing result with the row created
        for the first matching point.

        * public/v3/components/analysis-results-viewer.js:
        (AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):

2016-01-08  Ryosuke Niwa  <rniwa@webkit.org>

        Make v3 UI analysis task page is hard to understand
        https://bugs.webkit.org/show_bug.cgi?id=152917

        Reviewed by Antti Koivisto.

        Add a dark gray border around the selected block in the analysis results viewer instead of using darker
        shades since that looks as if they were bigger regression/progression.

        Explicitly show "Failed" as the label instead of omitting with "-" when all build requests in an A/B
        testing group fails.

        * public/v3/components/analysis-results-viewer.js:
        (AnalysisResultsViewer.cssTemplate): Tweaked the style to underline text in the hovered blocks and the
        selected blocks and show a dark gray border around the selected blocks.
        (AnalysisResultsViewer.TestGroupStackingBlock):
        (AnalysisResultsViewer.TestGroupStackingBlock.prototype.createStackingCell): Use this._title for title.
        (AnalysisResultsViewer.TestGroupStackingBlock.prototype._computeTestGroupStatus):
        (AnalysisResultsViewer.TestGroupStackingBlock.prototype._valuesForRootSet): Deleted.

        * public/v3/components/results-table.js:
        (ResultsTable.prototype.render):
        (ResultsTable.prototype._createRevisionListCells): Extracted from ResultsTable.prototype.render.
        (ResultsTable.cssTemplate): Tweaked the style.
        (ResultsTableRow):
        (ResultsTableRow.prototype.constructor): Added _labelForWholeRow to store the label for the entire row.
        This is used to show the comparison result of two root sets (e.g. A vs B).
        (ResultsTableRow.prototype.setLabelForWholeRow): Added.
        (ResultsTableRow.prototype.labelForWholeRow): Added.
        (ResultsTableRow.prototype.resultContent): Extracted from buildHeading. Creates a hyperlinked bar graph
        used for each A/B testing result.
        (ResultsTableRow.prototype.buildHeading): Deleted since we need to set colspan on the second table cell
        when we're creating a row with _labelForWholeRow.

        * public/v3/components/test-group-results-table.js:
        (TestGroupResultsTable.prototype.buildRowGroups): Added rows to show relative differences and statistical
        significance between root sets (e.g. A vs B).

        * public/v3/models/build-request.js:
        (BuildRequest.prototype.hasCompleted): Added.

        * public/v3/models/test-group.js:
        (TestGroup.prototype.compareTestResults): Extracted from AnalysisResultsViewer.TestGroupStackingBlock's
        _computeTestGroupStatus and generalized to be reused in TestGroupResultsTable.
        (TestGroup.prototype._valuesForRootSet): Moved from AnalysisResultsViewer.TestGroupStackingBlock.

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage.cssTemplate): Tweaked the style.

2016-01-07  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should automatically add aggregators
        https://bugs.webkit.org/show_bug.cgi?id=152818

        Reviewed by Chris Dumez.

        When an aggregator entry is missing in aggregators table, automatically insert it in /api/report.

        In a very early version of the perf dashboard, we had the ability to define a custom aggregator
        in an admin page. In practice, nobody used or needed this feature so we got rid of it even before
        the dashboard was landed into WebKit repository. This patch cleans up that mess.

        * run-tests.js:
        (main): Added the filtering capability.
        (TestEnvironment): Expose the config JSON in the test environment.

        * public/include/report-processor.php:
        (ReportProcessor): Renamed name_to_aggregator now that it only contains ID.
        (ReportProcessor::__construct): No longer fetches the aggregator table. An equivalent work is done
        in newly added ensure_aggregators.
        (ReportProcessor::process): Calls ensure_aggregators which populates name_to_aggregator_id.
        (ReportProcessor::ensure_aggregators): Added. Add the builtin aggregators: Arithmetic, Geometric,
        Harmonic, and Total.
        (TestRunsGenerator): Renamed name_to_aggregator now that it only contains ID.
        (TestRunsGenerator::__construct):
        (TestRunsGenerator::add_aggregated_metric): Don't include aggregator_definition here since it's
        never used now that all the aggregations are done natively in PHP.
        (TestRunsGenerator::$aggregators): Added. We don't include SquareSum since it's only used for
        computing run_square_sum_cache in test_runs table and it's useless elsewhere.
        (TestRunsGenerator::aggregate_values): Add a comment about that.

        * tests/api-report.js: Updated a test case to reflect the change.

2016-01-06  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard JSON API should fail gracefully when postgres is down
        https://bugs.webkit.org/show_bug.cgi?id=152812

        Reviewed by Chris Dumez.

        Even though all JSON APIs returned DatabaseConnectionFailure as the status when Database::connect
        returned a falsy value, PHP was spitting out warnings and producing HTTP responses that cannot be
        parsed as a JSON when pg_connect failed.

        Fixed the bug by suppressing warning messages in pg_connect.

        * public/include/db.php:
        (Database::connect): Use '@' prefix to suppress warning messages.

2016-01-06  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should auto-generate manifest file when one is missing
        https://bugs.webkit.org/show_bug.cgi?id=152813

        Reviewed by Chris Dumez.

        When /data/manifest.json is missing, fall back to newly added /api/manifest instead of
        silently failing to show the UI. This will make the initial setup easier.

        * public/api/manifest.php: Added.
        (main):
        * public/include/manifest.php:
        (Manifest::manifest): Added.
        * public/v3/main.js:
        (fetchManifest):
        (didFetchManifest): Extracted from fetchManifest.

2016-01-06  Ryosuke Niwa  <rniwa@webkit.org>

        Commit another forgotten change, this time, for r194653.

        * public/v3/models/measurement-set.js:

2016-01-06  Ryosuke Niwa  <rniwa@webkit.org>

        The sampling of time series on v3 UI is too aggressive
        https://bugs.webkit.org/show_bug.cgi?id=152804

        Reviewed by Chris Dumez.

        Fixed a bug that we were always halving the number of data points in _sampleTimeSeries
        and increased the number of data points allowed to make the sampling less aggressive.

        * public/v3/components/time-series-chart.js:
        (TimeSeriesChart.prototype._ensureSampledTimeSeries): Increase the number of maximum points
        to 2x the number of pixels divided by the radius of each point.
        (TimeSeriesChart.prototype._sampleTimeSeries.findMedian): Changed the semantics of endIndex
        to mean the index after the last point and renamed it to indexAfterEnd.
        (TimeSeriesChart.prototype._sampleTimeSeries): Fixed a bug that this code always coerced two
        data points into one sampled data point despite of the fact i and j are sufficiently apart
        since data[j].time - data[i].time > timePerSample by definition.

2016-01-06  Ryosuke Niwa  <rniwa@webkit.org>

        Commit the forgotten change for r194651.

        * public/v3/pages/domain-control-toolbar.js:
        (DomainControlToolbar.prototype.setStartTime):

2016-01-05  Ryosuke Niwa  <rniwa@webkit.org>

        The right hand side of main chart appears to be cut off as you zoom out on v3 UI
        https://bugs.webkit.org/show_bug.cgi?id=152778

        Reviewed by Antti Koivisto.

        Add a padding on x-axis after the end time to make the main chart more easily interactive.

        * public/v3/components/time-series-chart.js:
        (TimeSeriesChart.prototype._computeHorizontalRenderingMetrics):

        * public/v3/pages/page-with-charts.js:
        (PageWithCharts.mainChartOptions): Add a padding of 5px at the end of x-axis.

2016-01-06  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI should use four sig-figs to label y-axis of the main charts
        https://bugs.webkit.org/show_bug.cgi?id=152779

        Reviewed by Antti Koivisto.

        Increase the number of significant figures used in the main charts to four as done in v2 UI.

        * public/v3/pages/chart-pane.js:
        (ChartPane.constructor): Create a formatter with four significant figures.
        * public/v3/pages/page-with-charts.js:
        (PageWithCharts.mainChartOptions): Increase the width of y-axis labels.

2016-01-05  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI's time range slider is harder to use than that of v2 UI
        https://bugs.webkit.org/show_bug.cgi?id=152780

        Reviewed by Antti Koivisto.

        Improved the time range slider by using a cubic mapping to time range and providing a text field
        to directly edit the number of days to show.

        Now an user can enter the text mode to directly edit the number of days to show by clicking on
        the number of days (text field is always there with opacity=0).

        * public/v3/pages/charts-toolbar.js:
        (ChartsToolbar): Store the minimum and maximum number of days allowed. Also rename _inputElement
        to _slider and added a new type=number text field as _editor. 
        (ChartsToolbar.prototype.render):
        (ChartsToolbar.prototype.setStartTime): Exit the text mode when the number of days is changed by
        an URL state transition (i.e. back/forward navigation).
        (ChartsToolbar.prototype._setInputElementValue): Added. Updates the values of _slider and _editor.
        (ChartsToolbar.prototype._enterTextMode): Added. Hide the elements used by the slider mode and
        show the text field.
        (ChartsToolbar.prototype._exitTextMode): Added. Does the opposite.
        (ChartsToolbar.prototype._sliderValueMayHaveChanged): Renamed from _inputValueMayHaveChanged.
        (ChartsToolbar.prototype._editorValueMayHaveChanged): Added. Similar to _sliderValueMayHaveChanged
        but also corrects the value of _editor if needed.
        (ChartsToolbar.prototype._callNumberOfDaysCallback): Extracted from _inputValueMayHaveChanged.
        Also fixed a bug that we didn't update the URL state when the change event was fired without
        modifying the effective number of days.
        (ChartsToolbar.cssTemplate): Tweaked the style to support the new mode. Also set a fixed width on
        the span showing the number of days in the slider mode.

2016-01-06  Ryosuke Niwa  <rniwa@webkit.org>

        Zooming button is broken on v3 UI
        https://bugs.webkit.org/show_bug.cgi?id=152777

        Reviewed by Chris Dumez.

        Bring up the zoom button in z-index so that users can click it.

        * public/v3/components/interactive-time-series-chart.js:
        (InteractiveTimeSeriesChart.cssTemplate):

2016-01-06  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI doesn't preserve the time range when charts page is opened from a dashboard
        https://bugs.webkit.org/show_bug.cgi?id=152776

        Reviewed by Chris Dumez.

        Fixed the bug by moving the construction of charts URL from DashboardPage.prototype.open to
        DashboardPage.prototype.render and re-rendering the entire page upon an URL state transition.

        * public/v3/pages/charts-page.js:
        (ChartsPage.createStateForDashboardItem): Takes the start time for the charts page.

        * public/v3/pages/dashboard-page.js:
        (DashboardPage.prototype.updateFromSerializedState): Merged _numberOfDaysDidChange and
        _updateChartsDomainFromToolbar into this function since they're not used elsewhere. Also re-render
        the entire page when transition between different number of days to show.
        (DashboardPage.prototype._numberOfDaysDidChange): Deleted.
        (DashboardPage.prototype._updateChartsDomainFromToolbar): Deleted.
        (DashboardPage.prototype.render): Construct URL for each charts here.
        (DashboardPage.prototype._createChartForCell): Don't construct URL here since this function is
        called once when the dashboard page is opened, and not when the time range is changed.

2016-01-05  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix for an old version of PHP after r194618.

        * public/api/measurement-set.php:

2016-01-05  Ryosuke Niwa  <rniwa@webkit.org>

        A/B testing results should be visualized intuitively on v3 UI
        https://bugs.webkit.org/show_bug.cgi?id=152496

        Rubber-stamped by Chris Dumez.

        Add the "stacking block" view of A/B testing results to the analysis task page on v3 UI.

        The patch enhances JSON APIs at /api/analysis-task /api/measurement-set/ to reduce the number of
        HTTP requests, and adds two UI components: TestGroupResultsTable and AnalysisResultsViewer both
        of which inherits from an abstract superclass: ResultsTable.

        ResultsTable provides a tabular presentation of measured values in regular measurement sets and
        A/B testing results using groups of bar graphs created by BarGraphGroup. TestGroupResultsTable
        inherits from this class to display A/B testing configurations and the averaged results for each
        configuration, and AnalysisResultsViewer inherits from it to provide an intuitive visualization
        of the outcomes of all A/B testing results associated with a given analysis task.

        * public/api/analysis-tasks.php:
        (main): Add the capability to find the analysis task based on its build request.
        This allows /v3/#/analysis/task/?buildRequest=<id> to be hyperlinked on buildbot page.

        * public/api/measurement-set.php:
        (main): Removed the unused startTime and endTime, and added "analysisTask" to query parameters.
        (AnalysisResultsFetcher): Added. Used to fetch measured data associated with every build request
        on an analysis task.
        (AnalysisResultsFetcher::__construct):
        (AnalysisResultsFetcher::fetch): Unlike MeasurementSetFetcher, we fetch the list of commits and
        list of measurements separately since there will be a lot less builds and commits than measured
        data (since we're fetching measured values for all tests and their metrics).
        (AnalysisResultsFetcher::fetch_commits): Fetches commits.
        (AnalysisResultsFetcher::format_measurement): Like MeasurementSetFetcher::format_measurement but
        with config_type and config_metric since we're returning measured data for all metrics and test
        configurations.
        (AnalysisResultsFetcher::format_map): Similar to MeasurementSetFetcher::format_map.

        * public/v3/components/analysis-results-viewer.js: Added.
        (AnalysisResultsViewer): Added. 
        (AnalysisResultsViewer.prototype.didUpdateResults): This callback is called by AnalysisTaskPage
        when A/B testing results become available.
        (AnalysisResultsViewer.prototype.render): Overrides ResultsTable's render to highlight the block
        representing the currently selected test group.

        (AnalysisResultsViewer.prototype.buildRowGroups): Creates a list of rows with "stacking blocks"
        that visualizes A/B testing results. The algorithm works as follows: 1. Create all table rows.
        2. Find which row is associated with each set in each test group. 3. Layout "blocks".

        (AnalysisResultsViewer.prototype._collectRootSetsInTestGroups): Collects root sets from all data
        in the measurement set as well as A/B testing **requests** (results may contain more repositories
        than requested but they aren't interesting for the purpose of visualizing results for the entire
        analysis task).

        (AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups): Create table rows. First,
        create table rows for measurement set points that have a matching test group (i.e. either set A
        or set B of an A/B testing uses the same root set as a point). Second, insert a new row for each
        root set in each test group which didn't find a matching measurement set point. There is a little
        subtlety that some A/B testing may specify revisions for a subset of repositories and/or some A/B
        testing results may appear as if it goes back in time with respect to other A/B testing results.
        For example, consider creating two A/B test groups for WebKit changes and OS changes separately.
        There could be no coherent linearization of those two A/B testing in which both WebKit and OS
        versions move forward.

        (AnalysisResultsViewer.RootSetInTestGroup): Added. Represents a pair (test group, root set) since
        a root set could be shared by multiple test groups.
        (AnalysisResultsViewer.TestGroupStackingBlock): Added. A stacked block representing a test group.
        (AnalysisResultsViewer.TestGroupStackingBlock.prototype.addRowIndex): Associates a row number with
        either set A or set B.
        (AnalysisResultsViewer.TestGroupStackingBlock.prototype.createStackingCell): Creates a table cell
        for this block.
        (AnalysisResultsViewer.TestGroupStackingBlock.prototype.isThin): Returns true if this test group
        has failed and this block should look "thin" without any label.
        (AnalysisResultsViewer.TestGroupStackingBlock.prototype._computeTestGroupStatus): Computes the
        status for this test group.

        (AnalysisResultsViewer.TestGroupStackingGrid): Added. AnalysisResultsViewer uses this class to
        layout blocks representing test groups.
        (AnalysisResultsViewer.TestGroupStackingGrid.prototype.insertBlockToColumn): Inserts a new block
        to layout. We keep all test groups doing the same A/B test next to each other.
        (AnalysisResultsViewer.TestGroupStackingGrid.prototype.layout): Layouts each block / test group
        in the order they are created.
        (AnalysisResultsViewer.TestGroupStackingGrid.prototype._layoutBlock): Places the block in the
        left-most column that can accommodate it while avoiding columns of a different thin-ness. A column
        is thin if its A/B testing has failed, and not thin otherwise.
        (AnalysisResultsViewer.TestGroupStackingGrid.prototype.createCellsForRow): Creates table cells for
        a given row. For each column, generate a table cell if we're in the first row and the first block
        starts in a later row, a block starts in the current row, or the last block ended in the previous
        row and the next block or the last row appears later.

        * public/v3/components/bar-graph-group.js: Added. A component for showing a group of bar graphs.
        (BarGraphGroup): Added. Creates a group of bar graphs with the same value range. It's used by
        AnalysisResultsViewer and ResultsTable to show bar graphs to compare values.
        (SingleBarGraph): A component created and collectively controlled by BarGraphGroup.

        * public/v3/components/results-table.js: Added.
        (ResultsTable): An abstract superclass for TestGroupResultsTable and AnalysisResultsViewer.

        (ResultsTable.prototype.render): Renders the table. 1. Call "buildRowGroups()" implemented by
        a subclass to obtain the list of rows. 2. Compute the list of repositories to show. 3. For each
        cell in the table, compute the number of rows to show the same value (for rowspan). 4. Render the
        table with an extra list of repositories if exists.

        (ResultsTable.prototype._computeRepositoryList): Compute the list of repositories to list
        revisions in the table. Omit repositories not present in any row or for which all rows have the
        same revision. In the latter case, include it in the extra repositories listed below the table.
        This minimizes the amount of redundant information presented to the user.

        (ResultsTableRow): Added. Represents a single row in the table. ResultsTable constructs necessary
        table cells to tabulate the associated root sets, and shows the associated result using a grouped
        bar graph. Additional columns are used by AnalysisResultsViewer to show stacked blocks for A/B
        testing groups.

        * public/v3/components/test-group-results-table.js: Added.
        (TestGroupResultsTable):
        (TestGroupResultsTable.prototype.didUpdateResults):
        (TestGroupResultsTable.prototype.setTestGroup):
        (TestGroupResultsTable.prototype.heading):
        (TestGroupResultsTable.prototype.render):
        (TestGroupResultsTable.prototype.buildRowGroups):

        * public/v3/index.html:
        * public/v3/models/analysis-results.js: Added.
        (AnalysisResults): Added. Like MeasurementSet, this class represents a set of measured values
        associated with a given analysis task.
        (AnalysisResults.prototype.find): Returns a measured valued for a given build and metric.
        (AnalysisResults.prototype.add): Adds a new measured value. Used by AnalysisResults.fetch.
        (AnalysisResults.fetch): Fetches data and creates AnalysisResults for a given analysis task.

        * public/v3/models/analysis-task.js:
        (AnalysisTask.prototype.startMeasurementId): Added.
        (AnalysisTask.prototype.endMeasurementId): Added.
        (AnalysisTask.fetchByBuildRequestId): Added.
        (AnalysisTask._fetchSubset): Uses DataModelObject.cachedFetch.

        * public/v3/models/build-request.js: Added.
        (BuildRequest): Added. Represents a single A/B testing request associated with a test group.

        * public/v3/models/builder.js:
        (Build): Added. Represents a build associated with a given A/B testing result.

        * public/v3/models/commit-log.js:
        (CommitLog): Made this class inherit from DataModelObject.
        (CommitLog.ensureSingleton): Added. Finds the singleton object created for a given revision
        in the specified repository. This helps RootSet and other classes compare commits fast.
        (CommitLog.prototype.repository): Added.
        (CommitLog.fetchBetweenRevisions): Uses CommitLog.ensureSingleton.

        * public/v3/models/data-model.js:
        (DataModelObject):
        (DataModelObject.namedStaticMap): Added.
        (DataModelObject.ensureNamedStaticMap): Renamed from namedStaticMap instead of implicitly
        assuming that the non-static version always creates the map.
        (DataModelObject.prototype.namedStaticMap): Added.
        (DataModelObject.cachedFetch): Extracted from AnalysisTask._fetchSubset so that TestGroup's
        fetchByTask could also use it.
        (LabeledObject):

        * public/v3/models/measurement-adaptor.js: Added.
        (MeasurementAdaptor): Extracted from MeasurementCluster. This class is responsible for
        re-formatting the data received via /api/measurement-set JSON API inside the v3 UI.
        (MeasurementAdaptor.prototype.extractId): Added.
        (MeasurementAdaptor.prototype.adoptToAnalysisResults): Added. Used by AnalysisResults.
        (MeasurementAdaptor.aggregateAnalysisResults): Added. Used by TestGroupResultsTable to
        aggregate results for each test configuration; e.g. computing the average for set A.
        (MeasurementAdaptor.prototype.adoptToSeries): Extracted from MeasurementCluster.addToSeries.
        Added rootSet() to each point. This allows AnalysisResultsViewer to compare them against root
        sets associated with A/B testing results.
        (MeasurementAdaptor.computeConfidenceInterval): Moved from MeasurementCluster.

        * public/v3/models/measurement-cluster.js:
        (MeasurementCluster):
        (MeasurementCluster.prototype.addToSeries):

        * public/v3/models/repository.js:
        (Repository.prototype.hasUrlForRevision): Added.

        * public/v3/models/root-set.js: Added.
        (RootSet): Added. Represents a set of commits in measured results.
        (MeasurementRootSet): Added. Ditto for results associated with A/B testing.

        * public/v3/models/test-group.js: Added.
        (TestGroup): Added. Represents a A/B testing on analysis task.
        (TestGroup.prototype.createdAt): Added.
        (TestGroup.prototype.buildRequests): Returns the list of build requests associated with this
        A/B testing.
        (TestGroup.prototype.addBuildRequest): Added. Used by BuildRequest's constructor to associate
        itself with this group.
        (TestGroup.prototype.didSetResult): Added. Called by BuildRequest.setResult when measured
        values are fetched and associated with a build request in this group.

        * public/v3/models/test.js:
        (Test):

        * public/v3/pages/analysis-task-page.js:
        (AnalysisTaskPage):
        (AnalysisTaskPage.prototype.updateFromSerializedState): Fetch the analysis task, test groups
        associated with it, and all A/B testing results based on the task id or the build request id
        specified in the URL.
        (AnalysisTaskPage.prototype._didFetchTask): Added. Start fetching the measured data. This is
        the data on charts page for which this analysis task was created, not results of A/B testing.
        (AnalysisTaskPage.prototype._didFetchMeasurement): Added. Display the fetched data in a table
        inside AnalysisResultsViewer.
        (AnalysisTaskPage.prototype._didFetchTestGroups): Added. Display the list of A/B test groups
        as well as the results of the first A/B testing.
        (AnalysisTaskPage.prototype._didFetchAnalysisResults): Added.
        (AnalysisTaskPage.prototype._assignTestResultsIfPossible): Added. Once both the analysis task,
        A/B test groups as well as their results are fetched, update build requests in each test group
        with their results.
        (AnalysisTaskPage.prototype.render): Show the list of test groups and highlight the currently
        selected one.
        (AnalysisTaskPage.prototype._showTestGroup): Added. A callback used by AnalysisResultsViewer
        and TestGroupResultsTable to notify this class when the user selects a new test group.
        (AnalysisTaskPage.htmlTemplate): Updated the template.
        (AnalysisTaskPage.cssTemplate): Ditto.

        * public/v3/pages/charts-page.js:
        (ChartsPage.createStateForAnalysisTask): Added. Creates a URL state object for opening a chart
        associated with an analysis task.

2015-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Analysis task page is slow to load
        https://bugs.webkit.org/show_bug.cgi?id=152517

        Reviewed by Andreas Kling.

        The slowness comes from r194130 which made the JSON API at /api/analysis-tasks to report the start
        and the end of each analysis task. This query was adding ~2s to the total JSON generation time.

        Cache these values on analysis_task table since they never change once an analysis task is created.

        * init-database.sql: Added columns task_start_run_time and task_end_run_time to analysis_task table.
        Also added the missing drop statements at the top.

        * public/api/analysis-tasks.php:
        (fetch_and_push_bugs_to_tasks): Don't fetch the latest commit time of the start and the end.
        (format_task): Report task_start_run_time and task_end_run_time as startRunTime and endRunTime.

        * public/privileged-api/create-analysis-task.php:
        (main): Set start_run_time and end_run_time when creating an analysis task.
        (time_for_run): Added.

2015-12-17  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI shouldn't open/close pane selector by mouseenter/leave
        https://bugs.webkit.org/show_bug.cgi?id=152399

        Reviewed by Andreas Kling.

        Removed the code to open and close the pane selector by mouseenter and mouseleave
        since multiple people have complained about the behavior.

        * public/v3/pages/charts-toolbar.js:
        (ChartsToolbar): Removed the event listeners.
        (ChartsToolbar.prototype._addPane): Don't close the pane selector when adding a new pane
        to better support the use case of adding multiple panes.
        (ChartsToolbar.cssTemplate): Tweaked CSS.

2015-12-17  Ryosuke Niwa  <rniwa@webkit.org>

        Popover for analysis tasks shows up at the left edge of annotation bars in the v3 UI
        https://bugs.webkit.org/show_bug.cgi?id=152389

        Reviewed by Darin Adler.

        Compute the x coordinate of the popover from the center of each annotation bar.

        Also adjust the x coordinate to keep the popover within the charts.

        * public/v3/components/interactive-time-series-chart.js:
        (InteractiveTimeSeriesChart.prototype._renderChartContent):

2015-12-17  Ryosuke Niwa  <rniwa@webkit.org>

        Dashboard charts should have uniform widths on v3 UI
        https://bugs.webkit.org/show_bug.cgi?id=152395

        Reviewed by Chris Dumez.

        Fix the bug by applying table-layout: fixed on the dashboard table.

        * public/v3/pages/dashboard-page.js:
        (DashboardPage.prototype.render): Added header-column as a class name to explicitly set the header column with.
        (DashboardPage.cssTemplate): Adjusted CSS accordingly.

2015-12-17  Ryosuke Niwa  <rniwa@webkit.org>

        Closing a pane on v3 UI always closes the last pane
        https://bugs.webkit.org/show_bug.cgi?id=152388

        Reviewed by Chris Dumez.

        The bug was caused by closePane being called without arguments. (The first argument to bind is "this" value.)
        Fixed it by passing in "this" pane object to the first argument.

        * public/v3/pages/chart-pane.js:
        (ChartPane):

2015-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        Perf Dashboard v3 UI doesn't show recent data points on v2 UI
        https://bugs.webkit.org/show_bug.cgi?id=152368

        Reviewed by Chris Dumez.

        The bug was caused by the last modified date in measurement set JSON being a string instead of a POSIX timestamp,
        which prevented the v3 UI from invalidating the cache. Specifically, the following boolean logic always evaluated
        to false because +data['lastModified'] was NaN in MeasurementSet.prototype._fetch (/v3/models/measurement-set.js):

        !clusterEndTime && useCache && +data['lastModified'] < self._lastModified

        Fixed the bug by calling Database::to_js_time on the last modified date fetched from the database.

        * public/api/measurement-set.php:
        (MeasurementSetFetcher::fetch_config_list): Convert the string returned by the database to a POSIX timestamp.
        * tests/api-measurement-set.js: Added a test to ensure the last modified date in JSON is numeric. Since the value
        of the last modified date depends on when tests run, we can't assert it to be a certain value.

2015-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        v3 UI should show and link the build number on charts page
        https://bugs.webkit.org/show_bug.cgi?id=152359

        Reviewed by Chris Dumez.

        Show the hyperlinked build number in the v3 UI.

        * public/v3/models/builder.js:
        (Builder): Renamed _buildURL to _buildUrlTemplate.
        (Builder.prototype.urlForBuild): Added.
        * public/v3/pages/chart-pane-status-view.js:
        (ChartPaneStatusView):
        (ChartPaneStatusView.prototype.render): Added the code to render hyperlinked build number when one is available.
        (ChartPaneStatusView.prototype.computeChartStatusLabels): Store currentPoint's measurement object as _buildInfo
        if the current point is set by an indicator (not by a selection).

2015-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        v3 dashboard doesn't stretch charts to fill the screen
        https://bugs.webkit.org/show_bug.cgi?id=152354

        Reviewed by Chris Dumez.

        The bug was caused by a workaround to avoid canvas stretching table cell too much.

        Fix the problem instead by making the canvas absolutely positioned inside the "time-series-chart" element
        so that it does not contribute to the intrinsic/natural width of the cell.

        * public/v3/components/time-series-chart.js:
        (TimeSeriesChart.prototype._ensureCanvas): Make the canvas absolutely positioned inside the shadow root.
        (TimeSeriesChart.prototype._updateCanvasSizeIfClientSizeChanged): Use the container element's size now that
        the canvas does not resize with it.
        * public/v3/pages/dashboard-page.js:
        (DashboardPage.cssTemplate): Updated the CSS so that the chart stretches all the way.

2015-12-16  Ryosuke Niwa  <rniwa@webkit.org>

        The chart status on v3 UI sometimes show wrong revision ranges
        https://bugs.webkit.org/show_bug.cgi?id=152331

        Reviewed by Chris Dumez.

        The bug was caused by the status view not taking the data sampling that happens in TimeSeriesChart into account
        when finding the previous point. Take this into account by using InteractiveTimeSeries.currentPoint(-1) which
        finds the sampled data point immediately preceding the current point (at which the indicator is shown).

        * public/v3/components/chart-status-view.js:
        (ChartStatusView.prototype.updateStatusIfNeeded):

2015-12-15  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard's cycler page should use v3 UI
        https://bugs.webkit.org/show_bug.cgi?id=152324

        Reviewed by Chris Dumez.

        Use the v3 UI in cycler.html after r194130.

        * public/cycler.html:
        * public/v3/index.html: Removed the reference to a non-existent platform-selector.js.

2015-12-15  Ryosuke Niwa  <rniwa@webkit.org>

        Add v3 UI to perf dashboard
        https://bugs.webkit.org/show_bug.cgi?id=152311

        Reviewed by Chris Dumez.

        Add the third iteration of the perf dashboard UI. UI for viewing and modifying analysis tasks is coming soon.
        The v3 UI is focused on speed, and removes all third-party script dependencies including jQuery, d3, and Ember.
        Both the DOM-based UI and graphing are implemented manually.


        The entire app is structured using new component library implemented in components/base.js. Each component is
        an instance of a subclass of ComponentBase which owns a single DOM element. Each subclass may supply static
        methods named htmlTemplate and cssTemplate as the template for a component instance. ComponentBase automatically
        clones the templates inside the associated element (or its shadow root on the supported browsers). Each subclass
        must supply a method called "render()" which constructs and updates the DOM as needed.

        There is a special component called Page, which represents an entire page. Each Page is opened by PageRouter's
        "route()" function. Each subclass of Page supplies "open()" for initialization and "updateFromSerializedState()"
        for a hash URL transition.


        The key feature of the v3 UI is the split of time series into chunks called clusters (see r194120). On an internal
        instance of the dashboard, the v2 UI downloads 27MB of data whereas the same page loads only 3MB of data in the v3.
        The key logic for fetching time series in chunks is implemented by MeasurementSet in /v3/models/measurement-set.js.
        We first fetch the cached primary cluster (the cluster that contains the newest data) at:
        /data/measurement-set-<platform-id>-<metric-id>.json

        If that's outdated according to lastModified in manifest.json, then we immediately re-fetch the primary cluster at:
        /api/measurement-set/?platform=<platform-id>&metric=<metric-id>

        Once the up-to-date primary cluster is fetched, we fetch all "secondary" clusters. For each cluster being fetched,
        including the primary, we invoke registered callbacks.


        In addition, the v3 UI reduces the initial page load time by loading a single bundled JS file generated by
        tools/bundle-v3-scripts.py. index.html has a fallback to load all 44 JS files individually during development.

        * public/api/analysis-tasks.php:
        (fetch_and_push_bugs_to_tasks): Added the code to fetch start and end run times. This is necessary in V3 UI
        because no longer fetch the entire time series. See r194120 for the new measurement set JSON API.
        (format_task): Compute the category of an analysis task based on "result" value. This will be re-vamped once
        I add the UI for the analysis task page in v3.

        * public/include/json-header.php:
        (require_format): CamelCase the name.
        (require_match_one_of_values): Ditto.
        (validate_arguments): Renamed from require_existence_of and used in measurement-set.php landed in r194120.

        * public/v3: Added.
        * public/v3/components: Added.

        * public/v3/components/base.js: Added.
        (ComponentBase): The base component class.
        (ComponentBase.prototype.element): Returns the DOM element associated with the DOM element.
        (ComponentBase.prototype.content): Returns the shadow root if one exists and the associated element otherwise.
        (ComponentBase.prototype.render): To be implemented by a subclass.
        (ComponentBase.prototype.renderReplace): A helper function to "render" DOM contents.
        (ComponentBase.prototype._constructShadowTree): Called inside the constructor to instantiate the templates.
        (ComponentBase.prototype._recursivelyReplaceUnknownElementsByComponents): Instantiates components referred by
        its element name inside the instantiated content.
        (ComponentBase.isElementInViewport): A helper function. Returns true if the element is in the viewport and it has
        non-zero width and height.
        (ComponentBase.defineElement): Defines a custom element that can be automatically instantiated from htmlTemplate.
        (ComponentBase.createElement): A helper function to create DOM tree to be used in "render()" method.
        (ComponentBase._addContentToElement): A helper for "createElement".
        (ComponentBase.createLink): A helper function to create a hyperlink or another clickable element (via callback).
        (ComponentBase.createActionHandler): A helper function to create an event listener that prevents the default action
        and stops the event propagation.

        * public/v3/components/button-base.js: Added.

        * public/v3/components/chart-status-view.js: Added.
        (ChartStatusView): A component that reports the current status of time-series-chart. It's subclasses by
        ChartPaneStatusView to provide additional information in the charts page's panes.

        * public/v3/components/close-button.js: Added.
        (CloseButton):
        * public/v3/components/commit-log-viewer.js: Added.
        (CommitLogViewer): A component that lists commit revisions along with commit messages for a range of data points.

        * public/v3/components/interactive-time-series-chart.js: Added.
        (InteractiveTimeSeriesChart): A subclass of InteractiveTimeSeriesChart with interactivity (selection & indicator).
        Selection and indicator are mutually exclusive.

        * public/v3/components/pane-selector.js: Added.
        (PaneSelector): A component for selecting (platform, metric) pair to add in the charts page.

        * public/v3/components/spinner-icon.js: Added.

        * public/v3/components/time-series-chart.js: Added.
        (TimeSeriesChart): A canvas-based chart component without interactivity. It takes a source list and options as
        the constructor arguments. A source list is a list of measurement sets (measurement-set.js) with drawing options.
        This component fetches data via MeasurementSet.fetchBetween inside TimeSeriesChart.prototype.setDomain and
        progressively updates the charts as more data arrives. The canvas is updated on animation frame via rAF and all
        layout and rendering metrics are lazily computed in _layout. In addition, this component samples data before
        rendering the chart when there are more data points per pixel in _ensureSampledTimeSeries.

        * public/v3/index.html: Added. Loads bundled-scripts.js if it exists, or individual script files otherwise.

        * public/v3/instrumentation.js: Added. This class is used to gather runtime statistics of v3 UI. (It measures
        the performance of the perf dashboard UI).

        * public/v3/main.js: Added. Bootstraps the app.
        (main):
        (fetchManifest):

        * public/v3/models: Added.
        * public/v3/models/analysis-task.js: Added.
        * public/v3/models/bug-tracker.js: Added.
        * public/v3/models/bug.js: Added.
        * public/v3/models/builder.js: Added.
        * public/v3/models/commit-log.js: Added.
        * public/v3/models/data-model.js: Added.
        (DataModelObject): The base class for various data objects that correspond to database tables. It supplies static
        hash map to find entries by id as well as other keys.
        (LabeledObject): A subclass of DataModelObject with the capability to find an object via its name.

        * public/v3/models/measurement-cluster.js: Added.
        (MeasurementCluster): Represents a single cluster or a chunk of data in a measurement set.

        * public/v3/models/measurement-set.js: Added.
        (MeasurementSet): Represents a measurement set.
        (MeasurementSet.findSet): Returns the singleton set given (metric, platform). We use singleton to avoid issuing
        multiple HTTP requests for the same JSON when there are multiple TimeSeriesChart that show the same graph (e.g. on
        charts page with overview and main charts).
        (MeasurementSet.prototype.findClusters): Finds the list of clusters to fetch in a given time range.
        (MeasurementSet.prototype.fetchBetween): Fetch clusters for a given time range and calls callback whenever new data
        arrives. The number of callbacks depends on the how many clusters need to be newly fetched.
        (MeasurementSet.prototype._fetchSecondaryClusters): Fetches non-primary (non-latest) clusters.
        (MeasurementSet.prototype._fetch): Issues a HTTP request to fetch a cluster.
        (MeasurementSet.prototype._didFetchJSON): Called when a cluster is fetched.
        (MeasurementSet.prototype._failedToFetchJSON): Called when the fetching of a cluster has failed.
        (MeasurementSet.prototype._invokeCallbacks): Invokes callbacks upon an approval of a new cluster.
        (MeasurementSet.prototype._addFetchedCluster): Adds the newly fetched cluster in the order.
        (MeasurementSet.prototype.fetchedTimeSeries): Returns a time series that contains data from all clusters that have
        been fetched.
        (TimeSeries.prototype.findById): Additions to TimeSeries defined in /v2/data.js.
        (TimeSeries.prototype.dataBetweenPoints): Ditto.
        (TimeSeries.prototype.firstPoint): Ditto.

        * public/v3/models/metric.js: Added.
        * public/v3/models/platform.js: Added.
        * public/v3/models/repository.js: Added.
        * public/v3/models/test.js: Added.

        * public/v3/pages: Added.
        * public/v3/pages/analysis-category-page.js: Added. The "Analysis" page that lists the analysis tasks.
        * public/v3/pages/analysis-category-toolbar.js: Added. The toolbar to filter analysis tasks based on its category
        (unconfirmed, bisecting, identified, closed) and a keyword.

        * public/v3/pages/analysis-task-page.js: Added. Not implemented yet. It just has the hyperlink to the v2  UI.

        * public/v3/pages/chart-pane-status-view.js: Added.
        (ChartPaneStatusView): A subclass of ChartStatusView used in the charts page. In addition to the current value,
        comparison to baseline/target, it shows the list of repository revisions (e.g. WebKit revision, OS version).

        * public/v3/pages/chart-pane.js: Added.
        (ChartPane): A component a pane in the charts page. Each pane has the overview chart and the main chart. The zooming
        is synced across all panes in the charts page.

        * public/v3/pages/charts-page.js: Added. Charts page.
        * public/v3/pages/charts-toolbar.js: Added. The toolbar to set the number of days to show. This affects the overview
        chart's domain in each pane.

        * public/v3/pages/create-analysis-task-page.js: Added.
        (CreateAnalysisTaskPage): A page that gets shown momentarily while creating a new analysis task.

        * public/v3/pages/dashboard-page.js: Added. A dashboard page.
        * public/v3/pages/dashboard-toolbar.js: Added. Its toolbar with buttons to select the number of days to show.
        * public/v3/pages/domain-control-toolbar.js: Added. An abstract superclass of charts and dashboard toolbars.

        * public/v3/pages/heading.js: Added. A component for displaying the header and toolbar, if exists, on each page.
        * public/v3/pages/page-router.js: Added. This class is responsible for updating the URL hashes as well as opening
        and updating each page when the hash changes (via back/forward navigation).
        * public/v3/pages/page-with-charts.js: Added. An abstract subclass of page used by dashboards and charts page.
        Supplies helper functions for creating TimeSeriesChart options.
        * public/v3/pages/page-with-heading.js: Added. An abstract subclass of page that uses the heading component.
        * public/v3/pages/page.js: Added. The Page component.
        * public/v3/pages/toolbar.js: Added. An abstract toolbar component.

        * public/v3/remote.js: Added.
        (getJSON): Fetches JSON from the remote server.
        (getJSONWithStatus): Ditto. Rejects the response if the status is not "OK".
        (PrivilegedAPI.sendRequest): Posts a HTTP request to a privileged API in /privileged-api/.
        (PrivilegedAPI.requestCSRFToken): Creates a new CSRF token to request a privileged API post.

        * tools/bundle-v3-scripts.py: Added.
        (main): Bundles js files together and minifies them by jsmin.py for the v3 UI. Without this script, we're forced to
        download 44 JS files or making each JS file contain multiple classes.

        * tools/jsmin.py: Copied from WebInspector / JavaScriptCore code.

2015-12-15  Ryosuke Niwa  <rniwa@webkit.org>

        Fix v2 UI after r194093.

        * public/v2/data.js:

2015-12-15  Ryosuke Niwa  <rniwa@webkit.org>

        Add /api/measurement-set for v3 UI
        https://bugs.webkit.org/show_bug.cgi?id=152312

        Rubber-stamped by Chris Dumez.

        The new API JSON allows the front end to fetch measured data in chunks called a "cluster" as specified
        in config.json for each measurement set specified by the pair of a platform and a metric.

        When the front end needs measured data in a given time range (t_0, t_1) for a measurement set, it first
        fetches the primary cluster by /api/measurement-set/?platform=<platform-id>&metric=<metric-id>.
        The primary cluster is the last cluster in the set (returning the first cluster here is not useful
        since we don't typically show very old data), and provides the information needed to fetch other clusters.

        Fetching the primary cluster also creates JSON files at:
        /data/measurement-set-<platform-id>-<metric-id>-<cluster-end-time>.json
        to allow latency free access for secondary clusters. The front end code can also fetch the cache of
        the primary cluster at: /data/measurement-set-<platform-id>-<metric-id>.json.

        Because the front end code has to behave as if all data is fetched, each cluster contains one data point
        immediately before the first data point and one immediately after the last data point. This avoids having
        to fetch multiple empty clusters for manually specified baseline data. To support this behavior, we generate
        all clusters for a given measurement set at once when the primary cluster is requested.

        Furthermore, all measurement sets are divided at the same time into clusters so that the boundary of clusters
        won't shift as more data are reported to the server.

        * config.json: Added clusterStart and clusterSize as options.
        * public/api/measurement-set.php: Added.
        (main):
        (MeasurementSetFetcher::__construct):
        (MeasurementSetFetcher::fetch_config_list): Finds configurations that belongs to this (platform, metric) pair.
        (MeasurementSetFetcher::at_end): Returns true if we've reached the end of all clusters for this set.
        (MeasurementSetFetcher::fetch_next_cluster): Generates the JSON data for the next cluster. We generate clusters
        in increasing chronological order (the oldest first and the newest last).
        (MeasurementSetFetcher::execute_query): Executes the main query.
        (MeasurementSetFetcher::format_map): Returns the mapping of a measurement field to an array index. This removes
        the need to have key names for each measurement and reduces the JSON size by ~10%.
        (MeasurementSetFetcher::format_run): Creates an array that contains data for a single measurement. The order
        matches that of keys in format_map.
        (MeasurementSetFetcher::parse_revisions_array): Added. Copied from runs.php.
        * tests/api-measurement-set.js: Added. Added tests for /api/measurement-set.

2015-12-14  Ryosuke Niwa  <rniwa@webkit.org>

        Using fake timestamp in OS version make some results invisible
        https://bugs.webkit.org/show_bug.cgi?id=152289

        Reviewed by Stephanie Lewis.

        Fix various bugs after r194088.

        * public/api/commits.php:
        (format_commit): Include the commit order.
        * public/v2/data.js:
        (CommitLogs._cacheConsecutiveCommits): Sort by commit order when commit time is missing.
        * tools/pull-os-versions.py:
        (OSBuildFetcher._assign_order): Use integer instead of fake time for commit order.
        (available_builds_from_command): Exit early when an exception is thrown.

2015-12-14  Ryosuke Niwa  <rniwa@webkit.org>

        Fix a typo in the previous commit.

        * public/include/report-processor.php:

2015-12-14  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r192965. Suppress a warning about log being referred to as a closure variable.

        * public/include/report-processor.php:

2015-12-14  Ryosuke Niwa  <rniwa@webkit.org>

        Using fake timestamp in OS version make some results invisible
        https://bugs.webkit.org/show_bug.cgi?id=152289

        Reviewed by Stephanie Lewis.

        Added commit_order column to explicitly order OS versions. This fixes the bug whereby which
        baseline results reported with only OS versions are shown with x coordinate set to 10 years ago.

        To migrate the existing database, run:
            ALTER TABLE commits ADD COLUMN commit_order integer;
            CREATE INDEX commit_order_index ON commits(commit_order);

        Then for each repository $1,
            UPDATE commits SET (commit_time, commit_order) = (NULL, CAST(EXTRACT(epoch from commit_time) as integer))
            WHERE commit_repository = $1;


        * init-database.sql: Added the column.
        * public/api/commits.php:
        (fetch_commits_between): Use commit_order to order commits when commit_time is missing.
        * public/api/report-commits.php:
        (main): Set commit_order.
        * tools/pull-os-versions.py:
        (OSBuildFetcher.fetch_and_report_new_builds):
        (OSBuildFetcher._assign_order): Renamed from _assign_fake_timestamps. Set the order instead of a fake timestmap.

2015-12-14  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard can't merge when the destination platform is missing baseline/target
        https://bugs.webkit.org/show_bug.cgi?id=152286

        Reviewed by Stephanie Lewis.

        The bug was caused by the query to migrate test configurations to new platform checking
        configuration type and metric separately; that is, it assumes the configuration exists
        only if either the same type or the same metric exists in the destination.

        Fixed the bug by checking both conditions simultaneously for each configuration.

        * public/admin/platforms.php:
        * tests/admin-platforms.js: Added a test.

2015-12-11  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard's buildbot sync config JSON duplicates too much information
        https://bugs.webkit.org/show_bug.cgi?id=152196

        Reviewed by Stephanie Lewis.

        Added shared, per-builder, and per-test (called type) configurations.

        * tools/sync-with-buildbot.py:
        (load_config):
        (load_config.merge):

2015-12-02  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should avoid overflow during geometric mean computation
        https://bugs.webkit.org/show_bug.cgi?id=151773

        Reviewed by Chris Dumez.

        * public/include/report-processor.php:

2015-11-30  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should extend baseline and target to the future
        https://bugs.webkit.org/show_bug.cgi?id=151511

        Reviewed by Darin Adler.

        * public/v2/data.js:
        (RunsData.prototype.timeSeriesByCommitTime): Added extendToFuture as an argument.
        (RunsData.prototype.timeSeriesByBuildTime): Ditto.
        (RunsData.prototype._timeSeriesByTimeInternal): Ditto.
        (TimeSeries): Add a new point to the end if extendToFuture is set and the series is not empty.
        * public/v2/manifest.js:
        (App.Manifest._formatFetchedData): Set extendToFuture to true for baselines and targets.

2015-11-30  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should always show comparison to baseline and target even if one is missing
        https://bugs.webkit.org/show_bug.cgi?id=151510

        Reviewed by Darin Adler.

        Show the comparison status against the baseline when baseline is present but target is missing.

        To make the code more readable, this patch splits the logic into three cases:
        1. Both baseline and target are present
        2. Only baseline is present
        3. Only target is present

        Also extracted a helper function to construct the label.

        * public/v2/app.js:
        (.labelForDiff): Added.
        (App.Pane.computeStatus):

2015-11-23  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r192716 and r192717.
        https://bugs.webkit.org/show_bug.cgi?id=151582

        The patch was incorrect. We always need at least one data
        point in each configuration (Requested by rniwa on #webkit).

        Reverted changesets:

        "Perf dashboard's should not include results more than 366
        days old in JSON"
        https://bugs.webkit.org/show_bug.cgi?id=151529
        http://trac.webkit.org/changeset/192716

        "Build fix for old version of PHP."
        http://trac.webkit.org/changeset/192717

2015-11-20  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix for old version of PHP.

        * public/api/runs.php:

2015-11-20  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard's should not include results more than 366 days old in JSON
        https://bugs.webkit.org/show_bug.cgi?id=151529

        Reviewed by Timothy Hatcher.

        Don't return results more than 366 days old in /api/runs/ JSON API.
        This is a ~5% runtime improvement and reduces the JSON file size by 20-50% in the internal perf dashboard.

        * public/api/runs.php:
        (main): Added the support for "?noResults" to avoid echoing results. This is useful for debugging.
        Also instantiate RunsGenerator before issuing the query to find all configurations so that the runtime cost
        of doing so will be included in elapsedTime.
        (RunsGenerator::fetch_runs): Skip a row when its build and commit times are more than 366 days old.
        (RunsGenerator::format_run): Takes build_time and revisions as arguments since fetch_runs uses them now.
        (RunsGenerator::parse_revisions_array): Compute the max of commit times.

2015-11-20  Ryosuke Niwa  <rniwa@webkit.org>

        Remove chartPointRadius from interactive chart component
        https://bugs.webkit.org/show_bug.cgi?id=151480

        Reviewed by Darin Adler.

        Replaced the parameter by CSS rules.

        * public/v2/chart-pane.css:
        (.chart .dot):
        (.chart .dot.foreground):
        (.chart .highlight):
        (.chart .extent):
        * public/v2/index.html:
        * public/v2/interactive-chart.js:
        (App.InteractiveChartComponent.Ember.Component.extend._constructGraphIfPossible):
        (App.InteractiveChartComponent.Ember.Component.extend._highlightedItemsChanged):

2015-11-20  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard's runs API uses more than 128MB of memory
        https://bugs.webkit.org/show_bug.cgi?id=151478

        Reviewed by Andreas Kling.

        Don't fetch all query results at once to avoid using twice as much memory as needed.
        Use iterative API to format each result at a time.

        This change is also a 5% runtime performance gain.

        * public/api/runs.php:
        (RunsGenerator::__construct): Takes a Database instance instead of a list of configurations. The latter is
        no longer needed as we pass in each configuration type explicitly to fetch_runs.
        (RunsGenerator::fetch_runs): Renamed from add_runs since it now executes the database query via execute_query.
        Also moved the logic to compute the last modified time here.
        (RunsGenerator::execute_query): Moved from fetch_runs_for_config. Use Database::query instead of query_and_fetch_all.
        (RunsGeneratorForTestGroup):
        (RunsGeneratorForTestGroup::__construct):
        (RunsGeneratorForTestGroup::execute_query): Moved from fetch_runs_for_config_and_test_group.

        * public/include/db.php:
        (generate_data_file): Lock the file to avoid corruption.

2015-11-19  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard always fetches charts JSON twice
        https://bugs.webkit.org/show_bug.cgi?id=151483

        Reviewed by Andreas Kling.

        Only re-generate "runs" JSON via /api/runs/ when the cache doesn't exist in /data/ or the cached JSON is
        obsolete (shouldRefetch is set true) or corrupt (the second closure).

        * public/v2/app.js:
        (App.Pane._fetch):

2015-11-18  Ryosuke Niwa  <rniwa@webkit.org>

        Internal perf dashboard takes forever to load
        https://bugs.webkit.org/show_bug.cgi?id=151430

        Rubber-stamped by Antti Koivisto.

        Fix a few performance problems with the perf dashboard v2 UI.

        * public/v2/app.js:
        (App.DashboardRow._createPane): Set "inDashboard" to true.
        (App.Pane._fetch): Immediately show the cached chart instead of waiting for the refetched data which invokes
        a PHP JSON API. Also don't fetch the analysis tasks when the chart is shown in the dashboard since we don't
        show annotate charts in the dashboard.

2015-10-15  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed fix of a test after r190687.

        * tests/admin-regenerate-manifest.js:

2015-10-12  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard tools shouldn't require server credentials in multiple configuration files
        https://bugs.webkit.org/show_bug.cgi?id=149994

        Reviewed by Chris Dumez.

        Made detect-changes.js and pull-svn.py pull username and passwords from the server config JSON to reduce
        the number of JSON files that need to include credentials.

        Also made each script reload the server config after sleep to allow dynamic credential updates.

        In addition, change the server config JSON's format to include scheme, host, and port numbers separately
        instead of a url since detect-changes.js needs each value separately.

        This reduces the number of JSONs with credentials to two for our internal dashboard.

        * tools/detect-changes.js:
        (main): Added a property argument parsing. Now takes --server-config-json, --change-detection-config-json,
        and --seconds-to-sleep like other scripts.
        (parseArgument): Added.
        (fetchManifestAndAnalyzeData): Reload the server config JSON.
        (loadServerConfig): Added. Set settings.perfserver and settings.slave from the server config JSON. Also
        add settings.perfserver.host to match the old format.
        (configurationsForTesting): Fixed a bug that we throw an exception when a dashboard contains an empty cell.

        * tools/pull-os-versions.py:
        (main): Use load_server_config after each sleep.

        * tools/pull-svn.py:
        (main): Use load_server_config after each sleep.
        (fetch_commits_and_submit): Use the perf dashboard's auth as subversion credential when useServerAuth is set.

        * tools/sync-with-buildbot.py:
        (main): Use load_server_config after each sleep.

        * tools/util.py:
        (load_server_config): Extracted from python scripts. Computes server's url from scheme, host, and port number
        to match the old format python scripts except.

2015-10-11  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r190817.  Now that pull-os-versions store fake timestamps, we need to bypass timestamp
        checks for OS versions when bots try to report new results. Otherwise, we fail to process the reports
        with a MismatchingCommitTime error.

        * public/include/report-processor.php:
        (ReportProcessor::resolve_build_id):

2015-10-08  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard erroneously shows an old OS build in A/B testing range
        https://bugs.webkit.org/show_bug.cgi?id=149942

        Reviewed by Darin Adler.

        Ordering OS builds lexicologically turned out be a bad idea since 15A25 falls between 15A242 and 15A251.
        Use a fake/synthetic timestamp to force the commonly understood total order instead.

        Refactored pull-os-versions.py to share the server config JSON with other scripts. Also made the script
        support pulling multiple sources; e.g. both OS X and iOS.

        Also removed superfluous feature to submit results in chunks. The perf dashboard can handle thousands of
        revisions being submitted at once just fine.

        * public/api/commits.php:
        (main): A partial revert of r185574 since we no longer need to order builds lexicologically.

        * tools/pull-os-versions.py:
        (main): Takes --os-config-json, --server-config-json, and --seconds-to-sleep as arguments instead of
        a single --config argument to share the server config JSON with other scripts.
        (OSBuildFetcher): Extracted out of main. This class is instantiated for each OS kind (e.g. OS X).
        (OSBuildFetcher.__init__): Added.
        (OSBuildFetcher._fetch_available_builds): Extracted out of main. Fetches available builds from a website
        or custom commands.
        (OSBuildFetcher.fetch_and_report_new_builds): Extracted out of main. Submits the fetched builds after
        filtering out the ones we've already reported.
        (OSBuildFetcher._assign_fake_timestamps): Creates a fake timestamp to establish a total order amongst each
        OS X / iOS style build number such as 12A3456b.

2015-10-08  Ryosuke Niwa  <rniwa@webkit.org>

        pull-svn.py fails to sync revisions when SVN credentials is not setup
        https://bugs.webkit.org/show_bug.cgi?id=149941

        Reviewed by Chris Dumez.

        Added the support for specifying subversion credentials.

        Also added the support for pulling from multiple subversion servers. Subversion servers are specified
        in a JSON configuration file specified by --svn-config formatted as follows:

        [
            {
                "name": "WebKit",
                "url": "http://svn.webkit.org/repository/webkit",
                "username": "webkitten",
                "password": "webkitten's password",
                "trustCertificate": true,
                "accountNameFinderScript":
                    ["python", "/Volumes/Data/WebKit/Tools/Scripts/webkit-patch", "find-users"]
            },
            ...
        ]

        In addition, refactored it to use the shared server config JSON for the dashboard access.

        * tools/pull-svn.py:
        (main): Now takes --svn-config-json, --server-config-json, --seconds-to-sleep and --max-fetch-count
        as required options instead of seven unnamed arguments.
        (fetch_commits_and_submit): Extracted from main. Fetches at most max_fetch_count new revisions from
        the subversion server, and submits them in accordance with server_config.
        (fetch_commit_and_resolve_author): Now takes a single repository dictionary instead of two separate
        arguments for name and URL to pass down the repository's authentication info to fetch_commit.
        (fetch_commit): Ditto. Add appropriate arguments when username and passwords are specified.
        (resolve_author_name_from_account): Use a list argument instead of a single string argument now that
        the argument comes from a JSON instead of sys.argv.

2015-10-07  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed race condition fix. Exit early when xScale or yScale is not defined.

        * public/v2/interactive-chart.js:
        (App.InteractiveChartComponent._updateRangeBarRects):

2015-10-07  Ryosuke Niwa  <rniwa@webkit.org>

        Add a page that cycles through v2 dashboards
        https://bugs.webkit.org/show_bug.cgi?id=149907

        Reviewed by Chris Dumez.

        Add cycler.html that goes through each dashboard on v2 UI.

        This allows the dashboards to be cycled through on a TV screen.

        * public/cycler.html: Added.
        (loadURLAt): Appends a new iframe to load the next URL (i is the index of the dashboard to be shown)
        at the end of body. We don't immediately show the new iframe since it might take a while to load.
        (showNewFrameIfLoaded): Remove the current iframe and show the next iframe if the next dashboard has
        finished loading. We can't rely on DOMContentLoaded or load events because we use asynchronous XHR to
        load each chart's data. Instead, wait until some chart becomes available or fails to load and none of
        charts are still in progress to be shown.

2015-10-07  Ryosuke Niwa  <rniwa@webkit.org>

        Allow custom revisions to be specified in A/B testing
        https://bugs.webkit.org/show_bug.cgi?id=149905

        Reviewed by Chris Dumez.

        Allow custom revision number on each "repository" when creating a test group.

        * public/v2/app.css:
        (form .analysis-group [name=customValue]): Added.

        * public/v2/app.js:
        (App.AnalysisTaskController._createConfiguration): Added "Custom" as a revision option.
        Also added point labels such as (point 3) on "None" for when some points are missing revision info.
        (App.AnalysisTaskController._labelForPoints): Extracted from _createConfiguration.
        (App.AnalysisTaskController.actions.createTestGroup): Respect the custom revision number when custom
        revision option is selected.

        * public/v2/index.html: Added a text field for specifying a custom revision number.

2015-10-07  Ryosuke Niwa  <rniwa@webkit.org>

        Make the site name configurable in perf dashboard
        https://bugs.webkit.org/show_bug.cgi?id=149894

        Reviewed by Chris Dumez.

        Added "siteTitle" as a new configuration key to specify the site name.

        * public/include/db.php:
        (config): Now takes the default value as an argument.
        * public/include/manifest.php:
        (ManifestGenerator::generate): Include siteTitle in the manifest.
        * public/index.html: Update the title and the heading when the manifest is loaded.
        * public/v2/index.html: Use App.Manifest.siteTitle as the heading. document.title needs to be updated manually.
        * public/v2/manifest.js: 
        (App.MetricSerializer.normalizePayload): Update document.title and App.Manifest.siteTitle.

2015-10-07  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard doesn't show analysis tasks anchored at outliers
        https://bugs.webkit.org/show_bug.cgi?id=149870

        Reviewed by Chris Dumez.

        The bug was caused by the computation of start and end times of analysis tasks being dependent on
        time series provided to the interactive chart component even though they are already filtered.

        Since the interactive chart component shouldn't be messing with the underlying data models, moved
        the code to compute start and end times to App.Pane, to where it belongs, and made the moved code use
        the unfiltered time series newly exposed on ChartData.

        Also fixed a bug in fetch-from-remote.php which resulted in Ember endlessly fetching same JSON files.

        * public/admin/fetch-from-remote.php:
        (.): Use the full request URI for HTTP requests and caching. Otherwise, we're going to mix up caches
        and Ember can start hanging browsers (took me three hours to debug this).

        * public/v2/app.js:
        (App.Pane._showOutlierChanged): Added. Resets chartData when showOutlier flag has been changed.
        (App.Pane.fetchAnalyticRanges): The old code wasn't filtering analysis tasks by platforms and metrics
        at all since it relied on the server-side REST API to do the filtering, which I haven't implemented yet.
        Filter the results manually instead.
        (App.Pane.ranges): Moved the logic to compute startTime and endTime here from InteractiveChartComponent.
        (App.PaneController.toggleShowOutlier): Now that App.Pane responds to showOutlier changes, we don't
        need to call a private method on it.
        (App.AnalysisTaskController._chartDataChanged): When end points are not found, try showing outliers.
        This will cause chartData to be modified so just exit early and wait for getting called again.

        * public/v2/interactive-chart.js:
        (App.InteractiveChartComponent._rangesChanged): The code to compute start and end time has been moved
        to App.Pane.ranges.

        * public/v2/manifest.js:
        (App.Manifest._formatFetchedData): Added unfiltered time series as new properties as they are now used
        to compute the end points of analysis tasks when their end points are outliers.

2015-10-07  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed. Fix a typo in r190645.

        * public/include/db.php:

2015-10-06  Ryosuke Niwa  <rniwa@webkit.org>

        V2 UI shouldn't sort dashboards lexicologically
        https://bugs.webkit.org/show_bug.cgi?id=149856

        Reviewed by Chris Dumez.

        Don't sort the dashboards by name in App.Manifest.

        * public/v2/app.js:
        (App.IndexRoute.beforeModel): Don't transition to "undefined" (string) dashboard.
        * public/v2/manifest.js:
        (App.Manifest.._fetchedManifest):

2015-10-06  Ryosuke Niwa  <rniwa@webkit.org>

        V2 UI fails to show the data for the very first point in charts
        https://bugs.webkit.org/show_bug.cgi?id=149857

        Reviewed by Chris Dumez.

        The bug was caused by seriesBetweenPoints returning null for when point.seriesIndex is 0.
        Explicitly check the type of this property instead.

        * public/v2/data.js:
        (TimeSeries.prototype.seriesBetweenPoints):

2015-10-06  Ryosuke Niwa  <rniwa@webkit.org>

        Perf dashboard should have the capability to test local UI with production data
        https://bugs.webkit.org/show_bug.cgi?id=149834

        Reviewed by Chris Dumez.

        Added tools/run-with-remote-server.py which runs a local httpd server and pulls data from a remote server.

        * Install.md: Added the instruction on how to use the script. Also updated the remaining instructions
        for El Capitan.
        * config.json: Added remote server configurations.
        * public/admin/fetch-from-remote.php: Added. This script fetches JSON from the remote server specified in
        config.json and caches the results in the location specified as "cacheDirectory" in config.json.
        (main):
        (fetch_remote):
        * public/include/db.php:
        (config_path): Extracted from generate_data_file.
        (generate_data_file):
        * tools/remote-server-relay.conf: Added. Apache 2.4 configuration file for a local http server launched by
        run-with-remote-server.py.
        * tools/run-with-remote-server.py: Added. Launches Apache with the right set of directives.
        (main):
        (abspath_from_root):

2015-07-13  Ryosuke Niwa  <rniwa@webkit.org>

        Fix a typo.

        * public/js/helper-classes.js:

2015-06-27  Ryosuke Niwa  <rniwa@webkit.org>

        build-requests should use conform to JSON API format
        https://bugs.webkit.org/show_bug.cgi?id=146375

        Reviewed by Stephanie Lewis.

        Instead of returning single dictionary that maps root set id to a dictionary of repository names
        to revisions, timestamps, simply return root sets and roots "rows" or "objects" as defined in
        JSON API (http://jsonapi.org/). This API change makes it easier to resolve the bug 146374 and
        matches what we do in /api/test-groups.

        Also add the support for /api/build-requests/?id=<id> to fetch the build request with <id>.
        This is useful for debugging purposes.

        * public/api/build-requests.php:
        (main): Added the support for $_GET['id']. Also return "rootSets" and "roots".
        (update_builds): Extracted from main.

        * public/include/build-requests-fetcher.php:
        (BuildRequestFetcher::fetch_request): Added. Used for /api/build-requests/?id=<id>.
        (BuildRequestFetcher::results_internal): Always call fetch_roots_for_set_if_needed.
        (BuildRequestFetcher::fetch_roots_for_set_if_needed): Renamed from fetch_roots_for_set.
        Moved the logic to exit early when the root set had already been fetched here.

        * public/v2/analysis.js:
        (App.TestGroup._fetchTestResults): Fixed the bug that test groups without any successful results
        won't be shown.

        * tools/pull-os-versions.py:
        (main):
        (setup_auth): Moved to util.py

        * tools/sync-with-buildbot.py:
        (main): Replaced a bunch of perf dashboard related options by --server-config-json.
        (update_and_fetch_build_requests): No longer takes build_request_auth since that's now taken care
        of by setup_auth.
        (organize_root_sets_by_id_and_repository_names): Added. Builds the old rootsSets directory based
        on "roots" and "rootSets" dictionaries returned by /api/build-requests.
        (config_for_request): Fixed a bug that the script blows up when the build request is missing
        the repository specified in the configuration. This tolerance is necessary when a new repository
        dependency is added but we want to run A/B tests for old builds without the dependency.
        (fetch_json): No longer takes auth.

        * tools/util.py:
        (setup_auth): Moved from pull-os-versions.py to be shared with sync-with-buildbot.py.

2015-06-23  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix. A/B testing is broken when continuous builders report revisions out of order.

        * public/v2/app.js:
        (App.AnalysisTaskController.Ember.Controller.extend.):

2015-06-22  Ryosuke Niwa  <rniwa@webkit.org>