f981dd46b815a4f6a721a0286cd2be71ee2cfcc9
[WebKit.git] / WebKitTools / ChangeLog
1 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2
3         Reviewed by Adam Roben.
4
5         WinCairo build should not use link-time code generation (LTCG)
6         https://bugs.webkit.org/show_bug.cgi?id=50353
7
8         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
9         * DumpRenderTree/win/DumpRenderTree.vcproj:
10         * DumpRenderTree/win/ImageDiff.vcproj:
11         * FindSafari/FindSafari.vcproj:
12         * MiniBrowser/MiniBrowser.vcproj:
13         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
14         * WebKitAPITest/WebKitAPITest.vcproj:
15         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
16         * WebKitTestRunner/win/InjectedBundle.vcproj:
17         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
18         * WinLauncher/WinLauncher.vcproj:
19         * record-memory-win/record-memory-win.vcproj:
20
21 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
22
23         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
24         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
25         adding the file to the sources list was not enough to force the rebuild.
26
27         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
28         Remove an empty line at the end of this file to force a rebuild.
29
30 2010-12-01  Sam Weinig  <sam@webkit.org>
31
32         Fix windows build.
33
34         * MiniBrowser/win/BrowserView.cpp:
35         (BrowserView::create):
36
37 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
38
39         Add missing file to the TestNetscapePlugin sources list after r73057.
40
41         * GNUmakefile.am: Add missing file.
42
43 2010-12-01  Sam Weinig  <sam@webkit.org>
44
45         Reviewed by Anders Carlsson.
46
47         Add PageGrouping to WebKit2 API
48         https://bugs.webkit.org/show_bug.cgi?id=50332
49
50         - Update testing harnesses to deal with new PageGroup API.
51
52         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
53         (WKBundleInitialize):
54         * TestWebKitAPI/InjectedBundleController.cpp:
55         (TestWebKitAPI::InjectedBundleController::initialize):
56         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
57         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
58         * TestWebKitAPI/InjectedBundleController.h:
59         * TestWebKitAPI/InjectedBundleTest.h:
60         (TestWebKitAPI::InjectedBundleTest::initialize):
61         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
62         * TestWebKitAPI/PlatformUtilities.cpp:
63         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
64         * TestWebKitAPI/PlatformUtilities.h:
65         * TestWebKitAPI/PlatformWebView.h:
66         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
67         (TestWebKitAPI::TEST):
68         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
69         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
70         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
71         (TestWebKitAPI::PlatformWebView::PlatformWebView):
72         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
73         (TestWebKitAPI::PlatformWebView::PlatformWebView):
74         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
75         (WTR::InjectedBundle::didInitializePageGroup):
76         (WTR::InjectedBundle::initialize):
77         (WTR::InjectedBundle::beginTesting):
78         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
79         (WTR::InjectedBundle::pageGroup):
80         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
81         (WTR::LayoutTestController::addUserScript):
82         (WTR::LayoutTestController::addUserStyleSheet):
83         (WTR::LayoutTestController::setXSSAuditorEnabled):
84         * WebKitTestRunner/TestController.cpp:
85         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
86         (WTR::PlatformWebView::PlatformWebView):
87
88 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
89
90         Reviewed by Adam Roben.
91
92         vcproj changes can't be applied cleanly by the Windows EWS bot
93         https://bugs.webkit.org/show_bug.cgi?id=50328
94
95         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
96         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
97         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
98         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
99         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
100         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
101         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
102         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
103         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
104         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
105         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
106         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
107         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
108         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
109         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
110         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
111         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
112         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
113         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
114         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
115         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
116         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
117         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
118         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
119         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
120         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
121         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
122         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
123         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
124         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
125         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
126         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
127         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
128         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
129         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
130         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
131         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
132         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
133         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
134         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
135         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
136         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
137         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
138         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
139         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
140
141 2010-12-01  Anders Carlsson  <andersca@apple.com>
142
143         Reviewed by Darin Adler.
144
145         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
146         https://bugs.webkit.org/show_bug.cgi?id=50336
147
148         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
149         Add new test.
150
151         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
152         (PluginTest::NPP_New):
153         Add default implementation/
154
155         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
156         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
157         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
158         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
159         Get the user agent.
160
161         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
162         (NPP_New):
163         Call PluginTest::NPP_New.
164
165         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
166         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
167         Add new files.
168
169         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
170         (webkit_test_plugin_new_instance):
171         Call PluginTest::NPP_New.
172
173 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
174
175         [wx] Build fixes after recent trunk changes.
176
177         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
178         (LayoutTestController::findString):
179         * wx/build/settings.py:
180
181 2010-12-01  Dan Bernstein  <mitz@apple.com>
182
183         Reviewed by Darin Adler.
184
185         WebKitTestRunner needs layoutTestController.findString
186         https://bugs.webkit.org/show_bug.cgi?id=50238
187
188         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
189         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
190         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
191         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
192
193 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
194
195         Try using svn:eol-style native on a vcproj file.
196
197         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
198
199 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
200
201         Reviewed by Adam Roben.
202
203         [WINCE] Add WinCELauncher
204         https://bugs.webkit.org/show_bug.cgi?id=50217
205
206         * WinCELauncher/main.cpp: Added.
207
208 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
209
210         Reviewed by Kenneth Rohde Christiansen.
211
212         [Qt] Implement layoutTestController.findString
213         https://bugs.webkit.org/show_bug.cgi?id=50236
214
215         Add the missing function to the LayoutTestController.
216
217         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
218         (LayoutTestController::findString):
219         * DumpRenderTree/qt/LayoutTestControllerQt.h:
220
221 2010-11-30  Tony Chang  <tony@chromium.org>
222
223         Reviewed by Adam Barth.
224
225         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
226         https://bugs.webkit.org/show_bug.cgi?id=49036
227
228         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
229             for CppVariants.
230         (LayoutTestController::cppVariantToBool):
231         (LayoutTestController::cppVariantToInt32):
232         (LayoutTestController::setDatabaseQuota):
233         (LayoutTestController::evaluateInWebInspector):
234         (LayoutTestController::setMockGeolocationError):
235
236 2010-11-30  Eric Seidel  <eric@webkit.org>
237
238         Reviewed by Tony Chang.
239
240         update-webkit should call git fetch before git svn rebase
241         https://bugs.webkit.org/show_bug.cgi?id=50273
242
243         After discussion on webkit-dev, we've decided to move the "default"
244         git setup to pulling updates from git.webkit.org in preference
245         to rebuilding the local svn index using git svn fetch every time.
246
247         This change should have no effect on people using the "old" git setup
248         and should dramatically increase the speed of updates for those using
249         the "new" git setup along with update-webkit.  I'm about to move the
250         EWS and other queues over to this setup once this lands.
251
252         * Scripts/update-webkit:
253
254 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
255
256         Reviewed by Xan Lopez.
257
258         GTK: AX: implement press in DRT
259         https://bugs.webkit.org/show_bug.cgi?id=36146
260
261         Implement AccessibilityUIElement::press() for GTK.
262
263         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
264         (AccessibilityUIElement::press): Implemented.
265
266 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
267
268         Reviewed by Tony Chang.
269
270         config.webkit_base_dir returns a path with a trailing slash
271         https://bugs.webkit.org/show_bug.cgi?id=50197
272         
273         config.webkit_base_dir() should return a path without a trailing slash,
274         like all the other methods that return paths.
275         
276         Undoes MockFileSytem changes by r72640, since they're no longer
277         necessary for GetBaselinesTest to pass.
278
279         * Scripts/webkitpy/common/system/filesystem_mock.py:
280         * Scripts/webkitpy/layout_tests/port/base.py:
281         * Scripts/webkitpy/layout_tests/port/config.py:
282         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
283
284 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
285
286         Reviewed by Tony Chang.
287
288         Rebaseline server: baseline display tweaks
289         https://bugs.webkit.org/show_bug.cgi?id=50207
290         
291         Determine which baselines were used when running the tests and highlight
292         them in the UI. Sort platform names alphabetically.
293         
294         Also makes the server URL be launched in the user's browser
295         automatically.
296
297         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
298         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
299         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
300         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
301         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
302
303 2010-11-30  Dan Bernstein  <mitz@apple.com>
304
305         Reviewed by Anders Carlsson.
306
307         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
308         https://bugs.webkit.org/show_bug.cgi?id=50238
309
310         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
311         (WTR::LayoutTestController::findString): Added.
312         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
313
314 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
315
316         Reviewed by Adam Roben.
317
318         All projects on Windows should use cmd files for build events
319         https://bugs.webkit.org/show_bug.cgi?id=50213
320
321         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
322         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
323         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
324         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
325         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
326         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
327         * DumpRenderTree/win/ImageDiffCommon.vsprops:
328         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
329         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
330         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
331         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
332         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
333         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
334         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
335         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
336         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
337         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
338         * WebKitAPITest/WebKitAPITestCommon.vsprops:
339         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
340         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
341         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
342         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
343         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
344         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
345         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
346         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
347         * WinLauncher/WinLauncherCommon.vsprops:
348         * WinLauncher/WinLauncherPostBuild.cmd: Added.
349         * WinLauncher/WinLauncherPreBuild.cmd: Added.
350
351 2010-11-29  Dan Bernstein  <mitz@apple.com>
352
353         GTK DumpRenderTree build fix after r72887.
354
355         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
356         (LayoutTestController::findString):
357
358 2010-11-29  Dan Bernstein  <mitz@apple.com>
359
360         Windows DumpRenderTree build fix after r72887.
361
362         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
363         (LayoutTestController::findString): Added empty implementation.
364
365 2010-11-29  Dan Bernstein  <mitz@apple.com>
366
367         Reviewed by Darin Adler.
368
369         DumpRenderTree changes for testing the text search API.
370         https://bugs.webkit.org/show_bug.cgi?id=50038
371
372         * DumpRenderTree/LayoutTestController.cpp:
373         (findStringCallback):
374         (LayoutTestController::staticFunctions):
375         * DumpRenderTree/LayoutTestController.h:
376         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
377         (LayoutTestController::findString):
378         * MiniBrowser/mac/BrowserWindowController.m:
379         (-[BrowserWindowController find:]):
380
381 2010-11-29  Johnny Ding  <jnd@chromium.org>
382
383         Unreviewed: Add myself to the list of Committers.
384
385         * Scripts/webkitpy/common/config/committers.py:
386
387 2010-11-29  Mark Rowe  <mrowe@apple.com>
388
389         Reviewed by Adele Peterson.
390
391         <rdar://problem/8694997> DumpRenderTree fails to build.
392
393         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
394
395 2010-11-29  Mark Rowe  <mrowe@apple.com>
396
397         Reviewed by Adele Peterson.
398
399         <rdar://problem/8694997> DumpRenderTree fails to build.
400
401         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
402         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
403         * DumpRenderTree/mac/PerlSupport/Makefile:
404
405 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
406
407         Reviewed by Martin Robinson.
408
409         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
410         https://bugs.webkit.org/show_bug.cgi?id=50154
411
412         Added missing checks to allAttributes().
413
414         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
415         (AccessibilityUIElement::allAttributes): Added missing checks.
416
417 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
418
419         Reviewed by Kenneth Rohde Christiansen.
420
421         [Qt] Allow pre-generation for package builds for WebKit2
422         https://bugs.webkit.org/show_bug.cgi?id=50139
423
424         Use a build variable for the generated directory path and set the
425         value based on CONFIG just like for WebKit1.
426
427         For non-package builds use a relative base path for the
428         genrated directory just like for WebKit1.
429
430         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
431         * WebKitTestRunner/qt/WebKitTestRunner.pro:
432
433 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
434
435         Reviewed by Kenneth Rohde Christiansen.
436
437         [Qt] Move some build logic from Qt to platform independent code
438         https://bugs.webkit.org/show_bug.cgi?id=50134
439
440         Create target directories inside generate-forwarding-headers.pl.
441
442         * Scripts/generate-forwarding-headers.pl:
443
444 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
445
446         Reviewed by Martin Robinson.
447
448         [GTK] Windowless plugins gets broken key input
449         https://bugs.webkit.org/show_bug.cgi?id=49927
450
451         Convert the XEvent::keycode to ASCII before printing it. Not
452         doing this was causing false positive in 
453         plugins/keyboard-events.html.
454
455         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
456         (keycode_to_char):
457         (webkit_test_plugin_handle_event):
458
459 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
460
461         Reviewed by Antonio Gomes.
462
463         [Qt] Html autofocus not working with QGraphicsWebView
464         https://bugs.webkit.org/show_bug.cgi?id=43169
465
466         Tell the scene to set the webview item as the currently
467         focused item. This makes the input field with autofocus get
468         focus as it should.
469
470         * QtTestBrowser/webview.cpp:
471         (WebViewGraphicsBased::WebViewGraphicsBased):
472
473 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
474
475         Reviewed by Tony Chang.
476
477         nrwt - clean up create_driver interface and print out the
478         command line used for DumpRenderTree/TestShell.
479
480         This patch adds a driver_cmd_line() call to the Port class in
481         order to retrive the command line to print it out (as part of
482         --print config).
483
484         In addition, this patch cleans up the Port.create_driver()
485         signature and the Driver constructor interface to take a worker
486         number and no longer require the image_path argument (Chromium's
487         drivers now synthesize the image_path from the worker number
488         internally).
489
490         https://bugs.webkit.org/show_bug.cgi?id=49934
491
492         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
493         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
494         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
495         * Scripts/webkitpy/layout_tests/port/base.py:
496         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
497         * Scripts/webkitpy/layout_tests/port/chromium.py:
498         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
499         * Scripts/webkitpy/layout_tests/port/dryrun.py:
500         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
501         * Scripts/webkitpy/layout_tests/port/test.py:
502         * Scripts/webkitpy/layout_tests/port/webkit.py:
503         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
504         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
505
506 2010-11-24  Ojan Vafai  <ojan@chromium.org>
507
508         Reviewed by Tony Chang.
509
510         [chromium] improve memory usage for test results server and store fewer runs
511         https://bugs.webkit.org/show_bug.cgi?id=50035
512
513         Store fewer runs and don't pass full files around when we only need bools.
514         Greatly improves error rates on test-results.appspot.com.
515
516         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
517         * TestResultServer/handlers/testfilehandler.py:
518         * TestResultServer/model/dashboardfile.py:
519         * TestResultServer/model/jsonresults.py:
520
521 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
522
523         Reviewed by Tony Chang.
524
525         This patch implements the first part of the manager side of the
526         Broker objects - it handles creating threads, waiting for them
527         to complete, and running a single-threaded loop as well.
528
529         https://bugs.webkit.org/show_bug.cgi?id=49779
530
531         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
532         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
533         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
534         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
535
536 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
537
538         Reviewed by David Levin.
539
540         DRT should not generate pixel output for text/plain tests
541         https://bugs.webkit.org/show_bug.cgi?id=50002
542         
543         Modify Mac, Windows and GTK DRT implementations to disable pixel output
544         when encountering a text/plain response (the Chromium one already does
545         this, and none of the other ports special-case text/plain output in
546         the first place).
547
548         * DumpRenderTree/gtk/DumpRenderTree.cpp:
549         (dump):
550         * DumpRenderTree/mac/DumpRenderTree.mm:
551         (dump):
552         * DumpRenderTree/win/DumpRenderTree.cpp:
553         (dump):
554
555 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
556
557         Unreviewed.
558
559         Add my other email address to committers.py.
560
561         * Scripts/webkitpy/common/config/committers.py:
562
563 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
564
565         Reviewed by Csaba Osztrogonác.
566
567         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
568         https://bugs.webkit.org/show_bug.cgi?id=49975
569
570         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
571         to enable the script to define it 0 in case of a minimal build.
572
573 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
574
575         Reviewed by Xan Lopez.
576
577         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
578         https://bugs.webkit.org/show_bug.cgi?id=49143
579
580         * DumpRenderTree/gtk/DumpRenderTree.cpp:
581         (createWebView): Call the new connectEditingCallbacks function.
582         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
583         (dumpNodePath):
584         (dumpRange):
585         (insertActionString):
586         (selectionAffinityString):
587         (shouldBeginEditing):
588         (shouldEndEditing):
589         (shouldInsertNode):
590         (shouldInsertText):
591         (shouldDeleteRange):
592         (shouldShowDeleteInterfaceForElement):
593         (shouldChangeSelectedRange):
594         (shouldApplyStyle):
595         (editingBegan):
596         (userChangedContents):
597         (editingEnded):
598         (selectionChanged):
599         (connectEditingCallbacks):
600         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
601         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
602
603 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
604
605         Reviewed by Andreas Kling.
606
607         [Qt] Make QtTestBrowser remember the selected user agent
608         https://bugs.webkit.org/show_bug.cgi?id=50021
609
610         Set user agent for a new page by using the old page's
611
612         * QtTestBrowser/mainwindow.cpp:
613         (MainWindow::setPage):
614
615 2010-11-24 Patrick Gansterer <paroga@webkit.org>
616
617         Reviewed by Csaba Osztrogonác.
618
619         Remove Bakefile build system files
620         https://bugs.webkit.org/show_bug.cgi?id=49983
621
622         r53757 only removed the content, but not the files.
623         This patch removes that empty files.
624
625         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
626         * wx/browser/browser.bkl: Removed.
627         * wx/build-wxwebkit: Removed.
628
629 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
630
631         Reviewed by Tony Chang.
632
633         This patch cleans up the logic used to shard tests into groups a
634         bit and adds the --worker-model flag to NRWT. The flag is only
635         used at the moment to control whether to run single-threaded or
636         not, but eventually will also allow toggling between threads and
637         processes.
638
639         Also add a minor cleanup with _test_is_slow(), which just
640         eliminates some repetition and gives slightly better encapsulation.
641
642         https://bugs.webkit.org/show_bug.cgi?id=49773
643
644         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
645         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
646
647 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
648
649         Reviewed by Tony Chang.
650
651         Rebaseline server: list current baselines and platforms
652         https://bugs.webkit.org/show_bug.cgi?id=49991
653         
654         List existing baselines (with Trac links) for tests.
655         
656         Add dropdowns for choosing with platform baselines to target (and what
657         to do with existing ones).
658
659         Also fix MockFileSystem.join to behave more like os.path.join (unit
660         test was ending up with two consecutive slashes in a layout test
661         path).        
662
663         * Scripts/webkitpy/common/system/filesystem_mock.py:
664         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
665         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
666         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
667         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
668         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
669         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
670         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
671
672 2010-11-23  Ojan Vafai  <ojan@chromium.org>
673
674         Reviewed by Tony Chang.
675
676         remove timeout argument to urlopen
677         https://bugs.webkit.org/show_bug.cgi?id=49995
678
679         Apparently the version of python we have on the bots doesn't accept a timeout argument.
680
681         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
682
683 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
684
685         Unreviewed, rolling out r72628.
686         http://trac.webkit.org/changeset/72628
687         https://bugs.webkit.org/show_bug.cgi?id=49994
688
689         This patch is causing layout-test failtures on GTK Linux
690         64-bit Debug (Requested by ctguil on #webkit).
691
692         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
693         (AccessibilityUIElement::AccessibilityUIElement):
694         (AccessibilityUIElement::parentElementCallback):
695         * DumpRenderTree/chromium/AccessibilityUIElement.h:
696         * DumpRenderTree/chromium/CppBoundClass.cpp:
697         * DumpRenderTree/chromium/CppBoundClass.h:
698
699 2010-11-22  Ojan Vafai  <ojan@chromium.org>
700
701         Reviewed by Tony Chang.
702
703         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
704         https://bugs.webkit.org/show_bug.cgi?id=49944
705
706         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
707
708 2010-11-23  Chris Guillory  <chris.guillory@google.com>
709
710         Reviewed by Dimitri Glazkov.
711
712         Include the FrameView widget of a RenderWidget in the accessibility tree.
713         https://bugs.webkit.org/show_bug.cgi?id=49106
714
715         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
716         (AccessibilityUIElement::AccessibilityUIElement):
717         (AccessibilityUIElement::parentElementCallback):
718         (AccessibilityUIElement::isEqualCallback):
719         * DumpRenderTree/chromium/AccessibilityUIElement.h:
720         * DumpRenderTree/chromium/CppBoundClass.cpp:
721         (CppBoundClass::getFromCppVariant):
722         * DumpRenderTree/chromium/CppBoundClass.h:
723
724 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
725
726         Reviewed by Kenneth Rohde Christiansen.
727
728         [EFL] Add tiled backing store to EWebLauncher
729         https://bugs.webkit.org/show_bug.cgi?id=45777
730
731         Allow EWebLauncher to choose between single and tiled backing store
732
733         * EWebLauncher/main.c:
734         (on_key_down):
735         (browserCreate):
736         (main):
737
738 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
739
740         Reviewed by Tor Arne Vestbø.
741
742         [Qt] Review the setUserPermission & friends API
743         https://bugs.webkit.org/show_bug.cgi?id=46810
744
745         Renamed requestPermissionFromUser to featurePermissionRequested
746         and cancelRequestsForPermission to featurePermissionRequestCanceled.
747
748         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
749         (WebCore::WebPage::WebPage):
750         * QtTestBrowser/webpage.cpp:
751         (WebPage::WebPage):
752         (WebPage::featurePermissionRequestCanceled):
753         * QtTestBrowser/webpage.h:
754
755 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
756
757         Reviewed by Tor Arne Vestbø.
758
759         [Qt] Review the setUserPermission & friends API
760         https://bugs.webkit.org/show_bug.cgi?id=46810
761
762         Rename setUserPermission to setFeaturePermission
763
764         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
765         (WebCore::WebPage::requestPermission):
766         (WebCore::WebPage::permissionSet):
767         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
768         (LayoutTestController::grantDesktopNotificationPermission):
769         * QtTestBrowser/webpage.cpp:
770         (WebPage::requestPermission):
771
772 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
773
774         Reviewed by Tor Arne Vestbø.
775
776         [Qt] Review the setUserPermission & friends API
777         https://bugs.webkit.org/show_bug.cgi?id=46810
778
779         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
780         and GeolocationPermissionDomain to Geolocation.
781
782         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
783         (WebCore::WebPage::WebPage):
784         (WebCore::WebPage::requestPermission):
785         (WebCore::WebPage::cancelPermission):
786         (WebCore::WebPage::permissionSet):
787         (WebCore::DumpRenderTree::geolocationPermissionSet):
788         * DumpRenderTree/qt/DumpRenderTreeQt.h:
789         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
790         (LayoutTestController::grantDesktopNotificationPermission):
791         * QtTestBrowser/webpage.cpp:
792         (WebPage::WebPage):
793         (WebPage::requestPermission):
794         (WebPage::cancelRequestsForPermission):
795         * QtTestBrowser/webpage.h:
796
797 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
798
799         Reviewed by Tor Arne Vestbø.
800
801         [Qt] Review the setUserPermission & friends API
802         https://bugs.webkit.org/show_bug.cgi?id=46810
803
804         Add a ByUser suffix to PermissionGranted/Denied. In the future
805         we can add PermissionGrantedByDefault.
806
807
808         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
809         (WebCore::WebPage::requestPermission):
810         (WebCore::WebPage::permissionSet):
811         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
812         (LayoutTestController::grantDesktopNotificationPermission):
813         * QtTestBrowser/webpage.cpp:
814         (WebPage::requestPermission):
815
816 2010-11-18  Satish Sampath  <satish@chromium.org>
817
818         Reviewed by Jeremy Orlow.
819
820         For speech input event, send an event object containing all the recognition results and metadata.
821         https://bugs.webkit.org/show_bug.cgi?id=49736
822
823         Updated DRT by renaming the mock result method on all platforms to the new signature.
824
825         * DumpRenderTree/LayoutTestController.cpp:
826         (addMockSpeechInputResultCallback):
827         (LayoutTestController::staticFunctions):
828         * DumpRenderTree/LayoutTestController.h:
829         * DumpRenderTree/chromium/LayoutTestController.cpp:
830         (LayoutTestController::LayoutTestController):
831         (LayoutTestController::addMockSpeechInputResult):
832         * DumpRenderTree/chromium/LayoutTestController.h:
833         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
834         (LayoutTestController::addMockSpeechInputResult):
835         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
836         (LayoutTestController::addMockSpeechInputResult):
837         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
838         (LayoutTestController::addMockSpeechInputResult):
839         * DumpRenderTree/qt/LayoutTestControllerQt.h:
840         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
841         (LayoutTestController::addMockSpeechInputResult):
842         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
843         (LayoutTestController::addMockSpeechInputResult):
844
845 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
846
847         Reviewed by Tony Chang.
848
849         Fix some spacing issues with log messages with
850         new-run-webkit-tests --verbose.
851
852         https://bugs.webkit.org/show_bug.cgi?id=49936
853
854         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
855
856 2010-11-22  Ojan Vafai  <ojan@chromium.org>
857
858         Reviewed by Adam Barth.
859
860         update scm to work with different remote branches
861         https://bugs.webkit.org/show_bug.cgi?id=49949
862
863         This works if there are multiple svn tracking branches
864         and/or if the tracking branch is refs/remots/origin/master
865         instead of refs/remotes/trunk which is the direction we're trying
866         to head since that makes fetches faster.
867
868         * Scripts/webkitpy/common/checkout/scm.py:
869         * Scripts/webkitpy/common/checkout/scm_unittest.py:
870
871 2010-11-22  Hayato Ito  <hayato@chromium.org>
872
873         Reviewed by Shinichiro Hamaji.
874
875         Ignore reference files which will be used by reftests when collecting
876         test cases.
877         https://bugs.webkit.org/show_bug.cgi?id=49835
878
879         * Scripts/webkitpy/layout_tests/port/test_files.py:
880         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
881
882 2010-11-22  Adam Roben  <aroben@apple.com>
883
884         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
885
886         Apple's Windows build allows placing header files and import libraries for WebKit's
887         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
888         $WebKitLibrariesDir environment variable. This is both required for production builds and
889         convenient for Apple-internal developer builds. Apple's production builds also require that
890         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
891         builds, the files are copied into that directory tree by the
892         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
893         copying is done by
894         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
895
896         This .vsprops copying is problematic in one very important case: when a developer updates
897         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
898         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
899         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
900         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
901         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
902         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
903
904         To fix this, we now use normal relative paths to access the .vsprops files in the source
905         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
906         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
907         unset, so the normal relative paths are used to read the .vsprops files out of the source
908         tree directly. In production builds, this environment variable is set to a fake directory
909         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
910         is resolved.
911         
912         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
913
914         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
915
916         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
917         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
918         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
919         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
920         FeatureDefines.vsprops becomes:
921
922         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
923
924         which resolves to:
925
926         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
927
928         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
929         actually exist since they are matched by an equal number of ".." path components.)
930
931         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
932         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
933
934         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
935         updated
936
937         Reviewed by Dave Hyatt.
938
939         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
940         * DumpRenderTree/win/DumpRenderTree.vcproj:
941         * DumpRenderTree/win/ImageDiff.vcproj:
942         * FindSafari/FindSafari.vcproj:
943         * MiniBrowser/MiniBrowser.vcproj:
944         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
945         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
946         * WebKitAPITest/WebKitAPITest.vcproj:
947         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
948         * WebKitTestRunner/win/InjectedBundle.vcproj:
949         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
950         * WinLauncher/WinLauncher.vcproj:
951         * record-memory-win/record-memory-win.vcproj:
952         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
953         files.
954
955 2010-11-22  Adam Roben  <aroben@apple.com>
956
957         Make it possible to run tests on Windows without Visual Studio or VC++
958         Express installed
959
960         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
961         are not installed. But this function doesn't need to be called when we
962         already have a build available and are just trying to run the tests.
963
964         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
965         because Visual Studio/VC++ Express aren't installed
966
967         Reviewed by Dave Hyatt.
968
969         * Scripts/webkitdirs.pm:
970         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
971         it is not needed by this function. Also added a FIXME.
972
973         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
974         relying on determineConfigurationForVisualStudio doing it.
975
976 2010-11-19  Hayato Ito  <hayato@chromium.org>
977
978         Reviewed by Shinichiro Hamaji.
979
980         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
981
982         https://bugs.webkit.org/show_bug.cgi?id=49812
983
984         * Scripts/webkitpy/layout_tests/driver_test.py:
985         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
986         * Scripts/webkitpy/layout_tests/port/base.py:
987         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
988         * Scripts/webkitpy/layout_tests/port/chromium.py:
989         * Scripts/webkitpy/layout_tests/port/dryrun.py:
990         * Scripts/webkitpy/layout_tests/port/test.py:
991         * Scripts/webkitpy/layout_tests/port/webkit.py:
992         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
993         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
994
995 2010-11-22  Hayato Ito  <hayato@chromium.org>
996
997         Reviewed by Tony Chang.
998
999         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1000
1001         https://bugs.webkit.org/show_bug.cgi?id=49924
1002
1003         * Scripts/webkitpy/layout_tests/port/chromium.py:
1004
1005 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1006
1007         Reviewed by Kenneth Rohde Christiansen.
1008
1009         Fix EWebLauncher zoom discretization
1010         https://bugs.webkit.org/show_bug.cgi?id=49810
1011
1012         * EWebLauncher/main.c:
1013         (nearest_zoom_level_get):
1014         (zoom_level_set):
1015         (on_load_finished):
1016         (on_key_down):
1017
1018 2010-11-21  Sam Weinig  <sam@webkit.org>
1019
1020         Rubber-stamped by Dan Bernstein.
1021
1022         Fix ~300 WebKit2 tests by enabling developer extras preference.
1023
1024         * WebKitTestRunner/TestController.cpp:
1025         (WTR::TestController::resetStateToConsistentValues):
1026
1027 2010-11-21  Sam Weinig  <sam@webkit.org>
1028
1029         Reviewed by Dan Bernstein.
1030
1031         Textareas should be resizable by default
1032         https://bugs.webkit.org/show_bug.cgi?id=49892
1033
1034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1035         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1036         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1037         Add preferences test.
1038
1039 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1040
1041         Reviewed by Tony Chang.
1042
1043         Rebaseline server: checksum-only differences and prefetching
1044         https://bugs.webkit.org/show_bug.cgi?id=49841
1045         
1046         Add support for image test results where the only difference is in the
1047         checksum.
1048         
1049         Add prefetching of the image results from the next test.
1050         
1051         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1052         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1053         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1054
1055 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1056
1057         Reviewed by Tony Chang.
1058
1059         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1060
1061         Add the 'worker number' and 'worker name' concepts to the 
1062         TestShellThread objects, and move test_types and test_args from
1063         the TestRunner to the TestShellThread.
1064
1065         https://bugs.webkit.org/show_bug.cgi?id=49768
1066
1067         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1068         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1069
1070 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1071
1072         Reviewed by Ojan Vafai.
1073
1074         Do some minor cleanup and bug fixing.
1075
1076         https://bugs.webkit.org/show_bug.cgi?id=49777
1077
1078         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1079         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1080
1081 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1082
1083         Reviewed by Ojan Vafai.
1084
1085         nrwt - config.build_directory() is busted
1086
1087         Fixes a typo that was causing us to usually return the top level
1088         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1089         bug was hidden by test stubs that were too simplistic :(.
1090
1091         https://bugs.webkit.org/show_bug.cgi?id=49815
1092
1093         * Scripts/webkitpy/common/system/executive_mock.py:
1094         * Scripts/webkitpy/layout_tests/port/config.py:
1095         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1096
1097 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1098
1099         Reviewed by Adam Roben.
1100
1101         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1102         https://bugs.webkit.org/show_bug.cgi?id=49819
1103
1104         * DumpRenderTree/DumpRenderTree.sln:
1105         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1106         * DumpRenderTree/win/DumpRenderTree.vcproj:
1107         * DumpRenderTree/win/ImageDiff.vcproj:
1108         * FindSafari/FindSafari.vcproj:
1109         * MiniBrowser/MiniBrowser.vcproj:
1110         * TestWebKitAPI/win/TestWebKitAPI.sln:
1111         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1112         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1113         * WebKitAPITest/WebKitAPITest.vcproj:
1114         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1115         * WebKitTestRunner/win/InjectedBundle.vcproj:
1116         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1117         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1118         * WinLauncher/WinLauncher.vcproj:
1119         * record-memory-win/record-memory-win.vcproj:
1120
1121 2010-11-19  Adam Roben  <aroben@apple.com>
1122
1123         Add some more Windows slaves
1124
1125         This is probably more than we will be using in the immediate future,
1126         but having some extra slave names makes experimenting with different
1127         configurations easier.
1128
1129         Reviewed by Jon Honeycutt.
1130
1131         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1132         Windows slaves and distributed them among the three different Test
1133         builders.
1134
1135 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1136
1137         Reviewed by Ojan Vafai.
1138
1139         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1140         https://bugs.webkit.org/show_bug.cgi?id=49702
1141
1142         Re-landing r72357 with a test fix.
1143
1144         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1145         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1146         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1147
1148 2010-11-19  Avi Drissman  <avi@google.com>
1149
1150         Reviewed by Antonio Gomes.
1151
1152         Complete support for Unix editing mode
1153         https://bugs.webkit.org/show_bug.cgi?id=49757
1154
1155         * DumpRenderTree/LayoutTestController.cpp:
1156         (setEditingBehaviorCallback):
1157         * DumpRenderTree/chromium/LayoutTestController.cpp:
1158         (LayoutTestController::setEditingBehavior):
1159
1160 2010-11-19  Adam Roben  <aroben@apple.com>
1161
1162         Fix run-javascriptcore-tests when there's a space in the path to
1163         testapi
1164
1165         Reviewed by Sam Weinig.
1166
1167         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1168         system() to force it to interpret spaces in the path correctly.
1169
1170 2010-11-19  Adam Roben  <aroben@apple.com>
1171
1172         Update scripts for .exe name changes after r72327
1173
1174         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1175
1176         Reviewed by Sam Weinig.
1177
1178         * Scripts/run-javascriptcore-tests:
1179         (testapiPath):
1180
1181         * Scripts/sunspider-compare-results:
1182         (pathToBuiltJSC):
1183
1184         * Scripts/webkitdirs.pm:
1185         (jscPath):
1186         (safariPath):
1187
1188 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1189
1190         Reviewed by Darin Adler.
1191
1192         Normalize Cairo/CFLite project/solution configuration names
1193         https://bugs.webkit.org/show_bug.cgi?id=49818
1194
1195         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1196         * DumpRenderTree/win/DumpRenderTree.vcproj:
1197         * DumpRenderTree/win/ImageDiff.vcproj:
1198         * MiniBrowser/MiniBrowser.vcproj:
1199         * TestWebKitAPI/win/TestWebKitAPI.sln:
1200         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1201         * WebKitAPITest/WebKitAPITest.vcproj:
1202         * WebKitTestRunner/win/InjectedBundle.vcproj:
1203         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1204         * WinLauncher/WinLauncher.vcproj:
1205         * Scripts/webkitdirs.pm: Updated cairo build configs.
1206
1207 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1208
1209         Reviewed by Adam Roben.
1210
1211         Windows vcproj configuration names should be normalized across projects
1212         https://bugs.webkit.org/show_bug.cgi?id=49776
1213
1214         * DumpRenderTree/DumpRenderTree.sln:
1215         * FindSafari/FindSafari.vcproj:
1216         * TestWebKitAPI/win/TestWebKitAPI.sln:
1217         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1218         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
1219         * WebKitAPITest/WebKitAPITest.vcproj:
1220         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1221         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1222         * WebKitTestRunner/WebKitTestRunner.sln:
1223         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1224         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
1225         * record-memory-win/record-memory-win.vcproj:
1226
1227 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1228
1229         Build fix - as per DRT-mac, always enabled developer extras,
1230         in win/qt/gtk DRT.
1231
1232         This is necessary to enable rich exception messages to be generated
1233         following https://bugs.webkit.org/show_bug.cgi?id=49708.
1234
1235         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1236         (shouldEnableDeveloperExtras):
1237         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1238         (WebCore::shouldEnableDeveloperExtras):
1239         * DumpRenderTree/win/DumpRenderTree.cpp:
1240         (shouldEnableDeveloperExtras):
1241
1242 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1243
1244         Unreviewed, rolling out r72357.
1245         http://trac.webkit.org/changeset/72357
1246         https://bugs.webkit.org/show_bug.cgi?id=49784
1247
1248         It broke test-webkitpy tests since the patch didn't have the
1249         corresponding test update (Requested by kinuko on #webkit).
1250
1251         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1252         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1253
1254 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
1255
1256         Reviewed by Tony Chang.
1257
1258         Rebaseline server: add rebaseline queue
1259         https://bugs.webkit.org/show_bug.cgi?id=49763
1260         
1261         Add a UI queue (a multi-item <select>) where tests to be baselined
1262         can be enqueued (also supports basic removal). A queue is used instead
1263         of immediately doing rebaselines since SCM operations can take a while.
1264         It's better to go through lots of tests quickly to mark them as
1265         needing rebaselining and then batch the SCM operations.
1266         
1267         Also adds a simple log where results can be displayed.
1268
1269         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1270         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1271         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1272         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
1273         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1274         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1275
1276 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1277
1278         Reviewed by Oliver Hunt.
1279
1280         Bug 49708 - Stop recompiling functions to regenerate exception info.
1281
1282         Instead only hold info as necessary – keep divot info is the inspector
1283         is enabled, line number info is debugging or profiling, and handler
1284         info for functions with try/catch.
1285
1286         * DumpRenderTree/mac/DumpRenderTree.mm:
1287         (shouldEnableDeveloperExtras):
1288             - always enable the developer tools from DRT, to ensure we
1289               produce rich error messages on JavaScript exceptions.
1290
1291 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
1292
1293         Reviewed by Ojan Vafai.
1294
1295         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1296         https://bugs.webkit.org/show_bug.cgi?id=49702
1297
1298         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1299         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1300
1301 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
1302
1303         Reviewed by Tony Chang.
1304
1305         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
1306
1307         Create the first version of the 'message_broker' package. This
1308         class will encapsulate all of the threading/multiprocessing and
1309         message-sending details for the communication between the
1310         'manager' object and the 'worker' objects. For the moment, it
1311         just holds some routines and tests for logging thread stacks.
1312
1313         There should be no functional changes in this patch, just moving stuff
1314         around.
1315
1316         https://bugs.webkit.org/show_bug.cgi?id=49707
1317
1318         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1319         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
1320         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
1321         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
1322         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1323         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1324
1325 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1326
1327         Reviewed by Adam Roben.
1328
1329         Remove leftover Windows Debug_Internal configurations
1330         https://bugs.webkit.org/show_bug.cgi?id=49758
1331
1332         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1333         * DumpRenderTree/win/DumpRenderTree.vcproj:
1334         * DumpRenderTree/win/ImageDiff.vcproj:
1335         * MiniBrowser/MiniBrowser.vcproj:
1336         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1337         * WebKitAPITest/WebKitAPITest.vcproj:
1338         * WebKitTestRunner/win/InjectedBundle.vcproj:
1339         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1340         * WinLauncher/WinLauncher.vcproj:
1341
1342 2010-11-18  Adam Roben  <aroben@apple.com>
1343
1344         Add three new Windows XP build slaves
1345
1346         Reviewed by Steve Falkenburg.
1347
1348         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
1349         new slaves, and added them to the Windows XP Debug (Tests) builder.
1350
1351 2010-11-18  Daniel Bates  <dbates@rim.com>
1352
1353         Reviewed by Adam Roben.
1354
1355         update-webkit-support-libs should fall back to existing
1356         WebKitSupportLibrary version if there is no internet connectivity
1357         https://bugs.webkit.org/show_bug.cgi?id=49503
1358
1359         Fall back to existing support libraries (if present) when there is
1360         no internet connection.
1361
1362         Currently, update-webkit-support-libs dies with an "out-of-date"
1363         error when there is no internet connection because it cannot
1364         retrieve versioning information from developer.apple.com. Because
1365         update-webkit-support-libs fails, build-webkit fails. Instead,
1366         if there is no internet connection and the support libraries are
1367         present then we should warn the user and exit() with success so
1368         that build-webkit can work without an internet connection.
1369
1370         * Scripts/update-webkit-support-libs:
1371
1372 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1373
1374         Reviewed by Adam Roben.
1375
1376         Debug_Internal Windows configuration is unnecessary, should be removed
1377         https://bugs.webkit.org/show_bug.cgi?id=49753
1378
1379         * DumpRenderTree/win/DumpRenderTree.cpp:
1380         * MiniBrowser/win/stdafx.h:
1381         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1382         * WebKitTestRunner/win/TestControllerWin.cpp:
1383
1384 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1385
1386         Reviewed by Adam Roben.
1387
1388         Clean up vcproj errors
1389         https://bugs.webkit.org/show_bug.cgi?id=49741
1390
1391         * MiniBrowser/MiniBrowser.vcproj:
1392         * WebKitAPITest/WebKitAPITest.vcproj:
1393         * WebKitTestRunner/win/InjectedBundle.vcproj:
1394         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1395
1396 2010-11-18  Hayato Ito  <hayato@chromium.org>
1397
1398         Reviewed by Shinichiro Hamaji.
1399
1400         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
1401         which is caused by r72249.
1402
1403         https://bugs.webkit.org/show_bug.cgi?id=49751
1404
1405         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1406
1407 2010-11-18  Adam Roben  <aroben@apple.com>
1408
1409         Implement layoutTestController.waitForPolicyDelegate on Windows
1410
1411         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
1412
1413         Reviewed by Simon Fraser.
1414
1415         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1416         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
1417         code from LayoutTestControllerMac.mm.
1418
1419 2010-11-18  Hayato Ito  <hayato@chromium.org>
1420
1421         Reviewed by Shinichiro Hamaji.
1422
1423         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
1424
1425         https://bugs.webkit.org/show_bug.cgi?id=49740
1426
1427         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1428
1429 2010-11-18  Tony Chang  <tony@chromium.org>
1430
1431         Reviewed by Adam Barth.
1432
1433         run platform/chromium/plugins/refcount-leaks.html on all platforms
1434         https://bugs.webkit.org/show_bug.cgi?id=49485
1435
1436         Add PluginObject.testObjectCount which returns the number of allocated
1437         TestObjects. Add PluginObject.testCreateTestObject which allocates
1438         and returns a TestObject.
1439
1440         Add TestObject.refCount which returns the number of refs on the
1441         TestObject.
1442
1443         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1444         (pluginGetProperty):
1445         (pluginInvoke):
1446         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1447         (getTestObjectCount):
1448         (testAllocate):
1449         (testDeallocate):
1450         (testGetProperty):
1451         (testScriptObjectInvoke): Release a ref to a plugin object that was
1452             previously leaked.
1453         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1454
1455 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1456
1457         Reviewed by Adam Roben.
1458
1459         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
1460         https://bugs.webkit.org/show_bug.cgi?id=49711
1461
1462         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
1463         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
1464         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
1465         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1466         * record-memory-win/record-memory-win-common.vsprops: Added.
1467         * record-memory-win/record-memory-win.vcproj:
1468
1469 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
1470
1471         Reviewed by Csaba Osztrogonác.
1472
1473         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
1474
1475         * MiniBrowser/qt/BrowserWindow.cpp:
1476         (BrowserWindow::updateUserAgentList):
1477
1478 2010-11-17  Adam Roben  <aroben@apple.com>
1479
1480         Don't trigger Windows builds when chromium-win test results change
1481
1482         Reviewed by Mark Rowe.
1483
1484         * Scripts/webkitpy/common/config/build.py:
1485         (_should_file_trigger_build): Changed the regular expression used to
1486         search for directory names to only consider full directory names,
1487         rather than matching directory names where the string we care about is
1488         a suffix of the name.
1489
1490         * Scripts/webkitpy/common/config/build_unittest.py:
1491         (ShouldBuildTest): Added a test.
1492
1493 2010-11-17  Hayato Ito  <hayato@chromium.org>
1494
1495         Reviewed by Shinichiro Hamaji.
1496
1497         Remove a uri member from TestInput class.
1498
1499         https://bugs.webkit.org/show_bug.cgi?id=49691
1500
1501         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1502         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1503
1504 2010-11-17  Adam Roben  <aroben@apple.com>
1505
1506         Move FindSafari's settings into a vsprops file
1507
1508         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
1509
1510         Reviewed by Steve Falkenburg.
1511
1512         * FindSafari/FindSafari.vcproj:
1513         * FindSafari/FindSafariCommon.vsprops: Added.
1514
1515 2010-11-17  Adam Roben  <aroben@apple.com>
1516
1517         Use a minimum font size of 0 in DRT on Windows
1518
1519         This is the Windows equivalent of r72164.
1520
1521         Rubber-stamped by Dave Hyatt.
1522
1523         * DumpRenderTree/win/DumpRenderTree.cpp:
1524         (resetDefaultsToConsistentValues):
1525
1526 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
1527
1528         Reviewed by Andreas Kling.
1529
1530         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
1531         https://bugs.webkit.org/show_bug.cgi?id=49639
1532
1533         * Scripts/webkitpy/common/checkout/scm.py:
1534
1535 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
1536
1537         Reviewed by Tony Chang.
1538
1539         Rebaseline server: add loupe for image diffs
1540         https://bugs.webkit.org/show_bug.cgi?id=49692
1541         
1542         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
1543         enlarged area of the expected, actual and diff images side by side.
1544
1545         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1546         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
1547         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1548         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1549
1550 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1551
1552         Reviewed by Adam Roben.
1553
1554         WebKitLauncherWin should use vsprops for shared build settings
1555         https://bugs.webkit.org/show_bug.cgi?id=49696
1556
1557         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1558         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1559
1560 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1561
1562         Reviewed by Adam Roben.
1563
1564         WinLauncher should use vsprops for shared build settings
1565         https://bugs.webkit.org/show_bug.cgi?id=49695
1566
1567         * WinLauncher/WinLauncher.cpp:
1568         (_tWinMain):
1569         (PrintView):
1570         (WndProc):
1571         (MyEditProc):
1572         * WinLauncher/WinLauncher.vcproj:
1573         * WinLauncher/WinLauncherCommon.vsprops: Added.
1574
1575 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1576
1577         Delete unused file unintentionally added in last change.
1578
1579         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1580
1581 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1582
1583         Reviewed by Adam Roben.
1584
1585         DumpRenderTree on Windows should use a vsprops file for shared project settings
1586         https://bugs.webkit.org/show_bug.cgi?id=49690
1587
1588         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1589         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1590         * DumpRenderTree/win/DumpRenderTree.vcproj:
1591         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1592         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1593         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1594         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1595         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1596         * DumpRenderTree/win/ImageDiff.vcproj:
1597         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1598
1599 2010-11-17  Hayato Ito  <hayato@chromium.org>
1600
1601         Refactor TestTypeBase.compare_output().
1602
1603         Introduce a TestOutput class and update compare_output() of each test
1604         types so that they can take both actual and expected TestOutput objects.
1605
1606         https://bugs.webkit.org/show_bug.cgi?id=49431
1607
1608         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1609         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1610         * Scripts/webkitpy/layout_tests/port/base.py:
1611         * Scripts/webkitpy/layout_tests/port/chromium.py:
1612         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1613         * Scripts/webkitpy/layout_tests/port/test.py:
1614         * Scripts/webkitpy/layout_tests/port/webkit.py:
1615         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1616         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1617         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1618         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1619
1620 2010-11-17  Adam Roben  <aroben@apple.com>
1621
1622         Make each Windows Test builder use the same OS for all its slaves
1623
1624         Currently each WebKit1 Windows Test builder has one Windows XP slave
1625         and one Windows 7 slave. Having different OSes in a single builder
1626         meant that the builders would alternate between red and green when
1627         there were OS-specific failures.
1628
1629         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1630         between red and green because of multiple OS versions
1631
1632         Reviewed by Mark Rowe.
1633
1634         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1635         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1636         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1637         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1638         builders for the two WebKit1 builders so that they would all use the
1639         appropriate OS.
1640
1641 2010-11-17  James Robinson  <jamesr@chromium.org>
1642
1643         Reviewed by Dan Bernstein.
1644
1645         [chromium] Set minimum font size to 0 for DRT
1646         https://bugs.webkit.org/show_bug.cgi?id=49677
1647
1648         Followup for http://trac.webkit.org/changeset/72141.
1649
1650         Test: http/tests/misc/acid3.html
1651
1652         * DumpRenderTree/chromium/WebPreferences.cpp:
1653         (WebPreferences::reset):
1654
1655 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1656
1657         Unreviewed build fix.
1658
1659         [Qt] Add missing file I forgot in r72220.
1660
1661         * MiniBrowser/MiniBrowser.qrc: Added.
1662
1663 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1664
1665         Reviewed by Andreas Kling.
1666
1667         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1668         https://bugs.webkit.org/show_bug.cgi?id=49627
1669
1670         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1671
1672         * MiniBrowser/MiniBrowser.qrc: Added.
1673         Add it here to prevent qmake from detecting it
1674         since it needs to be copied to the build directory.
1675         * MiniBrowser/qt/BrowserWindow.cpp:
1676         (BrowserWindow::BrowserWindow):
1677         (BrowserWindow::updateUserAgentList):
1678         (BrowserWindow::showUserAgentDialog):
1679         * MiniBrowser/qt/BrowserWindow.h:
1680         * MiniBrowser/qt/MiniBrowser.pro:
1681
1682 2010-11-17  Adam Roben  <aroben@apple.com>
1683
1684         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1685
1686         We use that file on Windows!
1687
1688         Fixes <http://webkit.org/b/49643> Changes to
1689         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1690
1691         Reviewed by Steve Falkenburg.
1692
1693         * Scripts/webkitpy/common/config/build.py:
1694         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1695         trigger builds on SnowLeopard and Windows.
1696
1697         * Scripts/webkitpy/common/config/build_unittest.py:
1698         (ShouldBuildTest.test_should_build): Added a test.
1699
1700 2010-11-17  Satish Sampath  <satish@chromium.org>
1701
1702         Reviewed by Jeremy Orlow.
1703
1704         Clear the speech input mock explicitly before each test.
1705         https://bugs.webkit.org/show_bug.cgi?id=49660
1706
1707         * DumpRenderTree/chromium/LayoutTestController.cpp:
1708         (LayoutTestController::setMockSpeechInputResult):
1709         * DumpRenderTree/chromium/LayoutTestController.h:
1710         * DumpRenderTree/chromium/WebViewHost.cpp:
1711         (WebViewHost::speechInputController):
1712         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1713         * DumpRenderTree/chromium/WebViewHost.h:
1714         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1715
1716 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1717
1718         Unreviewed, specify IRC nickname in committers.py.
1719
1720         * Scripts/webkitpy/common/config/committers.py:
1721
1722 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1723
1724         Reviewed by Tony Chang.
1725
1726         [NRWT] Make http locking similar to perl implementation
1727         https://bugs.webkit.org/show_bug.cgi?id=49187
1728
1729         * Scripts/webkitpy/common/system/file_lock.py: Added.
1730         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1731         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1732
1733 2010-11-17  MORITA Hajime  <morrita@google.com>
1734
1735         Reviewed by Kent Tamura.
1736
1737         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
1738         https://bugs.webkit.org/show_bug.cgi?id=49366
1739
1740         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
1741           according to the spellchecker suggestion
1742         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
1743
1744         test_expectations.txt will be changed after this change is ported to test_shell.
1745         
1746         * DumpRenderTree/chromium/EventSender.cpp:
1747         (makeMenuItemStringsFor):
1748         (EventSender::contextClick):
1749         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1750         (MockSpellCheck::fillSuggestionList):
1751         (MockSpellCheck::initializeIfNeeded):
1752         * DumpRenderTree/chromium/MockSpellCheck.h:
1753         * DumpRenderTree/chromium/WebViewHost.cpp:
1754         (WebViewHost::mockSpellCheck):
1755         * DumpRenderTree/chromium/WebViewHost.h:
1756
1757 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1758
1759         Reviewed by Sam Weinig.
1760
1761         Make sure the pref for minimum font size is just explicitly set to 0 every time,
1762         since the bots have 1 stuck in their plist otherwise.
1763
1764         * DumpRenderTree/mac/DumpRenderTree.mm:
1765         (resetDefaultsToConsistentValues):
1766
1767 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1768
1769         Reviewed by Tony Chang.
1770
1771         Rebaseline server: compute diffs client-side
1772         https://bugs.webkit.org/show_bug.cgi?id=49640
1773         
1774         The image diff output from the DRT is pretty bad on some ports (at
1775         least the Mac one), so it's better to compute diffs on the client by
1776         using <canvas>.
1777
1778         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1779         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1780         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1781
1782 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1783
1784         Reviewed by Tony Chang.
1785
1786         Rebaseline server: display test results
1787         https://bugs.webkit.org/show_bug.cgi?id=49626
1788         
1789         Adds basic result display to the rebaseline server. On the Python side
1790         this involves:
1791         - Parsing the unexpected_results.json into a dictionary.
1792         - Serving it as JSON under /results.json.
1793         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
1794         but I'll need to have access to the parsed results on the Python side
1795         for follow-up changes).
1796         
1797         On the web UI side this adds:
1798         - Markup for display image and text results (expected, actual, diff),
1799           and JS for populating it.
1800         - Markup for breaking down test results by failure type and directory,
1801           and JS for populating it.
1802
1803         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1804         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1805         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1806         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
1807         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1808
1809 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1810
1811         Reviewed by Ojan Vafai.
1812
1813         See Chromium issue http://codereview.chromium.org/5133001/ - we
1814         are modifying the build bots to pass in the builder name with
1815         the "GPU" string appended instead of appending it in the code.
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=49636
1818
1819         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1820
1821 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
1822
1823         Reviewed by Adam Roben.
1824
1825         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
1826         https://bugs.webkit.org/show_bug.cgi?id=49632
1827
1828         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1829         * DumpRenderTree/win/DumpRenderTree.vcproj:
1830         * DumpRenderTree/win/ImageDiff.vcproj:
1831         * MiniBrowser/MiniBrowser.vcproj:
1832         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1833         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1834         * WebKitTestRunner/win/InjectedBundle.vcproj:
1835         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1836         * WinLauncher/WinLauncher.vcproj:
1837         * record-memory-win/record-memory-win.vcproj:
1838
1839 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1840
1841         Reviewed by Ojan Vafai.
1842
1843         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
1844
1845         Rename the TestInfo class to TestInput to be clearer about its
1846         function, and move the checksum-reading code into dump_render_tree_thread
1847         to avoid cross-thread access.
1848
1849         https://bugs.webkit.org/show_bug.cgi?id=49573
1850
1851         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1852         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1853         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1854
1855 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1856
1857         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
1858
1859         * DumpRenderTree/mac/DumpRenderTree.mm:
1860         (resetDefaultsToConsistentValues):
1861
1862 2010-11-16  Stephanie Lewis  <slewis@apple.com>
1863
1864         Reviewed by Geoff Garen.
1865
1866         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
1867
1868         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
1869         for every WebView, and the WebKit API doesn't support that ownership model.
1870
1871         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
1872
1873         * DumpRenderTree/mac/DumpRenderTree.mm:
1874         (createWebViewAndOffscreenWindow):
1875         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1876         (LayoutTestController::setMockDeviceOrientation):
1877
1878 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1879
1880         Reviewed by Ojan Vafai.
1881
1882         new-run-webkit-tests: log the process id in --verbose mode
1883
1884         As part of the switch to multi-process mode, we should log the
1885         process id when running w/ --verbose.
1886
1887         https://bugs.webkit.org/show_bug.cgi?id=49571
1888
1889         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1890
1891 2010-11-16  Adam Roben  <aroben@apple.com>
1892
1893         Only trigger Windows builds when files that we actually use on Windows
1894         are changed
1895
1896         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
1897         It uses the new webkitpy.common.config.build module to determine
1898         whether a particular change should trigger a build on a particular
1899         platform. The Windows builders have been switched to use a
1900         PlatformSpecificScheduler.
1901
1902         The logic to determine whether or not a particular change should
1903         trigger a build on a given platform has only been implemented/tested
1904         for Windows. I tried to make it easy to add more platforms in the
1905         future, but I don't have enough familiarity with all platforms to be
1906         able to implement it for them.
1907
1908         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
1909         lots irrelevant changes (e.g., rebaselining Chromium test results)
1910
1911         Reviewed by Eric Seidel.
1912
1913         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
1914         PlatformSpecificScheduler for the Windows builders.
1915
1916         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1917         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
1918         up a ChangeFilter that filters to our branch and will call through to
1919         our filter method, and calls up to our base class.
1920         (PlatformSpecificScheduler.filter): Calls through to
1921         build.should_build to find out whether we should trigger a build for
1922         this change.
1923
1924         * Scripts/webkitpy/common/net/build.py: Added.
1925         (_should_file_trigger_build): Uses a set of directories and regexp
1926         patterns to determine whether the given file should trigger a build on
1927         the given platform. As mentioned earlier, this has only been
1928         implemented for Windows, though I did try to make some guesses about
1929         other platforms.
1930         (should_build): Returns true if any of the files should trigger a
1931         build on the given platform.
1932
1933         * Scripts/webkitpy/common/net/build_unittest.py: Added.
1934         (ShouldBuildTest.test_should_build): Does some basic testing to make
1935         sure we're triggering builds for the right files. It only tests
1936         Windows for now, though I tried to make some guesses about other
1937         platforms.
1938
1939 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1940
1941         Reviewed by Andreas Kling.
1942
1943         [Qt] Remove synchronous QWebPage::checkPermissions signal
1944         https://bugs.webkit.org/show_bug.cgi?id=46810
1945
1946         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1947         (WebCore::WebPage::WebPage):
1948         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1949         (LayoutTestController::grantDesktopNotificationPermission): When granting
1950         permission, grant it directly on the QWebPage/Frame, that will remember it.
1951         * QtTestBrowser/webpage.cpp:
1952         (WebPage::WebPage):
1953         * QtTestBrowser/webpage.h:
1954
1955
1956 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
1957
1958         Reviewed by Csaba Osztrogonác.
1959
1960         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
1961
1962         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1963         (LayoutTestController::reset):
1964         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1965         (LayoutTestController::isPrinting):
1966         (LayoutTestController::setPrinting):
1967
1968 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
1969
1970         Reviewed by Andreas Kling.
1971
1972         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
1973         https://bugs.webkit.org/show_bug.cgi?id=49587
1974
1975         * MiniBrowser/qt/BrowserView.cpp:
1976         (BrowserView::BrowserView): Added BackingStoreType
1977         argument to ctor. Propagating it to the QGraphicsWKView.
1978         * MiniBrowser/qt/BrowserView.h:
1979         * MiniBrowser/qt/BrowserWindow.cpp:
1980         (BrowserWindow::BrowserWindow):
1981         (BrowserWindow::newWindow): Create the new BrowserWindow
1982         with the same BackingStoreType that this instance has.
1983         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
1984         * MiniBrowser/qt/main.cpp:
1985         (main): Use tiled backing store if got -tiled command line argument.
1986         Avoid redundant copy of command line args.
1987
1988 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
1989
1990         Reviewed by Jeremy Orlow.
1991
1992         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
1993         https://bugs.webkit.org/show_bug.cgi?id=48506
1994
1995         This ensures that there is one mock per page WebView / WebViewHost. This is a
1996         design constraint of the DeviceOrientationClientMock because the m_controller
1997         field can only store a pointer to a single instance of the corresponding
1998         DeviceOrientationController.
1999
2000         Test: fast/dom/DeviceOrientation/no-page-cache.html
2001
2002         * DumpRenderTree/chromium/LayoutTestController.cpp:
2003         (LayoutTestController::setMockDeviceOrientation):
2004         (LayoutTestController::deviceOrientationClientMock):
2005         * DumpRenderTree/chromium/LayoutTestController.h:
2006         * DumpRenderTree/chromium/WebViewHost.cpp:
2007         (WebViewHost::deviceOrientationClientMock):
2008         (WebViewHost::deviceOrientationClient):
2009         (WebViewHost::reset):
2010         * DumpRenderTree/chromium/WebViewHost.h:
2011
2012 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2013
2014         Reviewed by Andreas Kling.
2015
2016         [Qt][WK2] Avoid polling in WebKitTestRunner.
2017         https://bugs.webkit.org/show_bug.cgi?id=49542
2018
2019         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2020         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2021
2022         * WebKitTestRunner/TestController.cpp:
2023         (WTR::TestController::didFinishLoadForFrame):
2024         * WebKitTestRunner/TestController.h:
2025         * WebKitTestRunner/TestInvocation.cpp:
2026         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2027         * WebKitTestRunner/mac/TestControllerMac.mm:
2028         (WTR::TestController::notifyDone): Add method stub.
2029         * WebKitTestRunner/qt/TestControllerQt.cpp:
2030         (WTR::TestControllerRunLoop::instance):
2031         (WTR::TestControllerRunLoop::start):
2032         (WTR::TestControllerRunLoop::stop):
2033         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2034         (WTR::TestControllerRunLoop::timerEvent):
2035         (WTR::TestController::notifyDone):
2036         (WTR::TestController::platformRunUntil):
2037         * WebKitTestRunner/win/TestControllerWin.cpp:
2038         (WTR::TestController::notifyDone): Add method stub.
2039
2040 2010-11-15  Darin Adler  <darin@apple.com>
2041
2042         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2043
2044 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2045
2046         Reviewed by Andreas Kling.
2047
2048         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2049         https://bugs.webkit.org/show_bug.cgi?id=49544
2050
2051         Add the shortcut to BrowserWindow.
2052
2053         * MiniBrowser/qt/BrowserWindow.cpp:
2054         (BrowserWindow::BrowserWindow):
2055         (BrowserWindow::openLocation):
2056         * MiniBrowser/qt/BrowserWindow.h:
2057
2058 2010-11-14  David Levin  <levin@chromium.org>
2059
2060         Reviewed by Daniel Bates.
2061
2062         check-webkit-style should detect PassRefPtr usage in functions.
2063         https://bugs.webkit.org/show_bug.cgi?id=49513
2064
2065         * Scripts/webkitpy/style/checkers/cpp.py:
2066         (check_for_function_lengths): Revert a comment change that I
2067          accidentally made in r71986.
2068         (check_pass_ptr_usage): Added the code to do the check.
2069         (process_line): Added the call to check_pass_ptr_usage.
2070         (CppChecker): Added the new error category.
2071         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2072         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2073          testing purposes.
2074         (PassPtrTest::*): The class/functions to unit test the new
2075          functionality.
2076
2077 2010-11-14  David Levin  <levin@chromium.org>
2078
2079         Reviewed by Shinichiro Hamaji.
2080
2081         check-webkit-style function detection and the line count style checks should be separate.
2082         https://bugs.webkit.org/show_bug.cgi?id=49512
2083
2084         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2085         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2086           call the detection function and fix line counts in two places now that
2087           the code really only counts the lines in the body of the function.
2088
2089 2010-11-14  Andreas Kling  <kling@webkit.org>
2090
2091         Reviewed by Antonio Gomes.
2092
2093         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2094         https://bugs.webkit.org/show_bug.cgi?id=33438
2095
2096         Stifle "Unhandled variable" warning to match what the other
2097         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2098         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2099
2100         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2101         (webkit_test_plugin_get_value):
2102
2103 2010-11-13  David Levin  <levin@chromium.org>
2104
2105         Reviewed by Eric Seidel.
2106
2107         check-webkit-style function detection crashes on functions in templates.
2108         https://bugs.webkit.org/show_bug.cgi?id=49504
2109
2110         For example "template <bool shouldClose(const Element*)>".
2111
2112         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2113         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2114           function detection test to expose this issue.
2115
2116 2010-11-12  David Levin  <levin@chromium.org>
2117
2118         Reviewed by Shinichiro Hamaji.
2119
2120         check-webkit-style function detection doesn't detect indented functions declaractions.
2121         https://bugs.webkit.org/show_bug.cgi?id=49446
2122
2123         Indented function declarations occur inside class definitions, so
2124         they are a pretty common (and worth detecting).
2125
2126         * Scripts/webkitpy/style/checkers/cpp.py:
2127           Changed regex to allow indentation.
2128           Changed the function start detection to only happen when not in a
2129           function.
2130           Changed function end detection to work based on matching braces
2131           instead of finding a close brace at the beginning of the line.
2132           Fixed close_expression to do what it says when it doesn't find
2133           the close.
2134         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2135
2136 2010-11-12  Daniel Bates  <dbates@rim.com>
2137
2138         Rubber-stamped by Nikolas Zimmermann.
2139
2140         Make do-file-rename rename files in the directory WebKit2.
2141
2142         This also makes the list of searched directories in do-file-rename
2143         consistent with the list of searched directories in the script do-webcore-rename.
2144
2145         * Scripts/do-file-rename:
2146
2147 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2148
2149         Reviewed by James Robinson.
2150
2151         Attempt yet again to land the fix for bug 49360 (respecting
2152         set-webkit-configuration). We need to handle the cases where
2153         trying to run webkit-build-directory to find out where the
2154         default configuration might be fails (that shows up on some
2155         Chromium bots that apparently don't have perl installed).
2156
2157         https://bugs.webkit.org/show_bug.cgi?id=49360
2158
2159         * Scripts/webkitpy/layout_tests/port/config.py:
2160         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2161         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2162
2163 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2164
2165         Reviewed by Adam Barth.
2166
2167         webkit-patch land logs commit message twice
2168         https://bugs.webkit.org/show_bug.cgi?id=49482
2169         
2170         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2171         that's just the commit message, which we now output following the
2172         actual commit.
2173
2174         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2175
2176 2010-11-12  Tony Chang  <tony@chromium.org>
2177
2178         Reviewed by Adam Barth.
2179
2180         run platform/chromium/plugins/script-object-invoke.html on all platforms
2181         https://bugs.webkit.org/show_bug.cgi?id=49280
2182
2183         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2184         (testScriptObjectInvoke):
2185         (pluginInvoke):
2186
2187 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2188
2189         Reviewed by Adam Barth.
2190
2191         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
2192         https://bugs.webkit.org/show_bug.cgi?id=49471
2193
2194         Right now there's no indication of a successful commit.
2195         
2196         * Scripts/webkitpy/tool/commands/download_unittest.py:
2197         * Scripts/webkitpy/tool/steps/commit.py:
2198
2199 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
2200
2201         Reviewed by Ojan Vafai.
2202
2203         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
2204         https://bugs.webkit.org/show_bug.cgi?id=49354
2205
2206         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
2207
2208         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2209         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2210         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2211         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2212
2213 2010-11-12  Tony Chang  <tony@chromium.org>
2214
2215         Reviewed by Kent Tamura.
2216
2217         [chromium] Load a blank page when closing DRT WebViewHosts
2218         https://bugs.webkit.org/show_bug.cgi?id=49417
2219
2220         In test_shell, when we close a window, we first load about:blank
2221         and run GC to fire the destruction logic of the page.  In test_shell,
2222         this happens in ~TestShell.  In DRT, we manage virtual windows as
2223         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
2224
2225         Managing focus is a bit trickier, since normally you would get window
2226         events to reset the focus to the right window.  We do it manually
2227         instead.
2228
2229         This fixes 2 plugin tests on DRT.
2230
2231         * DumpRenderTree/chromium/TestShell.cpp:
2232         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
2233         (TestShell::closeWindow): Move widget close() to WVH destructor and
2234             manage focus manually.
2235         (TestShell::closeRemainingWindows): Comment typo.
2236         * DumpRenderTree/chromium/WebViewHost.cpp:
2237         (WebViewHost::closeWidget):
2238         (invokeCloseWidget):
2239         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
2240             test_shell).
2241         (WebViewHost::~WebViewHost):
2242         * DumpRenderTree/chromium/WebViewHost.h:
2243
2244 2010-11-12  David Levin  <levin@chromium.org>
2245
2246         Reviewed by Adam Barth.
2247
2248         cpp.py needs some tidying.
2249         https://bugs.webkit.org/show_bug.cgi?id=49443
2250
2251         * Scripts/webkitpy/style/checkers/cpp.py:
2252           Fix parameter ordering for iteratively_replace_matches_with_char
2253           to mirror other similar functions (and improved comments, etc.)
2254           Also, use a python-ism (for/else) to get rid of a variable that
2255           was there to determine if something had been found in the loop.
2256
2257 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
2258
2259         Reviewed by James Robinson.
2260
2261         [Chromium/DRT] Make EventSendingController send complete touch events.
2262         https://bugs.webkit.org/show_bug.cgi?id=49285
2263
2264         * DumpRenderTree/chromium/EventSender.cpp:
2265         (EventSender::addTouchPoint):
2266         (EventSender::updateTouchPoint):
2267         (EventSender::sendCurrentTouchEvent):
2268
2269 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2270
2271         Unreviewed rollout of r71858.
2272
2273         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
2274         NaCl tests.
2275
2276         * Scripts/webkitpy/layout_tests/port/config.py:
2277         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
2278         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2279
2280 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
2281
2282         Reviewed by Kenneth Rohde Christiansen.
2283
2284         [Qt] TestController::runUntil doesn't honor the timeout parameter
2285         https://bugs.webkit.org/show_bug.cgi?id=48941
2286
2287         Implement the missing timeout of WebKitTestRunner for Qt.
2288
2289         A QElapsedTimer has been added to RunUntilConditionLoop in order
2290         to measure how long the loop has been running. When the timer
2291         is bigger or equal than the timeout, the loop ends even if the
2292         condition is not met.
2293
2294         * WebKitTestRunner/qt/TestControllerQt.cpp:
2295         (WTR::RunUntilConditionLoop::start):
2296         (WTR::RunUntilConditionLoop::run):
2297         (WTR::RunUntilConditionLoop::timerEvent):
2298         (WTR::TestController::platformRunUntil):
2299
2300 2010-11-11  David Levin  <levin@chromium.org>
2301
2302         Reviewed by Shinichiro Hamaji.
2303
2304         check-webkit-style function detection doesn't handle templates with spaces.
2305         https://bugs.webkit.org/show_bug.cgi?id=49427
2306
2307         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
2308           finding the function name.
2309         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
2310           template with a space.
2311
2312 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2313
2314         Reviewed by Shinichiro Hamaji.
2315
2316         Enable check-webkit-style on Qt files
2317         https://bugs.webkit.org/show_bug.cgi?id=48322
2318
2319         Adding exception for _q_... private slots and
2320         ..._data() methods in tests
2321
2322         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
2323         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
2324
2325 2010-11-11  David Levin  <levin@chromium.org>
2326
2327         Reviewed by Shinichiro Hamaji.
2328
2329         check-webkit-style function detection doesn't work for templates and destructors.
2330         https://bugs.webkit.org/show_bug.cgi?id=49425
2331
2332         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
2333         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
2334
2335 2010-11-11  Joone Hur  <joone@kldp.org>
2336
2337         Reviewed by Antonio Gomes.
2338
2339         [GTK][DRT] Implement LayoutTestController::nodesFromRect
2340         https://bugs.webkit.org/show_bug.cgi?id=46598
2341
2342         Support nodesFromRect in DRT
2343
2344         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2345         (LayoutTestController::nodesFromRect):
2346
2347 2010-11-11  MORITA Hajime  <morrita@google.com>
2348
2349         Reviewed by Kent Tamura.
2350
2351         editing/selection/context-menu-on-text.html fails on chromium
2352         https://bugs.webkit.org/show_bug.cgi?id=45898
2353
2354         Enhance Chromium's EventSender::contextClick() to return
2355         array of menu strings. The implementation incomplete because
2356         Although actual context menu is implemented by the browser,
2357         it reflects editability of underlying context thus makes
2358         context-menu-on-text.html passed.
2359         
2360         * DumpRenderTree/chromium/EventSender.cpp:
2361         (makeMenuItemStringsFor): Added.
2362         (EventSender::contextClick): Now returns array of menu strings.
2363         * DumpRenderTree/chromium/WebViewHost.cpp:
2364         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
2365         (WebViewHost::clearContextMenuData): Added.
2366         (WebViewHost::lastContextMenuData): Added.
2367         * DumpRenderTree/chromium/WebViewHost.h:
2368
2369 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2370
2371         Unreviewed, build fix.
2372
2373         fix build breakage caused by fix for bug 49380 (r71858).
2374
2375         config_standalone needs to ensure that the packages it needs are
2376         in sys.path.
2377
2378         https://bugs.webkit.org/show_bug.cgi?id=49419
2379
2380         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2381
2382 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2383
2384         Reviewed by Adam Roben.
2385
2386         Fix NRWT to respect set-webkit-configuration again :(
2387
2388         This change fixes a typo in config.py that was causing the wrong
2389         value to be read initially and us never actually looking into
2390         the filesystem to get the default configuration.
2391         
2392         * Scripts/webkitpy/layout_tests/port/config.py:
2393         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2394         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2395
2396 2010-11-11  Eric Seidel  <eric@webkit.org>
2397
2398         Reviewed by Adam Barth.
2399
2400         Split out Bug, Attachment and CommitterValidator from bugzilla.py
2401         https://bugs.webkit.org/show_bug.cgi?id=49403
2402
2403         CommitterValidator really had nothing to do with bugzilla.py.
2404         I've put it next to committers.py for now since its rather tied to that file.
2405
2406         * Scripts/webkitpy/common/config/committervalidator.py: Added.
2407         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
2408         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2409         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
2410         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
2411         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
2412         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2413         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2414         * Scripts/webkitpy/tool/bot/feeders.py:
2415         * Scripts/webkitpy/tool/commands/queues.py:
2416
2417 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2418
2419         Reviewed by Eric Seidel.
2420
2421         fix missing 'pid' argument for http lockfile checking on win32
2422         https://bugs.webkit.org/show_bug.cgi?id=49363
2423
2424         * Scripts/webkitpy/common/system/executive.py:
2425
2426 2010-11-11  Eric Seidel  <eric@webkit.org>
2427
2428         Rubber-stamped by Adam Barth.
2429
2430         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
2431         https://bugs.webkit.org/show_bug.cgi?id=49402
2432
2433         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
2434         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
2435         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
2436
2437 2010-11-10  Chris Guillory  <chris.guillory@google.com>
2438
2439         Reviewed by Chris Fleizach.
2440
2441         Use IAccessibleComparable to compare accessibility objects.
2442         https://bugs.webkit.org/show_bug.cgi?id=49118
2443
2444         * DumpRenderTree/AccessibilityUIElement.cpp:
2445         (AccessibilityUIElement::isEqual):
2446         * DumpRenderTree/AccessibilityUIElement.h:
2447         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2448         (comparableObject):
2449         (AccessibilityUIElement::isEqual):
2450
2451 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2452
2453         Reviewed by David Hyatt.
2454
2455         HTML5 Ruby support should be mandatory feature
2456         https://bugs.webkit.org/show_bug.cgi?id=49272
2457
2458         Remove Ruby as optional feature.
2459
2460         * Scripts/build-webkit:
2461
2462 2010-11-10  Adam Roben  <aroben@apple.com>
2463
2464         Print VC++ Express build logs in the same order that the projects are
2465         built
2466
2467         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
2468         in an unhelpful order
2469
2470         Reviewed by Eric Seidel.
2471
2472         * Scripts/print-vse-failure-logs:
2473         (PrintVisualStudioExpressLogs._build_order): Added. Uses
2474         print-msvc-project-dependencies to figure out the order in which
2475         projects are built.
2476         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
2477         based on their build order and project name.
2478         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
2479         scripts directory from here...
2480         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
2481         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
2482         them.
2483
2484 2010-11-10  Adam Roben  <aroben@apple.com>
2485
2486         Only print the interesting text from VC++ Express build logs
2487
2488         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
2489         output from print-vse-failure-logs
2490
2491         Reviewed by Eric Seidel.
2492
2493         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
2494         added newly-required imports. Removed a comment that was essentially a
2495         FIXME, and is now fixed.
2496         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
2497         BeautifulSoup to extract the relevant text from the build log.
2498         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
2499
2500 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
2501
2502         Reviewed by Tony Chang.
2503
2504         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
2505         https://bugs.webkit.org/show_bug.cgi?id=49286
2506         
2507         The tests in http/tests/security/XFrameOptions started to fail after
2508         r71297, since it changed the WebViewHost::assignIdentifierToRequest
2509         logic to always assign identifiers to requests, even if we're not going
2510         to be dumping resource load callbacks at that point. These tests
2511         only call LayoutTestController.dumpResourceLoadCallbacks after the
2512         request is started, thus their expectations have "<unknown>" as the
2513         identifier. Change WebViewHost to the previous behavior, which also
2514         match the other ports'.
2515
2516         * DumpRenderTree/chromium/WebViewHost.cpp:
2517         (WebViewHost::assignIdentifierToRequest):
2518         (WebViewHost::removeIdentifierForRequest):
2519
2520 2010-11-08  Tony Chang  <tony@chromium.org>
2521
2522         Reviewed by Adam Barth.
2523
2524         run platform/chromium/plugins/return-npobject.html on all platforms
2525         https://bugs.webkit.org/show_bug.cgi?id=49103
2526
2527         This tests that we can get an NPObject returned through a method on
2528         an NPAPI Object.
2529
2530         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2531         (testCallbackReturn):
2532         (pluginInvoke):
2533
2534 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2535
2536         Unreviewed, rolling out r71672.
2537         http://trac.webkit.org/changeset/71672
2538         https://bugs.webkit.org/show_bug.cgi?id=49276
2539
2540         It doesn't work on Chromium Windows bot (Requested by Ossy on
2541         #webkit).
2542
2543         * Scripts/webkitpy/common/system/file_lock.py: Removed.
2544         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2545         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2546
2547 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2548
2549         Reviewed by Tony Chang.
2550
2551         [NRWT] Make http locking similar to perl implementation
2552         https://bugs.webkit.org/show_bug.cgi?id=49187
2553
2554         * Scripts/webkitpy/common/system/file_lock.py: Added.
2555         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2556         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2557
2558 2010-11-09  James Kozianski  <koz@chromium.org>
2559
2560         Reviewed by Eric Seidel.
2561
2562         Clean up imports for webkit-patch.
2563         https://bugs.webkit.org/show_bug.cgi?id=49083
2564
2565         Move some imports from commands into main.py where they are used.
2566         Move command imports into the __init__ of the commands module.
2567
2568         * Scripts/webkitpy/tool/commands/__init__.py:
2569         * Scripts/webkitpy/tool/commands/download.py:
2570         * Scripts/webkitpy/tool/commands/queues.py:
2571         * Scripts/webkitpy/tool/main.py:
2572
2573 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2574
2575         Reviewed by Andreas Kling.
2576
2577         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2578         https://bugs.webkit.org/show_bug.cgi?id=49047
2579
2580         * QtTestBrowser/mainwindow.cpp:
2581         (MainWindow::setAddressUrl):
2582
2583 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2584
2585         Reviewed by Csaba Osztrogonác.
2586
2587         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2588         https://bugs.webkit.org/show_bug.cgi?id=49252
2589
2590         * Scripts/old-run-webkit-tests:
2591
2592 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2593
2594         Reviewed by Tor Arne Vestbø.
2595
2596         Output of old-run-webkit-tests is buggy in verbose mode
2597         https://bugs.webkit.org/show_bug.cgi?id=49249
2598
2599         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2600
2601 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2602
2603         Reviewed by Martin Robinson.
2604
2605         [GTK] Link with target name set does not work
2606         https://bugs.webkit.org/show_bug.cgi?id=48865
2607
2608         When a new page is created with a name (target=myFrame), the new
2609         mainFrame could not be found because they where not stored in the
2610         same PageGroup. As PageGroup are not exposed externally so the
2611         simpliest solution is to use a global page group name. This also fixes
2612         issue with visited link coloration across pages. After this change the
2613         private function webkit_web_view_set_group_name() was no longer used
2614         so it was removed completly.
2615
2616         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2617         (createWebView):
2618
2619 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2620
2621         Reviewed by Kent Tamura.
2622
2623         WebViewHost::reset() uses placement new.
2624         https://bugs.webkit.org/show_bug.cgi?id=49069
2625
2626         WebViewHost is using placement destruction / new to simulate a fresh
2627         WebViewHost object at the same address. This is because the WebView remains
2628         open across tests and maintains a pointer to the WebViewHost.
2629         This change resets member variables explictly instead of the placement new dance.
2630
2631         * DumpRenderTree/chromium/WebViewHost.cpp:
2632         (WebViewHost::WebViewHost):
2633         (WebViewHost::reset):
2634
2635 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2636
2637         Reviewed by Eric Seidel.
2638
2639         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
2640         It turns out that NRWT can't use the code in scm.find_checkout_root()
2641         because the Chromium bots don't do full checkouts of the WebKit
2642         tree; they only check out subdirectories like WebKitTools/Scripts.
2643         Until we can figure out a better approach for this, I've
2644         restored the base_dir-detecting code from NRWT, which works in
2645         any directory tree, scm or no.
2646
2647         This also restores the files modified in r71475 and r71474.
2648
2649         https://bugs.webkit.org/show_bug.cgi?id=49151
2650
2651         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2652         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2653
2654 2010-11-08  Eric Seidel  <eric@webkit.org>
2655
2656         Reviewed by Adam Barth.
2657
2658         webkit-patch failure-reason explodes if a build is missing
2659         https://bugs.webkit.org/show_bug.cgi?id=49195
2660
2661         This is likely a recent regression.  Adding a unit test for this case.
2662
2663         * Scripts/webkitpy/common/net/buildbot.py:
2664         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2665
2666 2010-11-08  Dan Bernstein  <mitz@apple.com>
2667
2668         Reviewed by Darin Adler.
2669
2670         Ignore the system scrollbar setting.
2671
2672         * DumpRenderTree/mac/DumpRenderTree.mm:
2673         (resetDefaultsToConsistentValues): Set the scrollbar default.
2674
2675 2010-11-05  Adam Roben  <aroben@apple.com>
2676
2677         Make webkitpy.common.system.executive_unittest pass when running under
2678         Win32 Python
2679
2680         Fixes <http://webkit.org/b/49033>.
2681
2682         Reviewed by Dave Levin and Eric Seidel.
2683
2684         * Scripts/webkitpy/common/system/executive.py:
2685         (Executive._run_command_with_teed_output): Pass the arguments through
2686         encode_argument_if_needed rather than using Cygwin-specific code here.
2687         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2688         the output.
2689         (Executive.run_command): Use encode_argument_if_needed to encode the
2690         arguments and child_process_encoding to decode the output.
2691         (Executive._child_process_encoding): Returns the encoding that should be
2692         used when communicating with child processes. On Windows we use mbcs,
2693         which maps to the current code page. On all other platforms we use
2694         UTF-8.
2695         (Executive._should_encode_child_process_arguments): Returns True if
2696         arguments to child processes need to be encoded. This is currently
2697         only needed on Cygwin and Win32 Python 2.x.
2698         (Executive._encode_argument_if_needed): Encode the argument using
2699         child_process_encoding if we need to encode arguments to child
2700         processes on this platform.
2701
2702         * Scripts/webkitpy/common/system/executive_unittest.py:
2703         (never_ending_command): Added. Returns arguments to run a command that
2704         will not quit until we kill it. On Windows we use wmic, on other
2705         platforms we use yes.
2706         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2707         mbcs encoding to be used and for output from the child processes to
2708         have been roundtripped through encode/decode on Win32 Python. When
2709         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2710         it's possible that some characters will not be able to be converted
2711         and will be replaced by question marks; the round-tripping allows us
2712         to expect this result.
2713
2714         (ExecutiveTest.test_kill_process):
2715         (ExecutiveTest.test_kill_all):
2716         Use never_ending_command instead of invoking "yes" directly. Expect an
2717         exit code of 1 when using Win32 Python, as that's what seems to happen.
2718
2719 2010-11-08  Adam Roben  <aroben@apple.com>
2720
2721         Roll out r71532
2722
2723         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2724         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2725
2726         * Scripts/webkitdirs.pm:
2727
2728 2010-11-08  Tony Chang  <tony@chromium.org>
2729
2730         Reviewed by Adam Barth.
2731
2732         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
2733         https://bugs.webkit.org/show_bug.cgi?id=49094
2734
2735         This tests that objects created by plugins are proplery cleaned up.
2736
2737         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2738         (testPassTestObject):
2739         (pluginInvoke):
2740         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2741         (testAllocate):
2742         (testDeallocate):
2743         (testGetProperty):
2744         (testConstruct):
2745
2746 2010-11-08  Adam Roben  <aroben@apple.com>
2747
2748         Mark Windows builds triggered from Perl as being non-interactive
2749
2750         This affects whether some of our scripts will show alerts vs. printing
2751         to the build log.
2752
2753         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
2754         .vsprops files are updated
2755
2756         Reviewed by Steve Falkenburg.
2757
2758         * Scripts/webkitdirs.pm:
2759         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
2760
2761 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2762
2763         Reviewed by Ojan Vafai.
2764
2765         Make http locking default in NRWT.
2766         https://bugs.webkit.org/show_bug.cgi?id=48053
2767
2768         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2769         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2770
2771 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2772
2773         Reviewed by Csaba Osztrogonác.
2774
2775         [NRWT] If the http lock fails we shouldn't do any locking
2776         https://bugs.webkit.org/show_bug.cgi?id=49164
2777
2778         If something goes wrong with the locking, the test should keep going.
2779
2780         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2781
2782 2010-11-08  Adam Roben  <aroben@apple.com>
2783
2784         Switch back to using kCGImageAlphaPremultipliedFirst when generating
2785         pixel dumps on Windows
2786
2787         I changed this behavior in r71418 thinking that it was required for
2788         getting plugins to show up in pixel dumps. But it doesn't seem to be
2789         necessary, and was making it impossible to compare new Windows pixel
2790         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
2791         compare an image with alpha to an image without alpha).
2792
2793         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
2794         new Windows pixel results to existing Windows or Mac results
2795
2796         Reviewed by Antti Koivisto.
2797
2798         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2799         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
2800         with kCGImageAlphaPremultipliedFirst.
2801
2802 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
2803
2804         Unreviewed, rolling out r71466.
2805         http://trac.webkit.org/changeset/71466
2806         https://bugs.webkit.org/show_bug.cgi?id=48865
2807
2808         It broke layout tests on GTK bots.
2809
2810         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2811         (createWebView):
2812
2813 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2814
2815         Reviewed by Csaba Osztrogonác.
2816
2817         Enable running of Qt API tests on BuildBot
2818         https://bugs.webkit.org/show_bug.cgi?id=49004
2819
2820         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2821
2822 2010-11-08  Eric Seidel  <eric@webkit.org>
2823
2824         Reviewed by Adam Barth.
2825
2826         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
2827         https://bugs.webkit.org/show_bug.cgi?id=49160
2828
2829         Bugzilla doesn't automatically remove r? when a bug gets closed.
2830         This script takes care of that for webkit.org.
2831
2832         * Scripts/webkitpy/common/net/bugzilla.py:
2833         * Scripts/webkitpy/tool/commands/upload.py:
2834
2835 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2836
2837         Unreviewed, rolling out r71474.
2838         http://trac.webkit.org/changeset/71474
2839         https://bugs.webkit.org/show_bug.cgi?id=48280
2840
2841         breaks chromium webkit tests
2842         https://bugs.webkit.org/show_bug.cgi?id=49151
2843
2844         * Scripts/webkitpy/layout_tests/port/base.py:
2845         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2846         * Scripts/webkitpy/layout_tests/port/config.py:
2847         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2848         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2849         * Scripts/webkitpy/layout_tests/port/webkit.py:
2850         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2851         * Scripts/webkitpy/tool/mocktool.py:
2852
2853 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2854
2855         Unreviewed, rolling out r71475.
2856         http://trac.webkit.org/changeset/71475
2857  
2858         breaks chromium webkit tests
2859         https://bugs.webkit.org/show_bug.cgi?id=49151
2860
2861         * Scripts/webkitpy/common/newstringio.py: Removed.
2862         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
2863         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
2864         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
2865         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
2866
2867 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2868
2869         Unreviewed, build fix.
2870
2871         Add files inexplicably not committed in r71474 as part of the
2872         fix for bug 48280.
2873
2874         * Scripts/webkitpy/common/newstringio.py: Added.
2875         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2876         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2877         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2878         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
2879
2880 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2881
2882         Reviewed by Eric Siedel.
2883
2884         new-run-webkit-tests: update port/base and port/webkit to use the
2885         new FileSystem and Config abstractions, pulling more logic out of
2886         the base Port classes into separate, mockable objects.
2887
2888         Also create a MockFileSystem object, a MockConfig object, move
2889         MockExecutive into common/system to be next to executive, and
2890         update the config object to use a FileSystem.
2891
2892         https://bugs.webkit.org/show_bug.cgi?id=48280
2893
2894         * Scripts/webkitpy/common/newstringio.py: Added.
2895         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2896         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2897         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2898         * Scripts/webkitpy/layout_tests/port/base.py:
2899         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2900         * Scripts/webkitpy/layout_tests/port/config.py:
2901         * Scripts/webkitpy/layout_tests/port/config_mock.py:
2902         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2903         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2904         * Scripts/webkitpy/layout_tests/port/webkit.py:
2905         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2906         * Scripts/webkitpy/tool/mocktool.py:
2907
2908 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2909
2910         Unreviewed, build breakage.
2911
2912         Apparently I uploaded the wrong version of the file to fix 49122
2913         and neither Eric or I noticed - it was missing a dirname() call.
2914         Fixing ...
2915
2916         https://bugs.webkit.org/show_bug.cgi?id=49122
2917
2918         * Scripts/webkitpy/common/checkout/scm.py:
2919
2920 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2921
2922         Reviewed by Eric Seidel.
2923
2924         webkitpy/tool/* unittests change cwd and don't clean up properly
2925
2926         https://bugs.webkit.org/show_bug.cgi?id=49122
2927
2928         * Scripts/webkitpy/common/checkout/scm.py:
2929
2930 2010-11-05  Chris Marrin  <cmarrin@apple.com>
2931
2932         Reviewed by Simon Fraser.
2933
2934         suspendAnimations/resumeAnimations not present in WebKit2
2935         https://bugs.webkit.org/show_bug.cgi?id=49109
2936
2937         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2938         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2939         (WTR::LayoutTestController::suspendAnimations):
2940         (WTR::LayoutTestController::resumeAnimations):
2941         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2942
2943 2010-11-05  Tony Chang  <tony@chromium.org>
2944
2945         Reviewed by David Levin.
2946
2947         cleanup style in TestNetscapePlugIn/PluginObject.cpp
2948         https://bugs.webkit.org/show_bug.cgi?id=49044
2949
2950         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2951         (getPluginClass):
2952         (pluginGetProperty):
2953         (pluginSetProperty):
2954         (variantToIdentifier):
2955         (testCallback):
2956         (getURL):
2957         (getURLNotify):
2958         (testInvokeDefault):
2959         (testGetProperty):
2960         (testDocumentOpen):
2961         (testWindowOpen):
2962         (pluginInvoke):
2963         (handleCallback):
2964         (notifyStream):
2965         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2966
2967 2010-11-05  Eric Seidel  <eric@webkit.org>
2968
2969         Reviewed by David Levin.
2970
2971         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
2972         https://bugs.webkit.org/show_bug.cgi?id=49032
2973
2974         I wrote this file as part of bug 47847, but I forgot to commit it.
2975         No one else noticed it missing because test-webkitpy knows how
2976         to recover in the case where it can't import QueueStatusServer
2977         (which generally occurs due to not having installed the AppEngine SDK).
2978
2979         * QueueStatusServer/__init__.py: Added.
2980         * QueueStatusServer/model/workitems_unittest.py:
2981          - Remove a test which fails.  This was probably landed (by me)
2982            from my other machine, which since this __init__.py was missing
2983            I never noticed the failure and landed this invalid test.
2984            Sadly we can't really test remove_work_item as it depends
2985            on .key() working.  .key() will throw unless the object
2986            has already been saved it seems.
2987            This may be a mis-design in our remove_work_item implementation,
2988            but for now, just removing the test.
2989
2990 2010-11-04  Adam Roben  <aroben@apple.com>
2991
2992         Teach check-webkit-style about TestNetscapePlugIn
2993
2994         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
2995         TestNetscapePlugIn's coding conventions
2996
2997         Reviewed by John Sullivan.
2998
2999         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
3000         WebKitAPITest and TestWebKitAPI in having different include order and
3001         naming conventions than WebCore. Added some comments about why the
3002         exceptions exist.
3003
3004 2010-11-04  Adam Roben  <aroben@apple.com>
3005
3006         Add a test that shows that windowed plugins are able to paint
3007
3008         Somehow we never had a test for this before.
3009
3010         Fixes <http://webkit.org/b/49029> Should add a test that shows
3011         windowed plugins can paint
3012
3013         Reviewed by Jon Honeycutt.
3014
3015         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
3016         (DrawsGradient::DrawsGradient):
3017         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
3018
3019         (DrawsGradient::onPaint):
3020         (DrawsGradient::onPrintClient):
3021         These both just call through to paint.
3022
3023         (DrawsGradient::paint): Fills our client area with some gradients.
3024
3025         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
3026         against Msimg32.lib for ::GradientFill and added DrawsGradient.
3027
3028         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3029         (createBitmapContextFromWebView): Use WM_PRINT instead of
3030         WM_PRINTCLIENT so that ::DefWindowProc will send
3031         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
3032         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
3033         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
3034         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
3035         will run on a big-endian platform.
3036
3037 2010-11-04  Adam Roben  <aroben@apple.com>
3038
3039         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
3040         WindowedPluginTest base class
3041
3042         The base class takes care of subclassing the plugin's window so that a
3043         custom WNDPROC is called. This will make it easier to write tests that
3044         need to handle window messages.
3045
3046         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
3047         a custom WNDPROC
3048
3049         Reviewed by Jon Honeycutt.
3050
3051         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3052         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
3053         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
3054         (NPNInvalidateRectInvalidatesWindow::wndProc):
3055         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
3056         Moved code from here to WindowedPluginTest. Changed to use window()
3057         instead of m_window.
3058
3059         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3060         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
3061         include path. Also reordered the include path to make a little more
3062         sense and simplified the entry that added TestNetscapePlugIn itself to
3063         the include path.
3064
3065         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
3066         (WindowedPluginTest::WindowedPluginTest):
3067         (WindowedPluginTest::NPP_SetWindow):
3068         (WindowedPluginTest::staticWndProc):
3069         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
3070         (WindowedPluginTest::window):
3071         Code came from NPNInvalidateRectInvalidatesWindow.
3072
3073 2010-11-04  Adam Roben  <aroben@apple.com>
3074
3075         Add a plugin test to show that windowed plugins are clipped correctly
3076
3077         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
3078         plugins aren't clipped in WebKit2 on Windows
3079
3080         Reviewed by Jon Honeycutt.
3081
3082         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
3083         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
3084         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
3085         region matches the clip rect we know we should have based on
3086         window-region-is-set-to-clip-rect.html, and check that our window class
3087         doesn't have the CS_PARENTDC style.
3088
3089         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3090         Added WindowRegionIsSetToClipRect.
3091
3092 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
3093
3094         Reviewed by Martin Robinson.
3095
3096         [GTK] Avoid font hinting in the DRT
3097         https://bugs.webkit.org/show_bug.cgi?id=48548
3098
3099         Change the settings to avoid font hinting, it was causing
3100         different results depending on the distribution.
3101
3102         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3103         (initializeGtkFontSettings):
3104         * DumpRenderTree/gtk/fonts/fonts.conf:
3105
3106 2010-11-05  Eric Seidel  <eric@webkit.org>
3107
3108         Reviewed by Adam Barth.
3109
3110         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
3111         https://bugs.webkit.org/show_bug.cgi?id=49051
3112
3113         This is a speculative fix.  The unit tests cover these methods, however
3114         I don't know if this will fully stop the system.log spam.
3115
3116         * Scripts/webkitpy/layout_tests/port/base.py:
3117         * Scripts/webkitpy/layout_tests/port/webkit.py:
3118
3119 2010-11-05  Eric Seidel  <eric@webkit.org>
3120
3121         Reviewed by Adam Barth.
3122
3123         Add basic support for showing bot id on /queue-status/ pages
3124         https://bugs.webkit.org/show_bug.cgi?id=49037
3125
3126         This support is really simple.  Eventually we'll want to
3127         show the bot id in the lock table too, but we don't have
3128         that information stored in the server yet.
3129
3130         * QueueStatusServer/handlers/queuestatus.py:
3131         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
3132         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3133
3134 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3135
3136         Reviewed by Adam Barth.
3137
3138         Create a filesystem wrapper that we can use to enforce
3139         particular conventions and use for mocking and dependency
3140         injection down the line.
3141
3142         https://bugs.webkit.org/show_bug.cgi?id=48144
3143
3144         * Scripts/webkitpy/common/system/filesystem.py: Added.
3145         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
3146
3147 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3148
3149         Reviewed by Tony Chang.
3150
3151         run_webkit_tests_unittest fails under Python 2.5
3152         https://bugs.webkit.org/show_bug.cgi?id=49043
3153         
3154         Switch from itertools.chain.from_iterable (which was added in 2.6)
3155         to using itertools.chain directly.
3156
3157         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3158
3159 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3160
3161         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
3162         Python 2.5 (it needs an import to use the with statement).
3163
3164         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3165
3166 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3167
3168         Reviewed by Adam Barth.
3169
3170         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
3171
3172         The current NRWT code has webkit-specific configuration code (like
3173         _script_path, default configuration, etc.) mixed in with
3174         layout-test-specific stuff in port/base. The configuration code
3175         should be split out into a separate module for easier mocking,
3176         testing, and isolation.
3177
3178         https://bugs.webkit.org/show_bug.cgi?id=48264
3179
3180         * Scripts/webkitpy/layout_tests/port/config.py: Added.
3181         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
3182
3183 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3184
3185         Reviewed by Tony Chang.
3186
3187         Rebaseline server: initial framework
3188         https://bugs.webkit.org/show_bug.cgi?id=48892
3189         
3190         Adds the basic framework for the rebaseline server (details at 
3191         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
3192         command, which starts an HTTP server that can serve static files or
3193         invoke handler methods on a class.
3194
3195         * Scripts/webkitpy/tool/commands/__init__.py:
3196         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
3197         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
3198         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
3199         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
3200
3201 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3202
3203         Reviewed by James Robinson.
3204
3205         new-run-webkit-tests wasn't using DRT by default for
3206         --platform chromium-gpu
3207
3208         The default value was set to False instead of None, which meant
3209         that the platform specific logic wasn't firing to change the
3210         value to True (b/c we were afraid we'd be overriding the user
3211         preference).
3212
3213         https://bugs.webkit.org/show_bug.cgi?id=49038
3214
3215         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3216
3217 2010-11-04  Tony Chang  <tony@chromium.org>
3218
3219         Reviewed by Adam Barth.
3220
3221         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
3222         https://bugs.webkit.org/show_bug.cgi?id=49026
3223
3224         Have the testObject.bar property return the string "bar".  This lets
3225         us run and pass platform/chromium/plugins/multiple-plugins.html on all
3226         platforms.
3227
3228         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3229         (testGetProperty):
3230
3231 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3232
3233         Reviewed by Tony Chang.
3234
3235         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
3236         https://bugs.webkit.org/show_bug.cgi?id=48878
3237         
3238         Add get_tests_run so that it's easy to see which tests get run (and with
3239         what batching) for a given flag combination. Flesh out the various
3240         test cases that have FIXMEs.
3241         
3242         Also fixes an off-by-one error (batch sizes were one larger than 
3243         expected) and makes --run-part also have wraparound behavior, like
3244         --run-chunk.
3245
3246         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3247         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3248         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3249
3250 2010-11-04  Erik Arvidsson  <arv@chromium.org>
3251
3252         Reviewed by Dimitri Glazkov.
3253
3254         Support box-sizing without the vendor prefix
3255         https://bugs.webkit.org/show_bug.cgi?id=36713
3256
3257         Based on patch by Peter Beverloo <peter@lvp-media.com>
3258
3259         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
3260
3261 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3262
3263         Unreviewed rollout r71340, because it broke Chromium Windows bot.
3264
3265         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3266         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3267
3268 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3269
3270         Reviewed by Ojan Vafai.
3271
3272         Make http locking default in NRWT.
3273         https://bugs.webkit.org/show_bug.cgi?id=48053
3274
3275         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3276         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3277
3278 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3279
3280         Reviewed by Eric Seidel.
3281
3282         [NRWT] Clear invalid http locks on Windows platform as well
3283         https://bugs.webkit.org/show_bug.cgi?id=48515
3284
3285         * Scripts/webkitpy/common/system/executive.py:
3286         * Scripts/webkitpy/common/system/executive_unittest.py:
3287         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3288
3289 2010-11-02  Adam Roben  <aroben@apple.com>
3290
3291         Reduce our dependence on coreutils when running Python tests
3292
3293         This patch introduces versions of the standard echo and cat utilities
3294         implemented in Python. They are probably missing features of their
3295         coreutils equivalents, but they can do what's necessary for our Python
3296         tests. This is useful on Windows, where these utilities typically
3297         aren't available.
3298
3299         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
3300         and cat utilities from coreutils, which are not present on Windows
3301
3302         Reviewed by Eric Seidel.
3303
3304         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
3305         our Python-based echo and cat.
3306
3307         * Scripts/webkitpy/common/system/fileutils.py: Added.
3308         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
3309         that \n won't be translated into \r\n. I couldn't think of a good way
3310         to test this directly without touching the filesystem, but it is tested
3311         indirectly by echo_unittest.
3312
3313         * Scripts/webkitpy/test/cat.py: Added.
3314         (command_arguments): Returns a list for invoking cat with the given arguments.
3315         (main): Acts like a simplified version of the coreutils cat utility.
3316
3317         * Scripts/webkitpy/test/cat_unittest.py: Added.
3318         (CatTest.assert_cat): Runs cat with the given input and ensures the
3319         output matches the input.
3320         (CatTest.test_basic): Performs a simple test of cat.
3321         (CatTest.test_no_newline): Tests what happens when the input string
3322         doesn't have a trailing newline.
3323         (CatTest.test_unicode): Tests passing a unicode string to cat.
3324         (CatTest.test_as_command): Tests running cat as a separate command.
3325
3326         * Scripts/webkitpy/test/echo.py: Added.
3327         (command_arguments): Returns a list for invoking echo with the given arguments.
3328         (main): Acts like a simplified version of the coreutils echo utility.
3329
3330         * Scripts/webkitpy/test/echo_unittest.py: Added.
3331         (EchoTest.test_basic): Performs a simple test of echo.
3332         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
3333         trailing newline.
3334         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
3335         to echo.
3336         (EchoTest.test_argument_order): Tests what happens when -n is not the
3337         first argument.
3338         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
3339         echo.main.
3340         (EchoTest.test_no_arguments): Tests what happens when you call
3341         echo.main with no arguments.
3342         (EchoTest.test_as_command): Tests running echo as a separate command.
3343
3344 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
3345
3346         Unreviewed: Add myself to the list of Committers.
3347
3348         * Scripts/webkitpy/common/config/committers.py:
3349
3350 2010-11-04  Andreas Kling  <kling@webkit.org>
3351
3352         Reviewed by Kenneth Rohde Christiansen.
3353
3354         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
3355
3356         In RTC mode the QGraphicsWebView item is the size of the contents,
3357         scrolling works a bit differently  (we need to react to scrollRequested.)
3358
3359         Normally QGraphicsView will replay the last mouse event when scrolling,
3360         so to prevent WebKit from getting confused by this we temporarily make
3361         the QGraphicsView non-interactive.
3362
3363         * QtTestBrowser/webview.cpp:
3364         (WebViewGraphicsBased::setPage):
3365         (WebViewGraphicsBased::scrollRequested):
3366         * QtTestBrowser/webview.h:
3367
3368 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3369
3370         Reviewed by Andreas Kling.
3371
3372         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
3373
3374         PLATFORM(MAC) is not defined for the Qt port, as it refers to
3375         the Mac-port, not the Mac OS X operating system.
3376
3377         * WebKitTestRunner/qt/TestControllerQt.cpp:
3378         (WTR::isExistingLibrary):
3379
3380 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
3381
3382         Reviewed by Andreas Kling.
3383
3384         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
3385         https://bugs.webkit.org/show_bug.cgi?id=48869
3386
3387         * QtTestBrowser/useragentlist.txt:
3388
3389 2010-11-03  Adam Roben  <aroben@apple.com>
3390
3391         Always use uppercase drive names in strings returned by abspath_to_uri
3392
3393         Some versions of cygpath use lowercase drive letters while others use
3394         uppercase, which makes it hard to test the output of code that uses
3395         cygpath.
3396
3397         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
3398         fails with Cygwin 1.5
3399
3400         Reviewed by Eric Seidel.
3401
3402         * Scripts/webkitpy/common/system/path.py:
3403         (cygpath): Updated the docstring to indicate that only absolute paths
3404         should be passed for now (though relative paths will work fine).
3405         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
3406
3407 2010-11-03  George Guo  <George.Guo@Nokia.com>
3408
3409         Reviewed by Andreas Kling.
3410
3411         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
3412         https://bugs.webkit.org/show_bug.cgi?id=48767
3413     
3414         Paging is needd on Symbian devices to support benchmarks tests like
3415         dromaeo.com and Celtic Kane that need a lot of memory to run  
3416
3417         * QtTestBrowser/QtTestBrowser.pro:
3418
3419 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
3420
3421         Reviewed by Dmitry Titov.
3422
3423         Chromium: Update resource tracking when moving a frame between documents
3424         https://bugs.webkit.org/show_bug.cgi?id=48363
3425
3426         * DumpRenderTree/chromium/WebViewHost.cpp:
3427         (WebViewHost::assignIdentifierToRequest):
3428         Always put resource id in map so we can make assumptions about its
3429         presence.
3430         (WebViewHost::removeIdentifierForRequest):
3431         Added.
3432         (WebViewHost::didFinishResourceLoad):
3433         (WebViewHost::didFailResourceLoad):
3434         Check existence of resource id before removing from map.
3435         * DumpRenderTree/chromium/WebViewHost.h:
3436
3437 2010-11-03  Victor Wang  <victorw@chromium.org>
3438
3439         Reviewed by Adam Barth.
3440
3441         [Chromium] update buildbot names in chromium rebaseline tool.
3442
3443         https://bugs.webkit.org/show_bug.cgi?id=48881
3444
3445         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3446
3447 2010-11-03  Darin Adler  <darin@apple.com>
3448
3449         Updated Xcode projects by opening them with Xcode 3.2.4.
3450         Updated svn:ignore for Xcode projects.
3451
3452         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
3453         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
3454         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3455         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
3456
3457 2010-11-03  Adam Roben  <aroben@apple.com>
3458
3459         Stop waiting for messages from the web process after a timeout elapses
3460
3461         TestController::runUntil now takes a timeout parameter that specifies
3462         how long to wait for the condition to become true. WebKitTestRunner
3463         takes a --timeout flag that specifies how long the timeout should be.
3464         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
3465         will be similar to run-webkit-tests.
3466
3467         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
3468         WebKitTestRunner waits forever if the web process crashes
3469
3470         Reviewed by Darin Adler and Anders Carlsson.
3471
3472         * Scripts/old-run-webkit-tests:
3473         (top level): Moved the GuardMalloc timeout adjustment here from
3474         readFromDumpToolWithTimer.
3475         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
3476         than the one that was specified on the command line.
3477
3478         * WebKitTestRunner/TestController.cpp:
3479         (WTR::TestController::TestController): Initialize our timeout values.
3480         (WTR::TestController::initialize): Parse the --timeout flag and use it
3481         to modify our timeout values.
3482         (WTR::TestController::resetStateToConsistentValues): Changed to use a
3483         short timeout while waiting for the web process to reset and to return
3484         a boolean indicating whether we were able to reset the web process.
3485         Uses a 5-second timeout while waiting for the process to be reset.
3486         (WTR::TestController::runTest): Changed to return a boolean indicating
3487         whether we were able to reset the web process (and thus run the test).
3488         (WTR::TestController::runUntil): Call through to platformRunUntil.
3489
3490         (WTR::TestController::runTestingServerLoop):
3491         (WTR::TestController::run):
3492         Changed to bail if any test can't be run. This will cause the process
3493         to exit. (Unfortunately this will make run-webkit-tests think we
3494         crashed; see <http://webkit.org/b/48943>.)
3495
3496         * WebKitTestRunner/TestController.h: Added platformRunUntil,
3497         m_longTimeout, and m_shortTimeout.
3498
3499         * WebKitTestRunner/TestInvocation.cpp:
3500         (WTR::TestInvocation::invoke): Use a short timeout when waiting for the
3501         initial response and a long timeout when waiting for the test to
3502         complete. Check whether runUntil timed out and print an error message
3503         if so.
3504
3505         * WebKitTestRunner/mac/TestControllerMac.mm:
3506         (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
3507         [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
3508         won't block waiting for the run loop. Only loop until the timeout
3509         elapses.
3510
3511         * WebKitTestRunner/qt/TestControllerQt.cpp:
3512         (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
3513         FIXME about honoring the timeout.
3514
3515         * WebKitTestRunner/win/TestControllerWin.cpp:
3516         (WTR::TestController::platformRunUntil): Renamed from runUntil. Use
3517         ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
3518         ::PeekMessageW so that we don't block waiting for messages to become
3519         available.
3520
3521 2010-11-03  Adam Roben  <aroben@apple.com>
3522
3523         Add a plugin test that evaluates JS after removing the plugin element
3524         from the document
3525
3526         This test replaces platform/win/plugins/plugin-delayed-destroy.html.
3527         That test was made to prevent a crash very similar to this one, but
3528         unfortunately tested only the mechanism that prevented the crash and
3529         not whether the crash itself was prevented. Since WebKit2 uses a
3530         different mechanism to prevent the crash, the test was failing even
3531         though WebKit2 was not vulnerable to the crash. This new test crashes
3532         if there is no mechanism in place to prevent it and passes in both
3533         WebKit1 and WebKit2.
3534
3535         Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
3536         platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2
3537
3538         Reviewed by Anders Carlsson.
3539
3540         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3541         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3542         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3543         * GNUmakefile.am:
3544         Added new file.
3545
3546         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3547         (pluginDeallocate): Make sure we delete the PluginTest object. This
3548         prevents a leak and also allows us to test the crash.
3549
3550         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3551         (PluginTest::executeScript): Made this into a non-static member
3552         function.
3553
3554         (PluginTest::waitUntilDone):
3555         (PluginTest::notifyDone):
3556         Updated for changes to executeScript.
3557
3558         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
3559
3560         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.
3561         (EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
3562         Initialize ourselves and tell the test harness to wait.
3563         (EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
3564         plugin element from the document, then execute some JavaScript. If
3565         WebKit does not have appropriate mechanisms in place, we'll be
3566         destroyed inside the first call to executeScript and crash on the
3567         second call.
3568
3569 2010-11-02  Stephen White  <senorblanco@chromium.org>
3570
3571         Reviewed by Tony Chang.
3572
3573         [chromium] Fix LayoutTestController UMRs.
3574         https://bugs.webkit.org/show_bug.cgi?id=48872
3575
3576         * DumpRenderTree/chromium/LayoutTestController.cpp:
3577         (LayoutTestController::LayoutTestController):
3578
3579 2010-11-03  Kent Tamura  <tkent@chromium.org>
3580
3581         Reviewed by Dimitri Glazkov.
3582
3583         REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
3584         image dup detection
3585         https://bugs.webkit.org/show_bug.cgi?id=48744
3586
3587         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3588          - Make a function for option parsing for ease of test
3589          - Set 0 to options.tolerance
3590         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3591          - Add a test for this change
3592
3593 2010-11-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3594
3595         Unreviewed: Add myself to the list of Committers.
3596
3597         * Scripts/webkitpy/common/config/committers.py:
3598
3599 2010-11-02  Anders Carlsson  <andersca@apple.com>
3600
3601         Fix build.
3602
3603         * TestWebKitAPI/PlatformUtilities.cpp:
3604         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3605
3606 2010-11-02  Sam Weinig  <sam@webkit.org>
3607
3608         Reviewed by Anders Carlsson.
3609
3610         Add a way to send startup messages on the context which can be posted when a process launches
3611         <rdar://problem/8617928>
3612         https://bugs.webkit.org/show_bug.cgi?id=48838
3613
3614         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3615         (WKBundleInitialize):
3616         * TestWebKitAPI/InjectedBundleController.cpp:
3617         (TestWebKitAPI::InjectedBundleController::initialize):
3618         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
3619         * TestWebKitAPI/InjectedBundleController.h:
3620         * TestWebKitAPI/InjectedBundleMain.cpp:
3621         (WKBundleInitialize):
3622         * TestWebKitAPI/PlatformUtilities.cpp:
3623         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3624         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3625         (WKBundleInitialize):
3626         Update implementations of WKBundleInitialize to take an initial userData
3627         argument.  Change TestWebKitAPI to use the new initial userData to initialize
3628         each test's bundle.
3629
3630 2010-11-02  Benjamin Kalman  <kalman@google.com>
3631
3632         Reviewed by Ojan Vafai.
3633
3634         new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
3635         https://bugs.webkit.org/show_bug.cgi?id=48794
3636
3637         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
3638
3639 2010-11-02  Adam Roben  <aroben@apple.com>
3640
3641         Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin
3642         Python 2.5.x
3643
3644         It is known to hang on that version of Python. See
3645         <http://webkit.org/b/48614>.
3646
3647         Reviewed by Adam Barth.
3648
3649         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use
3650         skip_if to skip MainTest on Cygwin Python 2.5.x.
3651
3652         * Scripts/webkitpy/test/skip.py: Added.
3653         (skip_if): If the passed-in condition is false, find all the test_*
3654         methods of the given class and replace them with a function that just
3655         logs that we're skipping these tests. This is loosely based on the
3656         unittest.skip_if decorator added in Python 3.1.
3657         (_skipped_method): Returns a function that just logs that the tests are
3658         being skipped. This is used in place of the actual test_* functions.
3659
3660         * Scripts/webkitpy/test/skip_unittest.py: Added.
3661         (SkipTest.setUp): Create a logger for ourselves and give it a handler
3662         that logs to a private stream.
3663         (SkipTest.tearDown): Reset the logger.
3664         (SkipTest.create_fixture_class): Returns a class that we use to test
3665         skip_if. It has a single test_* method, test_foo, that just calls
3666         through to a callback.
3667         (SkipTest.foo_callback): Record that test_foo was called.
3668         (SkipTest.test_skip_if_false): Pass skip_if a False condition and test
3669         that test_foo does get called.
3670         (SkipTest.test_skip_if_true): Pass skip_if a True condition and test
3671         that test_foo does not get called and the appropriate message gets
3672         logged.
3673
3674 2010-11-02  Adam Barth  <abarth@webkit.org>
3675
3676         Reviewed by Eric Seidel.
3677
3678         webkit-patch should tell check-webkit-style which files were changed so
3679         check-webkit-style doesn't have to stat the whole working copy again
3680         https://bugs.webkit.org/show_bug.cgi?id=48792
3681
3682         * Scripts/webkitpy/tool/mocktool.py:
3683         * Scripts/webkitpy/tool/steps/checkstyle.py:
3684
3685 2010-11-02  Robert Kroeger  <rjkroege@chromium.org>
3686
3687         Reviewed by James Robinson.
3688
3689         [Chromium/DRT] Make EventSendingController honour leapForward for touch events.
3690         https://bugs.webkit.org/show_bug.cgi?id=48777
3691
3692         * DumpRenderTree/chromium/EventSender.cpp:
3693         (EventSender::sendCurrentTouchEvent):
3694
3695 2010-11-02  Adam Roben  <aroben@apple.com>
3696
3697         Only track resource identifiers in DRT when dumpResourceLoadCallbacks
3698         is on
3699
3700         This reverts Windows to our pre-r71097 behavior. That patch made us
3701         track all resource identifiers, including the main resource, so the
3702         main resource's URL started appearing in test output instead of
3703         "<unknown>". Arguably having the main resource's URL is better, but all
3704         other platforms print "<unknown>" and we want to match.
3705
3706         Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
3707         (r71097): Many http tests failing on Windows
3708
3709         Reviewed by Anders Carlsson.
3710
3711         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3712         (ResourceLoadDelegate::identifierForInitialRequest): Don't add the
3713         identifier to the URL map if we're not supposed to dump resource load
3714         callbacks.
3715         (ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
3716         identifier from the URL map even if we're already "done". There's no
3717         point in keeping out-of-date identifiers around.
3718
3719 2010-11-01  Jenn Braithwaite  <jennb@chromium.org>
3720
3721         Reviewed by Adam Roben.
3722
3723         Windows: Update resource tracking when moving a frame between documents
3724         https://bugs.webkit.org/show_bug.cgi?id=48364
3725
3726         * DumpRenderTree/win/DumpRenderTree.cpp:
3727         (createWebViewAndOffscreenWindow):
3728         (main):
3729         Give each WebView its own ResourceLoadDelegate instance in order to
3730         make assertions about resource ids on a particular WebView.
3731         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3732         (ResourceLoadDelegate::identifierForInitialRequest):
3733         Always add id to the map.
3734         (ResourceLoadDelegate::removeIdentifierForRequest):
3735         Added.
3736         (ResourceLoadDelegate::willSendRequest):
3737         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3738         (ResourceLoadDelegate::didReceiveResponse):
3739         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3740         (ResourceLoadDelegate::didFailLoadingWithError):
3741         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3742         Replace static descriptionSuitableForTestResult with static member function to access identifier map.
3743         * DumpRenderTree/win/ResourceLoadDelegate.h:
3744         (ResourceLoadDelegate::urlMap):
3745         Moved within class so that each WebView has its own id map.
3746
3747 2010-11-01  Ojan Vafai  <ojan@chromium.org>
3748
3749         Reviewed by Dimitri Glazkov.
3750
3751         remove debug code from run_webkit_tests.py
3752         https://bugs.webkit.org/show_bug.cgi?id=48800
3753
3754         Remove temporary debug code and make --master-name required
3755         if --test-results-server is set now that all clients set
3756         --master-name.
3757
3758         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3759
3760 2010-11-01  Tony Chang  <tony@chromium.org>
3761
3762         Reviewed by Kent Tamura.
3763
3764         add plugin event logging for linux
3765         https://bugs.webkit.org/show_bug.cgi?id=48779
3766
3767         This is taken from Chromium's fork of the layout test plugin:
3768         http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348
3769
3770         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3771         (handleEventX11):
3772         (NPP_HandleEvent):
3773
3774 2010-11-01  Dirk Pranke  <dpranke@chromium.org>
3775
3776         Reviewed by James Robinson.
3777
3778         new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
3779         https://bugs.webkit.org/show_bug.cgi?id=48790
3780
3781         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3782         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3783
3784 2010-11-01  Adam Barth  <abarth@webkit.org>
3785
3786         Reviewed by Eric Seidel.
3787
3788         Teach check-webkit-style how to accept a list of files to diff on the
3789         command line
3790         https://bugs.webkit.org/show_bug.cgi?id=48784
3791
3792         In a future patch, webkit-patch will use this option to improve
3793         performance.  I'm landing this in two pieces to avoid causing a version
3794         skew problem for the style-bot.
3795
3796         * Scripts/check-webkit-style:
3797         * Scripts/webkitpy/style/optparser.py:
3798         * Scripts/webkitpy/style/optparser_unittest.py:
3799         * Scripts/webkitpy/style_references.py:
3800
3801 2010-11-01  Anders Carlsson  <andersca@apple.com>
3802
3803         Reviewed by John Sullivan.
3804
3805         Tear down the related WebProcessProxy when a WebContext is deallocated
3806         https://bugs.webkit.org/show_bug.cgi?id=48769
3807
3808         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3809         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
3810         We don't support empty URLs anymore, update test to expect a null URL instead.
3811
3812 2010-11-01  Søren Gjesse  <sgjesse@chromium.org>
3813
3814         Reviewed by Andreas Kling.
3815
3816         Fix warning when compiling the chromium port of DumpRenderShell
3817         with clang.
3818         https://bugs.webkit.org/show_bug.cgi?id=48414
3819
3820         * DumpRenderTree/chromium/TestShell.h:
3821         (TestShell::javaScriptFlagsForLoad):
3822
3823 2010-11-01  Adam Roben  <aroben@apple.com>
3824
3825         Fix typo from r71022
3826
3827         * BuildSlaveSupport/build.webkit.org-config/config.json:
3828
3829 2010-11-01  Adam Roben  <aroben@apple.com>
3830
3831         Trigger the Windows Release WebKit2 tests when a Release build
3832         finishes, not when a Debug build finishes
3833
3834         Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
3835         triggered at the wrong time
3836
3837         Reviewed by Sam Weinig.
3838
3839         * BuildSlaveSupport/build.webkit.org-config/config.json: Fixed
3840         triggerable name and trigger.
3841
3842 2010-11-01  Mario Sanchez Prada  <msanchez@igalia.com>
3843
3844         Unreviewed. Adding my IRC nickname to the list of committers.
3845
3846         * Scripts/webkitpy/common/config/committers.py:
3847
3848 2010-10-31  Robert Hogan  <robert@webkit.org>
3849
3850         Reviewed by Antonio Gomes.
3851
3852         [Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
3853
3854         Qt and Gtk are case-sensitive when storing the declared mime-type
3855         of plugins. Since plugin mime-types are lowercased prior to searching
3856         for them in the plugin database, ensure they are loaded with the
3857         mime-type in lower case too.
3858
3859         Change the test netscape plugin to declare its mimetype in sentence
3860         case so that the correct behaviour is enforced.
3861
3862         https://bugs.webkit.org/show_bug.cgi?id=36815
3863
3864         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3865         (NP_GetMIMEDescription):
3866
3867 2010-10-31  Robert Hogan  <robert@webkit.org>
3868
3869         Reviewed by Antonio Gomes.
3870
3871         [Qt] Support nodesFromRect in DRT
3872
3873         https://bugs.webkit.org/show_bug.cgi?id=48716
3874
3875         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3876         (LayoutTestController::nodesFromRect):
3877         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3878
3879 2010-10-30  Andreas Kling  <kling@webkit.org>
3880
3881         Reviewed by Antonio Gomes.
3882
3883         [Qt] QtTestBrowser: Switching view type moves the embedded inspector
3884         https://bugs.webkit.org/show_bug.cgi?id=48705
3885
3886         Reinsert the embedded inspector into the splitter after changing
3887         between QWebView/QGraphicsWebView.
3888
3889         * QtTestBrowser/launcherwindow.cpp:
3890         (LauncherWindow::init):
3891         (LauncherWindow::initializeView):
3892         * QtTestBrowser/webinspector.h:
3893         (WebInspector::WebInspector):
3894
3895 2010-10-28  Antonio Gomes  <agomes@rim.com>
3896
3897         Reviewed by Ojan Vafai.
3898
3899         Needs a "LinuxEditingBehavior", perhaps with a better name
3900         https://bugs.webkit.org/show_bug.cgi?id=36627
3901
3902         Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
3903
3904         * DumpRenderTree/chromium/LayoutTestController.cpp:
3905         (LayoutTestController::setEditingBehavior):
3906         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3907         (LayoutTestController::setEditingBehavior):
3908         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3909         (LayoutTestController::setEditingBehavior):
3910         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3911         (LayoutTestController::setEditingBehavior):
3912
3913 2010-10-29  Andreas Kling  <kling@webkit.org>
3914
3915         Reviewed by Kenneth Rohde Christiansen.
3916
3917         [Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
3918         https://bugs.webkit.org/show_bug.cgi?id=48695
3919
3920         * QtTestBrowser/launcherwindow.cpp:
3921         (LauncherWindow::createChrome):
3922
3923 2010-10-29  Andreas Kling  <kling@webkit.org>
3924
3925         Reviewed by Kenneth Rohde Christiansen.
3926
3927         [Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
3928         https://bugs.webkit.org/show_bug.cgi?id=48675
3929
3930         FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
3931         on startup with in -graphicsbased mode.
3932
3933         * QtTestBrowser/fpstimer.cpp:
3934         (FpsTimer::FpsTimer):
3935         (FpsTimer::numFrames):
3936         (FpsTimer::stop):
3937         (FpsTimer::timerEvent):
3938         * QtTestBrowser/fpstimer.h:
3939
3940 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
3941
3942         Reviewed by Tony Chang.
3943
3944         new-run-webkit-tests: change TestResults to be serializable
3945
3946         In preparation for changing new-run-webkit-tests from
3947         multithreaded to multiprocess, we need to make sure the data
3948         going between the threads is easily serialized over a socket.
3949
3950         This change adds serialization/pickling for the TestResults and
3951         TestFailure objects (using cPickle).
3952
3953         The TestFailure objects included a "has_wdiff" flag for Text
3954         results, but the flag wasn't being used, so I've removed it,
3955         simplifying the state to basically a set of enum objects with
3956         associated methods.
3957
3958         https://bugs.webkit.org/show_bug.cgi?id=48616
3959
3960         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3961         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3962         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3963         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
3964         * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
3965         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added. 
3966         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3967         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3968
3969 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
3970
3971         Reviewed by Ojan Vafai.
3972
3973         new-run-webkit-tests: need to provide separate dashboard results for GPU tests
3974         https://bugs.webkit.org/show_bug.cgi?id=48687
3975
3976         Modify the steps to upload the JSON files to the dashboards so
3977         that the GPU tests don't conflict with the regular tests on a
3978         port. We do this by modifying the --builder-name parameter to
3979         append " - GPU", which should cause the app to treat the results
3980         as a completely new builder. This is a little non-obvious, but
3981         keeps us from having to restructure the app.
3982
3983         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3984         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3985         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3986
3987 2010-10-29  Ojan Vafai  <ojan@chromium.org>
3988
3989         Reviewed by Tony Chang.
3990
3991         [chromium] add debug logging to help diagnose flakiness dashboard issues
3992         https://bugs.webkit.org/show_bug.cgi?id=48657
3993
3994         The appengine app thinks it's getting empty files uploaded. Add some logging
3995         to see if new-run-webkit-tests agrees.
3996         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3997
3998 2010-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
3999
4000         Reviewed by Ojan Vafai.
4001
4002         [Chromium/DRT] Add master-name flag to new-run-webkit-tests.
4003         https://bugs.webkit.org/show_bug.cgi?id=48649
4004
4005         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added flag.
4006
4007 2010-10-29  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
4008
4009         Reviewed by Martin Robinson.
4010
4011         Enable popup window in GtkLauncher
4012         https://bugs.webkit.org/show_bug.cgi?id=48335
4013
4014         The GtkLauncher application does not support opening new window when
4015         a link with "target=_blank" is clicked or similar call to
4016         window.open(). Instead, GtkLauncher does nothing which breaks
4017         navigation of some websites.
4018
4019         * GtkLauncher/main.c:
4020         (activate_uri_entry_cb):
4021         (update_title):
4022         (link_hover_cb):
4023         (notify_title_cb):
4024         (notify_load_status_cb):
4025         (notify_progress_cb):
4026         (destroy_cb):
4027         (go_back_cb):
4028         (go_forward_cb):
4029         (create_web_view_cb):
4030         (web_view_ready_cb):
4031         (close_web_view_cb):
4032         (create_browser):
4033         (create_statusbar):
4034         (create_toolbar):
4035         (create_window):
4036         (main):
4037
4038 2010-10-29  Adam Roben  <aroben@apple.com>
4039
4040         Teach check-webkit-style about WebKit2's idiosyncracies
4041
4042         Fixes <http://webkit.org/b/48638> Style bot complains about a number
4043         of WebKit2 conventions
4044
4045         Reviewed by Anders Carlsson.
4046
4047         * Scripts/webkitpy/style/checker.py: Excluded some rules for various
4048         WebKit2-related files. Also updated the excluded rules for
4049         WebKitAPITest to match the current code.
4050
4051 2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>
4052
4053         Reviewed by Adam Roben and David Kilzer.
4054
4055         Fix and cleanup of build systems
4056         https://bugs.webkit.org/show_bug.cgi?id=48342
4057
4058         * Scripts/build-webkit:
4059          - Remove unnecessary ENABLE_SANDBOX option.
4060          - Add ENABLE_FULLSCREEN_API option.
4061
4062 2010-10-28  Adam Roben  <aroben@apple.com>
4063
4064         Switch the Windows WebKit2 bot to the Release configuration
4065
4066         We only have one machine testing WebKit2 on Windows right now, and
4067         Debug is just too slow for it to keep up.
4068
4069         Fixes (hopefully!) <http://webkit.org/b/48615> Windows WebKit2 bot is
4070         always way behind
4071
4072         Reviewed by Jon Honeycutt.
4073
4074         * BuildSlaveSupport/build.webkit.org-config/config.json:
4075
4076 2010-10-29  Leandro Gracia Gil  <leandrogracia@google.com>
4077
4078         Reviewed by Jeremy Orlow.
4079
4080         Added a second parameter to setMockSpeechInputResult for
4081         the language used in speech input.
4082         https://bugs.webkit.org/show_bug.cgi?id=47089
4083
4084         * DumpRenderTree/LayoutTestController.cpp:
4085         (setMockSpeechInputResultCallback):
4086         * DumpRenderTree/LayoutTestController.h:
4087         * DumpRenderTree/chromium/LayoutTestController.cpp:
4088         (LayoutTestController::setMockSpeechInputResult):
4089         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4090         (LayoutTestController::setMockSpeechInputResult):
4091         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4092         (LayoutTestController::setMockSpeechInputResult):
4093         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4094         (LayoutTestController::setMockSpeechInputResult):
4095         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4096         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4097         (LayoutTestController::setMockSpeechInputResult):
4098         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4099         (LayoutTestController::setMockSpeechInputResult):
4100         (LayoutTestController::pageSizeAndMarginsInPixels):
4101
4102 2010-10-28  Ojan Vafai  <ojan@chromium.org>
4103
4104         Reviewed by Tony Chang.
4105
4106         [chromium] add a result-small.json file for the test dashboard
4107         https://bugs.webkit.org/show_bug.cgi?id=48547
4108
4109         Output both a results.json file and a results-small.json file.
4110         The dashboard will load results-small.json by default so it loads faster.
4111
4112         * TestResultServer/model/jsonresults.py:
4113         * TestResultServer/model/jsonresults_unittest.py:
4114         Added a bunch of sys.path hackery. Unforunately, this uses hardcoded
4115         paths. That obviously needs to be fixed, but at least this way it
4116         clearly documents what paths are necessary.
4117
4118 2010-10-28  Eric Seidel  <eric@webkit.org>
4119
4120         Reviewed by Adam Barth.
4121
4122         webkit-patch upload calls changed_files more often than it should
4123         https://bugs.webkit.org/show_bug.cgi?id=48567
4124
4125         Passing changed_files around everywhere isn't a very elegant solution
4126         but it's the one we have for the moment.  I think keeping an explicit
4127         cache on Checkout (or making StepState() a real class) is a better
4128         long-term option.
4129
4130         Previously bug_id_for_this_commit was calling changed_files and the
4131         result was never getting cached on the state.  Now we're explicitly
4132         caching the result on the state and passing that to the bug_id_for_this_commit call.
4133
4134         I looked into building unit tests for this.  Doing so would require
4135         using a real Checkout object with a MockSCM and overriding the appropriate
4136         calls on SCM to count how often we're stating the file system.
4137         That's a useful set of tests to build for a separate change.
4138
4139         * Scripts/webkitpy/common/checkout/api.py:
4140         * Scripts/webkitpy/tool/commands/download.py:
4141         * Scripts/webkitpy/tool/commands/upload.py:
4142         * Scripts/webkitpy/tool/mocktool.py:
4143
4144 2010-10-28  Eric Seidel  <eric@webkit.org>
4145
4146         Reviewed by Adam Barth.
4147
4148         Make suggest-reviewers slightly faster
4149         https://bugs.webkit.org/show_bug.cgi?id=48562
4150
4151         Add @memoized to one more common call.
4152
4153         * Scripts/webkitpy/common/checkout/api.py:
4154
4155 2010-10-28  Eric Seidel  <eric@webkit.org>
4156
4157         Reviewed by Adam Barth.
4158
4159         webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow
4160         https://bugs.webkit.org/show_bug.cgi?id=48536
4161
4162         This patch makes it about 40 seconds faster, but it still
4163         takes 1:40.  This will require more refinement.
4164
4165         The suggested reviewers list appears to be the same.
4166
4167         I think the next step may be to have it stop the search after
4168         5 reviewers are found.  We never want to suggest 30 people.
4169
4170         * Scripts/webkitpy/common/checkout/scm.py:
4171          - Using --remove-empty to theoretically stop lookups past
4172            when a file is removed.  I'm not entirely clear that the option
4173            does what it says it does.  Example:
4174            git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
4175            returns only one commit
4176            vs.
4177            git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
4178            which returns 5.  I was not aware that wx files were ever removed from the repository?
4179
4180 2010-10-28  Kinuko Yasuda  <kinuko@chromium.org>
4181
4182         Reviewed by David Levin.
4183
4184         [Chromium] Support FileSystem in chromium DRT
4185         https://bugs.webkit.org/show_bug.cgi?id=47643
4186
4187         * DumpRenderTree/chromium/WebViewHost.cpp:
4188         (WebViewHost::openFileSystem): Added.
4189         * DumpRenderTree/chromium/WebViewHost.h:
4190         (WebViewHost::openFileSystem): Added.
4191
4192 2010-10-28  Sam Weinig  <sam@webkit.org>
4193
4194         Reviewed by Anders Carlsson.
4195
4196         WKURLRefs should be allowed to be null
4197         <rdar://problem/8575621>
4198         https://bugs.webkit.org/show_bug.cgi?id=48535
4199
4200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4201         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
4202         (TestWebKitAPI::didStartProvisionalLoadForFrame):
4203         (TestWebKitAPI::didCommitLoadForFrame):
4204         (TestWebKitAPI::didFinishLoadForFrame):
4205         Test that URLs are null pointers when unset.
4206
4207 2010-10-28  Chris Fleizach  <cfleizach@apple.com>
4208
4209         Reviewed by Adele Peterson.
4210
4211         AX: multi select group option does not handle setting of AXSelectedChildren correctly
4212         https://bugs.webkit.org/show_bug.cgi?id=48464
4213
4214         Add support for querying information about selected children to DRT, including:
4215            selectedChildAtIndex
4216            selectedChildrenCount
4217            setSelectedChild
4218
4219         * DumpRenderTree/AccessibilityUIElement.cpp:
4220         (selectedChildAtIndexCallback):
4221         (setSelectedChildCallback):
4222         (selectedChildrenCountCallback):
4223         (AccessibilityUIElement::setSelectedChild):
4224         (AccessibilityUIElement::selectedChildrenCount):
4225         (AccessibilityUIElement::selectedChildAtIndex):
4226         (AccessibilityUIElement::getJSClass):
4227         * DumpRenderTree/AccessibilityUIElement.h:
4228         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4229         (AccessibilityUIElement::selectedChildAtIndex):
4230         (AccessibilityUIElement::selectedChildrenCount):
4231         (AccessibilityUIElement::setSelectedChild):
4232
4233 2010-10-27  Sam Weinig  <sam@webkit.org>
4234
4235         Reviewed by Anders Carlsson.
4236
4237         Add WebKit2 API for window feature getter/setters
4238         <rdar://problem/8590373>
4239         https://bugs.webkit.org/show_bug.cgi?id=48496
4240
4241         * MiniBrowser/mac/BrowserWindowController.m:
4242         (-[BrowserWindowController awakeFromNib]):
4243         * MiniBrowser/win/BrowserView.cpp:
4244         (BrowserView::create):
4245         * WebKitTestRunner/TestController.cpp:
4246         (WTR::createOtherPage):
4247         (WTR::TestController::initialize):
4248
4249 2010-10-28  Søren Gjesse  <sgjesse@chromium.org>
4250
4251         Reviewed by Tony Chang.
4252
4253         Added support for the DumpRenderTree flags --multiple-loads and --js-flags to the Python test runner.
4254         https://bugs.webkit.org/show_bug.cgi?id=48236
4255
4256         * Scripts/webkitpy/layout_tests/port/chromium.py:
4257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4258
4259 2010-10-28  Sergio Villar Senin  <svillar@igalia.com>
4260
4261         Reviewed by Martin Robinson.
4262
4263         [GTK] WebKitWebFrame's load-status is not properly notified to the tests
4264         https://bugs.webkit.org/show_bug.cgi?id=48048
4265
4266         DRT now listens to WebKitWebFrame load-status signals for each
4267         created frame instead of the load-status signal of the
4268         WebKitWebView that only notifies about changes in the main frame.
4269
4270         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4271         (webViewLoadFinished):
4272         (webFrameLoadStatusNotified):
4273         (frameCreatedCallback):
4274         (createWebView):
4275         (main):
4276
4277 2010-10-28  Tony Chang  <tony@chromium.org>
4278
4279         Reviewed by Kent Tamura.
4280
4281         [chromium] fix textInputController.{selectedRange,markedRange}
4282         https://bugs.webkit.org/show_bug.cgi?id=48487
4283
4284         * DumpRenderTree/chromium/TextInputController.cpp:
4285         (TextInputController::markedRange): Return arrays of ints, rather than a string
4286         (TextInputController::selectedRange): Ditto.
4287
4288 2010-10-27  Ojan Vafai  <ojan@chromium.org>
4289
4290         Reviewed by Tony Chang.
4291
4292         [chromium] add a master-name flag to new-run-webkit-tests
4293         https://bugs.webkit.org/show_bug.cgi?id=48488
4294
4295         The test results server now allows adding a master name to
4296         the uploaded files. This lets us distinguish bots that have
4297         the same name, but are on different masters.
4298
4299         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4300
4301 2010-10-28  Adam Roben  <aroben@apple.com>
4302
4303         Don't append a newline to the test output if the frame has no document
4304         element in WebKitTestRunner
4305
4306         Fixes <http://webkit.org/b/48526> Extra trailing newline when running
4307         plugins/document-open.html in WebKitTestRunner
4308
4309         Reviewed by Anders Carlsson.
4310
4311         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4312         (WTR::toJS): Added. Turns a UTF-8 C string into a JSStringRef.
4313         (WTR::hasDocumentElement): Added. Uses the JSC API to figure out
4314         whether the frame has a document element.
4315         (WTR::dumpFrameText): Match DRT by bailing (rather than appending an
4316         empty string and a newline) if the frame has no document element.
4317
4318 2010-10-28  Adam Roben  <aroben@apple.com>
4319
4320         Skip npn-invalidate-rect-invalidates-window.html on headless XP
4321         machines
4322
4323         TestNetscapePlugIn never receives a WM_PAINT message on headless XP
4324         machines,