f841d3837df05d11cec98a038e93af4d7765153f
[WebKit.git] / WebKitTools / ChangeLog
1 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r63346.
4         http://trac.webkit.org/changeset/63346
5         https://bugs.webkit.org/show_bug.cgi?id=42295
6
7         Broke lots of tests, some of which probably just need new
8         results (Requested by aroben on #webkit).
9
10         * DumpRenderTree/win/DumpRenderTree.cpp:
11         (urlSuitableForTestResult):
12
13 2010-07-14  Adam Roben  <aroben@apple.com>
14
15         Speed up killing of Apache on Windows
16
17         Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
18         run-webkit-tests) takes a long time on Windows
19
20         Reviewed by Darin Adler and Jon Honeycutt.
21
22         * Scripts/webkitperl/httpd.pm:
23         (closeHTTPD): Use taskkill to kill Apache and its child processes.
24         Perl's kill seems ineffectual. We were already using taskkill, but
25         only after trying kill 20 times. Since kill never works, let's just
26         skip it entirely.
27
28 2010-07-14  Johnny Ding  <jnd@chromium.org>
29
30         Reviewed by Adam Barth.
31
32         https://bugs.webkit.org/show_bug.cgi?id=41292
33         Add a new parameter to the test plugin to allow to specify a script and a
34         mouse/keyboard event. The specified script will be evaluated in the browser
35         when the specified event is received by the plugin.
36
37         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
38         (pluginAllocate):
39         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
40         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
41         (NPP_New):
42         (handleEventCarbon):
43         (handleEventCocoa):
44
45 2010-07-14  Adam Roben  <aroben@apple.com>
46
47         Make urlSuitableForTestResult work for http: URLs, too
48
49         Fixes <http://webkit.org/b/42276>
50         http/tests/loading/preload-slow-loading.php and
51         http/tests/mime/uppercase-mime-type.html fail on Windows.
52
53         Reviewed by Darin Adler.
54
55         * DumpRenderTree/win/DumpRenderTree.cpp:
56         (urlSuitableForTestResult): Don't bail if the URL starts with http://.
57         We want this function to work for those URLs, too!
58
59 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
60
61         Reviewed by Oliver Hunt.
62
63         Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
64         https://bugs.webkit.org/show_bug.cgi?id=42227
65
66         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
67         (WTR::LayoutTestController::LayoutTestController): Initialize new bool
68         members.
69         (WTR::LayoutTestController::display): Dummy method.
70         (WTR::displayCallback): Call the dummy.
71         (WTR::repaintSweepHorizontallyCallback): ditto
72         (WTR::testRepaintCallback): ditto
73         (WTR::LayoutTestController::staticFunctions): Expose new methods.
74         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
75         (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does
76         nothing).
77         (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
78
79 2010-07-13  Andreas Kling  <andreas.kling@nokia.com>
80
81         Unreviewed. Adding myself as committer.
82
83         * Scripts/webkitpy/common/config/committers.py:
84
85 2010-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
86
87         Reviewed by Darin Adler.
88
89         Prevent assertion/duplicate loads for non-deferred subtitute-data loads
90
91         https://bugs.webkit.org/show_bug.cgi?id=30879
92
93         MainResourceLoader uses the member m_initialRequest to store requests for future
94         deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
95         have to clear this request so that subsequent entries into the loader will not
96         start yet another load.
97
98         This can happen as a result of a PageGroupLoadDeferrer going out of scope when
99         returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
100         but only in the case of using both substitute-data and non-deferred main resource
101         load together. That's why two new DRT functions were added:
102
103          * queueLoadHTMLString()
104          * setDeferMainResourceLoad()
105
106         The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
107         and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
108         added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
109
110         * DumpRenderTree/LayoutTestController.cpp:
111         (LayoutTestController::LayoutTestController):
112         (queueLoadHTMLStringCallback):
113         (setDeferMainResourceDataLoadCallback):
114         (LayoutTestController::staticFunctions):
115         (LayoutTestController::queueLoadHTMLString):
116         * DumpRenderTree/LayoutTestController.h:
117         (LayoutTestController::deferMainResourceDataLoad):
118         (LayoutTestController::setDeferMainResourceDataLoad):
119         * DumpRenderTree/WorkQueueItem.h:
120         (LoadHTMLStringItem::LoadHTMLStringItem):
121         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
122         (LoadHTMLStringItem::invoke):
123         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
124         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
125         * DumpRenderTree/mac/WorkQueueItemMac.mm:
126         (LoadHTMLStringItem::invoke):
127         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
128         (LayoutTestController::reset):
129         (LayoutTestController::setDeferMainResourceDataLoad):
130         (LayoutTestController::queueLoadHTMLString):
131         * DumpRenderTree/qt/LayoutTestControllerQt.h:
132         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
133         (LoadHTMLStringItem::invoke):
134         * DumpRenderTree/qt/WorkQueueItemQt.h:
135         (LoadHTMLStringItem::LoadHTMLStringItem):
136         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
137         (ResourceLoadDelegate::willSendRequest):
138         * DumpRenderTree/win/WorkQueueItemWin.cpp:
139         (LoadHTMLStringItem::invoke):
140         * DumpRenderTree/wx/WorkQueueItemWx.cpp:
141         (LoadHTMLStringItem::invoke):
142
143 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
144
145         Reviewed by Nikolas Zimmermann.
146
147         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
148         https://bugs.webkit.org/show_bug.cgi?id=42153
149
150         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
151         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
152         (WTR::InjectedBundle::initialize): Activate fonts on startup.
153         * WebKitTestRunner/InjectedBundle/mac: Added.
154         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
155         (WTR::activateFonts): Activate our fonts.
156         * WebKitTestRunner/InjectedBundle/win: Added.
157         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
158         (WTR::activateFonts): Dummy version.
159         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
160         add more files.
161         * WebKitTestRunner/fonts: Added.
162         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
163         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
164         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
165         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
166         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
167         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
168         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
169         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
170         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
171         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
172         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
173         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
174         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
175         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
176
177 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
178
179         Reviewed by Eric Seidel.
180
181         Remove check-header-includes, as it didn't turn out to be very useful.
182         https://bugs.webkit.org/show_bug.cgi?id=41970
183
184         * Scripts/check-header-includes: Removed.
185
186 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
187
188         Reviewed by Maciej Stachowiak.
189
190         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
191         https://bugs.webkit.org/show_bug.cgi?id=40922
192         
193         Always build WebKit2 on Windows. Necessary since our WebKit build on
194         Windows is packaged into a DLL with WebKit2.
195
196         * Scripts/build-webkit: Always build WebKit2 on Windows.
197
198 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
199
200         Reviewed by Steve Falkenburg.
201
202         One http test timing out on Windows can cause all future tests to time out
203         https://bugs.webkit.org/show_bug.cgi?id=42146
204         
205         There have been multiple times on the Windows bots where one http test timing out causes all future
206         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
207         times out, we should restart httpd on Cygwin to prevent this.
208
209         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
210         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
211             using kill fails.
212
213 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
214
215         Reviewed by Dan Bernstein.
216
217         Remove use of auto_ptr in WebKitTestRunner
218         https://bugs.webkit.org/show_bug.cgi?id=42134
219         
220         Replaced auto_ptr with PassOwnPtr / OwnPtr.
221
222         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
223         (WTR::WKStringToUTF8):
224         (WTR::InjectedBundlePage::dump):
225         (WTR::InjectedBundlePage::addMessageToConsole):
226         * WebKitTestRunner/TestInvocation.cpp:
227         (WTR::WKStringToUTF8):
228         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
229
230 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
231
232         Reviewed by Sam Weinig.
233
234         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
235         https://bugs.webkit.org/show_bug.cgi?id=42132
236
237         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
238         platform directories.
239
240 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
241
242         Reviewed by Anders Carlsson.
243
244         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
245         https://bugs.webkit.org/show_bug.cgi?id=42126
246
247         * WebKitTestRunner/PlatformWebView.h:
248         * WebKitTestRunner/TestInvocation.cpp:
249         (WTR::TestInvocation::TestInvocation): Store the path as a C
250         string for later use.
251         (WTR::TestInvocation::~TestInvocation):
252         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
253         size, depending on whether this is a W3C SVG test.
254         (WTR::TestInvocation::invoke): Call the size function.
255         * WebKitTestRunner/TestInvocation.h:
256         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
257         (WTR::PlatformWebView::resizeTo): Implement.
258         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
259         (WTR::PlatformWebView::resizeTo): Placeholder.
260
261 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
262
263         Reviewed by Xan Lopez.
264
265         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
266         https://bugs.webkit.org/show_bug.cgi?id=38648
267
268         Add the GTK_MODULES envvar (set to "gail") to the clean
269         environment when running DRT for the Gtk+ port
270
271         * Scripts/old-run-webkit-tests:
272
273 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
274
275         Reviewed by Dirk Schulze.
276
277         [GTK] Support pixel tests
278         https://bugs.webkit.org/show_bug.cgi?id=31518
279
280         Finish support for pixel tests on GTK+.
281
282         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
283         works on CoreFoundation systems) and add missing cstdio include.
284         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
285         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
286         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
287         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
288         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
289         by the ANSI standard and this fails on Linux, so unroll the loop here.
290         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
291         (BitmapContext::BitmapContext): There is no reason to check the value of the
292         m_context member in the constructor and it certainly should not be freed. Instead
293         just initialize it with the incoming value.
294         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
295         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
296         dump pixels.
297         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
298         (createBitmapContextFromWebView):
299         * GNUmakefile.am: Add new files to the build.
300
301 2010-07-12  Adam Barth  <abarth@webkit.org>
302
303         Unreviewed.
304
305         Remove stray "raise e" that got included in a previous patch.  This
306         caused the EWS bots to turn red instead of purple when a patch failed
307         to apply.
308
309         * Scripts/webkitpy/tool/commands/stepsequence.py:
310
311 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
312
313         Unreviewed, rolling out r63101.
314         http://trac.webkit.org/changeset/63101
315         https://bugs.webkit.org/show_bug.cgi?id=42103
316
317         Broke one API test (Requested by xan_ on #webkit).
318
319         * Scripts/old-run-webkit-tests:
320
321 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
322
323         Reviewed by Adam Roben.
324
325         https://bugs.webkit.org/show_bug.cgi?id=13075
326         XMLHttpRequest with failed authentication should set status to 401
327
328         https://bugs.webkit.org/show_bug.cgi?id=6871
329         <rdar://problem/3363403> 401 error page is never shown
330
331         Fix crashes in Windows DumpRenderTree.
332
333         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
334         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
335         again on a destroyed sender.
336
337 2010-07-12  Adam Roben  <aroben@apple.com>
338
339         Windows failure-to-launch fix
340
341         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
342         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
343         we already do for CoreFoundation, CFNetwork, etc.
344
345 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
346
347         Reviewed by Xan Lopez.
348
349         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
350         https://bugs.webkit.org/show_bug.cgi?id=38648
351
352         Add the GTK_MODULES envvar (set to "gail") to the clean
353         environment when running DRT for the Gtk+ port
354
355         * Scripts/old-run-webkit-tests:
356
357 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
358
359         Reviewed by Darin Adler.
360
361         https://bugs.webkit.org/show_bug.cgi?id=13075
362         XMLHttpRequest with failed authentication should set status to 401
363
364         https://bugs.webkit.org/show_bug.cgi?id=6871
365         <rdar://problem/3363403> 401 error page is never shown
366
367         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
368         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
369         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
370         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
371         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
372         the Cancel button.
373
374 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
375
376         Reviewed by Tor Arne Vestbø.
377
378         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
379         https://bugs.webkit.org/show_bug.cgi?id=42082
380
381         * QtTestBrowser/main.cpp:
382         (LauncherWindow::createChrome):
383         * QtTestBrowser/mainwindow.cpp:
384         (MainWindow::openLocation):
385         * QtTestBrowser/mainwindow.h:
386
387 2010-07-12  Adam Roben  <aroben@apple.com>
388
389         Make the Python autoinstaller not use a dead SourceForge server
390
391         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
392         offline SourceForge server
393
394         Reviewed by Anders Carlsson.
395
396         * Scripts/webkitpy/thirdparty/__init__.py: Use
397         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
398         which seems to be down.
399
400 2010-07-12  Adam Roben  <aroben@apple.com>
401
402         Make run-webkit-tests print how many tests timed out when exiting
403         early
404
405         The number of timed-out tests is taken into account when deciding
406         whether to exit early. Leaving it out of the output just makes the
407         script look buggy (because it might say something like "Exiting early
408         after 0 crashes.").
409
410         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
411         messages when exiting early due to crashes and time-outs
412
413         Reviewed by Anders Carlsson.
414
415         * Scripts/old-run-webkit-tests:
416         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
417         timed-out tests, too.
418
419 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
420
421         Reviewed by Dan Bernstein.
422
423         Implement animation-related methods for WebKitTestRunner
424         https://bugs.webkit.org/show_bug.cgi?id=42053
425         
426         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
427         animation tests were hanging otherwise.
428
429         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
430         (WTR::LayoutTestController::numberOfActiveAnimations):
431         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
432         (WTR::numberOfActiveAnimationsCallback):
433         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
434         (WTR::LayoutTestController::staticFunctions):
435         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
436
437 2010-07-11  Daniel Bates  <dbates@rim.com>
438
439         Reviewed by David Kilzer.
440
441         Enable executable support for svn-apply and svn-unapply
442         https://bugs.webkit.org/show_bug.cgi?id=39409
443
444         Connect up the Git and SVN executable bit support in parseDiff() so that
445         executable bit changes are propagated via the returned diff hash to the
446         patch function in svn-apply and svn-unapply.
447
448         * Scripts/VCSUtils.pm:
449           - Modified parseDiff() to call parseSvnDiffProperties when
450             it finds the start of an SVN property change diff.
451           - Removed FIXME comment above parseSvnDiffProperties() since
452             it is now being used by parseDiff().
453           - Export method scmToggleExecutableBit() now that we added the
454             executableBitDelta hash key. (This should have been exported
455             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
456         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
457           - Updated results for:
458             "rename (with executable bit change)"
459               - Test value of executableBitDelta (now that we have support).
460             "SVN: binary file (isBinary true)"
461               - Remove the property change diff from svnConvertedText. We plan
462                 to remove svnConvertedText in the future. So, we decided
463                 against adding such support to any new code, such as the
464                 property parsing routines. Therefore, we do not keep SVN
465                 converted text for property change diffs.
466           - Added unit tests:
467             "SVN: file change diff with property change diff"
468             "SVN: file change diff, followed by property change diff on different file"
469             "SVN: property diff, followed by file change diff"
470             "SVN: copied file with property change"
471             "SVN: two consecutive property diffs"
472             "SVN: binary file with executable bit change"
473             "SVN: binary file followed by property change on different file"
474             "SVN: binary file followed by file change on different file"
475             "SVN: file change diff with property change, followed by property change diff"
476             "SVN: file change diff with property change, followed by file change diff"
477
478 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
479
480         Reviewed by Dan Bernstein.
481
482         Implement waitUntilDone and notifyDone for WebKitTestRunner
483         https://bugs.webkit.org/show_bug.cgi?id=42049
484
485         With this fix, most of the DOM tests pass.
486         
487         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
488         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
489         a great way to do it in the future case where we may get multiple
490         pages - we really need a way to send it over from the ui process.
491         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
492         (WTR::InjectedBundle::page): A way to get the main page.
493         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
494         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
495         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
496         are loading.
497         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
498         called by the layout test controller. Also, cancel any pending watchdogs.
499         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
500         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
501         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
502         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
503         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
504         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
505         to false.
506         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
507         the watchdog.
508         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
509         (WTR::LayoutTestController::setWaitToDump): Set the flag.
510         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
511         where waitUntilDone times out.
512         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
513         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
514         (WTR::notifyDoneCallback): JS glue for notifyDone.
515         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
516         to the layoutController.
517         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
518         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
519
520 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
521
522         Rubber-stamped by Dan Bernstein.
523
524         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
525         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
526         slow down the tests).
527
528         * Scripts/webkitpy/common/system/executive.py:
529
530 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
531
532         Reviewed by Kenneth Rohde Christiansen.
533
534         [Qt] Mac build fix
535         https://bugs.webkit.org/show_bug.cgi?id=41967
536
537         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
538
539         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
540
541 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
542
543         Reviewed by Antonio Gomes.
544
545         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
546         https://bugs.webkit.org/show_bug.cgi?id=41966
547
548         * MiniBrowser/qt/BrowserWindow.cpp:
549         (BrowserWindow::BrowserWindow):
550
551 2010-07-09  Leon Clarke  <leonclarke@google.com>
552
553         Reviewed by Adam Barth.
554
555         add support for link prefetching
556         https://bugs.webkit.org/show_bug.cgi?id=3652
557
558         * Scripts/build-webkit:
559
560 2010-07-09  Ojan Vafai  <ojan@chromium.org>
561
562         Reviewed by Adam Barth.
563
564         r63004 broke some python tests
565         https://bugs.webkit.org/show_bug.cgi?id=42007
566
567         AbstractStep now checks options.no_squash and options.squash, so
568         they needed to have real values. Mock would return an object for those,
569         which would then act as if the values were True.
570
571         * Scripts/webkitpy/tool/commands/commandtest.py:
572         * Scripts/webkitpy/tool/commands/download_unittest.py:
573         * Scripts/webkitpy/tool/commands/stepsequence.py:
574         * Scripts/webkitpy/tool/commands/upload_unittest.py:
575         * Scripts/webkitpy/tool/mocktool.py:
576         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
577         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
578         * Scripts/webkitpy/tool/steps/steps_unittest.py:
579         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
580         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
581
582 2010-07-09  Ojan Vafai  <ojan@chromium.org>
583
584         Reviewed by Adam Barth.
585
586         --squash should go away and become the default
587         https://bugs.webkit.org/show_bug.cgi?id=39624
588
589         If there are local commits and working copy changes, then prompt the user
590         whether to continue. Setting git config webkit-patch.commit_should_always_squash
591         true bypasses the prompt.
592
593         --git-commit=HEAD.. operates on working copy changes only.
594         --git-commit=committish operates on a range of commits as a single commit.
595             e.g. --git-commit=HEAD only operates on the HEAD commit.
596             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
597
598         --no-squash and --squash are left in with descriptive error messages if used.
599
600         * Scripts/check-webkit-style:
601         * Scripts/webkitpy/common/checkout/api.py:
602         * Scripts/webkitpy/common/checkout/api_unittest.py:
603         * Scripts/webkitpy/common/checkout/scm.py:
604         * Scripts/webkitpy/common/checkout/scm_unittest.py:
605         * Scripts/webkitpy/common/net/rietveld.py:
606         * Scripts/webkitpy/common/system/user.py:
607         * Scripts/webkitpy/style/optparser.py:
608         * Scripts/webkitpy/style_references.py:
609         * Scripts/webkitpy/tool/commands/download.py:
610         * Scripts/webkitpy/tool/commands/upload.py:
611         * Scripts/webkitpy/tool/mocktool.py:
612         * Scripts/webkitpy/tool/steps/abstractstep.py:
613         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
614         * Scripts/webkitpy/tool/steps/checkstyle.py:
615         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
616         * Scripts/webkitpy/tool/steps/commit.py:
617         * Scripts/webkitpy/tool/steps/options.py:
618         * Scripts/webkitpy/tool/steps/preparechangelog.py:
619         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
620         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
621         * Scripts/webkitpy/tool/steps/validatereviewer.py:
622
623 2010-07-09  Mark Rowe  <mrowe@apple.com>
624
625         Add two new Windows test build slaves.
626
627         * BuildSlaveSupport/build.webkit.org-config/config.json:
628
629 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
630
631         Reviewed by David Levin.
632
633         rebaseline_chromium_webkit_tests missing --use_drt option on linux
634         https://bugs.webkit.org/show_bug.cgi?id=41985
635
636         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
637         so that it works on linux. This is essentially a "compile-fix" for the
638         script.
639
640         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
641
642 2010-07-09  Nico Weber  <thakis@chromium.org>
643
644         Unreviewed. Adding myself as committer.
645
646         * Scripts/webkitpy/common/config/committers.py:
647
648 2010-07-09  David Kilzer  <ddkilzer@apple.com>
649
650         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
651
652         This reverts commit r62692.
653
654         * Scripts/commit-log-editor:
655
656 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
657
658         Reviewed by Ojan Vafai.
659
660         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
661         https://bugs.webkit.org/show_bug.cgi?id=38693
662
663         Introduced a new base class JSONResultsGeneratorBase that doesn't
664         have any dependency on layout_tests packages.
665         Turned JSONResultsGenerator into a wrapper class of the base class
666         so that the old code can work with it during the cleanup.
667
668         Added json_results_generator_unittest.py.
669
670         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
671         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
672         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
673
674 2010-07-09  Abhishek Arya  <inferno@chromium.org>
675
676         Unreviewed.
677
678         Marking myself as a committer.
679
680         * Scripts/webkitpy/common/config/committers.py:
681
682 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
683
684         Reviewed by Antti Koivisto.
685
686         Implement MiniBrowser for Qt.
687         https://bugs.webkit.org/show_bug.cgi?id=40233
688
689         * MiniBrowser/qt/BrowserWindow.cpp: Added.
690         (createNewPage):
691         (BrowserView::BrowserView):
692         (BrowserView::resizeEvent):
693         (BrowserView::load):
694         (BrowserView::view):
695         (BrowserWindow::BrowserWindow):
696         (BrowserWindow::load):
697         (BrowserWindow::changeLocation):
698         (BrowserWindow::~BrowserWindow):
699         * MiniBrowser/qt/BrowserWindow.h: Added.
700         (BrowserView::~BrowserView):
701         * MiniBrowser/qt/MiniBrowser.pro: Added.
702         * MiniBrowser/qt/main.cpp: Added.
703         (main):
704
705 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
706
707         Reviewed by Simon Hausmann.
708
709         Introduce the Qt autotest launcher.
710
711         Qt autotests should be executed more frequently, ideally by the Qt
712         build bot. This is the first step to provide the tests more accessible.
713
714         [Qt] It should be easier to run all Qt's autotests.
715         https://bugs.webkit.org/show_bug.cgi?id=31625
716
717         * Scripts/run-qtwebkit-tests: Added.
718
719 2010-07-09  Adam Barth  <abarth@webkit.org>
720
721         Reviewed by Eric Seidel.
722
723         commit-queue should merge to TOT when checkout needs update
724         https://bugs.webkit.org/show_bug.cgi?id=41944
725
726         There are a bunch of different designs that are possible here.  This
727         one merges to top of tree by cleaning out the working copy and
728         re-applying the patch.  Once you decide to merge that way, you need to
729         decide who's going to retry.  In this patch, we retry in the child
730         process instead of plumbing the failure reason to the master process.
731
732         This patch is difficult to test end-to-end, but hopefully it will work.
733         :)
734
735         * Scripts/webkitpy/tool/commands/queues.py:
736         * Scripts/webkitpy/tool/commands/stepsequence.py:
737         * Scripts/webkitpy/tool/multicommandtool.py:
738         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
739
740 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
741
742         Reviewed by Darin Adler.
743
744         Add a script to check for unnecessary includes in header files.
745         https://bugs.webkit.org/show_bug.cgi?id=41894
746
747         * Scripts/check-header-includes: Added.
748
749 2010-07-09  Adam Barth  <abarth@webkit.org>
750
751         Reviewed by Eric Seidel.
752
753         Add --html5-treebuilder option to run-webkit-tests
754         https://bugs.webkit.org/show_bug.cgi?id=41922
755
756         We're down to one or two regressions in the HTML5lib test suite.  It's
757         getting to be time to look at fixing LayoutTests.
758
759         * Scripts/old-run-webkit-tests:
760
761 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
762
763         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
764         in the drawing model never getting set on Tiger.
765
766         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
767         (NPP_New):
768
769 2010-07-08  Aaron Boodman  <aa@chromium.org>
770
771         Reviewed by Timothy Hatcher.
772
773         Add the ability for user scripts and user styles to affect just the top frame.
774
775         https://bugs.webkit.org/show_bug.cgi?id=41529
776
777         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
778         * DumpRenderTree/LayoutTestController.cpp: Ditto.
779         (addUserScriptCallback):
780         (addUserStyleSheetCallback):
781         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
782         (LayoutTestController::addUserScript):
783         (LayoutTestController::addUserStyleSheet):
784         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
785         (LayoutTestController::addUserScript):
786         (LayoutTestController::addUserStyleSheet):
787         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
788         (LayoutTestController::addUserScript):
789         (LayoutTestController::addUserStyleSheet):
790         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
791         (LayoutTestController::addUserScript):
792         (LayoutTestController::addUserStyleSheet):
793         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
794         (LayoutTestController::addUserScript):
795         (LayoutTestController::addUserStyleSheet):
796
797 2010-07-08  Adele Peterson  <adele@apple.com>
798
799         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
800
801         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
802         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
803
804         Log when the missing plugin button is pressed.
805
806         * DumpRenderTree/mac/UIDelegate.mm:
807         (-[UIDelegate webView:didPressMissingPluginButton:]):
808         * DumpRenderTree/win/UIDelegate.cpp:
809         (UIDelegate::QueryInterface):
810         (UIDelegate::createWebViewWithRequest):
811         (UIDelegate::drawBackground):
812         (UIDelegate::decidePolicyForGeolocationRequest):
813         (UIDelegate::didPressMissingPluginButton):
814         * DumpRenderTree/win/UIDelegate.h:
815
816 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
817
818         Fix the Tiger build.
819
820         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
821         (NPP_New):
822
823 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
824
825         Fix windows build.
826
827         #ifdef code for Mac.
828
829         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
830         (NPP_New):
831
832 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
833
834         Reviewed by Anders Carlsson.
835
836         Allow the TestPlugin to use Core Animation rendering for testing
837         https://bugs.webkit.org/show_bug.cgi?id=41872
838         
839         Add the ability for the TestPlugin to use the CoreAnimation rendering model
840         when available, based on the "drawingmodel" attribute of the embed tag:
841             drawingmodel="coreanimation"
842
843         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
844         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
845         when building on Tiger. Add a void* coreAnimationLayer member.
846         
847         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
848         (createCoreAnimationLayer): Obj-C method to create the CALayer.
849         
850         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
851         (NPP_New): Look for the drawingmodel attribute to decide which drawing
852         model to use.
853         (NPP_Destroy): Release the CALayer if we have one.
854         (NPP_GetValue): Return the retained CALayer.
855
856 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
857
858         Reviewed by Xan Lopez.
859
860         [GTK] Support pixel tests
861         https://bugs.webkit.org/show_bug.cgi?id=31518
862
863         Convert this file from CRLF to NL line endings. It will soon
864         be used on more than just the WinCairo platform.
865
866         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
867         (writeFunction):
868         (printPNG):
869         (computeMD5HashStringForBitmapContext):
870         (dumpBitmap):
871
872 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
873
874         Reviewed by Darin Adler.
875
876         Enable Data Execution Prevention for our test harnesses on Windows
877         https://bugs.webkit.org/show_bug.cgi?id=41882
878
879         * DumpRenderTree/win/DumpRenderTree.vcproj:
880         * DumpRenderTree/win/ImageDiff.vcproj:
881         * WebKitAPITest/WebKitAPITest.vcproj:
882         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
883
884 2010-07-07  Robert Hogan  <robert@webkit.org>
885
886         Reviewed by Kenneth Rohde Christiansen.
887
888         [Qt] Add DRT support for pageProperty etc.
889
890         https://bugs.webkit.org/show_bug.cgi?id=41584
891
892         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
893         (LayoutTestController::isPageBoxVisible):
894         (LayoutTestController::pageSizeAndMarginsInPixels):
895         (LayoutTestController::pageProperty):
896         (LayoutTestController::addUserStyleSheet):
897         * DumpRenderTree/qt/LayoutTestControllerQt.h:
898
899 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
900
901         Reviewed by Xan Lopez.
902
903         Remove a warnings from the ImageDiff build by using the proper
904         printf format string for the gsize data type.
905
906         * DumpRenderTree/gtk/ImageDiff.cpp:
907         (printImage): Use the proper printf format string for the gsize data type.
908
909 2010-07-08  Alice Liu  <alice.liu@apple.com>
910
911         Reviewed by Sam Weinig.
912
913         https://bugs.webkit.org/show_bug.cgi?id=41653
914         Add new WebKitTestRunner project for Windows
915
916         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
917         Similar to how it's done in DumpRenderTree, define max and min early
918         on so that they don't get replaced by a macro requiring 2 arguments.
919
920         * WebKitTestRunner/win: Added.
921         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
922         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
923         * WebKitTestRunner/win/main.cpp: Added.
924         (main): Implemented
925
926         Added these files with stubbed out functions:
927         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
928         (WTR::PlatformWebView::PlatformWebView):
929         (WTR::PlatformWebView::~PlatformWebView):
930         (WTR::PlatformWebView::page):
931         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
932         (WTR::TestController::initializeInjectedBundlePath):
933         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
934         (WTR::TestInvocation::runUntil):
935
936 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
937
938         Reviewed by Gustavo Noronha Silva.
939
940         [GTK] Implement ImageDiff and add it to the build system
941         https://bugs.webkit.org/show_bug.cgi?id=41779
942
943         Add the initial implementation of the ImageDiff tool for the GTK+
944         port. This is an essential tool for doing pixel tests. The implementation
945         is based on the Mac and Chromium ports.
946
947         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
948         (readPixbufFromStdin): Added.
949         (differenceImageFromDifferenceBuffer): Ditto.
950         (calculateDifference): Ditto.
951         (printImage): Ditto.
952         (printImageDifferences): Ditto.
953         (main): Ditto.
954         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
955
956 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
957
958         Unreviewed. Adding myself as a committer.
959
960         * Scripts/webkitpy/common/config/committers.py:
961
962 2010-07-08  Adam Roben  <aroben@apple.com>
963
964         Make Windows stop running tests from platform/mac
965
966         r62742 made a change (at my suggestion!) that caused us to start
967         looking for tests in platform/mac, rather than just looking for
968         expected results in platform/mac. This patch just undoes that part of
969         r62742.
970
971         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
972         tests from platform/mac, but shouldn't
973
974         Reviewed by Antti Koivisto and Anders Carlsson.
975
976         * Scripts/old-run-webkit-tests:
977         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
978         so we won't look in those directories for tests to run.
979         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
980         platform/mac-snowleopard and platform/mac for expected results.
981
982 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
983
984         Unreviewed. Adding myself as a reviewer.
985
986         * Scripts/webkitpy/common/config/committers.py:
987
988 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
989
990         Update my e-mail in committers.py
991
992         * Scripts/webkitpy/common/config/committers.py:
993
994 2010-07-07  Daniel Bates  <dbates@rim.com>
995
996         Reviewed by Dumitru Daniliuc.
997
998         VCSUtils.pm complains about uninitialized value $newLine
999         https://bugs.webkit.org/show_bug.cgi?id=41333
1000
1001         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
1002         an array when fixing a change log entry that overlaps with an earlier
1003         entry. In particular, when a patch contains a change log entry inserted
1004         earlier in the change log file, but after an entry with the same author
1005         and date.
1006
1007         * Scripts/VCSUtils.pm:
1008             - Added for-loop constraint to fixChangeLogPatch() so that it does not
1009               read off the end of the @overlappingLines array.
1010         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
1011
1012 2010-07-07  Anders Carlsson  <andersca@apple.com>
1013
1014         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
1015
1016         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1017         (NPP_New):
1018
1019 2010-07-07  Kent Tamura  <tkent@chromium.org>
1020
1021         Reviewed by Adam Barth.
1022
1023         [DRT/Chromium] Support for indeterminate checkbox
1024         https://bugs.webkit.org/show_bug.cgi?id=41747
1025
1026         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
1027
1028         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
1029         (WebThemeControlDRT::draw):
1030         * DumpRenderTree/chromium/WebThemeControlDRT.h:
1031         (WebThemeControlDRT::):
1032         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
1033         (WebThemeEngineDRT::paintButton):
1034
1035 2010-07-07  Sam Weinig  <sam@webkit.org>
1036
1037         Reviewed by Mark Rowe.
1038
1039         Clean up MiniBrowser Xcode project.
1040
1041         - Use xcconfig files.
1042         - Rename plists to canonical Info.plist
1043         - Remove localizations.
1044
1045         * MiniBrowser/Configurations: Added.
1046         * MiniBrowser/Configurations/Base.xcconfig: Added.
1047         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
1048         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
1049         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
1050         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1051         * MiniBrowser/WebBundle-Info.plist: Removed.
1052         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1053         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1054         * MiniBrowser/mac/BrowserWindow.xib: Added.
1055         * MiniBrowser/mac/BrowserWindowController.m:
1056         (-[BrowserWindowController initWithPageNamespace:]):
1057         * MiniBrowser/mac/English.lproj: Removed.
1058         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
1059         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
1060         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
1061         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
1062         * MiniBrowser/mac/MainMenu.xib: Added.
1063         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
1064         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
1065
1066 2010-07-07  Kent Tamura  <tkent@chromium.org>
1067
1068         Reviewed by Dimitri Glazkov.
1069
1070         [DRT/Chromium] Fix two regressions
1071         https://bugs.webkit.org/show_bug.cgi?id=41745
1072
1073         * DumpRenderTree/chromium/WebViewHost.cpp:
1074         (WebViewHost::paintInvalidatedRegion):
1075          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
1076          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
1077          though test_shell does it twice. Probably DRT needs it because
1078          DRT delays painting as possible.
1079
1080 2010-07-07  Anders Carlsson  <andersca@apple.com>
1081
1082         Try to fix build.
1083
1084         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1085         (webkit_test_plugin_destroy_stream):
1086
1087 2010-07-07  Anders Carlsson  <andersca@apple.com>
1088
1089         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
1090
1091         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1092         (webkit_test_plugin_new_stream):
1093         (webkit_test_plugin_destroy_stream):
1094         (webkit_test_plugin_write_ready):
1095         (webkit_test_plugin_write):
1096
1097 2010-07-07  Sam Weinig  <sam@webkit.org>
1098
1099         Reviewed by Mark Rowe.
1100
1101         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
1102
1103         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1104
1105 2010-07-07  Anders Carlsson  <andersca@apple.com>
1106
1107         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
1108
1109         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1110         (NPP_New):
1111         (NPP_HandleEvent):
1112
1113 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1114
1115         Reviewed by Adam Roben.
1116
1117         Need to have a way to specify different results for Windows XP and 7
1118         https://bugs.webkit.org/show_bug.cgi?id=41776
1119         
1120         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
1121         subdirectories, so we can have different results for tests on Windows XP, Windows
1122         Vista, and Windows 7.
1123
1124         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
1125         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
1126         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
1127
1128         This matches the behavior of the mac.
1129
1130         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
1131             or Vista, try looking in other win-* subdirectories before win.
1132         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
1133             we are running.
1134
1135 2010-07-07  Kent Tamura  <tkent@chromium.org>
1136
1137         Reviewed by Dimitri Glazkov.
1138
1139         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
1140         https://bugs.webkit.org/show_bug.cgi?id=41753
1141
1142         The original code of the following functions in
1143         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
1144         ASSERT_NOT_REACHED(). The program shouldn't stop at these
1145         functions.
1146
1147         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1148         (DRTDevToolsClient::activateWindow):
1149         (DRTDevToolsClient::closeWindow):
1150         (DRTDevToolsClient::dockWindow):
1151         (DRTDevToolsClient::undockWindow):
1152
1153 2010-07-07  Anders Carlsson  <andersca@apple.com>
1154
1155         Reviewed by Sam Weinig.
1156
1157         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
1158         https://bugs.webkit.org/show_bug.cgi?id=41821
1159
1160         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1161         (pluginGetProperty):
1162         (pluginSetProperty):
1163         (pluginAllocate):
1164         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1165         Add and initialize the returnNegativeOneFromWrite property.
1166
1167         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1168         (NPP_NewStream):
1169         Set the stream type to NP_NORMAL so we'll get write callbacks.
1170
1171         (NPP_DestroyStream):
1172         Treat the onstreamdestroy attribute as a function name and not a string.
1173
1174         (NPP_WriteReady):
1175         Have this return a nonzero value.
1176
1177         (NPP_Write):
1178         If returnNegativeOneFromWrite is true return -1.
1179
1180 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1181
1182         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
1183         latest version is selected by default, and allows the version to be specified.
1184
1185         * wx/build/settings.py:
1186
1187 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
1188
1189         Reviewed by Darin Adler.
1190
1191         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
1192         https://bugs.webkit.org/show_bug.cgi?id=41810
1193
1194         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1195         (AccessibilityUIElement::selectedTextRange):
1196
1197 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
1198
1199         Unreviewed.
1200
1201         Build fix after r62700.
1202
1203         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
1204         source file locations.
1205
1206 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1207
1208         Reviewed by David Levin.
1209
1210         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
1211         https://bugs.webkit.org/show_bug.cgi?id=41814
1212
1213         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1214         * Scripts/old-run-webkit-tests:
1215
1216 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1217
1218         Reviewed by David Levin.
1219
1220         add --exit-after-n-crashes to run-webkit-tests
1221         https://bugs.webkit.org/show_bug.cgi?id=41811
1222
1223         Change the bots at build.webkit.org to use --exit-after-n-crashes
1224         instead of --exit-after-n-failures since we want to be able to have
1225         more than 20 failures on those bots, but more than 20 crashes means
1226         something should be rolled out.
1227
1228         * Scripts/old-run-webkit-tests:
1229         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1230
1231 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1232
1233         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
1234         TestNetscapePlugin project, because this was removed from the tree.
1235
1236         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1237
1238 2010-07-07  Anders Carlsson  <andersca@apple.com>
1239
1240         Reviewed by Simon Fraser.
1241
1242         Unify Mac and Windows TestNetscapePlugin main.cpp files
1243         https://bugs.webkit.org/show_bug.cgi?id=41798
1244         
1245         * DumpRenderTree/DumpRenderTree.sln:
1246         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1247         (strcasecmp):
1248         (NP_Initialize):
1249         (NP_GetEntryPoints):
1250         (NP_Shutdown):
1251         (NPP_New):
1252         (NPP_Destroy):
1253         (NPP_HandleEvent):
1254         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1255         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
1256
1257 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1258
1259         [wx] Build fix. pageProperty needs to return a value.
1260
1261         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1262         (LayoutTestController::pageProperty):
1263
1264 2010-07-07  David Kilzer  <ddkilzer@apple.com>
1265
1266         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
1267
1268         Reviewed by Anders Carlsson.
1269
1270         For both svn and git, commit-log-editor is invoked from the root
1271         of the working directory.  Unlike svn, git returns a list of
1272         changed files that are relative to the directory where the
1273         command was invoked.  This caused the ChangeLog file in the root
1274         directory to be read instead of the ChangeLog in the current
1275         directory.
1276
1277         The fix is to use $ENV{PWD} as the base directory when fixing
1278         the path to the ChangeLog files.  With svn, this has no net
1279         effect since $ENV{PWD} is the root of the working directory and
1280         the ChangeLog paths are already relative to that directory.
1281         With git, $ENV{PWD} is the directory that the commit was invoked
1282         from, which fixes the ChangeLog paths so that the correct files
1283         are read when creating the commit log entry.
1284
1285         Note that the call to makeFilePathRelative() was supposed to
1286         address this issue, but it doesn't because (a) it does nothing
1287         with svn working directories by design, and (b) it does nothing
1288         with git working directories because it's invoked when the
1289         current directory is the root of the working directory, thus
1290         giving no relative path.
1291
1292         * Scripts/commit-log-editor: Removed call to
1293         makeFilePathRelative() since since it does nothing.  Moved code
1294         to fix up $changeLog path so that it's fixed before trying to
1295         open the file, and use $ENV{PWD} as the base path.  Also use
1296         canonicalizePath() to clean up paths with "../" in them.
1297
1298 2010-07-07  Anders Carlsson  <andersca@apple.com>
1299
1300         Another attempt at fixing the Qt build.
1301
1302         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1303
1304 2010-07-07  Anders Carlsson  <andersca@apple.com>
1305
1306         Try to fix Qt build.
1307
1308         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1309
1310 2010-07-07  Anders Carlsson  <andersca@apple.com>
1311
1312         Reviewed by Simon Fraser.
1313
1314         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
1315         https://bugs.webkit.org/show_bug.cgi?id=41781
1316
1317         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1318         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
1319         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
1320         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
1321         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
1322         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
1323         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
1324         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
1325         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
1326         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
1327         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
1328         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
1329         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
1330
1331 2010-07-07  Andras Becsi  <abecsi@webkit.org>
1332
1333         Unreviewed trivial fix.
1334
1335         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
1336         which was checked in accidentally in r62635.
1337
1338         * Scripts/webkitpy/layout_tests/port/webkit.py:
1339
1340 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1341
1342         Reviewed by Eric Seidel.
1343
1344         Pass port specific environment to server process.
1345         https://bugs.webkit.org/show_bug.cgi?id=41593
1346
1347         * Scripts/webkitpy/layout_tests/port/qt.py:
1348         * Scripts/webkitpy/layout_tests/port/webkit.py:
1349
1350 2010-07-06  Kent Tamura  <tkent@chromium.org>
1351
1352         Reviewed by Shinichiro Hamaji.
1353
1354         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
1355         https://bugs.webkit.org/show_bug.cgi?id=41644
1356
1357         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
1358         tolerance. We don't need tolerance for rebaseline.
1359
1360         * Scripts/webkitpy/layout_tests/port/base.py:
1361           Add optional tolerance parameter to diff_image().
1362         * Scripts/webkitpy/layout_tests/port/test.py:
1363           Add optional tolerance parameter to diff_image().
1364         * Scripts/webkitpy/layout_tests/port/webkit.py:
1365           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
1366         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1367           diff_files() always calls diff_image() with tolerance=0.
1368           diff_files() is used only by rebaseline-chromium-webkit-tests.
1369
1370 2010-07-06  Sam Weinig  <sam@webkit.org>
1371
1372         Fix MiniBrowser build.
1373
1374         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1375
1376 2010-07-06  Sam Weinig  <sam@webkit.org>
1377
1378         Reviewed by Anders Carlsson.
1379
1380         Add support for dumping the contents of messages to the console to WebKitTestRunner
1381
1382         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1383         (WTR::InjectedBundlePage::InjectedBundlePage):
1384         (WTR::InjectedBundlePage::_addMessageToConsole):
1385         (WTR::InjectedBundlePage::addMessageToConsole):
1386         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1387
1388 2010-07-06  Sam Weinig  <sam@webkit.org>
1389
1390         Reviewed by Anders Carlsson.
1391
1392         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
1393         Add dumpAsText support for WebKitTestRunner
1394
1395         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1396         (WTR::InjectedBundle::InjectedBundle):
1397         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
1398         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1399         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
1400         API to dump the main frames text.
1401
1402 2010-07-06  Darin Adler  <darin@apple.com>
1403
1404         Fix Chromium build.
1405
1406         * DumpRenderTree/chromium/WebViewHost.cpp:
1407         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
1408         (WebViewHost::didNavigateWithinPage): Ditto.
1409         (WebViewHost::updateURL): Ditto.
1410
1411 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
1412
1413         Reviewed by Xan Lopez.
1414
1415         [GTK] build-webkit should not run autogen.sh unconditionally
1416         https://bugs.webkit.org/show_bug.cgi?id=41704
1417
1418         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
1419         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
1420         some very minor cleanup.
1421
1422 2010-07-06  Darin Adler  <darin@apple.com>
1423
1424         Try to fix Chromium build.
1425
1426         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
1427
1428 2010-07-06  Darin Adler  <darin@apple.com>
1429
1430         Fix build.
1431
1432         * WebKitAPITest/TestsController.cpp:
1433         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
1434
1435 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
1436
1437         Reviewed by Kent Tamura.
1438
1439         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
1440         https://bugs.webkit.org/show_bug.cgi?id=40558
1441
1442         Upstream DevTools for Chromium DRT.
1443         (original Chromium files rev. 51287)
1444
1445         * DumpRenderTree/DumpRenderTree.gypi:
1446         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
1447         (DRTDevToolsAgent::DRTDevToolsAgent):
1448         (DRTDevToolsAgent::setWebView):
1449         (DRTDevToolsAgent::sendMessageToFrontend):
1450         (DRTDevToolsAgent::forceRepaint):
1451         (DRTDevToolsAgent::runtimeFeatureStateChanged):
1452         (DRTDevToolsAgent::injectedScriptSource):
1453         (DRTDevToolsAgent::injectedScriptDispatcherSource):
1454         (DRTDevToolsAgent::debuggerScriptSource):
1455         (DRTDevToolsAgent::asyncCall):
1456         (DRTDevToolsAgent::call):
1457         (DRTDevToolsAgent::webDevToolsAgent):
1458         (DRTDevToolsAgent::attach):
1459         (DRTDevToolsAgent::detach):
1460         (DRTDevToolsAgent::setTimelineProfilingEnabled):
1461         (DRTDevToolsAgent::evaluateInWebInspector):
1462         (DRTDevToolsAgent::dispatchMessageLoop):
1463         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
1464         (DRTDevToolsAgent::~DRTDevToolsAgent):
1465         (DRTDevToolsAgent::hostIdentifier):
1466         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
1467         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1468         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1469         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
1470         (DRTDevToolsCallArgs::callsCount):
1471         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
1472         (DRTDevToolsClient::DRTDevToolsClient):
1473         (DRTDevToolsClient::~DRTDevToolsClient):
1474         (DRTDevToolsClient::sendMessageToAgent):
1475         (DRTDevToolsClient::sendDebuggerCommandToAgent):
1476         (DRTDevToolsClient::activateWindow):
1477         (DRTDevToolsClient::closeWindow):
1478         (DRTDevToolsClient::dockWindow):
1479         (DRTDevToolsClient::undockWindow):
1480         (DRTDevToolsClient::asyncCall):
1481         (DRTDevToolsClient::call):
1482         (DRTDevToolsClient::allMessagesProcessed):
1483         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1484         * DumpRenderTree/chromium/EventSender.cpp:
1485         * DumpRenderTree/chromium/LayoutTestController.cpp:
1486         (LayoutTestController::LayoutTestController):
1487         (LayoutTestController::closeWebInspector):
1488         (LayoutTestController::setTimelineProfilingEnabled):
1489         (LayoutTestController::evaluateInWebInspector):
1490         * DumpRenderTree/chromium/LayoutTestController.h:
1491         * DumpRenderTree/chromium/TestShell.cpp:
1492         (TestShell::TestShell):
1493         (TestShell::~TestShell):
1494         (TestShell::createDRTDevToolsClient):
1495         (TestShell::showDevTools):
1496         (TestShell::closeDevTools):
1497         (TestShell::runFileTest):
1498         (TestShell::createNewWindow):
1499         * DumpRenderTree/chromium/TestShell.h:
1500         (TestShell::drtDevToolsAgent):
1501         (TestShell::drtDevToolsClient):
1502         * DumpRenderTree/chromium/config.h:
1503
1504 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1505
1506         Reviewed by Eric Seidel.
1507
1508         Don't pass image hash to DRT when pixel tests are disabled.
1509         https://bugs.webkit.org/show_bug.cgi?id=41597
1510
1511         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1512
1513 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1514
1515         Reviewed by Eric Seidel.
1516
1517         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1518         https://bugs.webkit.org/show_bug.cgi?id=41612
1519
1520         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1521
1522 2010-07-05  Adam Barth  <abarth@webkit.org>
1523
1524         Reviewed by Eric Seidel.
1525
1526         We should be able to specify a bug to block for webkit-patch upload
1527         https://bugs.webkit.org/show_bug.cgi?id=41648
1528
1529         This will be useful for working on the HTML5 parser.
1530
1531         * Scripts/webkitpy/tool/steps/createbug.py:
1532         * Scripts/webkitpy/tool/steps/options.py:
1533
1534 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1535
1536         Reviewed by Oliver Hunt.
1537
1538         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1539         https://bugs.webkit.org/show_bug.cgi?id=41017
1540
1541         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1542         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1543
1544 2010-07-04  MORITA Hajime  <morrita@google.com>
1545
1546         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1547         https://bugs.webkit.org/show_bug.cgi?id=41589
1548
1549         * run() method can result non-utf-8 bytes, that causes utf-8
1550           decoding fail.  Fixed to disable decoding.
1551         * Fixed Git.find_checkout_root() to make a test pass.
1552
1553         * Scripts/webkitpy/common/checkout/scm.py:
1554         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1555
1556 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1557
1558         Reviewed by Simon Hausmann.
1559
1560         [Qt] Fix DumpRenderTree userStyleSheet handling.
1561         https://bugs.webkit.org/show_bug.cgi?id=41570
1562
1563         DumpRenderTree did only set the userStyleSheet at
1564         layoutTestController.setUserStyleSheetEnabled().
1565
1566         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1567         (LayoutTestController::reset):
1568         (LayoutTestController::setUserStyleSheetLocation):
1569         (LayoutTestController::setUserStyleSheetEnabled):
1570         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1571
1572 2010-07-03  Robert Hogan  <robert@webkit.org>
1573
1574         Reviewed by Kenneth Rohde Christiansen.
1575
1576         [Qt] support dumpChildFrameScrollPositions
1577
1578         https://bugs.webkit.org/show_bug.cgi?id=41088
1579
1580         Unskip:
1581
1582         http/tests/navigation/anchor-subframeload.html
1583         http/tests/navigation/relativeanchor-frames.html
1584
1585         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1586         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1587         (WebCore::DumpRenderTree::dump):
1588         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1589         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1590         (LayoutTestController::reset):
1591         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1592         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1593         (LayoutTestController::dumpChildFrameScrollPositions):
1594
1595 2010-07-02  Sam Weinig  <sam@webkit.org>
1596
1597         Reviewed by Anders Carlsson.
1598
1599         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1600
1601         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1602         * Scripts/debug-webkittestrunner: Removed.
1603         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1604         * Scripts/run-webkittestrunner: Removed.
1605
1606 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1607
1608         Reviewed by Steve Falkenburg.
1609
1610         Some http tests fail on Windows with Cygwin 1.7
1611         https://bugs.webkit.org/show_bug.cgi?id=41537
1612         
1613         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1614         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1615         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1616
1617         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1618         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1619             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1620
1621 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1622
1623         Reviewed by Gustavo Noronha Silva.
1624
1625         [GTK] Separate DerivedSources per-project
1626         https://bugs.webkit.org/show_bug.cgi?id=41109
1627
1628         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1629         allowing the tools to build as a side-effect. Now that the top-level directory
1630         is no longer in the list of JavaScriptCore includes, include it explicitly.
1631
1632         * GNUmakefile.am:
1633
1634 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1635
1636         Reviewed by Kenneth Rohde Christiansen.
1637
1638         [Qt] Make context menus show up in the right place in QTestBrowser
1639
1640         Context menus were shown at scene-relative coordinates for
1641         QGraphicsWebView while QMenu expects them to be global. The
1642         change to the QWidget case was to get rid of the mapToGlobal.
1643
1644         * QtTestBrowser/webview.cpp:
1645
1646 2010-07-01  Robert Hogan <robert@webkit.org>
1647
1648         Reviewed by Kenneth Rohde Christiansen.
1649
1650         [Qt] dump frames in ascending alphabetical order of title
1651
1652         https://bugs.webkit.org/show_bug.cgi?id=41261
1653
1654         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1655         (WebCore::dumpHistoryItem):
1656
1657 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1658
1659         Unreviewed. 
1660
1661         Fix the GTK+ build after r62278.
1662
1663         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1664         let them override the automatic CPU detection for autotools builds.
1665
1666 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1667
1668         Unreviewed.
1669
1670         Fix the Windows build after r62278.
1671
1672         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1673
1674 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1675
1676         Reviewed by Gustavo Noronha Silva.
1677
1678         [GTK] build-webkit does not detect the number of CPUs
1679         https://bugs.webkit.org/show_bug.cgi?id=41469
1680
1681         Pass the appropriate -j<#> flag to make when building autotools builds.
1682         This causes make to spawn that many number of child processes for doing
1683         parallel builds.
1684
1685         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1686         of CPUs. This makes the script work across more platforms.
1687         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1688         number of CPUs across several platforms. Use this new function to determine the appropriate
1689         arguments to pass to make for doing parallel builds with autotools build files.
1690
1691 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1692
1693         Rubber-stamped by Laszlo Gombos.
1694
1695         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1696
1697         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1698         and use the one from WebKit.pri instead.
1699
1700 2010-07-01  Adam Barth  <abarth@webkit.org>
1701
1702         Reviewed by Eric Seidel.
1703
1704         Promote webkit-patch land-safely to main help
1705         https://bugs.webkit.org/show_bug.cgi?id=41446
1706
1707         I've been using this command a bunch and recommending it to folks.  We
1708         should show it in main help as it's past the experimental phase.
1709
1710         * Scripts/webkitpy/tool/commands/upload.py:
1711
1712 2010-06-28  MORITA Hajime  <morrita@google.com>
1713
1714         Reviewed by Shinichiro Hamaji.
1715
1716         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1717         https://bugs.webkit.org/show_bug.cgi?id=38775
1718
1719         - Introduced SCM.show_head() and SCM.diff_for_file().
1720         - Replaced direct svn invocations with newly implement SCM methods.
1721
1722         * Scripts/webkitpy/common/checkout/scm.py:
1723         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1724         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1725
1726 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1727
1728         Reviewed by Sam Weinig.
1729
1730         Allow MiniBrowser to open local files
1731         https://bugs.webkit.org/show_bug.cgi?id=41104
1732
1733         Wire up the openDocument: message with an NSOpenPanel, so we can open
1734         local files.
1735         
1736         Also change the xib so that the window remembers its size.
1737         
1738         * MiniBrowser/mac/AppDelegate.m:
1739         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1740         (-[BrowserAppDelegate openDocument:]):
1741         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1742         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1743
1744 2010-06-30  Sam Weinig  <sam@webkit.org>
1745
1746         Rubber-stamped by Anders Carlsson.
1747
1748         Add debug-webkittestrunner and cleanup related scripts.
1749
1750         * Scripts/debug-webkittestrunner: Added.
1751         * Scripts/run-webkittestrunner:
1752         * Scripts/webkitdirs.pm:
1753
1754 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1755
1756         [wx] Build fix after recent changes to LayoutTestController.
1757
1758         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1759         (LayoutTestController::pageSizeAndMarginsInPixels):
1760
1761 2010-06-29  Sam Weinig  <sam@webkit.org>
1762
1763         Reviewed by Anders Carlsson.
1764
1765         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1766         Make WebKitTestRunner work with more than one test at a time.
1767
1768         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1769         where there is a single WKView and each test is run it, rather than
1770         the design I was using where each test got its own WKView.
1771
1772         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1773         (WTR::InjectedBundle::didRecieveMessage):
1774         (WTR::InjectedBundle::reset):
1775         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1776         * WebKitTestRunner/TestController.cpp:
1777         (WTR::TestController::initialize):
1778         (WTR::TestController::runTest):
1779         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1780         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1781         * WebKitTestRunner/TestController.h:
1782         (WTR::TestController::mainWebView):
1783         (WTR::TestController::pageNamespace):
1784         (WTR::TestController::context):
1785         * WebKitTestRunner/TestInvocation.cpp:
1786         (WTR::TestInvocation::TestInvocation):
1787         (WTR::TestInvocation::~TestInvocation):
1788         (WTR::TestInvocation::invoke):
1789         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1790         * WebKitTestRunner/TestInvocation.h:
1791
1792 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1793
1794         Reviewed by Laszlo Gombos.
1795
1796         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1797         https://bugs.webkit.org/show_bug.cgi?id=40446
1798
1799         We quickly run out of memory on Symbian when loading web pages. This is
1800         caused by the default heap size, which is not suited for a web browser.
1801
1802         This change bumps the max heap size to 32MB.
1803
1804         * QtTestBrowser/QtTestBrowser.pro:
1805
1806 2010-06-30  Eric Seidel  <eric@webkit.org>
1807
1808         Reviewed by Adam Barth.
1809
1810         webkit-patch land allow the user to continue even if the builders are red
1811         https://bugs.webkit.org/show_bug.cgi?id=41395
1812
1813         I don't think it's good that we've been teaching people
1814         to always pass --ignore-builders.  At least land is now
1815         useable w/o --ignore-builders.
1816
1817         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1818
1819 2010-06-29  Robert Hogan  <robert@webkit.org>
1820
1821         Reviewed by Kenneth Rohde Christiansen.
1822
1823         [Qt] support dumpResourceResponseMIMETypes
1824         https://bugs.webkit.org/show_bug.cgi?id=41260
1825
1826         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1827         (LayoutTestController::reset):
1828         (LayoutTestController::dumpResourceResponseMIMETypes):
1829         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1830
1831 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1832
1833         Reviewed by Kenneth Rohde Christiansen.
1834
1835         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1836         https://bugs.webkit.org/show_bug.cgi?id=41173
1837
1838         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1839         (WebCore::WebPage::setViewGeometry):
1840         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1841
1842 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1843
1844         Reviewed by Simon Hausmann.
1845
1846         [Qt] Deal with postEvent in case of graphics based DRT
1847         https://bugs.webkit.org/show_bug.cgi?id=41174
1848
1849         QGraphicsScene does not have a postEvent method, so make scene
1850         send the event, in case of graphics based DRT, and delete it after that.
1851
1852         * DumpRenderTree/qt/EventSenderQt.cpp:
1853         (EventSender::scheduleAsynchronousClick):
1854         (EventSender::replaySavedEvents):
1855         (EventSender::postEvent):
1856         * DumpRenderTree/qt/EventSenderQt.h:
1857
1858 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1859
1860         Reviewed by Kenneth Rohde Christiansen.
1861
1862         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1863         https://bugs.webkit.org/show_bug.cgi?id=41172
1864
1865         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1866         (WebCore::DumpRenderTree::switchFocus):
1867
1868 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1869
1870         Reviewed by Xan Lopez.
1871
1872         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1873         https://bugs.webkit.org/show_bug.cgi?id=40009
1874
1875         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1876         are used when returning those values, for coherency with other ports.
1877
1878         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1879         (AccessibilityUIElement::role):
1880         (AccessibilityUIElement::title):
1881         (AccessibilityUIElement::description):
1882
1883 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1884
1885         Unreviewed, rolling out r62106.
1886         http://trac.webkit.org/changeset/62106
1887         https://bugs.webkit.org/show_bug.cgi?id=41346
1888
1889         "Broke editing tests" (Requested by xan_ on #webkit).
1890
1891         * Scripts/old-run-webkit-tests:
1892
1893 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1894
1895         Reviewed by Xan Lopez.
1896
1897         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1898         https://bugs.webkit.org/show_bug.cgi?id=38648
1899
1900         Add the GTK_MODULES envvar (set to "gail") to the clean
1901         environment when running DRT for the Gtk+ port
1902
1903         * Scripts/old-run-webkit-tests:
1904
1905 2010-06-28  Adam Barth  <abarth@webkit.org>
1906
1907         Unreviewed.
1908
1909         Switch test-html5-parser back to using runner.html.
1910
1911         * Scripts/test-html5-parser:
1912
1913 2010-06-28  Adam Barth  <abarth@webkit.org>
1914
1915         Reviewed by Eric Seidel.
1916
1917         Restore webkit-runner.html for use with new tree builder
1918         https://bugs.webkit.org/show_bug.cgi?id=41317
1919
1920         For now, we just want to run webkit-runner when we test-html5-parser.
1921
1922         * Scripts/test-html5-parser:
1923
1924 2010-06-23  John Gregg  <johnnyg@google.com>
1925
1926         Reviewed by Kent Tamura.
1927
1928         add ENABLE_DIRECTORY_UPLOAD build support
1929         https://bugs.webkit.org/show_bug.cgi?id=41100
1930
1931         * Scripts/build-webkit:
1932
1933 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1934
1935         Rubber-stamped by Xan Lopez.
1936
1937         Update webkitdirs's knowledge of our library's name.
1938
1939         * Scripts/webkitdirs.pm:
1940
1941 2010-06-28  Sam Weinig  <sam@webkit.org>
1942
1943         Reviewed by Anders Carlsson.
1944
1945         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1946         Build up WebKitTestRunner output in the InjectedBundle
1947
1948         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1949         and sending it over postMessage when done, instead of using the async
1950         WKPageRenderTreeExternalRepresentation.
1951
1952         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1953         (WTR::InjectedBundle::done):
1954         (WTR::InjectedBundle::didRecieveMessage):
1955         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1956         (WTR::InjectedBundle::os):
1957         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1958         (WTR::WKStringToUTF8):
1959         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1960         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1961         * WebKitTestRunner/TestInvocation.cpp:
1962         (WTR::WKStringToUTF8):
1963         (WTR::TestInvocation::TestInvocation):
1964         (WTR::TestInvocation::invoke):
1965         (WTR::TestInvocation::initializeMainWebView):
1966         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1967         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1968         * WebKitTestRunner/TestInvocation.h:
1969
1970 2010-06-28  Robert Hogan  <robert@webkit.org>
1971
1972         Unreviewed, rolling out r62021.
1973         http://trac.webkit.org/changeset/62021
1974         https://bugs.webkit.org/show_bug.cgi?id=41261
1975
1976         Broke http/navigation tests among other
1977
1978         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1979         (WebCore::DumpRenderTree::dumpFramesAsText):
1980
1981 2010-06-28  Sam Weinig  <sam@webkit.org>
1982
1983         Reviewed by Anders Carlsson.
1984
1985         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1986         environment.
1987
1988         * Scripts/run-webkittestrunner: Added.
1989         * Scripts/webkitdirs.pm:
1990
1991 2010-06-28  Robert Hogan  <robert@webkit.org>
1992
1993         Reviewed by Kenneth Rohde Christiansen.
1994
1995         [Qt] dump frames in ascending alphabetical order of title
1996
1997         https://bugs.webkit.org/show_bug.cgi?id=41261
1998
1999         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2000         (WebCore::DumpRenderTree::dumpFramesAsText):
2001
2002 2010-06-28  Robert Hogan  <robert@webkit.org>
2003
2004         Reviewed by Kenneth Rohde Christiansen.
2005
2006         [Qt] dump bf history of child windows
2007
2008         https://bugs.webkit.org/show_bug.cgi?id=41266
2009
2010         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2011         (WebCore::DumpRenderTree::dumpBackForwardList):
2012         (WebCore::DumpRenderTree::dump):
2013         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2014
2015 2010-06-28  Sam Weinig  <sam@webkit.org>
2016
2017         Reviewed by Anders Carlsson.
2018
2019         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
2020         WebKit2: Add frame API for InjectedBundle code
2021
2022         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2023         (_didClearWindowForFrame):
2024
2025 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2026
2027         Reviewed by Kenneth Rohde Christiansen.
2028
2029         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
2030         https://bugs.webkit.org/show_bug.cgi?id=38597
2031
2032         Fix behavior so reload button really acts as a load and a reload button.
2033
2034         * QtTestBrowser/mainwindow.cpp:
2035         (MainWindow::changeLocation):
2036
2037 2010-06-28  Xan Lopez  <xlopez@igalia.com>
2038
2039         Reviewed by Gustavo Noronha.
2040
2041         [GTK] Does not compile with -DGSEAL_ENABLE
2042         https://bugs.webkit.org/show_bug.cgi?id=37851
2043
2044         Fix build with GSEAL enabled.
2045
2046         * DumpRenderTree/gtk/EventSender.cpp:
2047         (gtk_widget_get_window):
2048         (prepareMouseButtonEvent):
2049         (mouseMoveToCallback):
2050         (mouseWheelToCallback):
2051         (keyDownCallback):
2052
2053 2010-06-28  Xan Lopez  <xlopez@igalia.com>
2054
2055         Reviewed by Gustavo Noronha.
2056
2057         [GTK] Add support for GTK+3
2058         https://bugs.webkit.org/show_bug.cgi?id=41253
2059
2060         Adapt build system for 3.x support.
2061
2062         * GNUmakefile.am:
2063
2064 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2065
2066         Reviewed by Simon Hausmann.
2067
2068         [QT][S60] build-webkit scripts picks wrong make spec for windows build
2069         https://bugs.webkit.org/show_bug.cgi?id=41198
2070
2071         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
2072
2073         * Scripts/webkitdirs.pm:
2074         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
2075
2076 2010-06-28  Eric Seidel  <eric@webkit.org>
2077
2078         Reviewed by Adam Barth.
2079
2080         Make it possible to test the new HTML5 TreeBuilder
2081         https://bugs.webkit.org/show_bug.cgi?id=41276
2082
2083         Adam was concerned that someone might make their port
2084         depend on this setting (I guess we had some trouble with that
2085         with the HTML5Parser setting), so I littered the code with warnings.
2086
2087         test-html5-parser now tests this code path.
2088
2089         * DumpRenderTree/mac/DumpRenderTree.mm:
2090         (resetDefaultsToConsistentValues):
2091         (initializeGlobalsFromCommandLineOptions):
2092         * Scripts/test-html5-parser:
2093
2094 2010-06-27  MORITA Hajime  <morrita@google.com>
2095
2096         Unreviewed. 
2097         
2098         Some never-called @staticmethods touched self. 
2099         Fixed it to replace these self with a class.
2100
2101         * Scripts/webkitpy/common/checkout/scm.py:
2102
2103 2010-06-27  MORITA Hajime  <morrita@google.com>
2104
2105         Unreviewed.
2106         
2107         Fixed exception raising syntax that is pointed out at
2108         https://bugs.webkit.org/show_bug.cgi?id=41153
2109
2110         * Scripts/webkitpy/common/checkout/scm.py:
2111         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
2112           Removed a bad line that I accidentally checked-in at last revision.
2113
2114 2010-06-24  MORITA Hajime  <morrita@google.com>
2115
2116         Reviewed by Eric Seidel.
2117
2118         rebaseline-chromium-webkit-tests should add or remove files to local git repository
2119         https://bugs.webkit.org/show_bug.cgi?id=41153
2120
2121         - Added SCM.add() and SCM.remove()
2122         - Replaced "svn add" and "svn remove"
2123           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
2124         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
2125           for debugging purpose.
2126
2127         * Scripts/webkitpy/common/checkout/scm.py:
2128         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2129         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2130
2131 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
2132
2133         Reviewed by Shinichiro Hamaji.
2134
2135         Improve default value handling for page format properties.
2136         https://bugs.webkit.org/show_bug.cgi?id=41150
2137
2138         * DumpRenderTree/LayoutTestController.cpp:
2139         (parsePageNumber):
2140         (parsePageNumberSizeMarings):
2141         (pageSizeAndMarginsInPixelsCallback):
2142         (LayoutTestController::staticFunctions):
2143         * DumpRenderTree/LayoutTestController.h:
2144         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2145         (LayoutTestController::pageSizeAndMarginsInPixels):
2146         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2147         (LayoutTestController::pageSizeAndMarginsInPixels):
2148         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2149         (LayoutTestController::pageSizeAndMarginsInPixels):
2150
2151 2010-06-21  Robert Hogan  <robert@webkit.org>
2152
2153         Reviewed by Kenneth Rohde Christiansen.
2154
2155         [Qt] DRT Support for setCustomPolicyDelegate
2156
2157         https://bugs.webkit.org/show_bug.cgi?id=39564
2158
2159         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2160         (LayoutTestController::setCustomPolicyDelegate):
2161         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2162
2163 2010-06-26  Robert Hogan  <robert@webkit.org>
2164
2165         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
2166         
2167         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
2168         exported.
2169
2170         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2171
2172 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
2173
2174         Reviewed by Dimitri Glazkov.
2175
2176         Add a build-webkit option for enabling Web Timing support.
2177         https://bugs.webkit.org/show_bug.cgi?id=38924
2178
2179         * Scripts/build-webkit:
2180
2181 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2182
2183         Reviewed by Kenneth Rohde Christiansen.
2184
2185         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
2186         https://bugs.webkit.org/show_bug.cgi?id=38597
2187
2188         Make the reload button act as a load button as well.
2189
2190         * QtTestBrowser/mainwindow.cpp:
2191         (MainWindow::buildUI):
2192         (MainWindow::changeLocation):
2193
2194 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
2195
2196         Reviewed by Dmitry Titov.
2197
2198         Add empty abortModal() method to all platforms.
2199         https://bugs.webkit.org/show_bug.cgi?id=40864
2200
2201         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
2202         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
2203         that use abortModal will become mac specific which is not desirable.
2204
2205         * DumpRenderTree/LayoutTestController.cpp:
2206         (abortModalCallback):
2207         (LayoutTestController::staticFunctions):
2208         * DumpRenderTree/LayoutTestController.h:
2209         * DumpRenderTree/chromium/LayoutTestController.cpp:
2210         (LayoutTestController::LayoutTestController):
2211         (LayoutTestController::abortModal):
2212         * DumpRenderTree/chromium/LayoutTestController.h:
2213         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2214         (LayoutTestController::abortModal):
2215         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2216         (LayoutTestController::abortModal):
2217         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2218         (LayoutTestController::abortModal):
2219         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2220         (LayoutTestController::abortModal):
2221
2222 2010-06-25  Sam Weinig  <sam@webkit.org>
2223
2224         Reviewed by Anders Carlsson.
2225
2226         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
2227         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
2228
2229         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
2230         (WTR::InjectedBundle::shared):
2231         (WTR::InjectedBundle::InjectedBundle):
2232         (WTR::InjectedBundle::_didCreatePage):
2233         (WTR::InjectedBundle::_willDestroyPage):
2234         (WTR::InjectedBundle::_didRecieveMessage):
2235         (WTR::InjectedBundle::initialize):
2236         (WTR::InjectedBundle::didCreatePage):
2237         (WTR::InjectedBundle::willDestroyPage):
2238         (WTR::InjectedBundle::didRecieveMessage):
2239         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
2240         (WTR::InjectedBundle::layoutTestController):
2241         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2242         (WKBundleInitialize):
2243         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
2244         (WTR::InjectedBundlePage::InjectedBundlePage):
2245         (WTR::InjectedBundlePage::~InjectedBundlePage):
2246         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
2247         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
2248         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
2249         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
2250         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
2251         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
2252         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
2253         (WTR::InjectedBundlePage::_didClearWindowForFrame):
2254         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2255         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2256         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2257         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2258         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2259         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2260         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2261         (WTR::InjectedBundlePage::didClearWindowForFrame):
2262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
2263         (WTR::InjectedBundlePage::page):
2264         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
2265         (WTR::LayoutTestController::create):
2266         (WTR::LayoutTestController::LayoutTestController):
2267         (WTR::LayoutTestController::~LayoutTestController):
2268         (WTR::dumpAsTextCallback):
2269         (WTR::layoutTestControllerObjectFinalize):
2270         (WTR::LayoutTestController::makeWindowObject):
2271         (WTR::LayoutTestController::getJSClass):
2272         (WTR::LayoutTestController::staticFunctions):
2273         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
2274         (WTR::LayoutTestController::dumpAsText):
2275         (WTR::LayoutTestController::setDumpAsText):
2276         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2277
2278 2010-06-25  Sam Weinig  <sam@webkit.org>
2279
2280         Reviewed by Anders Carlsson.
2281
2282         Make WebKitTestRunner really work with run-webkit-tests. 
2283
2284         - Add Forwarding headers to allow some cleanup.
2285
2286         * WebKitTestRunner/ForwardingHeaders: Added.
2287         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
2288         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
2289         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
2290         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
2291         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
2292         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
2293         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
2294         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
2295         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
2296         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
2297         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
2298         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
2299         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
2300         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
2301         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
2302         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
2303         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
2304         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
2305         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
2306         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
2307         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
2308         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
2309         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
2310         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
2311         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
2312         * WebKitTestRunner/TestInvocation.cpp:
2313         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
2314         * WebKitTestRunner/TestInvocation.h:
2315
2316 2010-06-25  Sam Weinig  <sam@webkit.org>
2317
2318         Reviewed by Mark Rowe.
2319
2320         Add support for WebKitTestRunner to old-run-webkit-tests
2321
2322         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
2323
2324         * Scripts/build-webkittestrunner: Added.
2325         * Scripts/old-run-webkit-tests:
2326
2327 2010-06-25  Adam Barth  <abarth@webkit.org>
2328
2329         Reviewed by David Levin.
2330
2331         Incremental build failed on Chromium ews
2332         https://bugs.webkit.org/show_bug.cgi?id=41011
2333
2334         The division of responsibility between update-webkit --chromium and
2335         build-webkit --chromium is slightly unclear.  In this patch, we make
2336         build-webkit --chromium also update DEPS and re-run GYP in case the
2337         developer has changed either since they updated.
2338
2339         This change is also helpful for the EWS, which wants to update DEPS and
2340         re-run GYP after applying patches, but the EWS doesn't want to run
2341         update-webkit --chromium because it has a dirty working copy.
2342
2343         * Scripts/webkitdirs.pm:
2344
2345 2010-06-25  Robert Hogan  <robert@webkit.org>
2346
2347         Reviewed by Simon Hausmann.
2348
2349         [Qt] Support evaluateScriptInIsolatedWorld()
2350
2351         https://bugs.webkit.org/show_bug.cgi?id=40079
2352
2353         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
2354         Remove QWebScriptWorld from exported headers.
2355         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
2356
2357         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2358         (LayoutTestController::reset):
2359         (LayoutTestController::evaluateScriptInIsolatedWorld):
2360         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2361
2362 2010-06-25  Anders Carlsson  <andersca@apple.com>
2363
2364         Revert accidental part and add a newline.
2365
2366         * MiniBrowser/mac/AppDelegate.m:
2367         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2368
2369 2010-06-25  Anders Carlsson  <andersca@apple.com>
2370
2371         Rubber-stamped by Dan Bernstein.
2372
2373         Add a LOG macro that expands to a no-op by default.
2374
2375         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2376         * MiniBrowser/mac/AppDelegate.m:
2377         (_didRecieveMessageFromInjectedBundle):
2378         * MiniBrowser/mac/BrowserWindowController.m:
2379         (-[BrowserWindowController windowShouldClose:]):
2380         (_didStartProvisionalLoadForFrame):
2381         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2382         (_didFailProvisionalLoadWithErrorForFrame):
2383         (_didCommitLoadForFrame):
2384         (_didFinishLoadForFrame):
2385         (_didFailLoadWithErrorForFrame):
2386         (_didReceiveTitleForFrame):
2387         (_didFirstLayoutForFrame):
2388         (_didFirstVisuallyNonEmptyLayoutForFrame):
2389         (_didBecomeUnresponsive):
2390         (_didBecomeResponsive):
2391         (_decidePolicyForNavigationAction):
2392         (_decidePolicyForNewWindowAction):
2393         (_createNewPage):
2394         (_showPage):
2395         (_closePage):
2396         (_didNavigateWithNavigationData):
2397         (_didPerformClientRedirect):
2398         (_didPerformServerRedirect):
2399         (_didUpdateHistoryTitle):
2400         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2401         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2402         (_didClearWindowForFrame):
2403         (_didCreatePage):
2404         (_willDestroyPage):
2405         (_didRecieveMessage):
2406
2407 2010-06-24  Adam Barth  <abarth@webkit.org>
2408
2409         Reviewed by Eric Seidel.
2410
2411         commit-queue is taking too long to land patches because of red trees
2412         https://bugs.webkit.org/show_bug.cgi?id=41194
2413
2414         Instead of checking for the tree to be green, we'll just spin hot
2415         trying to land patches.  This is probably too extreme in ignoring the
2416         tree, but I think we should try it for a while to see if we have
2417         trouble.  That will help us find the right balance.
2418
2419         * Scripts/webkitpy/tool/commands/queues.py:
2420         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2421
2422 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2423
2424         Reviewed by Xan Lopez.
2425
2426         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
2427         https://bugs.webkit.org/show_bug.cgi?id=40843
2428
2429         Define the version for old GTK+s in a way that is forward-compatible
2430         and clean up the logic a bit.
2431
2432         * DumpRenderTree/gtk/EventSender.cpp:
2433         (gdk_window_get_root_coords): Renamed and cleaned up.
2434         (prepareMouseButtonEvent): Remove #ifdefs.
2435         (mouseMoveToCallback): Remove #ifdefs.
2436
2437 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
2438
2439         Reviewed by Eric Seidel.
2440
2441         Fix NewRunWebKitTests to work on Windows.
2442         https://bugs.webkit.org/show_bug.cgi?id=41180
2443
2444         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
2445             because Windows fails to understand what we're asking of it.
2446
2447 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2448
2449         Reviewed by Xan Lopez.
2450
2451         [GTK] The url passed to the WebView during layout tests is invalid
2452         https://bugs.webkit.org/show_bug.cgi?id=40832
2453
2454         Set the test URL to the full real file URL and do a small cleanup.
2455         Previously a URL like file://relative/path/to/test.html was passed
2456         to the WebView. This malformed file URL would be returned by
2457         webkit_web_view_get_url and webkit_web_frame_get_url.
2458
2459         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2460         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
2461         (shouldOpenWebInspector): Change to take a const string& as the argument.
2462         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
2463         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2464
2465 2010-06-24  Sam Weinig  <sam@webkit.org>
2466
2467         Reviewed by Anders Carlsson.
2468
2469         Fix WebKitTestRunner Makefile typos.
2470
2471         * WebKitTestRunner/Makefile:
2472
2473 2010-06-24  Adele Peterson  <adele@apple.com>
2474
2475         Reviewed by Eric Carlson.
2476
2477         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2478         https://bugs.webkit.org/show_bug.cgi?id=41085
2479
2480         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2481         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2482
2483 2010-06-23  Sam Weinig  <sam@webkit.org>
2484
2485         Reviewed by Anders Carlsson.
2486
2487         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2488         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2489
2490         - Mac only.
2491         - run-webkit-tests has not been modified to call it yet.
2492         - Only dumps the render tree at this time. 
2493
2494         * WebKitTestRunner: Added.
2495         * WebKitTestRunner/Configurations: Added.
2496         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2497         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2498         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2499         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2500         * WebKitTestRunner/InjectedBundle: Added.
2501         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2502         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2503         (_didStartProvisionalLoadForFrame):
2504         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2505         (_didFailProvisionalLoadWithErrorForFrame):
2506         (_didCommitLoadForFrame):
2507         (_didFinishLoadForFrame):
2508         (_didFailLoadWithErrorForFrame):
2509         (_didReceiveTitleForFrame):
2510         (_didClearWindow):
2511         (_didCreatePage):
2512         (_willDestroyPage):
2513         (_didRecieveMessage):
2514         (WKBundleInitialize):
2515         * WebKitTestRunner/Makefile: Added.
2516         * WebKitTestRunner/PlatformWebView.h: Added.
2517         (WTR::PlatformWebView::platformView):
2518         * WebKitTestRunner/TestController.cpp: Added.
2519         (WTR::TestController::shared):
2520         (WTR::TestController::TestController):
2521         (WTR::TestController::initialize):
2522         (WTR::TestController::runTest):
2523         (WTR::TestController::runTestingServerLoop):
2524         (WTR::TestController::run):
2525         * WebKitTestRunner/TestController.h: Added.
2526         (WTR::TestController::verbose):
2527         (WTR::TestController::injectedBundlePath):
2528         * WebKitTestRunner/TestInvocation.cpp: Added.
2529         (WTR::createWKURL):
2530         (WTR::TestInvocation::TestInvocation):
2531         (WTR::TestInvocation::~TestInvocation):
2532         (WTR::TestInvocation::invoke):
2533         (WTR::TestInvocation::dump):
2534         (WTR::TestInvocation::initializeMainWebView):
2535         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2536         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2537         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2538         (WTR::TestInvocation::didCommitLoadForFrame):
2539         (WTR::TestInvocation::didFinishLoadForFrame):
2540         (WTR::TestInvocation::didFailLoadForFrame):
2541         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2542         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2543         * WebKitTestRunner/TestInvocation.h: Added.
2544         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2545         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2546         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2547         * WebKitTestRunner/mac: Added.
2548         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2549         (WTR::PlatformWebView::PlatformWebView):
2550         (WTR::PlatformWebView::~PlatformWebView):
2551         (WTR::PlatformWebView::page):
2552         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2553         (WTR::TestInvocation::runUntil):
2554         * WebKitTestRunner/mac/main.mm: Added.
2555         (main):
2556
2557 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2558
2559         Unreviewed. Adding myself to the committers list.
2560
2561         * Scripts/webkitpy/common/config/committers.py:
2562
2563 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2564
2565         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2566
2567         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2568         (LayoutTestController::isPageBoxVisible):
2569         (LayoutTestController::pageAreaRectInPixels):
2570         (LayoutTestController::preferredPageSizeInPixels):
2571         * wx/build/settings.py:
2572
2573 2010-06-23  James Robinson  <jamesr@chromium.org>
2574
2575         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2576
2577         * Scripts/webkitpy/common/config/committers.py:
2578
2579 2010-06-23  Kent Tamura  <tkent@chromium.org>
2580
2581         Reviewed by Dimitri Glazkov.
2582
2583         Correct Chromium test configuration
2584         https://bugs.webkit.org/show_bug.cgi?id=41057
2585
2586         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2587          - Add "--use-drt" option for NRWT. It is required for Chromium and
2588            ignored for other platforms.
2589          - Skip JSC test on Chromium
2590         * BuildSlaveSupport/test-result-archive:
2591           Add Chromium support.
2592
2593 2010-06-23  Sam Weinig  <sam@webkit.org>
2594
2595         Reviewed by Anders Carlsson.
2596
2597         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2598         WebKit2: Flesh out more of the InjectedBundle client API
2599
2600         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2601         (_didStartProvisionalLoadForFrame):
2602         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2603         (_didFailProvisionalLoadWithErrorForFrame):
2604         (_didCommitLoadForFrame):
2605         (_didFinishLoadForFrame):
2606         (_didFailLoadWithErrorForFrame):
2607         (_didReceiveTitleForFrame):
2608         (_didClearWindowForFrame):
2609         (_didCreatePage):
2610         (_willDestroyPage):
2611         (WKBundleInitialize):
2612
2613 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2614
2615         Reviewed by Shinichiro Hamaji.
2616
2617         Implement page format data programming interface.
2618         Add methods for testing.
2619         https://bugs.webkit.org/show_bug.cgi?id=37538
2620
2621         * DumpRenderTree/LayoutTestController.cpp:
2622         (parsePageNumber):
2623         (isPageBoxVisibleCallback):
2624         (pageAreaRectInPixelsCallback):
2625         (preferredPageSizeInPixelsCallback):
2626         (LayoutTestController::staticFunctions):
2627         * DumpRenderTree/LayoutTestController.h:
2628         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2629         (LayoutTestController::isPageBoxVisible):
2630         (LayoutTestController::pageAreaRectInPixels):
2631         (LayoutTestController::preferredPageSizeInPixels):
2632         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2633         (LayoutTestController::isPageBoxVisible):
2634         (LayoutTestController::pageAreaRectInPixels):
2635         (LayoutTestController::preferredPageSizeInPixels):
2636         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2637         (LayoutTestController::isPageBoxVisible):
2638         (LayoutTestController::pageAreaRectInPixels):
2639         (LayoutTestController::preferredPageSizeInPixels):
2640
2641 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2642
2643         Reviewed by Shinichiro Hamaji.
2644
2645         Follow proper convention for if/switch/while as I've discovered
2646         them to be through my review processes.
2647         https://bugs.webkit.org/show_bug.cgi?id=40723
2648
2649         Modified test so that if( foo ) is not allowed as it appears not
2650         to be the accepted convention.
2651
2652         * Scripts/webkitpy/style/checkers/cpp.py:
2653         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2654
2655 2010-06-22  Eric Seidel  <eric@webkit.org>
2656
2657         Reviewed by Adam Barth.
2658
2659         Run clean-header-guards to fix some header guards
2660         https://bugs.webkit.org/show_bug.cgi?id=41044
2661
2662         No functional changes, thus no tests.
2663
2664         This entire change was generated by running
2665         clean-header-guards, and then reverting changes
2666         to files which shouldn't be changed.  Those which
2667         are left all should be updated.
2668
2669         Some of these changes are just fixing 755 permissions
2670         to be 644, since it seems various files have the wrong
2671         execute bit which don't need it.  clean-header-guards
2672         made those (welcome) permission fixes unintentionally.
2673
2674         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2675         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2676         * QtTestBrowser/fpstimer.h:
2677
2678 2010-06-22  Adam Barth  <abarth@webkit.org>
2679
2680         Reviewed by Eric Seidel.
2681
2682         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2683         https://bugs.webkit.org/show_bug.cgi?id=41043
2684
2685         Update the hash.
2686
2687         * Scripts/do-webcore-rename:
2688
2689 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2690
2691         Reviewed by Shinichiro Hamaji.
2692
2693         Follow proper convention for variable declaration spacing.
2694         https://bugs.webkit.org/show_bug.cgi?id=40724
2695
2696         Modified test so that 'int   a;' is not allowed.
2697
2698         * Scripts/webkitpy/style/checkers/cpp.py:
2699         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2700
2701 2010-06-22  Eric Seidel  <eric@webkit.org>
2702
2703         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2704
2705         * Scripts/webkitpy/common/config/committers.py:
2706
2707 2010-06-22  Eric Seidel  <eric@webkit.org>
2708
2709         Reviewed by Adam Barth.
2710
2711         Remove Gtk 64-Release bot from core since it's broken
2712         https://bugs.webkit.org/show_bug.cgi?id=41022
2713
2714         This bot alone has been responsible for more than 72 hours of
2715         commit-queue blockage in the last week.  The bot is broken -- keeps
2716         losing its display server or similar.  Until the Gtk folks can fix the
2717         bot, we need to remove it from core.  The WebKit community can't keep
2718         it green as is.
2719
2720         * Scripts/webkitpy/common/net/buildbot.py:
2721         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2722
2723 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2724
2725         Reviewed by Eric Seidel.
2726
2727         Fix the Windows build.
2728         https://bugs.webkit.org/show_bug.cgi?id=40972
2729
2730         * DumpRenderTree/win/ImageDiff.vcproj:
2731
2732 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2733
2734         Reviewed by Darin Adler, Dmitry Titov.
2735
2736         DumpRenderTree should allow tests with modal dialogs
2737         https://bugs.webkit.org/show_bug.cgi?id=35350
2738
2739         * DumpRenderTree/LayoutTestController.cpp:
2740         (abortModalCallback):
2741         (LayoutTestController::staticFunctions):
2742         * DumpRenderTree/LayoutTestController.h:
2743         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2744         (LayoutTestController::abortModal):
2745         Add abortModal method to LayoutTestController and make it available from script.
2746
2747         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2748         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2749         abortModal from when modal window closes.
2750         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2751
2752 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2753
2754         Reviewed by Anders Carlsson.
2755         
2756         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2757         https://bugs.webkit.org/show_bug.cgi?id=40948
2758         
2759         Have the script look in WebKit2.
2760
2761         * Scripts/do-webcore-rename:
2762
2763 2010-06-21  Robert Hogan  <robert@webkit.org>
2764
2765         Reviewed by Kenneth Rohde Christiansen.
2766
2767         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2768
2769         It's a Mac-specific test so just add the required LayoutTestController
2770         function as a no-op to avoid failing. Similar approach adopted by other
2771         ports.
2772
2773         https://bugs.webkit.org/show_bug.cgi?id=33344
2774
2775         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2776         (LayoutTestController::addDisallowedURL):
2777
2778 2010-06-21  Sam Weinig  <sam@webkit.org>
2779
2780         Reviewed by Anders Carlsson.
2781
2782         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2783         Add message passing support to the WebKit2 API.
2784
2785         - Add some test messages.
2786
2787         * MiniBrowser/mac/AppDelegate.m:
2788         (_didRecieveMessageFromInjectedBundle):
2789         (-[BrowserAppDelegate init]):
2790         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2791         (_didClearWindow):
2792         (_didCreatePage):
2793         (_didRecieveMessage):
2794         (WKBundleInitialize):
2795
2796 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2797
2798         Unreviewed.
2799
2800         Rolling back 61551 and 61555 due to test failures.
2801
2802         * DumpRenderTree/LayoutTestController.cpp:
2803         (LayoutTestController::staticFunctions):
2804         * DumpRenderTree/LayoutTestController.h:
2805         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2806         (LayoutTestController::setEditingBehavior):
2807         * DumpRenderTree/mac/UIDelegate.mm:
2808
2809 2010-06-21  Anders Carlsson  <andersca@apple.com>
2810
2811         Reviewed by Sam Weinig.
2812
2813         Make DumpRenderTree build with clang++
2814
2815         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2816         (-[LocalPasteboard setPropertyList:forType:]):
2817         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2818         (-[DumpRenderTreeWindow keyDown:]):
2819         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2820         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2821         (LayoutTestController::isCommandEnabled):
2822
2823 2010-06-21  Satish Sampath  <satish@chromium.org>
2824
2825         Reviewed by Steve Block.
2826
2827         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2828         https://bugs.webkit.org/show_bug.cgi?id=40878
2829
2830         * Scripts/build-webkit:
2831
2832 2010-06-21  Kent Tamura  <tkent@chromium.org>
2833
2834         Reviewed by Dimitri Glazkov.
2835
2836         [DRT/Chromium] Initialization for http/tests/loading/
2837         https://bugs.webkit.org/show_bug.cgi?id=40902
2838
2839         * DumpRenderTree/chromium/TestShell.cpp:
2840         (TestShell::runFileTest):
2841
2842 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2843
2844         Unreviewed.
2845
2846         Adding myself to the committers list.
2847
2848         * Scripts/webkitpy/common/config/committers.py:
2849
2850 2010-06-20  Kent Tamura  <tkent@chromium.org>
2851
2852         Reviewed by Dimitri Glazkov.
2853
2854         [DRT/Chromium] Add --allow-external-pages option
2855         https://bugs.webkit.org/show_bug.cgi?id=40762
2856
2857         Add --allow-external-pages introduced by Chromium r45403.
2858         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2859
2860         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2861         (main):
2862         * DumpRenderTree/chromium/TestShell.cpp:
2863         (TestShell::TestShell):
2864         * DumpRenderTree/chromium/TestShell.h:
2865         (TestShell::allowExternalPages):
2866         (TestShell::setAllowExternalPages):
2867         * DumpRenderTree/chromium/WebViewHost.cpp:
2868         (WebViewHost::willSendRequest):
2869
2870 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2871
2872         Reviewed by Adam Barth.
2873
2874         Sheriffbot: Should allow "r" in SVN_REVISION
2875         https://bugs.webkit.org/show_bug.cgi?id=40889
2876
2877         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2878         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2879
2880 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2881
2882         Reviewed by Dimitri Glazkov.
2883
2884         Python Tests Fail after r61508
2885         https://bugs.webkit.org/show_bug.cgi?id=40891
2886
2887         Test's regex list needed to be updated to match the new
2888         regex list in the source code. Added new bots to the
2889         example_buildbots list.
2890
2891         Regex list fixed in r61512. Updated bot list.
2892
2893         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2894
2895 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2896
2897         Unreviewed, build fix.
2898
2899         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2900
2901         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2902
2903 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2904
2905         Unreviewed.
2906
2907         Adding myself to the committers list.
2908
2909         * Scripts/webkitpy/common/config/committers.py:
2910
2911 2010-06-19  Sam Weinig  <sam@webkit.org>
2912
2913         Reviewed by Anders Carlsson.
2914
2915         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2916         Add ability to have a WebProcess per WebContext.
2917
2918         Move to use new shared contexts API.
2919
2920         * MiniBrowser/mac/AppDelegate.h:
2921         * MiniBrowser/mac/AppDelegate.m:
2922         (-[BrowserAppDelegate init]):
2923         (-[BrowserAppDelegate getCurrentPageNamespace]):
2924         (-[BrowserAppDelegate validateMenuItem:]):
2925         (-[BrowserAppDelegate _setProcessModel:]):
2926         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2927         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2928         * MiniBrowser/win/BrowserView.cpp:
2929         (BrowserView::create):
2930
2931 2010-06-02  Robert Hogan  <robert@webkit.org>
2932
2933         Reviewed by Adam Barth.
2934
2935         [Qt] Support evaluateScriptInIsolatedWorld()
2936
2937         https://bugs.webkit.org/show_bug.cgi?id=40079
2938
2939         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2940         (LayoutTestController::evaluateScriptInIsolatedWorld):
2941         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2942
2943 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2944
2945         Reviewed by Darin Adler.
2946
2947         Add three more non-core Chromium builders to start testing DumpRenderTree.
2948         https://bugs.webkit.org/show_bug.cgi?id=40335
2949
2950         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2951
2952 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2953
2954         Reviewed by Darin Fisher.
2955
2956         [Chromium] Plumbing for top-level frame names
2957         https://bugs.webkit.org/show_bug.cgi?id=40430
2958
2959         * DumpRenderTree/chromium/WebViewHost.cpp:
2960         (WebViewHost::reset):
2961         Changed obsolete call to clearName() to use setName(WebString()) instead.
2962
2963 2010-06-18  Sam Weinig  <weinig@apple.com>
2964
2965         Rolling http://trac.webkit.org/changeset/61297 back in.
2966
2967         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2968         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2969         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2970         (_didClearWindow):
2971         (_didCreatePage):
2972         (WKBundleInitialize):
2973
2974 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2975
2976         Reviewed by Darin Adler.
2977
2978         https://bugs.webkit.org/show_bug.cgi?id=40803
2979         TestNetscapePlugin has an incorrect implementation of "property" property
2980
2981         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2982         pass a static string back, it's going to be released by NPAPI implementation.
2983
2984 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2985
2986         Unreviewed.
2987
2988         Adding myself to the committers list.
2989
2990         * Scripts/webkitpy/common/config/committers.py:
2991
2992 2010-06-17  Tony Chang  <tony@chromium.org>
2993
2994         Reviewed by Kent Tamura.
2995
2996         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2997         https://bugs.webkit.org/show_bug.cgi?id=40615
2998
2999         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
3000
3001 2010-06-17  Ada Chan  <adachan@apple.com>
3002
3003         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
3004
3005         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3006         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
3007         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
3008
3009 2010-06-17  Darin Adler  <darin@apple.com>
3010
3011         One more try at fix for Chromium build.
3012
3013         * DumpRenderTree/chromium/TestShell.cpp:
3014         (TestShell::TestShell): Use set again instead of =.
3015
3016 2010-06-17  Darin Adler  <darin@apple.com>
3017
3018         Fix Chromium build.
3019
3020         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
3021         code with all the other platforms! Wow, that should be fixed at some point.
3022
3023         * DumpRenderTree/chromium/TestShell.cpp:
3024         (TestShell::TestShell): Changed back to using "new".
3025         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
3026
3027 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
3028
3029         Unreviewed Qt build fix.
3030
3031         LayoutTestController in the Qt DRT is not using refs :)
3032
3033         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3034         (WebCore::DumpRenderTree::DumpRenderTree):
3035
3036 2010-06-17  Darin Adler  <darin@apple.com>
3037
3038         Reviewed by Sam Weinig.
3039
3040         Use adoptRef and create functions in more code paths
3041         https://bugs.webkit.org/show_bug.cgi?id=40760
3042
3043         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
3044
3045         * DumpRenderTree/LayoutTestController.cpp:
3046         (LayoutTestController::create): Added.
3047         * DumpRenderTree/LayoutTestController.h: Declare the create function.
3048
3049         * DumpRenderTree/chromium/TestShell.cpp:
3050         (TestShell::TestShell): Use create instead of new.
3051         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
3052
3053         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3054         (runTest): Use RefPtr and create instead of OwnPtr and new.
3055
3056         * DumpRenderTree/mac/DumpRenderTree.mm:
3057         (runTest): Use RefPtr and create instead of OwnPtr and new.
3058
3059         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3060         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
3061         instead of new.
3062
3063         * DumpRenderTree/win/DumpRenderTree.cpp:
3064         (runTest): Use RefPtr and create instead of OwnPtr and new.
3065
3066         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3067         (runTest): Use RefPtr and create instead of OwnPtr and new.
3068         (MyApp::OnInit): Removed unneeded code to delete the layout
3069         test controller. This is done during each test.
3070
3071 2010-06-17  Kent Tamura  <tkent@chromium.org>
3072
3073         Reviewed by Shinichiro Hamaji.
3074
3075         [DRT/Chromium] Fix a bug of Windows pixel tests
3076         https://bugs.webkit.org/show_bug.cgi?id=40763
3077
3078         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3079         (TestShellPrinter::handleImage):
3080
3081 2010-06-16  Kent Tamura  <tkent@chromium.org>
3082
3083         Reviewed by Shinichiro Hamaji.
3084
3085         [DRT/Chromium] Fix crash on Mac Release
3086         https://bugs.webkit.org/show_bug.cgi?id=40759
3087
3088         * DumpRenderTree/chromium/WebViewHost.cpp:
3089         (WebViewHost::paintRect): We should not use m_canvas directly because
3090           it is created lazily in canvas().
3091
3092 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
3093
3094         [wx] Build fix after new method addition.
3095
3096         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3097         (LayoutTestController::pageProperty):
3098
3099 2010-06-16  Kent Tamura  <tkent@chromium.org>
3100
3101         Reviewed by Dimitri Glazkov.
3102
3103         [DRT/Chromium] Set current working directory for each of tests
3104         https://bugs.webkit.org/show_bug.cgi?id=40668
3105
3106         This change fixes tests with eventSender.beginDragWithFiles().
3107
3108         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3109         (runTest):
3110
3111 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
3112
3113         Reviewed by Gustavo Noronha Silva.
3114
3115         [GTK] r60803 broke media/controls-drag-timebar.html
3116         https://bugs.webkit.org/show_bug.cgi?id=40269
3117
3118         Only queue events while the mouse button is down, if drag mode is enabled. Some
3119         tests may disable drag mode, to prevent the queuing of events in this situation.
3120
3121         * DumpRenderTree/gtk/EventSender.cpp:
3122         (sendOrQueueEvent): Only queue events here if dragMode is true.
3123
3124 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
3125
3126         Reviewed by Gustavo Noronha Silva.
3127
3128         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
3129         https://bugs.webkit.org/show_bug.cgi?id=40600
3130
3131         * DumpRenderTree/gtk/EventSender.cpp:
3132         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
3133
3134 2010-06-16  Adam Barth  <abarth@webkit.org>
3135
3136         Reviewed by Dimitri Glazkov.
3137
3138         Add a hidden land-cowboy command to webkit-patch to help land quick
3139         build fixes.
3140
3141         * Scripts/webkitpy/tool/commands/download.py:
3142         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3143
3144 2010-06-16  Adam Roben  <aroben@apple.com>
3145
3146         Convert console messages to UTF-8 before printing them
3147
3148         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
3149         http/tests/security/xssAuditor/embed-tag-null-char.html and
3150         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
3151         Windows. (I can't test the fix because Apache is crashing on my
3152         computer.)
3153
3154         Reviewed by Alexey Proskuryakov.
3155
3156         * DumpRenderTree/win/DumpRenderTree.cpp:
3157         (toUTF8): Extracted the code into an overload that takes a wide string
3158         and a length, then added an overload that takes a wstring.
3159
3160         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
3161         overload.
3162
3163         * DumpRenderTree/win/UIDelegate.cpp:
3164         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
3165         UTF-8 instead of letting printf convert to the current code page.
3166
3167 2010-06-16  Drew Wilson  <atwilson@chromium.org>
3168
3169         Reviewed by Kent Tamura.
3170
3171         [Chromium] Plumbing for top-level frame names
3172         https://bugs.webkit.org/show_bug.cgi?id=40430
3173
3174         * DumpRenderTree/chromium/WebViewHost.cpp:
3175         (WebViewHost::createView):
3176         Migrate to new createView() API.
3177         * DumpRenderTree/chromium/WebViewHost.h:
3178         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
3179
3180 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
3181
3182         Reviewed by Kenneth Rohde Christiansen.
3183
3184         [Qt] Scroll wheel event support to graphics based DRT
3185         https://bugs.webkit.org/show_bug.cgi?id=40577
3186
3187         * DumpRenderTree/qt/EventSenderQt.cpp:
3188         (EventSender::continuousMouseScrollBy):
3189         (EventSender::createGraphicsSceneWheelEvent):
3190         * DumpRenderTree/qt/EventSenderQt.h:
3191
3192 2010-06-16  Adam Roben  <aroben@apple.com>
3193
3194         Remove a stray newline from the Windows version of TestNetscapePlugin
3195
3196         Reviewed by Alexey Proskuryakov.
3197
3198         Fixes <http://webkit.org/b/40728>
3199         plugins/geturlnotify-during-document-teardown.html fails on Windows
3200
3201         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3202         (NPP_Destroy): Removed extra newline that the Mac version doesn't
3203         have.
3204
3205 2010-06-16  Adam Roben  <aroben@apple.com>
3206
3207         Respect LayoutTestController::isPrinting on Windows
3208
3209         This gets some printing tests closer to passing (like
3210         printing/page-rule-in-media-query.html).
3211
3212         Fixes <http://webkit.org/b/40727>.
3213
3214         Reviewed by Dan Bernstein.
3215
3216         * DumpRenderTree/win/DumpRenderTree.cpp:
3217         (dump): Pass LayoutTestController::isPrinting to
3218         IWebFramePrivate::renderTreeAsExternalRepresentation.
3219
3220 2010-06-15  Adam Barth  <abarth@webkit.org>
3221
3222         Reviewed by Eric Seidel.
3223
3224         Enable HTML5 lexer
3225         https://bugs.webkit.org/show_bug.cgi?id=40650
3226
3227         * DumpRenderTree/mac/DumpRenderTree.mm:
3228         (initializeGlobalsFromCommandLineOptions):
3229
3230 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
3231
3232         Reviewed by Shinichiro Hamaji.
3233
3234         Implement render style selection for pages to support CSS3 Paged Media.
3235         https://bugs.webkit.org/show_bug.cgi?id=35961
3236
3237         * DumpRenderTree/LayoutTestController.cpp:
3238         (parsePagePropertyParameters):
3239         (pagePropertyCallback):
3240         (LayoutTestController::staticFunctions):
3241         * DumpRenderTree/LayoutTestController.h:
3242         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3243         (LayoutTestController::pageProperty):
3244         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3245         (LayoutTestController::pageProperty):
3246         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3247         (LayoutTestController::pageProperty):
3248
3249 2010-06-15  Sam Weinig  <sam@webkit.org>
3250
3251         Reviewed by Anders Carlsson.
3252
3253         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
3254         WebKit2: Add mechanism to inject code into the WebProcess on startup
3255
3256         Add initial InjectedBundle support.
3257
3258         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3259         * MiniBrowser/WebBundle-Info.plist: Added.
3260         Add test InjectedBundle to the project.
3261
3262         * MiniBrowser/mac/AppDelegate.m:
3263         (-[BrowserAppDelegate init]):
3264         Get the path to the WebBundle from the the main bundle and pass it to the new
3265         WKContextCreateWithInjectedBundlePath function.
3266
3267         * MiniBrowser/mac/BrowserWindowController.m:
3268         (_didChangeProgress):
3269         Fix the build.  This has been broken for a while.
3270
3271         * MiniBrowser/mac/WebBundle: Added.
3272         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
3273         (_didCreatePage):
3274         (WKBundleInitialize):
3275         Add really basic InjectedBundle.
3276
3277         * MiniBrowser/win/BrowserView.cpp:
3278         (BrowserView::create):
3279         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
3280
3281 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
3282
3283         Reviewed by Darin Adler.
3284
3285         Adding myself to the reviewers list.
3286         https://bugs.webkit.org/show_bug.cgi?id=40693
3287
3288         * Scripts/webkitpy/common/config/committers.py:
3289
3290 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
3291
3292         Reviewed by Xan Lopez.
3293
3294         Switch to using GIO methods instead of realpath in GtkLauncher to determine
3295         the file URI. This should remove warnings about realpath being undefined
3296         when compiling with '-ansi'.
3297
3298         * GtkLauncher/main.c:
3299         (filenameToURL): Use GIO instead of realpath to determine file URI.
3300
3301 2010-06-15  Adam Roben  <aroben@apple.com>
3302
3303         Remove the redundant set-apple-windows-environment-variables script
3304
3305         Apparently update-webkit does this for you these days.
3306
3307         Rubber-stamped by Steve Falkenburg.
3308
3309         * Scripts/set-apple-windows-environment-variables: Removed.
3310
3311 2010-06-14  Adam Roben  <aroben@apple.com>
3312
3313         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
3314         environment variables
3315
3316         Fixes <http://webkit.org/b/40595>.
3317
3318         Reviewed by Steve Falkenburg.
3319
3320         * Scripts/set-apple-windows-environment-variables: Added.
3321         (to_windows_path): Passes the passed-in path through cygpath to
3322         generate a Windows-style path.
3323         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
3324         variables to their defaults, if they aren't already set.
3325
3326 2010-06-14  Adam Roben  <aroben@apple.com>
3327
3328         Speed up run-safari/debug-safari on Windows
3329
3330         Fixes <http://webkit.org/b/40586>.
3331
3332         Reviewed by Steve Falkenburg.
3333
3334         * Scripts/webkitdirs.pm:
3335         (runSafari): When debugging, set up the environment to run Safari
3336         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
3337         actually launch the debugger. When not debugging, just run WebKit.exe
3338         and it will do the rest for us.
3339
3340 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
3341
3342         Reviewed by Kenneth Rohde Christiansen.
3343
3344         [Qt] DRT EventSender support to graphics context events
3345         https://bugs.webkit.org/show_bug.cgi?id=40324
3346
3347         * DumpRenderTree/qt/EventSenderQt.cpp:
3348         (EventSender::contextClick):
3349
3350 2010-06-14  Tony Chang  <tony@chromium.org>
3351
3352         Reviewed by Darin Fisher.
3353
3354         [chromium] checkout chromium third_party directly
3355         https://bugs.webkit.org/show_bug.cgi?id=40556
3356
3357         * Scripts/update-webkit-chromium: some migration code for the bots
3358
3359 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3360
3361         Chromium build fix.
3362
3363         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
3364         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
3365
3366 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3367
3368         Reviewed by Darin Adler.
3369
3370         https://bugs.webkit.org/show_bug.cgi?id=40529
3371         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
3372
3373         * DumpRenderTree/mac/EventSendingController.mm:
3374         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
3375         event for "delete" - it had virtual key code from forward delete, and text from backspace.
3376         Fixed "delete" to mean forward delete.
3377
3378         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
3379         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
3380         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3381         Mac DRT confusion has propagated to other platforms, fixing those.
3382
3383 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
3384
3385         Reviewed by Xan Lopez.
3386
3387         Small GtkLauncher build fix for some systems.
3388
3389         * GtkLauncher/main.c: Add <limit.h> include.
3390
3391 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3392
3393         Reviewed by Laszlo Gombos.
3394
3395         [Qt] navigator.geolocation support for Qt port
3396         https://bugs.webkit.org/show_bug.cgi?id=39724
3397
3398         Implementation for geolocation cases to DumpRenderTreeQt
3399
3400         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3401         (WebCore::WebPage::allowGeolocationRequest):
3402         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3403         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3404         (LayoutTestController::setGeolocationPermission):
3405         (LayoutTestController::setMockGeolocationError):
3406         (LayoutTestController::setMockGeolocationPosition):
3407         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3408         (LayoutTestController::isGeolocationPermissionSet):
3409         (LayoutTestController::geolocationPermission):
3410
3411 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
3412
3413         Reviewed by Darin Adler.
3414
3415         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
3416         be a way of overwriting the Xcode system path.  Making
3417         $WEBKITOUTPUTDIR take precedence over the system default would make
3418         this possible.
3419
3420         * Scripts/webkitdirs.pm:
3421
3422 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
3423
3424         Reviewed by Darin Adler.
3425
3426         AX: link won't return linked element if URL contains #
3427         https://bugs.webkit.org/show_bug.cgi?id=40192
3428
3429         * DumpRenderTree/AccessibilityUIElement.cpp:
3430         (linkedUIElementAtIndexCallback):
3431         (AccessibilityUIElement::getJSClass):
3432         * DumpRenderTree/AccessibilityUIElement.h:
3433         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3434         (AccessibilityUIElement::linkedUIElementAtIndex):
3435         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3436         (AccessibilityUIElement::linkedUIElementAtIndex):
3437         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3438         (AccessibilityUIElement::linkedUIElementAtIndex):
3439
3440 2010-06-13  Adam Barth  <abarth@webkit.org>
3441
3442         Reviewed by Darin Adler.
3443
3444         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
3445         https://bugs.webkit.org/show_bug.cgi?id=39550
3446
3447         This can cause an extra request to bugs.webkit.org durig upload, but it
3448         shouldn't be too bad.  Also, this won't work if you remove the
3449         boilerplate created by prepare-ChangeLog.
3450
3451         * Scripts/webkitpy/common/checkout/changelog.py:
3452         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3453         * Scripts/webkitpy/common/net/bugzilla.py:
3454         * Scripts/webkitpy/tool/steps/abstractstep.py:
3455         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3456         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
3457
3458 2010-06-08  Robert Hogan  <robert@webkit.org>
3459
3460         Reviewed by Eric Seidel.
3461
3462         [Qt] Add support for callShouldCloseOnWebView() to DRT
3463         https://bugs.webkit.org/show_bug.cgi?id=40330
3464
3465         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3466         (LayoutTestController::callShouldCloseOnWebView):
3467         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3468         (LayoutTestController::setCallCloseOnWebViews):
3469
3470 2010-06-12  Eric Seidel  <eric@webkit.org>
3471
3472         Reviewed by Daniel Bates.
3473
3474         do-webcore-rename should have a --verbose option
3475         https://bugs.webkit.org/show_bug.cgi?id=40497
3476
3477         * Scripts/do-webcore-rename:
3478          - Unified how we handle skipping files/directories
3479            this will allow us to "black list" certain files and
3480            directories when performing renames.
3481          - Made do-webcore-rename log what it's skipping when passed --verbose.
3482
3483 2010-06-12  Darin Adler  <darin@apple.com>
3484
3485         * Scripts/run-bindings-tests: Fixed a typo in a message.
3486
3487 2010-06-12  Kent Tamura  <tkent@chromium.org>
3488
3489         Reviewed by Dimitri Glazkov.
3490
3491         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3492         https://bugs.webkit.org/show_bug.cgi?id=40402
3493
3494         _build_path() of each Chromium port check existence of build path
3495         of Chromium checkout first, then check existence of build path of
3496         WebKit-only checkout.
3497
3498         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3499         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3500         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3501
3502 2010-06-12  Robert Hogan  <robert@webkit.org>
3503
3504         Reviewed by Kenneth Rohde Christiansen.
3505
3506         [Qt] Back-forward list dumping is incorrect
3507
3508         https://bugs.webkit.org/show_bug.cgi?id=36392
3509
3510         Support dumping child history items in DRT.
3511
3512         Unskip:
3513
3514         fast/loader/frame-src-change-added-to-history.html
3515         fast/loader/frame-src-change-not-added-to-history.html
3516         fast/loader/frame-location-change-not-added-to-history.html
3517
3518         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3519         (WebCore::dumpHistoryItem):
3520
3521 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3522
3523         Reviewed by Eric Seidel.
3524
3525         upload all patches that lack in-rietveld to rietveld
3526         https://bugs.webkit.org/show_bug.cgi?id=40444
3527
3528         If it's a patch, then we'll try to upload it as long as it
3529         doesn't have in-rietveld set. No longer set in-rietveld? since
3530         it's not needed.
3531
3532         * Scripts/webkitpy/common/net/bugzilla.py:
3533
3534 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3535
3536         Reviewed by Darin Fisher.
3537
3538         Fix rietveld upload when message length > 100 characters
3539         https://bugs.webkit.org/show_bug.cgi?id=40457
3540
3541         * Scripts/webkitpy/common/net/rietveld.py:
3542
3543 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3544
3545         Reviewed by Laszlo Gombos.
3546
3547         [Qt] There should be a way to enable popups in QtTestBrowser
3548         https://bugs.webkit.org/show_bug.cgi?id=40427
3549
3550         * QtTestBrowser/main.cpp:
3551         (LauncherWindow::toggleJavascriptCanOpenWindows):
3552         (LauncherWindow::createChrome):
3553
3554 2010-06-10  Adam Barth  <abarth@webkit.org>
3555
3556         Reviewed by Daniel Bates.
3557
3558         Make SheriffBot more chatty
3559         https://bugs.webkit.org/show_bug.cgi?id=40463
3560
3561         People seem to like to talk to SheriffBot, so let's make him chat back.
3562
3563         * Scripts/webkitpy/thirdparty/__init__.py:
3564         * Scripts/webkitpy/tool/bot/irc_command.py:
3565         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3566         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3567         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3568
3569 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3570
3571         Reviewed by Darin Adler.
3572
3573         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3574         
3575         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3576         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3577         WEXITSTATUS on $result instead of just comparing $result to 0.
3578
3579         * Scripts/update-webkit-auxiliary-libs:
3580
3581 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3582
3583         Reviewed by Alexey Proskuryakov.
3584
3585         don't use Exception.message as it's deprecated in python 2.6+
3586         https://bugs.webkit.org/show_bug.cgi?id=40449
3587
3588         * Scripts/webkitpy/tool/commands/queues.py:
3589
3590 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3591
3592         Reviewed by Adam Barth.
3593
3594         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3595         https://bugs.webkit.org/show_bug.cgi?id=40436
3596
3597         * Scripts/webkitpy/common/system/outputcapture.py:
3598         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3599         * Scripts/webkitpy/tool/commands/queues.py:
3600         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3601         * Scripts/webkitpy/tool/commands/queuestest.py:
3602         * Scripts/webkitpy/tool/mocktool.py:
3603
3604 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3605
3606         Reviewed by Simon Hausmann.
3607
3608         [Qt] *All* WebGL layout tests fail!
3609         https://bugs.webkit.org/show_bug.cgi?id=40296
3610
3611         Added test for WebKitWebGLEnabled to
3612         LayoutTestController::overridePreference().
3613
3614         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3615         (LayoutTestController::overridePreference):
3616
3617 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3618
3619         Reviewed by Kenneth Rohde Christiansen.
3620
3621         [Qt] DRT EventSender support to graphics mouse events activation
3622         https://bugs.webkit.org/show_bug.cgi?id=40017
3623
3624         * DumpRenderTree/qt/EventSenderQt.cpp:
3625         (EventSender::mouseDown):
3626         (EventSender::mouseUp):
3627         (EventSender::mouseMoveTo):
3628         (EventSender::keyDown):
3629         (EventSender::contextClick):
3630         (EventSender::sendTouchEvent):
3631         (EventSender::sendOrQueueEvent):
3632         (EventSender::eventFilter):
3633         (EventSender::createGraphicsSceneMouseEvent):
3634         (EventSender::sendEvent):
3635         * DumpRenderTree/qt/EventSenderQt.h:
3636         (EventSender::isGraphicsBased):
3637
3638 2010-06-09  Adam Barth  <abarth@webkit.org>
3639
3640         Reviewed by Ojan Vafai.
3641
3642         webkit-patch upload fails for security bugs because there's no rietveld flag
3643         https://bugs.webkit.org/show_bug.cgi?id=40309
3644
3645         There's probably a more elegant way of seeing whether the form control
3646         exists, but this seems to work.
3647
3648         * Scripts/webkitpy/common/net/bugzilla.py:
3649
3650 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3651
3652         Reviewed by Adam Barth.
3653
3654         make rietveld upload faster and avoid posting to bug on errors
3655         https://bugs.webkit.org/show_bug.cgi?id=40389
3656
3657         Only grab the first item of the upload queue instead of trying
3658         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3659
3660         Also, don't post comments to the bug when uploading fails.
3661
3662         * Scripts/webkitpy/common/net/bugzilla.py:
3663         * Scripts/webkitpy/tool/commands/queues.py:
3664         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3665         * Scripts/webkitpy/tool/commands/stepsequence.py:
3666         * Scripts/webkitpy/tool/mocktool.py:
3667
3668 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3669
3670         Reviewed by Adam Barth.
3671
3672         Rietveld upload queue fails when setting in-rietveld flag
3673         https://bugs.webkit.org/show_bug.cgi?id=40371
3674
3675         Make the comment arguments to set_flag_on_attachment optional
3676         and add it to the MockBugzilla.
3677
3678         * Scripts/webkitpy/common/net/bugzilla.py:
3679         * Scripts/webkitpy/tool/bot/queueengine.py:
3680         * Scripts/webkitpy/tool/commands/download_unittest.py:
3681         * Scripts/webkitpy/tool/commands/queues.py:
3682         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3683         * Scripts/webkitpy/tool/mocktool.py:
3684
3685 2010-06-09  Kenneth Russell  <kbr@google.com>
3686
3687         Reviewed by Dimitri Glazkov.
3688
3689         Rename FloatArray to Float32Array
3690         https://bugs.webkit.org/show_bug.cgi?id=40323
3691
3692         Used do-webcore-rename to perform renaming. Manually undid
3693         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3694         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3695         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3696         all layout tests on Safari; built Chromium and ran selected WebGL
3697         tests.
3698
3699         * Scripts/do-webcore-rename:
3700
3701 2010-06-08  Tony Chang  <tony@chromium.org>
3702
3703         Reviewed by David Levin.
3704
3705         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3706         https://bugs.webkit.org/show_bug.cgi?id=40285
3707
3708         * Scripts/webkitdirs.pm:
3709         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3710
3711 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3712
3713         Reviewed by Tamura Kent.
3714
3715         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3716         https://bugs.webkit.org/show_bug.cgi?id=40052
3717         
3718         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3719
3720         * DumpRenderTree/DumpRenderTree.gypi:
3721         * DumpRenderTree/chromium/TestShellWin.cpp:
3722         (platformInit):
3723         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3724         (WebKit::):
3725         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3726         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3727         (WebKit::WebThemeControlDRT::box):
3728         (WebKit::WebThemeControlDRT::line):
3729         (WebKit::WebThemeControlDRT::triangle):
3730         (WebKit::WebThemeControlDRT::roundRect):
3731         (WebKit::WebThemeControlDRT::oval):
3732         (WebKit::WebThemeControlDRT::circle):
3733         (WebKit::WebThemeControlDRT::nestedBoxes):
3734         (WebKit::WebThemeControlDRT::markState):
3735         (WebKit::WebThemeControlDRT::draw):
3736         (WebKit::WebThemeControlDRT::drawTextField):
3737         (WebKit::WebThemeControlDRT::drawProgressBar):
3738         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3739         (WebKit::WebThemeControlDRT::):
3740         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3741         (WebKit::):
3742         (WebKit::WebThemeEngineDRT::paintButton):
3743         (WebKit::WebThemeEngineDRT::paintMenuList):
3744         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3745         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3746         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3747         (WebKit::WebThemeEngineDRT::paintTextField):
3748         (WebKit::WebThemeEngineDRT::paintTrackbar):
3749         (WebKit::WebThemeEngineDRT::paintProgressBar):
3750         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3751         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
3752
3753 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3754
3755         Unreviewed, rolling out r60878.
3756         http://trac.webkit.org/changeset/60878
3757         https://bugs.webkit.org/show_bug.cgi?id=40349
3758
3759         broke linux build (Requested by tony^work on #webkit).
3760
3761         * Scripts/webkitdirs.pm:
3762         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3763
3764 2010-06-08  Tony Chang  <tony@chromium.org>
3765
3766         Reviewed by David Levin.
3767
3768         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3769         https://bugs.webkit.org/show_bug.cgi?id=40285
3770
3771         * Scripts/webkitdirs.pm:
3772         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3773
3774 2010-06-08  Kenneth Russell  <kbr@google.com>
3775
3776         Unreviewed, build fix.
3777
3778         Fix build breakage from 38145
3779         https://bugs.webkit.org/show_bug.cgi?id=40346
3780
3781         The fix for bug 38145 broke the Chromium Win build because
3782         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
3783         change log2(x) to log(x) / log(2). Built and ran WebGL layout
3784         tests in Safari on Mac OS X. Changed download mirrors for
3785         python-irclib to working ones.
3786
3787         * Scripts/webkitpy/thirdparty/__init__.py:
3788
3789 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
3790
3791         Reviewed by Eric Seidel.
3792
3793         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3794         https://bugs.webkit.org/show_bug.cgi?id=39058
3795
3796         * Scripts/old-run-webkit-tests:
3797          use sourceDir() to find ensure-valid-python in checkPythonVersion()
3798
3799 2010-06-08  Andras Becsi  <abecsi@webkit.org>
3800
3801         Unreviewed buildfix after r60479.
3802
3803         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
3804         versions other than 2.17.3.
3805
3806         * DumpRenderTree/gtk/EventSender.cpp:
3807         (getRootCoords):
3808
3809 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
3810
3811         Reviewed by Oliver Hunt.
3812
3813         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
3814         https://bugs.webkit.org/show_bug.cgi?id=40267
3815
3816         When a mouse button is down, automatically queue mouse motion events and
3817         do not play them back until the mouse button is released. This matches the
3818         behavior of other ports' EventSenders.
3819
3820         * DumpRenderTree/gtk/EventSender.cpp:
3821         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
3822         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
3823
3824 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3825
3826         Reviewed by Sam Weinig.
3827
3828         Add CPP bindings generator
3829         https://bugs.webkit.org/show_bug.cgi?id=38279
3830
3831         Integrate CPP bindings in run-bindings-tests.
3832
3833         * Scripts/run-bindings-tests:
3834
3835 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3836
3837         Reviewed by Ojan Vafai.
3838
3839         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
3840         https://bugs.webkit.org/show_bug.cgi?id=40183
3841
3842         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3843
3844 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3845
3846         Unreviewed.
3847
3848         Add my new email and IRC nick to committers.py.
3849
3850         * Scripts/webkitpy/common/config/committers.py:
3851
3852 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
3853
3854         Unreviewed.
3855
3856         Revert changes in json_results_generator.py's _get_svn_revision.
3857
3858         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3859
3860 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3861
3862         Reviewed by Xan Lopez.
3863
3864         [GTK] GtkLauncher should support relative file paths
3865         https://bugs.webkit.org/show_bug.cgi?id=39944
3866
3867         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
3868
3869         * GtkLauncher/main.c:
3870         (filename_to_url): Added.
3871         (main): Try to resolve arguments as relative file URLs first.
3872
3873 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3874
3875         Reviewed by Xan Lopez.
3876
3877         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
3878         https://bugs.webkit.org/show_bug.cgi?id=40182
3879
3880         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
3881         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
3882         without breaking DRT.
3883
3884         * DumpRenderTree/gtk/EventSender.cpp:
3885         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
3886         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
3887
3888 2010-06-04  Anders Carlsson  <andersca@apple.com>
3889
3890         Reviewed by David Hyatt.
3891
3892         Make the editing/spelling/context-menu-suggestions.html test more robust
3893         https://bugs.webkit.org/show_bug.cgi?id=40178
3894
3895         Change the contextClick method to return an array of strings describing the context menu items.
3896
3897         * DumpRenderTree/mac/EventSendingController.mm:
3898         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3899         (+[EventSendingController webScriptNameForSelector:]):
3900         (-[EventSendingController contextClick]):
3901
3902 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
3903
3904         Reviewed by Shinichiro Hamaji.
3905
3906         Clean up chromium-specific code from json_results_generator.py.
3907         https://bugs.webkit.org/show_bug.cgi?id=39665
3908
3909         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3910         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3911         * Scripts/webkitpy/layout_tests/port/base.py:
3912         * Scripts/webkitpy/layout_tests/port/chromium.py:
3913
3914 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3915
3916         Reviewed by Adam Barth.
3917
3918         Utilize new takeFirst() method where appropriate.
3919         https://bugs.webkit.org/show_bug.cgi?id=40089
3920
3921         * DumpRenderTree/chromium/EventSender.cpp:
3922         (EventSender::replaySavedEvents):
3923         * DumpRenderTree/chromium/LayoutTestController.cpp:
3924         (LayoutTestController::WorkQueue::processWork):
3925         (LayoutTestController::WorkQueue::reset):
3926
3927 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
3928
3929         Reviewed by Simon Hausmann.
3930
3931         [Qt] QtTestLauncher should allow notifications by default.
3932         https://bugs.webkit.org/show_bug.cgi?id=40078
3933
3934         * QtTestBrowser/main.cpp:
3935         (NotificationsPermissionController::NotificationsPermissionController):
3936         (NotificationsPermissionController::checkPermission):
3937         (NotificationsPermissionController::requestPermission):
3938         (LauncherWindow::LauncherWindow):
3939
3940 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3941
3942         Reviewed by Adam Barth.
3943
3944         Detect whether the user's environment can open a browser.
3945         https://bugs.webkit.org/show_bug.cgi?id=40136
3946
3947         Some environments like cygwin silently fail webbrowser.open() causing
3948         webkit-patch upload not to display any diff. This detects environments
3949         where webbrowser.open() would fail by testing if webbrowser.get()
3950         raises an exception.
3951
3952         * Scripts/webkitpy/common/system/user.py:
3953         * Scripts/webkitpy/tool/mocktool.py:
3954         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3955
3956 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
3957
3958         Reviewed by David Levin.
3959
3960         Add dependencies required to link with VS Express 2005.
3961         https://bugs.webkit.org/show_bug.cgi?id=40038
3962
3963         Visual Studio implicitly links against these libs.
3964         VC++ Express does not.
3965
3966         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3967         * WinLauncher/WinLauncher.vcproj:
3968
3969 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3970
3971         Reviewed by David Levin.
3972
3973         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
3974         https://bugs.webkit.org/show_bug.cgi?id=40105
3975
3976         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3977         - kill pywebsocket process when url is not alive and the process is not
3978           terminated, not to leave pywebsocket server running.
3979         - fix codecs.open parameters.
3980
3981 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3982
3983         Reviewed by Alexey Proskuryakov.
3984
3985         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3986         https://bugs.webkit.org/show_bug.cgi?id=39058
3987
3988         * Scripts/ensure-valid-python:
3989           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
3990           - Add --check-only and --help option.
3991           - --check-only option only checks python version and don't try to install Python 2.5.
3992           - Set executable bit.
3993         * Scripts/old-run-webkit-tests:
3994           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
3995
3996 2010-05-14  Ojan Vafai  <ojan@chromium.org>
3997
3998         Reviewed by Adam Barth.
3999
4000         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
4001         https://bugs.webkit.org/show_bug.cgi?id=38918
4002
4003         Patches with in-rietveld? get uploaded to rietveld and get marked
4004         in-rietveld+. If the upload fails, they are marked in-rietveld-
4005         and an error is logged to the bug, like the commit-queue.
4006
4007         Also, get rid of --fancy-review and the ability to upload to rietveld
4008         using webkit-patch upload/post.
4009
4010         * Scripts/webkitpy/common/net/bugzilla.py:
4011         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
4012         * Scripts/webkitpy/tool/commands/download.py:
4013         * Scripts/webkitpy/tool/commands/download_unittest.py:
4014         * Scripts/webkitpy/tool/commands/queues.py:
4015         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4016         * Scripts/webkitpy/tool/commands/upload.py:
4017         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4018         * Scripts/webkitpy/tool/mocktool.py:
4019         * Scripts/webkitpy/tool/steps/options.py:
4020         * Scripts/webkitpy/tool/steps/postcodereview.py:
4021
4022 2010-05-24  Ojan Vafai  <ojan@chromium.org>
4023
4024         Reviewed by Chris Jerdonek.
4025
4026         many webkit-patch commands fail in a non-svn tracking git checkout
4027         https://bugs.webkit.org/show_bug.cgi?id=38156
4028
4029         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
4030         If neither exists, then error out. This makes webkit-patch work
4031         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
4032         to checkout webkit. The fallback to master is for people who don't
4033         do the steps on that page for tracking svn.
4034
4035         * Scripts/webkitpy/common/checkout/scm.py:
4036         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4037
4038 2010-06-03  Mike Fenton  <mifenton@rim.com>
4039
4040         Unreviewed.
4041
4042         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
4043
4044         * Scripts/webkitpy/common/config/committers.py:
4045
4046 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
4047
4048         Reviewed by Yury Semikhatsky.
4049
4050         Web Inspector: a number of fixes that make InspectorController
4051         happy with null redirects.
4052
4053         https://bugs.webkit.org/show_bug.cgi?id=40109
4054
4055         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4056         (runTest):
4057         * DumpRenderTree/mac/DumpRenderTree.mm:
4058         (runTest):
4059         * DumpRenderTree/win/DumpRenderTree.cpp:
4060         (runTest):
4061
4062 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
4063
4064         Reviewed by Shinichiro Hamaji.
4065
4066         [Qt] Fix compilation with QT_NO_PROPERTIES
4067         https://bugs.webkit.org/show_bug.cgi?id=38324
4068
4069         * QtTestBrowser/main.cpp:
4070         (LauncherWindow::init):
4071
4072 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
4073
4074         Reviewed by Kenneth Rohde Christiansen.
4075
4076         [Qt] Make possible run DRT with QGraphicsWebView
4077         https://bugs.webkit.org/show_bug.cgi?id=40016
4078
4079         Make possible to use a environment variable for switching backend.
4080         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
4081
4082         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4083         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
4084         (WebCore::DumpRenderTree::DumpRenderTree):
4085         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4086         (WebCore::DumpRenderTree::setGraphicsBased):
4087         (WebCore::DumpRenderTree::isGraphicsBased):
4088         (WebCore::WebViewGraphicsBased::graphicsView):
4089         (WebCore::WebViewGraphicsBased::setPage):
4090         * Scripts/old-run-webkit-tests:
4091
4092 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
4093
4094         Reviewed by Eric Seidel.
4095
4096         Slave lost shouldn't be recognized as build failed.
4097         https://bugs.webkit.org/show_bug.cgi?id=39282
4098
4099         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
4100         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
4101
4102 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
4103
4104         Reviewed by Kenneth Rohde Christiansen.
4105
4106         [Qt] Fix the lifecycle of notification objects
4107         https://bugs.webkit.org/show_bug.cgi?id=40003
4108
4109         Remove the dependency of notifications on QWebPage.
4110
4111         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4112         (WebCore::requestPermissionCallback):
4113         (WebCore::WebPage::WebPage):
4114         (WebCore::DumpRenderTree::requestPermission):
4115         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4116
4117 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
4118
4119         Unreviewed, rolling out r60559.
4120         http://trac.webkit.org/changeset/60559
4121         https://bugs.webkit.org/show_bug.cgi?id=40055
4122
4123         It broke python unit test (Requested by Ossy on #webkit).
4124
4125         * Scripts/webkitpy/common/net/buildbot.py:
4126
4127 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
4128
4129         Reviewed by Eric Seidel.
4130
4131         Slave lost shouldn't be recognized as build failed.
4132         https://bugs.webkit.org/show_bug.cgi?id=39282
4133
4134         * Scripts/webkitpy/common/net/buildbot.py:
4135
4136 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
4137
4138         Reviewed by Eric Seidel.
4139
4140         Fix crash caused when assigned_to is disabled
4141         https://bugs.webkit.org/show_bug.cgi?id=40039
4142
4143         * Scripts/webkitpy/common/net/bugzilla.py:
4144
4145 2010-06-02  Sterling Swigart  <sswigart@google.com>
4146
4147         Reviewed by David Levin.
4148
4149         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
4150         https://bugs.webkit.org/show_bug.cgi?id=39906
4151
4152         * Scripts/build-webkit:
4153
4154 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
4155
4156         Reviewed by Simon Hausmann.
4157
4158         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
4159
4160         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4161         (WebCore::WebPage::WebPage):
4162         (WebCore::WebPage::resetSettings):
4163         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4164         (LayoutTestController::setJavaScriptCanAccessClipboard):
4165
4166 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
4167
4168         Reviewed by Mark Rowe.
4169
4170         A nicer Tiger build fix.
4171
4172         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4173         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4174         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
4175
4176 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
4177
4178         A real Tiger build fix.
4179
4180         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
4181         for all configurations, not just debug.
4182
4183 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
4184
4185         Tiger build fix.
4186
4187         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
4188
4189 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
4190
4191         Reviewed by Xan Lopez.
4192
4193         [GTK] Get more mouse tests passing
4194         https://bugs.webkit.org/show_bug.cgi?id=39040
4195
4196         Reproduce the logic from the Windows EventSender for mapping
4197         button numbers to GDK button numbers. Move this logic to the
4198         prepareMouseButtonEvent helper.
4199
4200         * DumpRenderTree/gtk/EventSender.cpp:
4201         (prepareMouseButtonEvent): Reproduce Windows logic.
4202         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
4203         (mouseDownCallback): Ditto.
4204         (mouseUpCallback): Ditto.
4205
4206 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
4207
4208         Reviewed by Sam Weinig.
4209
4210         https://bugs.webkit.org/show_bug.cgi?id=39434
4211         REGRESSION (r59811): Geolocation callbacks cannot be created
4212
4213         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
4214
4215         * DumpRenderTree/mac/DumpRenderTree.mm:
4216         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
4217         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
4218         into subsequent tests.
4219
4220         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4221         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
4222         (LayoutTestController::setMockGeolocationError): Ditto.
4223
4224         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
4225         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
4226         (+[MockGeolocationProvider shared]):
4227         (-[MockGeolocationProvider dealloc]):
4228         (-[MockGeolocationProvider setPosition:]):
4229         (-[MockGeolocationProvider setError:]):
4230         (-[MockGeolocationProvider registerWebView:]):
4231         (-[MockGeolocationProvider unregisterWebView:]):
4232         (-[MockGeolocationProvider lastPosition]):
4233         (-[MockGeolocationProvider stopTimer]):
4234         (-[MockGeolocationProvider timerFired]):
4235
4236         * DumpRenderTree/mac/UIDelegate.mm:
4237         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
4238         This delegate method must send a response. I'm not sure what the two-stage check is supposed
4239         to achieve, it seems unnecessary.
4240
4241 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
4242
4243         Reviewed by Xan Lopez.
4244
4245         [GTK] Double clicks cause three button press events
4246         https://bugs.webkit.org/show_bug.cgi?id=38853
4247
4248         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
4249         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
4250         the GDK event queue entirely, we simply do not send the extra event.
4251
4252         * DumpRenderTree/gtk/EventSender.cpp:
4253         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
4254         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
4255
4256 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
4257
4258         Not reviewed. Build fix.
4259
4260         Fix GTK+ build caused by a bad merge.
4261
4262         * DumpRenderTree/gtk/EventSender.cpp: 
4263         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
4264
4265 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
4266
4267         Reviewed by Xan Lopez.
4268
4269         [GTK] Double clicks cause three button press events
4270         https://bugs.webkit.org/show_bug.cgi?id=38853
4271
4272         Small EventSender cleanups. Consolidate some common code. Style fixes.
4273
4274         * DumpRenderTree/gtk/EventSender.cpp:
4275         (prepareMouseButtonEvent): Added.
4276         (contextClickCallback): Use prepareMouseButtonEvent.
4277         (mouseDownCallback): Use prepareMouseButtonEvent.
4278         (mouseUpCallback): Use prepareMouseButtonEvent.
4279         (mouseMoveToCallback): Small style fix.
4280
4281 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
4282
4283         Reviewed by Xan Lopez.
4284
4285         [GTK] Double clicks cause three button press events
4286         https://bugs.webkit.org/show_bug.cgi?id=38853
4287
4288         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
4289         to pause for a specified amount of time. It is used in the processing of drag-
4290         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
4291         This patch enables tests that rely on the latter behavior to pass.
4292
4293         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4294         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
4295         * DumpRenderTree/gtk/EventSender.cpp:
4296         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
4297         (contextClickCallback): Use sendOrQueueEvent.
4298         (updateClickCount): Take the time offset into account when counting clicks.
4299         (mouseDownCallback): Use sendOrQueueEvent.
4300         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
4301         (mouseUpCallback): Use sendOrQueueEvent.
4302         (mouseMoveToCallback): Ditto.
4303         (mouseWheelToCallback): Ditto.
4304         (sendOrQueueEvent): Added.
4305         (dispatchEvent): Added.
4306         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
4307         (makeEventSender): Only initialize the EventSender when loading the top frame.
4308         * DumpRenderTree/gtk/EventSender.h: Ditto.
4309
4310 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
4311
4312         Reviewed by Xan Lopez.
4313
4314         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
4315         https://bugs.webkit.org/show_bug.cgi?id=39101
4316
4317         Work around timing issues for render tree dumps by pumping the
4318         main loop before doing the dump. Resize events are asynchronous
4319         in GTK+, so sometimes resize requests are still pending when DRT
4320         dumps the tree.
4321
4322         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4323         (dump): Pump the main loop before dumping the render tree.
4324
4325 2010-05-31  Kent Tamura  <tkent@chromium.org>
4326
4327         Reviewed by Dimitri Glazkov.
4328
4329         [DRT/Chromium] Fix crash of a test after another test with multiple windows
4330         https://bugs.webkit.org/show_bug.cgi?id=39942
4331
4332         If a test opens multiple windows, focuses on non-main window, and
4333         the focused window is closed, TestShell::m_focusedWidget points a
4334         deleted object.
4335
4336         * DumpRenderTree/chromium/TestShell.cpp:
4337         (TestShell::closeWindow): Clear m_focusedWidget.
4338
4339 2010-05-30  Kent Tamura  <tkent@chromium.org>
4340
4341         Reviewed by Dimitri Glazkov.
4342
4343         new-run-webkit-tests: Support DRT on Chromium-win
4344         https://bugs.webkit.org/show_bug.cgi?id=39810
4345
4346         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
4347         it behaves like test_shell about command analysis, printing
4348         format, pixel dumping, and timeout handling.
4349
4350         chromium.py and chromium_win.py supports the --test-shell flag and
4351         DRT/Chromium-win binary names.
4352         
4353         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
4354         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4355         (runTest): Support for test_shell-style command.
4356         (main): Introduce --test-shell.
4357         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
4358         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
4359           TestEventPrinter class manages stdio output and image output.
4360           TestEventPrinter.cpp has two implementations; DRTPrinter and
4361           TestShellPrinter.
4362         * DumpRenderTree/chromium/TestShell.cpp:
4363           Some changes for TestEventPrinter.
4364         (TestShell::TestShell):
4365         (TestShell::runFileTest):
4366         (TestShell::testTimedOut):
4367         (TestShell::dump):
4368         (TestShell::dumpImage):
4369         * DumpRenderTree/chromium/TestShell.h:
4370         (TestShell::printer):
4371         (TestShell::layoutTestTimeout):
4372         (TestShell::layoutTestTimeoutForWatchDog):
4373         (TestShell::setLayoutTestTimeout):
4374         * DumpRenderTree/chromium/TestShellWin.cpp:
4375         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
4376         * Scripts/webkitpy/layout_tests/port/chromium.py:
4377         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4378
4379 2010-05-30  Robert Hogan  <robert@webkit.org>
4380
4381         Reviewed by Kenneth Rohde Christiansen.