Unbreak test-webkitpy
[WebKit.git] / WebKitTools / ChangeLog
1 2010-09-22  Adam Roben  <aroben@apple.com>
2
3         Unbreak test-webkitpy
4
5         * Scripts/webkitpy/test/main.py:
6         (Tester.run_tests): Add a line that mysteriously got deleted.
7
8 2010-09-22  Adam Roben  <aroben@apple.com>
9
10         Make test-webkitpy test WebKit2's scripts
11
12         These scripts can't be in WebKitTools due to limitations of Apple's
13         build process. But that doesn't mean we can't test them!
14
15         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
16         WebKit2/Scripts
17
18         Reviewed by Adam Barth.
19
20         * Scripts/test-webkitpy:
21         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
22         Now takes an external_package_paths parameter and cleans both webkitpy
23         and any external packages.
24         (init): Added an external_package_paths parameter which we pass along
25         to _clean_packages_with_test.
26         (top level): Add WebKit2/Scripts/webkit2 as our only external package
27         and pass it along to init and Tester.run_tests.
28
29         * Scripts/webkitpy/test/main.py:
30         (Tester.run_tests): Added an optional external_package_paths
31         parameter. We modify sys.path so that the external packages can be
32         imported, and search for unittest files inside all external packages
33         in addition to inside webkitpy.
34
35 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
36
37         Reviewed by Tony Chang.
38
39         new-run-webkit-tests: r68063 broke linux python tests
40
41         Add a missing "from __future__ import with_statement" to this
42         new file; the perils of testing only on the Mac and by review :(
43
44         https://bugs.webkit.org/show_bug.cgi?id=46293
45
46         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
47
48 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
49
50         Reviewed by Tony Chang.
51
52         Add a 'chromium-gpu' set of ports that will test the accelerated
53         GPU paths. This patch adds:
54
55         - support for the '--accelerated-compositing' and
56           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
57           'no-' flags)
58         - adds a new set of Ports that will look under
59           platform/chromium-gpu-$OS/ for baselines before looking in the
60           regular chromium search path
61         - adds a new test_expectations.txt file in platform/chromium-gpu
62           that skips all but the tests we actually want to run with
63           acceleration.
64
65         This patch will allow us to run both with and without acceleration
66         and to change the defaults for both the regular and -gpu options
67         as the code evolves.
68
69         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
70         each test bot.
71
72         https://bugs.webkit.org/show_bug.cgi?id=46225
73
74         * Scripts/webkitpy/layout_tests/port/chromium.py:
75         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
76         * Scripts/webkitpy/layout_tests/port/factory.py:
77         * Scripts/webkitpy/layout_tests/port/webkit.py:
78
79 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
80
81         Reviewed by Kenneth Rohde Christiansen.
82
83         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
84         https://bugs.webkit.org/show_bug.cgi?id=43988
85
86         Runs a web debug server on port specified by QtTestBrowser
87         argument -remote-inspector-port. Property
88         _q_webInspectorServerPort of the QWebPage instance will be set
89         according to the argument. All pages with that property set will
90         be remotely inspectable.
91
92         URL for remote inspection of first QWebPage is
93             http://localhost:9222/webkit/inspector/inspector.html?page=1
94         where 1 is the number of the QWebPage instance.
95
96         The base URL yields an index page with links to the individual inspectors:
97             http://localhost:9222/
98
99         * QtTestBrowser/launcherwindow.cpp:
100         (LauncherWindow::init):
101         * QtTestBrowser/launcherwindow.h:
102         * QtTestBrowser/main.cpp:
103         (LauncherApplication::handleUserOptions):
104
105 2010-09-22  Adam Roben  <aroben@apple.com>
106
107         Fix webkit-patch failure-reason now that build.webkit.org has been
108         updated
109
110         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
111         every time
112
113         Reviewed by Eric Seidel.
114
115         * Scripts/webkitpy/common/net/buildbot.py:
116         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
117         looking for an element that contains text, then returns it.
118         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
119         text out of the cells. This way it doesn't matter whether the cells
120         have <b> children (as for cells in directory rows) or not (as for
121         cells in file rows)
122         (BuildBot._parse_twisted_directory_listing): Look for rows that have
123         the "directory" or "file" class, rather than rows with any class,
124         since header rows now have a class attribute.
125
126         * Scripts/webkitpy/common/net/buildbot_unittest.py:
127         (BuildBotTest._example_directory_listing): Updated to more closely
128         match the markup that build.webkit.org is producing now.
129
130 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
131
132         Unreviewed, build fix.
133
134         new-run-webkit-tests: fix bug introduced in r68008 where if you
135         specify --chromium and no --platform, and you're running on
136         windows, you use the 'chromium-win' port by default instead of the
137         version-specific port. This breaks the buildbots.
138
139         It will be good for this refactoring to settle down so I can
140         rewrite the logic for default ports and the unit tests to be
141         clearer (and the testing more comprehensive).
142
143         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
144
145 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
146
147         Reviewed by Adam Barth.
148
149         Modify the Port interface to take only a series of keyword arguments
150         in the constructor, and modify Port/factory.get() to accomodate that,
151         and to accept user=XXX as an argument so we can pass
152         webkitpy.common.system.user.User objects in.
153
154         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
155         to use the common routine in webkitpy.common.system.user.open_url()
156         to display HTML files.
157
158         There was a routine in the Port interface to do the same thing,
159         but I see no need for a port-specific hook for this, since it is
160         something that will always be executed by the host environment
161         and displaying web pages has nothing to do with running layout tests.
162
163         Note that new-run-webkit-tests used to use test_shell to display
164         the page; this is potentially useful so that you can actually click
165         from a result to the broken page; however, since DumpRenderTree
166         doesn't support this functionality, it will be going away eventually.
167
168         https://bugs.webkit.org/show_bug.cgi?id=46128
169
170         * Scripts/webkitpy/layout_tests/port/base.py:
171         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
172         * Scripts/webkitpy/layout_tests/port/chromium.py:
173         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
174         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
175         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
176         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
177         * Scripts/webkitpy/layout_tests/port/dryrun.py:
178         * Scripts/webkitpy/layout_tests/port/factory.py:
179         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
180         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
181         * Scripts/webkitpy/layout_tests/port/gtk.py:
182         * Scripts/webkitpy/layout_tests/port/mac.py:
183         * Scripts/webkitpy/layout_tests/port/qt.py:
184         * Scripts/webkitpy/layout_tests/port/test.py:
185         * Scripts/webkitpy/layout_tests/port/webkit.py:
186         * Scripts/webkitpy/layout_tests/port/win.py:
187         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
188         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
189         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
190
191 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
192
193         Reviewed by Kenneth Rohde Christiansen.
194
195         [EFL] Get fresh theme when running EWebLauncher
196         https://bugs.webkit.org/show_bug.cgi?id=46210
197
198         If user tried to run EWebLauncher outside of the build tree, it would
199         not find the theme and fallback to the installed one. However, since
200         EWebLauncher is not installed, we always want to take the theme from
201         the just compiled source code. If user had never installed WebKit's
202         EFL port it could even receive a segv since no theme would be found.
203
204         Now EWebLauncher does not fallback to the installed theme and CMake
205         gives as DATA_DIR the directory of the theme it has just built.
206
207         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
208         EWebLauncher.
209         * EWebLauncher/main.c: Use only the theme from build director. Do not
210         fallback to others as this could hide real bugs.
211         (quit):
212         (browserCreate):
213         (findThemePath):
214         (main):
215
216 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
217
218         Unreviewed, build fix.
219
220         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
221         it just confuses it.
222
223         https://bugs.webkit.org/show_bug.cgi?id=46230
224
225         * Scripts/webkitpy/layout_tests/port/webkit.py:
226
227 2010-09-21  Lucas Forschler  <lforschler@apple.com>
228
229         Reviewed by Stephanie Lewis.
230
231         Make a new buildbot for Leopard Debug Test
232
233         * BuildSlaveSupport/build.webkit.org-config/config.json:
234
235 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
236
237         Unreviewed, build fix.
238
239         Fix breakage of Chromium Mac DRT port caused by r67905.
240
241         https://bugs.webkit.org/show_bug.cgi?id=46230
242
243         * Scripts/webkitpy/layout_tests/port/webkit.py:
244
245 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
246
247         Unreviewed, build fix.
248
249         Add missing import of 'tempfile'.
250
251         * Scripts/webkitpy/layout_tests/port/chromium.py:
252
253 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
254
255         Reviewed by Ojan Vafai.
256
257         new-run-webkit-tests: pull the list of tests from the Port, and
258            make it possible to run with no actual test files in the filesystem.
259
260         This set of changes allows us to delete the special
261         webkitpy/layout_tests/data directory and test the generic code without
262         touching the filesystem (except to write results). This speeds up
263         test-webkitpy substantially.
264
265         This also cleans up and removes several code paths in the generic
266         code and fixes some minor bugs, notably in the test_expectations
267         parsing, which was previously fragile if the tests weren't present.
268
269         We also change the way we diff image results to be able to do so
270         in memory, without relying on files. This slows down chromium
271         test_shell, which always writes images to files, but should speed
272         up DRT and ImageDiff-based implementations slightly.
273
274         Note that pulling the list of tests to run from the Port will allow
275         ports to specify what tests to run as an inclusive list; previously
276         you could only do this as an exclusive list by using a 
277         test_expectations file or Skipped files; nothing actually uses this
278         feature yet and it's unclear if it should be used.
279
280         Note that there are no functional changes -- apart from now 
281         always printing out the location of the checksum file when we are
282         tracing test runs -- and the total number of lines of non-test code
283         actually drops by two.
284
285         There is some more cleanup that can be done in the Port/Driver 
286         interface and in some handling of filenames, but I'll save that
287         for another change.
288
289         https://bugs.webkit.org/show_bug.cgi?id=45801
290
291         * Scripts/webkitpy/layout_tests/data/*: Removed.
292             - no longer need special mock layout_tests_directory in the
293               repository.
294         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
295             - add code to display missing text files, checksums when tracing
296             - update to not look at the filesystem directly.
297         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
298             - add more unit tests
299         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
300             - remove tests_are_present flag
301             - update with changes in Port interface - no longer access
302               the filesystem directly, although we still use os.path for
303               filename manipulation.
304         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
305             - add more unit tests
306         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
307             - renamed to port/test_files.py
308         * Scripts/webkitpy/layout_tests/port/base.py:
309             - change diff_image() to expect actual image data, not filenames
310             - add expected_checksum(), expected_image(), expected_text() to
311               return the content of the files so that we don't need a filesystem
312             - add path_exists(), path_isdir() for filesystem-like access.
313             - add test_dirs() to keep clobber-test-results from needing to
314               actually look at a real layout tests dir
315             - add tests() to return the list of tests to run on the port
316               (calls port/test_files to do the work).
317             - add update_baseline() to be able to save new baselines
318             - add uri_to_test_name() from port/dryrun.py so we can easily check
319               filename_to_uri()
320         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
321             - add more unit tests
322         * Scripts/webkitpy/layout_tests/port/chromium.py:
323             - change diff_image() to accept image content, not filenames.
324               This will be slower for test_shell/image_diff, but faster
325               for DRT/ImageDiff.
326         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
327             - add more unit tests
328         * Scripts/webkitpy/layout_tests/port/dryrun.py:
329             - simplify greatly
330         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
331             - add more unit tests
332         * Scripts/webkitpy/layout_tests/port/test.py:
333             - massive rewrite to use in-script list of tests and expectations
334         * Scripts/webkitpy/layout_tests/port/test_files.py:
335             - rename from layout_package/test_files.
336         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
337             - add unit tests
338         * Scripts/webkitpy/layout_tests/port/webkit.py:
339             - update diff_image() to take image contents, not files. Should
340               make things slightly faster.
341         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
342             - update with changes to diff_image()
343         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
344             - update with changes to diff_image()
345         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
346             - remove tests_are_present from test_expectations
347             - pull the list of tests from port.tests() instead
348               of calling test_files.py directly.
349         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
350             - update unit tests
351         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
352             - update with changes to 
353         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
354             - update with change in Port interface
355         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
356             - update with change in Port interface
357         * Scripts/webkitpy/style/checkers/test_expectations.py:
358             - remove the tests_are_present flag
359
360 2010-09-21  Anders Carlsson  <andersca@apple.com>
361
362         Disable logging.
363
364         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
365
366 2010-09-21  Tony Chang  <tony@chromium.org>
367
368         Reviewed by Kent Tamura.
369
370         add a script for running webkit_unit_tests
371         https://bugs.webkit.org/show_bug.cgi?id=46014
372
373         * Scripts/run-chromium-webkit-unit-tests: Added.
374
375 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
376
377         Reviewed by Martin Robinson.
378
379         Fix linking problems on Windows.
380         https://bugs.webkit.org/show_bug.cgi?id=45844
381
382         * GNUmakefile.am: link the executables with winmm.dll
383
384 2010-09-21  Adam Barth  <abarth@webkit.org>
385
386         Reviewed by Eric Seidel.
387
388         feeder-queue svn updates more often than needed
389         https://bugs.webkit.org/show_bug.cgi?id=46171
390
391         We don't need to poll SVN every time we feed the feeders.  Rather, we
392         can count on the wrapper shell script to auto-update the queue.
393
394         * Scripts/webkitpy/tool/commands/queues.py:
395         * Scripts/webkitpy/tool/commands/queues_unittest.py:
396
397 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
398
399         Reviewed by Andreas Kling.
400
401         [Qt] Add robot loader timeout and extra time options.
402         https://bugs.webkit.org/show_bug.cgi?id=46172
403
404         [-robot-timeout <s>]: Load the next page after s seconds if the current
405         page didn't finish loading.
406         [-robot-extra-time <s>]: Wait s seconds after the current page finished
407         loading before loading the next one. This should allow some time for the
408         page's JavaScript to execute.
409
410         * QtTestBrowser/launcherwindow.cpp:
411         (LauncherWindow::applyPrefs):
412         * QtTestBrowser/main.cpp:
413         (LauncherApplication::robotTimeout):
414         (LauncherApplication::robotExtraTime):
415         (LauncherApplication::LauncherApplication):
416         (LauncherApplication::handleUserOptions):
417         (main):
418         * QtTestBrowser/urlloader.cpp:
419         (UrlLoader::UrlLoader):
420         (UrlLoader::loadNext):
421         (UrlLoader::loadUrlList):
422         * QtTestBrowser/urlloader.h:
423
424 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
425
426         Unreviewed.
427
428         Adding myself to the committers list.
429
430         * Scripts/webkitpy/common/config/committers.py:
431
432 2010-09-20  Philippe Normand  <pnormand@igalia.com>
433
434         Reviewed by Eric Carlson.
435
436         [GTK] enhanced context menu for media elements
437         https://bugs.webkit.org/show_bug.cgi?id=45021
438
439         EventSender::contextClick() now returns an array of js
440         objects. Each object has a title property and a click() method.
441
442         * DumpRenderTree/gtk/EventSender.cpp:
443         (getMenuItemTitleCallback):
444         (setMenuItemTitleCallback):
445         (menuItemClickCallback):
446         (getMenuItemClass):
447         (contextClickCallback):
448
449 2010-09-20  Hayato Ito  <hayato@chromium.org>
450
451         Unreviewed.
452         Adding myself to the committers list.
453
454         * Scripts/webkitpy/common/config/committers.py:
455
456 2010-09-20  Adam Barth  <abarth@webkit.org>
457
458         Reviewed by Eric Seidel.
459
460         The tool member variable should be called _tool
461         https://bugs.webkit.org/show_bug.cgi?id=46160
462
463         Created by find-and-replace.
464
465         * Scripts/webkitpy/tool/commands/download.py:
466         * Scripts/webkitpy/tool/commands/openbugs.py:
467         * Scripts/webkitpy/tool/commands/queries.py:
468         * Scripts/webkitpy/tool/commands/queues.py:
469         * Scripts/webkitpy/tool/commands/queues_unittest.py:
470         * Scripts/webkitpy/tool/commands/rebaseline.py:
471         * Scripts/webkitpy/tool/commands/sheriffbot.py:
472         * Scripts/webkitpy/tool/commands/upload.py:
473         * Scripts/webkitpy/tool/multicommandtool.py:
474
475 2010-09-20  Adam Barth  <abarth@webkit.org>
476
477         I ran the tests before landing but ignored the fact that they failed.  :(
478
479         * Scripts/webkitpy/tool/commands/queues.py:
480
481 2010-09-20  Adam Barth  <abarth@webkit.org>
482
483         Reviewed by Eric Seidel.
484
485         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
486         https://bugs.webkit.org/show_bug.cgi?id=46141
487
488         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
489         list of work items on the status server.  The individual commit-cluster
490         nodes then grab the patches from the server and process them.
491
492         * Scripts/webkitpy/tool/bot/feeders.py: Added.
493         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
494         * Scripts/webkitpy/tool/commands/queues.py:
495         * Scripts/webkitpy/tool/commands/queues_unittest.py:
496         * Scripts/webkitpy/tool/commands/queuestest.py:
497
498 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
499
500         Reviewed by Darin Adler.
501
502         build-webkit: Add support for CMake build system
503         https://bugs.webkit.org/show_bug.cgi?id=44979
504
505         * Scripts/build-webkit: Add "--efl" command-line option to build the
506         EFL port of WebKit.
507         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
508         buildEflCMakeProject() subroutines.
509
510 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
511
512         Reviewed by Ojan Vafai.
513
514         new-run-webkit-tests: refactor command line args getting passed to DRT
515
516         This change cleans up some argument parsing between functions to get
517         rid of some overlapping data structures. There should be no functional
518         changes in this patch; it is pure refactoring in preparation for
519         landing the Chrome GPU port and adding a generic way to pass
520         args to DRT/TestShell.
521
522         https://bugs.webkit.org/show_bug.cgi?id=46135
523
524         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
525           - pass the options argument explicitly to the threads and drivers,
526             also consolidate the passing of options to the driver.
527           - pass options directly to process_output() to remove a couple
528             parameters (minor cleanup).
529         * Scripts/webkitpy/layout_tests/port/base.py:
530           - pass the options argument to Port.create_driver().
531         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
532           - update Port.create_driver() test
533         * Scripts/webkitpy/layout_tests/port/chromium.py:
534           - pass the options argument to Port.create_driver(), and clean up
535             building of the cmd line for DRT.
536         * Scripts/webkitpy/layout_tests/port/dryrun.py:
537           - pass the options argument to Port.create_driver()
538         * Scripts/webkitpy/layout_tests/port/test.py:
539           - pass the options argument to Port.create_driver()
540         * Scripts/webkitpy/layout_tests/port/webkit.py:
541           - pass the options argument to Port.create_driver(), and clean up
542             building of the cmd line for DRT.
543         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
544           - consolidate args in _get_dump_render_tree_args and rename to
545             _get_test_args(); move all of the command-line args to the
546             Port implementations.
547
548 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
549
550         Revert change which was accidentally committed along with some expectation changes.
551
552         * Scripts/webkitpy/layout_tests/port/base.py:
553
554 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
555
556         Reviewed by Adam Barth.
557
558         Add explicit --force-patch flag to webkitpy tools
559         https://bugs.webkit.org/show_bug.cgi?id=46103
560         
561         It wasn't obvious until I read the applypatch.py source code that
562         --non-interfactive implies passing --force to patch. Add --force-patch
563         as an alias to the flag, so that this behavior is more discoverable.
564
565         * Scripts/webkitpy/tool/steps/applypatch.py:
566         * Scripts/webkitpy/tool/steps/options.py:
567
568 2010-09-20  Eric Seidel  <eric@webkit.org>
569
570         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
571
572         commit-queue can't land patches
573         https://bugs.webkit.org/show_bug.cgi?id=46138
574
575         Add a line of code I forgot in my last commit.
576
577         * Scripts/webkitpy/common/net/bugzilla.py:
578         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
579
580 2010-09-20  Adam Barth  <abarth@webkit.org>
581
582         Reviewed by Eric Seidel.
583
584         The commit-cluster bots still race to lock patch_ids
585         https://bugs.webkit.org/show_bug.cgi?id=46130
586
587         It turns out we need to use a transaction object to make the
588         read/modify/write lock operation atomic.  From reading the AppEngine
589         documentation, I think this patch should do what we want.  It's hard to
590         test locally because the test instance isn't distributed in the same
591         way the production instance is.
592
593         * QueueStatusServer/handlers/nextpatch.py:
594         * QueueStatusServer/model/activeworkitems.py: Added.
595
596 2010-09-20  Andy Estes  <aestes@apple.com>
597
598         Reviewed by Adam Barth.
599
600         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
601         https://bugs.webkit.org/show_bug.cgi?id=40961
602
603         Implement WebKitUsePreHTML5ParserQuirks preference.
604
605         * DumpRenderTree/mac/DumpRenderTree.mm:
606         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
607         to false after a test finishes.
608
609 2010-09-20  Adam Roben  <aroben@apple.com>
610
611         Windows build fix
612
613         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
614         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
615         we'll pick up the most recent versions of the headers.
616
617 2010-09-20  Eric Seidel  <eric@webkit.org>
618
619         Reviewed by Adam Barth.
620
621         commit-queue should check commit-queue+ again just before committing
622         https://bugs.webkit.org/show_bug.cgi?id=32679
623
624         Added a _revalidate_patch check, right before landing.
625
626         Since _revalidate_patch passes the patch_id from the work item
627         back to bugzilla, I had to fix all of the previous queue tests to
628         use valid attachment ids (that's the majority of this change).
629
630         In order to validate that the bug was still open, I had to teach
631         bugzilla.Bug about open/closed states.
632
633         * Scripts/webkitpy/common/net/bugzilla.py:
634         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
635         * Scripts/webkitpy/tool/commands/queues.py:
636         * Scripts/webkitpy/tool/commands/queues_unittest.py:
637         * Scripts/webkitpy/tool/commands/queuestest.py:
638         * Scripts/webkitpy/tool/mocktool.py:
639
640 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
641
642         Unreviewed.
643
644         Adding myself as a comitter.
645
646         * Scripts/webkitpy/common/config/committers.py:
647
648 2010-09-20  Adam Barth  <abarth@webkit.org>
649
650         Reviewed by Eric Seidel.
651
652         Two instances of commit-queue try to process the same patch
653         https://bugs.webkit.org/show_bug.cgi?id=46113
654
655         This patch makes next-patch atomic so that the server won't vend the
656         same patch twice in the same hour.
657
658         * QueueStatusServer/handlers/nextpatch.py:
659
660 2010-09-20  Adam Roben  <aroben@apple.com>
661
662         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
663
664         We were previously trying to use a CFRunLoopTimer, but since Windows
665         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
666         Windows-style timer on Windows.
667
668         I also replaced all uses of "watchdog" with "watchdog timer".
669
670         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
671         watchdog timer doesn't work on Windows
672
673         Reviewed by Anders Carlsson.
674
675         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
676         (WTR::InjectedBundlePage::dump): Updated for rename.
677
678         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
679         platform-specific functions.
680         (WTR::LayoutTestController::LayoutTestController): Added call to
681         platformInitialize.
682         (WTR::LayoutTestController::waitUntilDone): Changed to call
683         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
684         right in this function.
685         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
686         rename.
687
688         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
689         members needed to support the watchdog timer abstraction. Replaced
690         some "watchdog"s with "watchdog timer".
691
692         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
693         Added.
694         (WTR::LayoutTestController::platformInitialize): Does nothing on this
695         platform.
696         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
697         from LayoutTestController.cpp and changed to use an early return.
698         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
699         LayoutTestController.cpp.
700         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
701         Moved code here from LayoutTestController::waitUntilDone and changed
702         to use an early return.
703
704         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
705         Added.
706         (WTR::LayoutTestController::platformInitialize): Initialize our
707         watchdog timer.
708         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
709         Kills and clears the watchdog timer.
710         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
711         LayoutTestController member function of the same name.
712         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
713         Added. Sets up the timer if it isn't already set.
714
715         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
716         LayoutTestControllerMac.mm.
717
718         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
719         LayoutTestControllerWin.cpp.
720
721 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
722
723         Reviewed by Daniel Bates.
724
725         [GTK] fast/forms/listbox-selection.html fails
726         https://bugs.webkit.org/show_bug.cgi?id=45942
727
728         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
729         strings in keyDownCallback.
730
731         * DumpRenderTree/gtk/EventSender.cpp:
732         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
733         modifier parsing logic.
734
735 2010-09-19  Sam Weinig  <sam@webkit.org>
736
737         Reviewed by Anders Carlsson.
738
739         WebKit2 decidePolicyForNavigationAction should include mouse button information
740         <rdar://problem/8413165>
741         https://bugs.webkit.org/show_bug.cgi?id=46060
742
743         * MiniBrowser/mac/BrowserWindowController.m:
744         (decidePolicyForNavigationAction):
745         (decidePolicyForNewWindowAction):
746
747 2010-09-19  Daniel Bates  <dbates@rim.com>
748
749         Reviewed by Martin Robinson.
750
751         Add unit tests for diffs that delete or modify a change log entry
752         or describe changes that are far apart
753         https://bugs.webkit.org/show_bug.cgi?id=46046
754
755         Add additional unit tests to test change log diffs that contain
756         deletions or changes that are far apart from each other in the
757         ChangeLog file.
758
759         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
760           - Added the following unit tests:
761           "fixChangeLogPatch: [no change] In-place change."
762           "fixChangeLogPatch: [no change] Remove first entry."
763           "fixChangeLogPatch: [no change] Remove entry in the middle."
764           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
765
766 2010-09-19  Sam Weinig  <sam@webkit.org>
767
768         Reviewed by Anders Carlsson.
769
770         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
771         https://bugs.webkit.org/show_bug.cgi?id=46054
772
773         The new one acts like WKBundleNodeHandleRef and allows for getting a
774         wrapper in a specific world for the handle.
775
776         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
777         (WTR::propertyValue):
778         (WTR::propertyValueDouble):
779         (WTR::propertyValueInt):
780         (WTR::numericWindowPropertyValue):
781         (WTR::toStr):
782         (WTR::InjectedBundlePage::shouldBeginEditing):
783         (WTR::InjectedBundlePage::shouldEndEditing):
784         (WTR::InjectedBundlePage::shouldInsertNode):
785         (WTR::InjectedBundlePage::shouldInsertText):
786         (WTR::InjectedBundlePage::shouldDeleteRange):
787         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
788         (WTR::InjectedBundlePage::shouldApplyStyle):
789         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
790
791 2010-09-19  Kent Tamura  <tkent@chromium.org>
792
793         Unreviewed. Fix WebGL test regressions by r67809.
794
795         * DumpRenderTree/chromium/WebPreferences.cpp:
796         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
797
798 2010-09-19  Kent Tamura  <tkent@chromium.org>
799
800         Reviewed by Adam Barth.
801
802         [DRT/Chromium] Fix a WebSettings handling bug
803         https://bugs.webkit.org/show_bug.cgi?id=45945
804
805         Before this change, Chromium DRT reset WebSettings for every new
806         window. It was wrong.
807         If new window is not the first one, we have to apply the same
808         settings as the first window.  So, we introduce WebPreference to
809         store the current settings, and apply it to new windows. It's same
810         as test_shell's behavior.
811
812         * DumpRenderTree/DumpRenderTree.gypi:
813         * DumpRenderTree/chromium/LayoutTestController.cpp:
814           Use WebPreferences instead of WebSettings.
815         (LayoutTestController::setUserStyleSheetEnabled):
816         (LayoutTestController::setUserStyleSheetLocation):
817         (LayoutTestController::setAuthorAndUserStylesEnabled):
818         (LayoutTestController::setPopupBlockingEnabled):
819         (LayoutTestController::disableImageLoading):
820         (LayoutTestController::setJavaScriptCanAccessClipboard):
821         (LayoutTestController::setXSSAuditorEnabled):
822         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
823         (LayoutTestController::setAllowFileAccessFromFileURLs):
824         (LayoutTestController::overridePreference):
825         (LayoutTestController::setEditingBehavior):
826         * DumpRenderTree/chromium/TestShell.cpp:
827         (TestShell::resetWebSettings): Use WebPreferences.
828         (TestShell::runFileTest): ditto.
829         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
830         * DumpRenderTree/chromium/TestShell.h:
831         (TestShell::preferences):
832         (TestShell::applyPreferences):
833         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
834         * DumpRenderTree/chromium/WebPreferences.h: Added.
835
836 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
837
838         Reviewed by David Levin.
839
840         update-webkit --chromium spitting out a spurious error
841         https://bugs.webkit.org/show_bug.cgi?id=45868
842
843         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
844
845 2010-09-18  Sam Weinig  <sam@webkit.org>
846
847         Reviewed by Dan Bernstein.
848
849         Improve/unify the PageLoadClient interfaces
850         https://bugs.webkit.org/show_bug.cgi?id=46043
851
852         * MiniBrowser/mac/BrowserWindowController.m:
853         (didStartProvisionalLoadForFrame):
854         (didReceiveServerRedirectForProvisionalLoadForFrame):
855         (didFailProvisionalLoadWithErrorForFrame):
856         (didCommitLoadForFrame):
857         (didFinishDocumentLoadForFrame):
858         (didFinishLoadForFrame):
859         (didFailLoadWithErrorForFrame):
860         (didReceiveTitleForFrame):
861         (didFirstLayoutForFrame):
862         (didFirstVisuallyNonEmptyLayoutForFrame):
863         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
864         (WTR::InjectedBundlePage::InjectedBundlePage):
865         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
866         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
867         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
868         (WTR::InjectedBundlePage::didCommitLoadForFrame):
869         (WTR::InjectedBundlePage::didFinishLoadForFrame):
870         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
871         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
872         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
873         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
874         * WebKitTestRunner/TestController.cpp:
875         (WTR::TestController::didReceiveMessageFromInjectedBundle):
876         (WTR::TestController::didFinishLoadForFrame):
877         * WebKitTestRunner/TestController.h:
878
879 2010-09-17  Eric Seidel  <eric@webkit.org>
880
881         Unreviewed.  Adding a shell script I use to run the
882         commit-queue. Now that multiple machines run the cq,
883         it makes sense to share the script between them.
884
885         * EWSTools/start-commit-queue.sh: Added.
886
887 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
888
889         Reviewed by Jon Honeycutt.
890
891         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
892         slightly harder to read, so this reverts the previous background colors for various
893         states, making it easier to read.
894
895         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
896         (.success):
897         (.failure):
898         (.warnings):
899         (.exception):
900         (.start,.running,td.building):
901         (.offline,td.offline):
902
903 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
904
905         Unreviewed, rolling out r67692.
906         http://trac.webkit.org/changeset/67692
907         https://bugs.webkit.org/show_bug.cgi?id=46011
908
909         broke layout test dashboard (Requested by johnny_g on
910         #webkit).
911
912         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
913         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
914         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
915
916 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
917
918         Reviewed by Oliver Hunt.
919
920         Style bot complains about cairo forward declaration naming
921         https://bugs.webkit.org/show_bug.cgi?id=45867
922
923         Exclude Cairo forward declarations from indentifiers with underscores checks.
924
925         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
926         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
927
928 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
929
930         Reviewed by Ojan Vafai.
931
932         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
933         https://bugs.webkit.org/show_bug.cgi?id=45408
934
935         This change also tries to remove duplicated upload_results_json methods
936         in run_webkit_tests.py and json_results_generator.py.
937
938         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
939         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
940         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
941
942 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
943
944         Reviewed by Andreas Kling.
945
946         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
947
948         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
949         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
950         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
951         all page specific stuff to the UI.
952
953         * QtTestBrowser/launcherwindow.cpp:
954         (LauncherWindow::initializeView):
955         * QtTestBrowser/mainwindow.cpp:
956         (MainWindow::MainWindow):
957         (MainWindow::buildUI):
958         (MainWindow::setPage):
959         * QtTestBrowser/mainwindow.h:
960
961 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
962
963         Reviewed by Andreas Kling.
964
965         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
966
967         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
968         object will move to the qgraphicsscene instead of the qgraphicsview.
969
970         * QtTestBrowser/webview.cpp:
971         (WebViewGraphicsBased::setPage):
972         (WebViewGraphicsBased::setResizesToContents):
973         (WebViewGraphicsBased::resizeEvent):
974         (WebViewGraphicsBased::animatedFlip):
975         * QtTestBrowser/webview.h:
976         (WebViewGraphicsBased::setItemCacheMode):
977         (WebViewGraphicsBased::itemCacheMode):
978
979 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
980
981         Reviewed by Andreas Kling.
982
983         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
984
985         We usually separate methods whose body are larger than a few lines from the class definition.
986
987         * QtTestBrowser/webview.h:
988         (WebViewGraphicsBased::yRotation):
989         (WebViewGraphicsBased::setYRotation):
990
991 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
992
993         Reviewed by Andreas Kling.
994
995         Make initializeView method of LauncherWindow private.
996
997         No one else needs to be able to call it but LauncherWindow.
998         Also moving the declation of isGraphicsBased method down in the same file, in order
999         to better group related methods.
1000
1001         * QtTestBrowser/launcherwindow.h:
1002
1003 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1004
1005         Reviewed by Andreas Kling.
1006
1007         Make the getter 'page' method of MainWindow const.
1008
1009         * QtTestBrowser/mainwindow.cpp:
1010         (MainWindow::page):
1011         * QtTestBrowser/mainwindow.h:
1012
1013 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1014
1015         Reviewed by Andreas Kling.
1016
1017         Remove useless parameter from MainWindow class' constructor.
1018
1019         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
1020         not referred in the constructor body and does not make much sense.
1021
1022         * QtTestBrowser/mainwindow.cpp:
1023         (MainWindow::MainWindow):
1024         * QtTestBrowser/mainwindow.h:
1025
1026 2010-09-15  Tony Chang  <tony@chromium.org>
1027
1028         Reviewed by Kent Tamura.
1029
1030         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1031         https://bugs.webkit.org/show_bug.cgi?id=42151
1032
1033         * DumpRenderTree/chromium/LayoutTestController.cpp:
1034         (LayoutTestController::LayoutTestController):
1035         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1036         (WorkItemLoadHTMLString::run):
1037         (LayoutTestController::queueLoadHTMLString):
1038         (LayoutTestController::reset):
1039         (LayoutTestController::setDeferMainResourceDataLoad):
1040         * DumpRenderTree/chromium/LayoutTestController.h:
1041         (LayoutTestController::deferMainResourceDataLoad):
1042         * DumpRenderTree/chromium/WebViewHost.cpp:
1043         (WebViewHost::didCreateDataSource):
1044
1045 2010-09-16  Adrienne Walker  <enne@google.com>
1046
1047         Reviewed by Kenneth Russell.
1048
1049         Add script to synchronize WebKit and Khronos WebGL tests
1050         https://bugs.webkit.org/show_bug.cgi?id=42336
1051
1052         * Scripts/update-webgl-conformance-tests: Added.
1053         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
1054         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
1055
1056 2010-09-16  Sam Weinig  <sam@webkit.org>
1057
1058         Reviewed by Anders Carlsson.
1059
1060         Add support for sending synchronous messages from the InjectedBundle to the WKContext
1061         <rdar://problem/8365320>
1062         https://bugs.webkit.org/show_bug.cgi?id=44785
1063
1064         * MiniBrowser/mac/AppDelegate.m:
1065         (didReceiveSynchronousMessageFromInjectedBundle):
1066         (-[BrowserAppDelegate init]):
1067         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1068         (didCreatePage):
1069         * WebKitTestRunner/TestController.cpp:
1070         (WTR::TestController::initialize):
1071
1072 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
1073
1074         Reviewed by Andreas Kling.
1075
1076         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
1077         https://bugs.webkit.org/show_bug.cgi?id=45885
1078
1079         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
1080
1081         * QtTestBrowser/launcherwindow.cpp:
1082         (LauncherWindow::screenshot):
1083
1084 2010-09-16  Anders Carlsson  <andersca@apple.com>
1085
1086         Fix clang++ build.
1087
1088         * MiniBrowser/mac/BrowserWindowController.m:
1089         (-[BrowserWindowController zoomIn:]):
1090         (-[BrowserWindowController zoomOut:]):
1091         (-[BrowserWindowController resetZoom:]):
1092         Remove trailing semicolons.
1093
1094 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1095
1096         Unreviewed, rolling out r67628.
1097         http://trac.webkit.org/changeset/67628
1098         https://bugs.webkit.org/show_bug.cgi?id=45904
1099
1100         broke the build (Requested by eric_carlson on #webkit).
1101
1102         * DumpRenderTree/gtk/EventSender.cpp:
1103         (contextClickCallback):
1104
1105 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
1106
1107         Unreviewed.
1108
1109         Adding myself as a comitter.
1110
1111         * Scripts/webkitpy/common/config/committers.py:
1112
1113 2010-09-15  Philippe Normand  <pnormand@igalia.com>
1114
1115         Reviewed by Eric Carlson.
1116
1117         [GTK] enhanced context menu for media elements
1118         https://bugs.webkit.org/show_bug.cgi?id=45021
1119
1120         EventSender::contextClick() now returns an array of js
1121         objects. Each object has a title property and a click() method.
1122
1123         * DumpRenderTree/gtk/EventSender.cpp:
1124         (getMenuItemTitleCallback):
1125         (setMenuItemTitleCallback):
1126         (menuItemClickCallback):
1127         (getMenuItemClass):
1128         (contextClickCallback):
1129
1130 2010-09-14  Philippe Normand  <pnormand@igalia.com>
1131
1132         Reviewed by Eric Carlson and Martin Robinson.
1133
1134         [GTK] eventSender.contextClick() should return the contents of the context menu
1135         https://bugs.webkit.org/show_bug.cgi?id=39102
1136
1137         Make the eventSender use the new private WebKitGtk+ API to
1138         retrieve the context-menu item titles and store them in an array.
1139
1140         * DumpRenderTree/gtk/EventSender.cpp:
1141         (contextClickCallback):
1142
1143 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
1144
1145         Reviewed by Jian Li.
1146
1147         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
1148         https://bugs.webkit.org/show_bug.cgi?id=45798
1149
1150         * Scripts/build-webkit:
1151
1152 2010-09-16  Robert Hogan  <robert@webkit.org>
1153
1154         Reviewed by Antonio Gomes.
1155
1156         [Qt] Support globalhistory tests
1157         https://bugs.webkit.org/show_bug.cgi?id=45774
1158
1159         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1160         (WebCore::isGlobalHistoryTest):
1161         (WebCore::DumpRenderTree::open):
1162         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1163         (LayoutTestController::reset):
1164         (LayoutTestController::dumpHistoryCallbacks):
1165         (LayoutTestController::removeAllVisitedLinks):
1166         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1167
1168 2010-09-10  Tony Chang  <tony@chromium.org>
1169
1170         Reviewed by Eric Seidel.
1171
1172         deduplicate-tests should be runnable from any WebKit directory
1173         https://bugs.webkit.org/show_bug.cgi?id=44709
1174
1175         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1176         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1177
1178 2010-09-15  Tony Chang  <tony@chromium.org>
1179
1180         Reviewed by Kent Tamura.
1181
1182         [chromium] sort testing methods in DRT
1183         https://bugs.webkit.org/show_bug.cgi?id=45850
1184
1185         * DumpRenderTree/chromium/EventSender.cpp:
1186         (EventSender::EventSender):
1187         * DumpRenderTree/chromium/LayoutTestController.cpp:
1188         (LayoutTestController::LayoutTestController):
1189         * DumpRenderTree/chromium/TextInputController.cpp:
1190         (TextInputController::TextInputController):
1191
1192 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
1193
1194         Reviewed by Adam Barth.
1195
1196         CQ status shows items out of order
1197         https://bugs.webkit.org/show_bug.cgi?id=45846
1198         
1199         Only group consecutive status items with the same patch ID into the same
1200         group, so that overall item ordering is preserved.
1201         
1202         Also don't indent status items that only have a single item in their
1203         group.
1204
1205         * QueueStatusServer/handlers/queuestatus.py:
1206         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
1207         * QueueStatusServer/templates/queuestatus.html:
1208
1209 2010-09-15  Eric Seidel  <eric@webkit.org>
1210
1211         Reviewed by Adam Barth.
1212
1213         Add queue start/stop messages
1214         https://bugs.webkit.org/show_bug.cgi?id=45853
1215
1216         I ended up needing to clean up a bunch of our unit testing
1217         in order to test this new code path nicely.
1218
1219         There are also a few PEP8 changes needed to pass check-webkit-style.
1220
1221         * Scripts/webkitpy/tool/bot/queueengine.py:
1222         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1223         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1224         * Scripts/webkitpy/tool/commands/queues.py:
1225         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1226         * Scripts/webkitpy/tool/commands/queuestest.py:
1227         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1228
1229 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
1230
1231         https://bugs.webkit.org/show_bug.cgi?id=45849
1232         WKURLCreateWithCFURL crashes with null url
1233         
1234         Fix MiniBrowser crash when the url is not parseable.
1235
1236         * MiniBrowser/mac/BrowserWindowController.m:
1237         (-[BrowserWindowController fetch:]):
1238
1239 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
1240
1241         Unreviewed.
1242
1243         Adding myself to the committers list.
1244
1245         * Scripts/webkitpy/common/config/committers.py:
1246
1247 2010-09-14  Eric Seidel  <eric@webkit.org>
1248
1249         Reviewed by Adam Barth.
1250
1251         Make it possible to run more than one commit-queue instance
1252         https://bugs.webkit.org/show_bug.cgi?id=45786
1253
1254         Mostly we need to make sure the two (or more) instances get
1255         different patches to work on.  To do this, I re-worked
1256         the code responsible for getting the next work item to
1257         round trip through the status server.  The status server only
1258         vends patches from the work items list, only if those patches
1259         have not had status reported for them in the last hour.
1260
1261         This is another step towards making all queues go through the
1262         status server, thus making it possible to run more than one
1263         instance of various EWS bots (as requested in bug 44292).
1264
1265         The webkitpy changes are already covered by existing unit tests.
1266         The QueueStatusSever sadly has no testing infrastructure yet. :(
1267
1268         * QueueStatusServer/handlers/nextpatch.py: Added.
1269         * QueueStatusServer/index.yaml:
1270         * QueueStatusServer/main.py:
1271         * Scripts/webkitpy/tool/commands/queues.py:
1272
1273 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
1274
1275         Reviewed by Tony Chang.
1276
1277         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
1278         https://bugs.webkit.org/show_bug.cgi?id=45791
1279
1280         Force filenames to be raw bytes before running difflib.unified_diff.
1281
1282         * Scripts/webkitpy/layout_tests/port/base.py:
1283         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1284
1285 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
1286
1287         Reviewed by Tor Arne Vestbø.
1288
1289         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
1290         https://bugs.webkit.org/show_bug.cgi?id=35247
1291
1292         The main issue when changing the views is that the plugins and any other components that
1293         depend on view specific attributes such as the native window id are not teared down.
1294         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
1295         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
1296         we decided to work around this in QtTestBrowser by making toggling between QWebView
1297         and QGraphicsWebView also re-create the page.
1298
1299         * QtTestBrowser/launcherwindow.cpp:
1300         (LauncherWindow::initializeView):
1301         * QtTestBrowser/mainwindow.h:
1302
1303 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
1304
1305         Reviewed by Adam Barth.
1306
1307         Send webkit accessibility notifications to Chromium
1308         https://bugs.webkit.org/show_bug.cgi?id=45156
1309
1310         Move printf inside shouldDumpAccessibilityNotifications check.
1311
1312         * DumpRenderTree/chromium/WebViewHost.cpp:
1313         (WebViewHost::postAccessibilityNotification):
1314
1315 2010-09-14  Tony Chang  <tony@chromium.org>
1316
1317         Reviewed by Kent Tamura.
1318
1319         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
1320         https://bugs.webkit.org/show_bug.cgi?id=45788
1321
1322         * DumpRenderTree/chromium/LayoutTestController.cpp:
1323         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
1324
1325 2010-09-14  Tony Chang  <tony@chromium.org>
1326
1327         Reviewed by Ojan Vafai.
1328
1329         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
1330         https://bugs.webkit.org/show_bug.cgi?id=45768
1331
1332         * DumpRenderTree/chromium/TestShell.cpp:
1333         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
1334
1335 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
1336
1337         [wx] Build fix, add newly added directories to the directory list.
1338
1339         * wx/build/settings.py:
1340
1341 2010-09-14  Sam Weinig  <sam@webkit.org>
1342
1343         Reviewed by Anders Carlsson.
1344
1345         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
1346         https://bugs.webkit.org/show_bug.cgi?id=45785
1347
1348         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1349         (WTR::propertyValue):
1350         (WTR::numericWindowPropertyValue):
1351         (WTR::dumpPath):
1352         (WTR::toStr):
1353         (WTR::operator<<):
1354         (WTR::InjectedBundlePage::InjectedBundlePage):
1355         (WTR::InjectedBundlePage::shouldInsertNode):
1356         (WTR::InjectedBundlePage::shouldBeginEditing):
1357         (WTR::InjectedBundlePage::shouldEndEditing):
1358         (WTR::InjectedBundlePage::shouldInsertText):
1359         (WTR::InjectedBundlePage::shouldDeleteRange):
1360         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1361         (WTR::InjectedBundlePage::shouldApplyStyle):
1362         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1363
1364 2010-09-14  Adam Barth  <abarth@webkit.org>
1365
1366         Fix two typos in commit-queue.  The first is harmless.  The second
1367         causes the queue to reject patches when the build is broken.  :(
1368
1369         * Scripts/webkitpy/tool/commands/queues.py:
1370         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1371
1372 2010-09-14  Chris Guillory   <chris.guillory@google.com>
1373
1374         Reviewed by Chris Fleizach.
1375
1376         Send all accessibility notifications to Chromium.
1377         https://bugs.webkit.org/show_bug.cgi?id=45156
1378
1379         * DumpRenderTree/chromium/WebViewHost.cpp:
1380         (WebViewHost::postAccessibilityNotification):
1381         * DumpRenderTree/chromium/WebViewHost.h:
1382
1383 2010-09-14  Adam Barth  <abarth@webkit.org>
1384
1385         Reviewed by Eric Seidel.
1386
1387         commit-queue is slow during the day
1388         https://bugs.webkit.org/show_bug.cgi?id=45780
1389
1390         Thanks to the new logging, we've noticed that checkout-is-out-of-date
1391         errors in the first pass of landing don't retry the land.  Instead,
1392         they're treated as failures and cause the commit-queue to do two more
1393         builds before really trying to land the patch.  Worse, in the second
1394         build, we can get bitten by a flaky test.
1395
1396         This patch takes a slightly different approach to the commit-queue's
1397         main control logic.  We now use a separate subprocess for building and
1398         testing and for landing.  This means we should very rarely see the
1399         checkout-is-out-of-date error, and when we do see it, we should retry
1400         more quickly.  If my understanding is correct, this should be a big
1401         speed win for the commit-queue.
1402
1403         * Scripts/webkitpy/tool/commands/download.py:
1404         * Scripts/webkitpy/tool/commands/queues.py:
1405         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1406
1407 2010-09-14  Tony Chang  <tony@chromium.org>
1408
1409         Reviewed by Dimitri Glazkov.
1410
1411         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
1412         https://bugs.webkit.org/show_bug.cgi?id=45762
1413
1414         * DumpRenderTree/chromium/LayoutTestController.cpp:
1415         (LayoutTestController::LayoutTestController):
1416         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1417         * DumpRenderTree/chromium/LayoutTestController.h:
1418
1419 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
1420
1421         Adding myself as a reviewer.
1422
1423         * Scripts/webkitpy/common/config/committers.py:
1424
1425 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
1426
1427         Reviewed by Kenneth Rohde Christiansen.
1428
1429         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
1430         https://bugs.webkit.org/show_bug.cgi?id=45736
1431
1432         Build-webkit has showed a warning when WebKitBuild didn't exist, add
1433         an additional condition to avoid it.
1434
1435         * Scripts/build-webkit:
1436
1437 2010-09-13  Eric Seidel  <eric@webkit.org>
1438
1439         Reviewed by Adam Barth.
1440
1441         commit-queue should log when it's retrying due to checkout out of date error
1442         https://bugs.webkit.org/show_bug.cgi?id=45725
1443
1444         This will allow us to better track how often we see these errors
1445         and how long it takes the queue to recover from them.
1446
1447         In order to pass the tests, I had to correct an error
1448         from a previous change.  The UnitTestPort should not have
1449         ever been using the base port method as that will read
1450         a file from disk.  If the unit tests haven't passed the contents
1451         it should raise an IOError as though the file doesn't exist.
1452
1453         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1454         * Scripts/webkitpy/tool/commands/queues.py:
1455         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1456
1457 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
1458
1459         Reviewed by Adam Barth.
1460
1461         Upload results when cq patch landing fails
1462         https://bugs.webkit.org/show_bug.cgi?id=45683
1463         
1464         Include script errors when CommitQueue._land fails.
1465
1466         * Scripts/webkitpy/tool/commands/queues.py:
1467
1468 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1469
1470         Reviewed by David Kilzer.
1471
1472         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
1473         https://bugs.webkit.org/show_bug.cgi?id=45548
1474
1475         * DumpRenderTree/AccessibilityUIElement.cpp:
1476         (isIgnoredCallback):
1477         (AccessibilityUIElement::getJSClass):
1478         * DumpRenderTree/AccessibilityUIElement.h:
1479         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1480         (AccessibilityUIElement::isIgnored):
1481         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1482         (AccessibilityUIElement::isIgnored):
1483         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1484         (AccessibilityUIElement::isIgnored):
1485
1486 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1487
1488         Reviewed by Andreas Kling.
1489
1490         jscPath() is incorrect in Windows' cmd.exe shell
1491         https://bugs.webkit.org/show_bug.cgi?id=45651
1492
1493         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
1494
1495 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1496
1497         Reviewed by Darin Adler.
1498
1499         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
1500         https://bugs.webkit.org/show_bug.cgi?id=43807
1501
1502         * DumpRenderTree/AccessibilityUIElement.cpp:
1503         (textMarkerForPointCallback):
1504         (AccessibilityUIElement::textMarkerForPoint):
1505         (AccessibilityUIElement::getJSClass):
1506         * DumpRenderTree/AccessibilityUIElement.h:
1507         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1508         (AccessibilityUIElement::textMarkerForPoint):
1509
1510 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
1511
1512         Reviewed by Kenneth Rohde Christiansen.
1513
1514         [Qt] build-webkit: Add --v8 option to build against V8
1515
1516         Note that V8 is picked up from QtScript, so this currently requires building
1517         against the experimental qt-script-v8 branch.
1518
1519         * Scripts/build-webkit:
1520
1521 2010-09-13  Hans Wennborg  <hans@chromium.org>
1522
1523         Reviewed by Jeremy Orlow.
1524
1525         Add WebDeviceOrientationClientMock::create() and use it from DRT.
1526         https://bugs.webkit.org/show_bug.cgi?id=45650
1527
1528         Do not use the WebDeviceOrientationClientMock constructor directly,
1529         but use the create() member function.
1530
1531         This should fix the linker errors for the multi-DLL Chromium DRT build.
1532
1533         * DumpRenderTree/chromium/LayoutTestController.cpp:
1534         (LayoutTestController::setMockDeviceOrientation):
1535         (LayoutTestController::deviceOrientationClient):
1536
1537 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
1538
1539         Reviewed by Antti Koivisto.
1540
1541         Add support for testing the viewport meta tag algorithm,
1542         based on the following draft spec:
1543
1544         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
1545
1546         Add common handling of viewport meta tag based on new Opera spec
1547         https://bugs.webkit.org/show_bug.cgi?id=44201
1548
1549         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1550         (LayoutTestController::dumpConfigurationForViewport):
1551         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1552
1553 2010-09-12  Kent Tamura  <tkent@chromium.org>
1554
1555         Reviewed by Tony Chang.
1556
1557         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
1558         https://bugs.webkit.org/show_bug.cgi?id=45517
1559
1560         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
1561
1562         * DumpRenderTree/chromium/ImageDiff.cpp:
1563         (Image::craeteFromStdin):
1564         (Image::createFromFilename):
1565         (diffImages):
1566         * DumpRenderTree/chromium/TestShell.cpp:
1567         (TestShell::dumpImage):
1568
1569 2010-09-10  MORITA Hajime  <morrita@google.com>
1570
1571         Reviewed by Tony Chang.
1572
1573         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
1574         https://bugs.webkit.org/show_bug.cgi?id=45441
1575
1576         Added TextInputController::hasSpellingMarker().
1577         
1578         * DumpRenderTree/chromium/TextInputController.cpp:
1579         (TextInputController::TextInputController):
1580         (TextInputController::hasSpellingMarker):
1581         * DumpRenderTree/chromium/TextInputController.h:
1582
1583 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
1584
1585         Unreviewed, build fix.
1586
1587         My last change accidentally contained a local change to the
1588         rebaselinig script; webkit-patch land picked it up without telling
1589         me and committed it :(
1590
1591         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1592
1593 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
1594
1595         Reviewed by Anders Carlsson.
1596
1597         Attempt to fix Windows MiniBrowser build (untested)
1598         https://bugs.webkit.org/show_bug.cgi?id=45609
1599
1600         * MiniBrowser/win/BrowserView.cpp:
1601         (runJavaScriptConfirm):
1602         (runJavaScriptPrompt):
1603
1604 2010-09-11  Sam Weinig  <sam@webkit.org>
1605
1606         Reviewed by Maciej Stachowiak.
1607
1608         Fix zoom related tests when testing WebKit2.
1609
1610         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1611         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
1612
1613 2010-09-11  Sam Weinig  <sam@webkit.org>
1614
1615         Reviewed by Dan Bernstein.
1616
1617         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
1618         <rdar://problem/8359252>
1619         https://bugs.webkit.org/show_bug.cgi?id=45605
1620
1621         * MiniBrowser/mac/BrowserWindowController.m:
1622         (setStatusText):
1623         (contentsSizeChanged):
1624         (-[BrowserWindowController awakeFromNib]):
1625         * MiniBrowser/win/BrowserView.cpp:
1626         (runJavaScriptConfirm):
1627         (runJavaScriptPrompt):
1628         (setStatusText):
1629         (contentsSizeChanged):
1630         (BrowserView::create):
1631         * WebKitTestRunner/TestController.cpp:
1632         (WTR::createOtherPage):
1633         (WTR::TestController::initialize):
1634
1635 2010-09-11  Sam Weinig  <sam@webkit.org>
1636
1637         Reviewed by Dan Bernstein.
1638
1639         Add callback mechanism for the getting the source of a frame
1640         <rdar://problem/8364681>
1641         https://bugs.webkit.org/show_bug.cgi?id=45604
1642
1643         Add ability to dump the main frame's source to the console.
1644
1645         * MiniBrowser/mac/BrowserWindowController.h:
1646         * MiniBrowser/mac/BrowserWindowController.m:
1647         (-[BrowserWindowController dumpSourceToConsole:]):
1648         * MiniBrowser/mac/MainMenu.xib:
1649
1650 2010-09-11  Eric Seidel  <eric@webkit.org>
1651
1652         Reviewed by Adam Barth.
1653
1654         Remove unneeded Empty Queue messages
1655         https://bugs.webkit.org/show_bug.cgi?id=45602
1656
1657         We already have a /gc job to delete these.
1658         recentstatus.py is already smart enough to use the
1659         most recent of the workitems last update or the most recent status,
1660         so removing these should not change the _last_status_date() return
1661         value more than a few milliseconds.
1662
1663         These messages just spam the recent status log.
1664
1665         * Scripts/webkitpy/tool/commands/queues.py:
1666
1667 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1668
1669         Reviewed by Adam Barth.
1670
1671         Fix Python exception when generating synthetic patch IDs
1672         https://bugs.webkit.org/show_bug.cgi?id=45592
1673
1674         Can't concatenate strings and numbers directly.
1675
1676         * QueueStatusServer/handlers/queuestatus.py:
1677
1678 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1679
1680         Reviewed by Adam Barth.
1681
1682         Group statuses in queue status by patch ID
1683         https://bugs.webkit.org/show_bug.cgi?id=45588
1684
1685         Group statuses by patch ID so that the status page is easier
1686         to scan.
1687
1688         * QueueStatusServer/handlers/queuestatus.py:
1689         * QueueStatusServer/stylesheets/dashboard.css:
1690         (.status-group):
1691         (.status-bug):
1692         (.status-group ul):
1693         (.status-group ul li):
1694         (.status-group ul li:hover):
1695         (.status-cell):
1696         (.status-cell:hover):
1697         (.status-cell.pass):
1698         (.status-cell.fail):
1699         (.status-cell.pending):
1700         (.status-cell.error):
1701         * QueueStatusServer/templates/dashboard.html:
1702         * QueueStatusServer/templates/queuestatus.html:
1703
1704 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1705
1706         Reviewed by Tony Chang.
1707
1708         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1709         https://bugs.webkit.org/show_bug.cgi?id=45479
1710
1711         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1712         implementation in ResourceLoadDelegate in the Mac port).
1713
1714         * DumpRenderTree/chromium/LayoutTestController.cpp:
1715         (LayoutTestController::LayoutTestController):
1716         (LayoutTestController::dumpResourceResponseMIMETypes):
1717         (LayoutTestController::reset):
1718         * DumpRenderTree/chromium/LayoutTestController.h:
1719         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1720         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1721         * DumpRenderTree/chromium/TestShell.h:
1722         (TestShell::shouldDumpResourceResponseMIMETypes):
1723         * DumpRenderTree/chromium/WebViewHost.cpp:
1724         (WebViewHost::didReceiveResponse):
1725
1726 2010-09-11  Eric Seidel  <eric@webkit.org>
1727
1728         Reviewed by Adam Barth.
1729
1730         queues.webkit.org should expose /remote_api for data upload/download
1731         https://bugs.webkit.org/show_bug.cgi?id=45559
1732
1733         * QueueStatusServer/app.yaml:
1734          - /remote_api is a standard app-engine service which allows use of
1735            the bulk uploader for data upload/download.  Exposing this
1736            (for admin access only) allows us to use 
1737
1738 2010-09-10  Sam Weinig  <sam@webkit.org>
1739
1740         Reviewed by Dan Bernstein.
1741
1742         Add zoom support to WebKit2 API
1743         <rdar://problem/7660657>
1744         https://bugs.webkit.org/show_bug.cgi?id=45585
1745
1746         - Add zoom options to MiniBrowser that mimic Safari's options using
1747           the new WebKit2 zoom APIs.
1748         - Switch uses of float for the zoom APIs to use double.
1749
1750         * MiniBrowser/mac/BrowserWindowController.h:
1751         * MiniBrowser/mac/BrowserWindowController.m:
1752         (-[BrowserWindowController initWithPageNamespace:]):
1753         (-[BrowserWindowController validateMenuItem:]):
1754         (-[BrowserWindowController validateUserInterfaceItem:]):
1755         (-[BrowserWindowController currentZoomFactor]):
1756         (-[BrowserWindowController setCurrentZoomFactor:]):
1757         (-[BrowserWindowController canZoomIn]):
1758         (-[BrowserWindowController zoomIn:]):
1759         (-[BrowserWindowController canZoomOut]):
1760         (-[BrowserWindowController zoomOut:]):
1761         (-[BrowserWindowController canResetZoom]):
1762         (-[BrowserWindowController resetZoom:]):
1763         (-[BrowserWindowController toggleZoomMode:]):
1764         * MiniBrowser/mac/MainMenu.xib:
1765         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1766         (WTR::EventSendingController::textZoomIn):
1767         (WTR::EventSendingController::textZoomOut):
1768         (WTR::EventSendingController::zoomPageIn):
1769         (WTR::EventSendingController::zoomPageOut):
1770
1771 2010-09-10  Robert Hogan  <robert@webkit.org>
1772
1773         Reviewed by Andreas Kling.
1774
1775         [Qt] Fix crash in DRT in standalone mode
1776
1777         https://bugs.webkit.org/show_bug.cgi?id=45454
1778
1779         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1780         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1781
1782 2010-09-10  Sam Weinig  <sam@webkit.org>
1783
1784         Reviewed by Darin Adler.
1785
1786         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
1787         Precursor to <rdar://problem/7660657>
1788         https://bugs.webkit.org/show_bug.cgi?id=45522
1789
1790         Update for changes to the Bundle API to allow separate control of page and text zoom
1791         levels.
1792
1793         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1794         (WTR::EventSendingController::textZoomIn):
1795         (WTR::EventSendingController::textZoomOut):
1796         (WTR::EventSendingController::zoomPageIn):
1797         (WTR::EventSendingController::zoomPageOut):
1798         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1799         (WTR::InjectedBundlePage::reset):
1800
1801 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
1802
1803         Reviewed by Andreas Kling.
1804
1805         [Qt] Support click event for notifications
1806         https://bugs.webkit.org/show_bug.cgi?id=44836
1807
1808         Add support for simulateDesktopNotificationClick by calling
1809         back to DumpRenderTreeSupportQt.cpp.
1810
1811         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1812         (LayoutTestController::simulateDesktopNotificationClick):
1813         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1814
1815 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
1816
1817         Reviewed by Eric Seidel.
1818
1819         Update queue status when patches fail their first land attempt
1820         https://bugs.webkit.org/show_bug.cgi?id=45583
1821
1822         Add a few more _update_status calls to make it more obvious if a patch is 
1823         being retried because tests failed.
1824
1825         * Scripts/webkitpy/tool/commands/queues.py:
1826
1827 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
1828
1829         Reviewed by Andreas Kling.
1830
1831         [Qt] MiniBrowser crashes with multiply windows when closing one of them
1832         https://bugs.webkit.org/show_bug.cgi?id=45536
1833
1834         * MiniBrowser/qt/BrowserView.cpp:
1835         (BrowserView::BrowserView): Reference the context instead of adopting it
1836         because it can be shared across different views.
1837
1838 2010-09-10  Tony Chang  <tony@chromium.org>
1839
1840         Unreviewed, rolling out r67241.
1841         http://trac.webkit.org/changeset/67241
1842         https://bugs.webkit.org/show_bug.cgi?id=44709
1843
1844         Accidentally committed.
1845
1846         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1847         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1848
1849 2010-09-10  Tony Chang  <tony@chromium.org>
1850
1851         Reviewed by Ojan Vafai.
1852
1853         deduplicate-tests should be runnable from any WebKit directory
1854         https://bugs.webkit.org/show_bug.cgi?id=44709
1855
1856         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1857         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1858
1859 2010-09-10  Tony Chang  <tony@chromium.org>
1860
1861         Unreviewed, rolling out r67216.
1862         http://trac.webkit.org/changeset/67216
1863         https://bugs.webkit.org/show_bug.cgi?id=44709
1864
1865         Broke
1866
1867         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1868         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1869
1870 2010-09-10  Tony Chang  <tony@chromium.org>
1871
1872         Reviewed by Ojan Vafai.
1873
1874         deduplicate-tests should be runnable from any WebKit directory
1875         https://bugs.webkit.org/show_bug.cgi?id=44709
1876
1877         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1878         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1879
1880 2010-09-09  Hans Wennborg  <hans@chromium.org>
1881
1882         Reviewed by Jeremy Orlow.
1883
1884         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
1885         https://bugs.webkit.org/show_bug.cgi?id=45460
1886
1887         This enables DumpRenderTree to run layout tests for DeviceOrientation.
1888
1889         Also declare the LayoutTestController destructor out-of-line.
1890         Otherwise the implicit destructor would cause compiler errors because
1891         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
1892
1893         * DumpRenderTree/chromium/LayoutTestController.cpp:
1894         (LayoutTestController::~LayoutTestController):
1895         (LayoutTestController::setMockDeviceOrientation):
1896         (LayoutTestController::deviceOrientationClient):
1897         * DumpRenderTree/chromium/LayoutTestController.h:
1898         * DumpRenderTree/chromium/WebViewHost.cpp:
1899         (WebViewHost::deviceOrientationClient):
1900         * DumpRenderTree/chromium/WebViewHost.h:
1901
1902 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1903
1904         Unreviewed, rolling out r67119.
1905         http://trac.webkit.org/changeset/67119
1906         https://bugs.webkit.org/show_bug.cgi?id=45505
1907
1908         Extra newlines in results (Requested by tony^work on #webkit).
1909
1910         * DumpRenderTree/chromium/LayoutTestController.cpp:
1911         (LayoutTestController::LayoutTestController):
1912         (LayoutTestController::reset):
1913         * DumpRenderTree/chromium/LayoutTestController.h:
1914         * DumpRenderTree/chromium/TestShell.h:
1915         * DumpRenderTree/chromium/WebViewHost.cpp:
1916         (printResponseDescription):
1917         (printNodeDescription):
1918         (printRangeDescription):
1919         (WebViewHost::shouldBeginEditing):
1920         (WebViewHost::shouldEndEditing):
1921         (WebViewHost::shouldInsertNode):
1922         (WebViewHost::shouldChangeSelectedRange):
1923         (WebViewHost::shouldDeleteRange):
1924         (WebViewHost::shouldApplyStyle):
1925         (WebViewHost::didBeginEditing):
1926         (WebViewHost::didChangeSelection):
1927         (WebViewHost::didChangeContents):
1928         (WebViewHost::didEndEditing):
1929         (WebViewHost::decidePolicyForNavigation):
1930         (WebViewHost::didCancelClientRedirect):
1931         (WebViewHost::didStartProvisionalLoad):
1932         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1933         (WebViewHost::didFailProvisionalLoad):
1934         (WebViewHost::didCommitProvisionalLoad):
1935         (WebViewHost::didFinishDocumentLoad):
1936         (WebViewHost::didHandleOnloadEvents):
1937         (WebViewHost::didFailLoad):
1938         (WebViewHost::didFinishLoad):
1939         (WebViewHost::didChangeLocationWithinPage):
1940         (WebViewHost::willSendRequest):
1941         (WebViewHost::didReceiveResponse):
1942         (WebViewHost::didFinishResourceLoad):
1943         (WebViewHost::didFailResourceLoad):
1944         (WebViewHost::didDisplayInsecureContent):
1945         (WebViewHost::didRunInsecureContent):
1946         (WebViewHost::printFrameDescription):
1947
1948 2010-09-09  Michael Saboff  <msaboff@apple.com>
1949
1950         Unreviewed, adding myself to committers list.
1951
1952         * Scripts/webkitpy/common/config/committers.py:
1953
1954 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1955
1956         Reviewed by Tony Chang.
1957
1958         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1959         https://bugs.webkit.org/show_bug.cgi?id=45479
1960
1961         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1962         implementation in ResourceLoadDelegate in the Mac port).
1963
1964         * DumpRenderTree/chromium/LayoutTestController.cpp:
1965         (LayoutTestController::LayoutTestController):
1966         (LayoutTestController::dumpResourceResponseMIMETypes):
1967         (LayoutTestController::reset):
1968         * DumpRenderTree/chromium/LayoutTestController.h:
1969         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1970         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1971         * DumpRenderTree/chromium/TestShell.h:
1972         (TestShell::shouldDumpResourceResponseMIMETypes):
1973         * DumpRenderTree/chromium/WebViewHost.cpp:
1974         (WebViewHost::didReceiveResponse):
1975
1976 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1977
1978         Reviewed by Daniel Bates.
1979
1980         svn-apply tries to delete directories it shouldn't
1981         https://bugs.webkit.org/show_bug.cgi?id=45424
1982
1983         isDirectoryEmptyForRemoval had the wrong check. If an item in the
1984         directory is itself a directory, then the directory is definitely
1985         not empty.
1986
1987         * Scripts/svn-apply:
1988
1989 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
1990
1991         Fixing GTK and windows build failure.
1992
1993         AX: Support AccessibilityTextMarkers in DRT
1994         https://bugs.webkit.org/show_bug.cgi?id=44778
1995
1996         * DumpRenderTree/AccessibilityTextMarker.h:
1997         (AccessibilityTextMarker::platformTextMarker):
1998         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1999         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2000         (AccessibilityTextMarker::platformTextMarker):
2001         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2002
2003 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
2004
2005         Reviewed by David Kilzer.
2006
2007         AX: Support AccessibilityTextMarkers in DRT
2008         https://bugs.webkit.org/show_bug.cgi?id=44778
2009
2010         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
2011         that WebCore uses when vending information about its VisiblePositions through AX.
2012
2013         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
2014         methods for encapsulating and checking equality.
2015
2016         This will allow future bug fixes in the text marker system to be adequately tested.
2017
2018         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
2019         (toTextMarker):
2020         (isMarkerEqualCallback):
2021         (markerFinalize):
2022         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
2023         (AccessibilityTextMarker::getJSClass):
2024         (toTextMarkerRange):
2025         (isMarkerRangeEqualCallback):
2026         (markerRangeFinalize):
2027         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
2028         (AccessibilityTextMarkerRange::getJSClass):
2029         * DumpRenderTree/AccessibilityTextMarker.h: Added.
2030         (AccessibilityTextMarker::platformTextMarker):
2031         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2032         (AccessibilityTextMarker::AccessibilityTextMarker):
2033         (AccessibilityTextMarker::~AccessibilityTextMarker):
2034         (AccessibilityTextMarker::isEqual):
2035         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2036         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2037         (AccessibilityTextMarkerRange::isEqual):
2038         * DumpRenderTree/AccessibilityUIElement.cpp:
2039         (textMarkerRangeForElementCallback):
2040         (textMarkerRangeLengthCallback):
2041         (textMarkerRangeForMarkersCallback):
2042         (startTextMarkerForTextMarkerRangeCallback):
2043         (endTextMarkerForTextMarkerRangeCallback):
2044         (accessibilityElementForTextMarkerCallback):
2045         (AccessibilityUIElement::textMarkerRangeForElement):
2046         (AccessibilityUIElement::textMarkerRangeLength):
2047         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2048         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2049         (AccessibilityUIElement::accessibilityElementForTextMarker):
2050         (AccessibilityUIElement::getJSClass):
2051         * DumpRenderTree/AccessibilityUIElement.h:
2052         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2053         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
2054         (AccessibilityTextMarker::AccessibilityTextMarker):
2055         (AccessibilityTextMarker::~AccessibilityTextMarker):
2056         (AccessibilityTextMarker::isEqual):
2057         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2058         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2059         (AccessibilityTextMarkerRange::isEqual):
2060         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2061         (AccessibilityUIElement::textMarkerRangeForElement):
2062         (AccessibilityUIElement::textMarkerRangeLength):
2063         (AccessibilityUIElement::textMarkerRangeForMarkers):
2064         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2065         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2066         (AccessibilityUIElement::accessibilityElementForTextMarker):
2067         * DumpRenderTree/win/DumpRenderTree.vcproj:
2068
2069 2010-08-25  Tony Chang  <tony@chromium.org>
2070
2071         Reviewed by Ojan Vafai.
2072
2073         don't delete duplicates needed because of intermediate results
2074         https://bugs.webkit.org/show_bug.cgi?id=44653
2075
2076         Also, output the full path so we can pipe the output to rm.
2077
2078         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2079         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2080
2081 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
2082
2083         Reviewed by Andreas Kling.
2084
2085         [Qt] MiniBrowser does not starts properly
2086         https://bugs.webkit.org/show_bug.cgi?id=45459
2087
2088         Do not try set up the first window by calling newWindow on a
2089         newly created BrowserWindow since it creates a new object.
2090         * MiniBrowser/qt/BrowserWindow.cpp:
2091         (BrowserWindow::BrowserWindow):
2092         * MiniBrowser/qt/main.cpp:
2093         (main):
2094
2095 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
2096
2097         Reviewed by Xan Lopez.
2098
2099         [GTK] Get ImageDiff building on Win32
2100         https://bugs.webkit.org/show_bug.cgi?id=45353
2101
2102         * DumpRenderTree/gtk/ImageDiff.cpp:
2103         (main): Switch from using strtok to g_strsplit.
2104
2105 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
2106
2107         Reviewed by Andreas Kling.
2108
2109         [Qt] Modify load method of MiniBrowser's BrowserView class
2110         https://bugs.webkit.org/show_bug.cgi?id=45442
2111
2112         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
2113
2114         * MiniBrowser/qt/BrowserView.cpp:
2115         (BrowserView::load):
2116         * MiniBrowser/qt/BrowserView.h:
2117         * MiniBrowser/qt/BrowserWindow.cpp:
2118         (BrowserWindow::load):
2119
2120 2010-09-09  Tony Chang  <tony@chromium.org>
2121
2122         Reviewed by Ojan Vafai.
2123
2124         fix show_results in new-run-webkit-tests
2125         https://bugs.webkit.org/show_bug.cgi?id=45413
2126
2127         * Scripts/webkitpy/layout_tests/port/chromium.py:
2128
2129 2010-09-08  Victor Wang  <victorw@chromium.org>
2130
2131         Reviewed by Ojan Vafai.
2132
2133         [Chromium] Fix test results server to make sure
2134         it does not have corrupted data.
2135
2136         results.json file size coulbe be >1M and we split
2137         the data into multiple data store entries in this
2138         case. This patch fixes the issue that the data may
2139         be corrupted if data store error happens in the middle
2140         of saving multiple entries.
2141
2142         https://bugs.webkit.org/show_bug.cgi?id=45063
2143
2144         * TestResultServer/model/datastorefile.py:
2145
2146 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
2147
2148         Reviewed by Kenneth Rohde Christiansen.
2149
2150         Fix ignoring return value warning in case of gcc 4.4.4
2151         https://bugs.webkit.org/show_bug.cgi?id=45384
2152
2153         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2154         (testPostURLFile):
2155         If fwrite have written zero byte then the testPostURLFile function
2156         returns with false as tempFile can't be opened.
2157         * DumpRenderTree/qt/ImageDiff.cpp:
2158         (main):
2159         Put fwrite function into an if condition without body to avoid
2160         warning. It is safe because this function writes to the stdout.
2161
2162 2010-09-08  Satish Sampath  <satish@chromium.org>
2163
2164         Unreviewed, adding myself to committers list.
2165
2166         * Scripts/webkitpy/common/config/committers.py:
2167
2168 2010-09-08  Hans Wennborg  <hans@chromium.org>
2169
2170         Unreviewed.
2171
2172         Adding myself as a committer in committers.py.
2173
2174         * Scripts/webkitpy/common/config/committers.py:
2175
2176 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
2177
2178         Reviewed by Simon Hausmann.
2179
2180         [Qt] Refactor MiniBrowser 
2181         https://bugs.webkit.org/show_bug.cgi?id=45173
2182
2183         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
2184
2185         * MiniBrowser/qt/BrowserView.cpp: Added.
2186         (createNewPage):
2187         (BrowserView::BrowserView):
2188         (BrowserView::resizeEvent):
2189         (BrowserView::load):
2190         (BrowserView::view):
2191         * MiniBrowser/qt/BrowserView.h: Added.
2192         (BrowserView::~BrowserView):
2193         * MiniBrowser/qt/BrowserWindow.cpp:
2194         * MiniBrowser/qt/BrowserWindow.h:
2195         * MiniBrowser/qt/MiniBrowser.pro:
2196
2197 2010-09-08  Adam Barth  <abarth@webkit.org>
2198
2199         Rubber-stamped by Eric Seidel.
2200
2201         Rename DocLoader to CachedResourceLoader because that's what it does.
2202
2203         * Scripts/do-webcore-rename:
2204
2205 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
2206
2207         Reviewed by Ojan Vafai.
2208
2209         Enable incremental results.json generation for non-layout tests.
2210         https://bugs.webkit.org/show_bug.cgi?id=45315
2211
2212         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
2213
2214         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
2215
2216
2217 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
2218
2219         Unreviewed, build fix
2220
2221         Missed one test in mac_unittest.py in previous change; for some
2222         reason the method is listed twice. I will fix both for now, but will
2223         figure this out in a later, not-time-sensitive patch.
2224
2225         https://bugs.webkit.org/show_bug.cgi?id=45357
2226
2227         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2228
2229 2010-09-07  Kent Tamura  <tkent@chromium.org>
2230
2231         Reviewed by Tony Chang.
2232
2233         test-webkitpy: Fix load error of
2234         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
2235         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
2236
2237         * Scripts/webkitpy/layout_tests/port/server_process.py:
2238           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
2239           and we don't use server_process.py on Win32 Python. However
2240           unittest.py tries to load everything in a module.
2241
2242 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
2243
2244         Reviewed by Kent Tamura.
2245
2246         Fix regression introduced in previous change to new-run-webkit-tests
2247         (bug 45090) to not try to run unittests for the Mac implementation
2248         of the Port interface if we aren't running on a Mac.
2249
2250         Also fix the overrides implementation mock in the chromium unittests
2251         to fix the case where there are overrides checked in that cause
2252         problems.
2253
2254         https://bugs.webkit.org/show_bug.cgi?id=45357
2255
2256         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2257         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2258         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2259
2260 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
2261
2262         Reviewed by Ojan Vafai.
2263
2264         new-run-webkit-tests: still more unit tests
2265
2266         Clean up and remove unnecessary code. Biggest notable change is
2267         moving the chromium-specific imagediff code from port/base to
2268         port/chromium.
2269
2270         Add more unit tests for run_webkit_tests.py, port/base.py,
2271         port/factory.py, port/dryrun.py, and
2272         layout_package/dump_render_tree_thread.py
2273
2274         This covers almost all of the generic and test code paths except for
2275         a few error paths involving invalid or port-specific command line
2276         arguments, and the code path for uploading results files to the
2277         buildbots.
2278         
2279         https://bugs.webkit.org/show_bug.cgi?id=45090
2280
2281         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
2282         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
2283         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
2284         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
2285         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
2286         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2287         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
2288         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
2289         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2290         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
2291         * Scripts/webkitpy/layout_tests/port/base.py:
2292         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2293         * Scripts/webkitpy/layout_tests/port/chromium.py:
2294         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2295         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2296         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2297         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
2298         * Scripts/webkitpy/layout_tests/port/server_process.py:
2299         * Scripts/webkitpy/layout_tests/port/test.py:
2300         * Scripts/webkitpy/layout_tests/port/webkit.py:
2301         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2302         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2303
2304 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
2305
2306         Reviewed by Darin Adler.
2307
2308         Provide a way to trigger a <select multiple> onchange event on changes
2309         https://bugs.webkit.org/show_bug.cgi?id=45192
2310
2311         Adds a selector on ObjCController for testing
2312         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
2313         its different uses.
2314
2315         * DumpRenderTree/mac/ObjCController.m:
2316         (+[ObjCController isSelectorExcludedFromWebScript:]):
2317         (+[ObjCController webScriptNameForSelector:]):
2318         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
2319
2320 2010-09-07  James Robinson  <jamesr@chromium.org>
2321
2322         Rubber-stamped by Dimitri Glazkov.
2323
2324         Move myself from the committer to the reviewer list.
2325
2326         * Scripts/webkitpy/common/config/committers.py:
2327
2328 2010-09-07  Tony Chang  <tony@chromium.org>
2329
2330         Reviewed by Darin Fisher.
2331
2332         [chromium] Make a public flag for how DRT generates bitmaps on Linux
2333         https://bugs.webkit.org/show_bug.cgi?id=45133
2334
2335         * DumpRenderTree/chromium/TestShell.cpp:
2336         (TestShell::dumpImage):
2337
2338 2010-09-07  Kent Tamura  <tkent@chromium.org>
2339
2340         Reviewed by Dimitri Glazkov.
2341
2342         [DRT/Chromium] Implement --check-layout-test-sys-deps
2343         https://bugs.webkit.org/show_bug.cgi?id=45283
2344
2345         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2346         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
2347         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
2348         * DumpRenderTree/chromium/TestShellGtk.cpp:
2349         (checkLayoutTestSystemDependencies): Add an empty implementation.
2350         * DumpRenderTree/chromium/TestShellMac.mm:
2351         (checkLayoutTestSystemDependencies): Add an empty implementation.
2352         * DumpRenderTree/chromium/TestShellWin.cpp:
2353         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
2354
2355 2010-09-07  Jessie Berlin  <jberlin@apple.com>
2356
2357         Unreviewed. Mac build fix.
2358
2359         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2360         (didClearWindowObjectForFrame):
2361
2362 2010-09-07  Jessie Berlin  <jberlin@apple.com>
2363
2364         Reviewed by Darin Adler.
2365
2366         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
2367         https://bugs.webkit.org/show_bug.cgi?id=45217
2368         
2369         Make WebKitTestRunner work with this change.
2370
2371         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2372         (WTR::InjectedBundlePage::didClearWindowForFrame):
2373         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
2374         WebFrameLoaderClient.
2375         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2376
2377 2010-09-07  Philippe Normand  <pnormand@igalia.com>
2378
2379         Unreviewed, build fix.
2380
2381         webkit-patch command to find the ports covering a specific layout test
2382         https://bugs.webkit.org/show_bug.cgi?id=42832
2383
2384         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
2385         tests are present when building the expectations. This is needed
2386         for the unittests.
2387
2388 2010-09-06  Philippe Normand  <pnormand@igalia.com>
2389
2390         Reviewed by Adam Barth.
2391
2392         webkit-patch command to find the ports covering a specific layout test
2393         https://bugs.webkit.org/show_bug.cgi?id=42832
2394
2395         To use it: webkit-patch skipped-ports some/layout/test.html
2396
2397         * Scripts/webkitpy/layout_tests/port/base.py:
2398         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2399         * Scripts/webkitpy/layout_tests/port/chromium.py:
2400         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2401         * Scripts/webkitpy/layout_tests/port/factory.py:
2402         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2403         * Scripts/webkitpy/layout_tests/port/test.py:
2404         * Scripts/webkitpy/layout_tests/port/webkit.py:
2405         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2406         * Scripts/webkitpy/tool/commands/queries.py:
2407         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2408         * Scripts/webkitpy/tool/main.py:
2409         * Scripts/webkitpy/tool/mocktool.py:
2410
2411 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2412
2413         Reviewed by Eric Seidel.
2414
2415         [NRWT] Add temp directory to all running drivers.
2416         https://bugs.webkit.org/show_bug.cgi?id=45261
2417
2418         * Scripts/webkitpy/layout_tests/port/webkit.py:
2419
2420 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
2421
2422         Reviewed by Kent Tamura.
2423
2424         [Chromium/DRT] Empty out user stylesheet after each test run.
2425         https://bugs.webkit.org/show_bug.cgi?id=45282
2426
2427         This should significantly cut down on the number of the mysterious flaky tests
2428         whose diffs looked like the page was blown up to a very lage size. This
2429         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
2430         which set the base body font to 100px.
2431
2432         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
2433         the same thread failed.
2434
2435         * DumpRenderTree/chromium/TestShell.cpp:
2436         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
2437
2438 2010-09-06  Kent Tamura  <tkent@chromium.org>
2439
2440         Reviewed by Dimitri Glazkov.
2441
2442         [DRT/Chromium] Do not generate pixel results for text/plain resources
2443         https://bugs.webkit.org/show_bug.cgi?id=45253
2444
2445         * DumpRenderTree/chromium/TestShell.cpp:
2446         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
2447
2448 2010-09-06  Ojan Vafai  <ojan@chromium.org>
2449
2450         Reviewed by Kent Tamura.
2451
2452         print out correct error when a DRT thread dies in NRWT
2453         https://bugs.webkit.org/show_bug.cgi?id=45281
2454
2455         Not sure why, but with the parens, python 2.6.5 on Linux
2456         gives an error that raise takes 5 arguments and 0 were given.
2457         Didn't test other platforms or python versions, but putting it
2458         all on one line fixes it and correctly prints the exception
2459         from the DRT thread.
2460
2461         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2462
2463 2010-09-06  Eric Seidel  <eric@webkit.org>
2464
2465         Unreviewed, just adding some emails from lists.webkit.org.
2466
2467         Update committers.py to include emails from lists.webkit.org
2468         as found by the validate-committer-lists script.
2469
2470         * Scripts/webkitpy/common/config/committers.py:
2471
2472 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2473
2474         Reviewed by Xan Lopez.
2475
2476         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
2477         https://bugs.webkit.org/show_bug.cgi?id=45213
2478
2479         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2480         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
2481         have to surround the invocation with #ifdefs.
2482         (useLongRunningServerMode): Added.
2483         (runTestingServerLoop): Added.
2484         (initializeGlobalsFromCommandLineOptions): Added.
2485         (runTest): Removed ifdefs.
2486         (main): Use new helper functions.
2487
2488 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2489
2490         Reviewed by Xan Lopez.
2491
2492         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
2493         https://bugs.webkit.org/show_bug.cgi?id=45235
2494
2495         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
2496         methods of the EventSender.
2497
2498         * DumpRenderTree/gtk/EventSender.cpp:
2499         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
2500         with the current modifiers.
2501         (contextClickCallback): Always send no modifiers when preparing the mouse event.
2502         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
2503         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
2504         (mouseUpCallback): Ditto.
2505
2506 2010-09-05  Peter Kasting  <pkasting@google.com>
2507
2508         Reviewed by Adam Barth.
2509
2510         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
2511         https://bugs.webkit.org/show_bug.cgi?id=45155
2512
2513         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
2514         (EventSender::handleMouseWheel):
2515
2516 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
2517
2518         Reviewed by Joseph Pecoraro.
2519
2520         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
2521         https://bugs.webkit.org/show_bug.cgi?id=45179
2522
2523         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2524         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2525
2526 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
2527
2528         Rubber-stamped by Daniel Bates.
2529
2530         Adding myself as reviewer.
2531
2532         * Scripts/webkitpy/common/config/committers.py:
2533
2534 2010-09-04  Daniel Bates  <dbates@rim.com>
2535
2536         Reviewed by Martin Robinson.
2537
2538         Teach svn-apply/unapply about svn:mergeinfo
2539         https://bugs.webkit.org/show_bug.cgi?id=45236
2540
2541         Recognize the svn:mergeinfo property and ignore it for now.
2542
2543         Currently, svn-apply/unapply recognize only '+' and '-'
2544         property changes within a diff. We should add support
2545         to recognize "Merged" and "Reverse-merged" changes as well.
2546         Because svn:mergeinfo is metadata that is used only by SVN
2547         and tends to be error-prone and/or nuisance (*), we will ignore
2548         it for now.
2549         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
2550
2551         * Scripts/VCSUtils.pm:
2552           - Modified parseSvnProperty() to recognize "Merged" and
2553             "Reverse-merged" as the start of a property value.
2554         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2555           - Added the following unit tests:
2556             "simple: add svn:mergeinfo"
2557             "simple: delete svn:mergeinfo"
2558             "simple: modified svn:mergeinfo"
2559         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2560           - Added the following unit tests:
2561             "simple: add svn:mergeinfo"
2562             "simple: delete svn:mergeinfo"
2563             "simple: modified svn:mergeinfo"
2564             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
2565             "'Merged' change followed by 'Merged' change"
2566             "'Reverse-merged' change followed by 'Reverse-merged' change"
2567         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2568           - Added the following unit tests:
2569             "'Merged' change"
2570             "'Reverse-merged' change"
2571             "'Reverse-merged' change followed by 'Merge' change"
2572             "'Merged' change followed by 'Merge' change"
2573             "'Reverse-merged' change followed by 'Reverse-merged' change"
2574             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
2575
2576 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2577
2578         Reviewed by Kenneth Rohde Christiansen.
2579
2580         [EFL] Move test browser to WebKitTools directory
2581         https://bugs.webkit.org/show_bug.cgi?id=45212
2582
2583         Follow other ports like QT and GTK which moved the test browser to
2584         WebKitTools directory.
2585
2586         * CMakeListsEfl.txt: Added.
2587         * EWebLauncher/main.c: Added.
2588         (print_history):
2589         (zoom_level_set):
2590         (on_ecore_evas_resize):
2591         (title_set):
2592         (viewport_set):
2593         (on_title_changed):
2594         (on_progress):
2595         (on_load_finished):
2596         (on_toolbars_visible_set):
2597         (on_toolbars_visible_get):
2598         (on_statusbar_visible_set):
2599         (on_statusbar_visible_get):
2600         (on_scrollbars_visible_set):
2601         (on_scrollbars_visible_get):
2602         (on_menubar_visible_set):
2603         (on_menubar_visible_get):
2604         (on_tooltip_text_set):
2605         (on_inputmethod_changed):
2606         (on_viewport_changed):
2607         (on_mouse_down):
2608         (on_focus_out):
2609         (on_focus_in):
2610         (on_resized):
2611         (on_key_down):
2612         (on_browser_del):
2613         (on_closeWindow):
2614         (quit):
2615         (browserCreate):
2616         (browserDestroy):
2617         (closeWindow):
2618         (main_signal_exit):
2619         (findThemePath):
2620         (main):
2621
2622 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
2623
2624         Reviewed by Adam Roben.
2625
2626         Set project dependencies so that they build serially. This fixes
2627         issues when running run-webkit-tests if DRT is not built yet.
2628
2629         * DumpRenderTree/DumpRenderTree.sln:
2630
2631 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
2632
2633         Reviewed by Adam Barth.
2634
2635         Fix reading configuraiton in NWRT to work on Windows.
2636         https://bugs.webkit.org/show_bug.cgi?id=45180
2637
2638         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
2639             with the file otherwise.
2640
2641 2010-09-03  Chris Rogers  <crogers@google.com>
2642
2643         Unreviewed
2644
2645         Add myself to the committers list
2646         https://bugs.webkit.org/show_bug.cgi?id=45189
2647
2648         * Scripts/webkitpy/common/config/committers.py:
2649
2650 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
2651
2652         Reviewed by Yury Semikhatsky.
2653
2654         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
2655         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
2656         https://bugs.webkit.org/show_bug.cgi?id=45137
2657
2658         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
2659
2660 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2661
2662         Reviewed by Eric Seidel.
2663
2664         Add feature detection support to NRWT.
2665         https://bugs.webkit.org/show_bug.cgi?id=41842
2666
2667         * Scripts/webkitpy/layout_tests/port/base.py:
2668         * Scripts/webkitpy/layout_tests/port/qt.py:
2669         * Scripts/webkitpy/layout_tests/port/webkit.py:
2670         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
2671
2672 2010-09-03  Hironori Bono  <hbono@chromium.org>
2673
2674         Reviewed by Kent Tamura.
2675
2676         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
2677         and implements it for Mac.
2678         https://bugs.webkit.org/show_bug.cgi?id=41832
2679
2680         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
2681         and bind it so we can call it from JavaScript.
2682         (+[TextInputController isSelectorExcludedFromWebScript:]):
2683         (+[TextInputController webScriptNameForSelector:]):
2684         (-[TextInputController hasSpellingMarker:length:]):
2685
2686 2010-09-02  Eric Seidel  <eric@webkit.org>
2687
2688         Reviewed by Adam Barth.
2689
2690         Add a unit test for commit-queue retries
2691         https://bugs.webkit.org/show_bug.cgi?id=45162
2692
2693         I think commit-queue retries are not correctly avoiding
2694         build and test on retries.  So I started testing the code.
2695         Unfortunately this test did not find the bug.  But now
2696         that we have the test we might as well keep it.
2697         I also fixed a broken import in validate-committer-lists.
2698
2699         * Scripts/validate-committer-lists:
2700         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2701
2702 2010-09-02  Kent Tamura  <tkent@chromium.org>
2703
2704         Reviewed by Dimitri Glazkov.
2705
2706         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
2707         https://bugs.webkit.org/show_bug.cgi?id=45091
2708
2709         Task.{cpp,h} introduces a simpler version of Chromium
2710         base/task.h. It doesn't have TupleN and Method.
2711
2712         * DumpRenderTree/DumpRenderTree.gypi:
2713          Add Task.cpp and Task.h
2714         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2715         (DRTDevToolsAgent::DRTDevToolsAgent):
2716         (DRTDevToolsAgent::reset):
2717         (DRTDevToolsAgent::asyncCall):
2718         (DRTDevToolsAgent::frontendLoaded):
2719         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2720         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
2721         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2722         (DRTDevToolsClient::DRTDevToolsClient):
2723         (DRTDevToolsClient::~DRTDevToolsClient):
2724         (DRTDevToolsClient::reset):
2725         (DRTDevToolsClient::asyncCall):
2726         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2727         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
2728         * DumpRenderTree/chromium/EventSender.cpp:
2729         (EventSender::EventSender):
2730         (EventSender::reset):
2731         (EventSender::scheduleAsynchronousClick):
2732         * DumpRenderTree/chromium/EventSender.h:
2733         (EventSender::taskList): Added to use MethodTask<T>.
2734         * DumpRenderTree/chromium/LayoutTestController.cpp:
2735         (LayoutTestController::LayoutTestController):
2736         (LayoutTestController::WorkQueue::processWorkSoon):
2737         (LayoutTestController::waitUntilDone):
2738         (LayoutTestController::notifyDone):
2739         (LayoutTestController::reset):
2740         * DumpRenderTree/chromium/LayoutTestController.h:
2741         (LayoutTestController::taskList): Added to use MethodTask<T>.
2742         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
2743         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2744         (deferredDisplayDispatch):
2745         (NotificationPresenter::show):
2746         * DumpRenderTree/chromium/Task.cpp: Added.
2747         * DumpRenderTree/chromium/Task.h: Added.
2748
2749 2010-09-02  Steve Block  <steveblock@google.com>
2750
2751         Reviewed by Adam Barth.
2752
2753         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
2754         https://bugs.webkit.org/show_bug.cgi?id=43181
2755
2756         * DumpRenderTree/mac/DumpRenderTree.mm:
2757         (createWebViewAndOffscreenWindow):
2758         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2759         (LayoutTestController::setMockDeviceOrientation):
2760
2761 2010-08-31  Adam Roben  <aroben@apple.com>
2762
2763         Fix flashiness when resizing the browser window on Windows
2764
2765         Reviewed by Sam Weinig.
2766
2767         * MiniBrowser/win/BrowserWindow.cpp:
2768         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
2769         periodically fill the window with white.
2770
2771 2010-09-02  Peter Kasting  <pkasting@google.com>
2772
2773         Reviewed by Dimitri Glazkov.
2774
2775         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
2776         https://bugs.webkit.org/show_bug.cgi?id=45073
2777
2778         * DumpRenderTree/chromium/EventSender.cpp:
2779         (EventSender::EventSender):
2780         (EventSender::mouseScrollBy):
2781         (EventSender::continuousMouseScrollBy):
2782         (EventSender::sendCurrentTouchEvent):
2783         (EventSender::handleMouseWheel):
2784         * DumpRenderTree/chromium/EventSender.h:
2785         * DumpRenderTree/gtk/EventSender.cpp:
2786         (mouseScrollByCallback):
2787         (continuousMouseScrollByCallback):
2788
2789 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
2790
2791         Reviewed by Tony Chang.
2792
2793         Land a patched version of r66542 - change TestRunner to have an
2794         separate cleanup method and fix the ordering of cleanup between
2795         TestRunner and the printing module, and then wrap everything in a
2796         try/finally block to ensure reliable cleanup without needing to
2797         rely on stuff happening in the destructor of the TestRunner.
2798
2799         Also refactor run_webkit_tests.run() to be much smaller and cleaner
2800         by creating a bunch of helper methods and moving more stuff into
2801         the TestRunner class.
2802
2803         This fixes the crash at the end of the linux test run of
2804         new-run-webkit-tests (and undoes the rollout in 66547).
2805
2806         https://bugs.webkit.org/show_bug.cgi?id=44902
2807
2808         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
2809         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
2810         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
2811         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
2812         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2813         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2814         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2815         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2816         * Scripts/webkitpy/layout_tests/port/base.py:
2817         * Scripts/webkitpy/layout_tests/port/test.py:
2818         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2819         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2820
2821 2010-09-01  Mark Rowe  <mrowe@apple.com>
2822
2823         Reviewed by Adam Roben.
2824
2825         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
2826
2827         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2828
2829 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
2830
2831         Reviewed by Adam Roben.
2832
2833         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
2834         and WebKitTestRunner.
2835
2836         * BuildSlaveSupport/win/kill-old-processes:
2837
2838 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2839
2840         Reviewed by Antonio Gomes.
2841
2842         [Qt] Remove obsolete include path from DumpRenderTree.pro
2843
2844         * DumpRenderTree/qt/DumpRenderTree.pro:
2845
2846 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2847
2848         Reviewed by Laszlo Gombos.
2849
2850         [Qt] QWebPage::allowGeolocationRequest should be async API
2851         https://bugs.webkit.org/show_bug.cgi?id=41364
2852
2853         Implements new async API for geolocation permission similar to
2854         Notification. WebPage maintains list of geolocation permission request
2855         QtWebkit and set's when LayoutTestController gets the access from test JS
2856
2857         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2858         (WebCore::WebPage::WebPage):
2859         (WebCore::WebPage::resetSettings):
2860         (WebCore::WebPage::requestPermission):
2861         (WebCore::WebPage::cancelPermission):
2862         (WebCore::WebPage::permissionSet):
2863         (WebCore::DumpRenderTree::DumpRenderTree):
2864         (WebCore::DumpRenderTree::processLine):
2865         (WebCore::DumpRenderTree::geolocationPermissionSet):
2866         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2867         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2868         (LayoutTestController::reset):
2869         (LayoutTestController::setGeolocationPermission):
2870         (LayoutTestController::setGeolocationPermissionCommon):
2871         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2872
2873 2010-09-01  Andras Becsi  <abecsi@webkit.org>
2874
2875         Reviewed by Antti Koivisto.
2876
2877         [Qt] Auto-generate WebKit2 forwarding headers
2878         https://bugs.webkit.org/show_bug.cgi?id=44692
2879
2880         * MiniBrowser/qt/BrowserWindow.h: use source style includes
2881         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
2882         * Scripts/enumerate-included-framework-headers: Removed.
2883
2884 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2885
2886         Reviewed by Adam Barth.
2887
2888         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
2889         https://bugs.webkit.org/show_bug.cgi?id=44789
2890
2891         * Scripts/webkitpy/common/net/bugzilla.py:
2892
2893 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
2894
2895         Reviewed by Adam Barth.
2896
2897         ews: Add support for EFL-EWS
2898         https://bugs.webkit.org/show_bug.cgi?id=44982
2899
2900         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
2901         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
2902         and add it to the ports dict.
2903         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
2904         EflEWS class.
2905         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
2906         a test case for the EFL EWS.
2907
2908 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
2909
2910         Reviewed by Sam Weinig.
2911
2912         https://bugs.webkit.org/show_bug.cgi?id=42195
2913         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
2914
2915         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2916         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
2917         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2918         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
2919         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
2920
2921         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2922         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
2923         which forgets its override.
2924
2925 2010-08-31  Sam Weinig  <sam@webkit.org>
2926
2927         Reviewed by Gavin Barraclough.
2928
2929         WebKitTestRunner needs layoutTestController.addUserStyleSheet
2930         https://bugs.webkit.org/show_bug.cgi?id=42680
2931
2932         WebKitTestRunner needs layoutTestController.addUserScript
2933         https://bugs.webkit.org/show_bug.cgi?id=42681
2934
2935         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2936         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2937         (WTR::InjectedBundle::beginTesting):
2938         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2939         (WTR::LayoutTestController::addUserScript):
2940         (WTR::LayoutTestController::addUserStyleSheet):
2941         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2942
2943 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2944
2945         Unreviewed, rolling out r66542.
2946         http://trac.webkit.org/changeset/66542
2947         https://bugs.webkit.org/show_bug.cgi?id=44902
2948
2949         r66542 - the weird logging dependencies in Python stuck again ...
2950
2951         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
2952         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
2953         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
2954         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
2955         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2956         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2957         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2958         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2959         * Scripts/webkitpy/layout_tests/port/base.py:
2960         * Scripts/webkitpy/layout_tests/port/test.py:
2961         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2962         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2963
2964 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
2965
2966         Reviewed by Tony Chang.
2967
2968         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
2969
2970         * DumpRenderTree/chromium/LayoutTestController.cpp:
2971         (LayoutTestController::LayoutTestController):
2972         (LayoutTestController::markerTextForListItem):
2973         * DumpRenderTree/chromium/LayoutTestController.h:
2974
2975 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2976
2977         Reviewed by Ojan Vafai.
2978
2979         new-run-webkit-tests: add more unit tests
2980
2981         Add more unit tests for new-run-webkit-tests; we now cover all but
2982         the most obscure code paths in the generic code. We still need to
2983         add coverage for the http server and web socket paths, and add better
2984         coverage of the platform-specific logic. Note that the rebaselining
2985         tool is still not well tested.
2986
2987         Also clean up some of the configuration logic for the printing
2988         module and the way it interacts with the Python logging module; that
2989         is a crufty interface, to be certain.
2990         
2991         https://bugs.webkit.org/show_bug.cgi?id=44902
2992
2993         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
2994         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
2995         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
2996         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
2997         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2998         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2999         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3000         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3001         * Scripts/webkitpy/layout_tests/port/base.py:
3002         * Scripts/webkitpy/layout_tests/port/test.py:
3003         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3004         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3005
3006 2010-08-31  Darin Adler  <darin@apple.com>
3007
3008         Reviewed by Anders Carlsson.
3009
3010         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
3011         in a debug build when built with certain compilers.
3012
3013 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
3014
3015         Reviewed by Gustavo Noronha Silva.
3016
3017         [GTK] Isolate all GTK+ typedefs into one file
3018         https://bugs.webkit.org/show_bug.cgi?id=44900
3019
3020         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
3021
3022 2010-08-31  Eric Seidel  <eric@webkit.org>
3023
3024         Reviewed by Adam Barth.
3025
3026         Show more status on queue status pages
3027         https://bugs.webkit.org/show_bug.cgi?id=44938
3028
3029         I upped the number of status lines from 6 to 15 --
3030         this has been bugging me for a while...
3031
3032         I also disabled showing the chromium-win EWS queue
3033         since it's been down for almost 5 months now.
3034
3035         * QueueStatusServer/handlers/dashboard.py:
3036         * QueueStatusServer/handlers/queuestatus.py:
3037         * QueueStatusServer/model/queues.py:
3038
3039 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
3040
3041         Reviewed by Antonio Gomes.
3042
3043         [Qt] Read command line arguments and open them as URLs in new windows
3044         https://bugs.webkit.org/show_bug.cgi?id=44944
3045
3046         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
3047
3048         * MiniBrowser/qt/main.cpp:
3049         (main):
3050
3051 2010-08-31  Adrian Perez  <aperez@igalia.com>
3052
3053         Reviewed by Martin Robinson.
3054
3055         Support scripts to run Buildbot slaves under daemontools (gtk related)
3056         https://bugs.webkit.org/show_bug.cgi?id=40053
3057
3058         * BuildSlaveSupport/gtk: Added.
3059         * BuildSlaveSupport/gtk/README: Added.
3060         * BuildSlaveSupport/gtk/buildbot: Added.
3061         * BuildSlaveSupport/gtk/buildbot/log: Added.
3062         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
3063         * BuildSlaveSupport/gtk/buildbot/run: Added.
3064         * BuildSlaveSupport/gtk/crashmon: Added.
3065         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
3066         * BuildSlaveSupport/gtk/crashmon/log: Added.
3067         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
3068         * BuildSlaveSupport/gtk/crashmon/run: Added.
3069         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
3070         * BuildSlaveSupport/gtk/pulseaudio: Added.
3071         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
3072         * BuildSlaveSupport/gtk/xvfb: Added.
3073         * BuildSlaveSupport/gtk/xvfb/log: Added.
3074         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
3075         * BuildSlaveSupport/gtk/xvfb/run: Added.
3076
3077 2010-08-27  John Gregg  <johnnyg@google.com>
3078
3079         Reviewed by David Levin.
3080
3081         Notifications should support a click event.
3082         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
3083         can be simulated during a layout test.  Requires storing a list of active
3084         notifications so that they can be referred to later for clicking.
3085         https://bugs.webkit.org/show_bug.cgi?id=44800
3086
3087         * DumpRenderTree/chromium/LayoutTestController.cpp:
3088         (LayoutTestController::LayoutTestController):
3089         (LayoutTestController::simulateDesktopNotificationClick):
3090         * DumpRenderTree/chromium/LayoutTestController.h:
3091         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3092         (NotificationPresenter::simulateClick):
3093         (NotificationPresenter::show):
3094         (NotificationPresenter::cancel):
3095         (NotificationPresenter::objectDestroyed):
3096         * DumpRenderTree/chromium/NotificationPresenter.h:
3097
3098 2010-08-30  Alice Liu  <alice.liu@apple.com>
3099
3100         Reviewed by Darin Adler.
3101
3102         Add missing parts of didFinishDocumentLoadForFrame
3103         https://bugs.webkit.org/show_bug.cgi?id=44913
3104
3105         * MiniBrowser/mac/BrowserWindowController.m:
3106         (didFinishDocumentLoadForFrame): Added
3107         (-[BrowserWindowController awakeFromNib]): Updated struct
3108         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3109         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
3110         * WebKitTestRunner/TestController.cpp:
3111         (WTR::TestController::initialize): Updated struct
3112
3113 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
3114
3115         Unreviewed: Add myself to the list of Committers.
3116
3117         * Scripts/webkitpy/common/config/committers.py:
3118
3119 2010-08-30  Kent Tamura  <tkent@chromium.org>
3120
3121         Reviewed by Adam Barth.
3122
3123         Fix fast/notifications/notifications-display-close-events.html failure
3124         https://bugs.webkit.org/show_bug.cgi?id=44585
3125
3126         Apply http://crrev.com/48893. We should dispatch display events
3127         asynchronously.
3128
3129         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3130         (deferredDisplayDispatch):
3131         (NotificationPresenter::show):
3132
3133 2010-08-30  Robert Hogan  <robert@webkit.org>
3134
3135         Reviewed by Simon Hausmann.
3136
3137         allow ports with windowed plugins to support windowless plugin tests
3138
3139         https://bugs.webkit.org/show_bug.cgi?id=40730
3140
3141         Ports that implement plugins windowed by default need to have a way of
3142         supporting plugin tests that assume the plugin is windowless. Add this
3143         feature to the tests and support it in the webkit test plugin. Also
3144         add mouse and keyboard event logging to the webkit-test plugin on Unix.
3145
3146         Unskip the following tests on Qt:
3147
3148         plugins/mouse-events.html
3149         plugins/keyboard-events.html
3150         plugins/mouse-events-fixedpos.html
3151
3152         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3153         (pluginSetProperty):
3154         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3155         (NPP_New):
3156         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3157         (webkit_test_plugin_handle_event):
3158
3159 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
3160
3161         [wx] Build fix after addition of fileapi directory in WebCore.
3162
3163         * wx/build/settings.py:
3164
3165 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
3166
3167         Reviewed by Xan Lopez.
3168
3169         Fixed compilation error, now that we have included the
3170         GtkVersioning.h we have to remove some version dependent code from
3171         EventSender.
3172
3173         * DumpRenderTree/gtk/EventSender.cpp:
3174
3175 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
3176
3177         Reviewed by Martin Robinson.
3178
3179         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
3180         are deprecated
3181         https://bugs.webkit.org/show_bug.cgi?id=44787
3182
3183         We have replaced GtkVersioning.cpp with GtkVersioning.c and
3184         created a function (getDefaultGDKPointerDevice) to get the pointer
3185         of the window with the new APIs. We added that function to DRT and
3186         copyandpaste unit test.
3187
3188         * DumpRenderTree/gtk/EventSender.cpp:
3189         (prepareMouseButtonEvent):
3190         (mouseMoveToCallback):
3191         (keyDownCallback):
3192         * GNUmakefile.am:
3193
3194 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
3195
3196         Reviewed by Kenneth Rohde Christiansen.
3197
3198         [Qt] Add new window menu to MiniBrowser
3199
3200         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
3201
3202         * MiniBrowser/qt/BrowserWindow.cpp:
3203         (BrowserWindow::BrowserWindow):
3204         (BrowserWindow::newWindow):
3205         * MiniBrowser/qt/BrowserWindow.h:
3206         * MiniBrowser/qt/main.cpp:
3207         (main):
3208
3209 2010-08-29  James Robinson  <jamesr@chromium.org>
3210
3211         Reviewed by David Levin.
3212
3213         Make failing the download step fail the build
3214         https://bugs.webkit.org/show_bug.cgi?id=44298
3215
3216         If the download step fails on a test bot, this ensures that
3217         the build goes red instead of only the download step going red
3218         and the overall build staying green.
3219
3220         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3221
3222 2010-08-29  Kent Tamura  <tkent@chromium.org>
3223
3224         Reviewed by Dimitri Glazkov.
3225
3226         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
3227         https://bugs.webkit.org/show_bug.cgi?id=44847
3228
3229         * DumpRenderTree/chromium/EventSender.cpp:
3230          Use webkit_support::VKEY_* instead of base::VKEY_*.
3231
3232 2010-08-29  Darin Adler  <darin@apple.com>
3233
3234         https://bugs.webkit.org/show_bug.cgi?id=40589
3235
3236         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
3237         function names.
3238
3239 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
3240
3241         Reviewed by Darin Adler.
3242
3243         [iExploder] Add new CSS Properties and HTML Attributes
3244         https://bugs.webkit.org/show_bug.cgi?id=44746
3245
3246         Updated the files with the update-iexploder-cssproperties script
3247         and manually readded the -webkit-binding CSS Property to the list.
3248
3249         * iExploder/htdocs/cssproperties.in:
3250         * iExploder/htdocs/htmlattrs.in:
3251         * iExploder/htdocs/htmltags.in:
3252
3253 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
3254
3255         Reviewed by Darin Adler.
3256
3257         Fix Coverage build after the addition of ANGLE
3258         https://bugs.webkit.org/show_bug.cgi?id=44744
3259
3260         ANGLE is using libtool to build a static library and the version of
3261         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
3262         parameters. The easiest way to handle this is to not build ANGLE with
3263         coverage information.
3264
3265         This is achieved by applying the XCode options for each project
3266         separately and exclude ANGLE.
3267
3268         * Scripts/build-webkit: Remove -framework AppKit due link errors.
3269         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
3270
3271 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
3272
3273         [wx] Build fix after directory addition.
3274
3275         * wx/build/settings.py:
3276
3277 2010-08-28  Chris Guillory   <chris.guillory@google.com>
3278
3279         Reviewed by Chris Fleizach.
3280
3281         Add AX notification for childrenChanged
3282         https://bugs.webkit.org/show_bug.cgi?id=44472
3283
3284         * DumpRenderTree/chromium/AccessibilityController.cpp:
3285         (AccessibilityController::AccessibilityController):
3286         (AccessibilityController::reset):
3287         (AccessibilityController::getRootElement):
3288         (AccessibilityController::dumpAccessibilityNotifications):
3289         * DumpRenderTree/chromium/AccessibilityController.h:
3290         (AccessibilityController::shouldDumpAccessibilityNotifications):
3291         * DumpRenderTree/chromium/WebViewHost.cpp:
3292         (WebViewHost::didChangeAccessibilityObjectChildren):
3293         * DumpRenderTree/chromium/WebViewHost.h:
3294
3295 2010-08-28  Eric Seidel  <eric@webkit.org>
3296
3297         Reviewed by Adam Barth.
3298
3299         Update commit-queue failure message
3300         https://bugs.webkit.org/show_bug.cgi?id=44798
3301
3302         The commit-queue auto-restarts itself and has for a very long time.
3303         No need for people to email me to request a restart anymore.
3304
3305         * Scripts/webkitpy/common/net/bugzilla.py:
3306         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3307         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3308
3309 2010-07-27  Jer Noble  <jer.noble@apple.com>
3310
3311         Reviewed by Eric Carlson.
3312
3313         Add JavaScript API to allow a page to go fullscreen.
3314         rdar://problem/6867795
3315         
3316         Added basic full screen support to DumpRenderTree: when a webView requests
3317         that DumpRenderTree go "full screen", just call the provided callback listener object's
3318         will/did Enter/Exit full screen methods.  Also, register a new user default which 
3319         enables full screen support.
3320
3321         * DumpRenderTree/mac/DumpRenderTree.mm:
3322         (resetDefaultsToConsistentValues):
3323         * DumpRenderTree/mac/UIDelegate.mm:
3324         (-[UIDelegate webView:supportsFullscreenForElement:]):
3325         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
3326         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
3327
3328 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
3329
3330         Unreviewed. Add myself to the committers list.
3331
3332         * Scripts/webkitpy/common/config/committers.py:
3333
3334 2010-08-27  Kent Tamura  <tkent@chromium.org>
3335
3336         Reviewed by Pavel Feldman.
3337
3338         [DRT/Chromium] Fix inspector test failures
3339         https://bugs.webkit.org/show_bug.cgi?id=44748
3340
3341         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3342         (DRTDevToolsAgent::createClientMessageLoop):
3343           Returns a valid WebKitClientMessageLoop instance
3344         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3345
3346 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
3347
3348         Add Windows WebKit2 Tester to buildbot
3349         <rdar://problem/7887703>
3350
3351         Reviewed by Dan Bernstein.
3352
3353         * BuildSlaveSupport/build.webkit.org-config/config.json:
3354
3355 2010-08-26  Philippe Normand  <pnormand@igalia.com>
3356
3357         Reviewed by Martin Robinson.
3358
3359         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3360         https://bugs.webkit.org/show_bug.cgi?id=42152
3361
3362         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3363         (LoadHTMLStringItem::invoke): Implementation using
3364         webkit_web_frame_load_string().
3365
3366 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
3367
3368         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
3369         WebKitTestRunner (44331)
3370
3371         Reviewed by Darin Adler.
3372
3373         * WebKitTestRunner/TestController.cpp:
3374         (WTR::TestController::initialize):
3375         The hang occurs when WebKitTestRunner begins launching the WebKit2
3376         web process then exits before it finishes launching. Work around this by
3377         looking for the --print-supported-features argument and exiting without
3378         creating the web process.
3379
3380 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
3381
3382         Reviewed by Tony Chang.
3383
3384         new-run-webkit-tests: add rebaselining tests for test_expectations
3385         
3386         This patch adds more unit tests for the rebaselining code in the
3387         test_expectations module. It doesn't add any tests for
3388         rebaseline_chromium_webkit_tests itself; that will come some other
3389         time.
3390
3391         https://bugs.webkit.org/show_bug.cgi?id=44648
3392
3393         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3394         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3395
3396 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3397
3398         Reviewed by Martin Robinson.
3399
3400         [GTK] Add HTTP caching support
3401         https://bugs.webkit.org/show_bug.cgi?id=44261
3402
3403         Ignore new soup API that we decided to merge into the soup backend
3404         while it is being cooked. It follows the libsoup style, and will
3405         be removed from WebKit as soon as it is merged into libsoup.
3406
3407         * Scripts/webkitpy/style/checker.py:
3408
3409 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3410
3411         Reviewed by Kenneth Rohde Christiansen.
3412
3413         [Qt] DumpRenderTree runs only one test from command mode
3414         https://bugs.webkit.org/show_bug.cgi?id=44012
3415
3416         Enables support to run multiple test files and single
3417         folder containing html files in stand alone mode
3418
3419         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3420         (WebCore::DumpRenderTree::DumpRenderTree):
3421         (WebCore::DumpRenderTree::processArgsLine):
3422         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3423         (WebCore::DumpRenderTree::processLine):
3424         (WebCore::DumpRenderTree::dump):
3425         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3426         (WebCore::DumpRenderTree::setStandAloneMode):
3427         (WebCore::DumpRenderTree::isStandAloneMode):
3428         * DumpRenderTree/qt/main.cpp:
3429         (main):
3430
3431 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
3432
3433         Updating webkitpy test expectations.
3434
3435         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3436
3437 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3438
3439         Reviewed by Eric Seidel.
3440
3441         fix the always squash git config
3442         https://bugs.webkit.org/show_bug.cgi?id=44651
3443
3444         Fix help text and apparently underscores are not allowed
3445         in git config keys.
3446
3447         * Scripts/webkitpy/common/checkout/scm.py:
3448         * Scripts/webkitpy/tool/steps/commit.py:
3449
3450 2010-08-25  Darin Adler  <darin@apple.com>
3451
3452         Reviewed by John Sullivan.
3453
3454         * Scripts/commit-log-editor: Fix perl warning for people who have no
3455         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
3456
3457 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3458
3459         Reviewed by Eric Seidel.
3460
3461         stop blocking commits when the bots are red
3462         https://bugs.webkit.org/show_bug.cgi?id=44644
3463
3464         This check currently is just annoying. It doesn't actually
3465         help keep the tree green. We can always add it back later
3466         if we decide the tree is generally more green.
3467
3468         * Scripts/webkitpy/tool/commands/download_unittest.py:
3469         * Scripts/webkitpy/tool/mocktool.py:
3470         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
3471
3472 2010-08-25  Eric Seidel  <eric@webkit.org>
3473
3474         Reviewed by Simon Fraser.
3475
3476         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
3477         https://bugs.webkit.org/show_bug.cgi?id=38912
3478
3479         I know of nothing else to do but skip all media tests for the cq.
3480
3481         * Scripts/webkitpy/tool/steps/runtests.py:
3482
3483 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3484
3485         Reviewed by Ojan Vafai.
3486
3487         new-run-webkit-tests: add more unit tests for test_expectations
3488         This adds unit tests to cover (almost?) all of the non-rebaselining
3489         functionality.
3490
3491         https://bugs.webkit.org/show_bug.cgi?id=44579
3492
3493         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3494         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3495
3496 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3497
3498         Reviewed by Ojan Vafai.
3499
3500         new-run-webkit-tests: add more unit tests
3501
3502         This change adds more unit tests for the image_diff, test_failures,
3503         and test_files modules, bringing them to 100% coverage (and adds a
3504         couple tests to run_webkit_tests while we're at it).
3505
3506         This test also turns on the "dryrun" port for testing when run on
3507         the mac, increasing coverage in a few other places.
3508
3509         https://bugs.webkit.org/show_bug.cgi?id=44578
3510
3511         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
3512         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
3513         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
3514         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
3515         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
3516         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
3517         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
3518         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
3519         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3520         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
3521         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
3522         * Scripts/webkitpy/layout_tests/port/test.py:
3523         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3524
3525 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3526
3527         Reviewed by Ojan Vafai.
3528
3529         new-run-webkit-tests: add more unit tests for layout_package/printing.py
3530
3531         This change adds more unit tests to get the test coverage to 100%
3532         for the printing module. This code is actually pretty crufty and
3533         has some layering violations that need to be cleaned up but I'll
3534         save that for another CL after we get all the unit tests written and
3535         we fix the multithreading issues. At least now we'll be able to tell
3536         if we break things.
3537
3538         https://bugs.webkit.org/show_bug.cgi?id=44576
3539
3540         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3541         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3542
3543 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3544
3545         Reviewed by Adam Barth.
3546
3547         new-run-webkit-tests should respect set-webkit-configuration
3548         https://bugs.webkit.org/show_bug.cgi?id=44633
3549
3550         Moves the getting of the configuration into the base Port so that
3551         chromium ports use it as well. In the downstream chromium port,
3552         this should still just return Release.
3553
3554         * Scripts/webkitpy/layout_tests/port/base.py:
3555         * Scripts/webkitpy/layout_tests/port/webkit.py:
3556
3557 2010-08-25  Tony Chang  <tony@chromium.org>
3558
3559         Not reviewed, changing svn props for a script.
3560
3561         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
3562
3563 2010-08-25  Adam Barth  <abarth@webkit.org>
3564
3565         Reviewed by Eric Seidel.
3566
3567         Remove WebKit2 from core builders
3568         https://bugs.webkit.org/show_bug.cgi?id=44625
3569
3570         This builder was added to the core builders by accident.  It doesn't
3571         appear to be green enough to be a core builder yet.
3572
3573         * Scripts/webkitpy/common/net/buildbot.py:
3574         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3575
3576 2010-08-19  Adam Roben  <aroben@apple.com>
3577
3578         Test that NP_Initialize and NP_GetEntryPoints are called in the
3579         correct order
3580
3581         The order differs between Mac and Windows (see r38858).
3582
3583         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
3584         NP_Initialize when loading QuickTime when running
3585         plugins/embed-attributes-setting.html in WebKit2 on Windows
3586
3587         Reviewed by John Sullivan.
3588
3589         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
3590         a boolean to record whether NP_GetEntryPoints has been called.
3591         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
3592         called yet. This matches Flash and QuickTime's behavior.
3593         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
3594         yet. This matches Silverlight's behavior.
3595
3596 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
3597
3598         Reviewed by Gustavo Noronha Silva.
3599
3600         Cairo and EFL port shouldn't depend on glib.
3601         https://bugs.webkit.org/show_bug.cgi?id=44354
3602
3603         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
3604         adoptPlatformRef.
3605
3606         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3607         (AccessibilityUIElement::isSelected):
3608
3609 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3610
3611         Fix order of Timothy's email address. The script, and
3612         other tools all assume that the first email is the bugzilla address.
3613
3614         * Scripts/webkitpy/common/config/committers.py:
3615
3616 2010-08-24  Kent Tamura  <tkent@chromium.org>
3617
3618         Reviewed by Pavel Feldman.
3619
3620         [DRT/Chromium] Fix 26 inspector test crashes
3621         https://bugs.webkit.org/show_bug.cgi?id=44580
3622
3623         - DRTDevToolsAgent has a reference to the main WebView. So we
3624           should not clear it in closeDevTools() and should clear it in
3625           ~TestShell().
3626         - DRTDevToolsClient has a reference to a DevTools WebView and no
3627           way to update it. So we should delete DRTDevToolsClient instances
3628           in closeDevTools().
3629
3630         * DumpRenderTree/chromium/TestShell.cpp:
3631         (TestShell::~TestShell):
3632         (TestShell::closeDevTools):
3633
3634 2010-08-24  Eric Seidel  <eric@webkit.org>
3635
3636         Reviewed by Adam Barth.
3637
3638         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
3639         https://bugs.webkit.org/show_bug.cgi?id=44584
3640
3641         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3642
3643 2010-08-24  Eric Seidel  <eric@webkit.org>
3644
3645         Reviewed by Adam Barth.
3646
3647         commit-queue and EWS bots should report all failures
3648         https://bugs.webkit.org/show_bug.cgi?id=41820
3649
3650         Right now commit-queue/EWS only report failures when the
3651         patch under testing fails.  We should report all failures
3652         to the status server so that we can diagnose when the bots
3653         are wedged w/o needing to log into the machines.
3654
3655         I also reduced the amount of data we upload since we've seen
3656         timeouts during status upload.
3657
3658         * Scripts/webkitpy/common/system/executive.py:
3659         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3660         * Scripts/webkitpy/tool/commands/queues.py:
3661         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3662
3663 2010-08-24  Eric Seidel  <eric@webkit.org>
3664
3665         Reviewed by Adam Barth.
3666
3667         Remove HTML5 parser testing infrastructure now that we don't need it
3668         https://bugs.webkit.org/show_bug.cgi?id=44581