e714ed6b8ff9abb886cfff0b6c6be8f4f0cbbfdb
[WebKit.git] / WebKitTools / ChangeLog
1 2010-12-02  Sam Weinig  <sam@webkit.org>
2
3         Fix Qt build.
4
5         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
6         (WTR::PlatformWebView::PlatformWebView):
7
8 2010-12-02  Sam Weinig  <sam@webkit.org>
9
10         Reviewed by Anders Carlsson.
11
12         WebKit2 Preferences should be held off the PageGroup, not the Context
13         https://bugs.webkit.org/show_bug.cgi?id=50414
14
15         Update for API changes.
16
17         * WebKitTestRunner/PlatformWebView.h:
18         * WebKitTestRunner/TestController.cpp:
19         (WTR::createOtherPage):
20         (WTR::TestController::initialize):
21         (WTR::TestController::resetStateToConsistentValues):
22         * WebKitTestRunner/TestController.h:
23         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
24         (WTR::PlatformWebView::PlatformWebView):
25         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
26         (WTR::PlatformWebView::PlatformWebView):
27
28 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
29
30         Reviewed by Tony Chang.
31
32         This change is a bunch of cleanup / refactoring of the file
33         below. It moves a bunch of free functions to methods on the
34         TestShellThread class, and restructures other methods to be
35         closer to the structure we'll need for the multiprocessing
36         rewrite.
37
38         It also makes the logic of --run-singly a *lot* easier to follow
39         by nestling all of the separate-thread logic into a single
40         routine.
41
42         There should be no semantic changes in this patch, just cleanup.
43
44         https://bugs.webkit.org/show_bug.cgi?id=50367
45
46         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
47
48 2010-12-02  Tony Chang  <tony@chromium.org>
49
50         Unreviewed, rolling out r73164.
51         http://trac.webkit.org/changeset/73164
52         https://bugs.webkit.org/show_bug.cgi?id=50359
53
54         broke debugger tests on win
55
56         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
57
58 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
59
60         Reviewed by Tony Chang.
61
62         Rebaseline server: add updating of baselines
63         https://bugs.webkit.org/show_bug.cgi?id=50305
64         
65         Implements updating of baselines, where we copy -actual.* files over
66         the current -expected.* files. To do this, we need a
67         _get_actual_result_files method to get test results files and a
68         _rebaseline_test method to actually do the file copy and SCM operation.
69         _rebaseline_test logs output into a buffer, this is useful for both
70         showing result in the UI and for unit tests.
71         
72         To make passing around of the various test environment properties
73         (results directory, filesystem, SCM, etc) easier, add a TestConfig
74         class for them.
75         
76         Moving of existing baselines is not implemented yet, this patch is big
77         enough as it is.
78
79         * Scripts/webkitpy/common/system/filesystem.py:
80         * Scripts/webkitpy/common/system/filesystem_mock.py:
81         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
82         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
83         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
84         * Scripts/webkitpy/tool/mocktool.py:
85
86 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
87
88         Unreviewed build fix after vcproj updates.
89
90         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
91         that WIN_CAIRO is defined for this build.
92         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
93         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
94         (these were previously 'Debug_Cairo' and 'Release_Cairo'
95
96 2010-12-02  Sam Weinig  <sam@webkit.org>
97
98         Reviewed by Anders Carlsson.
99
100         WebKit2 needs API to turn on popup blocking
101         https://bugs.webkit.org/show_bug.cgi?id=50407
102
103         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
104         (TestWebKitAPI::TEST):
105         * WebKitTestRunner/TestController.cpp:
106         (WTR::TestController::resetStateToConsistentValues):
107
108 2010-12-01  Tony Chang  <tony@chromium.org>
109
110         Reviewed by Ojan Vafai.
111
112         [chromium] force NRWT to use DRT
113         https://bugs.webkit.org/show_bug.cgi?id=50359
114
115         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
116
117 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
118
119         Reviewed by Xan Lopez.
120
121         [GTK] DumpRenderTree has two copies of JavaScriptCore
122         https://bugs.webkit.org/show_bug.cgi?id=49877
123
124         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
125         LDADD list for DumpRenderTree.
126
127 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
128
129         Unreviewed: Added myself to list of Committers.
130
131         * Scripts/webkitpy/common/config/committers.py:
132
133 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
134
135         Reviewed by Adam Barth.
136
137         build-webkit --chromium always updates DEPS and re-generates project files
138         https://bugs.webkit.org/show_bug.cgi?id=50340
139         
140         Make build-webkit --chromium invoke update-webkit-chromium only when
141         --update-chromium is passed in, so that we don't add 20 seconds to all
142         builds.
143         
144         Making all invocations update was added with r61883, with the goal of
145         making EWS bots always update. The bots will switch to using this flag
146         (as will all other webkit-patch build steps) so nothing should change
147         for them.
148
149         * Scripts/webkitdirs.pm:
150         * Scripts/webkitpy/common/config/ports.py:
151         * Scripts/webkitpy/common/config/ports_unittest.py:
152
153 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
154
155         Reviewed by Tony Chang.
156
157         new-run-webkit-tests: add a --dry-run / -n flag
158         https://bugs.webkit.org/show_bug.cgi?id=50045
159
160         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
161         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
162
163 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
164
165         Reviewed by Adam Roben.
166
167         WinCairo build should not use link-time code generation (LTCG)
168         https://bugs.webkit.org/show_bug.cgi?id=50353
169
170         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
171         * DumpRenderTree/win/DumpRenderTree.vcproj:
172         * DumpRenderTree/win/ImageDiff.vcproj:
173         * FindSafari/FindSafari.vcproj:
174         * MiniBrowser/MiniBrowser.vcproj:
175         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
176         * WebKitAPITest/WebKitAPITest.vcproj:
177         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
178         * WebKitTestRunner/win/InjectedBundle.vcproj:
179         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
180         * WinLauncher/WinLauncher.vcproj:
181         * record-memory-win/record-memory-win.vcproj:
182
183 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
184
185         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
186         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
187         adding the file to the sources list was not enough to force the rebuild.
188
189         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
190         Remove an empty line at the end of this file to force a rebuild.
191
192 2010-12-01  Sam Weinig  <sam@webkit.org>
193
194         Fix windows build.
195
196         * MiniBrowser/win/BrowserView.cpp:
197         (BrowserView::create):
198
199 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
200
201         Add missing file to the TestNetscapePlugin sources list after r73057.
202
203         * GNUmakefile.am: Add missing file.
204
205 2010-12-01  Sam Weinig  <sam@webkit.org>
206
207         Reviewed by Anders Carlsson.
208
209         Add PageGrouping to WebKit2 API
210         https://bugs.webkit.org/show_bug.cgi?id=50332
211
212         - Update testing harnesses to deal with new PageGroup API.
213
214         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
215         (WKBundleInitialize):
216         * TestWebKitAPI/InjectedBundleController.cpp:
217         (TestWebKitAPI::InjectedBundleController::initialize):
218         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
219         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
220         * TestWebKitAPI/InjectedBundleController.h:
221         * TestWebKitAPI/InjectedBundleTest.h:
222         (TestWebKitAPI::InjectedBundleTest::initialize):
223         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
224         * TestWebKitAPI/PlatformUtilities.cpp:
225         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
226         * TestWebKitAPI/PlatformUtilities.h:
227         * TestWebKitAPI/PlatformWebView.h:
228         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
229         (TestWebKitAPI::TEST):
230         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
231         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
232         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
233         (TestWebKitAPI::PlatformWebView::PlatformWebView):
234         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
235         (TestWebKitAPI::PlatformWebView::PlatformWebView):
236         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
237         (WTR::InjectedBundle::didInitializePageGroup):
238         (WTR::InjectedBundle::initialize):
239         (WTR::InjectedBundle::beginTesting):
240         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
241         (WTR::InjectedBundle::pageGroup):
242         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
243         (WTR::LayoutTestController::addUserScript):
244         (WTR::LayoutTestController::addUserStyleSheet):
245         (WTR::LayoutTestController::setXSSAuditorEnabled):
246         * WebKitTestRunner/TestController.cpp:
247         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
248         (WTR::PlatformWebView::PlatformWebView):
249
250 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
251
252         Reviewed by Adam Roben.
253
254         vcproj changes can't be applied cleanly by the Windows EWS bot
255         https://bugs.webkit.org/show_bug.cgi?id=50328
256
257         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
258         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
259         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
260         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
261         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
262         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
263         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
264         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
265         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
266         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
267         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
268         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
269         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
270         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
271         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
272         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
273         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
274         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
275         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
276         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
277         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
278         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
279         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
280         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
281         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
282         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
283         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
284         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
285         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
286         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
287         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
288         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
289         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
290         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
291         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
292         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
293         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
294         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
295         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
296         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
297         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
298         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
299         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
300         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
301         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
302
303 2010-12-01  Anders Carlsson  <andersca@apple.com>
304
305         Reviewed by Darin Adler.
306
307         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
308         https://bugs.webkit.org/show_bug.cgi?id=50336
309
310         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
311         Add new test.
312
313         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
314         (PluginTest::NPP_New):
315         Add default implementation/
316
317         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
318         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
319         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
320         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
321         Get the user agent.
322
323         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
324         (NPP_New):
325         Call PluginTest::NPP_New.
326
327         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
328         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
329         Add new files.
330
331         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
332         (webkit_test_plugin_new_instance):
333         Call PluginTest::NPP_New.
334
335 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
336
337         [wx] Build fixes after recent trunk changes.
338
339         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
340         (LayoutTestController::findString):
341         * wx/build/settings.py:
342
343 2010-12-01  Dan Bernstein  <mitz@apple.com>
344
345         Reviewed by Darin Adler.
346
347         WebKitTestRunner needs layoutTestController.findString
348         https://bugs.webkit.org/show_bug.cgi?id=50238
349
350         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
351         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
352         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
353         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
354
355 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
356
357         Try using svn:eol-style native on a vcproj file.
358
359         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
360
361 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
362
363         Reviewed by Adam Roben.
364
365         [WINCE] Add WinCELauncher
366         https://bugs.webkit.org/show_bug.cgi?id=50217
367
368         * WinCELauncher/main.cpp: Added.
369
370 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
371
372         Reviewed by Kenneth Rohde Christiansen.
373
374         [Qt] Implement layoutTestController.findString
375         https://bugs.webkit.org/show_bug.cgi?id=50236
376
377         Add the missing function to the LayoutTestController.
378
379         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
380         (LayoutTestController::findString):
381         * DumpRenderTree/qt/LayoutTestControllerQt.h:
382
383 2010-11-30  Tony Chang  <tony@chromium.org>
384
385         Reviewed by Adam Barth.
386
387         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
388         https://bugs.webkit.org/show_bug.cgi?id=49036
389
390         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
391             for CppVariants.
392         (LayoutTestController::cppVariantToBool):
393         (LayoutTestController::cppVariantToInt32):
394         (LayoutTestController::setDatabaseQuota):
395         (LayoutTestController::evaluateInWebInspector):
396         (LayoutTestController::setMockGeolocationError):
397
398 2010-11-30  Eric Seidel  <eric@webkit.org>
399
400         Reviewed by Tony Chang.
401
402         update-webkit should call git fetch before git svn rebase
403         https://bugs.webkit.org/show_bug.cgi?id=50273
404
405         After discussion on webkit-dev, we've decided to move the "default"
406         git setup to pulling updates from git.webkit.org in preference
407         to rebuilding the local svn index using git svn fetch every time.
408
409         This change should have no effect on people using the "old" git setup
410         and should dramatically increase the speed of updates for those using
411         the "new" git setup along with update-webkit.  I'm about to move the
412         EWS and other queues over to this setup once this lands.
413
414         * Scripts/update-webkit:
415
416 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
417
418         Reviewed by Xan Lopez.
419
420         GTK: AX: implement press in DRT
421         https://bugs.webkit.org/show_bug.cgi?id=36146
422
423         Implement AccessibilityUIElement::press() for GTK.
424
425         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
426         (AccessibilityUIElement::press): Implemented.
427
428 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
429
430         Reviewed by Tony Chang.
431
432         config.webkit_base_dir returns a path with a trailing slash
433         https://bugs.webkit.org/show_bug.cgi?id=50197
434         
435         config.webkit_base_dir() should return a path without a trailing slash,
436         like all the other methods that return paths.
437         
438         Undoes MockFileSytem changes by r72640, since they're no longer
439         necessary for GetBaselinesTest to pass.
440
441         * Scripts/webkitpy/common/system/filesystem_mock.py:
442         * Scripts/webkitpy/layout_tests/port/base.py:
443         * Scripts/webkitpy/layout_tests/port/config.py:
444         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
445
446 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
447
448         Reviewed by Tony Chang.
449
450         Rebaseline server: baseline display tweaks
451         https://bugs.webkit.org/show_bug.cgi?id=50207
452         
453         Determine which baselines were used when running the tests and highlight
454         them in the UI. Sort platform names alphabetically.
455         
456         Also makes the server URL be launched in the user's browser
457         automatically.
458
459         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
460         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
461         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
462         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
463         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
464
465 2010-11-30  Dan Bernstein  <mitz@apple.com>
466
467         Reviewed by Anders Carlsson.
468
469         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
470         https://bugs.webkit.org/show_bug.cgi?id=50238
471
472         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
473         (WTR::LayoutTestController::findString): Added.
474         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
475
476 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
477
478         Reviewed by Adam Roben.
479
480         All projects on Windows should use cmd files for build events
481         https://bugs.webkit.org/show_bug.cgi?id=50213
482
483         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
484         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
485         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
486         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
487         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
488         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
489         * DumpRenderTree/win/ImageDiffCommon.vsprops:
490         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
491         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
492         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
493         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
494         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
495         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
496         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
497         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
498         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
499         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
500         * WebKitAPITest/WebKitAPITestCommon.vsprops:
501         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
502         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
503         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
504         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
505         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
506         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
507         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
508         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
509         * WinLauncher/WinLauncherCommon.vsprops:
510         * WinLauncher/WinLauncherPostBuild.cmd: Added.
511         * WinLauncher/WinLauncherPreBuild.cmd: Added.
512
513 2010-11-29  Dan Bernstein  <mitz@apple.com>
514
515         GTK DumpRenderTree build fix after r72887.
516
517         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
518         (LayoutTestController::findString):
519
520 2010-11-29  Dan Bernstein  <mitz@apple.com>
521
522         Windows DumpRenderTree build fix after r72887.
523
524         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
525         (LayoutTestController::findString): Added empty implementation.
526
527 2010-11-29  Dan Bernstein  <mitz@apple.com>
528
529         Reviewed by Darin Adler.
530
531         DumpRenderTree changes for testing the text search API.
532         https://bugs.webkit.org/show_bug.cgi?id=50038
533
534         * DumpRenderTree/LayoutTestController.cpp:
535         (findStringCallback):
536         (LayoutTestController::staticFunctions):
537         * DumpRenderTree/LayoutTestController.h:
538         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
539         (LayoutTestController::findString):
540         * MiniBrowser/mac/BrowserWindowController.m:
541         (-[BrowserWindowController find:]):
542
543 2010-11-29  Johnny Ding  <jnd@chromium.org>
544
545         Unreviewed: Add myself to the list of Committers.
546
547         * Scripts/webkitpy/common/config/committers.py:
548
549 2010-11-29  Mark Rowe  <mrowe@apple.com>
550
551         Reviewed by Adele Peterson.
552
553         <rdar://problem/8694997> DumpRenderTree fails to build.
554
555         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
556
557 2010-11-29  Mark Rowe  <mrowe@apple.com>
558
559         Reviewed by Adele Peterson.
560
561         <rdar://problem/8694997> DumpRenderTree fails to build.
562
563         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
564         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
565         * DumpRenderTree/mac/PerlSupport/Makefile:
566
567 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
568
569         Reviewed by Martin Robinson.
570
571         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
572         https://bugs.webkit.org/show_bug.cgi?id=50154
573
574         Added missing checks to allAttributes().
575
576         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
577         (AccessibilityUIElement::allAttributes): Added missing checks.
578
579 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
580
581         Reviewed by Kenneth Rohde Christiansen.
582
583         [Qt] Allow pre-generation for package builds for WebKit2
584         https://bugs.webkit.org/show_bug.cgi?id=50139
585
586         Use a build variable for the generated directory path and set the
587         value based on CONFIG just like for WebKit1.
588
589         For non-package builds use a relative base path for the
590         genrated directory just like for WebKit1.
591
592         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
593         * WebKitTestRunner/qt/WebKitTestRunner.pro:
594
595 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
596
597         Reviewed by Kenneth Rohde Christiansen.
598
599         [Qt] Move some build logic from Qt to platform independent code
600         https://bugs.webkit.org/show_bug.cgi?id=50134
601
602         Create target directories inside generate-forwarding-headers.pl.
603
604         * Scripts/generate-forwarding-headers.pl:
605
606 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
607
608         Reviewed by Martin Robinson.
609
610         [GTK] Windowless plugins gets broken key input
611         https://bugs.webkit.org/show_bug.cgi?id=49927
612
613         Convert the XEvent::keycode to ASCII before printing it. Not
614         doing this was causing false positive in 
615         plugins/keyboard-events.html.
616
617         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
618         (keycode_to_char):
619         (webkit_test_plugin_handle_event):
620
621 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
622
623         Reviewed by Antonio Gomes.
624
625         [Qt] Html autofocus not working with QGraphicsWebView
626         https://bugs.webkit.org/show_bug.cgi?id=43169
627
628         Tell the scene to set the webview item as the currently
629         focused item. This makes the input field with autofocus get
630         focus as it should.
631
632         * QtTestBrowser/webview.cpp:
633         (WebViewGraphicsBased::WebViewGraphicsBased):
634
635 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
636
637         Reviewed by Tony Chang.
638
639         nrwt - clean up create_driver interface and print out the
640         command line used for DumpRenderTree/TestShell.
641
642         This patch adds a driver_cmd_line() call to the Port class in
643         order to retrive the command line to print it out (as part of
644         --print config).
645
646         In addition, this patch cleans up the Port.create_driver()
647         signature and the Driver constructor interface to take a worker
648         number and no longer require the image_path argument (Chromium's
649         drivers now synthesize the image_path from the worker number
650         internally).
651
652         https://bugs.webkit.org/show_bug.cgi?id=49934
653
654         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
655         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
656         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
657         * Scripts/webkitpy/layout_tests/port/base.py:
658         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
659         * Scripts/webkitpy/layout_tests/port/chromium.py:
660         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
661         * Scripts/webkitpy/layout_tests/port/dryrun.py:
662         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
663         * Scripts/webkitpy/layout_tests/port/test.py:
664         * Scripts/webkitpy/layout_tests/port/webkit.py:
665         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
666         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
667
668 2010-11-24  Ojan Vafai  <ojan@chromium.org>
669
670         Reviewed by Tony Chang.
671
672         [chromium] improve memory usage for test results server and store fewer runs
673         https://bugs.webkit.org/show_bug.cgi?id=50035
674
675         Store fewer runs and don't pass full files around when we only need bools.
676         Greatly improves error rates on test-results.appspot.com.
677
678         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
679         * TestResultServer/handlers/testfilehandler.py:
680         * TestResultServer/model/dashboardfile.py:
681         * TestResultServer/model/jsonresults.py:
682
683 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
684
685         Reviewed by Tony Chang.
686
687         This patch implements the first part of the manager side of the
688         Broker objects - it handles creating threads, waiting for them
689         to complete, and running a single-threaded loop as well.
690
691         https://bugs.webkit.org/show_bug.cgi?id=49779
692
693         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
694         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
695         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
696         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
697
698 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
699
700         Reviewed by David Levin.
701
702         DRT should not generate pixel output for text/plain tests
703         https://bugs.webkit.org/show_bug.cgi?id=50002
704         
705         Modify Mac, Windows and GTK DRT implementations to disable pixel output
706         when encountering a text/plain response (the Chromium one already does
707         this, and none of the other ports special-case text/plain output in
708         the first place).
709
710         * DumpRenderTree/gtk/DumpRenderTree.cpp:
711         (dump):
712         * DumpRenderTree/mac/DumpRenderTree.mm:
713         (dump):
714         * DumpRenderTree/win/DumpRenderTree.cpp:
715         (dump):
716
717 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
718
719         Unreviewed.
720
721         Add my other email address to committers.py.
722
723         * Scripts/webkitpy/common/config/committers.py:
724
725 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
726
727         Reviewed by Csaba Osztrogonác.
728
729         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
730         https://bugs.webkit.org/show_bug.cgi?id=49975
731
732         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
733         to enable the script to define it 0 in case of a minimal build.
734
735 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
736
737         Reviewed by Xan Lopez.
738
739         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
740         https://bugs.webkit.org/show_bug.cgi?id=49143
741
742         * DumpRenderTree/gtk/DumpRenderTree.cpp:
743         (createWebView): Call the new connectEditingCallbacks function.
744         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
745         (dumpNodePath):
746         (dumpRange):
747         (insertActionString):
748         (selectionAffinityString):
749         (shouldBeginEditing):
750         (shouldEndEditing):
751         (shouldInsertNode):
752         (shouldInsertText):
753         (shouldDeleteRange):
754         (shouldShowDeleteInterfaceForElement):
755         (shouldChangeSelectedRange):
756         (shouldApplyStyle):
757         (editingBegan):
758         (userChangedContents):
759         (editingEnded):
760         (selectionChanged):
761         (connectEditingCallbacks):
762         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
763         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
764
765 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
766
767         Reviewed by Andreas Kling.
768
769         [Qt] Make QtTestBrowser remember the selected user agent
770         https://bugs.webkit.org/show_bug.cgi?id=50021
771
772         Set user agent for a new page by using the old page's
773
774         * QtTestBrowser/mainwindow.cpp:
775         (MainWindow::setPage):
776
777 2010-11-24 Patrick Gansterer <paroga@webkit.org>
778
779         Reviewed by Csaba Osztrogonác.
780
781         Remove Bakefile build system files
782         https://bugs.webkit.org/show_bug.cgi?id=49983
783
784         r53757 only removed the content, but not the files.
785         This patch removes that empty files.
786
787         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
788         * wx/browser/browser.bkl: Removed.
789         * wx/build-wxwebkit: Removed.
790
791 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
792
793         Reviewed by Tony Chang.
794
795         This patch cleans up the logic used to shard tests into groups a
796         bit and adds the --worker-model flag to NRWT. The flag is only
797         used at the moment to control whether to run single-threaded or
798         not, but eventually will also allow toggling between threads and
799         processes.
800
801         Also add a minor cleanup with _test_is_slow(), which just
802         eliminates some repetition and gives slightly better encapsulation.
803
804         https://bugs.webkit.org/show_bug.cgi?id=49773
805
806         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
807         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
808
809 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
810
811         Reviewed by Tony Chang.
812
813         Rebaseline server: list current baselines and platforms
814         https://bugs.webkit.org/show_bug.cgi?id=49991
815         
816         List existing baselines (with Trac links) for tests.
817         
818         Add dropdowns for choosing with platform baselines to target (and what
819         to do with existing ones).
820
821         Also fix MockFileSystem.join to behave more like os.path.join (unit
822         test was ending up with two consecutive slashes in a layout test
823         path).        
824
825         * Scripts/webkitpy/common/system/filesystem_mock.py:
826         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
827         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
828         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
829         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
830         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
831         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
832         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
833
834 2010-11-23  Ojan Vafai  <ojan@chromium.org>
835
836         Reviewed by Tony Chang.
837
838         remove timeout argument to urlopen
839         https://bugs.webkit.org/show_bug.cgi?id=49995
840
841         Apparently the version of python we have on the bots doesn't accept a timeout argument.
842
843         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
844
845 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
846
847         Unreviewed, rolling out r72628.
848         http://trac.webkit.org/changeset/72628
849         https://bugs.webkit.org/show_bug.cgi?id=49994
850
851         This patch is causing layout-test failtures on GTK Linux
852         64-bit Debug (Requested by ctguil on #webkit).
853
854         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
855         (AccessibilityUIElement::AccessibilityUIElement):
856         (AccessibilityUIElement::parentElementCallback):
857         * DumpRenderTree/chromium/AccessibilityUIElement.h:
858         * DumpRenderTree/chromium/CppBoundClass.cpp:
859         * DumpRenderTree/chromium/CppBoundClass.h:
860
861 2010-11-22  Ojan Vafai  <ojan@chromium.org>
862
863         Reviewed by Tony Chang.
864
865         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
866         https://bugs.webkit.org/show_bug.cgi?id=49944
867
868         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
869
870 2010-11-23  Chris Guillory  <chris.guillory@google.com>
871
872         Reviewed by Dimitri Glazkov.
873
874         Include the FrameView widget of a RenderWidget in the accessibility tree.
875         https://bugs.webkit.org/show_bug.cgi?id=49106
876
877         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
878         (AccessibilityUIElement::AccessibilityUIElement):
879         (AccessibilityUIElement::parentElementCallback):
880         (AccessibilityUIElement::isEqualCallback):
881         * DumpRenderTree/chromium/AccessibilityUIElement.h:
882         * DumpRenderTree/chromium/CppBoundClass.cpp:
883         (CppBoundClass::getFromCppVariant):
884         * DumpRenderTree/chromium/CppBoundClass.h:
885
886 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
887
888         Reviewed by Kenneth Rohde Christiansen.
889
890         [EFL] Add tiled backing store to EWebLauncher
891         https://bugs.webkit.org/show_bug.cgi?id=45777
892
893         Allow EWebLauncher to choose between single and tiled backing store
894
895         * EWebLauncher/main.c:
896         (on_key_down):
897         (browserCreate):
898         (main):
899
900 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
901
902         Reviewed by Tor Arne Vestbø.
903
904         [Qt] Review the setUserPermission & friends API
905         https://bugs.webkit.org/show_bug.cgi?id=46810
906
907         Renamed requestPermissionFromUser to featurePermissionRequested
908         and cancelRequestsForPermission to featurePermissionRequestCanceled.
909
910         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
911         (WebCore::WebPage::WebPage):
912         * QtTestBrowser/webpage.cpp:
913         (WebPage::WebPage):
914         (WebPage::featurePermissionRequestCanceled):
915         * QtTestBrowser/webpage.h:
916
917 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
918
919         Reviewed by Tor Arne Vestbø.
920
921         [Qt] Review the setUserPermission & friends API
922         https://bugs.webkit.org/show_bug.cgi?id=46810
923
924         Rename setUserPermission to setFeaturePermission
925
926         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
927         (WebCore::WebPage::requestPermission):
928         (WebCore::WebPage::permissionSet):
929         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
930         (LayoutTestController::grantDesktopNotificationPermission):
931         * QtTestBrowser/webpage.cpp:
932         (WebPage::requestPermission):
933
934 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
935
936         Reviewed by Tor Arne Vestbø.
937
938         [Qt] Review the setUserPermission & friends API
939         https://bugs.webkit.org/show_bug.cgi?id=46810
940
941         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
942         and GeolocationPermissionDomain to Geolocation.
943
944         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
945         (WebCore::WebPage::WebPage):
946         (WebCore::WebPage::requestPermission):
947         (WebCore::WebPage::cancelPermission):
948         (WebCore::WebPage::permissionSet):
949         (WebCore::DumpRenderTree::geolocationPermissionSet):
950         * DumpRenderTree/qt/DumpRenderTreeQt.h:
951         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
952         (LayoutTestController::grantDesktopNotificationPermission):
953         * QtTestBrowser/webpage.cpp:
954         (WebPage::WebPage):
955         (WebPage::requestPermission):
956         (WebPage::cancelRequestsForPermission):
957         * QtTestBrowser/webpage.h:
958
959 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
960
961         Reviewed by Tor Arne Vestbø.
962
963         [Qt] Review the setUserPermission & friends API
964         https://bugs.webkit.org/show_bug.cgi?id=46810
965
966         Add a ByUser suffix to PermissionGranted/Denied. In the future
967         we can add PermissionGrantedByDefault.
968
969
970         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
971         (WebCore::WebPage::requestPermission):
972         (WebCore::WebPage::permissionSet):
973         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
974         (LayoutTestController::grantDesktopNotificationPermission):
975         * QtTestBrowser/webpage.cpp:
976         (WebPage::requestPermission):
977
978 2010-11-18  Satish Sampath  <satish@chromium.org>
979
980         Reviewed by Jeremy Orlow.
981
982         For speech input event, send an event object containing all the recognition results and metadata.
983         https://bugs.webkit.org/show_bug.cgi?id=49736
984
985         Updated DRT by renaming the mock result method on all platforms to the new signature.
986
987         * DumpRenderTree/LayoutTestController.cpp:
988         (addMockSpeechInputResultCallback):
989         (LayoutTestController::staticFunctions):
990         * DumpRenderTree/LayoutTestController.h:
991         * DumpRenderTree/chromium/LayoutTestController.cpp:
992         (LayoutTestController::LayoutTestController):
993         (LayoutTestController::addMockSpeechInputResult):
994         * DumpRenderTree/chromium/LayoutTestController.h:
995         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
996         (LayoutTestController::addMockSpeechInputResult):
997         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
998         (LayoutTestController::addMockSpeechInputResult):
999         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1000         (LayoutTestController::addMockSpeechInputResult):
1001         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1002         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1003         (LayoutTestController::addMockSpeechInputResult):
1004         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1005         (LayoutTestController::addMockSpeechInputResult):
1006
1007 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
1008
1009         Reviewed by Tony Chang.
1010
1011         Fix some spacing issues with log messages with
1012         new-run-webkit-tests --verbose.
1013
1014         https://bugs.webkit.org/show_bug.cgi?id=49936
1015
1016         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1017
1018 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1019
1020         Reviewed by Adam Barth.
1021
1022         update scm to work with different remote branches
1023         https://bugs.webkit.org/show_bug.cgi?id=49949
1024
1025         This works if there are multiple svn tracking branches
1026         and/or if the tracking branch is refs/remots/origin/master
1027         instead of refs/remotes/trunk which is the direction we're trying
1028         to head since that makes fetches faster.
1029
1030         * Scripts/webkitpy/common/checkout/scm.py:
1031         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1032
1033 2010-11-22  Hayato Ito  <hayato@chromium.org>
1034
1035         Reviewed by Shinichiro Hamaji.
1036
1037         Ignore reference files which will be used by reftests when collecting
1038         test cases.
1039         https://bugs.webkit.org/show_bug.cgi?id=49835
1040
1041         * Scripts/webkitpy/layout_tests/port/test_files.py:
1042         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1043
1044 2010-11-22  Adam Roben  <aroben@apple.com>
1045
1046         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
1047
1048         Apple's Windows build allows placing header files and import libraries for WebKit's
1049         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
1050         $WebKitLibrariesDir environment variable. This is both required for production builds and
1051         convenient for Apple-internal developer builds. Apple's production builds also require that
1052         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
1053         builds, the files are copied into that directory tree by the
1054         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
1055         copying is done by
1056         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
1057
1058         This .vsprops copying is problematic in one very important case: when a developer updates
1059         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
1060         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
1061         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
1062         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
1063         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
1064         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
1065
1066         To fix this, we now use normal relative paths to access the .vsprops files in the source
1067         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
1068         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
1069         unset, so the normal relative paths are used to read the .vsprops files out of the source
1070         tree directly. In production builds, this environment variable is set to a fake directory
1071         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
1072         is resolved.
1073         
1074         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
1075
1076         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1077
1078         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
1079         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
1080         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
1081         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
1082         FeatureDefines.vsprops becomes:
1083
1084         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1085
1086         which resolves to:
1087
1088         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1089
1090         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
1091         actually exist since they are matched by an equal number of ".." path components.)
1092
1093         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
1094         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
1095
1096         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
1097         updated
1098
1099         Reviewed by Dave Hyatt.
1100
1101         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1102         * DumpRenderTree/win/DumpRenderTree.vcproj:
1103         * DumpRenderTree/win/ImageDiff.vcproj:
1104         * FindSafari/FindSafari.vcproj:
1105         * MiniBrowser/MiniBrowser.vcproj:
1106         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1107         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1108         * WebKitAPITest/WebKitAPITest.vcproj:
1109         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1110         * WebKitTestRunner/win/InjectedBundle.vcproj:
1111         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1112         * WinLauncher/WinLauncher.vcproj:
1113         * record-memory-win/record-memory-win.vcproj:
1114         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
1115         files.
1116
1117 2010-11-22  Adam Roben  <aroben@apple.com>
1118
1119         Make it possible to run tests on Windows without Visual Studio or VC++
1120         Express installed
1121
1122         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1123         are not installed. But this function doesn't need to be called when we
1124         already have a build available and are just trying to run the tests.
1125
1126         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1127         because Visual Studio/VC++ Express aren't installed
1128
1129         Reviewed by Dave Hyatt.
1130
1131         * Scripts/webkitdirs.pm:
1132         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1133         it is not needed by this function. Also added a FIXME.
1134
1135         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1136         relying on determineConfigurationForVisualStudio doing it.
1137
1138 2010-11-19  Hayato Ito  <hayato@chromium.org>
1139
1140         Reviewed by Shinichiro Hamaji.
1141
1142         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1143
1144         https://bugs.webkit.org/show_bug.cgi?id=49812
1145
1146         * Scripts/webkitpy/layout_tests/driver_test.py:
1147         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1148         * Scripts/webkitpy/layout_tests/port/base.py:
1149         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1150         * Scripts/webkitpy/layout_tests/port/chromium.py:
1151         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1152         * Scripts/webkitpy/layout_tests/port/test.py:
1153         * Scripts/webkitpy/layout_tests/port/webkit.py:
1154         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1155         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1156
1157 2010-11-22  Hayato Ito  <hayato@chromium.org>
1158
1159         Reviewed by Tony Chang.
1160
1161         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1162
1163         https://bugs.webkit.org/show_bug.cgi?id=49924
1164
1165         * Scripts/webkitpy/layout_tests/port/chromium.py:
1166
1167 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1168
1169         Reviewed by Kenneth Rohde Christiansen.
1170
1171         Fix EWebLauncher zoom discretization
1172         https://bugs.webkit.org/show_bug.cgi?id=49810
1173
1174         * EWebLauncher/main.c:
1175         (nearest_zoom_level_get):
1176         (zoom_level_set):
1177         (on_load_finished):
1178         (on_key_down):
1179
1180 2010-11-21  Sam Weinig  <sam@webkit.org>
1181
1182         Rubber-stamped by Dan Bernstein.
1183
1184         Fix ~300 WebKit2 tests by enabling developer extras preference.
1185
1186         * WebKitTestRunner/TestController.cpp:
1187         (WTR::TestController::resetStateToConsistentValues):
1188
1189 2010-11-21  Sam Weinig  <sam@webkit.org>
1190
1191         Reviewed by Dan Bernstein.
1192
1193         Textareas should be resizable by default
1194         https://bugs.webkit.org/show_bug.cgi?id=49892
1195
1196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1197         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1198         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1199         Add preferences test.
1200
1201 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1202
1203         Reviewed by Tony Chang.
1204
1205         Rebaseline server: checksum-only differences and prefetching
1206         https://bugs.webkit.org/show_bug.cgi?id=49841
1207         
1208         Add support for image test results where the only difference is in the
1209         checksum.
1210         
1211         Add prefetching of the image results from the next test.
1212         
1213         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1214         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1215         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1216
1217 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1218
1219         Reviewed by Tony Chang.
1220
1221         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1222
1223         Add the 'worker number' and 'worker name' concepts to the 
1224         TestShellThread objects, and move test_types and test_args from
1225         the TestRunner to the TestShellThread.
1226
1227         https://bugs.webkit.org/show_bug.cgi?id=49768
1228
1229         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1230         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1231
1232 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1233
1234         Reviewed by Ojan Vafai.
1235
1236         Do some minor cleanup and bug fixing.
1237
1238         https://bugs.webkit.org/show_bug.cgi?id=49777
1239
1240         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1241         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1242
1243 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1244
1245         Reviewed by Ojan Vafai.
1246
1247         nrwt - config.build_directory() is busted
1248
1249         Fixes a typo that was causing us to usually return the top level
1250         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1251         bug was hidden by test stubs that were too simplistic :(.
1252
1253         https://bugs.webkit.org/show_bug.cgi?id=49815
1254
1255         * Scripts/webkitpy/common/system/executive_mock.py:
1256         * Scripts/webkitpy/layout_tests/port/config.py:
1257         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1258
1259 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1260
1261         Reviewed by Adam Roben.
1262
1263         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1264         https://bugs.webkit.org/show_bug.cgi?id=49819
1265
1266         * DumpRenderTree/DumpRenderTree.sln:
1267         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1268         * DumpRenderTree/win/DumpRenderTree.vcproj:
1269         * DumpRenderTree/win/ImageDiff.vcproj:
1270         * FindSafari/FindSafari.vcproj:
1271         * MiniBrowser/MiniBrowser.vcproj:
1272         * TestWebKitAPI/win/TestWebKitAPI.sln:
1273         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1274         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1275         * WebKitAPITest/WebKitAPITest.vcproj:
1276         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1277         * WebKitTestRunner/win/InjectedBundle.vcproj:
1278         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1279         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1280         * WinLauncher/WinLauncher.vcproj:
1281         * record-memory-win/record-memory-win.vcproj:
1282
1283 2010-11-19  Adam Roben  <aroben@apple.com>
1284
1285         Add some more Windows slaves
1286
1287         This is probably more than we will be using in the immediate future,
1288         but having some extra slave names makes experimenting with different
1289         configurations easier.
1290
1291         Reviewed by Jon Honeycutt.
1292
1293         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1294         Windows slaves and distributed them among the three different Test
1295         builders.
1296
1297 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1298
1299         Reviewed by Ojan Vafai.
1300
1301         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1302         https://bugs.webkit.org/show_bug.cgi?id=49702
1303
1304         Re-landing r72357 with a test fix.
1305
1306         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1307         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1308         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1309
1310 2010-11-19  Avi Drissman  <avi@google.com>
1311
1312         Reviewed by Antonio Gomes.
1313
1314         Complete support for Unix editing mode
1315         https://bugs.webkit.org/show_bug.cgi?id=49757
1316
1317         * DumpRenderTree/LayoutTestController.cpp:
1318         (setEditingBehaviorCallback):
1319         * DumpRenderTree/chromium/LayoutTestController.cpp:
1320         (LayoutTestController::setEditingBehavior):
1321
1322 2010-11-19  Adam Roben  <aroben@apple.com>
1323
1324         Fix run-javascriptcore-tests when there's a space in the path to
1325         testapi
1326
1327         Reviewed by Sam Weinig.
1328
1329         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1330         system() to force it to interpret spaces in the path correctly.
1331
1332 2010-11-19  Adam Roben  <aroben@apple.com>
1333
1334         Update scripts for .exe name changes after r72327
1335
1336         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1337
1338         Reviewed by Sam Weinig.
1339
1340         * Scripts/run-javascriptcore-tests:
1341         (testapiPath):
1342
1343         * Scripts/sunspider-compare-results:
1344         (pathToBuiltJSC):
1345
1346         * Scripts/webkitdirs.pm:
1347         (jscPath):
1348         (safariPath):
1349
1350 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1351
1352         Reviewed by Darin Adler.
1353
1354         Normalize Cairo/CFLite project/solution configuration names
1355         https://bugs.webkit.org/show_bug.cgi?id=49818
1356
1357         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1358         * DumpRenderTree/win/DumpRenderTree.vcproj:
1359         * DumpRenderTree/win/ImageDiff.vcproj:
1360         * MiniBrowser/MiniBrowser.vcproj:
1361         * TestWebKitAPI/win/TestWebKitAPI.sln:
1362         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1363         * WebKitAPITest/WebKitAPITest.vcproj:
1364         * WebKitTestRunner/win/InjectedBundle.vcproj:
1365         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1366         * WinLauncher/WinLauncher.vcproj:
1367         * Scripts/webkitdirs.pm: Updated cairo build configs.
1368
1369 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1370
1371         Reviewed by Adam Roben.
1372
1373         Windows vcproj configuration names should be normalized across projects
1374         https://bugs.webkit.org/show_bug.cgi?id=49776
1375
1376         * DumpRenderTree/DumpRenderTree.sln:
1377         * FindSafari/FindSafari.vcproj:
1378         * TestWebKitAPI/win/TestWebKitAPI.sln:
1379         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1380         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
1381         * WebKitAPITest/WebKitAPITest.vcproj:
1382         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1383         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1384         * WebKitTestRunner/WebKitTestRunner.sln:
1385         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1386         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
1387         * record-memory-win/record-memory-win.vcproj:
1388
1389 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1390
1391         Build fix - as per DRT-mac, always enabled developer extras,
1392         in win/qt/gtk DRT.
1393
1394         This is necessary to enable rich exception messages to be generated
1395         following https://bugs.webkit.org/show_bug.cgi?id=49708.
1396
1397         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1398         (shouldEnableDeveloperExtras):
1399         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1400         (WebCore::shouldEnableDeveloperExtras):
1401         * DumpRenderTree/win/DumpRenderTree.cpp:
1402         (shouldEnableDeveloperExtras):
1403
1404 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1405
1406         Unreviewed, rolling out r72357.
1407         http://trac.webkit.org/changeset/72357
1408         https://bugs.webkit.org/show_bug.cgi?id=49784
1409
1410         It broke test-webkitpy tests since the patch didn't have the
1411         corresponding test update (Requested by kinuko on #webkit).
1412
1413         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1414         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1415
1416 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
1417
1418         Reviewed by Tony Chang.
1419
1420         Rebaseline server: add rebaseline queue
1421         https://bugs.webkit.org/show_bug.cgi?id=49763
1422         
1423         Add a UI queue (a multi-item <select>) where tests to be baselined
1424         can be enqueued (also supports basic removal). A queue is used instead
1425         of immediately doing rebaselines since SCM operations can take a while.
1426         It's better to go through lots of tests quickly to mark them as
1427         needing rebaselining and then batch the SCM operations.
1428         
1429         Also adds a simple log where results can be displayed.
1430
1431         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1432         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1433         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1434         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
1435         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1436         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1437
1438 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1439
1440         Reviewed by Oliver Hunt.
1441
1442         Bug 49708 - Stop recompiling functions to regenerate exception info.
1443
1444         Instead only hold info as necessary – keep divot info is the inspector
1445         is enabled, line number info is debugging or profiling, and handler
1446         info for functions with try/catch.
1447
1448         * DumpRenderTree/mac/DumpRenderTree.mm:
1449         (shouldEnableDeveloperExtras):
1450             - always enable the developer tools from DRT, to ensure we
1451               produce rich error messages on JavaScript exceptions.
1452
1453 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
1454
1455         Reviewed by Ojan Vafai.
1456
1457         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1458         https://bugs.webkit.org/show_bug.cgi?id=49702
1459
1460         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1461         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1462
1463 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
1464
1465         Reviewed by Tony Chang.
1466
1467         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
1468
1469         Create the first version of the 'message_broker' package. This
1470         class will encapsulate all of the threading/multiprocessing and
1471         message-sending details for the communication between the
1472         'manager' object and the 'worker' objects. For the moment, it
1473         just holds some routines and tests for logging thread stacks.
1474
1475         There should be no functional changes in this patch, just moving stuff
1476         around.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=49707
1479
1480         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1481         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
1482         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
1483         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
1484         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1485         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1486
1487 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1488
1489         Reviewed by Adam Roben.
1490
1491         Remove leftover Windows Debug_Internal configurations
1492         https://bugs.webkit.org/show_bug.cgi?id=49758
1493
1494         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1495         * DumpRenderTree/win/DumpRenderTree.vcproj:
1496         * DumpRenderTree/win/ImageDiff.vcproj:
1497         * MiniBrowser/MiniBrowser.vcproj:
1498         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1499         * WebKitAPITest/WebKitAPITest.vcproj:
1500         * WebKitTestRunner/win/InjectedBundle.vcproj:
1501         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1502         * WinLauncher/WinLauncher.vcproj:
1503
1504 2010-11-18  Adam Roben  <aroben@apple.com>
1505
1506         Add three new Windows XP build slaves
1507
1508         Reviewed by Steve Falkenburg.
1509
1510         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
1511         new slaves, and added them to the Windows XP Debug (Tests) builder.
1512
1513 2010-11-18  Daniel Bates  <dbates@rim.com>
1514
1515         Reviewed by Adam Roben.
1516
1517         update-webkit-support-libs should fall back to existing
1518         WebKitSupportLibrary version if there is no internet connectivity
1519         https://bugs.webkit.org/show_bug.cgi?id=49503
1520
1521         Fall back to existing support libraries (if present) when there is
1522         no internet connection.
1523
1524         Currently, update-webkit-support-libs dies with an "out-of-date"
1525         error when there is no internet connection because it cannot
1526         retrieve versioning information from developer.apple.com. Because
1527         update-webkit-support-libs fails, build-webkit fails. Instead,
1528         if there is no internet connection and the support libraries are
1529         present then we should warn the user and exit() with success so
1530         that build-webkit can work without an internet connection.
1531
1532         * Scripts/update-webkit-support-libs:
1533
1534 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1535
1536         Reviewed by Adam Roben.
1537
1538         Debug_Internal Windows configuration is unnecessary, should be removed
1539         https://bugs.webkit.org/show_bug.cgi?id=49753
1540
1541         * DumpRenderTree/win/DumpRenderTree.cpp:
1542         * MiniBrowser/win/stdafx.h:
1543         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1544         * WebKitTestRunner/win/TestControllerWin.cpp:
1545
1546 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1547
1548         Reviewed by Adam Roben.
1549
1550         Clean up vcproj errors
1551         https://bugs.webkit.org/show_bug.cgi?id=49741
1552
1553         * MiniBrowser/MiniBrowser.vcproj:
1554         * WebKitAPITest/WebKitAPITest.vcproj:
1555         * WebKitTestRunner/win/InjectedBundle.vcproj:
1556         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1557
1558 2010-11-18  Hayato Ito  <hayato@chromium.org>
1559
1560         Reviewed by Shinichiro Hamaji.
1561
1562         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
1563         which is caused by r72249.
1564
1565         https://bugs.webkit.org/show_bug.cgi?id=49751
1566
1567         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1568
1569 2010-11-18  Adam Roben  <aroben@apple.com>
1570
1571         Implement layoutTestController.waitForPolicyDelegate on Windows
1572
1573         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
1574
1575         Reviewed by Simon Fraser.
1576
1577         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1578         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
1579         code from LayoutTestControllerMac.mm.
1580
1581 2010-11-18  Hayato Ito  <hayato@chromium.org>
1582
1583         Reviewed by Shinichiro Hamaji.
1584
1585         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
1586
1587         https://bugs.webkit.org/show_bug.cgi?id=49740
1588
1589         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1590
1591 2010-11-18  Tony Chang  <tony@chromium.org>
1592
1593         Reviewed by Adam Barth.
1594
1595         run platform/chromium/plugins/refcount-leaks.html on all platforms
1596         https://bugs.webkit.org/show_bug.cgi?id=49485
1597
1598         Add PluginObject.testObjectCount which returns the number of allocated
1599         TestObjects. Add PluginObject.testCreateTestObject which allocates
1600         and returns a TestObject.
1601
1602         Add TestObject.refCount which returns the number of refs on the
1603         TestObject.
1604
1605         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1606         (pluginGetProperty):
1607         (pluginInvoke):
1608         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1609         (getTestObjectCount):
1610         (testAllocate):
1611         (testDeallocate):
1612         (testGetProperty):
1613         (testScriptObjectInvoke): Release a ref to a plugin object that was
1614             previously leaked.
1615         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1616
1617 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1618
1619         Reviewed by Adam Roben.
1620
1621         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
1622         https://bugs.webkit.org/show_bug.cgi?id=49711
1623
1624         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
1625         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
1626         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
1627         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1628         * record-memory-win/record-memory-win-common.vsprops: Added.
1629         * record-memory-win/record-memory-win.vcproj:
1630
1631 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
1632
1633         Reviewed by Csaba Osztrogonác.
1634
1635         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
1636
1637         * MiniBrowser/qt/BrowserWindow.cpp:
1638         (BrowserWindow::updateUserAgentList):
1639
1640 2010-11-17  Adam Roben  <aroben@apple.com>
1641
1642         Don't trigger Windows builds when chromium-win test results change
1643
1644         Reviewed by Mark Rowe.
1645
1646         * Scripts/webkitpy/common/config/build.py:
1647         (_should_file_trigger_build): Changed the regular expression used to
1648         search for directory names to only consider full directory names,
1649         rather than matching directory names where the string we care about is
1650         a suffix of the name.
1651
1652         * Scripts/webkitpy/common/config/build_unittest.py:
1653         (ShouldBuildTest): Added a test.
1654
1655 2010-11-17  Hayato Ito  <hayato@chromium.org>
1656
1657         Reviewed by Shinichiro Hamaji.
1658
1659         Remove a uri member from TestInput class.
1660
1661         https://bugs.webkit.org/show_bug.cgi?id=49691
1662
1663         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1664         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1665
1666 2010-11-17  Adam Roben  <aroben@apple.com>
1667
1668         Move FindSafari's settings into a vsprops file
1669
1670         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
1671
1672         Reviewed by Steve Falkenburg.
1673
1674         * FindSafari/FindSafari.vcproj:
1675         * FindSafari/FindSafariCommon.vsprops: Added.
1676
1677 2010-11-17  Adam Roben  <aroben@apple.com>
1678
1679         Use a minimum font size of 0 in DRT on Windows
1680
1681         This is the Windows equivalent of r72164.
1682
1683         Rubber-stamped by Dave Hyatt.
1684
1685         * DumpRenderTree/win/DumpRenderTree.cpp:
1686         (resetDefaultsToConsistentValues):
1687
1688 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
1689
1690         Reviewed by Andreas Kling.
1691
1692         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
1693         https://bugs.webkit.org/show_bug.cgi?id=49639
1694
1695         * Scripts/webkitpy/common/checkout/scm.py:
1696
1697 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
1698
1699         Reviewed by Tony Chang.
1700
1701         Rebaseline server: add loupe for image diffs
1702         https://bugs.webkit.org/show_bug.cgi?id=49692
1703         
1704         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
1705         enlarged area of the expected, actual and diff images side by side.
1706
1707         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1708         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
1709         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1710         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1711
1712 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1713
1714         Reviewed by Adam Roben.
1715
1716         WebKitLauncherWin should use vsprops for shared build settings
1717         https://bugs.webkit.org/show_bug.cgi?id=49696
1718
1719         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1720         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1721
1722 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1723
1724         Reviewed by Adam Roben.
1725
1726         WinLauncher should use vsprops for shared build settings
1727         https://bugs.webkit.org/show_bug.cgi?id=49695
1728
1729         * WinLauncher/WinLauncher.cpp:
1730         (_tWinMain):
1731         (PrintView):
1732         (WndProc):
1733         (MyEditProc):
1734         * WinLauncher/WinLauncher.vcproj:
1735         * WinLauncher/WinLauncherCommon.vsprops: Added.
1736
1737 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1738
1739         Delete unused file unintentionally added in last change.
1740
1741         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1742
1743 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1744
1745         Reviewed by Adam Roben.
1746
1747         DumpRenderTree on Windows should use a vsprops file for shared project settings
1748         https://bugs.webkit.org/show_bug.cgi?id=49690
1749
1750         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1751         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1752         * DumpRenderTree/win/DumpRenderTree.vcproj:
1753         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1754         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1755         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1756         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1757         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1758         * DumpRenderTree/win/ImageDiff.vcproj:
1759         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1760
1761 2010-11-17  Hayato Ito  <hayato@chromium.org>
1762
1763         Refactor TestTypeBase.compare_output().
1764
1765         Introduce a TestOutput class and update compare_output() of each test
1766         types so that they can take both actual and expected TestOutput objects.
1767
1768         https://bugs.webkit.org/show_bug.cgi?id=49431
1769
1770         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1771         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1772         * Scripts/webkitpy/layout_tests/port/base.py:
1773         * Scripts/webkitpy/layout_tests/port/chromium.py:
1774         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1775         * Scripts/webkitpy/layout_tests/port/test.py:
1776         * Scripts/webkitpy/layout_tests/port/webkit.py:
1777         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1778         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1779         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1780         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1781
1782 2010-11-17  Adam Roben  <aroben@apple.com>
1783
1784         Make each Windows Test builder use the same OS for all its slaves
1785
1786         Currently each WebKit1 Windows Test builder has one Windows XP slave
1787         and one Windows 7 slave. Having different OSes in a single builder
1788         meant that the builders would alternate between red and green when
1789         there were OS-specific failures.
1790
1791         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1792         between red and green because of multiple OS versions
1793
1794         Reviewed by Mark Rowe.
1795
1796         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1797         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1798         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1799         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1800         builders for the two WebKit1 builders so that they would all use the
1801         appropriate OS.
1802
1803 2010-11-17  James Robinson  <jamesr@chromium.org>
1804
1805         Reviewed by Dan Bernstein.
1806
1807         [chromium] Set minimum font size to 0 for DRT
1808         https://bugs.webkit.org/show_bug.cgi?id=49677
1809
1810         Followup for http://trac.webkit.org/changeset/72141.
1811
1812         Test: http/tests/misc/acid3.html
1813
1814         * DumpRenderTree/chromium/WebPreferences.cpp:
1815         (WebPreferences::reset):
1816
1817 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1818
1819         Unreviewed build fix.
1820
1821         [Qt] Add missing file I forgot in r72220.
1822
1823         * MiniBrowser/MiniBrowser.qrc: Added.
1824
1825 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1826
1827         Reviewed by Andreas Kling.
1828
1829         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1830         https://bugs.webkit.org/show_bug.cgi?id=49627
1831
1832         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1833
1834         * MiniBrowser/MiniBrowser.qrc: Added.
1835         Add it here to prevent qmake from detecting it
1836         since it needs to be copied to the build directory.
1837         * MiniBrowser/qt/BrowserWindow.cpp:
1838         (BrowserWindow::BrowserWindow):
1839         (BrowserWindow::updateUserAgentList):
1840         (BrowserWindow::showUserAgentDialog):
1841         * MiniBrowser/qt/BrowserWindow.h:
1842         * MiniBrowser/qt/MiniBrowser.pro:
1843
1844 2010-11-17  Adam Roben  <aroben@apple.com>
1845
1846         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1847
1848         We use that file on Windows!
1849
1850         Fixes <http://webkit.org/b/49643> Changes to
1851         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1852
1853         Reviewed by Steve Falkenburg.
1854
1855         * Scripts/webkitpy/common/config/build.py:
1856         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1857         trigger builds on SnowLeopard and Windows.
1858
1859         * Scripts/webkitpy/common/config/build_unittest.py:
1860         (ShouldBuildTest.test_should_build): Added a test.
1861
1862 2010-11-17  Satish Sampath  <satish@chromium.org>
1863
1864         Reviewed by Jeremy Orlow.
1865
1866         Clear the speech input mock explicitly before each test.
1867         https://bugs.webkit.org/show_bug.cgi?id=49660
1868
1869         * DumpRenderTree/chromium/LayoutTestController.cpp:
1870         (LayoutTestController::setMockSpeechInputResult):
1871         * DumpRenderTree/chromium/LayoutTestController.h:
1872         * DumpRenderTree/chromium/WebViewHost.cpp:
1873         (WebViewHost::speechInputController):
1874         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1875         * DumpRenderTree/chromium/WebViewHost.h:
1876         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1877
1878 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1879
1880         Unreviewed, specify IRC nickname in committers.py.
1881
1882         * Scripts/webkitpy/common/config/committers.py:
1883
1884 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1885
1886         Reviewed by Tony Chang.
1887
1888         [NRWT] Make http locking similar to perl implementation
1889         https://bugs.webkit.org/show_bug.cgi?id=49187
1890
1891         * Scripts/webkitpy/common/system/file_lock.py: Added.
1892         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1893         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1894
1895 2010-11-17  MORITA Hajime  <morrita@google.com>
1896
1897         Reviewed by Kent Tamura.
1898
1899         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
1900         https://bugs.webkit.org/show_bug.cgi?id=49366
1901
1902         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
1903           according to the spellchecker suggestion
1904         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
1905
1906         test_expectations.txt will be changed after this change is ported to test_shell.
1907         
1908         * DumpRenderTree/chromium/EventSender.cpp:
1909         (makeMenuItemStringsFor):
1910         (EventSender::contextClick):
1911         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1912         (MockSpellCheck::fillSuggestionList):
1913         (MockSpellCheck::initializeIfNeeded):
1914         * DumpRenderTree/chromium/MockSpellCheck.h:
1915         * DumpRenderTree/chromium/WebViewHost.cpp:
1916         (WebViewHost::mockSpellCheck):
1917         * DumpRenderTree/chromium/WebViewHost.h:
1918
1919 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1920
1921         Reviewed by Sam Weinig.
1922
1923         Make sure the pref for minimum font size is just explicitly set to 0 every time,
1924         since the bots have 1 stuck in their plist otherwise.
1925
1926         * DumpRenderTree/mac/DumpRenderTree.mm:
1927         (resetDefaultsToConsistentValues):
1928
1929 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1930
1931         Reviewed by Tony Chang.
1932
1933         Rebaseline server: compute diffs client-side
1934         https://bugs.webkit.org/show_bug.cgi?id=49640
1935         
1936         The image diff output from the DRT is pretty bad on some ports (at
1937         least the Mac one), so it's better to compute diffs on the client by
1938         using <canvas>.
1939
1940         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1941         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1942         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1943
1944 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1945
1946         Reviewed by Tony Chang.
1947
1948         Rebaseline server: display test results
1949         https://bugs.webkit.org/show_bug.cgi?id=49626
1950         
1951         Adds basic result display to the rebaseline server. On the Python side
1952         this involves:
1953         - Parsing the unexpected_results.json into a dictionary.
1954         - Serving it as JSON under /results.json.
1955         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
1956         but I'll need to have access to the parsed results on the Python side
1957         for follow-up changes).
1958         
1959         On the web UI side this adds:
1960         - Markup for display image and text results (expected, actual, diff),
1961           and JS for populating it.
1962         - Markup for breaking down test results by failure type and directory,
1963           and JS for populating it.
1964
1965         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1966         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1967         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1968         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
1969         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1970
1971 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1972
1973         Reviewed by Ojan Vafai.
1974
1975         See Chromium issue http://codereview.chromium.org/5133001/ - we
1976         are modifying the build bots to pass in the builder name with
1977         the "GPU" string appended instead of appending it in the code.
1978
1979         https://bugs.webkit.org/show_bug.cgi?id=49636
1980
1981         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1982
1983 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
1984
1985         Reviewed by Adam Roben.
1986
1987         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
1988         https://bugs.webkit.org/show_bug.cgi?id=49632
1989
1990         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1991         * DumpRenderTree/win/DumpRenderTree.vcproj:
1992         * DumpRenderTree/win/ImageDiff.vcproj:
1993         * MiniBrowser/MiniBrowser.vcproj:
1994         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1995         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1996         * WebKitTestRunner/win/InjectedBundle.vcproj:
1997         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1998         * WinLauncher/WinLauncher.vcproj:
1999         * record-memory-win/record-memory-win.vcproj:
2000
2001 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2002
2003         Reviewed by Ojan Vafai.
2004
2005         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
2006
2007         Rename the TestInfo class to TestInput to be clearer about its
2008         function, and move the checksum-reading code into dump_render_tree_thread
2009         to avoid cross-thread access.
2010
2011         https://bugs.webkit.org/show_bug.cgi?id=49573
2012
2013         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2014         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2015         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2016
2017 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2018
2019         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
2020
2021         * DumpRenderTree/mac/DumpRenderTree.mm:
2022         (resetDefaultsToConsistentValues):
2023
2024 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2025
2026         Reviewed by Geoff Garen.
2027
2028         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2029
2030         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
2031         for every WebView, and the WebKit API doesn't support that ownership model.
2032
2033         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
2034
2035         * DumpRenderTree/mac/DumpRenderTree.mm:
2036         (createWebViewAndOffscreenWindow):
2037         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2038         (LayoutTestController::setMockDeviceOrientation):
2039
2040 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2041
2042         Reviewed by Ojan Vafai.
2043
2044         new-run-webkit-tests: log the process id in --verbose mode
2045
2046         As part of the switch to multi-process mode, we should log the
2047         process id when running w/ --verbose.
2048
2049         https://bugs.webkit.org/show_bug.cgi?id=49571
2050
2051         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2052
2053 2010-11-16  Adam Roben  <aroben@apple.com>
2054
2055         Only trigger Windows builds when files that we actually use on Windows
2056         are changed
2057
2058         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
2059         It uses the new webkitpy.common.config.build module to determine
2060         whether a particular change should trigger a build on a particular
2061         platform. The Windows builders have been switched to use a
2062         PlatformSpecificScheduler.
2063
2064         The logic to determine whether or not a particular change should
2065         trigger a build on a given platform has only been implemented/tested
2066         for Windows. I tried to make it easy to add more platforms in the
2067         future, but I don't have enough familiarity with all platforms to be
2068         able to implement it for them.
2069
2070         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
2071         lots irrelevant changes (e.g., rebaselining Chromium test results)
2072
2073         Reviewed by Eric Seidel.
2074
2075         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
2076         PlatformSpecificScheduler for the Windows builders.
2077
2078         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2079         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
2080         up a ChangeFilter that filters to our branch and will call through to
2081         our filter method, and calls up to our base class.
2082         (PlatformSpecificScheduler.filter): Calls through to
2083         build.should_build to find out whether we should trigger a build for
2084         this change.
2085
2086         * Scripts/webkitpy/common/net/build.py: Added.
2087         (_should_file_trigger_build): Uses a set of directories and regexp
2088         patterns to determine whether the given file should trigger a build on
2089         the given platform. As mentioned earlier, this has only been
2090         implemented for Windows, though I did try to make some guesses about
2091         other platforms.
2092         (should_build): Returns true if any of the files should trigger a
2093         build on the given platform.
2094
2095         * Scripts/webkitpy/common/net/build_unittest.py: Added.
2096         (ShouldBuildTest.test_should_build): Does some basic testing to make
2097         sure we're triggering builds for the right files. It only tests
2098         Windows for now, though I tried to make some guesses about other
2099         platforms.
2100
2101 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2102
2103         Reviewed by Andreas Kling.
2104
2105         [Qt] Remove synchronous QWebPage::checkPermissions signal
2106         https://bugs.webkit.org/show_bug.cgi?id=46810
2107
2108         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2109         (WebCore::WebPage::WebPage):
2110         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2111         (LayoutTestController::grantDesktopNotificationPermission): When granting
2112         permission, grant it directly on the QWebPage/Frame, that will remember it.
2113         * QtTestBrowser/webpage.cpp:
2114         (WebPage::WebPage):
2115         * QtTestBrowser/webpage.h:
2116
2117
2118 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2119
2120         Reviewed by Csaba Osztrogonác.
2121
2122         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2123
2124         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2125         (LayoutTestController::reset):
2126         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2127         (LayoutTestController::isPrinting):
2128         (LayoutTestController::setPrinting):
2129
2130 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2131
2132         Reviewed by Andreas Kling.
2133
2134         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2135         https://bugs.webkit.org/show_bug.cgi?id=49587
2136
2137         * MiniBrowser/qt/BrowserView.cpp:
2138         (BrowserView::BrowserView): Added BackingStoreType
2139         argument to ctor. Propagating it to the QGraphicsWKView.
2140         * MiniBrowser/qt/BrowserView.h:
2141         * MiniBrowser/qt/BrowserWindow.cpp:
2142         (BrowserWindow::BrowserWindow):
2143         (BrowserWindow::newWindow): Create the new BrowserWindow
2144         with the same BackingStoreType that this instance has.
2145         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
2146         * MiniBrowser/qt/main.cpp:
2147         (main): Use tiled backing store if got -tiled command line argument.
2148         Avoid redundant copy of command line args.
2149
2150 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
2151
2152         Reviewed by Jeremy Orlow.
2153
2154         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2155         https://bugs.webkit.org/show_bug.cgi?id=48506
2156
2157         This ensures that there is one mock per page WebView / WebViewHost. This is a
2158         design constraint of the DeviceOrientationClientMock because the m_controller
2159         field can only store a pointer to a single instance of the corresponding
2160         DeviceOrientationController.
2161
2162         Test: fast/dom/DeviceOrientation/no-page-cache.html
2163
2164         * DumpRenderTree/chromium/LayoutTestController.cpp:
2165         (LayoutTestController::setMockDeviceOrientation):
2166         (LayoutTestController::deviceOrientationClientMock):
2167         * DumpRenderTree/chromium/LayoutTestController.h:
2168         * DumpRenderTree/chromium/WebViewHost.cpp:
2169         (WebViewHost::deviceOrientationClientMock):
2170         (WebViewHost::deviceOrientationClient):
2171         (WebViewHost::reset):
2172         * DumpRenderTree/chromium/WebViewHost.h:
2173
2174 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2175
2176         Reviewed by Andreas Kling.
2177
2178         [Qt][WK2] Avoid polling in WebKitTestRunner.
2179         https://bugs.webkit.org/show_bug.cgi?id=49542
2180
2181         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2182         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2183
2184         * WebKitTestRunner/TestController.cpp:
2185         (WTR::TestController::didFinishLoadForFrame):
2186         * WebKitTestRunner/TestController.h:
2187         * WebKitTestRunner/TestInvocation.cpp:
2188         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2189         * WebKitTestRunner/mac/TestControllerMac.mm:
2190         (WTR::TestController::notifyDone): Add method stub.
2191         * WebKitTestRunner/qt/TestControllerQt.cpp:
2192         (WTR::TestControllerRunLoop::instance):
2193         (WTR::TestControllerRunLoop::start):
2194         (WTR::TestControllerRunLoop::stop):
2195         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2196         (WTR::TestControllerRunLoop::timerEvent):
2197         (WTR::TestController::notifyDone):
2198         (WTR::TestController::platformRunUntil):
2199         * WebKitTestRunner/win/TestControllerWin.cpp:
2200         (WTR::TestController::notifyDone): Add method stub.
2201
2202 2010-11-15  Darin Adler  <darin@apple.com>
2203
2204         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2205
2206 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2207
2208         Reviewed by Andreas Kling.
2209
2210         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2211         https://bugs.webkit.org/show_bug.cgi?id=49544
2212
2213         Add the shortcut to BrowserWindow.
2214
2215         * MiniBrowser/qt/BrowserWindow.cpp:
2216         (BrowserWindow::BrowserWindow):
2217         (BrowserWindow::openLocation):
2218         * MiniBrowser/qt/BrowserWindow.h:
2219
2220 2010-11-14  David Levin  <levin@chromium.org>
2221
2222         Reviewed by Daniel Bates.
2223
2224         check-webkit-style should detect PassRefPtr usage in functions.
2225         https://bugs.webkit.org/show_bug.cgi?id=49513
2226
2227         * Scripts/webkitpy/style/checkers/cpp.py:
2228         (check_for_function_lengths): Revert a comment change that I
2229          accidentally made in r71986.
2230         (check_pass_ptr_usage): Added the code to do the check.
2231         (process_line): Added the call to check_pass_ptr_usage.
2232         (CppChecker): Added the new error category.
2233         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2234         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2235          testing purposes.
2236         (PassPtrTest::*): The class/functions to unit test the new
2237          functionality.
2238
2239 2010-11-14  David Levin  <levin@chromium.org>
2240
2241         Reviewed by Shinichiro Hamaji.
2242
2243         check-webkit-style function detection and the line count style checks should be separate.
2244         https://bugs.webkit.org/show_bug.cgi?id=49512
2245
2246         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2247         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2248           call the detection function and fix line counts in two places now that
2249           the code really only counts the lines in the body of the function.
2250
2251 2010-11-14  Andreas Kling  <kling@webkit.org>
2252
2253         Reviewed by Antonio Gomes.
2254
2255         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2256         https://bugs.webkit.org/show_bug.cgi?id=33438
2257
2258         Stifle "Unhandled variable" warning to match what the other
2259         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2260         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2261
2262         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2263         (webkit_test_plugin_get_value):
2264
2265 2010-11-13  David Levin  <levin@chromium.org>
2266
2267         Reviewed by Eric Seidel.
2268
2269         check-webkit-style function detection crashes on functions in templates.
2270         https://bugs.webkit.org/show_bug.cgi?id=49504
2271
2272         For example "template <bool shouldClose(const Element*)>".
2273
2274         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2275         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2276           function detection test to expose this issue.
2277
2278 2010-11-12  David Levin  <levin@chromium.org>
2279
2280         Reviewed by Shinichiro Hamaji.
2281
2282         check-webkit-style function detection doesn't detect indented functions declaractions.
2283         https://bugs.webkit.org/show_bug.cgi?id=49446
2284
2285         Indented function declarations occur inside class definitions, so
2286         they are a pretty common (and worth detecting).
2287
2288         * Scripts/webkitpy/style/checkers/cpp.py:
2289           Changed regex to allow indentation.
2290           Changed the function start detection to only happen when not in a
2291           function.
2292           Changed function end detection to work based on matching braces
2293           instead of finding a close brace at the beginning of the line.
2294           Fixed close_expression to do what it says when it doesn't find
2295           the close.
2296         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2297
2298 2010-11-12  Daniel Bates  <dbates@rim.com>
2299
2300         Rubber-stamped by Nikolas Zimmermann.
2301
2302         Make do-file-rename rename files in the directory WebKit2.
2303
2304         This also makes the list of searched directories in do-file-rename
2305         consistent with the list of searched directories in the script do-webcore-rename.
2306
2307         * Scripts/do-file-rename:
2308
2309 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2310
2311         Reviewed by James Robinson.
2312
2313         Attempt yet again to land the fix for bug 49360 (respecting
2314         set-webkit-configuration). We need to handle the cases where
2315         trying to run webkit-build-directory to find out where the
2316         default configuration might be fails (that shows up on some
2317         Chromium bots that apparently don't have perl installed).
2318
2319         https://bugs.webkit.org/show_bug.cgi?id=49360
2320
2321         * Scripts/webkitpy/layout_tests/port/config.py:
2322         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2323         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2324
2325 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2326
2327         Reviewed by Adam Barth.
2328
2329         webkit-patch land logs commit message twice
2330         https://bugs.webkit.org/show_bug.cgi?id=49482
2331         
2332         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2333         that's just the commit message, which we now output following the
2334         actual commit.
2335
2336         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2337
2338 2010-11-12  Tony Chang  <tony@chromium.org>
2339
2340         Reviewed by Adam Barth.
2341
2342         run platform/chromium/plugins/script-object-invoke.html on all platforms
2343         https://bugs.webkit.org/show_bug.cgi?id=49280
2344
2345         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2346         (testScriptObjectInvoke):
2347         (pluginInvoke):
2348
2349 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2350
2351         Reviewed by Adam Barth.
2352
2353         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
2354         https://bugs.webkit.org/show_bug.cgi?id=49471
2355
2356         Right now there's no indication of a successful commit.
2357         
2358         * Scripts/webkitpy/tool/commands/download_unittest.py:
2359         * Scripts/webkitpy/tool/steps/commit.py:
2360
2361 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
2362
2363         Reviewed by Ojan Vafai.
2364
2365         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
2366         https://bugs.webkit.org/show_bug.cgi?id=49354
2367
2368         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
2369
2370         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2371         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2372         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2373         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2374
2375 2010-11-12  Tony Chang  <tony@chromium.org>
2376
2377         Reviewed by Kent Tamura.
2378
2379         [chromium] Load a blank page when closing DRT WebViewHosts
2380         https://bugs.webkit.org/show_bug.cgi?id=49417
2381
2382         In test_shell, when we close a window, we first load about:blank
2383         and run GC to fire the destruction logic of the page.  In test_shell,
2384         this happens in ~TestShell.  In DRT, we manage virtual windows as
2385         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
2386
2387         Managing focus is a bit trickier, since normally you would get window
2388         events to reset the focus to the right window.  We do it manually
2389         instead.
2390
2391         This fixes 2 plugin tests on DRT.
2392
2393         * DumpRenderTree/chromium/TestShell.cpp:
2394         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
2395         (TestShell::closeWindow): Move widget close() to WVH destructor and
2396             manage focus manually.
2397         (TestShell::closeRemainingWindows): Comment typo.
2398         * DumpRenderTree/chromium/WebViewHost.cpp:
2399         (WebViewHost::closeWidget):
2400         (invokeCloseWidget):
2401         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
2402             test_shell).
2403         (WebViewHost::~WebViewHost):
2404         * DumpRenderTree/chromium/WebViewHost.h:
2405
2406 2010-11-12  David Levin  <levin@chromium.org>
2407
2408         Reviewed by Adam Barth.
2409
2410         cpp.py needs some tidying.
2411         https://bugs.webkit.org/show_bug.cgi?id=49443
2412
2413         * Scripts/webkitpy/style/checkers/cpp.py:
2414           Fix parameter ordering for iteratively_replace_matches_with_char
2415           to mirror other similar functions (and improved comments, etc.)
2416           Also, use a python-ism (for/else) to get rid of a variable that
2417           was there to determine if something had been found in the loop.
2418
2419 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
2420
2421         Reviewed by James Robinson.
2422
2423         [Chromium/DRT] Make EventSendingController send complete touch events.
2424         https://bugs.webkit.org/show_bug.cgi?id=49285
2425
2426         * DumpRenderTree/chromium/EventSender.cpp:
2427         (EventSender::addTouchPoint):
2428         (EventSender::updateTouchPoint):
2429         (EventSender::sendCurrentTouchEvent):
2430
2431 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2432
2433         Unreviewed rollout of r71858.
2434
2435         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
2436         NaCl tests.
2437
2438         * Scripts/webkitpy/layout_tests/port/config.py:
2439         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
2440         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2441
2442 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
2443
2444         Reviewed by Kenneth Rohde Christiansen.
2445
2446         [Qt] TestController::runUntil doesn't honor the timeout parameter
2447         https://bugs.webkit.org/show_bug.cgi?id=48941
2448
2449         Implement the missing timeout of WebKitTestRunner for Qt.
2450
2451         A QElapsedTimer has been added to RunUntilConditionLoop in order
2452         to measure how long the loop has been running. When the timer
2453         is bigger or equal than the timeout, the loop ends even if the
2454         condition is not met.
2455
2456         * WebKitTestRunner/qt/TestControllerQt.cpp:
2457         (WTR::RunUntilConditionLoop::start):
2458         (WTR::RunUntilConditionLoop::run):
2459         (WTR::RunUntilConditionLoop::timerEvent):
2460         (WTR::TestController::platformRunUntil):
2461
2462 2010-11-11  David Levin  <levin@chromium.org>
2463
2464         Reviewed by Shinichiro Hamaji.
2465
2466         check-webkit-style function detection doesn't handle templates with spaces.
2467         https://bugs.webkit.org/show_bug.cgi?id=49427
2468
2469         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
2470           finding the function name.
2471         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
2472           template with a space.
2473
2474 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2475
2476         Reviewed by Shinichiro Hamaji.
2477
2478         Enable check-webkit-style on Qt files
2479         https://bugs.webkit.org/show_bug.cgi?id=48322
2480
2481         Adding exception for _q_... private slots and
2482         ..._data() methods in tests
2483
2484         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
2485         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
2486
2487 2010-11-11  David Levin  <levin@chromium.org>
2488
2489         Reviewed by Shinichiro Hamaji.
2490
2491         check-webkit-style function detection doesn't work for templates and destructors.
2492         https://bugs.webkit.org/show_bug.cgi?id=49425
2493
2494         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
2495         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
2496
2497 2010-11-11  Joone Hur  <joone@kldp.org>
2498
2499         Reviewed by Antonio Gomes.
2500
2501         [GTK][DRT] Implement LayoutTestController::nodesFromRect
2502         https://bugs.webkit.org/show_bug.cgi?id=46598
2503
2504         Support nodesFromRect in DRT
2505
2506         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2507         (LayoutTestController::nodesFromRect):
2508
2509 2010-11-11  MORITA Hajime  <morrita@google.com>
2510
2511         Reviewed by Kent Tamura.
2512
2513         editing/selection/context-menu-on-text.html fails on chromium
2514         https://bugs.webkit.org/show_bug.cgi?id=45898
2515
2516         Enhance Chromium's EventSender::contextClick() to return
2517         array of menu strings. The implementation incomplete because
2518         Although actual context menu is implemented by the browser,
2519         it reflects editability of underlying context thus makes
2520         context-menu-on-text.html passed.
2521         
2522         * DumpRenderTree/chromium/EventSender.cpp:
2523         (makeMenuItemStringsFor): Added.
2524         (EventSender::contextClick): Now returns array of menu strings.
2525         * DumpRenderTree/chromium/WebViewHost.cpp:
2526         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
2527         (WebViewHost::clearContextMenuData): Added.
2528         (WebViewHost::lastContextMenuData): Added.
2529         * DumpRenderTree/chromium/WebViewHost.h:
2530
2531 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2532
2533         Unreviewed, build fix.
2534
2535         fix build breakage caused by fix for bug 49380 (r71858).
2536
2537         config_standalone needs to ensure that the packages it needs are
2538         in sys.path.
2539
2540         https://bugs.webkit.org/show_bug.cgi?id=49419
2541
2542         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2543
2544 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2545
2546         Reviewed by Adam Roben.
2547
2548         Fix NRWT to respect set-webkit-configuration again :(
2549
2550         This change fixes a typo in config.py that was causing the wrong
2551         value to be read initially and us never actually looking into
2552         the filesystem to get the default configuration.
2553         
2554         * Scripts/webkitpy/layout_tests/port/config.py:
2555         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2556         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2557
2558 2010-11-11  Eric Seidel  <eric@webkit.org>
2559
2560         Reviewed by Adam Barth.
2561
2562         Split out Bug, Attachment and CommitterValidator from bugzilla.py
2563         https://bugs.webkit.org/show_bug.cgi?id=49403
2564
2565         CommitterValidator really had nothing to do with bugzilla.py.
2566         I've put it next to committers.py for now since its rather tied to that file.
2567
2568         * Scripts/webkitpy/common/config/committervalidator.py: Added.
2569         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
2570         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2571         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
2572         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
2573         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
2574         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2575         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2576         * Scripts/webkitpy/tool/bot/feeders.py:
2577         * Scripts/webkitpy/tool/commands/queues.py:
2578
2579 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2580
2581         Reviewed by Eric Seidel.
2582
2583         fix missing 'pid' argument for http lockfile checking on win32
2584         https://bugs.webkit.org/show_bug.cgi?id=49363
2585
2586         * Scripts/webkitpy/common/system/executive.py:
2587
2588 2010-11-11  Eric Seidel  <eric@webkit.org>
2589
2590         Rubber-stamped by Adam Barth.
2591
2592         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
2593         https://bugs.webkit.org/show_bug.cgi?id=49402
2594
2595         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
2596         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
2597         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
2598
2599 2010-11-10  Chris Guillory  <chris.guillory@google.com>
2600
2601         Reviewed by Chris Fleizach.
2602
2603         Use IAccessibleComparable to compare accessibility objects.
2604         https://bugs.webkit.org/show_bug.cgi?id=49118
2605
2606         * DumpRenderTree/AccessibilityUIElement.cpp:
2607         (AccessibilityUIElement::isEqual):
2608         * DumpRenderTree/AccessibilityUIElement.h:
2609         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2610         (comparableObject):
2611         (AccessibilityUIElement::isEqual):
2612
2613 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2614
2615         Reviewed by David Hyatt.
2616
2617         HTML5 Ruby support should be mandatory feature
2618         https://bugs.webkit.org/show_bug.cgi?id=49272
2619
2620         Remove Ruby as optional feature.
2621
2622         * Scripts/build-webkit:
2623
2624 2010-11-10  Adam Roben  <aroben@apple.com>
2625
2626         Print VC++ Express build logs in the same order that the projects are
2627         built
2628
2629         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
2630         in an unhelpful order
2631
2632         Reviewed by Eric Seidel.
2633
2634         * Scripts/print-vse-failure-logs:
2635         (PrintVisualStudioExpressLogs._build_order): Added. Uses
2636         print-msvc-project-dependencies to figure out the order in which
2637         projects are built.
2638         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
2639         based on their build order and project name.
2640         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
2641         scripts directory from here...
2642         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
2643         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
2644         them.
2645
2646 2010-11-10  Adam Roben  <aroben@apple.com>
2647
2648         Only print the interesting text from VC++ Express build logs
2649
2650         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
2651         output from print-vse-failure-logs
2652
2653         Reviewed by Eric Seidel.
2654
2655         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
2656         added newly-required imports. Removed a comment that was essentially a
2657         FIXME, and is now fixed.
2658         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
2659         BeautifulSoup to extract the relevant text from the build log.
2660         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
2661
2662 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
2663
2664         Reviewed by Tony Chang.
2665
2666         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
2667         https://bugs.webkit.org/show_bug.cgi?id=49286
2668         
2669         The tests in http/tests/security/XFrameOptions started to fail after
2670         r71297, since it changed the WebViewHost::assignIdentifierToRequest
2671         logic to always assign identifiers to requests, even if we're not going
2672         to be dumping resource load callbacks at that point. These tests
2673         only call LayoutTestController.dumpResourceLoadCallbacks after the
2674         request is started, thus their expectations have "<unknown>" as the
2675         identifier. Change WebViewHost to the previous behavior, which also
2676         match the other ports'.
2677
2678         * DumpRenderTree/chromium/WebViewHost.cpp:
2679         (WebViewHost::assignIdentifierToRequest):
2680         (WebViewHost::removeIdentifierForRequest):
2681
2682 2010-11-08  Tony Chang  <tony@chromium.org>
2683
2684         Reviewed by Adam Barth.
2685
2686         run platform/chromium/plugins/return-npobject.html on all platforms
2687         https://bugs.webkit.org/show_bug.cgi?id=49103
2688
2689         This tests that we can get an NPObject returned through a method on
2690         an NPAPI Object.
2691
2692         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2693         (testCallbackReturn):
2694         (pluginInvoke):
2695
2696 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2697
2698         Unreviewed, rolling out r71672.
2699         http://trac.webkit.org/changeset/71672
2700         https://bugs.webkit.org/show_bug.cgi?id=49276
2701
2702         It doesn't work on Chromium Windows bot (Requested by Ossy on
2703         #webkit).
2704
2705         * Scripts/webkitpy/common/system/file_lock.py: Removed.
2706         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2707         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2708
2709 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2710
2711         Reviewed by Tony Chang.
2712
2713         [NRWT] Make http locking similar to perl implementation
2714         https://bugs.webkit.org/show_bug.cgi?id=49187
2715
2716         * Scripts/webkitpy/common/system/file_lock.py: Added.
2717         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2718         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2719
2720 2010-11-09  James Kozianski  <koz@chromium.org>
2721
2722         Reviewed by Eric Seidel.
2723
2724         Clean up imports for webkit-patch.
2725         https://bugs.webkit.org/show_bug.cgi?id=49083
2726
2727         Move some imports from commands into main.py where they are used.
2728         Move command imports into the __init__ of the commands module.
2729
2730         * Scripts/webkitpy/tool/commands/__init__.py:
2731         * Scripts/webkitpy/tool/commands/download.py:
2732         * Scripts/webkitpy/tool/commands/queues.py:
2733         * Scripts/webkitpy/tool/main.py:
2734
2735 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2736
2737         Reviewed by Andreas Kling.
2738
2739         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2740         https://bugs.webkit.org/show_bug.cgi?id=49047
2741
2742         * QtTestBrowser/mainwindow.cpp:
2743         (MainWindow::setAddressUrl):
2744
2745 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2746
2747         Reviewed by Csaba Osztrogonác.
2748
2749         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2750         https://bugs.webkit.org/show_bug.cgi?id=49252
2751
2752         * Scripts/old-run-webkit-tests:
2753
2754 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2755
2756         Reviewed by Tor Arne Vestbø.
2757
2758         Output of old-run-webkit-tests is buggy in verbose mode
2759         https://bugs.webkit.org/show_bug.cgi?id=49249
2760
2761         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2762
2763 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2764
2765         Reviewed by Martin Robinson.
2766
2767         [GTK] Link with target name set does not work
2768         https://bugs.webkit.org/show_bug.cgi?id=48865
2769
2770         When a new page is created with a name (target=myFrame), the new
2771         mainFrame could not be found because they where not stored in the
2772         same PageGroup. As PageGroup are not exposed externally so the
2773         simpliest solution is to use a global page group name. This also fixes
2774         issue with visited link coloration across pages. After this change the
2775         private function webkit_web_view_set_group_name() was no longer used
2776         so it was removed completly.
2777
2778         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2779         (createWebView):
2780
2781 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2782
2783         Reviewed by Kent Tamura.
2784
2785         WebViewHost::reset() uses placement new.
2786         https://bugs.webkit.org/show_bug.cgi?id=49069
2787
2788         WebViewHost is using placement destruction / new to simulate a fresh
2789         WebViewHost object at the same address. This is because the WebView remains
2790         open across tests and maintains a pointer to the WebViewHost.
2791         This change resets member variables explictly instead of the placement new dance.
2792
2793         * DumpRenderTree/chromium/WebViewHost.cpp:
2794         (WebViewHost::WebViewHost):
2795         (WebViewHost::reset):
2796
2797 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2798
2799         Reviewed by Eric Seidel.
2800
2801         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
2802         It turns out that NRWT can't use the code in scm.find_checkout_root()
2803         because the Chromium bots don't do full checkouts of the WebKit
2804         tree; they only check out subdirectories like WebKitTools/Scripts.
2805         Until we can figure out a better approach for this, I've
2806         restored the base_dir-detecting code from NRWT, which works in
2807         any directory tree, scm or no.
2808
2809         This also restores the files modified in r71475 and r71474.
2810
2811         https://bugs.webkit.org/show_bug.cgi?id=49151
2812
2813         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2814         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2815
2816 2010-11-08  Eric Seidel  <eric@webkit.org>
2817
2818         Reviewed by Adam Barth.
2819
2820         webkit-patch failure-reason explodes if a build is missing
2821         https://bugs.webkit.org/show_bug.cgi?id=49195
2822
2823         This is likely a recent regression.  Adding a unit test for this case.
2824
2825         * Scripts/webkitpy/common/net/buildbot.py:
2826         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2827
2828 2010-11-08  Dan Bernstein  <mitz@apple.com>
2829
2830         Reviewed by Darin Adler.
2831
2832         Ignore the system scrollbar setting.
2833
2834         * DumpRenderTree/mac/DumpRenderTree.mm:
2835         (resetDefaultsToConsistentValues): Set the scrollbar default.
2836
2837 2010-11-05  Adam Roben  <aroben@apple.com>
2838
2839         Make webkitpy.common.system.executive_unittest pass when running under
2840         Win32 Python
2841
2842         Fixes <http://webkit.org/b/49033>.
2843
2844         Reviewed by Dave Levin and Eric Seidel.
2845
2846         * Scripts/webkitpy/common/system/executive.py:
2847         (Executive._run_command_with_teed_output): Pass the arguments through
2848         encode_argument_if_needed rather than using Cygwin-specific code here.
2849         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2850         the output.
2851         (Executive.run_command): Use encode_argument_if_needed to encode the
2852         arguments and child_process_encoding to decode the output.
2853         (Executive._child_process_encoding): Returns the encoding that should be
2854         used when communicating with child processes. On Windows we use mbcs,
2855         which maps to the current code page. On all other platforms we use
2856         UTF-8.
2857         (Executive._should_encode_child_process_arguments): Returns True if
2858         arguments to child processes need to be encoded. This is currently
2859         only needed on Cygwin and Win32 Python 2.x.
2860         (Executive._encode_argument_if_needed): Encode the argument using
2861         child_process_encoding if we need to encode arguments to child
2862         processes on this platform.
2863
2864         * Scripts/webkitpy/common/system/executive_unittest.py:
2865         (never_ending_command): Added. Returns arguments to run a command that
2866         will not quit until we kill it. On Windows we use wmic, on other
2867         platforms we use yes.
2868         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2869         mbcs encoding to be used and for output from the child processes to
2870         have been roundtripped through encode/decode on Win32 Python. When
2871         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2872         it's possible that some characters will not be able to be converted
2873         and will be replaced by question marks; the round-tripping allows us
2874         to expect this result.
2875
2876         (ExecutiveTest.test_kill_process):
2877         (ExecutiveTest.test_kill_all):
2878         Use never_ending_command instead of invoking "yes" directly. Expect an
2879         exit code of 1 when using Win32 Python, as that's what seems to happen.
2880
2881 2010-11-08  Adam Roben  <aroben@apple.com>
2882
2883         Roll out r71532
2884
2885         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2886         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2887
2888         * Scripts/webkitdirs.pm:
2889
2890 2010-11-08  Tony Chang  <tony@chromium.org>
2891
2892         Reviewed by Adam Barth.
2893
2894         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
2895         https://bugs.webkit.org/show_bug.cgi?id=49094
2896
2897         This tests that objects created by plugins are proplery cleaned up.
2898
2899         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2900         (testPassTestObject):
2901         (pluginInvoke):
2902         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2903         (testAllocate):
2904         (testDeallocate):
2905         (testGetProperty):
2906         (testConstruct):
2907
2908 2010-11-08  Adam Roben  <aroben@apple.com>
2909
2910         Mark Windows builds triggered from Perl as being non-interactive
2911
2912         This affects whether some of our scripts will show alerts vs. printing
2913         to the build log.
2914
2915         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
2916         .vsprops files are updated
2917
2918         Reviewed by Steve Falkenburg.
2919
2920         * Scripts/webkitdirs.pm:
2921         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
2922
2923 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2924
2925         Reviewed by Ojan Vafai.
2926
2927         Make http locking default in NRWT.
2928         https://bugs.webkit.org/show_bug.cgi?id=48053
2929
2930         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2931         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2932
2933 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2934
2935         Reviewed by Csaba Osztrogonác.
2936
2937         [NRWT] If the http lock fails we shouldn't do any locking
2938         https://bugs.webkit.org/show_bug.cgi?id=49164
2939
2940         If something goes wrong with the locking, the test should keep going.
2941
2942         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2943
2944 2010-11-08  Adam Roben  <aroben@apple.com>
2945
2946         Switch back to using kCGImageAlphaPremultipliedFirst when generating
2947         pixel dumps on Windows
2948
2949         I changed this behavior in r71418 thinking that it was required for
2950         getting plugins to show up in pixel dumps. But it doesn't seem to be
2951         necessary, and was making it impossible to compare new Windows pixel
2952         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
2953         compare an image with alpha to an image without alpha).
2954
2955         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
2956         new Windows pixel results to existing Windows or Mac results
2957
2958         Reviewed by Antti Koivisto.
2959
2960         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2961         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
2962         with kCGImageAlphaPremultipliedFirst.
2963
2964 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
2965
2966         Unreviewed, rolling out r71466.
2967         http://trac.webkit.org/changeset/71466
2968         https://bugs.webkit.org/show_bug.cgi?id=48865
2969
2970         It broke layout tests on GTK bots.
2971
2972         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2973         (createWebView):
2974
2975 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2976
2977         Reviewed by Csaba Osztrogonác.
2978
2979         Enable running of Qt API tests on BuildBot
2980         https://bugs.webkit.org/show_bug.cgi?id=49004
2981
2982         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2983
2984 2010-11-08  Eric Seidel  <eric@webkit.org>
2985
2986         Reviewed by Adam Barth.
2987
2988         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
2989         https://bugs.webkit.org/show_bug.cgi?id=49160
2990
2991         Bugzilla doesn't automatically remove r? when a bug gets closed.
2992         This script takes care of that for webkit.org.
2993
2994         * Scripts/webkitpy/common/net/bugzilla.py:
2995         * Scripts/webkitpy/tool/commands/upload.py:
2996
2997 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2998
2999         Unreviewed, rolling out r71474.
3000         http://trac.webkit.org/changeset/71474
3001         https://bugs.webkit.org/show_bug.cgi?id=48280
3002
3003         breaks chromium webkit tests
3004         https://bugs.webkit.org/show_bug.cgi?id=49151
3005
3006         * Scripts/webkitpy/layout_tests/port/base.py:
3007         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3008         * Scripts/webkitpy/layout_tests/port/config.py:
3009         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3010         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3011         * Scripts/webkitpy/layout_tests/port/webkit.py:
3012         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3013         * Scripts/webkitpy/tool/mocktool.py:
3014
3015 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3016
3017         Unreviewed, rolling out r71475.
3018         http://trac.webkit.org/changeset/71475
3019  
3020         breaks chromium webkit tests
3021         https://bugs.webkit.org/show_bug.cgi?id=49151
3022
3023         * Scripts/webkitpy/common/newstringio.py: Removed.
3024         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
3025         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
3026         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
3027         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
3028
3029 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3030
3031         Unreviewed, build fix.
3032
3033         Add files inexplicably not committed in r71474 as part of the
3034         fix for bug 48280.
3035
3036         * Scripts/webkitpy/common/newstringio.py: Added.
3037         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3038         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3039         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3040         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
3041
3042 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3043
3044         Reviewed by Eric Siedel.
3045
3046         new-run-webkit-tests: update port/base and port/webkit to use the
3047         new FileSystem and Config abstractions, pulling more logic out of
3048         the base Port classes into separate, mockable objects.
3049
3050         Also create a MockFileSystem object, a MockConfig object, move
3051         MockExecutive into common/system to be next to executive, and
3052         update the config object to use a FileSystem.
3053
3054         https://bugs.webkit.org/show_bug.cgi?id=48280
3055
3056         * Scripts/webkitpy/common/newstringio.py: Added.
3057         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3058         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3059         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3060         * Scripts/webkitpy/layout_tests/port/base.py:
3061         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3062         * Scripts/webkitpy/layout_tests/port/config.py:
3063         * Scripts/webkitpy/layout_tests/port/config_mock.py:
3064         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3065         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3066         * Scripts/webkitpy/layout_tests/port/webkit.py:
3067         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3068         * Scripts/webkitpy/tool/mocktool.py:
3069
3070 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3071
3072         Unreviewed, build breakage.
3073
3074         Apparently I uploaded the wrong version of the file to fix 49122
3075         and neither Eric or I noticed - it was missing a dirname() call.
3076         Fixing ...
3077
3078         https://bugs.webkit.org/show_bug.cgi?id=49122
3079
3080         * Scripts/webkitpy/common/checkout/scm.py:
3081
3082 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3083
3084         Reviewed by Eric Seidel.
3085
3086         webkitpy/tool/* unittests change cwd and don't clean up properly
3087
3088         https://bugs.webkit.org/show_bug.cgi?id=49122
3089
3090         * Scripts/webkitpy/common/checkout/scm.py:
3091
3092 2010-11-05  Chris Marrin  <cmarrin@apple.com>
3093
3094         Reviewed by Simon Fraser.
3095
3096         suspendAnimations/resumeAnimations not present in WebKit2
3097         https://bugs.webkit.org/show_bug.cgi?id=49109
3098
3099         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3100         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3101         (WTR::LayoutTestController::suspendAnimations):
3102         (WTR::LayoutTestController::resumeAnimations):
3103         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3104
3105 2010-11-05  Tony Chang  <tony@chromium.org>
3106
3107         Reviewed by David Levin.
3108
3109         cleanup style in TestNetscapePlugIn/PluginObject.cpp
3110         https://bugs.webkit.org/show_bug.cgi?id=49044
3111
3112         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3113         (getPluginClass):
3114         (pluginGetProperty):
3115         (pluginSetProperty):
3116         (variantToIdentifier):
3117         (testCallback):
3118         (getURL):
3119         (getURLNotify):
3120         (testInvokeDefault):
3121         (testGetProperty):
3122         (testDocumentOpen):
3123         (testWindowOpen):
3124         (pluginInvoke):
3125         (handleCallback):
3126         (notifyStream):
3127         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3128
3129 2010-11-05  Eric Seidel  <eric@webkit.org>
3130
3131         Reviewed by David Levin.
3132
3133         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
3134         https://bugs.webkit.org/show_bug.cgi?id=49032
3135
3136         I wrote this file as part of bug 47847, but I forgot to commit it.
3137         No one else noticed it missing because test-webkitpy knows how
3138         to recover in the case where it can't import QueueStatusServer
3139         (which generally occurs due to not having installed the AppEngine SDK).
3140
3141         * QueueStatusServer/__init__.py: Added.
3142         * QueueStatusServer/model/workitems_unittest.py:
3143          - Remove a test which fails.  This was probably landed (by me)
3144            from my other machine, which since this __init__.py was missing
3145            I never noticed the failure and landed this invalid test.
3146            Sadly we can't really test remove_work_item as it depends
3147            on .key() working.  .key() will throw unless the object
3148            has already been saved it seems.
3149            This may be a mis-design in our remove_work_item implementation,
3150            but for now, just removing the test.
3151
3152 2010-11-04  Adam Roben  <aroben@apple.com>
3153
3154         Teach check-webkit-style about TestNetscapePlugIn
3155
3156         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
3157         TestNetscapePlugIn's coding conventions
3158
3159         Reviewed by John Sullivan.
3160
3161         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
3162         WebKitAPITest and TestWebKitAPI in having different include order and
3163         naming conventions than WebCore. Added some comments about why the
3164         exceptions exist.
3165
3166 2010-11-04  Adam Roben  <aroben@apple.com>
3167
3168         Add a test that shows that windowed plugins are able to paint
3169
3170         Somehow we never had a test for this before.
3171
3172         Fixes <http://webkit.org/b/49029> Should add a test that shows
3173         windowed plugins can paint
3174
3175         Reviewed by Jon Honeycutt.
3176
3177         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
3178         (DrawsGradient::DrawsGradient):
3179         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
3180
3181         (DrawsGradient::onPaint):
3182         (DrawsGradient::onPrintClient):
3183         These both just call through to paint.
3184
3185         (DrawsGradient::paint): Fills our client area with some gradients.
3186
3187         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
3188         against Msimg32.lib for ::GradientFill and added DrawsGradient.
3189
3190         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3191         (createBitmapContextFromWebView): Use WM_PRINT instead of
3192         WM_PRINTCLIENT so that ::DefWindowProc will send
3193         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
3194         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
3195         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
3196         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
3197         will run on a big-endian platform.
3198
3199 2010-11-04  Adam Roben  <aroben@apple.com>
3200
3201         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
3202         WindowedPluginTest base class
3203
3204         The base class takes care of subclassing the plugin's window so that a
3205         custom WNDPROC is called. This will make it easier to write tests that
3206         need to handle window messages.
3207
3208         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
3209         a custom WNDPROC
3210
3211         Reviewed by Jon Honeycutt.
3212
3213         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3214         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
3215         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
3216         (NPNInvalidateRectInvalidatesWindow::wndProc):
3217         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
3218         Moved code from here to WindowedPluginTest. Changed to use window()
3219         instead of m_window.
3220
3221         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3222         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
3223         include path. Also reordered the include path to make a little more
3224         sense and simplified the entry that added TestNetscapePlugIn itself to
3225         the include path.
3226
3227         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
3228         (WindowedPluginTest::WindowedPluginTest):
3229         (WindowedPluginTest::NPP_SetWindow):
3230         (WindowedPluginTest::staticWndProc):
3231         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
3232         (WindowedPluginTest::window):
3233         Code came from NPNInvalidateRectInvalidatesWindow.
3234
3235 2010-11-04  Adam Roben  <aroben@apple.com>
3236
3237         Add a plugin test to show that windowed plugins are clipped correctly
3238
3239         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
3240         plugins aren't clipped in WebKit2 on Windows
3241
3242         Reviewed by Jon Honeycutt.
3243
3244         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
3245         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
3246         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
3247         region matches the clip rect we know we should have based on
3248         window-region-is-set-to-clip-rect.html, and check that our window class
3249         doesn't have the CS_PARENTDC style.
3250
3251         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3252         Added WindowRegionIsSetToClipRect.
3253
3254 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
3255
3256         Reviewed by Martin Robinson.
3257
3258         [GTK] Avoid font hinting in the DRT
3259         https://bugs.webkit.org/show_bug.cgi?id=48548
3260
3261         Change the settings to avoid font hinting, it was causing
3262         different results depending on the distribution.
3263
3264         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3265         (initializeGtkFontSettings):
3266         * DumpRenderTree/gtk/fonts/fonts.conf:
3267
3268 2010-11-05  Eric Seidel  <eric@webkit.org>
3269
3270         Reviewed by Adam Barth.
3271
3272         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
3273         https://bugs.webkit.org/show_bug.cgi?id=49051
3274
3275         This is a speculative fix.  The unit tests cover these methods, however
3276         I don't know if this will fully stop the system.log spam.
3277
3278         * Scripts/webkitpy/layout_tests/port/base.py:
3279         * Scripts/webkitpy/layout_tests/port/webkit.py:
3280
3281 2010-11-05  Eric Seidel  <eric@webkit.org>
3282
3283         Reviewed by Adam Barth.
3284
3285         Add basic support for showing bot id on /queue-status/ pages
3286         https://bugs.webkit.org/show_bug.cgi?id=49037
3287
3288         This support is really simple.  Eventually we'll want to
3289         show the bot id in the lock table too, but we don't have
3290         that information stored in the server yet.
3291
3292         * QueueStatusServer/handlers/queuestatus.py:
3293         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
3294         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3295
3296 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3297
3298         Reviewed by Adam Barth.
3299
3300         Create a filesystem wrapper that we can use to enforce
3301         particular conventions and use for mocking and dependency
3302         injection down the line.
3303
3304         https://bugs.webkit.org/show_bug.cgi?id=48144
3305
3306         * Scripts/webkitpy/common/system/filesystem.py: Added.
3307         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
3308
3309 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3310
3311         Reviewed by Tony Chang.
3312
3313         run_webkit_tests_unittest fails under Python 2.5
3314         https://bugs.webkit.org/show_bug.cgi?id=49043
3315         
3316         Switch from itertools.chain.from_iterable (which was added in 2.6)
3317         to using itertools.chain directly.
3318
3319         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3320
3321 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3322
3323         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
3324         Python 2.5 (it needs an import to use the with statement).
3325
3326         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3327
3328 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3329
3330         Reviewed by Adam Barth.
3331
3332         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
3333
3334         The current NRWT code has webkit-specific configuration code (like
3335         _script_path, default configuration, etc.) mixed in with
3336         layout-test-specific stuff in port/base. The configuration code
3337         should be split out into a separate module for easier mocking,
3338         testing, and isolation.
3339
3340         https://bugs.webkit.org/show_bug.cgi?id=48264
3341
3342         * Scripts/webkitpy/layout_tests/port/config.py: Added.
3343         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
3344
3345 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3346
3347         Reviewed by Tony Chang.
3348
3349         Rebaseline server: initial framework
3350         https://bugs.webkit.org/show_bug.cgi?id=48892
3351         
3352         Adds the basic framework for the rebaseline server (details at 
3353         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
3354         command, which starts an HTTP server that can serve static files or
3355         invoke handler methods on a class.
3356
3357         * Scripts/webkitpy/tool/commands/__init__.py:
3358         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
3359         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
3360         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
3361         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
3362
3363 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3364
3365         Reviewed by James Robinson.
3366
3367         new-run-webkit-tests wasn't using DRT by default for
3368         --platform chromium-gpu
3369
3370         The default value was set to False instead of None, which meant
3371         that the platform specific logic wasn't firing to change the
3372         value to True (b/c we were afraid we'd be overriding the user
3373         preference).
3374
3375         https://bugs.webkit.org/show_bug.cgi?id=49038
3376
3377         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3378
3379 2010-11-04  Tony Chang  <tony@chromium.org>
3380
3381         Reviewed by Adam Barth.
3382
3383         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
3384         https://bugs.webkit.org/show_bug.cgi?id=49026
3385
3386         Have the testObject.bar property return the string "bar".  This lets
3387         us run and pass platform/chromium/plugins/multiple-plugins.html on all
3388         platforms.
3389
3390         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3391         (testGetProperty):
3392
3393 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3394
3395         Reviewed by Tony Chang.
3396
3397         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
3398         https://bugs.webkit.org/show_bug.cgi?id=48878
3399         
3400         Add get_tests_run so that it's easy to see which tests get run (and with
3401         what batching) for a given flag combination. Flesh out the various
3402         test cases that have FIXMEs.
3403         
3404         Also fixes an off-by-one error (batch sizes were one larger than 
3405         expected) and makes --run-part also have wraparound behavior, like
3406         --run-chunk.
3407
3408         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3409         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3410         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3411
3412 2010-11-04  Erik Arvidsson  <arv@chromium.org>
3413
3414         Reviewed by Dimitri Glazkov.
3415
3416         Support box-sizing without the vendor prefix
3417         https://bugs.webkit.org/show_bug.cgi?id=36713
3418
3419         Based on patch by Peter Beverloo <peter@lvp-media.com>
3420
3421         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
3422
3423 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3424
3425         Unreviewed rollout r71340, because it broke Chromium Windows bot.
3426
3427         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3428         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3429
3430 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3431
3432         Reviewed by Ojan Vafai.
3433
3434         Make http locking default in NRWT.
3435         https://bugs.webkit.org/show_bug.cgi?id=48053
3436
3437         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3438         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3439
3440 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3441
3442         Reviewed by Eric Seidel.
3443
3444         [NRWT] Clear invalid http locks on Windows platform as well
3445         https://bugs.webkit.org/show_bug.cgi?id=48515
3446
3447         * Scripts/webkitpy/common/system/executive.py:
3448         * Scripts/webkitpy/common/system/executive_unittest.py:
3449         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3450
3451 2010-11-02  Adam Roben  <aroben@apple.com>
3452
3453         Reduce our dependence on coreutils when running Python tests
3454
3455         This patch introduces versions of the standard echo and cat utilities
3456         implemented in Python. They are probably missing features of their
3457         coreutils equivalents, but they can do what's necessary for our Python
3458         tests. This is useful on Windows, where these utilities typically
3459         aren't available.
3460
3461         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
3462         and cat utilities from coreutils, which are not present on Windows
3463
3464         Reviewed by Eric Seidel.
3465
3466         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
3467         our Python-based echo and cat.
3468
3469         * Scripts/webkitpy/common/system/fileutils.py: Added.
3470         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
3471         that \n won't be translated into \r\n. I couldn't think of a good way
3472         to test this directly without touching the filesystem, but it is tested
3473         indirectly by echo_unittest.
3474
3475         * Scripts/webkitpy/test/cat.py: Added.
3476         (command_arguments): Returns a list for invoking cat with the given arguments.
3477         (main): Acts like a simplified version of the coreutils cat utility.
3478
3479         * Scripts/webkitpy/test/cat_unittest.py: Added.
3480         (CatTest.assert_cat): Runs cat with the given input and ensures the
3481         output matches the input.
3482         (CatTest.test_basic): Performs a simple test of cat.
3483         (CatTest.test_no_newline): Tests what happens when the input string
3484         doesn't have a trailing newline.
3485         (CatTest.test_unicode): Tests passing a unicode string to cat.
3486         (CatTest.test_as_command): Tests running cat as a separate command.
3487
3488         * Scripts/webkitpy/test/echo.py: Added.
3489         (command_arguments): Returns a list for invoking echo with the given arguments.
3490         (main): Acts like a simplified version of the coreutils echo utility.
3491
3492         * Scripts/webkitpy/test/echo_unittest.py: Added.
3493         (EchoTest.test_basic): Performs a simple test of echo.
3494         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
3495         trailing newline.
3496         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
3497         to echo.
3498         (EchoTest.test_argument_order): Tests what happens when -n is not the
3499         first argument.
3500         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
3501         echo.main.
3502         (EchoTest.test_no_arguments): Tests what happens when you call
3503         echo.main with no arguments.
3504         (EchoTest.test_as_command): Tests running echo as a separate command.
3505
3506 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
3507
3508         Unreviewed: Add myself to the list of Committers.
3509
3510         * Scripts/webkitpy/common/config/committers.py:
3511
3512 2010-11-04  Andreas Kling  <kling@webkit.org>
3513
3514         Reviewed by Kenneth Rohde Christiansen.
3515
3516         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
3517
3518         In RTC mode the QGraphicsWebView item is the size of the contents,
3519         scrolling works a bit differently  (we need to react to scrollRequested.)
3520
3521         Normally QGraphicsView will replay the last mouse event when scrolling,
3522         so to prevent WebKit from getting confused by this we temporarily make
3523         the QGraphicsView non-interactive.
3524
3525         * QtTestBrowser/webview.cpp:
3526         (WebViewGraphicsBased::setPage):
3527         (WebViewGraphicsBased::scrollRequested):
3528         * QtTestBrowser/webview.h:
3529
3530 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3531
3532         Reviewed by Andreas Kling.
3533
3534         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
3535
3536         PLATFORM(MAC) is not defined for the Qt port, as it refers to
3537         the Mac-port, not the Mac OS X operating system.
3538
3539         * WebKitTestRunner/qt/TestControllerQt.cpp:
3540         (WTR::isExistingLibrary):
3541
3542 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
3543
3544         Reviewed by Andreas Kling.
3545
3546         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
3547         https://bugs.webkit.org/show_bug.cgi?id=48869
3548
3549         * QtTestBrowser/useragentlist.txt:
3550
3551 2010-11-03  Adam Roben  <aroben@apple.com>
3552
3553         Always use uppercase drive names in strings returned by abspath_to_uri
3554
3555         Some versions of cygpath use lowercase drive letters while others use
3556         uppercase, which makes it hard to test the output of code that uses
3557         cygpath.
3558
3559         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
3560         fails with Cygwin 1.5
3561
3562         Reviewed by Eric Seidel.
3563
3564         * Scripts/webkitpy/common/system/path.py:
3565         (cygpath): Updated the docstring to indicate that only absolute paths
3566         should be passed for now (though relative paths will work fine).
3567         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
3568
3569 2010-11-03  George Guo  <George.Guo@Nokia.com>
3570
3571         Reviewed by Andreas Kling.
3572
3573         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
3574         https://bugs.webkit.org/show_bug.cgi?id=48767
3575     
3576         Paging is needd on Symbian devices to support benchmarks tests like
3577         dromaeo.com and Celtic Kane that need a lot of memory to run  
3578
3579         * QtTestBrowser/QtTestBrowser.pro:
3580
3581 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
3582
3583         Reviewed by Dmitry Titov.
3584
3585         Chromium: Update resource tracking when moving a frame between documents
3586         https://bugs.webkit.org/show_bug.cgi?id=48363
3587
3588         * DumpRenderTree/chromium/WebViewHost.cpp:
3589         (WebViewHost::assignIdentifierToRequest):
3590         Always put resource id in map so we can make assumptions about its
3591         presence.
3592         (WebViewHost::removeIdentifierForRequest):
3593         Added.
3594         (WebViewHost::didFinishResourceLoad):
3595         (WebViewHost::didFailResourceLoad):
3596         Check existence of resource id before removing from map.
3597         * DumpRenderTree/chromium/WebViewHost.h:
3598
3599 2010-11-03  Victor Wang  <victorw@chromium.org>
3600
3601         Reviewed by Adam Barth.
3602
3603         [Chromium] update buildbot names in chromium rebaseline tool.
3604
3605         https://bugs.webkit.org/show_bug.cgi?id=48881
3606
3607         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3608
3609 2010-11-03  Darin Adler  <darin@apple.com>
3610
3611         Updated Xcode projects by opening them with Xcode 3.2.4.
3612         Updated svn:ignore for Xcode projects.
3613
3614         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
3615         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
3616         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3617         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
3618
3619 2010-11-03  Adam Roben  <aroben@apple.com>
3620
3621         Stop waiting for messages from the web process after a timeout elapses
3622
3623         TestController::runUntil now takes a timeout parameter that specifies
3624         how long to wait for the condition to become true. WebKitTestRunner
3625         takes a --timeout flag that specifies how long the timeout should be.
3626         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
3627         will be similar to run-webkit-tests.
3628
3629         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
3630         WebKitTestRunner waits forever if the web process crashes
3631
3632         Reviewed by Darin Adler and Anders Carlsson.
3633
3634         * Scripts/old-run-webkit-tests:
3635         (top level): Moved the GuardMalloc timeout adjustment here from
3636         readFromDumpToolWithTimer.
3637         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
3638         than the one that was specified on the command line.
3639
3640         * WebKitTestRunner/TestController.cpp:
3641         (WTR::TestController::TestController): Initialize our timeout values.
3642         (WTR::TestController::initialize): Parse the --timeout flag and use it
3643         to modify our timeout values.
3644         (WTR::TestController::resetStateToConsistentValues): Changed to use a
3645         short timeout while waiting for the web process to reset and to return
3646         a boolean indicating whether we were able to reset the web process.
3647         Uses a 5-second timeout while waiting for the process to be reset.
3648         (WTR::TestController::runTest): Changed to return a boolean indicating
3649         whether we were able to reset the web process (and thus run the test).
3650         (WTR::TestController::runUntil): Call through to platformRunUntil.
3651
3652         (WTR::TestController::runTestingServerLoop):
3653         (WTR::TestController::run):
3654         Changed to bail if any test can't be run. This will cause the process
3655         to exit. (Unfortunately this will make run-webkit-tests think we
3656         crashed; see <http://webkit.org/b/48943>.)
3657
3658         * WebKitTestRunner/TestController.h: Added platformRunUntil,
3659         m_longTimeout, and m_shortTimeout.
3660
3661         * WebKitTestRunner/TestInvocation.cpp:
3662         (WTR::TestInvocation::invoke): Use a short timeou