2010-07-13 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Nikolas Zimmermann.
4
5         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
6         https://bugs.webkit.org/show_bug.cgi?id=42153
7
8         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
9         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
10         (WTR::InjectedBundle::initialize): Activate fonts on startup.
11         * WebKitTestRunner/InjectedBundle/mac: Added.
12         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
13         (WTR::activateFonts): Activate our fonts.
14         * WebKitTestRunner/InjectedBundle/win: Added.
15         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
16         (WTR::activateFonts): Dummy version.
17         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
18         add more files.
19         * WebKitTestRunner/fonts: Added.
20         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
21         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
22         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
23         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
24         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
25         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
26         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
27         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
28         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
29         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
30         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
31         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
32         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
33         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
34
35 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
36
37         Reviewed by Eric Seidel.
38
39         Remove check-header-includes, as it didn't turn out to be very useful.
40         https://bugs.webkit.org/show_bug.cgi?id=41970
41
42         * Scripts/check-header-includes: Removed.
43
44 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
45
46         Reviewed by Maciej Stachowiak.
47
48         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
49         https://bugs.webkit.org/show_bug.cgi?id=40922
50         
51         Always build WebKit2 on Windows. Necessary since our WebKit build on
52         Windows is packaged into a DLL with WebKit2.
53
54         * Scripts/build-webkit: Always build WebKit2 on Windows.
55
56 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
57
58         Reviewed by Steve Falkenburg.
59
60         One http test timing out on Windows can cause all future tests to time out
61         https://bugs.webkit.org/show_bug.cgi?id=42146
62         
63         There have been multiple times on the Windows bots where one http test timing out causes all future
64         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
65         times out, we should restart httpd on Cygwin to prevent this.
66
67         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
68         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
69             using kill fails.
70
71 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
72
73         Reviewed by Dan Bernstein.
74
75         Remove use of auto_ptr in WebKitTestRunner
76         https://bugs.webkit.org/show_bug.cgi?id=42134
77         
78         Replaced auto_ptr with PassOwnPtr / OwnPtr.
79
80         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
81         (WTR::WKStringToUTF8):
82         (WTR::InjectedBundlePage::dump):
83         (WTR::InjectedBundlePage::addMessageToConsole):
84         * WebKitTestRunner/TestInvocation.cpp:
85         (WTR::WKStringToUTF8):
86         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
87
88 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
89
90         Reviewed by Sam Weinig.
91
92         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
93         https://bugs.webkit.org/show_bug.cgi?id=42132
94
95         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
96         platform directories.
97
98 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
99
100         Reviewed by Anders Carlsson.
101
102         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
103         https://bugs.webkit.org/show_bug.cgi?id=42126
104
105         * WebKitTestRunner/PlatformWebView.h:
106         * WebKitTestRunner/TestInvocation.cpp:
107         (WTR::TestInvocation::TestInvocation): Store the path as a C
108         string for later use.
109         (WTR::TestInvocation::~TestInvocation):
110         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
111         size, depending on whether this is a W3C SVG test.
112         (WTR::TestInvocation::invoke): Call the size function.
113         * WebKitTestRunner/TestInvocation.h:
114         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
115         (WTR::PlatformWebView::resizeTo): Implement.
116         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
117         (WTR::PlatformWebView::resizeTo): Placeholder.
118
119 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
120
121         Reviewed by Xan Lopez.
122
123         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
124         https://bugs.webkit.org/show_bug.cgi?id=38648
125
126         Add the GTK_MODULES envvar (set to "gail") to the clean
127         environment when running DRT for the Gtk+ port
128
129         * Scripts/old-run-webkit-tests:
130
131 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
132
133         Reviewed by Dirk Schulze.
134
135         [GTK] Support pixel tests
136         https://bugs.webkit.org/show_bug.cgi?id=31518
137
138         Finish support for pixel tests on GTK+.
139
140         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
141         works on CoreFoundation systems) and add missing cstdio include.
142         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
143         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
144         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
145         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
146         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
147         by the ANSI standard and this fails on Linux, so unroll the loop here.
148         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
149         (BitmapContext::BitmapContext): There is no reason to check the value of the
150         m_context member in the constructor and it certainly should not be freed. Instead
151         just initialize it with the incoming value.
152         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
153         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
154         dump pixels.
155         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
156         (createBitmapContextFromWebView):
157         * GNUmakefile.am: Add new files to the build.
158
159 2010-07-12  Adam Barth  <abarth@webkit.org>
160
161         Unreviewed.
162
163         Remove stray "raise e" that got included in a previous patch.  This
164         caused the EWS bots to turn red instead of purple when a patch failed
165         to apply.
166
167         * Scripts/webkitpy/tool/commands/stepsequence.py:
168
169 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
170
171         Unreviewed, rolling out r63101.
172         http://trac.webkit.org/changeset/63101
173         https://bugs.webkit.org/show_bug.cgi?id=42103
174
175         Broke one API test (Requested by xan_ on #webkit).
176
177         * Scripts/old-run-webkit-tests:
178
179 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
180
181         Reviewed by Adam Roben.
182
183         https://bugs.webkit.org/show_bug.cgi?id=13075
184         XMLHttpRequest with failed authentication should set status to 401
185
186         https://bugs.webkit.org/show_bug.cgi?id=6871
187         <rdar://problem/3363403> 401 error page is never shown
188
189         Fix crashes in Windows DumpRenderTree.
190
191         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
192         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
193         again on a destroyed sender.
194
195 2010-07-12  Adam Roben  <aroben@apple.com>
196
197         Windows failure-to-launch fix
198
199         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
200         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
201         we already do for CoreFoundation, CFNetwork, etc.
202
203 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
204
205         Reviewed by Xan Lopez.
206
207         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
208         https://bugs.webkit.org/show_bug.cgi?id=38648
209
210         Add the GTK_MODULES envvar (set to "gail") to the clean
211         environment when running DRT for the Gtk+ port
212
213         * Scripts/old-run-webkit-tests:
214
215 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
216
217         Reviewed by Darin Adler.
218
219         https://bugs.webkit.org/show_bug.cgi?id=13075
220         XMLHttpRequest with failed authentication should set status to 401
221
222         https://bugs.webkit.org/show_bug.cgi?id=6871
223         <rdar://problem/3363403> 401 error page is never shown
224
225         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
226         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
227         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
228         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
229         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
230         the Cancel button.
231
232 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
233
234         Reviewed by Tor Arne Vestbø.
235
236         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
237         https://bugs.webkit.org/show_bug.cgi?id=42082
238
239         * QtTestBrowser/main.cpp:
240         (LauncherWindow::createChrome):
241         * QtTestBrowser/mainwindow.cpp:
242         (MainWindow::openLocation):
243         * QtTestBrowser/mainwindow.h:
244
245 2010-07-12  Adam Roben  <aroben@apple.com>
246
247         Make the Python autoinstaller not use a dead SourceForge server
248
249         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
250         offline SourceForge server
251
252         Reviewed by Anders Carlsson.
253
254         * Scripts/webkitpy/thirdparty/__init__.py: Use
255         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
256         which seems to be down.
257
258 2010-07-12  Adam Roben  <aroben@apple.com>
259
260         Make run-webkit-tests print how many tests timed out when exiting
261         early
262
263         The number of timed-out tests is taken into account when deciding
264         whether to exit early. Leaving it out of the output just makes the
265         script look buggy (because it might say something like "Exiting early
266         after 0 crashes.").
267
268         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
269         messages when exiting early due to crashes and time-outs
270
271         Reviewed by Anders Carlsson.
272
273         * Scripts/old-run-webkit-tests:
274         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
275         timed-out tests, too.
276
277 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
278
279         Reviewed by Dan Bernstein.
280
281         Implement animation-related methods for WebKitTestRunner
282         https://bugs.webkit.org/show_bug.cgi?id=42053
283         
284         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
285         animation tests were hanging otherwise.
286
287         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
288         (WTR::LayoutTestController::numberOfActiveAnimations):
289         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
290         (WTR::numberOfActiveAnimationsCallback):
291         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
292         (WTR::LayoutTestController::staticFunctions):
293         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
294
295 2010-07-11  Daniel Bates  <dbates@rim.com>
296
297         Reviewed by David Kilzer.
298
299         Enable executable support for svn-apply and svn-unapply
300         https://bugs.webkit.org/show_bug.cgi?id=39409
301
302         Connect up the Git and SVN executable bit support in parseDiff() so that
303         executable bit changes are propagated via the returned diff hash to the
304         patch function in svn-apply and svn-unapply.
305
306         * Scripts/VCSUtils.pm:
307           - Modified parseDiff() to call parseSvnDiffProperties when
308             it finds the start of an SVN property change diff.
309           - Removed FIXME comment above parseSvnDiffProperties() since
310             it is now being used by parseDiff().
311           - Export method scmToggleExecutableBit() now that we added the
312             executableBitDelta hash key. (This should have been exported
313             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
314         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
315           - Updated results for:
316             "rename (with executable bit change)"
317               - Test value of executableBitDelta (now that we have support).
318             "SVN: binary file (isBinary true)"
319               - Remove the property change diff from svnConvertedText. We plan
320                 to remove svnConvertedText in the future. So, we decided
321                 against adding such support to any new code, such as the
322                 property parsing routines. Therefore, we do not keep SVN
323                 converted text for property change diffs.
324           - Added unit tests:
325             "SVN: file change diff with property change diff"
326             "SVN: file change diff, followed by property change diff on different file"
327             "SVN: property diff, followed by file change diff"
328             "SVN: copied file with property change"
329             "SVN: two consecutive property diffs"
330             "SVN: binary file with executable bit change"
331             "SVN: binary file followed by property change on different file"
332             "SVN: binary file followed by file change on different file"
333             "SVN: file change diff with property change, followed by property change diff"
334             "SVN: file change diff with property change, followed by file change diff"
335
336 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
337
338         Reviewed by Dan Bernstein.
339
340         Implement waitUntilDone and notifyDone for WebKitTestRunner
341         https://bugs.webkit.org/show_bug.cgi?id=42049
342
343         With this fix, most of the DOM tests pass.
344         
345         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
346         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
347         a great way to do it in the future case where we may get multiple
348         pages - we really need a way to send it over from the ui process.
349         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
350         (WTR::InjectedBundle::page): A way to get the main page.
351         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
352         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
353         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
354         are loading.
355         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
356         called by the layout test controller. Also, cancel any pending watchdogs.
357         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
358         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
359         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
360         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
361         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
362         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
363         to false.
364         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
365         the watchdog.
366         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
367         (WTR::LayoutTestController::setWaitToDump): Set the flag.
368         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
369         where waitUntilDone times out.
370         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
371         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
372         (WTR::notifyDoneCallback): JS glue for notifyDone.
373         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
374         to the layoutController.
375         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
376         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
377
378 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
379
380         Rubber-stamped by Dan Bernstein.
381
382         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
383         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
384         slow down the tests).
385
386         * Scripts/webkitpy/common/system/executive.py:
387
388 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
389
390         Reviewed by Kenneth Rohde Christiansen.
391
392         [Qt] Mac build fix
393         https://bugs.webkit.org/show_bug.cgi?id=41967
394
395         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
396
397         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
398
399 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
400
401         Reviewed by Antonio Gomes.
402
403         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
404         https://bugs.webkit.org/show_bug.cgi?id=41966
405
406         * MiniBrowser/qt/BrowserWindow.cpp:
407         (BrowserWindow::BrowserWindow):
408
409 2010-07-09  Leon Clarke  <leonclarke@google.com>
410
411         Reviewed by Adam Barth.
412
413         add support for link prefetching
414         https://bugs.webkit.org/show_bug.cgi?id=3652
415
416         * Scripts/build-webkit:
417
418 2010-07-09  Ojan Vafai  <ojan@chromium.org>
419
420         Reviewed by Adam Barth.
421
422         r63004 broke some python tests
423         https://bugs.webkit.org/show_bug.cgi?id=42007
424
425         AbstractStep now checks options.no_squash and options.squash, so
426         they needed to have real values. Mock would return an object for those,
427         which would then act as if the values were True.
428
429         * Scripts/webkitpy/tool/commands/commandtest.py:
430         * Scripts/webkitpy/tool/commands/download_unittest.py:
431         * Scripts/webkitpy/tool/commands/stepsequence.py:
432         * Scripts/webkitpy/tool/commands/upload_unittest.py:
433         * Scripts/webkitpy/tool/mocktool.py:
434         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
435         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
436         * Scripts/webkitpy/tool/steps/steps_unittest.py:
437         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
438         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
439
440 2010-07-09  Ojan Vafai  <ojan@chromium.org>
441
442         Reviewed by Adam Barth.
443
444         --squash should go away and become the default
445         https://bugs.webkit.org/show_bug.cgi?id=39624
446
447         If there are local commits and working copy changes, then prompt the user
448         whether to continue. Setting git config webkit-patch.commit_should_always_squash
449         true bypasses the prompt.
450
451         --git-commit=HEAD.. operates on working copy changes only.
452         --git-commit=committish operates on a range of commits as a single commit.
453             e.g. --git-commit=HEAD only operates on the HEAD commit.
454             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
455
456         --no-squash and --squash are left in with descriptive error messages if used.
457
458         * Scripts/check-webkit-style:
459         * Scripts/webkitpy/common/checkout/api.py:
460         * Scripts/webkitpy/common/checkout/api_unittest.py:
461         * Scripts/webkitpy/common/checkout/scm.py:
462         * Scripts/webkitpy/common/checkout/scm_unittest.py:
463         * Scripts/webkitpy/common/net/rietveld.py:
464         * Scripts/webkitpy/common/system/user.py:
465         * Scripts/webkitpy/style/optparser.py:
466         * Scripts/webkitpy/style_references.py:
467         * Scripts/webkitpy/tool/commands/download.py:
468         * Scripts/webkitpy/tool/commands/upload.py:
469         * Scripts/webkitpy/tool/mocktool.py:
470         * Scripts/webkitpy/tool/steps/abstractstep.py:
471         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
472         * Scripts/webkitpy/tool/steps/checkstyle.py:
473         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
474         * Scripts/webkitpy/tool/steps/commit.py:
475         * Scripts/webkitpy/tool/steps/options.py:
476         * Scripts/webkitpy/tool/steps/preparechangelog.py:
477         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
478         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
479         * Scripts/webkitpy/tool/steps/validatereviewer.py:
480
481 2010-07-09  Mark Rowe  <mrowe@apple.com>
482
483         Add two new Windows test build slaves.
484
485         * BuildSlaveSupport/build.webkit.org-config/config.json:
486
487 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
488
489         Reviewed by David Levin.
490
491         rebaseline_chromium_webkit_tests missing --use_drt option on linux
492         https://bugs.webkit.org/show_bug.cgi?id=41985
493
494         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
495         so that it works on linux. This is essentially a "compile-fix" for the
496         script.
497
498         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
499
500 2010-07-09  Nico Weber  <thakis@chromium.org>
501
502         Unreviewed. Adding myself as committer.
503
504         * Scripts/webkitpy/common/config/committers.py:
505
506 2010-07-09  David Kilzer  <ddkilzer@apple.com>
507
508         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
509
510         This reverts commit r62692.
511
512         * Scripts/commit-log-editor:
513
514 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
515
516         Reviewed by Ojan Vafai.
517
518         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
519         https://bugs.webkit.org/show_bug.cgi?id=38693
520
521         Introduced a new base class JSONResultsGeneratorBase that doesn't
522         have any dependency on layout_tests packages.
523         Turned JSONResultsGenerator into a wrapper class of the base class
524         so that the old code can work with it during the cleanup.
525
526         Added json_results_generator_unittest.py.
527
528         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
529         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
530         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
531
532 2010-07-09  Abhishek Arya  <inferno@chromium.org>
533
534         Unreviewed.
535
536         Marking myself as a committer.
537
538         * Scripts/webkitpy/common/config/committers.py:
539
540 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
541
542         Reviewed by Antti Koivisto.
543
544         Implement MiniBrowser for Qt.
545         https://bugs.webkit.org/show_bug.cgi?id=40233
546
547         * MiniBrowser/qt/BrowserWindow.cpp: Added.
548         (createNewPage):
549         (BrowserView::BrowserView):
550         (BrowserView::resizeEvent):
551         (BrowserView::load):
552         (BrowserView::view):
553         (BrowserWindow::BrowserWindow):
554         (BrowserWindow::load):
555         (BrowserWindow::changeLocation):
556         (BrowserWindow::~BrowserWindow):
557         * MiniBrowser/qt/BrowserWindow.h: Added.
558         (BrowserView::~BrowserView):
559         * MiniBrowser/qt/MiniBrowser.pro: Added.
560         * MiniBrowser/qt/main.cpp: Added.
561         (main):
562
563 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
564
565         Reviewed by Simon Hausmann.
566
567         Introduce the Qt autotest launcher.
568
569         Qt autotests should be executed more frequently, ideally by the Qt
570         build bot. This is the first step to provide the tests more accessible.
571
572         [Qt] It should be easier to run all Qt's autotests.
573         https://bugs.webkit.org/show_bug.cgi?id=31625
574
575         * Scripts/run-qtwebkit-tests: Added.
576
577 2010-07-09  Adam Barth  <abarth@webkit.org>
578
579         Reviewed by Eric Seidel.
580
581         commit-queue should merge to TOT when checkout needs update
582         https://bugs.webkit.org/show_bug.cgi?id=41944
583
584         There are a bunch of different designs that are possible here.  This
585         one merges to top of tree by cleaning out the working copy and
586         re-applying the patch.  Once you decide to merge that way, you need to
587         decide who's going to retry.  In this patch, we retry in the child
588         process instead of plumbing the failure reason to the master process.
589
590         This patch is difficult to test end-to-end, but hopefully it will work.
591         :)
592
593         * Scripts/webkitpy/tool/commands/queues.py:
594         * Scripts/webkitpy/tool/commands/stepsequence.py:
595         * Scripts/webkitpy/tool/multicommandtool.py:
596         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
597
598 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
599
600         Reviewed by Darin Adler.
601
602         Add a script to check for unnecessary includes in header files.
603         https://bugs.webkit.org/show_bug.cgi?id=41894
604
605         * Scripts/check-header-includes: Added.
606
607 2010-07-09  Adam Barth  <abarth@webkit.org>
608
609         Reviewed by Eric Seidel.
610
611         Add --html5-treebuilder option to run-webkit-tests
612         https://bugs.webkit.org/show_bug.cgi?id=41922
613
614         We're down to one or two regressions in the HTML5lib test suite.  It's
615         getting to be time to look at fixing LayoutTests.
616
617         * Scripts/old-run-webkit-tests:
618
619 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
620
621         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
622         in the drawing model never getting set on Tiger.
623
624         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
625         (NPP_New):
626
627 2010-07-08  Aaron Boodman  <aa@chromium.org>
628
629         Reviewed by Timothy Hatcher.
630
631         Add the ability for user scripts and user styles to affect just the top frame.
632
633         https://bugs.webkit.org/show_bug.cgi?id=41529
634
635         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
636         * DumpRenderTree/LayoutTestController.cpp: Ditto.
637         (addUserScriptCallback):
638         (addUserStyleSheetCallback):
639         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
640         (LayoutTestController::addUserScript):
641         (LayoutTestController::addUserStyleSheet):
642         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
643         (LayoutTestController::addUserScript):
644         (LayoutTestController::addUserStyleSheet):
645         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
646         (LayoutTestController::addUserScript):
647         (LayoutTestController::addUserStyleSheet):
648         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
649         (LayoutTestController::addUserScript):
650         (LayoutTestController::addUserStyleSheet):
651         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
652         (LayoutTestController::addUserScript):
653         (LayoutTestController::addUserStyleSheet):
654
655 2010-07-08  Adele Peterson  <adele@apple.com>
656
657         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
658
659         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
660         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
661
662         Log when the missing plugin button is pressed.
663
664         * DumpRenderTree/mac/UIDelegate.mm:
665         (-[UIDelegate webView:didPressMissingPluginButton:]):
666         * DumpRenderTree/win/UIDelegate.cpp:
667         (UIDelegate::QueryInterface):
668         (UIDelegate::createWebViewWithRequest):
669         (UIDelegate::drawBackground):
670         (UIDelegate::decidePolicyForGeolocationRequest):
671         (UIDelegate::didPressMissingPluginButton):
672         * DumpRenderTree/win/UIDelegate.h:
673
674 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
675
676         Fix the Tiger build.
677
678         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
679         (NPP_New):
680
681 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
682
683         Fix windows build.
684
685         #ifdef code for Mac.
686
687         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
688         (NPP_New):
689
690 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
691
692         Reviewed by Anders Carlsson.
693
694         Allow the TestPlugin to use Core Animation rendering for testing
695         https://bugs.webkit.org/show_bug.cgi?id=41872
696         
697         Add the ability for the TestPlugin to use the CoreAnimation rendering model
698         when available, based on the "drawingmodel" attribute of the embed tag:
699             drawingmodel="coreanimation"
700
701         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
702         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
703         when building on Tiger. Add a void* coreAnimationLayer member.
704         
705         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
706         (createCoreAnimationLayer): Obj-C method to create the CALayer.
707         
708         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
709         (NPP_New): Look for the drawingmodel attribute to decide which drawing
710         model to use.
711         (NPP_Destroy): Release the CALayer if we have one.
712         (NPP_GetValue): Return the retained CALayer.
713
714 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
715
716         Reviewed by Xan Lopez.
717
718         [GTK] Support pixel tests
719         https://bugs.webkit.org/show_bug.cgi?id=31518
720
721         Convert this file from CRLF to NL line endings. It will soon
722         be used on more than just the WinCairo platform.
723
724         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
725         (writeFunction):
726         (printPNG):
727         (computeMD5HashStringForBitmapContext):
728         (dumpBitmap):
729
730 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
731
732         Reviewed by Darin Adler.
733
734         Enable Data Execution Prevention for our test harnesses on Windows
735         https://bugs.webkit.org/show_bug.cgi?id=41882
736
737         * DumpRenderTree/win/DumpRenderTree.vcproj:
738         * DumpRenderTree/win/ImageDiff.vcproj:
739         * WebKitAPITest/WebKitAPITest.vcproj:
740         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
741
742 2010-07-07  Robert Hogan  <robert@webkit.org>
743
744         Reviewed by Kenneth Rohde Christiansen.
745
746         [Qt] Add DRT support for pageProperty etc.
747
748         https://bugs.webkit.org/show_bug.cgi?id=41584
749
750         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
751         (LayoutTestController::isPageBoxVisible):
752         (LayoutTestController::pageSizeAndMarginsInPixels):
753         (LayoutTestController::pageProperty):
754         (LayoutTestController::addUserStyleSheet):
755         * DumpRenderTree/qt/LayoutTestControllerQt.h:
756
757 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
758
759         Reviewed by Xan Lopez.
760
761         Remove a warnings from the ImageDiff build by using the proper
762         printf format string for the gsize data type.
763
764         * DumpRenderTree/gtk/ImageDiff.cpp:
765         (printImage): Use the proper printf format string for the gsize data type.
766
767 2010-07-08  Alice Liu  <alice.liu@apple.com>
768
769         Reviewed by Sam Weinig.
770
771         https://bugs.webkit.org/show_bug.cgi?id=41653
772         Add new WebKitTestRunner project for Windows
773
774         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
775         Similar to how it's done in DumpRenderTree, define max and min early
776         on so that they don't get replaced by a macro requiring 2 arguments.
777
778         * WebKitTestRunner/win: Added.
779         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
780         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
781         * WebKitTestRunner/win/main.cpp: Added.
782         (main): Implemented
783
784         Added these files with stubbed out functions:
785         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
786         (WTR::PlatformWebView::PlatformWebView):
787         (WTR::PlatformWebView::~PlatformWebView):
788         (WTR::PlatformWebView::page):
789         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
790         (WTR::TestController::initializeInjectedBundlePath):
791         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
792         (WTR::TestInvocation::runUntil):
793
794 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
795
796         Reviewed by Gustavo Noronha Silva.
797
798         [GTK] Implement ImageDiff and add it to the build system
799         https://bugs.webkit.org/show_bug.cgi?id=41779
800
801         Add the initial implementation of the ImageDiff tool for the GTK+
802         port. This is an essential tool for doing pixel tests. The implementation
803         is based on the Mac and Chromium ports.
804
805         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
806         (readPixbufFromStdin): Added.
807         (differenceImageFromDifferenceBuffer): Ditto.
808         (calculateDifference): Ditto.
809         (printImage): Ditto.
810         (printImageDifferences): Ditto.
811         (main): Ditto.
812         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
813
814 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
815
816         Unreviewed. Adding myself as a committer.
817
818         * Scripts/webkitpy/common/config/committers.py:
819
820 2010-07-08  Adam Roben  <aroben@apple.com>
821
822         Make Windows stop running tests from platform/mac
823
824         r62742 made a change (at my suggestion!) that caused us to start
825         looking for tests in platform/mac, rather than just looking for
826         expected results in platform/mac. This patch just undoes that part of
827         r62742.
828
829         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
830         tests from platform/mac, but shouldn't
831
832         Reviewed by Antti Koivisto and Anders Carlsson.
833
834         * Scripts/old-run-webkit-tests:
835         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
836         so we won't look in those directories for tests to run.
837         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
838         platform/mac-snowleopard and platform/mac for expected results.
839
840 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
841
842         Unreviewed. Adding myself as a reviewer.
843
844         * Scripts/webkitpy/common/config/committers.py:
845
846 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
847
848         Update my e-mail in committers.py
849
850         * Scripts/webkitpy/common/config/committers.py:
851
852 2010-07-07  Daniel Bates  <dbates@rim.com>
853
854         Reviewed by Dumitru Daniliuc.
855
856         VCSUtils.pm complains about uninitialized value $newLine
857         https://bugs.webkit.org/show_bug.cgi?id=41333
858
859         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
860         an array when fixing a change log entry that overlaps with an earlier
861         entry. In particular, when a patch contains a change log entry inserted
862         earlier in the change log file, but after an entry with the same author
863         and date.
864
865         * Scripts/VCSUtils.pm:
866             - Added for-loop constraint to fixChangeLogPatch() so that it does not
867               read off the end of the @overlappingLines array.
868         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
869
870 2010-07-07  Anders Carlsson  <andersca@apple.com>
871
872         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
873
874         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
875         (NPP_New):
876
877 2010-07-07  Kent Tamura  <tkent@chromium.org>
878
879         Reviewed by Adam Barth.
880
881         [DRT/Chromium] Support for indeterminate checkbox
882         https://bugs.webkit.org/show_bug.cgi?id=41747
883
884         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
885
886         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
887         (WebThemeControlDRT::draw):
888         * DumpRenderTree/chromium/WebThemeControlDRT.h:
889         (WebThemeControlDRT::):
890         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
891         (WebThemeEngineDRT::paintButton):
892
893 2010-07-07  Sam Weinig  <sam@webkit.org>
894
895         Reviewed by Mark Rowe.
896
897         Clean up MiniBrowser Xcode project.
898
899         - Use xcconfig files.
900         - Rename plists to canonical Info.plist
901         - Remove localizations.
902
903         * MiniBrowser/Configurations: Added.
904         * MiniBrowser/Configurations/Base.xcconfig: Added.
905         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
906         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
907         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
908         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
909         * MiniBrowser/WebBundle-Info.plist: Removed.
910         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
911         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
912         * MiniBrowser/mac/BrowserWindow.xib: Added.
913         * MiniBrowser/mac/BrowserWindowController.m:
914         (-[BrowserWindowController initWithPageNamespace:]):
915         * MiniBrowser/mac/English.lproj: Removed.
916         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
917         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
918         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
919         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
920         * MiniBrowser/mac/MainMenu.xib: Added.
921         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
922         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
923
924 2010-07-07  Kent Tamura  <tkent@chromium.org>
925
926         Reviewed by Dimitri Glazkov.
927
928         [DRT/Chromium] Fix two regressions
929         https://bugs.webkit.org/show_bug.cgi?id=41745
930
931         * DumpRenderTree/chromium/WebViewHost.cpp:
932         (WebViewHost::paintInvalidatedRegion):
933          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
934          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
935          though test_shell does it twice. Probably DRT needs it because
936          DRT delays painting as possible.
937
938 2010-07-07  Anders Carlsson  <andersca@apple.com>
939
940         Try to fix build.
941
942         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
943         (webkit_test_plugin_destroy_stream):
944
945 2010-07-07  Anders Carlsson  <andersca@apple.com>
946
947         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
948
949         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
950         (webkit_test_plugin_new_stream):
951         (webkit_test_plugin_destroy_stream):
952         (webkit_test_plugin_write_ready):
953         (webkit_test_plugin_write):
954
955 2010-07-07  Sam Weinig  <sam@webkit.org>
956
957         Reviewed by Mark Rowe.
958
959         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
960
961         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
962
963 2010-07-07  Anders Carlsson  <andersca@apple.com>
964
965         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
966
967         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
968         (NPP_New):
969         (NPP_HandleEvent):
970
971 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
972
973         Reviewed by Adam Roben.
974
975         Need to have a way to specify different results for Windows XP and 7
976         https://bugs.webkit.org/show_bug.cgi?id=41776
977         
978         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
979         subdirectories, so we can have different results for tests on Windows XP, Windows
980         Vista, and Windows 7.
981
982         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
983         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
984         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
985
986         This matches the behavior of the mac.
987
988         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
989             or Vista, try looking in other win-* subdirectories before win.
990         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
991             we are running.
992
993 2010-07-07  Kent Tamura  <tkent@chromium.org>
994
995         Reviewed by Dimitri Glazkov.
996
997         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
998         https://bugs.webkit.org/show_bug.cgi?id=41753
999
1000         The original code of the following functions in
1001         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
1002         ASSERT_NOT_REACHED(). The program shouldn't stop at these
1003         functions.
1004
1005         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1006         (DRTDevToolsClient::activateWindow):
1007         (DRTDevToolsClient::closeWindow):
1008         (DRTDevToolsClient::dockWindow):
1009         (DRTDevToolsClient::undockWindow):
1010
1011 2010-07-07  Anders Carlsson  <andersca@apple.com>
1012
1013         Reviewed by Sam Weinig.
1014
1015         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
1016         https://bugs.webkit.org/show_bug.cgi?id=41821
1017
1018         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1019         (pluginGetProperty):
1020         (pluginSetProperty):
1021         (pluginAllocate):
1022         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1023         Add and initialize the returnNegativeOneFromWrite property.
1024
1025         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1026         (NPP_NewStream):
1027         Set the stream type to NP_NORMAL so we'll get write callbacks.
1028
1029         (NPP_DestroyStream):
1030         Treat the onstreamdestroy attribute as a function name and not a string.
1031
1032         (NPP_WriteReady):
1033         Have this return a nonzero value.
1034
1035         (NPP_Write):
1036         If returnNegativeOneFromWrite is true return -1.
1037
1038 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1039
1040         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
1041         latest version is selected by default, and allows the version to be specified.
1042
1043         * wx/build/settings.py:
1044
1045 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
1046
1047         Reviewed by Darin Adler.
1048
1049         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
1050         https://bugs.webkit.org/show_bug.cgi?id=41810
1051
1052         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1053         (AccessibilityUIElement::selectedTextRange):
1054
1055 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
1056
1057         Unreviewed.
1058
1059         Build fix after r62700.
1060
1061         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
1062         source file locations.
1063
1064 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1065
1066         Reviewed by David Levin.
1067
1068         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
1069         https://bugs.webkit.org/show_bug.cgi?id=41814
1070
1071         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1072         * Scripts/old-run-webkit-tests:
1073
1074 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1075
1076         Reviewed by David Levin.
1077
1078         add --exit-after-n-crashes to run-webkit-tests
1079         https://bugs.webkit.org/show_bug.cgi?id=41811
1080
1081         Change the bots at build.webkit.org to use --exit-after-n-crashes
1082         instead of --exit-after-n-failures since we want to be able to have
1083         more than 20 failures on those bots, but more than 20 crashes means
1084         something should be rolled out.
1085
1086         * Scripts/old-run-webkit-tests:
1087         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1088
1089 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1090
1091         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
1092         TestNetscapePlugin project, because this was removed from the tree.
1093
1094         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1095
1096 2010-07-07  Anders Carlsson  <andersca@apple.com>
1097
1098         Reviewed by Simon Fraser.
1099
1100         Unify Mac and Windows TestNetscapePlugin main.cpp files
1101         https://bugs.webkit.org/show_bug.cgi?id=41798
1102         
1103         * DumpRenderTree/DumpRenderTree.sln:
1104         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1105         (strcasecmp):
1106         (NP_Initialize):
1107         (NP_GetEntryPoints):
1108         (NP_Shutdown):
1109         (NPP_New):
1110         (NPP_Destroy):
1111         (NPP_HandleEvent):
1112         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1113         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
1114
1115 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1116
1117         [wx] Build fix. pageProperty needs to return a value.
1118
1119         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1120         (LayoutTestController::pageProperty):
1121
1122 2010-07-07  David Kilzer  <ddkilzer@apple.com>
1123
1124         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
1125
1126         Reviewed by Anders Carlsson.
1127
1128         For both svn and git, commit-log-editor is invoked from the root
1129         of the working directory.  Unlike svn, git returns a list of
1130         changed files that are relative to the directory where the
1131         command was invoked.  This caused the ChangeLog file in the root
1132         directory to be read instead of the ChangeLog in the current
1133         directory.
1134
1135         The fix is to use $ENV{PWD} as the base directory when fixing
1136         the path to the ChangeLog files.  With svn, this has no net
1137         effect since $ENV{PWD} is the root of the working directory and
1138         the ChangeLog paths are already relative to that directory.
1139         With git, $ENV{PWD} is the directory that the commit was invoked
1140         from, which fixes the ChangeLog paths so that the correct files
1141         are read when creating the commit log entry.
1142
1143         Note that the call to makeFilePathRelative() was supposed to
1144         address this issue, but it doesn't because (a) it does nothing
1145         with svn working directories by design, and (b) it does nothing
1146         with git working directories because it's invoked when the
1147         current directory is the root of the working directory, thus
1148         giving no relative path.
1149
1150         * Scripts/commit-log-editor: Removed call to
1151         makeFilePathRelative() since since it does nothing.  Moved code
1152         to fix up $changeLog path so that it's fixed before trying to
1153         open the file, and use $ENV{PWD} as the base path.  Also use
1154         canonicalizePath() to clean up paths with "../" in them.
1155
1156 2010-07-07  Anders Carlsson  <andersca@apple.com>
1157
1158         Another attempt at fixing the Qt build.
1159
1160         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1161
1162 2010-07-07  Anders Carlsson  <andersca@apple.com>
1163
1164         Try to fix Qt build.
1165
1166         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1167
1168 2010-07-07  Anders Carlsson  <andersca@apple.com>
1169
1170         Reviewed by Simon Fraser.
1171
1172         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
1173         https://bugs.webkit.org/show_bug.cgi?id=41781
1174
1175         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1176         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
1177         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
1178         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
1179         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
1180         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
1181         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
1182         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
1183         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
1184         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
1185         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
1186         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
1187         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
1188
1189 2010-07-07  Andras Becsi  <abecsi@webkit.org>
1190
1191         Unreviewed trivial fix.
1192
1193         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
1194         which was checked in accidentally in r62635.
1195
1196         * Scripts/webkitpy/layout_tests/port/webkit.py:
1197
1198 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1199
1200         Reviewed by Eric Seidel.
1201
1202         Pass port specific environment to server process.
1203         https://bugs.webkit.org/show_bug.cgi?id=41593
1204
1205         * Scripts/webkitpy/layout_tests/port/qt.py:
1206         * Scripts/webkitpy/layout_tests/port/webkit.py:
1207
1208 2010-07-06  Kent Tamura  <tkent@chromium.org>
1209
1210         Reviewed by Shinichiro Hamaji.
1211
1212         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
1213         https://bugs.webkit.org/show_bug.cgi?id=41644
1214
1215         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
1216         tolerance. We don't need tolerance for rebaseline.
1217
1218         * Scripts/webkitpy/layout_tests/port/base.py:
1219           Add optional tolerance parameter to diff_image().
1220         * Scripts/webkitpy/layout_tests/port/test.py:
1221           Add optional tolerance parameter to diff_image().
1222         * Scripts/webkitpy/layout_tests/port/webkit.py:
1223           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
1224         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1225           diff_files() always calls diff_image() with tolerance=0.
1226           diff_files() is used only by rebaseline-chromium-webkit-tests.
1227
1228 2010-07-06  Sam Weinig  <sam@webkit.org>
1229
1230         Fix MiniBrowser build.
1231
1232         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1233
1234 2010-07-06  Sam Weinig  <sam@webkit.org>
1235
1236         Reviewed by Anders Carlsson.
1237
1238         Add support for dumping the contents of messages to the console to WebKitTestRunner
1239
1240         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1241         (WTR::InjectedBundlePage::InjectedBundlePage):
1242         (WTR::InjectedBundlePage::_addMessageToConsole):
1243         (WTR::InjectedBundlePage::addMessageToConsole):
1244         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1245
1246 2010-07-06  Sam Weinig  <sam@webkit.org>
1247
1248         Reviewed by Anders Carlsson.
1249
1250         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
1251         Add dumpAsText support for WebKitTestRunner
1252
1253         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1254         (WTR::InjectedBundle::InjectedBundle):
1255         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
1256         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1257         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
1258         API to dump the main frames text.
1259
1260 2010-07-06  Darin Adler  <darin@apple.com>
1261
1262         Fix Chromium build.
1263
1264         * DumpRenderTree/chromium/WebViewHost.cpp:
1265         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
1266         (WebViewHost::didNavigateWithinPage): Ditto.
1267         (WebViewHost::updateURL): Ditto.
1268
1269 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
1270
1271         Reviewed by Xan Lopez.
1272
1273         [GTK] build-webkit should not run autogen.sh unconditionally
1274         https://bugs.webkit.org/show_bug.cgi?id=41704
1275
1276         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
1277         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
1278         some very minor cleanup.
1279
1280 2010-07-06  Darin Adler  <darin@apple.com>
1281
1282         Try to fix Chromium build.
1283
1284         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
1285
1286 2010-07-06  Darin Adler  <darin@apple.com>
1287
1288         Fix build.
1289
1290         * WebKitAPITest/TestsController.cpp:
1291         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
1292
1293 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
1294
1295         Reviewed by Kent Tamura.
1296
1297         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
1298         https://bugs.webkit.org/show_bug.cgi?id=40558
1299
1300         Upstream DevTools for Chromium DRT.
1301         (original Chromium files rev. 51287)
1302
1303         * DumpRenderTree/DumpRenderTree.gypi:
1304         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
1305         (DRTDevToolsAgent::DRTDevToolsAgent):
1306         (DRTDevToolsAgent::setWebView):
1307         (DRTDevToolsAgent::sendMessageToFrontend):
1308         (DRTDevToolsAgent::forceRepaint):
1309         (DRTDevToolsAgent::runtimeFeatureStateChanged):
1310         (DRTDevToolsAgent::injectedScriptSource):
1311         (DRTDevToolsAgent::injectedScriptDispatcherSource):
1312         (DRTDevToolsAgent::debuggerScriptSource):
1313         (DRTDevToolsAgent::asyncCall):
1314         (DRTDevToolsAgent::call):
1315         (DRTDevToolsAgent::webDevToolsAgent):
1316         (DRTDevToolsAgent::attach):
1317         (DRTDevToolsAgent::detach):
1318         (DRTDevToolsAgent::setTimelineProfilingEnabled):
1319         (DRTDevToolsAgent::evaluateInWebInspector):
1320         (DRTDevToolsAgent::dispatchMessageLoop):
1321         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
1322         (DRTDevToolsAgent::~DRTDevToolsAgent):
1323         (DRTDevToolsAgent::hostIdentifier):
1324         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
1325         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1326         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1327         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
1328         (DRTDevToolsCallArgs::callsCount):
1329         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
1330         (DRTDevToolsClient::DRTDevToolsClient):
1331         (DRTDevToolsClient::~DRTDevToolsClient):
1332         (DRTDevToolsClient::sendMessageToAgent):
1333         (DRTDevToolsClient::sendDebuggerCommandToAgent):
1334         (DRTDevToolsClient::activateWindow):
1335         (DRTDevToolsClient::closeWindow):
1336         (DRTDevToolsClient::dockWindow):
1337         (DRTDevToolsClient::undockWindow):
1338         (DRTDevToolsClient::asyncCall):
1339         (DRTDevToolsClient::call):
1340         (DRTDevToolsClient::allMessagesProcessed):
1341         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1342         * DumpRenderTree/chromium/EventSender.cpp:
1343         * DumpRenderTree/chromium/LayoutTestController.cpp:
1344         (LayoutTestController::LayoutTestController):
1345         (LayoutTestController::closeWebInspector):
1346         (LayoutTestController::setTimelineProfilingEnabled):
1347         (LayoutTestController::evaluateInWebInspector):
1348         * DumpRenderTree/chromium/LayoutTestController.h:
1349         * DumpRenderTree/chromium/TestShell.cpp:
1350         (TestShell::TestShell):
1351         (TestShell::~TestShell):
1352         (TestShell::createDRTDevToolsClient):
1353         (TestShell::showDevTools):
1354         (TestShell::closeDevTools):
1355         (TestShell::runFileTest):
1356         (TestShell::createNewWindow):
1357         * DumpRenderTree/chromium/TestShell.h:
1358         (TestShell::drtDevToolsAgent):
1359         (TestShell::drtDevToolsClient):
1360         * DumpRenderTree/chromium/config.h:
1361
1362 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1363
1364         Reviewed by Eric Seidel.
1365
1366         Don't pass image hash to DRT when pixel tests are disabled.
1367         https://bugs.webkit.org/show_bug.cgi?id=41597
1368
1369         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1370
1371 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1372
1373         Reviewed by Eric Seidel.
1374
1375         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1376         https://bugs.webkit.org/show_bug.cgi?id=41612
1377
1378         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1379
1380 2010-07-05  Adam Barth  <abarth@webkit.org>
1381
1382         Reviewed by Eric Seidel.
1383
1384         We should be able to specify a bug to block for webkit-patch upload
1385         https://bugs.webkit.org/show_bug.cgi?id=41648
1386
1387         This will be useful for working on the HTML5 parser.
1388
1389         * Scripts/webkitpy/tool/steps/createbug.py:
1390         * Scripts/webkitpy/tool/steps/options.py:
1391
1392 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1393
1394         Reviewed by Oliver Hunt.
1395
1396         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1397         https://bugs.webkit.org/show_bug.cgi?id=41017
1398
1399         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1400         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1401
1402 2010-07-04  MORITA Hajime  <morrita@google.com>
1403
1404         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1405         https://bugs.webkit.org/show_bug.cgi?id=41589
1406
1407         * run() method can result non-utf-8 bytes, that causes utf-8
1408           decoding fail.  Fixed to disable decoding.
1409         * Fixed Git.find_checkout_root() to make a test pass.
1410
1411         * Scripts/webkitpy/common/checkout/scm.py:
1412         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1413
1414 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1415
1416         Reviewed by Simon Hausmann.
1417
1418         [Qt] Fix DumpRenderTree userStyleSheet handling.
1419         https://bugs.webkit.org/show_bug.cgi?id=41570
1420
1421         DumpRenderTree did only set the userStyleSheet at
1422         layoutTestController.setUserStyleSheetEnabled().
1423
1424         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1425         (LayoutTestController::reset):
1426         (LayoutTestController::setUserStyleSheetLocation):
1427         (LayoutTestController::setUserStyleSheetEnabled):
1428         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1429
1430 2010-07-03  Robert Hogan  <robert@webkit.org>
1431
1432         Reviewed by Kenneth Rohde Christiansen.
1433
1434         [Qt] support dumpChildFrameScrollPositions
1435
1436         https://bugs.webkit.org/show_bug.cgi?id=41088
1437
1438         Unskip:
1439
1440         http/tests/navigation/anchor-subframeload.html
1441         http/tests/navigation/relativeanchor-frames.html
1442
1443         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1444         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1445         (WebCore::DumpRenderTree::dump):
1446         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1447         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1448         (LayoutTestController::reset):
1449         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1450         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1451         (LayoutTestController::dumpChildFrameScrollPositions):
1452
1453 2010-07-02  Sam Weinig  <sam@webkit.org>
1454
1455         Reviewed by Anders Carlsson.
1456
1457         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1458
1459         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1460         * Scripts/debug-webkittestrunner: Removed.
1461         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1462         * Scripts/run-webkittestrunner: Removed.
1463
1464 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1465
1466         Reviewed by Steve Falkenburg.
1467
1468         Some http tests fail on Windows with Cygwin 1.7
1469         https://bugs.webkit.org/show_bug.cgi?id=41537
1470         
1471         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1472         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1473         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1474
1475         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1476         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1477             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1478
1479 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1480
1481         Reviewed by Gustavo Noronha Silva.
1482
1483         [GTK] Separate DerivedSources per-project
1484         https://bugs.webkit.org/show_bug.cgi?id=41109
1485
1486         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1487         allowing the tools to build as a side-effect. Now that the top-level directory
1488         is no longer in the list of JavaScriptCore includes, include it explicitly.
1489
1490         * GNUmakefile.am:
1491
1492 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1493
1494         Reviewed by Kenneth Rohde Christiansen.
1495
1496         [Qt] Make context menus show up in the right place in QTestBrowser
1497
1498         Context menus were shown at scene-relative coordinates for
1499         QGraphicsWebView while QMenu expects them to be global. The
1500         change to the QWidget case was to get rid of the mapToGlobal.
1501
1502         * QtTestBrowser/webview.cpp:
1503
1504 2010-07-01  Robert Hogan <robert@webkit.org>
1505
1506         Reviewed by Kenneth Rohde Christiansen.
1507
1508         [Qt] dump frames in ascending alphabetical order of title
1509
1510         https://bugs.webkit.org/show_bug.cgi?id=41261
1511
1512         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1513         (WebCore::dumpHistoryItem):
1514
1515 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1516
1517         Unreviewed. 
1518
1519         Fix the GTK+ build after r62278.
1520
1521         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1522         let them override the automatic CPU detection for autotools builds.
1523
1524 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1525
1526         Unreviewed.
1527
1528         Fix the Windows build after r62278.
1529
1530         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1531
1532 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1533
1534         Reviewed by Gustavo Noronha Silva.
1535
1536         [GTK] build-webkit does not detect the number of CPUs
1537         https://bugs.webkit.org/show_bug.cgi?id=41469
1538
1539         Pass the appropriate -j<#> flag to make when building autotools builds.
1540         This causes make to spawn that many number of child processes for doing
1541         parallel builds.
1542
1543         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1544         of CPUs. This makes the script work across more platforms.
1545         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1546         number of CPUs across several platforms. Use this new function to determine the appropriate
1547         arguments to pass to make for doing parallel builds with autotools build files.
1548
1549 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1550
1551         Rubber-stamped by Laszlo Gombos.
1552
1553         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1554
1555         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1556         and use the one from WebKit.pri instead.
1557
1558 2010-07-01  Adam Barth  <abarth@webkit.org>
1559
1560         Reviewed by Eric Seidel.
1561
1562         Promote webkit-patch land-safely to main help
1563         https://bugs.webkit.org/show_bug.cgi?id=41446
1564
1565         I've been using this command a bunch and recommending it to folks.  We
1566         should show it in main help as it's past the experimental phase.
1567
1568         * Scripts/webkitpy/tool/commands/upload.py:
1569
1570 2010-06-28  MORITA Hajime  <morrita@google.com>
1571
1572         Reviewed by Shinichiro Hamaji.
1573
1574         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1575         https://bugs.webkit.org/show_bug.cgi?id=38775
1576
1577         - Introduced SCM.show_head() and SCM.diff_for_file().
1578         - Replaced direct svn invocations with newly implement SCM methods.
1579
1580         * Scripts/webkitpy/common/checkout/scm.py:
1581         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1582         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1583
1584 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1585
1586         Reviewed by Sam Weinig.
1587
1588         Allow MiniBrowser to open local files
1589         https://bugs.webkit.org/show_bug.cgi?id=41104
1590
1591         Wire up the openDocument: message with an NSOpenPanel, so we can open
1592         local files.
1593         
1594         Also change the xib so that the window remembers its size.
1595         
1596         * MiniBrowser/mac/AppDelegate.m:
1597         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1598         (-[BrowserAppDelegate openDocument:]):
1599         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1600         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1601
1602 2010-06-30  Sam Weinig  <sam@webkit.org>
1603
1604         Rubber-stamped by Anders Carlsson.
1605
1606         Add debug-webkittestrunner and cleanup related scripts.
1607
1608         * Scripts/debug-webkittestrunner: Added.
1609         * Scripts/run-webkittestrunner:
1610         * Scripts/webkitdirs.pm:
1611
1612 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1613
1614         [wx] Build fix after recent changes to LayoutTestController.
1615
1616         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1617         (LayoutTestController::pageSizeAndMarginsInPixels):
1618
1619 2010-06-29  Sam Weinig  <sam@webkit.org>
1620
1621         Reviewed by Anders Carlsson.
1622
1623         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1624         Make WebKitTestRunner work with more than one test at a time.
1625
1626         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1627         where there is a single WKView and each test is run it, rather than
1628         the design I was using where each test got its own WKView.
1629
1630         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1631         (WTR::InjectedBundle::didRecieveMessage):
1632         (WTR::InjectedBundle::reset):
1633         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1634         * WebKitTestRunner/TestController.cpp:
1635         (WTR::TestController::initialize):
1636         (WTR::TestController::runTest):
1637         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1638         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1639         * WebKitTestRunner/TestController.h:
1640         (WTR::TestController::mainWebView):
1641         (WTR::TestController::pageNamespace):
1642         (WTR::TestController::context):
1643         * WebKitTestRunner/TestInvocation.cpp:
1644         (WTR::TestInvocation::TestInvocation):
1645         (WTR::TestInvocation::~TestInvocation):
1646         (WTR::TestInvocation::invoke):
1647         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1648         * WebKitTestRunner/TestInvocation.h:
1649
1650 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1651
1652         Reviewed by Laszlo Gombos.
1653
1654         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1655         https://bugs.webkit.org/show_bug.cgi?id=40446
1656
1657         We quickly run out of memory on Symbian when loading web pages. This is
1658         caused by the default heap size, which is not suited for a web browser.
1659
1660         This change bumps the max heap size to 32MB.
1661
1662         * QtTestBrowser/QtTestBrowser.pro:
1663
1664 2010-06-30  Eric Seidel  <eric@webkit.org>
1665
1666         Reviewed by Adam Barth.
1667
1668         webkit-patch land allow the user to continue even if the builders are red
1669         https://bugs.webkit.org/show_bug.cgi?id=41395
1670
1671         I don't think it's good that we've been teaching people
1672         to always pass --ignore-builders.  At least land is now
1673         useable w/o --ignore-builders.
1674
1675         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1676
1677 2010-06-29  Robert Hogan  <robert@webkit.org>
1678
1679         Reviewed by Kenneth Rohde Christiansen.
1680
1681         [Qt] support dumpResourceResponseMIMETypes
1682         https://bugs.webkit.org/show_bug.cgi?id=41260
1683
1684         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1685         (LayoutTestController::reset):
1686         (LayoutTestController::dumpResourceResponseMIMETypes):
1687         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1688
1689 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1690
1691         Reviewed by Kenneth Rohde Christiansen.
1692
1693         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1694         https://bugs.webkit.org/show_bug.cgi?id=41173
1695
1696         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1697         (WebCore::WebPage::setViewGeometry):
1698         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1699
1700 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1701
1702         Reviewed by Simon Hausmann.
1703
1704         [Qt] Deal with postEvent in case of graphics based DRT
1705         https://bugs.webkit.org/show_bug.cgi?id=41174
1706
1707         QGraphicsScene does not have a postEvent method, so make scene
1708         send the event, in case of graphics based DRT, and delete it after that.
1709
1710         * DumpRenderTree/qt/EventSenderQt.cpp:
1711         (EventSender::scheduleAsynchronousClick):
1712         (EventSender::replaySavedEvents):
1713         (EventSender::postEvent):
1714         * DumpRenderTree/qt/EventSenderQt.h:
1715
1716 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1717
1718         Reviewed by Kenneth Rohde Christiansen.
1719
1720         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1721         https://bugs.webkit.org/show_bug.cgi?id=41172
1722
1723         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1724         (WebCore::DumpRenderTree::switchFocus):
1725
1726 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1727
1728         Reviewed by Xan Lopez.
1729
1730         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1731         https://bugs.webkit.org/show_bug.cgi?id=40009
1732
1733         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1734         are used when returning those values, for coherency with other ports.
1735
1736         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1737         (AccessibilityUIElement::role):
1738         (AccessibilityUIElement::title):
1739         (AccessibilityUIElement::description):
1740
1741 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1742
1743         Unreviewed, rolling out r62106.
1744         http://trac.webkit.org/changeset/62106
1745         https://bugs.webkit.org/show_bug.cgi?id=41346
1746
1747         "Broke editing tests" (Requested by xan_ on #webkit).
1748
1749         * Scripts/old-run-webkit-tests:
1750
1751 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1752
1753         Reviewed by Xan Lopez.
1754
1755         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1756         https://bugs.webkit.org/show_bug.cgi?id=38648
1757
1758         Add the GTK_MODULES envvar (set to "gail") to the clean
1759         environment when running DRT for the Gtk+ port
1760
1761         * Scripts/old-run-webkit-tests:
1762
1763 2010-06-28  Adam Barth  <abarth@webkit.org>
1764
1765         Unreviewed.
1766
1767         Switch test-html5-parser back to using runner.html.
1768
1769         * Scripts/test-html5-parser:
1770
1771 2010-06-28  Adam Barth  <abarth@webkit.org>
1772
1773         Reviewed by Eric Seidel.
1774
1775         Restore webkit-runner.html for use with new tree builder
1776         https://bugs.webkit.org/show_bug.cgi?id=41317
1777
1778         For now, we just want to run webkit-runner when we test-html5-parser.
1779
1780         * Scripts/test-html5-parser:
1781
1782 2010-06-23  John Gregg  <johnnyg@google.com>
1783
1784         Reviewed by Kent Tamura.
1785
1786         add ENABLE_DIRECTORY_UPLOAD build support
1787         https://bugs.webkit.org/show_bug.cgi?id=41100
1788
1789         * Scripts/build-webkit:
1790
1791 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1792
1793         Rubber-stamped by Xan Lopez.
1794
1795         Update webkitdirs's knowledge of our library's name.
1796
1797         * Scripts/webkitdirs.pm:
1798
1799 2010-06-28  Sam Weinig  <sam@webkit.org>
1800
1801         Reviewed by Anders Carlsson.
1802
1803         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1804         Build up WebKitTestRunner output in the InjectedBundle
1805
1806         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1807         and sending it over postMessage when done, instead of using the async
1808         WKPageRenderTreeExternalRepresentation.
1809
1810         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1811         (WTR::InjectedBundle::done):
1812         (WTR::InjectedBundle::didRecieveMessage):
1813         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1814         (WTR::InjectedBundle::os):
1815         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1816         (WTR::WKStringToUTF8):
1817         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1818         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1819         * WebKitTestRunner/TestInvocation.cpp:
1820         (WTR::WKStringToUTF8):
1821         (WTR::TestInvocation::TestInvocation):
1822         (WTR::TestInvocation::invoke):
1823         (WTR::TestInvocation::initializeMainWebView):
1824         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1825         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1826         * WebKitTestRunner/TestInvocation.h:
1827
1828 2010-06-28  Robert Hogan  <robert@webkit.org>
1829
1830         Unreviewed, rolling out r62021.
1831         http://trac.webkit.org/changeset/62021
1832         https://bugs.webkit.org/show_bug.cgi?id=41261
1833
1834         Broke http/navigation tests among other
1835
1836         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1837         (WebCore::DumpRenderTree::dumpFramesAsText):
1838
1839 2010-06-28  Sam Weinig  <sam@webkit.org>
1840
1841         Reviewed by Anders Carlsson.
1842
1843         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1844         environment.
1845
1846         * Scripts/run-webkittestrunner: Added.
1847         * Scripts/webkitdirs.pm:
1848
1849 2010-06-28  Robert Hogan  <robert@webkit.org>
1850
1851         Reviewed by Kenneth Rohde Christiansen.
1852
1853         [Qt] dump frames in ascending alphabetical order of title
1854
1855         https://bugs.webkit.org/show_bug.cgi?id=41261
1856
1857         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1858         (WebCore::DumpRenderTree::dumpFramesAsText):
1859
1860 2010-06-28  Robert Hogan  <robert@webkit.org>
1861
1862         Reviewed by Kenneth Rohde Christiansen.
1863
1864         [Qt] dump bf history of child windows
1865
1866         https://bugs.webkit.org/show_bug.cgi?id=41266
1867
1868         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1869         (WebCore::DumpRenderTree::dumpBackForwardList):
1870         (WebCore::DumpRenderTree::dump):
1871         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1872
1873 2010-06-28  Sam Weinig  <sam@webkit.org>
1874
1875         Reviewed by Anders Carlsson.
1876
1877         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
1878         WebKit2: Add frame API for InjectedBundle code
1879
1880         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1881         (_didClearWindowForFrame):
1882
1883 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1884
1885         Reviewed by Kenneth Rohde Christiansen.
1886
1887         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1888         https://bugs.webkit.org/show_bug.cgi?id=38597
1889
1890         Fix behavior so reload button really acts as a load and a reload button.
1891
1892         * QtTestBrowser/mainwindow.cpp:
1893         (MainWindow::changeLocation):
1894
1895 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1896
1897         Reviewed by Gustavo Noronha.
1898
1899         [GTK] Does not compile with -DGSEAL_ENABLE
1900         https://bugs.webkit.org/show_bug.cgi?id=37851
1901
1902         Fix build with GSEAL enabled.
1903
1904         * DumpRenderTree/gtk/EventSender.cpp:
1905         (gtk_widget_get_window):
1906         (prepareMouseButtonEvent):
1907         (mouseMoveToCallback):
1908         (mouseWheelToCallback):
1909         (keyDownCallback):
1910
1911 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1912
1913         Reviewed by Gustavo Noronha.
1914
1915         [GTK] Add support for GTK+3
1916         https://bugs.webkit.org/show_bug.cgi?id=41253
1917
1918         Adapt build system for 3.x support.
1919
1920         * GNUmakefile.am:
1921
1922 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1923
1924         Reviewed by Simon Hausmann.
1925
1926         [QT][S60] build-webkit scripts picks wrong make spec for windows build
1927         https://bugs.webkit.org/show_bug.cgi?id=41198
1928
1929         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
1930
1931         * Scripts/webkitdirs.pm:
1932         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
1933
1934 2010-06-28  Eric Seidel  <eric@webkit.org>
1935
1936         Reviewed by Adam Barth.
1937
1938         Make it possible to test the new HTML5 TreeBuilder
1939         https://bugs.webkit.org/show_bug.cgi?id=41276
1940
1941         Adam was concerned that someone might make their port
1942         depend on this setting (I guess we had some trouble with that
1943         with the HTML5Parser setting), so I littered the code with warnings.
1944
1945         test-html5-parser now tests this code path.
1946
1947         * DumpRenderTree/mac/DumpRenderTree.mm:
1948         (resetDefaultsToConsistentValues):
1949         (initializeGlobalsFromCommandLineOptions):
1950         * Scripts/test-html5-parser:
1951
1952 2010-06-27  MORITA Hajime  <morrita@google.com>
1953
1954         Unreviewed. 
1955         
1956         Some never-called @staticmethods touched self. 
1957         Fixed it to replace these self with a class.
1958
1959         * Scripts/webkitpy/common/checkout/scm.py:
1960
1961 2010-06-27  MORITA Hajime  <morrita@google.com>
1962
1963         Unreviewed.
1964         
1965         Fixed exception raising syntax that is pointed out at
1966         https://bugs.webkit.org/show_bug.cgi?id=41153
1967
1968         * Scripts/webkitpy/common/checkout/scm.py:
1969         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
1970           Removed a bad line that I accidentally checked-in at last revision.
1971
1972 2010-06-24  MORITA Hajime  <morrita@google.com>
1973
1974         Reviewed by Eric Seidel.
1975
1976         rebaseline-chromium-webkit-tests should add or remove files to local git repository
1977         https://bugs.webkit.org/show_bug.cgi?id=41153
1978
1979         - Added SCM.add() and SCM.remove()
1980         - Replaced "svn add" and "svn remove"
1981           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
1982         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
1983           for debugging purpose.
1984
1985         * Scripts/webkitpy/common/checkout/scm.py:
1986         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1987         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1988
1989 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
1990
1991         Reviewed by Shinichiro Hamaji.
1992
1993         Improve default value handling for page format properties.
1994         https://bugs.webkit.org/show_bug.cgi?id=41150
1995
1996         * DumpRenderTree/LayoutTestController.cpp:
1997         (parsePageNumber):
1998         (parsePageNumberSizeMarings):
1999         (pageSizeAndMarginsInPixelsCallback):
2000         (LayoutTestController::staticFunctions):
2001         * DumpRenderTree/LayoutTestController.h:
2002         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2003         (LayoutTestController::pageSizeAndMarginsInPixels):
2004         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2005         (LayoutTestController::pageSizeAndMarginsInPixels):
2006         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2007         (LayoutTestController::pageSizeAndMarginsInPixels):
2008
2009 2010-06-21  Robert Hogan  <robert@webkit.org>
2010
2011         Reviewed by Kenneth Rohde Christiansen.
2012
2013         [Qt] DRT Support for setCustomPolicyDelegate
2014
2015         https://bugs.webkit.org/show_bug.cgi?id=39564
2016
2017         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2018         (LayoutTestController::setCustomPolicyDelegate):
2019         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2020
2021 2010-06-26  Robert Hogan  <robert@webkit.org>
2022
2023         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
2024         
2025         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
2026         exported.
2027
2028         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2029
2030 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
2031
2032         Reviewed by Dimitri Glazkov.
2033
2034         Add a build-webkit option for enabling Web Timing support.
2035         https://bugs.webkit.org/show_bug.cgi?id=38924
2036
2037         * Scripts/build-webkit:
2038
2039 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2040
2041         Reviewed by Kenneth Rohde Christiansen.
2042
2043         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
2044         https://bugs.webkit.org/show_bug.cgi?id=38597
2045
2046         Make the reload button act as a load button as well.
2047
2048         * QtTestBrowser/mainwindow.cpp:
2049         (MainWindow::buildUI):
2050         (MainWindow::changeLocation):
2051
2052 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
2053
2054         Reviewed by Dmitry Titov.
2055
2056         Add empty abortModal() method to all platforms.
2057         https://bugs.webkit.org/show_bug.cgi?id=40864
2058
2059         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
2060         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
2061         that use abortModal will become mac specific which is not desirable.
2062
2063         * DumpRenderTree/LayoutTestController.cpp:
2064         (abortModalCallback):
2065         (LayoutTestController::staticFunctions):
2066         * DumpRenderTree/LayoutTestController.h:
2067         * DumpRenderTree/chromium/LayoutTestController.cpp:
2068         (LayoutTestController::LayoutTestController):
2069         (LayoutTestController::abortModal):
2070         * DumpRenderTree/chromium/LayoutTestController.h:
2071         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2072         (LayoutTestController::abortModal):
2073         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2074         (LayoutTestController::abortModal):
2075         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2076         (LayoutTestController::abortModal):
2077         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2078         (LayoutTestController::abortModal):
2079
2080 2010-06-25  Sam Weinig  <sam@webkit.org>
2081
2082         Reviewed by Anders Carlsson.
2083
2084         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
2085         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
2086
2087         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
2088         (WTR::InjectedBundle::shared):
2089         (WTR::InjectedBundle::InjectedBundle):
2090         (WTR::InjectedBundle::_didCreatePage):
2091         (WTR::InjectedBundle::_willDestroyPage):
2092         (WTR::InjectedBundle::_didRecieveMessage):
2093         (WTR::InjectedBundle::initialize):
2094         (WTR::InjectedBundle::didCreatePage):
2095         (WTR::InjectedBundle::willDestroyPage):
2096         (WTR::InjectedBundle::didRecieveMessage):
2097         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
2098         (WTR::InjectedBundle::layoutTestController):
2099         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2100         (WKBundleInitialize):
2101         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
2102         (WTR::InjectedBundlePage::InjectedBundlePage):
2103         (WTR::InjectedBundlePage::~InjectedBundlePage):
2104         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
2105         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
2106         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
2107         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
2108         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
2109         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
2110         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
2111         (WTR::InjectedBundlePage::_didClearWindowForFrame):
2112         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2113         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2114         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2115         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2116         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2117         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2118         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2119         (WTR::InjectedBundlePage::didClearWindowForFrame):
2120         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
2121         (WTR::InjectedBundlePage::page):
2122         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
2123         (WTR::LayoutTestController::create):
2124         (WTR::LayoutTestController::LayoutTestController):
2125         (WTR::LayoutTestController::~LayoutTestController):
2126         (WTR::dumpAsTextCallback):
2127         (WTR::layoutTestControllerObjectFinalize):
2128         (WTR::LayoutTestController::makeWindowObject):
2129         (WTR::LayoutTestController::getJSClass):
2130         (WTR::LayoutTestController::staticFunctions):
2131         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
2132         (WTR::LayoutTestController::dumpAsText):
2133         (WTR::LayoutTestController::setDumpAsText):
2134         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2135
2136 2010-06-25  Sam Weinig  <sam@webkit.org>
2137
2138         Reviewed by Anders Carlsson.
2139
2140         Make WebKitTestRunner really work with run-webkit-tests. 
2141
2142         - Add Forwarding headers to allow some cleanup.
2143
2144         * WebKitTestRunner/ForwardingHeaders: Added.
2145         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
2146         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
2147         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
2148         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
2149         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
2150         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
2151         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
2152         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
2153         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
2154         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
2155         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
2156         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
2157         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
2158         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
2159         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
2160         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
2161         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
2162         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
2163         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
2164         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
2165         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
2166         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
2167         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
2168         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
2169         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
2170         * WebKitTestRunner/TestInvocation.cpp:
2171         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
2172         * WebKitTestRunner/TestInvocation.h:
2173
2174 2010-06-25  Sam Weinig  <sam@webkit.org>
2175
2176         Reviewed by Mark Rowe.
2177
2178         Add support for WebKitTestRunner to old-run-webkit-tests
2179
2180         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
2181
2182         * Scripts/build-webkittestrunner: Added.
2183         * Scripts/old-run-webkit-tests:
2184
2185 2010-06-25  Adam Barth  <abarth@webkit.org>
2186
2187         Reviewed by David Levin.
2188
2189         Incremental build failed on Chromium ews
2190         https://bugs.webkit.org/show_bug.cgi?id=41011
2191
2192         The division of responsibility between update-webkit --chromium and
2193         build-webkit --chromium is slightly unclear.  In this patch, we make
2194         build-webkit --chromium also update DEPS and re-run GYP in case the
2195         developer has changed either since they updated.
2196
2197         This change is also helpful for the EWS, which wants to update DEPS and
2198         re-run GYP after applying patches, but the EWS doesn't want to run
2199         update-webkit --chromium because it has a dirty working copy.
2200
2201         * Scripts/webkitdirs.pm:
2202
2203 2010-06-25  Robert Hogan  <robert@webkit.org>
2204
2205         Reviewed by Simon Hausmann.
2206
2207         [Qt] Support evaluateScriptInIsolatedWorld()
2208
2209         https://bugs.webkit.org/show_bug.cgi?id=40079
2210
2211         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
2212         Remove QWebScriptWorld from exported headers.
2213         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
2214
2215         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2216         (LayoutTestController::reset):
2217         (LayoutTestController::evaluateScriptInIsolatedWorld):
2218         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2219
2220 2010-06-25  Anders Carlsson  <andersca@apple.com>
2221
2222         Revert accidental part and add a newline.
2223
2224         * MiniBrowser/mac/AppDelegate.m:
2225         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2226
2227 2010-06-25  Anders Carlsson  <andersca@apple.com>
2228
2229         Rubber-stamped by Dan Bernstein.
2230
2231         Add a LOG macro that expands to a no-op by default.
2232
2233         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2234         * MiniBrowser/mac/AppDelegate.m:
2235         (_didRecieveMessageFromInjectedBundle):
2236         * MiniBrowser/mac/BrowserWindowController.m:
2237         (-[BrowserWindowController windowShouldClose:]):
2238         (_didStartProvisionalLoadForFrame):
2239         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2240         (_didFailProvisionalLoadWithErrorForFrame):
2241         (_didCommitLoadForFrame):
2242         (_didFinishLoadForFrame):
2243         (_didFailLoadWithErrorForFrame):
2244         (_didReceiveTitleForFrame):
2245         (_didFirstLayoutForFrame):
2246         (_didFirstVisuallyNonEmptyLayoutForFrame):
2247         (_didBecomeUnresponsive):
2248         (_didBecomeResponsive):
2249         (_decidePolicyForNavigationAction):
2250         (_decidePolicyForNewWindowAction):
2251         (_createNewPage):
2252         (_showPage):
2253         (_closePage):
2254         (_didNavigateWithNavigationData):
2255         (_didPerformClientRedirect):
2256         (_didPerformServerRedirect):
2257         (_didUpdateHistoryTitle):
2258         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2259         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2260         (_didClearWindowForFrame):
2261         (_didCreatePage):
2262         (_willDestroyPage):
2263         (_didRecieveMessage):
2264
2265 2010-06-24  Adam Barth  <abarth@webkit.org>
2266
2267         Reviewed by Eric Seidel.
2268
2269         commit-queue is taking too long to land patches because of red trees
2270         https://bugs.webkit.org/show_bug.cgi?id=41194
2271
2272         Instead of checking for the tree to be green, we'll just spin hot
2273         trying to land patches.  This is probably too extreme in ignoring the
2274         tree, but I think we should try it for a while to see if we have
2275         trouble.  That will help us find the right balance.
2276
2277         * Scripts/webkitpy/tool/commands/queues.py:
2278         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2279
2280 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2281
2282         Reviewed by Xan Lopez.
2283
2284         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
2285         https://bugs.webkit.org/show_bug.cgi?id=40843
2286
2287         Define the version for old GTK+s in a way that is forward-compatible
2288         and clean up the logic a bit.
2289
2290         * DumpRenderTree/gtk/EventSender.cpp:
2291         (gdk_window_get_root_coords): Renamed and cleaned up.
2292         (prepareMouseButtonEvent): Remove #ifdefs.
2293         (mouseMoveToCallback): Remove #ifdefs.
2294
2295 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
2296
2297         Reviewed by Eric Seidel.
2298
2299         Fix NewRunWebKitTests to work on Windows.
2300         https://bugs.webkit.org/show_bug.cgi?id=41180
2301
2302         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
2303             because Windows fails to understand what we're asking of it.
2304
2305 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2306
2307         Reviewed by Xan Lopez.
2308
2309         [GTK] The url passed to the WebView during layout tests is invalid
2310         https://bugs.webkit.org/show_bug.cgi?id=40832
2311
2312         Set the test URL to the full real file URL and do a small cleanup.
2313         Previously a URL like file://relative/path/to/test.html was passed
2314         to the WebView. This malformed file URL would be returned by
2315         webkit_web_view_get_url and webkit_web_frame_get_url.
2316
2317         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2318         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
2319         (shouldOpenWebInspector): Change to take a const string& as the argument.
2320         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
2321         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2322
2323 2010-06-24  Sam Weinig  <sam@webkit.org>
2324
2325         Reviewed by Anders Carlsson.
2326
2327         Fix WebKitTestRunner Makefile typos.
2328
2329         * WebKitTestRunner/Makefile:
2330
2331 2010-06-24  Adele Peterson  <adele@apple.com>
2332
2333         Reviewed by Eric Carlson.
2334
2335         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2336         https://bugs.webkit.org/show_bug.cgi?id=41085
2337
2338         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2339         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2340
2341 2010-06-23  Sam Weinig  <sam@webkit.org>
2342
2343         Reviewed by Anders Carlsson.
2344
2345         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2346         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2347
2348         - Mac only.
2349         - run-webkit-tests has not been modified to call it yet.
2350         - Only dumps the render tree at this time. 
2351
2352         * WebKitTestRunner: Added.
2353         * WebKitTestRunner/Configurations: Added.
2354         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2355         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2356         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2357         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2358         * WebKitTestRunner/InjectedBundle: Added.
2359         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2360         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2361         (_didStartProvisionalLoadForFrame):
2362         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2363         (_didFailProvisionalLoadWithErrorForFrame):
2364         (_didCommitLoadForFrame):
2365         (_didFinishLoadForFrame):
2366         (_didFailLoadWithErrorForFrame):
2367         (_didReceiveTitleForFrame):
2368         (_didClearWindow):
2369         (_didCreatePage):
2370         (_willDestroyPage):
2371         (_didRecieveMessage):
2372         (WKBundleInitialize):
2373         * WebKitTestRunner/Makefile: Added.
2374         * WebKitTestRunner/PlatformWebView.h: Added.
2375         (WTR::PlatformWebView::platformView):
2376         * WebKitTestRunner/TestController.cpp: Added.
2377         (WTR::TestController::shared):
2378         (WTR::TestController::TestController):
2379         (WTR::TestController::initialize):
2380         (WTR::TestController::runTest):
2381         (WTR::TestController::runTestingServerLoop):
2382         (WTR::TestController::run):
2383         * WebKitTestRunner/TestController.h: Added.
2384         (WTR::TestController::verbose):
2385         (WTR::TestController::injectedBundlePath):
2386         * WebKitTestRunner/TestInvocation.cpp: Added.
2387         (WTR::createWKURL):
2388         (WTR::TestInvocation::TestInvocation):
2389         (WTR::TestInvocation::~TestInvocation):
2390         (WTR::TestInvocation::invoke):
2391         (WTR::TestInvocation::dump):
2392         (WTR::TestInvocation::initializeMainWebView):
2393         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2394         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2395         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2396         (WTR::TestInvocation::didCommitLoadForFrame):
2397         (WTR::TestInvocation::didFinishLoadForFrame):
2398         (WTR::TestInvocation::didFailLoadForFrame):
2399         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2400         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2401         * WebKitTestRunner/TestInvocation.h: Added.
2402         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2403         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2404         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2405         * WebKitTestRunner/mac: Added.
2406         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2407         (WTR::PlatformWebView::PlatformWebView):
2408         (WTR::PlatformWebView::~PlatformWebView):
2409         (WTR::PlatformWebView::page):
2410         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2411         (WTR::TestInvocation::runUntil):
2412         * WebKitTestRunner/mac/main.mm: Added.
2413         (main):
2414
2415 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2416
2417         Unreviewed. Adding myself to the committers list.
2418
2419         * Scripts/webkitpy/common/config/committers.py:
2420
2421 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2422
2423         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2424
2425         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2426         (LayoutTestController::isPageBoxVisible):
2427         (LayoutTestController::pageAreaRectInPixels):
2428         (LayoutTestController::preferredPageSizeInPixels):
2429         * wx/build/settings.py:
2430
2431 2010-06-23  James Robinson  <jamesr@chromium.org>
2432
2433         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2434
2435         * Scripts/webkitpy/common/config/committers.py:
2436
2437 2010-06-23  Kent Tamura  <tkent@chromium.org>
2438
2439         Reviewed by Dimitri Glazkov.
2440
2441         Correct Chromium test configuration
2442         https://bugs.webkit.org/show_bug.cgi?id=41057
2443
2444         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2445          - Add "--use-drt" option for NRWT. It is required for Chromium and
2446            ignored for other platforms.
2447          - Skip JSC test on Chromium
2448         * BuildSlaveSupport/test-result-archive:
2449           Add Chromium support.
2450
2451 2010-06-23  Sam Weinig  <sam@webkit.org>
2452
2453         Reviewed by Anders Carlsson.
2454
2455         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2456         WebKit2: Flesh out more of the InjectedBundle client API
2457
2458         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2459         (_didStartProvisionalLoadForFrame):
2460         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2461         (_didFailProvisionalLoadWithErrorForFrame):
2462         (_didCommitLoadForFrame):
2463         (_didFinishLoadForFrame):
2464         (_didFailLoadWithErrorForFrame):
2465         (_didReceiveTitleForFrame):
2466         (_didClearWindowForFrame):
2467         (_didCreatePage):
2468         (_willDestroyPage):
2469         (WKBundleInitialize):
2470
2471 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2472
2473         Reviewed by Shinichiro Hamaji.
2474
2475         Implement page format data programming interface.
2476         Add methods for testing.
2477         https://bugs.webkit.org/show_bug.cgi?id=37538
2478
2479         * DumpRenderTree/LayoutTestController.cpp:
2480         (parsePageNumber):
2481         (isPageBoxVisibleCallback):
2482         (pageAreaRectInPixelsCallback):
2483         (preferredPageSizeInPixelsCallback):
2484         (LayoutTestController::staticFunctions):
2485         * DumpRenderTree/LayoutTestController.h:
2486         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2487         (LayoutTestController::isPageBoxVisible):
2488         (LayoutTestController::pageAreaRectInPixels):
2489         (LayoutTestController::preferredPageSizeInPixels):
2490         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2491         (LayoutTestController::isPageBoxVisible):
2492         (LayoutTestController::pageAreaRectInPixels):
2493         (LayoutTestController::preferredPageSizeInPixels):
2494         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2495         (LayoutTestController::isPageBoxVisible):
2496         (LayoutTestController::pageAreaRectInPixels):
2497         (LayoutTestController::preferredPageSizeInPixels):
2498
2499 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2500
2501         Reviewed by Shinichiro Hamaji.
2502
2503         Follow proper convention for if/switch/while as I've discovered
2504         them to be through my review processes.
2505         https://bugs.webkit.org/show_bug.cgi?id=40723
2506
2507         Modified test so that if( foo ) is not allowed as it appears not
2508         to be the accepted convention.
2509
2510         * Scripts/webkitpy/style/checkers/cpp.py:
2511         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2512
2513 2010-06-22  Eric Seidel  <eric@webkit.org>
2514
2515         Reviewed by Adam Barth.
2516
2517         Run clean-header-guards to fix some header guards
2518         https://bugs.webkit.org/show_bug.cgi?id=41044
2519
2520         No functional changes, thus no tests.
2521
2522         This entire change was generated by running
2523         clean-header-guards, and then reverting changes
2524         to files which shouldn't be changed.  Those which
2525         are left all should be updated.
2526
2527         Some of these changes are just fixing 755 permissions
2528         to be 644, since it seems various files have the wrong
2529         execute bit which don't need it.  clean-header-guards
2530         made those (welcome) permission fixes unintentionally.
2531
2532         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2533         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2534         * QtTestBrowser/fpstimer.h:
2535
2536 2010-06-22  Adam Barth  <abarth@webkit.org>
2537
2538         Reviewed by Eric Seidel.
2539
2540         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2541         https://bugs.webkit.org/show_bug.cgi?id=41043
2542
2543         Update the hash.
2544
2545         * Scripts/do-webcore-rename:
2546
2547 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2548
2549         Reviewed by Shinichiro Hamaji.
2550
2551         Follow proper convention for variable declaration spacing.
2552         https://bugs.webkit.org/show_bug.cgi?id=40724
2553
2554         Modified test so that 'int   a;' is not allowed.
2555
2556         * Scripts/webkitpy/style/checkers/cpp.py:
2557         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2558
2559 2010-06-22  Eric Seidel  <eric@webkit.org>
2560
2561         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2562
2563         * Scripts/webkitpy/common/config/committers.py:
2564
2565 2010-06-22  Eric Seidel  <eric@webkit.org>
2566
2567         Reviewed by Adam Barth.
2568
2569         Remove Gtk 64-Release bot from core since it's broken
2570         https://bugs.webkit.org/show_bug.cgi?id=41022
2571
2572         This bot alone has been responsible for more than 72 hours of
2573         commit-queue blockage in the last week.  The bot is broken -- keeps
2574         losing its display server or similar.  Until the Gtk folks can fix the
2575         bot, we need to remove it from core.  The WebKit community can't keep
2576         it green as is.
2577
2578         * Scripts/webkitpy/common/net/buildbot.py:
2579         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2580
2581 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2582
2583         Reviewed by Eric Seidel.
2584
2585         Fix the Windows build.
2586         https://bugs.webkit.org/show_bug.cgi?id=40972
2587
2588         * DumpRenderTree/win/ImageDiff.vcproj:
2589
2590 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2591
2592         Reviewed by Darin Adler, Dmitry Titov.
2593
2594         DumpRenderTree should allow tests with modal dialogs
2595         https://bugs.webkit.org/show_bug.cgi?id=35350
2596
2597         * DumpRenderTree/LayoutTestController.cpp:
2598         (abortModalCallback):
2599         (LayoutTestController::staticFunctions):
2600         * DumpRenderTree/LayoutTestController.h:
2601         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2602         (LayoutTestController::abortModal):
2603         Add abortModal method to LayoutTestController and make it available from script.
2604
2605         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2606         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2607         abortModal from when modal window closes.
2608         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2609
2610 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2611
2612         Reviewed by Anders Carlsson.
2613         
2614         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2615         https://bugs.webkit.org/show_bug.cgi?id=40948
2616         
2617         Have the script look in WebKit2.
2618
2619         * Scripts/do-webcore-rename:
2620
2621 2010-06-21  Robert Hogan  <robert@webkit.org>
2622
2623         Reviewed by Kenneth Rohde Christiansen.
2624
2625         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2626
2627         It's a Mac-specific test so just add the required LayoutTestController
2628         function as a no-op to avoid failing. Similar approach adopted by other
2629         ports.
2630
2631         https://bugs.webkit.org/show_bug.cgi?id=33344
2632
2633         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2634         (LayoutTestController::addDisallowedURL):
2635
2636 2010-06-21  Sam Weinig  <sam@webkit.org>
2637
2638         Reviewed by Anders Carlsson.
2639
2640         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2641         Add message passing support to the WebKit2 API.
2642
2643         - Add some test messages.
2644
2645         * MiniBrowser/mac/AppDelegate.m:
2646         (_didRecieveMessageFromInjectedBundle):
2647         (-[BrowserAppDelegate init]):
2648         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2649         (_didClearWindow):
2650         (_didCreatePage):
2651         (_didRecieveMessage):
2652         (WKBundleInitialize):
2653
2654 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2655
2656         Unreviewed.
2657
2658         Rolling back 61551 and 61555 due to test failures.
2659
2660         * DumpRenderTree/LayoutTestController.cpp:
2661         (LayoutTestController::staticFunctions):
2662         * DumpRenderTree/LayoutTestController.h:
2663         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2664         (LayoutTestController::setEditingBehavior):
2665         * DumpRenderTree/mac/UIDelegate.mm:
2666
2667 2010-06-21  Anders Carlsson  <andersca@apple.com>
2668
2669         Reviewed by Sam Weinig.
2670
2671         Make DumpRenderTree build with clang++
2672
2673         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2674         (-[LocalPasteboard setPropertyList:forType:]):
2675         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2676         (-[DumpRenderTreeWindow keyDown:]):
2677         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2678         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2679         (LayoutTestController::isCommandEnabled):
2680
2681 2010-06-21  Satish Sampath  <satish@chromium.org>
2682
2683         Reviewed by Steve Block.
2684
2685         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2686         https://bugs.webkit.org/show_bug.cgi?id=40878
2687
2688         * Scripts/build-webkit:
2689
2690 2010-06-21  Kent Tamura  <tkent@chromium.org>
2691
2692         Reviewed by Dimitri Glazkov.
2693
2694         [DRT/Chromium] Initialization for http/tests/loading/
2695         https://bugs.webkit.org/show_bug.cgi?id=40902
2696
2697         * DumpRenderTree/chromium/TestShell.cpp:
2698         (TestShell::runFileTest):
2699
2700 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2701
2702         Unreviewed.
2703
2704         Adding myself to the committers list.
2705
2706         * Scripts/webkitpy/common/config/committers.py:
2707
2708 2010-06-20  Kent Tamura  <tkent@chromium.org>
2709
2710         Reviewed by Dimitri Glazkov.
2711
2712         [DRT/Chromium] Add --allow-external-pages option
2713         https://bugs.webkit.org/show_bug.cgi?id=40762
2714
2715         Add --allow-external-pages introduced by Chromium r45403.
2716         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2717
2718         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2719         (main):
2720         * DumpRenderTree/chromium/TestShell.cpp:
2721         (TestShell::TestShell):
2722         * DumpRenderTree/chromium/TestShell.h:
2723         (TestShell::allowExternalPages):
2724         (TestShell::setAllowExternalPages):
2725         * DumpRenderTree/chromium/WebViewHost.cpp:
2726         (WebViewHost::willSendRequest):
2727
2728 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2729
2730         Reviewed by Adam Barth.
2731
2732         Sheriffbot: Should allow "r" in SVN_REVISION
2733         https://bugs.webkit.org/show_bug.cgi?id=40889
2734
2735         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2736         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2737
2738 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2739
2740         Reviewed by Dimitri Glazkov.
2741
2742         Python Tests Fail after r61508
2743         https://bugs.webkit.org/show_bug.cgi?id=40891
2744
2745         Test's regex list needed to be updated to match the new
2746         regex list in the source code. Added new bots to the
2747         example_buildbots list.
2748
2749         Regex list fixed in r61512. Updated bot list.
2750
2751         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2752
2753 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2754
2755         Unreviewed, build fix.
2756
2757         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2758
2759         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2760
2761 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2762
2763         Unreviewed.
2764
2765         Adding myself to the committers list.
2766
2767         * Scripts/webkitpy/common/config/committers.py:
2768
2769 2010-06-19  Sam Weinig  <sam@webkit.org>
2770
2771         Reviewed by Anders Carlsson.
2772
2773         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2774         Add ability to have a WebProcess per WebContext.
2775
2776         Move to use new shared contexts API.
2777
2778         * MiniBrowser/mac/AppDelegate.h:
2779         * MiniBrowser/mac/AppDelegate.m:
2780         (-[BrowserAppDelegate init]):
2781         (-[BrowserAppDelegate getCurrentPageNamespace]):
2782         (-[BrowserAppDelegate validateMenuItem:]):
2783         (-[BrowserAppDelegate _setProcessModel:]):
2784         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2785         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2786         * MiniBrowser/win/BrowserView.cpp:
2787         (BrowserView::create):
2788
2789 2010-06-02  Robert Hogan  <robert@webkit.org>
2790
2791         Reviewed by Adam Barth.
2792
2793         [Qt] Support evaluateScriptInIsolatedWorld()
2794
2795         https://bugs.webkit.org/show_bug.cgi?id=40079
2796
2797         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2798         (LayoutTestController::evaluateScriptInIsolatedWorld):
2799         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2800
2801 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2802
2803         Reviewed by Darin Adler.
2804
2805         Add three more non-core Chromium builders to start testing DumpRenderTree.
2806         https://bugs.webkit.org/show_bug.cgi?id=40335
2807
2808         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2809
2810 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2811
2812         Reviewed by Darin Fisher.
2813
2814         [Chromium] Plumbing for top-level frame names
2815         https://bugs.webkit.org/show_bug.cgi?id=40430
2816
2817         * DumpRenderTree/chromium/WebViewHost.cpp:
2818         (WebViewHost::reset):
2819         Changed obsolete call to clearName() to use setName(WebString()) instead.
2820
2821 2010-06-18  Sam Weinig  <weinig@apple.com>
2822
2823         Rolling http://trac.webkit.org/changeset/61297 back in.
2824
2825         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2826         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2827         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2828         (_didClearWindow):
2829         (_didCreatePage):
2830         (WKBundleInitialize):
2831
2832 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2833
2834         Reviewed by Darin Adler.
2835
2836         https://bugs.webkit.org/show_bug.cgi?id=40803
2837         TestNetscapePlugin has an incorrect implementation of "property" property
2838
2839         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2840         pass a static string back, it's going to be released by NPAPI implementation.
2841
2842 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2843
2844         Unreviewed.
2845
2846         Adding myself to the committers list.
2847
2848         * Scripts/webkitpy/common/config/committers.py:
2849
2850 2010-06-17  Tony Chang  <tony@chromium.org>
2851
2852         Reviewed by Kent Tamura.
2853
2854         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2855         https://bugs.webkit.org/show_bug.cgi?id=40615
2856
2857         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2858
2859 2010-06-17  Ada Chan  <adachan@apple.com>
2860
2861         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
2862
2863         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2864         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
2865         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2866
2867 2010-06-17  Darin Adler  <darin@apple.com>
2868
2869         One more try at fix for Chromium build.
2870
2871         * DumpRenderTree/chromium/TestShell.cpp:
2872         (TestShell::TestShell): Use set again instead of =.
2873
2874 2010-06-17  Darin Adler  <darin@apple.com>
2875
2876         Fix Chromium build.
2877
2878         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
2879         code with all the other platforms! Wow, that should be fixed at some point.
2880
2881         * DumpRenderTree/chromium/TestShell.cpp:
2882         (TestShell::TestShell): Changed back to using "new".
2883         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2884
2885 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
2886
2887         Unreviewed Qt build fix.
2888
2889         LayoutTestController in the Qt DRT is not using refs :)
2890
2891         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2892         (WebCore::DumpRenderTree::DumpRenderTree):
2893
2894 2010-06-17  Darin Adler  <darin@apple.com>
2895
2896         Reviewed by Sam Weinig.
2897
2898         Use adoptRef and create functions in more code paths
2899         https://bugs.webkit.org/show_bug.cgi?id=40760
2900
2901         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
2902
2903         * DumpRenderTree/LayoutTestController.cpp:
2904         (LayoutTestController::create): Added.
2905         * DumpRenderTree/LayoutTestController.h: Declare the create function.
2906
2907         * DumpRenderTree/chromium/TestShell.cpp:
2908         (TestShell::TestShell): Use create instead of new.
2909         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
2910
2911         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2912         (runTest): Use RefPtr and create instead of OwnPtr and new.
2913
2914         * DumpRenderTree/mac/DumpRenderTree.mm:
2915         (runTest): Use RefPtr and create instead of OwnPtr and new.
2916
2917         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2918         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
2919         instead of new.
2920
2921         * DumpRenderTree/win/DumpRenderTree.cpp:
2922         (runTest): Use RefPtr and create instead of OwnPtr and new.
2923
2924         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2925         (runTest): Use RefPtr and create instead of OwnPtr and new.
2926         (MyApp::OnInit): Removed unneeded code to delete the layout
2927         test controller. This is done during each test.
2928
2929 2010-06-17  Kent Tamura  <tkent@chromium.org>
2930
2931         Reviewed by Shinichiro Hamaji.
2932
2933         [DRT/Chromium] Fix a bug of Windows pixel tests
2934         https://bugs.webkit.org/show_bug.cgi?id=40763
2935
2936         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2937         (TestShellPrinter::handleImage):
2938
2939 2010-06-16  Kent Tamura  <tkent@chromium.org>
2940
2941         Reviewed by Shinichiro Hamaji.
2942
2943         [DRT/Chromium] Fix crash on Mac Release
2944         https://bugs.webkit.org/show_bug.cgi?id=40759
2945
2946         * DumpRenderTree/chromium/WebViewHost.cpp:
2947         (WebViewHost::paintRect): We should not use m_canvas directly because
2948           it is created lazily in canvas().
2949
2950 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2951
2952         [wx] Build fix after new method addition.
2953
2954         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2955         (LayoutTestController::pageProperty):
2956
2957 2010-06-16  Kent Tamura  <tkent@chromium.org>
2958
2959         Reviewed by Dimitri Glazkov.
2960
2961         [DRT/Chromium] Set current working directory for each of tests
2962         https://bugs.webkit.org/show_bug.cgi?id=40668
2963
2964         This change fixes tests with eventSender.beginDragWithFiles().
2965
2966         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2967         (runTest):
2968
2969 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2970
2971         Reviewed by Gustavo Noronha Silva.
2972
2973         [GTK] r60803 broke media/controls-drag-timebar.html
2974         https://bugs.webkit.org/show_bug.cgi?id=40269
2975
2976         Only queue events while the mouse button is down, if drag mode is enabled. Some
2977         tests may disable drag mode, to prevent the queuing of events in this situation.
2978
2979         * DumpRenderTree/gtk/EventSender.cpp:
2980         (sendOrQueueEvent): Only queue events here if dragMode is true.
2981
2982 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2983
2984         Reviewed by Gustavo Noronha Silva.
2985
2986         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
2987         https://bugs.webkit.org/show_bug.cgi?id=40600
2988
2989         * DumpRenderTree/gtk/EventSender.cpp:
2990         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
2991
2992 2010-06-16  Adam Barth  <abarth@webkit.org>
2993
2994         Reviewed by Dimitri Glazkov.
2995
2996         Add a hidden land-cowboy command to webkit-patch to help land quick
2997         build fixes.
2998
2999         * Scripts/webkitpy/tool/commands/download.py:
3000         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3001
3002 2010-06-16  Adam Roben  <aroben@apple.com>
3003
3004         Convert console messages to UTF-8 before printing them
3005
3006         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
3007         http/tests/security/xssAuditor/embed-tag-null-char.html and
3008         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
3009         Windows. (I can't test the fix because Apache is crashing on my
3010         computer.)
3011
3012         Reviewed by Alexey Proskuryakov.
3013
3014         * DumpRenderTree/win/DumpRenderTree.cpp:
3015         (toUTF8): Extracted the code into an overload that takes a wide string
3016         and a length, then added an overload that takes a wstring.
3017
3018         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
3019         overload.
3020
3021         * DumpRenderTree/win/UIDelegate.cpp:
3022         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
3023         UTF-8 instead of letting printf convert to the current code page.
3024
3025 2010-06-16  Drew Wilson  <atwilson@chromium.org>
3026
3027         Reviewed by Kent Tamura.
3028
3029         [Chromium] Plumbing for top-level frame names
3030         https://bugs.webkit.org/show_bug.cgi?id=40430
3031
3032         * DumpRenderTree/chromium/WebViewHost.cpp:
3033         (WebViewHost::createView):
3034         Migrate to new createView() API.
3035         * DumpRenderTree/chromium/WebViewHost.h:
3036         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
3037
3038 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
3039
3040         Reviewed by Kenneth Rohde Christiansen.
3041
3042         [Qt] Scroll wheel event support to graphics based DRT
3043         https://bugs.webkit.org/show_bug.cgi?id=40577
3044
3045         * DumpRenderTree/qt/EventSenderQt.cpp:
3046         (EventSender::continuousMouseScrollBy):
3047         (EventSender::createGraphicsSceneWheelEvent):
3048         * DumpRenderTree/qt/EventSenderQt.h:
3049
3050 2010-06-16  Adam Roben  <aroben@apple.com>
3051
3052         Remove a stray newline from the Windows version of TestNetscapePlugin
3053
3054         Reviewed by Alexey Proskuryakov.
3055
3056         Fixes <http://webkit.org/b/40728>
3057         plugins/geturlnotify-during-document-teardown.html fails on Windows
3058
3059         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3060         (NPP_Destroy): Removed extra newline that the Mac version doesn't
3061         have.
3062
3063 2010-06-16  Adam Roben  <aroben@apple.com>
3064
3065         Respect LayoutTestController::isPrinting on Windows
3066
3067         This gets some printing tests closer to passing (like
3068         printing/page-rule-in-media-query.html).
3069
3070         Fixes <http://webkit.org/b/40727>.
3071
3072         Reviewed by Dan Bernstein.
3073
3074         * DumpRenderTree/win/DumpRenderTree.cpp:
3075         (dump): Pass LayoutTestController::isPrinting to
3076         IWebFramePrivate::renderTreeAsExternalRepresentation.
3077
3078 2010-06-15  Adam Barth  <abarth@webkit.org>
3079
3080         Reviewed by Eric Seidel.
3081
3082         Enable HTML5 lexer
3083         https://bugs.webkit.org/show_bug.cgi?id=40650
3084
3085         * DumpRenderTree/mac/DumpRenderTree.mm:
3086         (initializeGlobalsFromCommandLineOptions):
3087
3088 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
3089
3090         Reviewed by Shinichiro Hamaji.
3091
3092         Implement render style selection for pages to support CSS3 Paged Media.
3093         https://bugs.webkit.org/show_bug.cgi?id=35961
3094
3095         * DumpRenderTree/LayoutTestController.cpp:
3096         (parsePagePropertyParameters):
3097         (pagePropertyCallback):
3098         (LayoutTestController::staticFunctions):
3099         * DumpRenderTree/LayoutTestController.h:
3100         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3101         (LayoutTestController::pageProperty):
3102         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3103         (LayoutTestController::pageProperty):
3104         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3105         (LayoutTestController::pageProperty):
3106
3107 2010-06-15  Sam Weinig  <sam@webkit.org>
3108
3109         Reviewed by Anders Carlsson.
3110
3111         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
3112         WebKit2: Add mechanism to inject code into the WebProcess on startup
3113
3114         Add initial InjectedBundle support.
3115
3116         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3117         * MiniBrowser/WebBundle-Info.plist: Added.
3118         Add test InjectedBundle to the project.
3119
3120         * MiniBrowser/mac/AppDelegate.m:
3121         (-[BrowserAppDelegate init]):
3122         Get the path to the WebBundle from the the main bundle and pass it to the new
3123         WKContextCreateWithInjectedBundlePath function.
3124
3125         * MiniBrowser/mac/BrowserWindowController.m:
3126         (_didChangeProgress):
3127         Fix the build.  This has been broken for a while.
3128
3129         * MiniBrowser/mac/WebBundle: Added.
3130         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
3131         (_didCreatePage):
3132         (WKBundleInitialize):
3133         Add really basic InjectedBundle.
3134
3135         * MiniBrowser/win/BrowserView.cpp:
3136         (BrowserView::create):
3137         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
3138
3139 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
3140
3141         Reviewed by Darin Adler.
3142
3143         Adding myself to the reviewers list.
3144         https://bugs.webkit.org/show_bug.cgi?id=40693
3145
3146         * Scripts/webkitpy/common/config/committers.py:
3147
3148 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
3149
3150         Reviewed by Xan Lopez.
3151
3152         Switch to using GIO methods instead of realpath in GtkLauncher to determine
3153         the file URI. This should remove warnings about realpath being undefined
3154         when compiling with '-ansi'.
3155
3156         * GtkLauncher/main.c:
3157         (filenameToURL): Use GIO instead of realpath to determine file URI.
3158
3159 2010-06-15  Adam Roben  <aroben@apple.com>
3160
3161         Remove the redundant set-apple-windows-environment-variables script
3162
3163         Apparently update-webkit does this for you these days.
3164
3165         Rubber-stamped by Steve Falkenburg.
3166
3167         * Scripts/set-apple-windows-environment-variables: Removed.
3168
3169 2010-06-14  Adam Roben  <aroben@apple.com>
3170
3171         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
3172         environment variables
3173
3174         Fixes <http://webkit.org/b/40595>.
3175
3176         Reviewed by Steve Falkenburg.
3177
3178         * Scripts/set-apple-windows-environment-variables: Added.
3179         (to_windows_path): Passes the passed-in path through cygpath to
3180         generate a Windows-style path.
3181         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
3182         variables to their defaults, if they aren't already set.
3183
3184 2010-06-14  Adam Roben  <aroben@apple.com>
3185
3186         Speed up run-safari/debug-safari on Windows
3187
3188         Fixes <http://webkit.org/b/40586>.
3189
3190         Reviewed by Steve Falkenburg.
3191
3192         * Scripts/webkitdirs.pm:
3193         (runSafari): When debugging, set up the environment to run Safari
3194         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
3195         actually launch the debugger. When not debugging, just run WebKit.exe
3196         and it will do the rest for us.
3197
3198 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
3199
3200         Reviewed by Kenneth Rohde Christiansen.
3201
3202         [Qt] DRT EventSender support to graphics context events
3203         https://bugs.webkit.org/show_bug.cgi?id=40324
3204
3205         * DumpRenderTree/qt/EventSenderQt.cpp:
3206         (EventSender::contextClick):
3207
3208 2010-06-14  Tony Chang  <tony@chromium.org>
3209
3210         Reviewed by Darin Fisher.
3211
3212         [chromium] checkout chromium third_party directly
3213         https://bugs.webkit.org/show_bug.cgi?id=40556
3214
3215         * Scripts/update-webkit-chromium: some migration code for the bots
3216
3217 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3218
3219         Chromium build fix.
3220
3221         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
3222         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
3223
3224 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3225
3226         Reviewed by Darin Adler.
3227
3228         https://bugs.webkit.org/show_bug.cgi?id=40529
3229         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
3230
3231         * DumpRenderTree/mac/EventSendingController.mm:
3232         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
3233         event for "delete" - it had virtual key code from forward delete, and text from backspace.
3234         Fixed "delete" to mean forward delete.
3235
3236         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
3237         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
3238         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3239         Mac DRT confusion has propagated to other platforms, fixing those.
3240
3241 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
3242
3243         Reviewed by Xan Lopez.
3244
3245         Small GtkLauncher build fix for some systems.
3246
3247         * GtkLauncher/main.c: Add <limit.h> include.
3248
3249 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3250
3251         Reviewed by Laszlo Gombos.
3252
3253         [Qt] navigator.geolocation support for Qt port
3254         https://bugs.webkit.org/show_bug.cgi?id=39724
3255
3256         Implementation for geolocation cases to DumpRenderTreeQt
3257
3258         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3259         (WebCore::WebPage::allowGeolocationRequest):
3260         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3261         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3262         (LayoutTestController::setGeolocationPermission):
3263         (LayoutTestController::setMockGeolocationError):
3264         (LayoutTestController::setMockGeolocationPosition):
3265         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3266         (LayoutTestController::isGeolocationPermissionSet):
3267         (LayoutTestController::geolocationPermission):
3268
3269 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
3270
3271         Reviewed by Darin Adler.
3272
3273         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
3274         be a way of overwriting the Xcode system path.  Making
3275         $WEBKITOUTPUTDIR take precedence over the system default would make
3276         this possible.
3277
3278         * Scripts/webkitdirs.pm:
3279
3280 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
3281
3282         Reviewed by Darin Adler.
3283
3284         AX: link won't return linked element if URL contains #
3285         https://bugs.webkit.org/show_bug.cgi?id=40192
3286
3287         * DumpRenderTree/AccessibilityUIElement.cpp:
3288         (linkedUIElementAtIndexCallback):
3289         (AccessibilityUIElement::getJSClass):
3290         * DumpRenderTree/AccessibilityUIElement.h:
3291         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3292         (AccessibilityUIElement::linkedUIElementAtIndex):
3293         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3294         (AccessibilityUIElement::linkedUIElementAtIndex):
3295         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3296         (AccessibilityUIElement::linkedUIElementAtIndex):
3297
3298 2010-06-13  Adam Barth  <abarth@webkit.org>
3299
3300         Reviewed by Darin Adler.
3301
3302         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
3303         https://bugs.webkit.org/show_bug.cgi?id=39550
3304
3305         This can cause an extra request to bugs.webkit.org durig upload, but it
3306         shouldn't be too bad.  Also, this won't work if you remove the
3307         boilerplate created by prepare-ChangeLog.
3308
3309         * Scripts/webkitpy/common/checkout/changelog.py:
3310         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3311         * Scripts/webkitpy/common/net/bugzilla.py:
3312         * Scripts/webkitpy/tool/steps/abstractstep.py:
3313         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3314         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
3315
3316 2010-06-08  Robert Hogan  <robert@webkit.org>
3317
3318         Reviewed by Eric Seidel.
3319
3320         [Qt] Add support for callShouldCloseOnWebView() to DRT
3321         https://bugs.webkit.org/show_bug.cgi?id=40330
3322
3323         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3324         (LayoutTestController::callShouldCloseOnWebView):
3325         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3326         (LayoutTestController::setCallCloseOnWebViews):
3327
3328 2010-06-12  Eric Seidel  <eric@webkit.org>
3329
3330         Reviewed by Daniel Bates.
3331
3332         do-webcore-rename should have a --verbose option
3333         https://bugs.webkit.org/show_bug.cgi?id=40497
3334
3335         * Scripts/do-webcore-rename:
3336          - Unified how we handle skipping files/directories
3337            this will allow us to "black list" certain files and
3338            directories when performing renames.
3339          - Made do-webcore-rename log what it's skipping when passed --verbose.
3340
3341 2010-06-12  Darin Adler  <darin@apple.com>
3342
3343         * Scripts/run-bindings-tests: Fixed a typo in a message.
3344
3345 2010-06-12  Kent Tamura  <tkent@chromium.org>
3346
3347         Reviewed by Dimitri Glazkov.
3348
3349         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3350         https://bugs.webkit.org/show_bug.cgi?id=40402
3351
3352         _build_path() of each Chromium port check existence of build path
3353         of Chromium checkout first, then check existence of build path of
3354         WebKit-only checkout.
3355
3356         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3357         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3358         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3359
3360 2010-06-12  Robert Hogan  <robert@webkit.org>
3361
3362         Reviewed by Kenneth Rohde Christiansen.
3363
3364         [Qt] Back-forward list dumping is incorrect
3365
3366         https://bugs.webkit.org/show_bug.cgi?id=36392
3367
3368         Support dumping child history items in DRT.
3369
3370         Unskip:
3371
3372         fast/loader/frame-src-change-added-to-history.html
3373         fast/loader/frame-src-change-not-added-to-history.html
3374         fast/loader/frame-location-change-not-added-to-history.html
3375
3376         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3377         (WebCore::dumpHistoryItem):
3378
3379 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3380
3381         Reviewed by Eric Seidel.
3382
3383         upload all patches that lack in-rietveld to rietveld
3384         https://bugs.webkit.org/show_bug.cgi?id=40444
3385
3386         If it's a patch, then we'll try to upload it as long as it
3387         doesn't have in-rietveld set. No longer set in-rietveld? since
3388         it's not needed.
3389
3390         * Scripts/webkitpy/common/net/bugzilla.py:
3391
3392 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3393
3394         Reviewed by Darin Fisher.
3395
3396         Fix rietveld upload when message length > 100 characters
3397         https://bugs.webkit.org/show_bug.cgi?id=40457
3398
3399         * Scripts/webkitpy/common/net/rietveld.py:
3400
3401 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3402
3403         Reviewed by Laszlo Gombos.
3404
3405         [Qt] There should be a way to enable popups in QtTestBrowser
3406         https://bugs.webkit.org/show_bug.cgi?id=40427
3407
3408         * QtTestBrowser/main.cpp:
3409         (LauncherWindow::toggleJavascriptCanOpenWindows):
3410         (LauncherWindow::createChrome):
3411
3412 2010-06-10  Adam Barth  <abarth@webkit.org>
3413
3414         Reviewed by Daniel Bates.
3415
3416         Make SheriffBot more chatty
3417         https://bugs.webkit.org/show_bug.cgi?id=40463
3418
3419         People seem to like to talk to SheriffBot, so let's make him chat back.
3420
3421         * Scripts/webkitpy/thirdparty/__init__.py:
3422         * Scripts/webkitpy/tool/bot/irc_command.py:
3423         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3424         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3425         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3426
3427 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3428
3429         Reviewed by Darin Adler.
3430
3431         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3432         
3433         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3434         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3435         WEXITSTATUS on $result instead of just comparing $result to 0.
3436
3437         * Scripts/update-webkit-auxiliary-libs:
3438
3439 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3440
3441         Reviewed by Alexey Proskuryakov.
3442
3443         don't use Exception.message as it's deprecated in python 2.6+
3444         https://bugs.webkit.org/show_bug.cgi?id=40449
3445
3446         * Scripts/webkitpy/tool/commands/queues.py:
3447
3448 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3449
3450         Reviewed by Adam Barth.
3451
3452         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3453         https://bugs.webkit.org/show_bug.cgi?id=40436
3454
3455         * Scripts/webkitpy/common/system/outputcapture.py:
3456         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3457         * Scripts/webkitpy/tool/commands/queues.py:
3458         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3459         * Scripts/webkitpy/tool/commands/queuestest.py:
3460         * Scripts/webkitpy/tool/mocktool.py:
3461
3462 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3463
3464         Reviewed by Simon Hausmann.
3465
3466         [Qt] *All* WebGL layout tests fail!
3467         https://bugs.webkit.org/show_bug.cgi?id=40296
3468
3469         Added test for WebKitWebGLEnabled to
3470         LayoutTestController::overridePreference().
3471
3472         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3473         (LayoutTestController::overridePreference):
3474
3475 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3476
3477         Reviewed by Kenneth Rohde Christiansen.
3478
3479         [Qt] DRT EventSender support to graphics mouse events activation
3480         https://bugs.webkit.org/show_bug.cgi?id=40017
3481
3482         * DumpRenderTree/qt/EventSenderQt.cpp:
3483         (EventSender::mouseDown):
3484         (EventSender::mouseUp):
3485         (EventSender::mouseMoveTo):
3486         (EventSender::keyDown):
3487         (EventSender::contextClick):
3488         (EventSender::sendTouchEvent):
3489         (EventSender::sendOrQueueEvent):
3490         (EventSender::eventFilter):
3491         (EventSender::createGraphicsSceneMouseEvent):
3492         (EventSender::sendEvent):
3493         * DumpRenderTree/qt/EventSenderQt.h:
3494         (EventSender::isGraphicsBased):
3495
3496 2010-06-09  Adam Barth  <abarth@webkit.org>
3497
3498         Reviewed by Ojan Vafai.
3499
3500         webkit-patch upload fails for security bugs because there's no rietveld flag
3501         https://bugs.webkit.org/show_bug.cgi?id=40309
3502
3503         There's probably a more elegant way of seeing whether the form control
3504         exists, but this seems to work.
3505
3506         * Scripts/webkitpy/common/net/bugzilla.py:
3507
3508 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3509
3510         Reviewed by Adam Barth.
3511
3512         make rietveld upload faster and avoid posting to bug on errors
3513         https://bugs.webkit.org/show_bug.cgi?id=40389
3514
3515         Only grab the first item of the upload queue instead of trying
3516         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3517
3518         Also, don't post comments to the bug when uploading fails.
3519
3520         * Scripts/webkitpy/common/net/bugzilla.py:
3521         * Scripts/webkitpy/tool/commands/queues.py:
3522         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3523         * Scripts/webkitpy/tool/commands/stepsequence.py:
3524         * Scripts/webkitpy/tool/mocktool.py:
3525
3526 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3527
3528         Reviewed by Adam Barth.
3529
3530         Rietveld upload queue fails when setting in-rietveld flag
3531         https://bugs.webkit.org/show_bug.cgi?id=40371
3532
3533         Make the comment arguments to set_flag_on_attachment optional
3534         and add it to the MockBugzilla.
3535
3536         * Scripts/webkitpy/common/net/bugzilla.py:
3537         * Scripts/webkitpy/tool/bot/queueengine.py:
3538         * Scripts/webkitpy/tool/commands/download_unittest.py:
3539         * Scripts/webkitpy/tool/commands/queues.py:
3540         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3541         * Scripts/webkitpy/tool/mocktool.py:
3542
3543 2010-06-09  Kenneth Russell  <kbr@google.com>
3544
3545         Reviewed by Dimitri Glazkov.
3546
3547         Rename FloatArray to Float32Array
3548         https://bugs.webkit.org/show_bug.cgi?id=40323
3549
3550         Used do-webcore-rename to perform renaming. Manually undid
3551         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3552         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3553         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3554         all layout tests on Safari; built Chromium and ran selected WebGL
3555         tests.
3556
3557         * Scripts/do-webcore-rename:
3558
3559 2010-06-08  Tony Chang  <tony@chromium.org>
3560
3561         Reviewed by David Levin.
3562
3563         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3564         https://bugs.webkit.org/show_bug.cgi?id=40285
3565
3566         * Scripts/webkitdirs.pm:
3567         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3568
3569 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3570
3571         Reviewed by Tamura Kent.
3572
3573         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3574         https://bugs.webkit.org/show_bug.cgi?id=40052
3575         
3576         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3577
3578         * DumpRenderTree/DumpRenderTree.gypi:
3579         * DumpRenderTree/chromium/TestShellWin.cpp:
3580         (platformInit):
3581         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3582         (WebKit::):
3583         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3584         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3585         (WebKit::WebThemeControlDRT::box):
3586         (WebKit::WebThemeControlDRT::line):
3587         (WebKit::WebThemeControlDRT::triangle):
3588         (WebKit::WebThemeControlDRT::roundRect):
3589         (WebKit::WebThemeControlDRT::oval):
3590         (WebKit::WebThemeControlDRT::circle):
3591         (WebKit::WebThemeControlDRT::nestedBoxes):
3592         (WebKit::WebThemeControlDRT::markState):
3593         (WebKit::WebThemeControlDRT::draw):
3594         (WebKit::WebThemeControlDRT::drawTextField):
3595         (WebKit::WebThemeControlDRT::drawProgressBar):
3596         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3597         (WebKit::WebThemeControlDRT::):
3598         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3599         (WebKit::):
3600         (WebKit::WebThemeEngineDRT::paintButton):
3601         (WebKit::WebThemeEngineDRT::paintMenuList):
3602         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3603         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3604         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3605         (WebKit::WebThemeEngineDRT::paintTextField):
3606         (WebKit::WebThemeEngineDRT::paintTrackbar):
3607         (WebKit::WebThemeEngineDRT::paintProgressBar):
3608         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3609         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
3610
3611 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3612
3613         Unreviewed, rolling out r60878.
3614         http://trac.webkit.org/changeset/60878
3615         https://bugs.webkit.org/show_bug.cgi?id=40349
3616
3617         broke linux build (Requested by tony^work on #webkit).
3618
3619         * Scripts/webkitdirs.pm:
3620         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3621
3622 2010-06-08  Tony Chang  <tony@chromium.org>
3623
3624         Reviewed by David Levin.
3625
3626         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3627         https://bugs.webkit.org/show_bug.cgi?id=40285
3628
3629         * Scripts/webkitdirs.pm:
3630         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3631
3632 2010-06-08  Kenneth Russell  <kbr@google.com>
3633
3634         Unreviewed, build fix.
3635
3636         Fix build breakage from 38145
3637         https://bugs.webkit.org/show_bug.cgi?id=40346
3638
3639         The fix for bug 38145 broke the Chromium Win build because
3640         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
3641         change log2(x) to log(x) / log(2). Built and ran WebGL layout
3642         tests in Safari on Mac OS X. Changed download mirrors for
3643         python-irclib to working ones.
3644
3645         * Scripts/webkitpy/thirdparty/__init__.py:
3646
3647 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
3648
3649         Reviewed by Eric Seidel.
3650
3651         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3652         https://bugs.webkit.org/show_bug.cgi?id=39058
3653
3654         * Scripts/old-run-webkit-tests:
3655          use sourceDir() to find ensure-valid-python in checkPythonVersion()
3656
3657 2010-06-08  Andras Becsi  <abecsi@webkit.org>
3658
3659         Unreviewed buildfix after r60479.
3660
3661         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
3662         versions other than 2.17.3.
3663
3664         * DumpRenderTree/gtk/EventSender.cpp:
3665         (getRootCoords):
3666
3667 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
3668
3669         Reviewed by Oliver Hunt.
3670
3671         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
3672         https://bugs.webkit.org/show_bug.cgi?id=40267
3673
3674         When a mouse button is down, automatically queue mouse motion events and
3675         do not play them back until the mouse button is released. This matches the
3676         behavior of other ports' EventSenders.
3677
3678         * DumpRenderTree/gtk/EventSender.cpp:
3679         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
3680         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
3681
3682 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3683
3684         Reviewed by Sam Weinig.
3685
3686         Add CPP bindings generator
3687         https://bugs.webkit.org/show_bug.cgi?id=38279
3688
3689         Integrate CPP bindings in run-bindings-tests.
3690
3691         * Scripts/run-bindings-tests:
3692
3693 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3694
3695         Reviewed by Ojan Vafai.
3696
3697         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
3698         https://bugs.webkit.org/show_bug.cgi?id=40183
3699