2010-07-13 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Oliver Hunt.
4
5         Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
6         https://bugs.webkit.org/show_bug.cgi?id=42227
7
8         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
9         (WTR::LayoutTestController::LayoutTestController): Initialize new bool
10         members.
11         (WTR::LayoutTestController::display): Dummy method.
12         (WTR::displayCallback): Call the dummy.
13         (WTR::repaintSweepHorizontallyCallback): ditto
14         (WTR::testRepaintCallback): ditto
15         (WTR::LayoutTestController::staticFunctions): Expose new methods.
16         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
17         (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does
18         nothing).
19         (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
20
21 2010-07-13  Andreas Kling  <andreas.kling@nokia.com>
22
23         Unreviewed. Adding myself as committer.
24
25         * Scripts/webkitpy/common/config/committers.py:
26
27 2010-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
28
29         Reviewed by Darin Adler.
30
31         Prevent assertion/duplicate loads for non-deferred subtitute-data loads
32
33         https://bugs.webkit.org/show_bug.cgi?id=30879
34
35         MainResourceLoader uses the member m_initialRequest to store requests for future
36         deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
37         have to clear this request so that subsequent entries into the loader will not
38         start yet another load.
39
40         This can happen as a result of a PageGroupLoadDeferrer going out of scope when
41         returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
42         but only in the case of using both substitute-data and non-deferred main resource
43         load together. That's why two new DRT functions were added:
44
45          * queueLoadHTMLString()
46          * setDeferMainResourceLoad()
47
48         The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
49         and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
50         added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
51
52         * DumpRenderTree/LayoutTestController.cpp:
53         (LayoutTestController::LayoutTestController):
54         (queueLoadHTMLStringCallback):
55         (setDeferMainResourceDataLoadCallback):
56         (LayoutTestController::staticFunctions):
57         (LayoutTestController::queueLoadHTMLString):
58         * DumpRenderTree/LayoutTestController.h:
59         (LayoutTestController::deferMainResourceDataLoad):
60         (LayoutTestController::setDeferMainResourceDataLoad):
61         * DumpRenderTree/WorkQueueItem.h:
62         (LoadHTMLStringItem::LoadHTMLStringItem):
63         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
64         (LoadHTMLStringItem::invoke):
65         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
66         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
67         * DumpRenderTree/mac/WorkQueueItemMac.mm:
68         (LoadHTMLStringItem::invoke):
69         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
70         (LayoutTestController::reset):
71         (LayoutTestController::setDeferMainResourceDataLoad):
72         (LayoutTestController::queueLoadHTMLString):
73         * DumpRenderTree/qt/LayoutTestControllerQt.h:
74         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
75         (LoadHTMLStringItem::invoke):
76         * DumpRenderTree/qt/WorkQueueItemQt.h:
77         (LoadHTMLStringItem::LoadHTMLStringItem):
78         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
79         (ResourceLoadDelegate::willSendRequest):
80         * DumpRenderTree/win/WorkQueueItemWin.cpp:
81         (LoadHTMLStringItem::invoke):
82         * DumpRenderTree/wx/WorkQueueItemWx.cpp:
83         (LoadHTMLStringItem::invoke):
84
85 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
86
87         Reviewed by Nikolas Zimmermann.
88
89         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
90         https://bugs.webkit.org/show_bug.cgi?id=42153
91
92         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
93         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
94         (WTR::InjectedBundle::initialize): Activate fonts on startup.
95         * WebKitTestRunner/InjectedBundle/mac: Added.
96         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
97         (WTR::activateFonts): Activate our fonts.
98         * WebKitTestRunner/InjectedBundle/win: Added.
99         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
100         (WTR::activateFonts): Dummy version.
101         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
102         add more files.
103         * WebKitTestRunner/fonts: Added.
104         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
105         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
106         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
107         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
108         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
109         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
110         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
111         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
112         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
113         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
114         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
115         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
116         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
117         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
118
119 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
120
121         Reviewed by Eric Seidel.
122
123         Remove check-header-includes, as it didn't turn out to be very useful.
124         https://bugs.webkit.org/show_bug.cgi?id=41970
125
126         * Scripts/check-header-includes: Removed.
127
128 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
129
130         Reviewed by Maciej Stachowiak.
131
132         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
133         https://bugs.webkit.org/show_bug.cgi?id=40922
134         
135         Always build WebKit2 on Windows. Necessary since our WebKit build on
136         Windows is packaged into a DLL with WebKit2.
137
138         * Scripts/build-webkit: Always build WebKit2 on Windows.
139
140 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
141
142         Reviewed by Steve Falkenburg.
143
144         One http test timing out on Windows can cause all future tests to time out
145         https://bugs.webkit.org/show_bug.cgi?id=42146
146         
147         There have been multiple times on the Windows bots where one http test timing out causes all future
148         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
149         times out, we should restart httpd on Cygwin to prevent this.
150
151         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
152         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
153             using kill fails.
154
155 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
156
157         Reviewed by Dan Bernstein.
158
159         Remove use of auto_ptr in WebKitTestRunner
160         https://bugs.webkit.org/show_bug.cgi?id=42134
161         
162         Replaced auto_ptr with PassOwnPtr / OwnPtr.
163
164         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
165         (WTR::WKStringToUTF8):
166         (WTR::InjectedBundlePage::dump):
167         (WTR::InjectedBundlePage::addMessageToConsole):
168         * WebKitTestRunner/TestInvocation.cpp:
169         (WTR::WKStringToUTF8):
170         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
171
172 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
173
174         Reviewed by Sam Weinig.
175
176         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
177         https://bugs.webkit.org/show_bug.cgi?id=42132
178
179         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
180         platform directories.
181
182 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
183
184         Reviewed by Anders Carlsson.
185
186         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
187         https://bugs.webkit.org/show_bug.cgi?id=42126
188
189         * WebKitTestRunner/PlatformWebView.h:
190         * WebKitTestRunner/TestInvocation.cpp:
191         (WTR::TestInvocation::TestInvocation): Store the path as a C
192         string for later use.
193         (WTR::TestInvocation::~TestInvocation):
194         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
195         size, depending on whether this is a W3C SVG test.
196         (WTR::TestInvocation::invoke): Call the size function.
197         * WebKitTestRunner/TestInvocation.h:
198         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
199         (WTR::PlatformWebView::resizeTo): Implement.
200         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
201         (WTR::PlatformWebView::resizeTo): Placeholder.
202
203 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
204
205         Reviewed by Xan Lopez.
206
207         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
208         https://bugs.webkit.org/show_bug.cgi?id=38648
209
210         Add the GTK_MODULES envvar (set to "gail") to the clean
211         environment when running DRT for the Gtk+ port
212
213         * Scripts/old-run-webkit-tests:
214
215 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
216
217         Reviewed by Dirk Schulze.
218
219         [GTK] Support pixel tests
220         https://bugs.webkit.org/show_bug.cgi?id=31518
221
222         Finish support for pixel tests on GTK+.
223
224         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
225         works on CoreFoundation systems) and add missing cstdio include.
226         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
227         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
228         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
229         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
230         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
231         by the ANSI standard and this fails on Linux, so unroll the loop here.
232         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
233         (BitmapContext::BitmapContext): There is no reason to check the value of the
234         m_context member in the constructor and it certainly should not be freed. Instead
235         just initialize it with the incoming value.
236         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
237         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
238         dump pixels.
239         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
240         (createBitmapContextFromWebView):
241         * GNUmakefile.am: Add new files to the build.
242
243 2010-07-12  Adam Barth  <abarth@webkit.org>
244
245         Unreviewed.
246
247         Remove stray "raise e" that got included in a previous patch.  This
248         caused the EWS bots to turn red instead of purple when a patch failed
249         to apply.
250
251         * Scripts/webkitpy/tool/commands/stepsequence.py:
252
253 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
254
255         Unreviewed, rolling out r63101.
256         http://trac.webkit.org/changeset/63101
257         https://bugs.webkit.org/show_bug.cgi?id=42103
258
259         Broke one API test (Requested by xan_ on #webkit).
260
261         * Scripts/old-run-webkit-tests:
262
263 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
264
265         Reviewed by Adam Roben.
266
267         https://bugs.webkit.org/show_bug.cgi?id=13075
268         XMLHttpRequest with failed authentication should set status to 401
269
270         https://bugs.webkit.org/show_bug.cgi?id=6871
271         <rdar://problem/3363403> 401 error page is never shown
272
273         Fix crashes in Windows DumpRenderTree.
274
275         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
276         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
277         again on a destroyed sender.
278
279 2010-07-12  Adam Roben  <aroben@apple.com>
280
281         Windows failure-to-launch fix
282
283         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
284         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
285         we already do for CoreFoundation, CFNetwork, etc.
286
287 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
288
289         Reviewed by Xan Lopez.
290
291         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
292         https://bugs.webkit.org/show_bug.cgi?id=38648
293
294         Add the GTK_MODULES envvar (set to "gail") to the clean
295         environment when running DRT for the Gtk+ port
296
297         * Scripts/old-run-webkit-tests:
298
299 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
300
301         Reviewed by Darin Adler.
302
303         https://bugs.webkit.org/show_bug.cgi?id=13075
304         XMLHttpRequest with failed authentication should set status to 401
305
306         https://bugs.webkit.org/show_bug.cgi?id=6871
307         <rdar://problem/3363403> 401 error page is never shown
308
309         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
310         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
311         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
312         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
313         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
314         the Cancel button.
315
316 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
317
318         Reviewed by Tor Arne Vestbø.
319
320         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
321         https://bugs.webkit.org/show_bug.cgi?id=42082
322
323         * QtTestBrowser/main.cpp:
324         (LauncherWindow::createChrome):
325         * QtTestBrowser/mainwindow.cpp:
326         (MainWindow::openLocation):
327         * QtTestBrowser/mainwindow.h:
328
329 2010-07-12  Adam Roben  <aroben@apple.com>
330
331         Make the Python autoinstaller not use a dead SourceForge server
332
333         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
334         offline SourceForge server
335
336         Reviewed by Anders Carlsson.
337
338         * Scripts/webkitpy/thirdparty/__init__.py: Use
339         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
340         which seems to be down.
341
342 2010-07-12  Adam Roben  <aroben@apple.com>
343
344         Make run-webkit-tests print how many tests timed out when exiting
345         early
346
347         The number of timed-out tests is taken into account when deciding
348         whether to exit early. Leaving it out of the output just makes the
349         script look buggy (because it might say something like "Exiting early
350         after 0 crashes.").
351
352         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
353         messages when exiting early due to crashes and time-outs
354
355         Reviewed by Anders Carlsson.
356
357         * Scripts/old-run-webkit-tests:
358         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
359         timed-out tests, too.
360
361 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
362
363         Reviewed by Dan Bernstein.
364
365         Implement animation-related methods for WebKitTestRunner
366         https://bugs.webkit.org/show_bug.cgi?id=42053
367         
368         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
369         animation tests were hanging otherwise.
370
371         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
372         (WTR::LayoutTestController::numberOfActiveAnimations):
373         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
374         (WTR::numberOfActiveAnimationsCallback):
375         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
376         (WTR::LayoutTestController::staticFunctions):
377         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
378
379 2010-07-11  Daniel Bates  <dbates@rim.com>
380
381         Reviewed by David Kilzer.
382
383         Enable executable support for svn-apply and svn-unapply
384         https://bugs.webkit.org/show_bug.cgi?id=39409
385
386         Connect up the Git and SVN executable bit support in parseDiff() so that
387         executable bit changes are propagated via the returned diff hash to the
388         patch function in svn-apply and svn-unapply.
389
390         * Scripts/VCSUtils.pm:
391           - Modified parseDiff() to call parseSvnDiffProperties when
392             it finds the start of an SVN property change diff.
393           - Removed FIXME comment above parseSvnDiffProperties() since
394             it is now being used by parseDiff().
395           - Export method scmToggleExecutableBit() now that we added the
396             executableBitDelta hash key. (This should have been exported
397             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
398         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
399           - Updated results for:
400             "rename (with executable bit change)"
401               - Test value of executableBitDelta (now that we have support).
402             "SVN: binary file (isBinary true)"
403               - Remove the property change diff from svnConvertedText. We plan
404                 to remove svnConvertedText in the future. So, we decided
405                 against adding such support to any new code, such as the
406                 property parsing routines. Therefore, we do not keep SVN
407                 converted text for property change diffs.
408           - Added unit tests:
409             "SVN: file change diff with property change diff"
410             "SVN: file change diff, followed by property change diff on different file"
411             "SVN: property diff, followed by file change diff"
412             "SVN: copied file with property change"
413             "SVN: two consecutive property diffs"
414             "SVN: binary file with executable bit change"
415             "SVN: binary file followed by property change on different file"
416             "SVN: binary file followed by file change on different file"
417             "SVN: file change diff with property change, followed by property change diff"
418             "SVN: file change diff with property change, followed by file change diff"
419
420 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
421
422         Reviewed by Dan Bernstein.
423
424         Implement waitUntilDone and notifyDone for WebKitTestRunner
425         https://bugs.webkit.org/show_bug.cgi?id=42049
426
427         With this fix, most of the DOM tests pass.
428         
429         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
430         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
431         a great way to do it in the future case where we may get multiple
432         pages - we really need a way to send it over from the ui process.
433         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
434         (WTR::InjectedBundle::page): A way to get the main page.
435         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
436         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
437         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
438         are loading.
439         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
440         called by the layout test controller. Also, cancel any pending watchdogs.
441         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
442         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
443         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
444         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
445         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
446         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
447         to false.
448         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
449         the watchdog.
450         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
451         (WTR::LayoutTestController::setWaitToDump): Set the flag.
452         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
453         where waitUntilDone times out.
454         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
455         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
456         (WTR::notifyDoneCallback): JS glue for notifyDone.
457         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
458         to the layoutController.
459         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
460         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
461
462 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
463
464         Rubber-stamped by Dan Bernstein.
465
466         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
467         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
468         slow down the tests).
469
470         * Scripts/webkitpy/common/system/executive.py:
471
472 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
473
474         Reviewed by Kenneth Rohde Christiansen.
475
476         [Qt] Mac build fix
477         https://bugs.webkit.org/show_bug.cgi?id=41967
478
479         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
480
481         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
482
483 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
484
485         Reviewed by Antonio Gomes.
486
487         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
488         https://bugs.webkit.org/show_bug.cgi?id=41966
489
490         * MiniBrowser/qt/BrowserWindow.cpp:
491         (BrowserWindow::BrowserWindow):
492
493 2010-07-09  Leon Clarke  <leonclarke@google.com>
494
495         Reviewed by Adam Barth.
496
497         add support for link prefetching
498         https://bugs.webkit.org/show_bug.cgi?id=3652
499
500         * Scripts/build-webkit:
501
502 2010-07-09  Ojan Vafai  <ojan@chromium.org>
503
504         Reviewed by Adam Barth.
505
506         r63004 broke some python tests
507         https://bugs.webkit.org/show_bug.cgi?id=42007
508
509         AbstractStep now checks options.no_squash and options.squash, so
510         they needed to have real values. Mock would return an object for those,
511         which would then act as if the values were True.
512
513         * Scripts/webkitpy/tool/commands/commandtest.py:
514         * Scripts/webkitpy/tool/commands/download_unittest.py:
515         * Scripts/webkitpy/tool/commands/stepsequence.py:
516         * Scripts/webkitpy/tool/commands/upload_unittest.py:
517         * Scripts/webkitpy/tool/mocktool.py:
518         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
519         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
520         * Scripts/webkitpy/tool/steps/steps_unittest.py:
521         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
522         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
523
524 2010-07-09  Ojan Vafai  <ojan@chromium.org>
525
526         Reviewed by Adam Barth.
527
528         --squash should go away and become the default
529         https://bugs.webkit.org/show_bug.cgi?id=39624
530
531         If there are local commits and working copy changes, then prompt the user
532         whether to continue. Setting git config webkit-patch.commit_should_always_squash
533         true bypasses the prompt.
534
535         --git-commit=HEAD.. operates on working copy changes only.
536         --git-commit=committish operates on a range of commits as a single commit.
537             e.g. --git-commit=HEAD only operates on the HEAD commit.
538             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
539
540         --no-squash and --squash are left in with descriptive error messages if used.
541
542         * Scripts/check-webkit-style:
543         * Scripts/webkitpy/common/checkout/api.py:
544         * Scripts/webkitpy/common/checkout/api_unittest.py:
545         * Scripts/webkitpy/common/checkout/scm.py:
546         * Scripts/webkitpy/common/checkout/scm_unittest.py:
547         * Scripts/webkitpy/common/net/rietveld.py:
548         * Scripts/webkitpy/common/system/user.py:
549         * Scripts/webkitpy/style/optparser.py:
550         * Scripts/webkitpy/style_references.py:
551         * Scripts/webkitpy/tool/commands/download.py:
552         * Scripts/webkitpy/tool/commands/upload.py:
553         * Scripts/webkitpy/tool/mocktool.py:
554         * Scripts/webkitpy/tool/steps/abstractstep.py:
555         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
556         * Scripts/webkitpy/tool/steps/checkstyle.py:
557         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
558         * Scripts/webkitpy/tool/steps/commit.py:
559         * Scripts/webkitpy/tool/steps/options.py:
560         * Scripts/webkitpy/tool/steps/preparechangelog.py:
561         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
562         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
563         * Scripts/webkitpy/tool/steps/validatereviewer.py:
564
565 2010-07-09  Mark Rowe  <mrowe@apple.com>
566
567         Add two new Windows test build slaves.
568
569         * BuildSlaveSupport/build.webkit.org-config/config.json:
570
571 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
572
573         Reviewed by David Levin.
574
575         rebaseline_chromium_webkit_tests missing --use_drt option on linux
576         https://bugs.webkit.org/show_bug.cgi?id=41985
577
578         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
579         so that it works on linux. This is essentially a "compile-fix" for the
580         script.
581
582         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
583
584 2010-07-09  Nico Weber  <thakis@chromium.org>
585
586         Unreviewed. Adding myself as committer.
587
588         * Scripts/webkitpy/common/config/committers.py:
589
590 2010-07-09  David Kilzer  <ddkilzer@apple.com>
591
592         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
593
594         This reverts commit r62692.
595
596         * Scripts/commit-log-editor:
597
598 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
599
600         Reviewed by Ojan Vafai.
601
602         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
603         https://bugs.webkit.org/show_bug.cgi?id=38693
604
605         Introduced a new base class JSONResultsGeneratorBase that doesn't
606         have any dependency on layout_tests packages.
607         Turned JSONResultsGenerator into a wrapper class of the base class
608         so that the old code can work with it during the cleanup.
609
610         Added json_results_generator_unittest.py.
611
612         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
613         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
614         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
615
616 2010-07-09  Abhishek Arya  <inferno@chromium.org>
617
618         Unreviewed.
619
620         Marking myself as a committer.
621
622         * Scripts/webkitpy/common/config/committers.py:
623
624 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
625
626         Reviewed by Antti Koivisto.
627
628         Implement MiniBrowser for Qt.
629         https://bugs.webkit.org/show_bug.cgi?id=40233
630
631         * MiniBrowser/qt/BrowserWindow.cpp: Added.
632         (createNewPage):
633         (BrowserView::BrowserView):
634         (BrowserView::resizeEvent):
635         (BrowserView::load):
636         (BrowserView::view):
637         (BrowserWindow::BrowserWindow):
638         (BrowserWindow::load):
639         (BrowserWindow::changeLocation):
640         (BrowserWindow::~BrowserWindow):
641         * MiniBrowser/qt/BrowserWindow.h: Added.
642         (BrowserView::~BrowserView):
643         * MiniBrowser/qt/MiniBrowser.pro: Added.
644         * MiniBrowser/qt/main.cpp: Added.
645         (main):
646
647 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
648
649         Reviewed by Simon Hausmann.
650
651         Introduce the Qt autotest launcher.
652
653         Qt autotests should be executed more frequently, ideally by the Qt
654         build bot. This is the first step to provide the tests more accessible.
655
656         [Qt] It should be easier to run all Qt's autotests.
657         https://bugs.webkit.org/show_bug.cgi?id=31625
658
659         * Scripts/run-qtwebkit-tests: Added.
660
661 2010-07-09  Adam Barth  <abarth@webkit.org>
662
663         Reviewed by Eric Seidel.
664
665         commit-queue should merge to TOT when checkout needs update
666         https://bugs.webkit.org/show_bug.cgi?id=41944
667
668         There are a bunch of different designs that are possible here.  This
669         one merges to top of tree by cleaning out the working copy and
670         re-applying the patch.  Once you decide to merge that way, you need to
671         decide who's going to retry.  In this patch, we retry in the child
672         process instead of plumbing the failure reason to the master process.
673
674         This patch is difficult to test end-to-end, but hopefully it will work.
675         :)
676
677         * Scripts/webkitpy/tool/commands/queues.py:
678         * Scripts/webkitpy/tool/commands/stepsequence.py:
679         * Scripts/webkitpy/tool/multicommandtool.py:
680         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
681
682 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
683
684         Reviewed by Darin Adler.
685
686         Add a script to check for unnecessary includes in header files.
687         https://bugs.webkit.org/show_bug.cgi?id=41894
688
689         * Scripts/check-header-includes: Added.
690
691 2010-07-09  Adam Barth  <abarth@webkit.org>
692
693         Reviewed by Eric Seidel.
694
695         Add --html5-treebuilder option to run-webkit-tests
696         https://bugs.webkit.org/show_bug.cgi?id=41922
697
698         We're down to one or two regressions in the HTML5lib test suite.  It's
699         getting to be time to look at fixing LayoutTests.
700
701         * Scripts/old-run-webkit-tests:
702
703 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
704
705         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
706         in the drawing model never getting set on Tiger.
707
708         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
709         (NPP_New):
710
711 2010-07-08  Aaron Boodman  <aa@chromium.org>
712
713         Reviewed by Timothy Hatcher.
714
715         Add the ability for user scripts and user styles to affect just the top frame.
716
717         https://bugs.webkit.org/show_bug.cgi?id=41529
718
719         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
720         * DumpRenderTree/LayoutTestController.cpp: Ditto.
721         (addUserScriptCallback):
722         (addUserStyleSheetCallback):
723         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
724         (LayoutTestController::addUserScript):
725         (LayoutTestController::addUserStyleSheet):
726         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
727         (LayoutTestController::addUserScript):
728         (LayoutTestController::addUserStyleSheet):
729         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
730         (LayoutTestController::addUserScript):
731         (LayoutTestController::addUserStyleSheet):
732         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
733         (LayoutTestController::addUserScript):
734         (LayoutTestController::addUserStyleSheet):
735         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
736         (LayoutTestController::addUserScript):
737         (LayoutTestController::addUserStyleSheet):
738
739 2010-07-08  Adele Peterson  <adele@apple.com>
740
741         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
742
743         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
744         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
745
746         Log when the missing plugin button is pressed.
747
748         * DumpRenderTree/mac/UIDelegate.mm:
749         (-[UIDelegate webView:didPressMissingPluginButton:]):
750         * DumpRenderTree/win/UIDelegate.cpp:
751         (UIDelegate::QueryInterface):
752         (UIDelegate::createWebViewWithRequest):
753         (UIDelegate::drawBackground):
754         (UIDelegate::decidePolicyForGeolocationRequest):
755         (UIDelegate::didPressMissingPluginButton):
756         * DumpRenderTree/win/UIDelegate.h:
757
758 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
759
760         Fix the Tiger build.
761
762         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
763         (NPP_New):
764
765 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
766
767         Fix windows build.
768
769         #ifdef code for Mac.
770
771         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
772         (NPP_New):
773
774 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
775
776         Reviewed by Anders Carlsson.
777
778         Allow the TestPlugin to use Core Animation rendering for testing
779         https://bugs.webkit.org/show_bug.cgi?id=41872
780         
781         Add the ability for the TestPlugin to use the CoreAnimation rendering model
782         when available, based on the "drawingmodel" attribute of the embed tag:
783             drawingmodel="coreanimation"
784
785         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
786         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
787         when building on Tiger. Add a void* coreAnimationLayer member.
788         
789         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
790         (createCoreAnimationLayer): Obj-C method to create the CALayer.
791         
792         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
793         (NPP_New): Look for the drawingmodel attribute to decide which drawing
794         model to use.
795         (NPP_Destroy): Release the CALayer if we have one.
796         (NPP_GetValue): Return the retained CALayer.
797
798 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
799
800         Reviewed by Xan Lopez.
801
802         [GTK] Support pixel tests
803         https://bugs.webkit.org/show_bug.cgi?id=31518
804
805         Convert this file from CRLF to NL line endings. It will soon
806         be used on more than just the WinCairo platform.
807
808         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
809         (writeFunction):
810         (printPNG):
811         (computeMD5HashStringForBitmapContext):
812         (dumpBitmap):
813
814 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
815
816         Reviewed by Darin Adler.
817
818         Enable Data Execution Prevention for our test harnesses on Windows
819         https://bugs.webkit.org/show_bug.cgi?id=41882
820
821         * DumpRenderTree/win/DumpRenderTree.vcproj:
822         * DumpRenderTree/win/ImageDiff.vcproj:
823         * WebKitAPITest/WebKitAPITest.vcproj:
824         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
825
826 2010-07-07  Robert Hogan  <robert@webkit.org>
827
828         Reviewed by Kenneth Rohde Christiansen.
829
830         [Qt] Add DRT support for pageProperty etc.
831
832         https://bugs.webkit.org/show_bug.cgi?id=41584
833
834         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
835         (LayoutTestController::isPageBoxVisible):
836         (LayoutTestController::pageSizeAndMarginsInPixels):
837         (LayoutTestController::pageProperty):
838         (LayoutTestController::addUserStyleSheet):
839         * DumpRenderTree/qt/LayoutTestControllerQt.h:
840
841 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
842
843         Reviewed by Xan Lopez.
844
845         Remove a warnings from the ImageDiff build by using the proper
846         printf format string for the gsize data type.
847
848         * DumpRenderTree/gtk/ImageDiff.cpp:
849         (printImage): Use the proper printf format string for the gsize data type.
850
851 2010-07-08  Alice Liu  <alice.liu@apple.com>
852
853         Reviewed by Sam Weinig.
854
855         https://bugs.webkit.org/show_bug.cgi?id=41653
856         Add new WebKitTestRunner project for Windows
857
858         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
859         Similar to how it's done in DumpRenderTree, define max and min early
860         on so that they don't get replaced by a macro requiring 2 arguments.
861
862         * WebKitTestRunner/win: Added.
863         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
864         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
865         * WebKitTestRunner/win/main.cpp: Added.
866         (main): Implemented
867
868         Added these files with stubbed out functions:
869         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
870         (WTR::PlatformWebView::PlatformWebView):
871         (WTR::PlatformWebView::~PlatformWebView):
872         (WTR::PlatformWebView::page):
873         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
874         (WTR::TestController::initializeInjectedBundlePath):
875         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
876         (WTR::TestInvocation::runUntil):
877
878 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
879
880         Reviewed by Gustavo Noronha Silva.
881
882         [GTK] Implement ImageDiff and add it to the build system
883         https://bugs.webkit.org/show_bug.cgi?id=41779
884
885         Add the initial implementation of the ImageDiff tool for the GTK+
886         port. This is an essential tool for doing pixel tests. The implementation
887         is based on the Mac and Chromium ports.
888
889         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
890         (readPixbufFromStdin): Added.
891         (differenceImageFromDifferenceBuffer): Ditto.
892         (calculateDifference): Ditto.
893         (printImage): Ditto.
894         (printImageDifferences): Ditto.
895         (main): Ditto.
896         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
897
898 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
899
900         Unreviewed. Adding myself as a committer.
901
902         * Scripts/webkitpy/common/config/committers.py:
903
904 2010-07-08  Adam Roben  <aroben@apple.com>
905
906         Make Windows stop running tests from platform/mac
907
908         r62742 made a change (at my suggestion!) that caused us to start
909         looking for tests in platform/mac, rather than just looking for
910         expected results in platform/mac. This patch just undoes that part of
911         r62742.
912
913         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
914         tests from platform/mac, but shouldn't
915
916         Reviewed by Antti Koivisto and Anders Carlsson.
917
918         * Scripts/old-run-webkit-tests:
919         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
920         so we won't look in those directories for tests to run.
921         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
922         platform/mac-snowleopard and platform/mac for expected results.
923
924 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
925
926         Unreviewed. Adding myself as a reviewer.
927
928         * Scripts/webkitpy/common/config/committers.py:
929
930 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
931
932         Update my e-mail in committers.py
933
934         * Scripts/webkitpy/common/config/committers.py:
935
936 2010-07-07  Daniel Bates  <dbates@rim.com>
937
938         Reviewed by Dumitru Daniliuc.
939
940         VCSUtils.pm complains about uninitialized value $newLine
941         https://bugs.webkit.org/show_bug.cgi?id=41333
942
943         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
944         an array when fixing a change log entry that overlaps with an earlier
945         entry. In particular, when a patch contains a change log entry inserted
946         earlier in the change log file, but after an entry with the same author
947         and date.
948
949         * Scripts/VCSUtils.pm:
950             - Added for-loop constraint to fixChangeLogPatch() so that it does not
951               read off the end of the @overlappingLines array.
952         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
953
954 2010-07-07  Anders Carlsson  <andersca@apple.com>
955
956         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
957
958         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
959         (NPP_New):
960
961 2010-07-07  Kent Tamura  <tkent@chromium.org>
962
963         Reviewed by Adam Barth.
964
965         [DRT/Chromium] Support for indeterminate checkbox
966         https://bugs.webkit.org/show_bug.cgi?id=41747
967
968         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
969
970         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
971         (WebThemeControlDRT::draw):
972         * DumpRenderTree/chromium/WebThemeControlDRT.h:
973         (WebThemeControlDRT::):
974         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
975         (WebThemeEngineDRT::paintButton):
976
977 2010-07-07  Sam Weinig  <sam@webkit.org>
978
979         Reviewed by Mark Rowe.
980
981         Clean up MiniBrowser Xcode project.
982
983         - Use xcconfig files.
984         - Rename plists to canonical Info.plist
985         - Remove localizations.
986
987         * MiniBrowser/Configurations: Added.
988         * MiniBrowser/Configurations/Base.xcconfig: Added.
989         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
990         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
991         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
992         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
993         * MiniBrowser/WebBundle-Info.plist: Removed.
994         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
995         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
996         * MiniBrowser/mac/BrowserWindow.xib: Added.
997         * MiniBrowser/mac/BrowserWindowController.m:
998         (-[BrowserWindowController initWithPageNamespace:]):
999         * MiniBrowser/mac/English.lproj: Removed.
1000         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
1001         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
1002         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
1003         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
1004         * MiniBrowser/mac/MainMenu.xib: Added.
1005         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
1006         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
1007
1008 2010-07-07  Kent Tamura  <tkent@chromium.org>
1009
1010         Reviewed by Dimitri Glazkov.
1011
1012         [DRT/Chromium] Fix two regressions
1013         https://bugs.webkit.org/show_bug.cgi?id=41745
1014
1015         * DumpRenderTree/chromium/WebViewHost.cpp:
1016         (WebViewHost::paintInvalidatedRegion):
1017          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
1018          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
1019          though test_shell does it twice. Probably DRT needs it because
1020          DRT delays painting as possible.
1021
1022 2010-07-07  Anders Carlsson  <andersca@apple.com>
1023
1024         Try to fix build.
1025
1026         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1027         (webkit_test_plugin_destroy_stream):
1028
1029 2010-07-07  Anders Carlsson  <andersca@apple.com>
1030
1031         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
1032
1033         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1034         (webkit_test_plugin_new_stream):
1035         (webkit_test_plugin_destroy_stream):
1036         (webkit_test_plugin_write_ready):
1037         (webkit_test_plugin_write):
1038
1039 2010-07-07  Sam Weinig  <sam@webkit.org>
1040
1041         Reviewed by Mark Rowe.
1042
1043         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
1044
1045         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1046
1047 2010-07-07  Anders Carlsson  <andersca@apple.com>
1048
1049         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
1050
1051         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1052         (NPP_New):
1053         (NPP_HandleEvent):
1054
1055 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1056
1057         Reviewed by Adam Roben.
1058
1059         Need to have a way to specify different results for Windows XP and 7
1060         https://bugs.webkit.org/show_bug.cgi?id=41776
1061         
1062         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
1063         subdirectories, so we can have different results for tests on Windows XP, Windows
1064         Vista, and Windows 7.
1065
1066         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
1067         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
1068         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
1069
1070         This matches the behavior of the mac.
1071
1072         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
1073             or Vista, try looking in other win-* subdirectories before win.
1074         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
1075             we are running.
1076
1077 2010-07-07  Kent Tamura  <tkent@chromium.org>
1078
1079         Reviewed by Dimitri Glazkov.
1080
1081         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
1082         https://bugs.webkit.org/show_bug.cgi?id=41753
1083
1084         The original code of the following functions in
1085         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
1086         ASSERT_NOT_REACHED(). The program shouldn't stop at these
1087         functions.
1088
1089         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1090         (DRTDevToolsClient::activateWindow):
1091         (DRTDevToolsClient::closeWindow):
1092         (DRTDevToolsClient::dockWindow):
1093         (DRTDevToolsClient::undockWindow):
1094
1095 2010-07-07  Anders Carlsson  <andersca@apple.com>
1096
1097         Reviewed by Sam Weinig.
1098
1099         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
1100         https://bugs.webkit.org/show_bug.cgi?id=41821
1101
1102         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1103         (pluginGetProperty):
1104         (pluginSetProperty):
1105         (pluginAllocate):
1106         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1107         Add and initialize the returnNegativeOneFromWrite property.
1108
1109         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1110         (NPP_NewStream):
1111         Set the stream type to NP_NORMAL so we'll get write callbacks.
1112
1113         (NPP_DestroyStream):
1114         Treat the onstreamdestroy attribute as a function name and not a string.
1115
1116         (NPP_WriteReady):
1117         Have this return a nonzero value.
1118
1119         (NPP_Write):
1120         If returnNegativeOneFromWrite is true return -1.
1121
1122 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1123
1124         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
1125         latest version is selected by default, and allows the version to be specified.
1126
1127         * wx/build/settings.py:
1128
1129 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
1130
1131         Reviewed by Darin Adler.
1132
1133         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
1134         https://bugs.webkit.org/show_bug.cgi?id=41810
1135
1136         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1137         (AccessibilityUIElement::selectedTextRange):
1138
1139 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
1140
1141         Unreviewed.
1142
1143         Build fix after r62700.
1144
1145         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
1146         source file locations.
1147
1148 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1149
1150         Reviewed by David Levin.
1151
1152         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
1153         https://bugs.webkit.org/show_bug.cgi?id=41814
1154
1155         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1156         * Scripts/old-run-webkit-tests:
1157
1158 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1159
1160         Reviewed by David Levin.
1161
1162         add --exit-after-n-crashes to run-webkit-tests
1163         https://bugs.webkit.org/show_bug.cgi?id=41811
1164
1165         Change the bots at build.webkit.org to use --exit-after-n-crashes
1166         instead of --exit-after-n-failures since we want to be able to have
1167         more than 20 failures on those bots, but more than 20 crashes means
1168         something should be rolled out.
1169
1170         * Scripts/old-run-webkit-tests:
1171         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1172
1173 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1174
1175         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
1176         TestNetscapePlugin project, because this was removed from the tree.
1177
1178         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1179
1180 2010-07-07  Anders Carlsson  <andersca@apple.com>
1181
1182         Reviewed by Simon Fraser.
1183
1184         Unify Mac and Windows TestNetscapePlugin main.cpp files
1185         https://bugs.webkit.org/show_bug.cgi?id=41798
1186         
1187         * DumpRenderTree/DumpRenderTree.sln:
1188         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1189         (strcasecmp):
1190         (NP_Initialize):
1191         (NP_GetEntryPoints):
1192         (NP_Shutdown):
1193         (NPP_New):
1194         (NPP_Destroy):
1195         (NPP_HandleEvent):
1196         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1197         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
1198
1199 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1200
1201         [wx] Build fix. pageProperty needs to return a value.
1202
1203         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1204         (LayoutTestController::pageProperty):
1205
1206 2010-07-07  David Kilzer  <ddkilzer@apple.com>
1207
1208         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
1209
1210         Reviewed by Anders Carlsson.
1211
1212         For both svn and git, commit-log-editor is invoked from the root
1213         of the working directory.  Unlike svn, git returns a list of
1214         changed files that are relative to the directory where the
1215         command was invoked.  This caused the ChangeLog file in the root
1216         directory to be read instead of the ChangeLog in the current
1217         directory.
1218
1219         The fix is to use $ENV{PWD} as the base directory when fixing
1220         the path to the ChangeLog files.  With svn, this has no net
1221         effect since $ENV{PWD} is the root of the working directory and
1222         the ChangeLog paths are already relative to that directory.
1223         With git, $ENV{PWD} is the directory that the commit was invoked
1224         from, which fixes the ChangeLog paths so that the correct files
1225         are read when creating the commit log entry.
1226
1227         Note that the call to makeFilePathRelative() was supposed to
1228         address this issue, but it doesn't because (a) it does nothing
1229         with svn working directories by design, and (b) it does nothing
1230         with git working directories because it's invoked when the
1231         current directory is the root of the working directory, thus
1232         giving no relative path.
1233
1234         * Scripts/commit-log-editor: Removed call to
1235         makeFilePathRelative() since since it does nothing.  Moved code
1236         to fix up $changeLog path so that it's fixed before trying to
1237         open the file, and use $ENV{PWD} as the base path.  Also use
1238         canonicalizePath() to clean up paths with "../" in them.
1239
1240 2010-07-07  Anders Carlsson  <andersca@apple.com>
1241
1242         Another attempt at fixing the Qt build.
1243
1244         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1245
1246 2010-07-07  Anders Carlsson  <andersca@apple.com>
1247
1248         Try to fix Qt build.
1249
1250         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1251
1252 2010-07-07  Anders Carlsson  <andersca@apple.com>
1253
1254         Reviewed by Simon Fraser.
1255
1256         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
1257         https://bugs.webkit.org/show_bug.cgi?id=41781
1258
1259         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1260         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
1261         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
1262         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
1263         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
1264         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
1265         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
1266         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
1267         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
1268         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
1269         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
1270         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
1271         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
1272
1273 2010-07-07  Andras Becsi  <abecsi@webkit.org>
1274
1275         Unreviewed trivial fix.
1276
1277         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
1278         which was checked in accidentally in r62635.
1279
1280         * Scripts/webkitpy/layout_tests/port/webkit.py:
1281
1282 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1283
1284         Reviewed by Eric Seidel.
1285
1286         Pass port specific environment to server process.
1287         https://bugs.webkit.org/show_bug.cgi?id=41593
1288
1289         * Scripts/webkitpy/layout_tests/port/qt.py:
1290         * Scripts/webkitpy/layout_tests/port/webkit.py:
1291
1292 2010-07-06  Kent Tamura  <tkent@chromium.org>
1293
1294         Reviewed by Shinichiro Hamaji.
1295
1296         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
1297         https://bugs.webkit.org/show_bug.cgi?id=41644
1298
1299         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
1300         tolerance. We don't need tolerance for rebaseline.
1301
1302         * Scripts/webkitpy/layout_tests/port/base.py:
1303           Add optional tolerance parameter to diff_image().
1304         * Scripts/webkitpy/layout_tests/port/test.py:
1305           Add optional tolerance parameter to diff_image().
1306         * Scripts/webkitpy/layout_tests/port/webkit.py:
1307           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
1308         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1309           diff_files() always calls diff_image() with tolerance=0.
1310           diff_files() is used only by rebaseline-chromium-webkit-tests.
1311
1312 2010-07-06  Sam Weinig  <sam@webkit.org>
1313
1314         Fix MiniBrowser build.
1315
1316         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1317
1318 2010-07-06  Sam Weinig  <sam@webkit.org>
1319
1320         Reviewed by Anders Carlsson.
1321
1322         Add support for dumping the contents of messages to the console to WebKitTestRunner
1323
1324         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1325         (WTR::InjectedBundlePage::InjectedBundlePage):
1326         (WTR::InjectedBundlePage::_addMessageToConsole):
1327         (WTR::InjectedBundlePage::addMessageToConsole):
1328         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1329
1330 2010-07-06  Sam Weinig  <sam@webkit.org>
1331
1332         Reviewed by Anders Carlsson.
1333
1334         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
1335         Add dumpAsText support for WebKitTestRunner
1336
1337         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1338         (WTR::InjectedBundle::InjectedBundle):
1339         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
1340         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1341         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
1342         API to dump the main frames text.
1343
1344 2010-07-06  Darin Adler  <darin@apple.com>
1345
1346         Fix Chromium build.
1347
1348         * DumpRenderTree/chromium/WebViewHost.cpp:
1349         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
1350         (WebViewHost::didNavigateWithinPage): Ditto.
1351         (WebViewHost::updateURL): Ditto.
1352
1353 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
1354
1355         Reviewed by Xan Lopez.
1356
1357         [GTK] build-webkit should not run autogen.sh unconditionally
1358         https://bugs.webkit.org/show_bug.cgi?id=41704
1359
1360         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
1361         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
1362         some very minor cleanup.
1363
1364 2010-07-06  Darin Adler  <darin@apple.com>
1365
1366         Try to fix Chromium build.
1367
1368         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
1369
1370 2010-07-06  Darin Adler  <darin@apple.com>
1371
1372         Fix build.
1373
1374         * WebKitAPITest/TestsController.cpp:
1375         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
1376
1377 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
1378
1379         Reviewed by Kent Tamura.
1380
1381         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
1382         https://bugs.webkit.org/show_bug.cgi?id=40558
1383
1384         Upstream DevTools for Chromium DRT.
1385         (original Chromium files rev. 51287)
1386
1387         * DumpRenderTree/DumpRenderTree.gypi:
1388         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
1389         (DRTDevToolsAgent::DRTDevToolsAgent):
1390         (DRTDevToolsAgent::setWebView):
1391         (DRTDevToolsAgent::sendMessageToFrontend):
1392         (DRTDevToolsAgent::forceRepaint):
1393         (DRTDevToolsAgent::runtimeFeatureStateChanged):
1394         (DRTDevToolsAgent::injectedScriptSource):
1395         (DRTDevToolsAgent::injectedScriptDispatcherSource):
1396         (DRTDevToolsAgent::debuggerScriptSource):
1397         (DRTDevToolsAgent::asyncCall):
1398         (DRTDevToolsAgent::call):
1399         (DRTDevToolsAgent::webDevToolsAgent):
1400         (DRTDevToolsAgent::attach):
1401         (DRTDevToolsAgent::detach):
1402         (DRTDevToolsAgent::setTimelineProfilingEnabled):
1403         (DRTDevToolsAgent::evaluateInWebInspector):
1404         (DRTDevToolsAgent::dispatchMessageLoop):
1405         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
1406         (DRTDevToolsAgent::~DRTDevToolsAgent):
1407         (DRTDevToolsAgent::hostIdentifier):
1408         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
1409         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1410         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1411         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
1412         (DRTDevToolsCallArgs::callsCount):
1413         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
1414         (DRTDevToolsClient::DRTDevToolsClient):
1415         (DRTDevToolsClient::~DRTDevToolsClient):
1416         (DRTDevToolsClient::sendMessageToAgent):
1417         (DRTDevToolsClient::sendDebuggerCommandToAgent):
1418         (DRTDevToolsClient::activateWindow):
1419         (DRTDevToolsClient::closeWindow):
1420         (DRTDevToolsClient::dockWindow):
1421         (DRTDevToolsClient::undockWindow):
1422         (DRTDevToolsClient::asyncCall):
1423         (DRTDevToolsClient::call):
1424         (DRTDevToolsClient::allMessagesProcessed):
1425         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1426         * DumpRenderTree/chromium/EventSender.cpp:
1427         * DumpRenderTree/chromium/LayoutTestController.cpp:
1428         (LayoutTestController::LayoutTestController):
1429         (LayoutTestController::closeWebInspector):
1430         (LayoutTestController::setTimelineProfilingEnabled):
1431         (LayoutTestController::evaluateInWebInspector):
1432         * DumpRenderTree/chromium/LayoutTestController.h:
1433         * DumpRenderTree/chromium/TestShell.cpp:
1434         (TestShell::TestShell):
1435         (TestShell::~TestShell):
1436         (TestShell::createDRTDevToolsClient):
1437         (TestShell::showDevTools):
1438         (TestShell::closeDevTools):
1439         (TestShell::runFileTest):
1440         (TestShell::createNewWindow):
1441         * DumpRenderTree/chromium/TestShell.h:
1442         (TestShell::drtDevToolsAgent):
1443         (TestShell::drtDevToolsClient):
1444         * DumpRenderTree/chromium/config.h:
1445
1446 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1447
1448         Reviewed by Eric Seidel.
1449
1450         Don't pass image hash to DRT when pixel tests are disabled.
1451         https://bugs.webkit.org/show_bug.cgi?id=41597
1452
1453         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1454
1455 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1456
1457         Reviewed by Eric Seidel.
1458
1459         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1460         https://bugs.webkit.org/show_bug.cgi?id=41612
1461
1462         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1463
1464 2010-07-05  Adam Barth  <abarth@webkit.org>
1465
1466         Reviewed by Eric Seidel.
1467
1468         We should be able to specify a bug to block for webkit-patch upload
1469         https://bugs.webkit.org/show_bug.cgi?id=41648
1470
1471         This will be useful for working on the HTML5 parser.
1472
1473         * Scripts/webkitpy/tool/steps/createbug.py:
1474         * Scripts/webkitpy/tool/steps/options.py:
1475
1476 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1477
1478         Reviewed by Oliver Hunt.
1479
1480         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1481         https://bugs.webkit.org/show_bug.cgi?id=41017
1482
1483         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1484         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1485
1486 2010-07-04  MORITA Hajime  <morrita@google.com>
1487
1488         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1489         https://bugs.webkit.org/show_bug.cgi?id=41589
1490
1491         * run() method can result non-utf-8 bytes, that causes utf-8
1492           decoding fail.  Fixed to disable decoding.
1493         * Fixed Git.find_checkout_root() to make a test pass.
1494
1495         * Scripts/webkitpy/common/checkout/scm.py:
1496         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1497
1498 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1499
1500         Reviewed by Simon Hausmann.
1501
1502         [Qt] Fix DumpRenderTree userStyleSheet handling.
1503         https://bugs.webkit.org/show_bug.cgi?id=41570
1504
1505         DumpRenderTree did only set the userStyleSheet at
1506         layoutTestController.setUserStyleSheetEnabled().
1507
1508         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1509         (LayoutTestController::reset):
1510         (LayoutTestController::setUserStyleSheetLocation):
1511         (LayoutTestController::setUserStyleSheetEnabled):
1512         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1513
1514 2010-07-03  Robert Hogan  <robert@webkit.org>
1515
1516         Reviewed by Kenneth Rohde Christiansen.
1517
1518         [Qt] support dumpChildFrameScrollPositions
1519
1520         https://bugs.webkit.org/show_bug.cgi?id=41088
1521
1522         Unskip:
1523
1524         http/tests/navigation/anchor-subframeload.html
1525         http/tests/navigation/relativeanchor-frames.html
1526
1527         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1528         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1529         (WebCore::DumpRenderTree::dump):
1530         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1531         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1532         (LayoutTestController::reset):
1533         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1534         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1535         (LayoutTestController::dumpChildFrameScrollPositions):
1536
1537 2010-07-02  Sam Weinig  <sam@webkit.org>
1538
1539         Reviewed by Anders Carlsson.
1540
1541         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1542
1543         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1544         * Scripts/debug-webkittestrunner: Removed.
1545         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1546         * Scripts/run-webkittestrunner: Removed.
1547
1548 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1549
1550         Reviewed by Steve Falkenburg.
1551
1552         Some http tests fail on Windows with Cygwin 1.7
1553         https://bugs.webkit.org/show_bug.cgi?id=41537
1554         
1555         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1556         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1557         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1558
1559         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1560         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1561             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1562
1563 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1564
1565         Reviewed by Gustavo Noronha Silva.
1566
1567         [GTK] Separate DerivedSources per-project
1568         https://bugs.webkit.org/show_bug.cgi?id=41109
1569
1570         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1571         allowing the tools to build as a side-effect. Now that the top-level directory
1572         is no longer in the list of JavaScriptCore includes, include it explicitly.
1573
1574         * GNUmakefile.am:
1575
1576 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1577
1578         Reviewed by Kenneth Rohde Christiansen.
1579
1580         [Qt] Make context menus show up in the right place in QTestBrowser
1581
1582         Context menus were shown at scene-relative coordinates for
1583         QGraphicsWebView while QMenu expects them to be global. The
1584         change to the QWidget case was to get rid of the mapToGlobal.
1585
1586         * QtTestBrowser/webview.cpp:
1587
1588 2010-07-01  Robert Hogan <robert@webkit.org>
1589
1590         Reviewed by Kenneth Rohde Christiansen.
1591
1592         [Qt] dump frames in ascending alphabetical order of title
1593
1594         https://bugs.webkit.org/show_bug.cgi?id=41261
1595
1596         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1597         (WebCore::dumpHistoryItem):
1598
1599 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1600
1601         Unreviewed. 
1602
1603         Fix the GTK+ build after r62278.
1604
1605         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1606         let them override the automatic CPU detection for autotools builds.
1607
1608 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1609
1610         Unreviewed.
1611
1612         Fix the Windows build after r62278.
1613
1614         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1615
1616 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1617
1618         Reviewed by Gustavo Noronha Silva.
1619
1620         [GTK] build-webkit does not detect the number of CPUs
1621         https://bugs.webkit.org/show_bug.cgi?id=41469
1622
1623         Pass the appropriate -j<#> flag to make when building autotools builds.
1624         This causes make to spawn that many number of child processes for doing
1625         parallel builds.
1626
1627         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1628         of CPUs. This makes the script work across more platforms.
1629         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1630         number of CPUs across several platforms. Use this new function to determine the appropriate
1631         arguments to pass to make for doing parallel builds with autotools build files.
1632
1633 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1634
1635         Rubber-stamped by Laszlo Gombos.
1636
1637         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1638
1639         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1640         and use the one from WebKit.pri instead.
1641
1642 2010-07-01  Adam Barth  <abarth@webkit.org>
1643
1644         Reviewed by Eric Seidel.
1645
1646         Promote webkit-patch land-safely to main help
1647         https://bugs.webkit.org/show_bug.cgi?id=41446
1648
1649         I've been using this command a bunch and recommending it to folks.  We
1650         should show it in main help as it's past the experimental phase.
1651
1652         * Scripts/webkitpy/tool/commands/upload.py:
1653
1654 2010-06-28  MORITA Hajime  <morrita@google.com>
1655
1656         Reviewed by Shinichiro Hamaji.
1657
1658         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1659         https://bugs.webkit.org/show_bug.cgi?id=38775
1660
1661         - Introduced SCM.show_head() and SCM.diff_for_file().
1662         - Replaced direct svn invocations with newly implement SCM methods.
1663
1664         * Scripts/webkitpy/common/checkout/scm.py:
1665         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1666         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1667
1668 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1669
1670         Reviewed by Sam Weinig.
1671
1672         Allow MiniBrowser to open local files
1673         https://bugs.webkit.org/show_bug.cgi?id=41104
1674
1675         Wire up the openDocument: message with an NSOpenPanel, so we can open
1676         local files.
1677         
1678         Also change the xib so that the window remembers its size.
1679         
1680         * MiniBrowser/mac/AppDelegate.m:
1681         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1682         (-[BrowserAppDelegate openDocument:]):
1683         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1684         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1685
1686 2010-06-30  Sam Weinig  <sam@webkit.org>
1687
1688         Rubber-stamped by Anders Carlsson.
1689
1690         Add debug-webkittestrunner and cleanup related scripts.
1691
1692         * Scripts/debug-webkittestrunner: Added.
1693         * Scripts/run-webkittestrunner:
1694         * Scripts/webkitdirs.pm:
1695
1696 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1697
1698         [wx] Build fix after recent changes to LayoutTestController.
1699
1700         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1701         (LayoutTestController::pageSizeAndMarginsInPixels):
1702
1703 2010-06-29  Sam Weinig  <sam@webkit.org>
1704
1705         Reviewed by Anders Carlsson.
1706
1707         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1708         Make WebKitTestRunner work with more than one test at a time.
1709
1710         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1711         where there is a single WKView and each test is run it, rather than
1712         the design I was using where each test got its own WKView.
1713
1714         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1715         (WTR::InjectedBundle::didRecieveMessage):
1716         (WTR::InjectedBundle::reset):
1717         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1718         * WebKitTestRunner/TestController.cpp:
1719         (WTR::TestController::initialize):
1720         (WTR::TestController::runTest):
1721         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1722         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1723         * WebKitTestRunner/TestController.h:
1724         (WTR::TestController::mainWebView):
1725         (WTR::TestController::pageNamespace):
1726         (WTR::TestController::context):
1727         * WebKitTestRunner/TestInvocation.cpp:
1728         (WTR::TestInvocation::TestInvocation):
1729         (WTR::TestInvocation::~TestInvocation):
1730         (WTR::TestInvocation::invoke):
1731         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1732         * WebKitTestRunner/TestInvocation.h:
1733
1734 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1735
1736         Reviewed by Laszlo Gombos.
1737
1738         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1739         https://bugs.webkit.org/show_bug.cgi?id=40446
1740
1741         We quickly run out of memory on Symbian when loading web pages. This is
1742         caused by the default heap size, which is not suited for a web browser.
1743
1744         This change bumps the max heap size to 32MB.
1745
1746         * QtTestBrowser/QtTestBrowser.pro:
1747
1748 2010-06-30  Eric Seidel  <eric@webkit.org>
1749
1750         Reviewed by Adam Barth.
1751
1752         webkit-patch land allow the user to continue even if the builders are red
1753         https://bugs.webkit.org/show_bug.cgi?id=41395
1754
1755         I don't think it's good that we've been teaching people
1756         to always pass --ignore-builders.  At least land is now
1757         useable w/o --ignore-builders.
1758
1759         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1760
1761 2010-06-29  Robert Hogan  <robert@webkit.org>
1762
1763         Reviewed by Kenneth Rohde Christiansen.
1764
1765         [Qt] support dumpResourceResponseMIMETypes
1766         https://bugs.webkit.org/show_bug.cgi?id=41260
1767
1768         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1769         (LayoutTestController::reset):
1770         (LayoutTestController::dumpResourceResponseMIMETypes):
1771         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1772
1773 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1774
1775         Reviewed by Kenneth Rohde Christiansen.
1776
1777         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1778         https://bugs.webkit.org/show_bug.cgi?id=41173
1779
1780         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1781         (WebCore::WebPage::setViewGeometry):
1782         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1783
1784 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1785
1786         Reviewed by Simon Hausmann.
1787
1788         [Qt] Deal with postEvent in case of graphics based DRT
1789         https://bugs.webkit.org/show_bug.cgi?id=41174
1790
1791         QGraphicsScene does not have a postEvent method, so make scene
1792         send the event, in case of graphics based DRT, and delete it after that.
1793
1794         * DumpRenderTree/qt/EventSenderQt.cpp:
1795         (EventSender::scheduleAsynchronousClick):
1796         (EventSender::replaySavedEvents):
1797         (EventSender::postEvent):
1798         * DumpRenderTree/qt/EventSenderQt.h:
1799
1800 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1801
1802         Reviewed by Kenneth Rohde Christiansen.
1803
1804         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1805         https://bugs.webkit.org/show_bug.cgi?id=41172
1806
1807         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1808         (WebCore::DumpRenderTree::switchFocus):
1809
1810 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1811
1812         Reviewed by Xan Lopez.
1813
1814         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1815         https://bugs.webkit.org/show_bug.cgi?id=40009
1816
1817         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1818         are used when returning those values, for coherency with other ports.
1819
1820         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1821         (AccessibilityUIElement::role):
1822         (AccessibilityUIElement::title):
1823         (AccessibilityUIElement::description):
1824
1825 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1826
1827         Unreviewed, rolling out r62106.
1828         http://trac.webkit.org/changeset/62106
1829         https://bugs.webkit.org/show_bug.cgi?id=41346
1830
1831         "Broke editing tests" (Requested by xan_ on #webkit).
1832
1833         * Scripts/old-run-webkit-tests:
1834
1835 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1836
1837         Reviewed by Xan Lopez.
1838
1839         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1840         https://bugs.webkit.org/show_bug.cgi?id=38648
1841
1842         Add the GTK_MODULES envvar (set to "gail") to the clean
1843         environment when running DRT for the Gtk+ port
1844
1845         * Scripts/old-run-webkit-tests:
1846
1847 2010-06-28  Adam Barth  <abarth@webkit.org>
1848
1849         Unreviewed.
1850
1851         Switch test-html5-parser back to using runner.html.
1852
1853         * Scripts/test-html5-parser:
1854
1855 2010-06-28  Adam Barth  <abarth@webkit.org>
1856
1857         Reviewed by Eric Seidel.
1858
1859         Restore webkit-runner.html for use with new tree builder
1860         https://bugs.webkit.org/show_bug.cgi?id=41317
1861
1862         For now, we just want to run webkit-runner when we test-html5-parser.
1863
1864         * Scripts/test-html5-parser:
1865
1866 2010-06-23  John Gregg  <johnnyg@google.com>
1867
1868         Reviewed by Kent Tamura.
1869
1870         add ENABLE_DIRECTORY_UPLOAD build support
1871         https://bugs.webkit.org/show_bug.cgi?id=41100
1872
1873         * Scripts/build-webkit:
1874
1875 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1876
1877         Rubber-stamped by Xan Lopez.
1878
1879         Update webkitdirs's knowledge of our library's name.
1880
1881         * Scripts/webkitdirs.pm:
1882
1883 2010-06-28  Sam Weinig  <sam@webkit.org>
1884
1885         Reviewed by Anders Carlsson.
1886
1887         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1888         Build up WebKitTestRunner output in the InjectedBundle
1889
1890         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1891         and sending it over postMessage when done, instead of using the async
1892         WKPageRenderTreeExternalRepresentation.
1893
1894         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1895         (WTR::InjectedBundle::done):
1896         (WTR::InjectedBundle::didRecieveMessage):
1897         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1898         (WTR::InjectedBundle::os):
1899         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1900         (WTR::WKStringToUTF8):
1901         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1902         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1903         * WebKitTestRunner/TestInvocation.cpp:
1904         (WTR::WKStringToUTF8):
1905         (WTR::TestInvocation::TestInvocation):
1906         (WTR::TestInvocation::invoke):
1907         (WTR::TestInvocation::initializeMainWebView):
1908         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1909         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1910         * WebKitTestRunner/TestInvocation.h:
1911
1912 2010-06-28  Robert Hogan  <robert@webkit.org>
1913
1914         Unreviewed, rolling out r62021.
1915         http://trac.webkit.org/changeset/62021
1916         https://bugs.webkit.org/show_bug.cgi?id=41261
1917
1918         Broke http/navigation tests among other
1919
1920         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1921         (WebCore::DumpRenderTree::dumpFramesAsText):
1922
1923 2010-06-28  Sam Weinig  <sam@webkit.org>
1924
1925         Reviewed by Anders Carlsson.
1926
1927         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1928         environment.
1929
1930         * Scripts/run-webkittestrunner: Added.
1931         * Scripts/webkitdirs.pm:
1932
1933 2010-06-28  Robert Hogan  <robert@webkit.org>
1934
1935         Reviewed by Kenneth Rohde Christiansen.
1936
1937         [Qt] dump frames in ascending alphabetical order of title
1938
1939         https://bugs.webkit.org/show_bug.cgi?id=41261
1940
1941         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1942         (WebCore::DumpRenderTree::dumpFramesAsText):
1943
1944 2010-06-28  Robert Hogan  <robert@webkit.org>
1945
1946         Reviewed by Kenneth Rohde Christiansen.
1947
1948         [Qt] dump bf history of child windows
1949
1950         https://bugs.webkit.org/show_bug.cgi?id=41266
1951
1952         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1953         (WebCore::DumpRenderTree::dumpBackForwardList):
1954         (WebCore::DumpRenderTree::dump):
1955         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1956
1957 2010-06-28  Sam Weinig  <sam@webkit.org>
1958
1959         Reviewed by Anders Carlsson.
1960
1961         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
1962         WebKit2: Add frame API for InjectedBundle code
1963
1964         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1965         (_didClearWindowForFrame):
1966
1967 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1968
1969         Reviewed by Kenneth Rohde Christiansen.
1970
1971         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1972         https://bugs.webkit.org/show_bug.cgi?id=38597
1973
1974         Fix behavior so reload button really acts as a load and a reload button.
1975
1976         * QtTestBrowser/mainwindow.cpp:
1977         (MainWindow::changeLocation):
1978
1979 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1980
1981         Reviewed by Gustavo Noronha.
1982
1983         [GTK] Does not compile with -DGSEAL_ENABLE
1984         https://bugs.webkit.org/show_bug.cgi?id=37851
1985
1986         Fix build with GSEAL enabled.
1987
1988         * DumpRenderTree/gtk/EventSender.cpp:
1989         (gtk_widget_get_window):
1990         (prepareMouseButtonEvent):
1991         (mouseMoveToCallback):
1992         (mouseWheelToCallback):
1993         (keyDownCallback):
1994
1995 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1996
1997         Reviewed by Gustavo Noronha.
1998
1999         [GTK] Add support for GTK+3
2000         https://bugs.webkit.org/show_bug.cgi?id=41253
2001
2002         Adapt build system for 3.x support.
2003
2004         * GNUmakefile.am:
2005
2006 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2007
2008         Reviewed by Simon Hausmann.
2009
2010         [QT][S60] build-webkit scripts picks wrong make spec for windows build
2011         https://bugs.webkit.org/show_bug.cgi?id=41198
2012
2013         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
2014
2015         * Scripts/webkitdirs.pm:
2016         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
2017
2018 2010-06-28  Eric Seidel  <eric@webkit.org>
2019
2020         Reviewed by Adam Barth.
2021
2022         Make it possible to test the new HTML5 TreeBuilder
2023         https://bugs.webkit.org/show_bug.cgi?id=41276
2024
2025         Adam was concerned that someone might make their port
2026         depend on this setting (I guess we had some trouble with that
2027         with the HTML5Parser setting), so I littered the code with warnings.
2028
2029         test-html5-parser now tests this code path.
2030
2031         * DumpRenderTree/mac/DumpRenderTree.mm:
2032         (resetDefaultsToConsistentValues):
2033         (initializeGlobalsFromCommandLineOptions):
2034         * Scripts/test-html5-parser:
2035
2036 2010-06-27  MORITA Hajime  <morrita@google.com>
2037
2038         Unreviewed. 
2039         
2040         Some never-called @staticmethods touched self. 
2041         Fixed it to replace these self with a class.
2042
2043         * Scripts/webkitpy/common/checkout/scm.py:
2044
2045 2010-06-27  MORITA Hajime  <morrita@google.com>
2046
2047         Unreviewed.
2048         
2049         Fixed exception raising syntax that is pointed out at
2050         https://bugs.webkit.org/show_bug.cgi?id=41153
2051
2052         * Scripts/webkitpy/common/checkout/scm.py:
2053         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
2054           Removed a bad line that I accidentally checked-in at last revision.
2055
2056 2010-06-24  MORITA Hajime  <morrita@google.com>
2057
2058         Reviewed by Eric Seidel.
2059
2060         rebaseline-chromium-webkit-tests should add or remove files to local git repository
2061         https://bugs.webkit.org/show_bug.cgi?id=41153
2062
2063         - Added SCM.add() and SCM.remove()
2064         - Replaced "svn add" and "svn remove"
2065           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
2066         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
2067           for debugging purpose.
2068
2069         * Scripts/webkitpy/common/checkout/scm.py:
2070         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2071         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2072
2073 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
2074
2075         Reviewed by Shinichiro Hamaji.
2076
2077         Improve default value handling for page format properties.
2078         https://bugs.webkit.org/show_bug.cgi?id=41150
2079
2080         * DumpRenderTree/LayoutTestController.cpp:
2081         (parsePageNumber):
2082         (parsePageNumberSizeMarings):
2083         (pageSizeAndMarginsInPixelsCallback):
2084         (LayoutTestController::staticFunctions):
2085         * DumpRenderTree/LayoutTestController.h:
2086         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2087         (LayoutTestController::pageSizeAndMarginsInPixels):
2088         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2089         (LayoutTestController::pageSizeAndMarginsInPixels):
2090         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2091         (LayoutTestController::pageSizeAndMarginsInPixels):
2092
2093 2010-06-21  Robert Hogan  <robert@webkit.org>
2094
2095         Reviewed by Kenneth Rohde Christiansen.
2096
2097         [Qt] DRT Support for setCustomPolicyDelegate
2098
2099         https://bugs.webkit.org/show_bug.cgi?id=39564
2100
2101         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2102         (LayoutTestController::setCustomPolicyDelegate):
2103         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2104
2105 2010-06-26  Robert Hogan  <robert@webkit.org>
2106
2107         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
2108         
2109         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
2110         exported.
2111
2112         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2113
2114 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
2115
2116         Reviewed by Dimitri Glazkov.
2117
2118         Add a build-webkit option for enabling Web Timing support.
2119         https://bugs.webkit.org/show_bug.cgi?id=38924
2120
2121         * Scripts/build-webkit:
2122
2123 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2124
2125         Reviewed by Kenneth Rohde Christiansen.
2126
2127         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
2128         https://bugs.webkit.org/show_bug.cgi?id=38597
2129
2130         Make the reload button act as a load button as well.
2131
2132         * QtTestBrowser/mainwindow.cpp:
2133         (MainWindow::buildUI):
2134         (MainWindow::changeLocation):
2135
2136 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
2137
2138         Reviewed by Dmitry Titov.
2139
2140         Add empty abortModal() method to all platforms.
2141         https://bugs.webkit.org/show_bug.cgi?id=40864
2142
2143         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
2144         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
2145         that use abortModal will become mac specific which is not desirable.
2146
2147         * DumpRenderTree/LayoutTestController.cpp:
2148         (abortModalCallback):
2149         (LayoutTestController::staticFunctions):
2150         * DumpRenderTree/LayoutTestController.h:
2151         * DumpRenderTree/chromium/LayoutTestController.cpp:
2152         (LayoutTestController::LayoutTestController):
2153         (LayoutTestController::abortModal):
2154         * DumpRenderTree/chromium/LayoutTestController.h:
2155         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2156         (LayoutTestController::abortModal):
2157         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2158         (LayoutTestController::abortModal):
2159         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2160         (LayoutTestController::abortModal):
2161         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2162         (LayoutTestController::abortModal):
2163
2164 2010-06-25  Sam Weinig  <sam@webkit.org>
2165
2166         Reviewed by Anders Carlsson.
2167
2168         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
2169         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
2170
2171         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
2172         (WTR::InjectedBundle::shared):
2173         (WTR::InjectedBundle::InjectedBundle):
2174         (WTR::InjectedBundle::_didCreatePage):
2175         (WTR::InjectedBundle::_willDestroyPage):
2176         (WTR::InjectedBundle::_didRecieveMessage):
2177         (WTR::InjectedBundle::initialize):
2178         (WTR::InjectedBundle::didCreatePage):
2179         (WTR::InjectedBundle::willDestroyPage):
2180         (WTR::InjectedBundle::didRecieveMessage):
2181         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
2182         (WTR::InjectedBundle::layoutTestController):
2183         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2184         (WKBundleInitialize):
2185         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
2186         (WTR::InjectedBundlePage::InjectedBundlePage):
2187         (WTR::InjectedBundlePage::~InjectedBundlePage):
2188         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
2189         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
2190         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
2191         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
2192         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
2193         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
2194         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
2195         (WTR::InjectedBundlePage::_didClearWindowForFrame):
2196         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2197         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2198         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2199         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2200         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2201         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2202         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2203         (WTR::InjectedBundlePage::didClearWindowForFrame):
2204         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
2205         (WTR::InjectedBundlePage::page):
2206         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
2207         (WTR::LayoutTestController::create):
2208         (WTR::LayoutTestController::LayoutTestController):
2209         (WTR::LayoutTestController::~LayoutTestController):
2210         (WTR::dumpAsTextCallback):
2211         (WTR::layoutTestControllerObjectFinalize):
2212         (WTR::LayoutTestController::makeWindowObject):
2213         (WTR::LayoutTestController::getJSClass):
2214         (WTR::LayoutTestController::staticFunctions):
2215         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
2216         (WTR::LayoutTestController::dumpAsText):
2217         (WTR::LayoutTestController::setDumpAsText):
2218         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2219
2220 2010-06-25  Sam Weinig  <sam@webkit.org>
2221
2222         Reviewed by Anders Carlsson.
2223
2224         Make WebKitTestRunner really work with run-webkit-tests. 
2225
2226         - Add Forwarding headers to allow some cleanup.
2227
2228         * WebKitTestRunner/ForwardingHeaders: Added.
2229         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
2230         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
2231         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
2232         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
2233         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
2234         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
2235         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
2236         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
2237         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
2238         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
2239         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
2240         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
2241         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
2242         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
2243         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
2244         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
2245         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
2246         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
2247         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
2248         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
2249         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
2250         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
2251         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
2252         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
2253         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
2254         * WebKitTestRunner/TestInvocation.cpp:
2255         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
2256         * WebKitTestRunner/TestInvocation.h:
2257
2258 2010-06-25  Sam Weinig  <sam@webkit.org>
2259
2260         Reviewed by Mark Rowe.
2261
2262         Add support for WebKitTestRunner to old-run-webkit-tests
2263
2264         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
2265
2266         * Scripts/build-webkittestrunner: Added.
2267         * Scripts/old-run-webkit-tests:
2268
2269 2010-06-25  Adam Barth  <abarth@webkit.org>
2270
2271         Reviewed by David Levin.
2272
2273         Incremental build failed on Chromium ews
2274         https://bugs.webkit.org/show_bug.cgi?id=41011
2275
2276         The division of responsibility between update-webkit --chromium and
2277         build-webkit --chromium is slightly unclear.  In this patch, we make
2278         build-webkit --chromium also update DEPS and re-run GYP in case the
2279         developer has changed either since they updated.
2280
2281         This change is also helpful for the EWS, which wants to update DEPS and
2282         re-run GYP after applying patches, but the EWS doesn't want to run
2283         update-webkit --chromium because it has a dirty working copy.
2284
2285         * Scripts/webkitdirs.pm:
2286
2287 2010-06-25  Robert Hogan  <robert@webkit.org>
2288
2289         Reviewed by Simon Hausmann.
2290
2291         [Qt] Support evaluateScriptInIsolatedWorld()
2292
2293         https://bugs.webkit.org/show_bug.cgi?id=40079
2294
2295         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
2296         Remove QWebScriptWorld from exported headers.
2297         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
2298
2299         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2300         (LayoutTestController::reset):
2301         (LayoutTestController::evaluateScriptInIsolatedWorld):
2302         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2303
2304 2010-06-25  Anders Carlsson  <andersca@apple.com>
2305
2306         Revert accidental part and add a newline.
2307
2308         * MiniBrowser/mac/AppDelegate.m:
2309         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2310
2311 2010-06-25  Anders Carlsson  <andersca@apple.com>
2312
2313         Rubber-stamped by Dan Bernstein.
2314
2315         Add a LOG macro that expands to a no-op by default.
2316
2317         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2318         * MiniBrowser/mac/AppDelegate.m:
2319         (_didRecieveMessageFromInjectedBundle):
2320         * MiniBrowser/mac/BrowserWindowController.m:
2321         (-[BrowserWindowController windowShouldClose:]):
2322         (_didStartProvisionalLoadForFrame):
2323         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2324         (_didFailProvisionalLoadWithErrorForFrame):
2325         (_didCommitLoadForFrame):
2326         (_didFinishLoadForFrame):
2327         (_didFailLoadWithErrorForFrame):
2328         (_didReceiveTitleForFrame):
2329         (_didFirstLayoutForFrame):
2330         (_didFirstVisuallyNonEmptyLayoutForFrame):
2331         (_didBecomeUnresponsive):
2332         (_didBecomeResponsive):
2333         (_decidePolicyForNavigationAction):
2334         (_decidePolicyForNewWindowAction):
2335         (_createNewPage):
2336         (_showPage):
2337         (_closePage):
2338         (_didNavigateWithNavigationData):
2339         (_didPerformClientRedirect):
2340         (_didPerformServerRedirect):
2341         (_didUpdateHistoryTitle):
2342         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2343         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2344         (_didClearWindowForFrame):
2345         (_didCreatePage):
2346         (_willDestroyPage):
2347         (_didRecieveMessage):
2348
2349 2010-06-24  Adam Barth  <abarth@webkit.org>
2350
2351         Reviewed by Eric Seidel.
2352
2353         commit-queue is taking too long to land patches because of red trees
2354         https://bugs.webkit.org/show_bug.cgi?id=41194
2355
2356         Instead of checking for the tree to be green, we'll just spin hot
2357         trying to land patches.  This is probably too extreme in ignoring the
2358         tree, but I think we should try it for a while to see if we have
2359         trouble.  That will help us find the right balance.
2360
2361         * Scripts/webkitpy/tool/commands/queues.py:
2362         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2363
2364 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2365
2366         Reviewed by Xan Lopez.
2367
2368         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
2369         https://bugs.webkit.org/show_bug.cgi?id=40843
2370
2371         Define the version for old GTK+s in a way that is forward-compatible
2372         and clean up the logic a bit.
2373
2374         * DumpRenderTree/gtk/EventSender.cpp:
2375         (gdk_window_get_root_coords): Renamed and cleaned up.
2376         (prepareMouseButtonEvent): Remove #ifdefs.
2377         (mouseMoveToCallback): Remove #ifdefs.
2378
2379 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
2380
2381         Reviewed by Eric Seidel.
2382
2383         Fix NewRunWebKitTests to work on Windows.
2384         https://bugs.webkit.org/show_bug.cgi?id=41180
2385
2386         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
2387             because Windows fails to understand what we're asking of it.
2388
2389 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2390
2391         Reviewed by Xan Lopez.
2392
2393         [GTK] The url passed to the WebView during layout tests is invalid
2394         https://bugs.webkit.org/show_bug.cgi?id=40832
2395
2396         Set the test URL to the full real file URL and do a small cleanup.
2397         Previously a URL like file://relative/path/to/test.html was passed
2398         to the WebView. This malformed file URL would be returned by
2399         webkit_web_view_get_url and webkit_web_frame_get_url.
2400
2401         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2402         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
2403         (shouldOpenWebInspector): Change to take a const string& as the argument.
2404         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
2405         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2406
2407 2010-06-24  Sam Weinig  <sam@webkit.org>
2408
2409         Reviewed by Anders Carlsson.
2410
2411         Fix WebKitTestRunner Makefile typos.
2412
2413         * WebKitTestRunner/Makefile:
2414
2415 2010-06-24  Adele Peterson  <adele@apple.com>
2416
2417         Reviewed by Eric Carlson.
2418
2419         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2420         https://bugs.webkit.org/show_bug.cgi?id=41085
2421
2422         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2423         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2424
2425 2010-06-23  Sam Weinig  <sam@webkit.org>
2426
2427         Reviewed by Anders Carlsson.
2428
2429         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2430         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2431
2432         - Mac only.
2433         - run-webkit-tests has not been modified to call it yet.
2434         - Only dumps the render tree at this time. 
2435
2436         * WebKitTestRunner: Added.
2437         * WebKitTestRunner/Configurations: Added.
2438         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2439         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2440         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2441         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2442         * WebKitTestRunner/InjectedBundle: Added.
2443         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2444         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2445         (_didStartProvisionalLoadForFrame):
2446         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2447         (_didFailProvisionalLoadWithErrorForFrame):
2448         (_didCommitLoadForFrame):
2449         (_didFinishLoadForFrame):
2450         (_didFailLoadWithErrorForFrame):
2451         (_didReceiveTitleForFrame):
2452         (_didClearWindow):
2453         (_didCreatePage):
2454         (_willDestroyPage):
2455         (_didRecieveMessage):
2456         (WKBundleInitialize):
2457         * WebKitTestRunner/Makefile: Added.
2458         * WebKitTestRunner/PlatformWebView.h: Added.
2459         (WTR::PlatformWebView::platformView):
2460         * WebKitTestRunner/TestController.cpp: Added.
2461         (WTR::TestController::shared):
2462         (WTR::TestController::TestController):
2463         (WTR::TestController::initialize):
2464         (WTR::TestController::runTest):
2465         (WTR::TestController::runTestingServerLoop):
2466         (WTR::TestController::run):
2467         * WebKitTestRunner/TestController.h: Added.
2468         (WTR::TestController::verbose):
2469         (WTR::TestController::injectedBundlePath):
2470         * WebKitTestRunner/TestInvocation.cpp: Added.
2471         (WTR::createWKURL):
2472         (WTR::TestInvocation::TestInvocation):
2473         (WTR::TestInvocation::~TestInvocation):
2474         (WTR::TestInvocation::invoke):
2475         (WTR::TestInvocation::dump):
2476         (WTR::TestInvocation::initializeMainWebView):
2477         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2478         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2479         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2480         (WTR::TestInvocation::didCommitLoadForFrame):
2481         (WTR::TestInvocation::didFinishLoadForFrame):
2482         (WTR::TestInvocation::didFailLoadForFrame):
2483         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2484         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2485         * WebKitTestRunner/TestInvocation.h: Added.
2486         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2487         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2488         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2489         * WebKitTestRunner/mac: Added.
2490         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2491         (WTR::PlatformWebView::PlatformWebView):
2492         (WTR::PlatformWebView::~PlatformWebView):
2493         (WTR::PlatformWebView::page):
2494         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2495         (WTR::TestInvocation::runUntil):
2496         * WebKitTestRunner/mac/main.mm: Added.
2497         (main):
2498
2499 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2500
2501         Unreviewed. Adding myself to the committers list.
2502
2503         * Scripts/webkitpy/common/config/committers.py:
2504
2505 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2506
2507         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2508
2509         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2510         (LayoutTestController::isPageBoxVisible):
2511         (LayoutTestController::pageAreaRectInPixels):
2512         (LayoutTestController::preferredPageSizeInPixels):
2513         * wx/build/settings.py:
2514
2515 2010-06-23  James Robinson  <jamesr@chromium.org>
2516
2517         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2518
2519         * Scripts/webkitpy/common/config/committers.py:
2520
2521 2010-06-23  Kent Tamura  <tkent@chromium.org>
2522
2523         Reviewed by Dimitri Glazkov.
2524
2525         Correct Chromium test configuration
2526         https://bugs.webkit.org/show_bug.cgi?id=41057
2527
2528         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2529          - Add "--use-drt" option for NRWT. It is required for Chromium and
2530            ignored for other platforms.
2531          - Skip JSC test on Chromium
2532         * BuildSlaveSupport/test-result-archive:
2533           Add Chromium support.
2534
2535 2010-06-23  Sam Weinig  <sam@webkit.org>
2536
2537         Reviewed by Anders Carlsson.
2538
2539         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2540         WebKit2: Flesh out more of the InjectedBundle client API
2541
2542         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2543         (_didStartProvisionalLoadForFrame):
2544         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2545         (_didFailProvisionalLoadWithErrorForFrame):
2546         (_didCommitLoadForFrame):
2547         (_didFinishLoadForFrame):
2548         (_didFailLoadWithErrorForFrame):
2549         (_didReceiveTitleForFrame):
2550         (_didClearWindowForFrame):
2551         (_didCreatePage):
2552         (_willDestroyPage):
2553         (WKBundleInitialize):
2554
2555 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2556
2557         Reviewed by Shinichiro Hamaji.
2558
2559         Implement page format data programming interface.
2560         Add methods for testing.
2561         https://bugs.webkit.org/show_bug.cgi?id=37538
2562
2563         * DumpRenderTree/LayoutTestController.cpp:
2564         (parsePageNumber):
2565         (isPageBoxVisibleCallback):
2566         (pageAreaRectInPixelsCallback):
2567         (preferredPageSizeInPixelsCallback):
2568         (LayoutTestController::staticFunctions):
2569         * DumpRenderTree/LayoutTestController.h:
2570         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2571         (LayoutTestController::isPageBoxVisible):
2572         (LayoutTestController::pageAreaRectInPixels):
2573         (LayoutTestController::preferredPageSizeInPixels):
2574         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2575         (LayoutTestController::isPageBoxVisible):
2576         (LayoutTestController::pageAreaRectInPixels):
2577         (LayoutTestController::preferredPageSizeInPixels):
2578         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2579         (LayoutTestController::isPageBoxVisible):
2580         (LayoutTestController::pageAreaRectInPixels):
2581         (LayoutTestController::preferredPageSizeInPixels):
2582
2583 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2584
2585         Reviewed by Shinichiro Hamaji.
2586
2587         Follow proper convention for if/switch/while as I've discovered
2588         them to be through my review processes.
2589         https://bugs.webkit.org/show_bug.cgi?id=40723
2590
2591         Modified test so that if( foo ) is not allowed as it appears not
2592         to be the accepted convention.
2593
2594         * Scripts/webkitpy/style/checkers/cpp.py:
2595         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2596
2597 2010-06-22  Eric Seidel  <eric@webkit.org>
2598
2599         Reviewed by Adam Barth.
2600
2601         Run clean-header-guards to fix some header guards
2602         https://bugs.webkit.org/show_bug.cgi?id=41044
2603
2604         No functional changes, thus no tests.
2605
2606         This entire change was generated by running
2607         clean-header-guards, and then reverting changes
2608         to files which shouldn't be changed.  Those which
2609         are left all should be updated.
2610
2611         Some of these changes are just fixing 755 permissions
2612         to be 644, since it seems various files have the wrong
2613         execute bit which don't need it.  clean-header-guards
2614         made those (welcome) permission fixes unintentionally.
2615
2616         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2617         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2618         * QtTestBrowser/fpstimer.h:
2619
2620 2010-06-22  Adam Barth  <abarth@webkit.org>
2621
2622         Reviewed by Eric Seidel.
2623
2624         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2625         https://bugs.webkit.org/show_bug.cgi?id=41043
2626
2627         Update the hash.
2628
2629         * Scripts/do-webcore-rename:
2630
2631 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2632
2633         Reviewed by Shinichiro Hamaji.
2634
2635         Follow proper convention for variable declaration spacing.
2636         https://bugs.webkit.org/show_bug.cgi?id=40724
2637
2638         Modified test so that 'int   a;' is not allowed.
2639
2640         * Scripts/webkitpy/style/checkers/cpp.py:
2641         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2642
2643 2010-06-22  Eric Seidel  <eric@webkit.org>
2644
2645         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2646
2647         * Scripts/webkitpy/common/config/committers.py:
2648
2649 2010-06-22  Eric Seidel  <eric@webkit.org>
2650
2651         Reviewed by Adam Barth.
2652
2653         Remove Gtk 64-Release bot from core since it's broken
2654         https://bugs.webkit.org/show_bug.cgi?id=41022
2655
2656         This bot alone has been responsible for more than 72 hours of
2657         commit-queue blockage in the last week.  The bot is broken -- keeps
2658         losing its display server or similar.  Until the Gtk folks can fix the
2659         bot, we need to remove it from core.  The WebKit community can't keep
2660         it green as is.
2661
2662         * Scripts/webkitpy/common/net/buildbot.py:
2663         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2664
2665 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2666
2667         Reviewed by Eric Seidel.
2668
2669         Fix the Windows build.
2670         https://bugs.webkit.org/show_bug.cgi?id=40972
2671
2672         * DumpRenderTree/win/ImageDiff.vcproj:
2673
2674 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2675
2676         Reviewed by Darin Adler, Dmitry Titov.
2677
2678         DumpRenderTree should allow tests with modal dialogs
2679         https://bugs.webkit.org/show_bug.cgi?id=35350
2680
2681         * DumpRenderTree/LayoutTestController.cpp:
2682         (abortModalCallback):
2683         (LayoutTestController::staticFunctions):
2684         * DumpRenderTree/LayoutTestController.h:
2685         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2686         (LayoutTestController::abortModal):
2687         Add abortModal method to LayoutTestController and make it available from script.
2688
2689         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2690         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2691         abortModal from when modal window closes.
2692         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2693
2694 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2695
2696         Reviewed by Anders Carlsson.
2697         
2698         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2699         https://bugs.webkit.org/show_bug.cgi?id=40948
2700         
2701         Have the script look in WebKit2.
2702
2703         * Scripts/do-webcore-rename:
2704
2705 2010-06-21  Robert Hogan  <robert@webkit.org>
2706
2707         Reviewed by Kenneth Rohde Christiansen.
2708
2709         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2710
2711         It's a Mac-specific test so just add the required LayoutTestController
2712         function as a no-op to avoid failing. Similar approach adopted by other
2713         ports.
2714
2715         https://bugs.webkit.org/show_bug.cgi?id=33344
2716
2717         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2718         (LayoutTestController::addDisallowedURL):
2719
2720 2010-06-21  Sam Weinig  <sam@webkit.org>
2721
2722         Reviewed by Anders Carlsson.
2723
2724         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2725         Add message passing support to the WebKit2 API.
2726
2727         - Add some test messages.
2728
2729         * MiniBrowser/mac/AppDelegate.m:
2730         (_didRecieveMessageFromInjectedBundle):
2731         (-[BrowserAppDelegate init]):
2732         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2733         (_didClearWindow):
2734         (_didCreatePage):
2735         (_didRecieveMessage):
2736         (WKBundleInitialize):
2737
2738 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2739
2740         Unreviewed.
2741
2742         Rolling back 61551 and 61555 due to test failures.
2743
2744         * DumpRenderTree/LayoutTestController.cpp:
2745         (LayoutTestController::staticFunctions):
2746         * DumpRenderTree/LayoutTestController.h:
2747         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2748         (LayoutTestController::setEditingBehavior):
2749         * DumpRenderTree/mac/UIDelegate.mm:
2750
2751 2010-06-21  Anders Carlsson  <andersca@apple.com>
2752
2753         Reviewed by Sam Weinig.
2754
2755         Make DumpRenderTree build with clang++
2756
2757         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2758         (-[LocalPasteboard setPropertyList:forType:]):
2759         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2760         (-[DumpRenderTreeWindow keyDown:]):
2761         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2762         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2763         (LayoutTestController::isCommandEnabled):
2764
2765 2010-06-21  Satish Sampath  <satish@chromium.org>
2766
2767         Reviewed by Steve Block.
2768
2769         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2770         https://bugs.webkit.org/show_bug.cgi?id=40878
2771
2772         * Scripts/build-webkit:
2773
2774 2010-06-21  Kent Tamura  <tkent@chromium.org>
2775
2776         Reviewed by Dimitri Glazkov.
2777
2778         [DRT/Chromium] Initialization for http/tests/loading/
2779         https://bugs.webkit.org/show_bug.cgi?id=40902
2780
2781         * DumpRenderTree/chromium/TestShell.cpp:
2782         (TestShell::runFileTest):
2783
2784 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2785
2786         Unreviewed.
2787
2788         Adding myself to the committers list.
2789
2790         * Scripts/webkitpy/common/config/committers.py:
2791
2792 2010-06-20  Kent Tamura  <tkent@chromium.org>
2793
2794         Reviewed by Dimitri Glazkov.
2795
2796         [DRT/Chromium] Add --allow-external-pages option
2797         https://bugs.webkit.org/show_bug.cgi?id=40762
2798
2799         Add --allow-external-pages introduced by Chromium r45403.
2800         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2801
2802         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2803         (main):
2804         * DumpRenderTree/chromium/TestShell.cpp:
2805         (TestShell::TestShell):
2806         * DumpRenderTree/chromium/TestShell.h:
2807         (TestShell::allowExternalPages):
2808         (TestShell::setAllowExternalPages):
2809         * DumpRenderTree/chromium/WebViewHost.cpp:
2810         (WebViewHost::willSendRequest):
2811
2812 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2813
2814         Reviewed by Adam Barth.
2815
2816         Sheriffbot: Should allow "r" in SVN_REVISION
2817         https://bugs.webkit.org/show_bug.cgi?id=40889
2818
2819         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2820         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2821
2822 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2823
2824         Reviewed by Dimitri Glazkov.
2825
2826         Python Tests Fail after r61508
2827         https://bugs.webkit.org/show_bug.cgi?id=40891
2828
2829         Test's regex list needed to be updated to match the new
2830         regex list in the source code. Added new bots to the
2831         example_buildbots list.
2832
2833         Regex list fixed in r61512. Updated bot list.
2834
2835         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2836
2837 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2838
2839         Unreviewed, build fix.
2840
2841         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2842
2843         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2844
2845 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2846
2847         Unreviewed.
2848
2849         Adding myself to the committers list.
2850
2851         * Scripts/webkitpy/common/config/committers.py:
2852
2853 2010-06-19  Sam Weinig  <sam@webkit.org>
2854
2855         Reviewed by Anders Carlsson.
2856
2857         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2858         Add ability to have a WebProcess per WebContext.
2859
2860         Move to use new shared contexts API.
2861
2862         * MiniBrowser/mac/AppDelegate.h:
2863         * MiniBrowser/mac/AppDelegate.m:
2864         (-[BrowserAppDelegate init]):
2865         (-[BrowserAppDelegate getCurrentPageNamespace]):
2866         (-[BrowserAppDelegate validateMenuItem:]):
2867         (-[BrowserAppDelegate _setProcessModel:]):
2868         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2869         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2870         * MiniBrowser/win/BrowserView.cpp:
2871         (BrowserView::create):
2872
2873 2010-06-02  Robert Hogan  <robert@webkit.org>
2874
2875         Reviewed by Adam Barth.
2876
2877         [Qt] Support evaluateScriptInIsolatedWorld()
2878
2879         https://bugs.webkit.org/show_bug.cgi?id=40079
2880
2881         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2882         (LayoutTestController::evaluateScriptInIsolatedWorld):
2883         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2884
2885 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2886
2887         Reviewed by Darin Adler.
2888
2889         Add three more non-core Chromium builders to start testing DumpRenderTree.
2890         https://bugs.webkit.org/show_bug.cgi?id=40335
2891
2892         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2893
2894 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2895
2896         Reviewed by Darin Fisher.
2897
2898         [Chromium] Plumbing for top-level frame names
2899         https://bugs.webkit.org/show_bug.cgi?id=40430
2900
2901         * DumpRenderTree/chromium/WebViewHost.cpp:
2902         (WebViewHost::reset):
2903         Changed obsolete call to clearName() to use setName(WebString()) instead.
2904
2905 2010-06-18  Sam Weinig  <weinig@apple.com>
2906
2907         Rolling http://trac.webkit.org/changeset/61297 back in.
2908
2909         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2910         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2911         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2912         (_didClearWindow):
2913         (_didCreatePage):
2914         (WKBundleInitialize):
2915
2916 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2917
2918         Reviewed by Darin Adler.
2919
2920         https://bugs.webkit.org/show_bug.cgi?id=40803
2921         TestNetscapePlugin has an incorrect implementation of "property" property
2922
2923         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2924         pass a static string back, it's going to be released by NPAPI implementation.
2925
2926 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2927
2928         Unreviewed.
2929
2930         Adding myself to the committers list.
2931
2932         * Scripts/webkitpy/common/config/committers.py:
2933
2934 2010-06-17  Tony Chang  <tony@chromium.org>
2935
2936         Reviewed by Kent Tamura.
2937
2938         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2939         https://bugs.webkit.org/show_bug.cgi?id=40615
2940
2941         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2942
2943 2010-06-17  Ada Chan  <adachan@apple.com>
2944
2945         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
2946
2947         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2948         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
2949         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2950
2951 2010-06-17  Darin Adler  <darin@apple.com>
2952
2953         One more try at fix for Chromium build.
2954
2955         * DumpRenderTree/chromium/TestShell.cpp:
2956         (TestShell::TestShell): Use set again instead of =.
2957
2958 2010-06-17  Darin Adler  <darin@apple.com>
2959
2960         Fix Chromium build.
2961
2962         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
2963         code with all the other platforms! Wow, that should be fixed at some point.
2964
2965         * DumpRenderTree/chromium/TestShell.cpp:
2966         (TestShell::TestShell): Changed back to using "new".
2967         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2968
2969 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
2970
2971         Unreviewed Qt build fix.
2972
2973         LayoutTestController in the Qt DRT is not using refs :)
2974
2975         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2976         (WebCore::DumpRenderTree::DumpRenderTree):
2977
2978 2010-06-17  Darin Adler  <darin@apple.com>
2979
2980         Reviewed by Sam Weinig.
2981
2982         Use adoptRef and create functions in more code paths
2983         https://bugs.webkit.org/show_bug.cgi?id=40760
2984
2985         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
2986
2987         * DumpRenderTree/LayoutTestController.cpp:
2988         (LayoutTestController::create): Added.
2989         * DumpRenderTree/LayoutTestController.h: Declare the create function.
2990
2991         * DumpRenderTree/chromium/TestShell.cpp:
2992         (TestShell::TestShell): Use create instead of new.
2993         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
2994
2995         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2996         (runTest): Use RefPtr and create instead of OwnPtr and new.
2997
2998         * DumpRenderTree/mac/DumpRenderTree.mm:
2999         (runTest): Use RefPtr and create instead of OwnPtr and new.
3000
3001         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3002         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
3003         instead of new.
3004
3005         * DumpRenderTree/win/DumpRenderTree.cpp:
3006         (runTest): Use RefPtr and create instead of OwnPtr and new.
3007
3008         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3009         (runTest): Use RefPtr and create instead of OwnPtr and new.
3010         (MyApp::OnInit): Removed unneeded code to delete the layout
3011         test controller. This is done during each test.
3012
3013 2010-06-17  Kent Tamura  <tkent@chromium.org>
3014
3015         Reviewed by Shinichiro Hamaji.
3016
3017         [DRT/Chromium] Fix a bug of Windows pixel tests
3018         https://bugs.webkit.org/show_bug.cgi?id=40763
3019
3020         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3021         (TestShellPrinter::handleImage):
3022
3023 2010-06-16  Kent Tamura  <tkent@chromium.org>
3024
3025         Reviewed by Shinichiro Hamaji.
3026
3027         [DRT/Chromium] Fix crash on Mac Release
3028         https://bugs.webkit.org/show_bug.cgi?id=40759
3029
3030         * DumpRenderTree/chromium/WebViewHost.cpp:
3031         (WebViewHost::paintRect): We should not use m_canvas directly because
3032           it is created lazily in canvas().
3033
3034 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
3035
3036         [wx] Build fix after new method addition.
3037
3038         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3039         (LayoutTestController::pageProperty):
3040
3041 2010-06-16  Kent Tamura  <tkent@chromium.org>
3042
3043         Reviewed by Dimitri Glazkov.
3044
3045         [DRT/Chromium] Set current working directory for each of tests
3046         https://bugs.webkit.org/show_bug.cgi?id=40668
3047
3048         This change fixes tests with eventSender.beginDragWithFiles().
3049
3050         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3051         (runTest):
3052
3053 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
3054
3055         Reviewed by Gustavo Noronha Silva.
3056
3057         [GTK] r60803 broke media/controls-drag-timebar.html
3058         https://bugs.webkit.org/show_bug.cgi?id=40269
3059
3060         Only queue events while the mouse button is down, if drag mode is enabled. Some
3061         tests may disable drag mode, to prevent the queuing of events in this situation.
3062
3063         * DumpRenderTree/gtk/EventSender.cpp:
3064         (sendOrQueueEvent): Only queue events here if dragMode is true.
3065
3066 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
3067
3068         Reviewed by Gustavo Noronha Silva.
3069
3070         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
3071         https://bugs.webkit.org/show_bug.cgi?id=40600
3072
3073         * DumpRenderTree/gtk/EventSender.cpp:
3074         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
3075
3076 2010-06-16  Adam Barth  <abarth@webkit.org>
3077
3078         Reviewed by Dimitri Glazkov.
3079
3080         Add a hidden land-cowboy command to webkit-patch to help land quick
3081         build fixes.
3082
3083         * Scripts/webkitpy/tool/commands/download.py:
3084         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3085
3086 2010-06-16  Adam Roben  <aroben@apple.com>
3087
3088         Convert console messages to UTF-8 before printing them
3089
3090         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
3091         http/tests/security/xssAuditor/embed-tag-null-char.html and
3092         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
3093         Windows. (I can't test the fix because Apache is crashing on my
3094         computer.)
3095
3096         Reviewed by Alexey Proskuryakov.
3097
3098         * DumpRenderTree/win/DumpRenderTree.cpp:
3099         (toUTF8): Extracted the code into an overload that takes a wide string
3100         and a length, then added an overload that takes a wstring.
3101
3102         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
3103         overload.
3104
3105         * DumpRenderTree/win/UIDelegate.cpp:
3106         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
3107         UTF-8 instead of letting printf convert to the current code page.
3108
3109 2010-06-16  Drew Wilson  <atwilson@chromium.org>
3110
3111         Reviewed by Kent Tamura.
3112
3113         [Chromium] Plumbing for top-level frame names
3114         https://bugs.webkit.org/show_bug.cgi?id=40430
3115
3116         * DumpRenderTree/chromium/WebViewHost.cpp:
3117         (WebViewHost::createView):
3118         Migrate to new createView() API.
3119         * DumpRenderTree/chromium/WebViewHost.h:
3120         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
3121
3122 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
3123
3124         Reviewed by Kenneth Rohde Christiansen.
3125
3126         [Qt] Scroll wheel event support to graphics based DRT
3127         https://bugs.webkit.org/show_bug.cgi?id=40577
3128
3129         * DumpRenderTree/qt/EventSenderQt.cpp:
3130         (EventSender::continuousMouseScrollBy):
3131         (EventSender::createGraphicsSceneWheelEvent):
3132         * DumpRenderTree/qt/EventSenderQt.h:
3133
3134 2010-06-16  Adam Roben  <aroben@apple.com>
3135
3136         Remove a stray newline from the Windows version of TestNetscapePlugin
3137
3138         Reviewed by Alexey Proskuryakov.
3139
3140         Fixes <http://webkit.org/b/40728>
3141         plugins/geturlnotify-during-document-teardown.html fails on Windows
3142
3143         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3144         (NPP_Destroy): Removed extra newline that the Mac version doesn't
3145         have.
3146
3147 2010-06-16  Adam Roben  <aroben@apple.com>
3148
3149         Respect LayoutTestController::isPrinting on Windows
3150
3151         This gets some printing tests closer to passing (like
3152         printing/page-rule-in-media-query.html).
3153
3154         Fixes <http://webkit.org/b/40727>.
3155
3156         Reviewed by Dan Bernstein.
3157
3158         * DumpRenderTree/win/DumpRenderTree.cpp:
3159         (dump): Pass LayoutTestController::isPrinting to
3160         IWebFramePrivate::renderTreeAsExternalRepresentation.
3161
3162 2010-06-15  Adam Barth  <abarth@webkit.org>
3163
3164         Reviewed by Eric Seidel.
3165
3166         Enable HTML5 lexer
3167         https://bugs.webkit.org/show_bug.cgi?id=40650
3168
3169         * DumpRenderTree/mac/DumpRenderTree.mm:
3170         (initializeGlobalsFromCommandLineOptions):
3171
3172 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
3173
3174         Reviewed by Shinichiro Hamaji.
3175
3176         Implement render style selection for pages to support CSS3 Paged Media.
3177         https://bugs.webkit.org/show_bug.cgi?id=35961
3178
3179         * DumpRenderTree/LayoutTestController.cpp:
3180         (parsePagePropertyParameters):
3181         (pagePropertyCallback):
3182         (LayoutTestController::staticFunctions):
3183         * DumpRenderTree/LayoutTestController.h:
3184         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3185         (LayoutTestController::pageProperty):
3186         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3187         (LayoutTestController::pageProperty):
3188         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3189         (LayoutTestController::pageProperty):
3190
3191 2010-06-15  Sam Weinig  <sam@webkit.org>
3192
3193         Reviewed by Anders Carlsson.
3194
3195         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
3196         WebKit2: Add mechanism to inject code into the WebProcess on startup
3197
3198         Add initial InjectedBundle support.
3199
3200         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3201         * MiniBrowser/WebBundle-Info.plist: Added.
3202         Add test InjectedBundle to the project.
3203
3204         * MiniBrowser/mac/AppDelegate.m:
3205         (-[BrowserAppDelegate init]):
3206         Get the path to the WebBundle from the the main bundle and pass it to the new
3207         WKContextCreateWithInjectedBundlePath function.
3208
3209         * MiniBrowser/mac/BrowserWindowController.m:
3210         (_didChangeProgress):
3211         Fix the build.  This has been broken for a while.
3212
3213         * MiniBrowser/mac/WebBundle: Added.
3214         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
3215         (_didCreatePage):
3216         (WKBundleInitialize):
3217         Add really basic InjectedBundle.
3218
3219         * MiniBrowser/win/BrowserView.cpp:
3220         (BrowserView::create):
3221         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
3222
3223 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
3224
3225         Reviewed by Darin Adler.
3226
3227         Adding myself to the reviewers list.
3228         https://bugs.webkit.org/show_bug.cgi?id=40693
3229
3230         * Scripts/webkitpy/common/config/committers.py:
3231
3232 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
3233
3234         Reviewed by Xan Lopez.
3235
3236         Switch to using GIO methods instead of realpath in GtkLauncher to determine
3237         the file URI. This should remove warnings about realpath being undefined
3238         when compiling with '-ansi'.
3239
3240         * GtkLauncher/main.c:
3241         (filenameToURL): Use GIO instead of realpath to determine file URI.
3242
3243 2010-06-15  Adam Roben  <aroben@apple.com>
3244
3245         Remove the redundant set-apple-windows-environment-variables script
3246
3247         Apparently update-webkit does this for you these days.
3248
3249         Rubber-stamped by Steve Falkenburg.
3250
3251         * Scripts/set-apple-windows-environment-variables: Removed.
3252
3253 2010-06-14  Adam Roben  <aroben@apple.com>
3254
3255         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
3256         environment variables
3257
3258         Fixes <http://webkit.org/b/40595>.
3259
3260         Reviewed by Steve Falkenburg.
3261
3262         * Scripts/set-apple-windows-environment-variables: Added.
3263         (to_windows_path): Passes the passed-in path through cygpath to
3264         generate a Windows-style path.
3265         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
3266         variables to their defaults, if they aren't already set.
3267
3268 2010-06-14  Adam Roben  <aroben@apple.com>
3269
3270         Speed up run-safari/debug-safari on Windows
3271
3272         Fixes <http://webkit.org/b/40586>.
3273
3274         Reviewed by Steve Falkenburg.
3275
3276         * Scripts/webkitdirs.pm:
3277         (runSafari): When debugging, set up the environment to run Safari
3278         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
3279         actually launch the debugger. When not debugging, just run WebKit.exe
3280         and it will do the rest for us.
3281
3282 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
3283
3284         Reviewed by Kenneth Rohde Christiansen.
3285
3286         [Qt] DRT EventSender support to graphics context events
3287         https://bugs.webkit.org/show_bug.cgi?id=40324
3288
3289         * DumpRenderTree/qt/EventSenderQt.cpp:
3290         (EventSender::contextClick):
3291
3292 2010-06-14  Tony Chang  <tony@chromium.org>
3293
3294         Reviewed by Darin Fisher.
3295
3296         [chromium] checkout chromium third_party directly
3297         https://bugs.webkit.org/show_bug.cgi?id=40556
3298
3299         * Scripts/update-webkit-chromium: some migration code for the bots
3300
3301 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3302
3303         Chromium build fix.
3304
3305         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
3306         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
3307
3308 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3309
3310         Reviewed by Darin Adler.
3311
3312         https://bugs.webkit.org/show_bug.cgi?id=40529
3313         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
3314
3315         * DumpRenderTree/mac/EventSendingController.mm:
3316         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
3317         event for "delete" - it had virtual key code from forward delete, and text from backspace.
3318         Fixed "delete" to mean forward delete.
3319
3320         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
3321         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
3322         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3323         Mac DRT confusion has propagated to other platforms, fixing those.
3324
3325 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
3326
3327         Reviewed by Xan Lopez.
3328
3329         Small GtkLauncher build fix for some systems.
3330
3331         * GtkLauncher/main.c: Add <limit.h> include.
3332
3333 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3334
3335         Reviewed by Laszlo Gombos.
3336
3337         [Qt] navigator.geolocation support for Qt port
3338         https://bugs.webkit.org/show_bug.cgi?id=39724
3339
3340         Implementation for geolocation cases to DumpRenderTreeQt
3341
3342         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3343         (WebCore::WebPage::allowGeolocationRequest):
3344         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3345         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3346         (LayoutTestController::setGeolocationPermission):
3347         (LayoutTestController::setMockGeolocationError):
3348         (LayoutTestController::setMockGeolocationPosition):
3349         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3350         (LayoutTestController::isGeolocationPermissionSet):
3351         (LayoutTestController::geolocationPermission):
3352
3353 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
3354
3355         Reviewed by Darin Adler.
3356
3357         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
3358         be a way of overwriting the Xcode system path.  Making
3359         $WEBKITOUTPUTDIR take precedence over the system default would make
3360         this possible.
3361
3362         * Scripts/webkitdirs.pm:
3363
3364 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
3365
3366         Reviewed by Darin Adler.
3367
3368         AX: link won't return linked element if URL contains #
3369         https://bugs.webkit.org/show_bug.cgi?id=40192
3370
3371         * DumpRenderTree/AccessibilityUIElement.cpp:
3372         (linkedUIElementAtIndexCallback):
3373         (AccessibilityUIElement::getJSClass):
3374         * DumpRenderTree/AccessibilityUIElement.h:
3375         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3376         (AccessibilityUIElement::linkedUIElementAtIndex):
3377         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3378         (AccessibilityUIElement::linkedUIElementAtIndex):
3379         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3380         (AccessibilityUIElement::linkedUIElementAtIndex):
3381
3382 2010-06-13  Adam Barth  <abarth@webkit.org>
3383
3384         Reviewed by Darin Adler.
3385
3386         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
3387         https://bugs.webkit.org/show_bug.cgi?id=39550
3388
3389         This can cause an extra request to bugs.webkit.org durig upload, but it
3390         shouldn't be too bad.  Also, this won't work if you remove the
3391         boilerplate created by prepare-ChangeLog.
3392
3393         * Scripts/webkitpy/common/checkout/changelog.py:
3394         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3395         * Scripts/webkitpy/common/net/bugzilla.py:
3396         * Scripts/webkitpy/tool/steps/abstractstep.py:
3397         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3398         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
3399
3400 2010-06-08  Robert Hogan  <robert@webkit.org>
3401
3402         Reviewed by Eric Seidel.
3403
3404         [Qt] Add support for callShouldCloseOnWebView() to DRT
3405         https://bugs.webkit.org/show_bug.cgi?id=40330
3406
3407         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3408         (LayoutTestController::callShouldCloseOnWebView):
3409         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3410         (LayoutTestController::setCallCloseOnWebViews):
3411
3412 2010-06-12  Eric Seidel  <eric@webkit.org>
3413
3414         Reviewed by Daniel Bates.
3415
3416         do-webcore-rename should have a --verbose option
3417         https://bugs.webkit.org/show_bug.cgi?id=40497
3418
3419         * Scripts/do-webcore-rename:
3420          - Unified how we handle skipping files/directories
3421            this will allow us to "black list" certain files and
3422            directories when performing renames.
3423          - Made do-webcore-rename log what it's skipping when passed --verbose.
3424
3425 2010-06-12  Darin Adler  <darin@apple.com>
3426
3427         * Scripts/run-bindings-tests: Fixed a typo in a message.
3428
3429 2010-06-12  Kent Tamura  <tkent@chromium.org>
3430
3431         Reviewed by Dimitri Glazkov.
3432
3433         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3434         https://bugs.webkit.org/show_bug.cgi?id=40402
3435
3436         _build_path() of each Chromium port check existence of build path
3437         of Chromium checkout first, then check existence of build path of
3438         WebKit-only checkout.
3439
3440         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3441         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3442         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3443
3444 2010-06-12  Robert Hogan  <robert@webkit.org>
3445
3446         Reviewed by Kenneth Rohde Christiansen.
3447
3448         [Qt] Back-forward list dumping is incorrect
3449
3450         https://bugs.webkit.org/show_bug.cgi?id=36392
3451
3452         Support dumping child history items in DRT.
3453
3454         Unskip:
3455
3456         fast/loader/frame-src-change-added-to-history.html
3457         fast/loader/frame-src-change-not-added-to-history.html
3458         fast/loader/frame-location-change-not-added-to-history.html
3459
3460         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3461         (WebCore::dumpHistoryItem):
3462
3463 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3464
3465         Reviewed by Eric Seidel.
3466
3467         upload all patches that lack in-rietveld to rietveld
3468         https://bugs.webkit.org/show_bug.cgi?id=40444
3469
3470         If it's a patch, then we'll try to upload it as long as it
3471         doesn't have in-rietveld set. No longer set in-rietveld? since
3472         it's not needed.
3473
3474         * Scripts/webkitpy/common/net/bugzilla.py:
3475
3476 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3477
3478         Reviewed by Darin Fisher.
3479
3480         Fix rietveld upload when message length > 100 characters
3481         https://bugs.webkit.org/show_bug.cgi?id=40457
3482
3483         * Scripts/webkitpy/common/net/rietveld.py:
3484
3485 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3486
3487         Reviewed by Laszlo Gombos.
3488
3489         [Qt] There should be a way to enable popups in QtTestBrowser
3490         https://bugs.webkit.org/show_bug.cgi?id=40427
3491
3492         * QtTestBrowser/main.cpp:
3493         (LauncherWindow::toggleJavascriptCanOpenWindows):
3494         (LauncherWindow::createChrome):
3495
3496 2010-06-10  Adam Barth  <abarth@webkit.org>
3497
3498         Reviewed by Daniel Bates.
3499
3500         Make SheriffBot more chatty
3501         https://bugs.webkit.org/show_bug.cgi?id=40463
3502
3503         People seem to like to talk to SheriffBot, so let's make him chat back.
3504
3505         * Scripts/webkitpy/thirdparty/__init__.py:
3506         * Scripts/webkitpy/tool/bot/irc_command.py:
3507         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3508         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3509         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3510
3511 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3512
3513         Reviewed by Darin Adler.
3514
3515         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3516         
3517         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3518         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3519         WEXITSTATUS on $result instead of just comparing $result to 0.
3520
3521         * Scripts/update-webkit-auxiliary-libs:
3522
3523 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3524
3525         Reviewed by Alexey Proskuryakov.
3526
3527         don't use Exception.message as it's deprecated in python 2.6+
3528         https://bugs.webkit.org/show_bug.cgi?id=40449
3529
3530         * Scripts/webkitpy/tool/commands/queues.py:
3531
3532 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3533
3534         Reviewed by Adam Barth.
3535
3536         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3537         https://bugs.webkit.org/show_bug.cgi?id=40436
3538
3539         * Scripts/webkitpy/common/system/outputcapture.py:
3540         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3541         * Scripts/webkitpy/tool/commands/queues.py:
3542         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3543         * Scripts/webkitpy/tool/commands/queuestest.py:
3544         * Scripts/webkitpy/tool/mocktool.py:
3545
3546 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3547
3548         Reviewed by Simon Hausmann.
3549
3550         [Qt] *All* WebGL layout tests fail!
3551         https://bugs.webkit.org/show_bug.cgi?id=40296
3552
3553         Added test for WebKitWebGLEnabled to
3554         LayoutTestController::overridePreference().
3555
3556         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3557         (LayoutTestController::overridePreference):
3558
3559 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3560
3561         Reviewed by Kenneth Rohde Christiansen.
3562
3563         [Qt] DRT EventSender support to graphics mouse events activation
3564         https://bugs.webkit.org/show_bug.cgi?id=40017
3565
3566         * DumpRenderTree/qt/EventSenderQt.cpp:
3567         (EventSender::mouseDown):
3568         (EventSender::mouseUp):
3569         (EventSender::mouseMoveTo):
3570         (EventSender::keyDown):
3571         (EventSender::contextClick):
3572         (EventSender::sendTouchEvent):
3573         (EventSender::sendOrQueueEvent):
3574         (EventSender::eventFilter):
3575         (EventSender::createGraphicsSceneMouseEvent):
3576         (EventSender::sendEvent):
3577         * DumpRenderTree/qt/EventSenderQt.h:
3578         (EventSender::isGraphicsBased):
3579
3580 2010-06-09  Adam Barth  <abarth@webkit.org>
3581
3582         Reviewed by Ojan Vafai.
3583
3584         webkit-patch upload fails for security bugs because there's no rietveld flag
3585         https://bugs.webkit.org/show_bug.cgi?id=40309
3586
3587         There's probably a more elegant way of seeing whether the form control
3588         exists, but this seems to work.
3589
3590         * Scripts/webkitpy/common/net/bugzilla.py:
3591
3592 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3593
3594         Reviewed by Adam Barth.
3595
3596         make rietveld upload faster and avoid posting to bug on errors
3597         https://bugs.webkit.org/show_bug.cgi?id=40389
3598
3599         Only grab the first item of the upload queue instead of trying
3600         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3601
3602         Also, don't post comments to the bug when uploading fails.
3603
3604         * Scripts/webkitpy/common/net/bugzilla.py:
3605         * Scripts/webkitpy/tool/commands/queues.py:
3606         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3607         * Scripts/webkitpy/tool/commands/stepsequence.py:
3608         * Scripts/webkitpy/tool/mocktool.py:
3609
3610 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3611
3612         Reviewed by Adam Barth.
3613
3614         Rietveld upload queue fails when setting in-rietveld flag
3615         https://bugs.webkit.org/show_bug.cgi?id=40371
3616
3617         Make the comment arguments to set_flag_on_attachment optional
3618         and add it to the MockBugzilla.
3619
3620         * Scripts/webkitpy/common/net/bugzilla.py:
3621         * Scripts/webkitpy/tool/bot/queueengine.py:
3622         * Scripts/webkitpy/tool/commands/download_unittest.py:
3623         * Scripts/webkitpy/tool/commands/queues.py:
3624         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3625         * Scripts/webkitpy/tool/mocktool.py:
3626
3627 2010-06-09  Kenneth Russell  <kbr@google.com>
3628
3629         Reviewed by Dimitri Glazkov.
3630
3631         Rename FloatArray to Float32Array
3632         https://bugs.webkit.org/show_bug.cgi?id=40323
3633
3634         Used do-webcore-rename to perform renaming. Manually undid
3635         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3636         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3637         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3638         all layout tests on Safari; built Chromium and ran selected WebGL
3639         tests.
3640
3641         * Scripts/do-webcore-rename:
3642
3643 2010-06-08  Tony Chang  <tony@chromium.org>
3644
3645         Reviewed by David Levin.
3646
3647         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3648         https://bugs.webkit.org/show_bug.cgi?id=40285
3649
3650         * Scripts/webkitdirs.pm:
3651         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3652
3653 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3654
3655         Reviewed by Tamura Kent.
3656
3657         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3658         https://bugs.webkit.org/show_bug.cgi?id=40052
3659         
3660         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3661
3662         * DumpRenderTree/DumpRenderTree.gypi:
3663         * DumpRenderTree/chromium/TestShellWin.cpp:
3664         (platformInit):
3665         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3666         (WebKit::):
3667         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3668         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3669         (WebKit::WebThemeControlDRT::box):
3670         (WebKit::WebThemeControlDRT::line):
3671         (WebKit::WebThemeControlDRT::triangle):
3672         (WebKit::WebThemeControlDRT::roundRect):
3673         (WebKit::WebThemeControlDRT::oval):
3674         (WebKit::WebThemeControlDRT::circle):
3675         (WebKit::WebThemeControlDRT::nestedBoxes):
3676         (WebKit::WebThemeControlDRT::markState):
3677         (WebKit::WebThemeControlDRT::draw):
3678         (WebKit::WebThemeControlDRT::drawTextField):
3679         (WebKit::WebThemeControlDRT::drawProgressBar):
3680         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3681         (WebKit::WebThemeControlDRT::):
3682         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3683         (WebKit::):
3684         (WebKit::WebThemeEngineDRT::paintButton):
3685         (WebKit::WebThemeEngineDRT::paintMenuList):
3686         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3687         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3688         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3689         (WebKit::WebThemeEngineDRT::paintTextField):
3690         (WebKit::WebThemeEngineDRT::paintTrackbar):
3691         (WebKit::WebThemeEngineDRT::paintProgressBar):
3692         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3693         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):