2010-09-07 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Kent Tamura.
4
5         Fix regression introduced in previous change to new-run-webkit-tests
6         (bug 45090) to not try to run unittests for the Mac implementation
7         of the Port interface if we aren't running on a Mac.
8
9         Also fix the overrides implementation mock in the chromium unittests
10         to fix the case where there are overrides checked in that cause
11         problems.
12
13         https://bugs.webkit.org/show_bug.cgi?id=45357
14
15         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
16         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
17         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
18
19 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
20
21         Reviewed by Ojan Vafai.
22
23         new-run-webkit-tests: still more unit tests
24
25         Clean up and remove unnecessary code. Biggest notable change is
26         moving the chromium-specific imagediff code from port/base to
27         port/chromium.
28
29         Add more unit tests for run_webkit_tests.py, port/base.py,
30         port/factory.py, port/dryrun.py, and
31         layout_package/dump_render_tree_thread.py
32
33         This covers almost all of the generic and test code paths except for
34         a few error paths involving invalid or port-specific command line
35         arguments, and the code path for uploading results files to the
36         buildbots.
37         
38         https://bugs.webkit.org/show_bug.cgi?id=45090
39
40         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
41         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
42         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
43         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
44         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
45         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
46         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
47         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
48         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
49         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
50         * Scripts/webkitpy/layout_tests/port/base.py:
51         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
52         * Scripts/webkitpy/layout_tests/port/chromium.py:
53         * Scripts/webkitpy/layout_tests/port/dryrun.py:
54         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
55         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
56         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
57         * Scripts/webkitpy/layout_tests/port/server_process.py:
58         * Scripts/webkitpy/layout_tests/port/test.py:
59         * Scripts/webkitpy/layout_tests/port/webkit.py:
60         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
61         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
62
63 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
64
65         Reviewed by Darin Adler.
66
67         Provide a way to trigger a <select multiple> onchange event on changes
68         https://bugs.webkit.org/show_bug.cgi?id=45192
69
70         Adds a selector on ObjCController for testing
71         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
72         its different uses.
73
74         * DumpRenderTree/mac/ObjCController.m:
75         (+[ObjCController isSelectorExcludedFromWebScript:]):
76         (+[ObjCController webScriptNameForSelector:]):
77         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
78
79 2010-09-07  James Robinson  <jamesr@chromium.org>
80
81         Rubber-stamped by Dimitri Glazkov.
82
83         Move myself from the committer to the reviewer list.
84
85         * Scripts/webkitpy/common/config/committers.py:
86
87 2010-09-07  Tony Chang  <tony@chromium.org>
88
89         Reviewed by Darin Fisher.
90
91         [chromium] Make a public flag for how DRT generates bitmaps on Linux
92         https://bugs.webkit.org/show_bug.cgi?id=45133
93
94         * DumpRenderTree/chromium/TestShell.cpp:
95         (TestShell::dumpImage):
96
97 2010-09-07  Kent Tamura  <tkent@chromium.org>
98
99         Reviewed by Dimitri Glazkov.
100
101         [DRT/Chromium] Implement --check-layout-test-sys-deps
102         https://bugs.webkit.org/show_bug.cgi?id=45283
103
104         * DumpRenderTree/chromium/DumpRenderTree.cpp:
105         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
106         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
107         * DumpRenderTree/chromium/TestShellGtk.cpp:
108         (checkLayoutTestSystemDependencies): Add an empty implementation.
109         * DumpRenderTree/chromium/TestShellMac.mm:
110         (checkLayoutTestSystemDependencies): Add an empty implementation.
111         * DumpRenderTree/chromium/TestShellWin.cpp:
112         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
113
114 2010-09-07  Jessie Berlin  <jberlin@apple.com>
115
116         Unreviewed. Mac build fix.
117
118         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
119         (didClearWindowObjectForFrame):
120
121 2010-09-07  Jessie Berlin  <jberlin@apple.com>
122
123         Reviewed by Darin Adler.
124
125         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
126         https://bugs.webkit.org/show_bug.cgi?id=45217
127         
128         Make WebKitTestRunner work with this change.
129
130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
131         (WTR::InjectedBundlePage::didClearWindowForFrame):
132         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
133         WebFrameLoaderClient.
134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
135
136 2010-09-07  Philippe Normand  <pnormand@igalia.com>
137
138         Unreviewed, build fix.
139
140         webkit-patch command to find the ports covering a specific layout test
141         https://bugs.webkit.org/show_bug.cgi?id=42832
142
143         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
144         tests are present when building the expectations. This is needed
145         for the unittests.
146
147 2010-09-06  Philippe Normand  <pnormand@igalia.com>
148
149         Reviewed by Adam Barth.
150
151         webkit-patch command to find the ports covering a specific layout test
152         https://bugs.webkit.org/show_bug.cgi?id=42832
153
154         To use it: webkit-patch skipped-ports some/layout/test.html
155
156         * Scripts/webkitpy/layout_tests/port/base.py:
157         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
158         * Scripts/webkitpy/layout_tests/port/chromium.py:
159         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
160         * Scripts/webkitpy/layout_tests/port/factory.py:
161         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
162         * Scripts/webkitpy/layout_tests/port/test.py:
163         * Scripts/webkitpy/layout_tests/port/webkit.py:
164         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
165         * Scripts/webkitpy/tool/commands/queries.py:
166         * Scripts/webkitpy/tool/commands/queries_unittest.py:
167         * Scripts/webkitpy/tool/main.py:
168         * Scripts/webkitpy/tool/mocktool.py:
169
170 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
171
172         Reviewed by Eric Seidel.
173
174         [NRWT] Add temp directory to all running drivers.
175         https://bugs.webkit.org/show_bug.cgi?id=45261
176
177         * Scripts/webkitpy/layout_tests/port/webkit.py:
178
179 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
180
181         Reviewed by Kent Tamura.
182
183         [Chromium/DRT] Empty out user stylesheet after each test run.
184         https://bugs.webkit.org/show_bug.cgi?id=45282
185
186         This should significantly cut down on the number of the mysterious flaky tests
187         whose diffs looked like the page was blown up to a very lage size. This
188         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
189         which set the base body font to 100px.
190
191         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
192         the same thread failed.
193
194         * DumpRenderTree/chromium/TestShell.cpp:
195         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
196
197 2010-09-06  Kent Tamura  <tkent@chromium.org>
198
199         Reviewed by Dimitri Glazkov.
200
201         [DRT/Chromium] Do not generate pixel results for text/plain resources
202         https://bugs.webkit.org/show_bug.cgi?id=45253
203
204         * DumpRenderTree/chromium/TestShell.cpp:
205         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
206
207 2010-09-06  Ojan Vafai  <ojan@chromium.org>
208
209         Reviewed by Kent Tamura.
210
211         print out correct error when a DRT thread dies in NRWT
212         https://bugs.webkit.org/show_bug.cgi?id=45281
213
214         Not sure why, but with the parens, python 2.6.5 on Linux
215         gives an error that raise takes 5 arguments and 0 were given.
216         Didn't test other platforms or python versions, but putting it
217         all on one line fixes it and correctly prints the exception
218         from the DRT thread.
219
220         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
221
222 2010-09-06  Eric Seidel  <eric@webkit.org>
223
224         Unreviewed, just adding some emails from lists.webkit.org.
225
226         Update committers.py to include emails from lists.webkit.org
227         as found by the validate-committer-lists script.
228
229         * Scripts/webkitpy/common/config/committers.py:
230
231 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
232
233         Reviewed by Xan Lopez.
234
235         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
236         https://bugs.webkit.org/show_bug.cgi?id=45213
237
238         * DumpRenderTree/gtk/DumpRenderTree.cpp:
239         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
240         have to surround the invocation with #ifdefs.
241         (useLongRunningServerMode): Added.
242         (runTestingServerLoop): Added.
243         (initializeGlobalsFromCommandLineOptions): Added.
244         (runTest): Removed ifdefs.
245         (main): Use new helper functions.
246
247 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
248
249         Reviewed by Xan Lopez.
250
251         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
252         https://bugs.webkit.org/show_bug.cgi?id=45235
253
254         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
255         methods of the EventSender.
256
257         * DumpRenderTree/gtk/EventSender.cpp:
258         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
259         with the current modifiers.
260         (contextClickCallback): Always send no modifiers when preparing the mouse event.
261         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
262         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
263         (mouseUpCallback): Ditto.
264
265 2010-09-05  Peter Kasting  <pkasting@google.com>
266
267         Reviewed by Adam Barth.
268
269         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
270         https://bugs.webkit.org/show_bug.cgi?id=45155
271
272         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
273         (EventSender::handleMouseWheel):
274
275 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
276
277         Reviewed by Joseph Pecoraro.
278
279         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
280         https://bugs.webkit.org/show_bug.cgi?id=45179
281
282         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
283         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
284
285 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
286
287         Rubber-stamped by Daniel Bates.
288
289         Adding myself as reviewer.
290
291         * Scripts/webkitpy/common/config/committers.py:
292
293 2010-09-04  Daniel Bates  <dbates@rim.com>
294
295         Reviewed by Martin Robinson.
296
297         Teach svn-apply/unapply about svn:mergeinfo
298         https://bugs.webkit.org/show_bug.cgi?id=45236
299
300         Recognize the svn:mergeinfo property and ignore it for now.
301
302         Currently, svn-apply/unapply recognize only '+' and '-'
303         property changes within a diff. We should add support
304         to recognize "Merged" and "Reverse-merged" changes as well.
305         Because svn:mergeinfo is metadata that is used only by SVN
306         and tends to be error-prone and/or nuisance (*), we will ignore
307         it for now.
308         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
309
310         * Scripts/VCSUtils.pm:
311           - Modified parseSvnProperty() to recognize "Merged" and
312             "Reverse-merged" as the start of a property value.
313         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
314           - Added the following unit tests:
315             "simple: add svn:mergeinfo"
316             "simple: delete svn:mergeinfo"
317             "simple: modified svn:mergeinfo"
318         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
319           - Added the following unit tests:
320             "simple: add svn:mergeinfo"
321             "simple: delete svn:mergeinfo"
322             "simple: modified svn:mergeinfo"
323             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
324             "'Merged' change followed by 'Merged' change"
325             "'Reverse-merged' change followed by 'Reverse-merged' change"
326         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
327           - Added the following unit tests:
328             "'Merged' change"
329             "'Reverse-merged' change"
330             "'Reverse-merged' change followed by 'Merge' change"
331             "'Merged' change followed by 'Merge' change"
332             "'Reverse-merged' change followed by 'Reverse-merged' change"
333             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
334
335 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
336
337         Reviewed by Kenneth Rohde Christiansen.
338
339         [EFL] Move test browser to WebKitTools directory
340         https://bugs.webkit.org/show_bug.cgi?id=45212
341
342         Follow other ports like QT and GTK which moved the test browser to
343         WebKitTools directory.
344
345         * CMakeListsEfl.txt: Added.
346         * EWebLauncher/main.c: Added.
347         (print_history):
348         (zoom_level_set):
349         (on_ecore_evas_resize):
350         (title_set):
351         (viewport_set):
352         (on_title_changed):
353         (on_progress):
354         (on_load_finished):
355         (on_toolbars_visible_set):
356         (on_toolbars_visible_get):
357         (on_statusbar_visible_set):
358         (on_statusbar_visible_get):
359         (on_scrollbars_visible_set):
360         (on_scrollbars_visible_get):
361         (on_menubar_visible_set):
362         (on_menubar_visible_get):
363         (on_tooltip_text_set):
364         (on_inputmethod_changed):
365         (on_viewport_changed):
366         (on_mouse_down):
367         (on_focus_out):
368         (on_focus_in):
369         (on_resized):
370         (on_key_down):
371         (on_browser_del):
372         (on_closeWindow):
373         (quit):
374         (browserCreate):
375         (browserDestroy):
376         (closeWindow):
377         (main_signal_exit):
378         (findThemePath):
379         (main):
380
381 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
382
383         Reviewed by Adam Roben.
384
385         Set project dependencies so that they build serially. This fixes
386         issues when running run-webkit-tests if DRT is not built yet.
387
388         * DumpRenderTree/DumpRenderTree.sln:
389
390 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
391
392         Reviewed by Adam Barth.
393
394         Fix reading configuraiton in NWRT to work on Windows.
395         https://bugs.webkit.org/show_bug.cgi?id=45180
396
397         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
398             with the file otherwise.
399
400 2010-09-03  Chris Rogers  <crogers@google.com>
401
402         Unreviewed
403
404         Add myself to the committers list
405         https://bugs.webkit.org/show_bug.cgi?id=45189
406
407         * Scripts/webkitpy/common/config/committers.py:
408
409 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
410
411         Reviewed by Yury Semikhatsky.
412
413         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
414         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
415         https://bugs.webkit.org/show_bug.cgi?id=45137
416
417         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
418
419 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
420
421         Reviewed by Eric Seidel.
422
423         Add feature detection support to NRWT.
424         https://bugs.webkit.org/show_bug.cgi?id=41842
425
426         * Scripts/webkitpy/layout_tests/port/base.py:
427         * Scripts/webkitpy/layout_tests/port/qt.py:
428         * Scripts/webkitpy/layout_tests/port/webkit.py:
429         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
430
431 2010-09-03  Hironori Bono  <hbono@chromium.org>
432
433         Reviewed by Kent Tamura.
434
435         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
436         and implements it for Mac.
437         https://bugs.webkit.org/show_bug.cgi?id=41832
438
439         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
440         and bind it so we can call it from JavaScript.
441         (+[TextInputController isSelectorExcludedFromWebScript:]):
442         (+[TextInputController webScriptNameForSelector:]):
443         (-[TextInputController hasSpellingMarker:length:]):
444
445 2010-09-02  Eric Seidel  <eric@webkit.org>
446
447         Reviewed by Adam Barth.
448
449         Add a unit test for commit-queue retries
450         https://bugs.webkit.org/show_bug.cgi?id=45162
451
452         I think commit-queue retries are not correctly avoiding
453         build and test on retries.  So I started testing the code.
454         Unfortunately this test did not find the bug.  But now
455         that we have the test we might as well keep it.
456         I also fixed a broken import in validate-committer-lists.
457
458         * Scripts/validate-committer-lists:
459         * Scripts/webkitpy/tool/commands/queues_unittest.py:
460
461 2010-09-02  Kent Tamura  <tkent@chromium.org>
462
463         Reviewed by Dimitri Glazkov.
464
465         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
466         https://bugs.webkit.org/show_bug.cgi?id=45091
467
468         Task.{cpp,h} introduces a simpler version of Chromium
469         base/task.h. It doesn't have TupleN and Method.
470
471         * DumpRenderTree/DumpRenderTree.gypi:
472          Add Task.cpp and Task.h
473         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
474         (DRTDevToolsAgent::DRTDevToolsAgent):
475         (DRTDevToolsAgent::reset):
476         (DRTDevToolsAgent::asyncCall):
477         (DRTDevToolsAgent::frontendLoaded):
478         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
479         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
480         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
481         (DRTDevToolsClient::DRTDevToolsClient):
482         (DRTDevToolsClient::~DRTDevToolsClient):
483         (DRTDevToolsClient::reset):
484         (DRTDevToolsClient::asyncCall):
485         * DumpRenderTree/chromium/DRTDevToolsClient.h:
486         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
487         * DumpRenderTree/chromium/EventSender.cpp:
488         (EventSender::EventSender):
489         (EventSender::reset):
490         (EventSender::scheduleAsynchronousClick):
491         * DumpRenderTree/chromium/EventSender.h:
492         (EventSender::taskList): Added to use MethodTask<T>.
493         * DumpRenderTree/chromium/LayoutTestController.cpp:
494         (LayoutTestController::LayoutTestController):
495         (LayoutTestController::WorkQueue::processWorkSoon):
496         (LayoutTestController::waitUntilDone):
497         (LayoutTestController::notifyDone):
498         (LayoutTestController::reset):
499         * DumpRenderTree/chromium/LayoutTestController.h:
500         (LayoutTestController::taskList): Added to use MethodTask<T>.
501         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
502         * DumpRenderTree/chromium/NotificationPresenter.cpp:
503         (deferredDisplayDispatch):
504         (NotificationPresenter::show):
505         * DumpRenderTree/chromium/Task.cpp: Added.
506         * DumpRenderTree/chromium/Task.h: Added.
507
508 2010-09-02  Steve Block  <steveblock@google.com>
509
510         Reviewed by Adam Barth.
511
512         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
513         https://bugs.webkit.org/show_bug.cgi?id=43181
514
515         * DumpRenderTree/mac/DumpRenderTree.mm:
516         (createWebViewAndOffscreenWindow):
517         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
518         (LayoutTestController::setMockDeviceOrientation):
519
520 2010-08-31  Adam Roben  <aroben@apple.com>
521
522         Fix flashiness when resizing the browser window on Windows
523
524         Reviewed by Sam Weinig.
525
526         * MiniBrowser/win/BrowserWindow.cpp:
527         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
528         periodically fill the window with white.
529
530 2010-09-02  Peter Kasting  <pkasting@google.com>
531
532         Reviewed by Dimitri Glazkov.
533
534         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
535         https://bugs.webkit.org/show_bug.cgi?id=45073
536
537         * DumpRenderTree/chromium/EventSender.cpp:
538         (EventSender::EventSender):
539         (EventSender::mouseScrollBy):
540         (EventSender::continuousMouseScrollBy):
541         (EventSender::sendCurrentTouchEvent):
542         (EventSender::handleMouseWheel):
543         * DumpRenderTree/chromium/EventSender.h:
544         * DumpRenderTree/gtk/EventSender.cpp:
545         (mouseScrollByCallback):
546         (continuousMouseScrollByCallback):
547
548 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
549
550         Reviewed by Tony Chang.
551
552         Land a patched version of r66542 - change TestRunner to have an
553         separate cleanup method and fix the ordering of cleanup between
554         TestRunner and the printing module, and then wrap everything in a
555         try/finally block to ensure reliable cleanup without needing to
556         rely on stuff happening in the destructor of the TestRunner.
557
558         Also refactor run_webkit_tests.run() to be much smaller and cleaner
559         by creating a bunch of helper methods and moving more stuff into
560         the TestRunner class.
561
562         This fixes the crash at the end of the linux test run of
563         new-run-webkit-tests (and undoes the rollout in 66547).
564
565         https://bugs.webkit.org/show_bug.cgi?id=44902
566
567         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
568         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
569         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
570         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
571         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
572         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
573         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
574         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
575         * Scripts/webkitpy/layout_tests/port/base.py:
576         * Scripts/webkitpy/layout_tests/port/test.py:
577         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
578         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
579
580 2010-09-01  Mark Rowe  <mrowe@apple.com>
581
582         Reviewed by Adam Roben.
583
584         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
585
586         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
587
588 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
589
590         Reviewed by Adam Roben.
591
592         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
593         and WebKitTestRunner.
594
595         * BuildSlaveSupport/win/kill-old-processes:
596
597 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
598
599         Reviewed by Antonio Gomes.
600
601         [Qt] Remove obsolete include path from DumpRenderTree.pro
602
603         * DumpRenderTree/qt/DumpRenderTree.pro:
604
605 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
606
607         Reviewed by Laszlo Gombos.
608
609         [Qt] QWebPage::allowGeolocationRequest should be async API
610         https://bugs.webkit.org/show_bug.cgi?id=41364
611
612         Implements new async API for geolocation permission similar to
613         Notification. WebPage maintains list of geolocation permission request
614         QtWebkit and set's when LayoutTestController gets the access from test JS
615
616         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
617         (WebCore::WebPage::WebPage):
618         (WebCore::WebPage::resetSettings):
619         (WebCore::WebPage::requestPermission):
620         (WebCore::WebPage::cancelPermission):
621         (WebCore::WebPage::permissionSet):
622         (WebCore::DumpRenderTree::DumpRenderTree):
623         (WebCore::DumpRenderTree::processLine):
624         (WebCore::DumpRenderTree::geolocationPermissionSet):
625         * DumpRenderTree/qt/DumpRenderTreeQt.h:
626         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
627         (LayoutTestController::reset):
628         (LayoutTestController::setGeolocationPermission):
629         (LayoutTestController::setGeolocationPermissionCommon):
630         * DumpRenderTree/qt/LayoutTestControllerQt.h:
631
632 2010-09-01  Andras Becsi  <abecsi@webkit.org>
633
634         Reviewed by Antti Koivisto.
635
636         [Qt] Auto-generate WebKit2 forwarding headers
637         https://bugs.webkit.org/show_bug.cgi?id=44692
638
639         * MiniBrowser/qt/BrowserWindow.h: use source style includes
640         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
641         * Scripts/enumerate-included-framework-headers: Removed.
642
643 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
644
645         Reviewed by Adam Barth.
646
647         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
648         https://bugs.webkit.org/show_bug.cgi?id=44789
649
650         * Scripts/webkitpy/common/net/bugzilla.py:
651
652 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
653
654         Reviewed by Adam Barth.
655
656         ews: Add support for EFL-EWS
657         https://bugs.webkit.org/show_bug.cgi?id=44982
658
659         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
660         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
661         and add it to the ports dict.
662         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
663         EflEWS class.
664         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
665         a test case for the EFL EWS.
666
667 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
668
669         Reviewed by Sam Weinig.
670
671         https://bugs.webkit.org/show_bug.cgi?id=42195
672         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
673
674         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
675         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
676         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
677         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
678         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
679
680         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
681         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
682         which forgets its override.
683
684 2010-08-31  Sam Weinig  <sam@webkit.org>
685
686         Reviewed by Gavin Barraclough.
687
688         WebKitTestRunner needs layoutTestController.addUserStyleSheet
689         https://bugs.webkit.org/show_bug.cgi?id=42680
690
691         WebKitTestRunner needs layoutTestController.addUserScript
692         https://bugs.webkit.org/show_bug.cgi?id=42681
693
694         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
695         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
696         (WTR::InjectedBundle::beginTesting):
697         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
698         (WTR::LayoutTestController::addUserScript):
699         (WTR::LayoutTestController::addUserStyleSheet):
700         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
701
702 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
703
704         Unreviewed, rolling out r66542.
705         http://trac.webkit.org/changeset/66542
706         https://bugs.webkit.org/show_bug.cgi?id=44902
707
708         r66542 - the weird logging dependencies in Python stuck again ...
709
710         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
711         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
712         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
713         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
714         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
715         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
716         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
717         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
718         * Scripts/webkitpy/layout_tests/port/base.py:
719         * Scripts/webkitpy/layout_tests/port/test.py:
720         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
721         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
722
723 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
724
725         Reviewed by Tony Chang.
726
727         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
728
729         * DumpRenderTree/chromium/LayoutTestController.cpp:
730         (LayoutTestController::LayoutTestController):
731         (LayoutTestController::markerTextForListItem):
732         * DumpRenderTree/chromium/LayoutTestController.h:
733
734 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
735
736         Reviewed by Ojan Vafai.
737
738         new-run-webkit-tests: add more unit tests
739
740         Add more unit tests for new-run-webkit-tests; we now cover all but
741         the most obscure code paths in the generic code. We still need to
742         add coverage for the http server and web socket paths, and add better
743         coverage of the platform-specific logic. Note that the rebaselining
744         tool is still not well tested.
745
746         Also clean up some of the configuration logic for the printing
747         module and the way it interacts with the Python logging module; that
748         is a crufty interface, to be certain.
749         
750         https://bugs.webkit.org/show_bug.cgi?id=44902
751
752         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
753         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
754         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
755         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
756         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
757         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
758         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
759         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
760         * Scripts/webkitpy/layout_tests/port/base.py:
761         * Scripts/webkitpy/layout_tests/port/test.py:
762         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
763         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
764
765 2010-08-31  Darin Adler  <darin@apple.com>
766
767         Reviewed by Anders Carlsson.
768
769         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
770         in a debug build when built with certain compilers.
771
772 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
773
774         Reviewed by Gustavo Noronha Silva.
775
776         [GTK] Isolate all GTK+ typedefs into one file
777         https://bugs.webkit.org/show_bug.cgi?id=44900
778
779         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
780
781 2010-08-31  Eric Seidel  <eric@webkit.org>
782
783         Reviewed by Adam Barth.
784
785         Show more status on queue status pages
786         https://bugs.webkit.org/show_bug.cgi?id=44938
787
788         I upped the number of status lines from 6 to 15 --
789         this has been bugging me for a while...
790
791         I also disabled showing the chromium-win EWS queue
792         since it's been down for almost 5 months now.
793
794         * QueueStatusServer/handlers/dashboard.py:
795         * QueueStatusServer/handlers/queuestatus.py:
796         * QueueStatusServer/model/queues.py:
797
798 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
799
800         Reviewed by Antonio Gomes.
801
802         [Qt] Read command line arguments and open them as URLs in new windows
803         https://bugs.webkit.org/show_bug.cgi?id=44944
804
805         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
806
807         * MiniBrowser/qt/main.cpp:
808         (main):
809
810 2010-08-31  Adrian Perez  <aperez@igalia.com>
811
812         Reviewed by Martin Robinson.
813
814         Support scripts to run Buildbot slaves under daemontools (gtk related)
815         https://bugs.webkit.org/show_bug.cgi?id=40053
816
817         * BuildSlaveSupport/gtk: Added.
818         * BuildSlaveSupport/gtk/README: Added.
819         * BuildSlaveSupport/gtk/buildbot: Added.
820         * BuildSlaveSupport/gtk/buildbot/log: Added.
821         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
822         * BuildSlaveSupport/gtk/buildbot/run: Added.
823         * BuildSlaveSupport/gtk/crashmon: Added.
824         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
825         * BuildSlaveSupport/gtk/crashmon/log: Added.
826         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
827         * BuildSlaveSupport/gtk/crashmon/run: Added.
828         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
829         * BuildSlaveSupport/gtk/pulseaudio: Added.
830         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
831         * BuildSlaveSupport/gtk/xvfb: Added.
832         * BuildSlaveSupport/gtk/xvfb/log: Added.
833         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
834         * BuildSlaveSupport/gtk/xvfb/run: Added.
835
836 2010-08-27  John Gregg  <johnnyg@google.com>
837
838         Reviewed by David Levin.
839
840         Notifications should support a click event.
841         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
842         can be simulated during a layout test.  Requires storing a list of active
843         notifications so that they can be referred to later for clicking.
844         https://bugs.webkit.org/show_bug.cgi?id=44800
845
846         * DumpRenderTree/chromium/LayoutTestController.cpp:
847         (LayoutTestController::LayoutTestController):
848         (LayoutTestController::simulateDesktopNotificationClick):
849         * DumpRenderTree/chromium/LayoutTestController.h:
850         * DumpRenderTree/chromium/NotificationPresenter.cpp:
851         (NotificationPresenter::simulateClick):
852         (NotificationPresenter::show):
853         (NotificationPresenter::cancel):
854         (NotificationPresenter::objectDestroyed):
855         * DumpRenderTree/chromium/NotificationPresenter.h:
856
857 2010-08-30  Alice Liu  <alice.liu@apple.com>
858
859         Reviewed by Darin Adler.
860
861         Add missing parts of didFinishDocumentLoadForFrame
862         https://bugs.webkit.org/show_bug.cgi?id=44913
863
864         * MiniBrowser/mac/BrowserWindowController.m:
865         (didFinishDocumentLoadForFrame): Added
866         (-[BrowserWindowController awakeFromNib]): Updated struct
867         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
868         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
869         * WebKitTestRunner/TestController.cpp:
870         (WTR::TestController::initialize): Updated struct
871
872 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
873
874         Unreviewed: Add myself to the list of Committers.
875
876         * Scripts/webkitpy/common/config/committers.py:
877
878 2010-08-30  Kent Tamura  <tkent@chromium.org>
879
880         Reviewed by Adam Barth.
881
882         Fix fast/notifications/notifications-display-close-events.html failure
883         https://bugs.webkit.org/show_bug.cgi?id=44585
884
885         Apply http://crrev.com/48893. We should dispatch display events
886         asynchronously.
887
888         * DumpRenderTree/chromium/NotificationPresenter.cpp:
889         (deferredDisplayDispatch):
890         (NotificationPresenter::show):
891
892 2010-08-30  Robert Hogan  <robert@webkit.org>
893
894         Reviewed by Simon Hausmann.
895
896         allow ports with windowed plugins to support windowless plugin tests
897
898         https://bugs.webkit.org/show_bug.cgi?id=40730
899
900         Ports that implement plugins windowed by default need to have a way of
901         supporting plugin tests that assume the plugin is windowless. Add this
902         feature to the tests and support it in the webkit test plugin. Also
903         add mouse and keyboard event logging to the webkit-test plugin on Unix.
904
905         Unskip the following tests on Qt:
906
907         plugins/mouse-events.html
908         plugins/keyboard-events.html
909         plugins/mouse-events-fixedpos.html
910
911         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
912         (pluginSetProperty):
913         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
914         (NPP_New):
915         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
916         (webkit_test_plugin_handle_event):
917
918 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
919
920         [wx] Build fix after addition of fileapi directory in WebCore.
921
922         * wx/build/settings.py:
923
924 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
925
926         Reviewed by Xan Lopez.
927
928         Fixed compilation error, now that we have included the
929         GtkVersioning.h we have to remove some version dependent code from
930         EventSender.
931
932         * DumpRenderTree/gtk/EventSender.cpp:
933
934 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
935
936         Reviewed by Martin Robinson.
937
938         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
939         are deprecated
940         https://bugs.webkit.org/show_bug.cgi?id=44787
941
942         We have replaced GtkVersioning.cpp with GtkVersioning.c and
943         created a function (getDefaultGDKPointerDevice) to get the pointer
944         of the window with the new APIs. We added that function to DRT and
945         copyandpaste unit test.
946
947         * DumpRenderTree/gtk/EventSender.cpp:
948         (prepareMouseButtonEvent):
949         (mouseMoveToCallback):
950         (keyDownCallback):
951         * GNUmakefile.am:
952
953 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
954
955         Reviewed by Kenneth Rohde Christiansen.
956
957         [Qt] Add new window menu to MiniBrowser
958
959         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
960
961         * MiniBrowser/qt/BrowserWindow.cpp:
962         (BrowserWindow::BrowserWindow):
963         (BrowserWindow::newWindow):
964         * MiniBrowser/qt/BrowserWindow.h:
965         * MiniBrowser/qt/main.cpp:
966         (main):
967
968 2010-08-29  James Robinson  <jamesr@chromium.org>
969
970         Reviewed by David Levin.
971
972         Make failing the download step fail the build
973         https://bugs.webkit.org/show_bug.cgi?id=44298
974
975         If the download step fails on a test bot, this ensures that
976         the build goes red instead of only the download step going red
977         and the overall build staying green.
978
979         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
980
981 2010-08-29  Kent Tamura  <tkent@chromium.org>
982
983         Reviewed by Dimitri Glazkov.
984
985         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
986         https://bugs.webkit.org/show_bug.cgi?id=44847
987
988         * DumpRenderTree/chromium/EventSender.cpp:
989          Use webkit_support::VKEY_* instead of base::VKEY_*.
990
991 2010-08-29  Darin Adler  <darin@apple.com>
992
993         https://bugs.webkit.org/show_bug.cgi?id=40589
994
995         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
996         function names.
997
998 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
999
1000         Reviewed by Darin Adler.
1001
1002         [iExploder] Add new CSS Properties and HTML Attributes
1003         https://bugs.webkit.org/show_bug.cgi?id=44746
1004
1005         Updated the files with the update-iexploder-cssproperties script
1006         and manually readded the -webkit-binding CSS Property to the list.
1007
1008         * iExploder/htdocs/cssproperties.in:
1009         * iExploder/htdocs/htmlattrs.in:
1010         * iExploder/htdocs/htmltags.in:
1011
1012 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1013
1014         Reviewed by Darin Adler.
1015
1016         Fix Coverage build after the addition of ANGLE
1017         https://bugs.webkit.org/show_bug.cgi?id=44744
1018
1019         ANGLE is using libtool to build a static library and the version of
1020         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
1021         parameters. The easiest way to handle this is to not build ANGLE with
1022         coverage information.
1023
1024         This is achieved by applying the XCode options for each project
1025         separately and exclude ANGLE.
1026
1027         * Scripts/build-webkit: Remove -framework AppKit due link errors.
1028         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
1029
1030 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
1031
1032         [wx] Build fix after directory addition.
1033
1034         * wx/build/settings.py:
1035
1036 2010-08-28  Chris Guillory   <chris.guillory@google.com>
1037
1038         Reviewed by Chris Fleizach.
1039
1040         Add AX notification for childrenChanged
1041         https://bugs.webkit.org/show_bug.cgi?id=44472
1042
1043         * DumpRenderTree/chromium/AccessibilityController.cpp:
1044         (AccessibilityController::AccessibilityController):
1045         (AccessibilityController::reset):
1046         (AccessibilityController::getRootElement):
1047         (AccessibilityController::dumpAccessibilityNotifications):
1048         * DumpRenderTree/chromium/AccessibilityController.h:
1049         (AccessibilityController::shouldDumpAccessibilityNotifications):
1050         * DumpRenderTree/chromium/WebViewHost.cpp:
1051         (WebViewHost::didChangeAccessibilityObjectChildren):
1052         * DumpRenderTree/chromium/WebViewHost.h:
1053
1054 2010-08-28  Eric Seidel  <eric@webkit.org>
1055
1056         Reviewed by Adam Barth.
1057
1058         Update commit-queue failure message
1059         https://bugs.webkit.org/show_bug.cgi?id=44798
1060
1061         The commit-queue auto-restarts itself and has for a very long time.
1062         No need for people to email me to request a restart anymore.
1063
1064         * Scripts/webkitpy/common/net/bugzilla.py:
1065         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1066         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1067
1068 2010-07-27  Jer Noble  <jer.noble@apple.com>
1069
1070         Reviewed by Eric Carlson.
1071
1072         Add JavaScript API to allow a page to go fullscreen.
1073         rdar://problem/6867795
1074         
1075         Added basic full screen support to DumpRenderTree: when a webView requests
1076         that DumpRenderTree go "full screen", just call the provided callback listener object's
1077         will/did Enter/Exit full screen methods.  Also, register a new user default which 
1078         enables full screen support.
1079
1080         * DumpRenderTree/mac/DumpRenderTree.mm:
1081         (resetDefaultsToConsistentValues):
1082         * DumpRenderTree/mac/UIDelegate.mm:
1083         (-[UIDelegate webView:supportsFullscreenForElement:]):
1084         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
1085         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
1086
1087 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1088
1089         Unreviewed. Add myself to the committers list.
1090
1091         * Scripts/webkitpy/common/config/committers.py:
1092
1093 2010-08-27  Kent Tamura  <tkent@chromium.org>
1094
1095         Reviewed by Pavel Feldman.
1096
1097         [DRT/Chromium] Fix inspector test failures
1098         https://bugs.webkit.org/show_bug.cgi?id=44748
1099
1100         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1101         (DRTDevToolsAgent::createClientMessageLoop):
1102           Returns a valid WebKitClientMessageLoop instance
1103         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1104
1105 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
1106
1107         Add Windows WebKit2 Tester to buildbot
1108         <rdar://problem/7887703>
1109
1110         Reviewed by Dan Bernstein.
1111
1112         * BuildSlaveSupport/build.webkit.org-config/config.json:
1113
1114 2010-08-26  Philippe Normand  <pnormand@igalia.com>
1115
1116         Reviewed by Martin Robinson.
1117
1118         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1119         https://bugs.webkit.org/show_bug.cgi?id=42152
1120
1121         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1122         (LoadHTMLStringItem::invoke): Implementation using
1123         webkit_web_frame_load_string().
1124
1125 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
1126
1127         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
1128         WebKitTestRunner (44331)
1129
1130         Reviewed by Darin Adler.
1131
1132         * WebKitTestRunner/TestController.cpp:
1133         (WTR::TestController::initialize):
1134         The hang occurs when WebKitTestRunner begins launching the WebKit2
1135         web process then exits before it finishes launching. Work around this by
1136         looking for the --print-supported-features argument and exiting without
1137         creating the web process.
1138
1139 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
1140
1141         Reviewed by Tony Chang.
1142
1143         new-run-webkit-tests: add rebaselining tests for test_expectations
1144         
1145         This patch adds more unit tests for the rebaselining code in the
1146         test_expectations module. It doesn't add any tests for
1147         rebaseline_chromium_webkit_tests itself; that will come some other
1148         time.
1149
1150         https://bugs.webkit.org/show_bug.cgi?id=44648
1151
1152         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1153         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1154
1155 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1156
1157         Reviewed by Martin Robinson.
1158
1159         [GTK] Add HTTP caching support
1160         https://bugs.webkit.org/show_bug.cgi?id=44261
1161
1162         Ignore new soup API that we decided to merge into the soup backend
1163         while it is being cooked. It follows the libsoup style, and will
1164         be removed from WebKit as soon as it is merged into libsoup.
1165
1166         * Scripts/webkitpy/style/checker.py:
1167
1168 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1169
1170         Reviewed by Kenneth Rohde Christiansen.
1171
1172         [Qt] DumpRenderTree runs only one test from command mode
1173         https://bugs.webkit.org/show_bug.cgi?id=44012
1174
1175         Enables support to run multiple test files and single
1176         folder containing html files in stand alone mode
1177
1178         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1179         (WebCore::DumpRenderTree::DumpRenderTree):
1180         (WebCore::DumpRenderTree::processArgsLine):
1181         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1182         (WebCore::DumpRenderTree::processLine):
1183         (WebCore::DumpRenderTree::dump):
1184         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1185         (WebCore::DumpRenderTree::setStandAloneMode):
1186         (WebCore::DumpRenderTree::isStandAloneMode):
1187         * DumpRenderTree/qt/main.cpp:
1188         (main):
1189
1190 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1191
1192         Updating webkitpy test expectations.
1193
1194         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1195
1196 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1197
1198         Reviewed by Eric Seidel.
1199
1200         fix the always squash git config
1201         https://bugs.webkit.org/show_bug.cgi?id=44651
1202
1203         Fix help text and apparently underscores are not allowed
1204         in git config keys.
1205
1206         * Scripts/webkitpy/common/checkout/scm.py:
1207         * Scripts/webkitpy/tool/steps/commit.py:
1208
1209 2010-08-25  Darin Adler  <darin@apple.com>
1210
1211         Reviewed by John Sullivan.
1212
1213         * Scripts/commit-log-editor: Fix perl warning for people who have no
1214         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
1215
1216 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1217
1218         Reviewed by Eric Seidel.
1219
1220         stop blocking commits when the bots are red
1221         https://bugs.webkit.org/show_bug.cgi?id=44644
1222
1223         This check currently is just annoying. It doesn't actually
1224         help keep the tree green. We can always add it back later
1225         if we decide the tree is generally more green.
1226
1227         * Scripts/webkitpy/tool/commands/download_unittest.py:
1228         * Scripts/webkitpy/tool/mocktool.py:
1229         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1230
1231 2010-08-25  Eric Seidel  <eric@webkit.org>
1232
1233         Reviewed by Simon Fraser.
1234
1235         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
1236         https://bugs.webkit.org/show_bug.cgi?id=38912
1237
1238         I know of nothing else to do but skip all media tests for the cq.
1239
1240         * Scripts/webkitpy/tool/steps/runtests.py:
1241
1242 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1243
1244         Reviewed by Ojan Vafai.
1245
1246         new-run-webkit-tests: add more unit tests for test_expectations
1247         This adds unit tests to cover (almost?) all of the non-rebaselining
1248         functionality.
1249
1250         https://bugs.webkit.org/show_bug.cgi?id=44579
1251
1252         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1253         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1254
1255 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1256
1257         Reviewed by Ojan Vafai.
1258
1259         new-run-webkit-tests: add more unit tests
1260
1261         This change adds more unit tests for the image_diff, test_failures,
1262         and test_files modules, bringing them to 100% coverage (and adds a
1263         couple tests to run_webkit_tests while we're at it).
1264
1265         This test also turns on the "dryrun" port for testing when run on
1266         the mac, increasing coverage in a few other places.
1267
1268         https://bugs.webkit.org/show_bug.cgi?id=44578
1269
1270         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
1271         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
1272         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
1273         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
1274         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
1275         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
1276         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
1277         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
1278         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1279         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
1280         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1281         * Scripts/webkitpy/layout_tests/port/test.py:
1282         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1283
1284 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1285
1286         Reviewed by Ojan Vafai.
1287
1288         new-run-webkit-tests: add more unit tests for layout_package/printing.py
1289
1290         This change adds more unit tests to get the test coverage to 100%
1291         for the printing module. This code is actually pretty crufty and
1292         has some layering violations that need to be cleaned up but I'll
1293         save that for another CL after we get all the unit tests written and
1294         we fix the multithreading issues. At least now we'll be able to tell
1295         if we break things.
1296
1297         https://bugs.webkit.org/show_bug.cgi?id=44576
1298
1299         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1300         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1301
1302 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1303
1304         Reviewed by Adam Barth.
1305
1306         new-run-webkit-tests should respect set-webkit-configuration
1307         https://bugs.webkit.org/show_bug.cgi?id=44633
1308
1309         Moves the getting of the configuration into the base Port so that
1310         chromium ports use it as well. In the downstream chromium port,
1311         this should still just return Release.
1312
1313         * Scripts/webkitpy/layout_tests/port/base.py:
1314         * Scripts/webkitpy/layout_tests/port/webkit.py:
1315
1316 2010-08-25  Tony Chang  <tony@chromium.org>
1317
1318         Not reviewed, changing svn props for a script.
1319
1320         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
1321
1322 2010-08-25  Adam Barth  <abarth@webkit.org>
1323
1324         Reviewed by Eric Seidel.
1325
1326         Remove WebKit2 from core builders
1327         https://bugs.webkit.org/show_bug.cgi?id=44625
1328
1329         This builder was added to the core builders by accident.  It doesn't
1330         appear to be green enough to be a core builder yet.
1331
1332         * Scripts/webkitpy/common/net/buildbot.py:
1333         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1334
1335 2010-08-19  Adam Roben  <aroben@apple.com>
1336
1337         Test that NP_Initialize and NP_GetEntryPoints are called in the
1338         correct order
1339
1340         The order differs between Mac and Windows (see r38858).
1341
1342         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1343         NP_Initialize when loading QuickTime when running
1344         plugins/embed-attributes-setting.html in WebKit2 on Windows
1345
1346         Reviewed by John Sullivan.
1347
1348         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1349         a boolean to record whether NP_GetEntryPoints has been called.
1350         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1351         called yet. This matches Flash and QuickTime's behavior.
1352         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
1353         yet. This matches Silverlight's behavior.
1354
1355 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1356
1357         Reviewed by Gustavo Noronha Silva.
1358
1359         Cairo and EFL port shouldn't depend on glib.
1360         https://bugs.webkit.org/show_bug.cgi?id=44354
1361
1362         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
1363         adoptPlatformRef.
1364
1365         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1366         (AccessibilityUIElement::isSelected):
1367
1368 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1369
1370         Fix order of Timothy's email address. The script, and
1371         other tools all assume that the first email is the bugzilla address.
1372
1373         * Scripts/webkitpy/common/config/committers.py:
1374
1375 2010-08-24  Kent Tamura  <tkent@chromium.org>
1376
1377         Reviewed by Pavel Feldman.
1378
1379         [DRT/Chromium] Fix 26 inspector test crashes
1380         https://bugs.webkit.org/show_bug.cgi?id=44580
1381
1382         - DRTDevToolsAgent has a reference to the main WebView. So we
1383           should not clear it in closeDevTools() and should clear it in
1384           ~TestShell().
1385         - DRTDevToolsClient has a reference to a DevTools WebView and no
1386           way to update it. So we should delete DRTDevToolsClient instances
1387           in closeDevTools().
1388
1389         * DumpRenderTree/chromium/TestShell.cpp:
1390         (TestShell::~TestShell):
1391         (TestShell::closeDevTools):
1392
1393 2010-08-24  Eric Seidel  <eric@webkit.org>
1394
1395         Reviewed by Adam Barth.
1396
1397         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
1398         https://bugs.webkit.org/show_bug.cgi?id=44584
1399
1400         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1401
1402 2010-08-24  Eric Seidel  <eric@webkit.org>
1403
1404         Reviewed by Adam Barth.
1405
1406         commit-queue and EWS bots should report all failures
1407         https://bugs.webkit.org/show_bug.cgi?id=41820
1408
1409         Right now commit-queue/EWS only report failures when the
1410         patch under testing fails.  We should report all failures
1411         to the status server so that we can diagnose when the bots
1412         are wedged w/o needing to log into the machines.
1413
1414         I also reduced the amount of data we upload since we've seen
1415         timeouts during status upload.
1416
1417         * Scripts/webkitpy/common/system/executive.py:
1418         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1419         * Scripts/webkitpy/tool/commands/queues.py:
1420         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1421
1422 2010-08-24  Eric Seidel  <eric@webkit.org>
1423
1424         Reviewed by Adam Barth.
1425
1426         Remove HTML5 parser testing infrastructure now that we don't need it
1427         https://bugs.webkit.org/show_bug.cgi?id=44581
1428
1429         * DumpRenderTree/mac/DumpRenderTree.mm:
1430         (resetDefaultsToConsistentValues):
1431         (initializeGlobalsFromCommandLineOptions):
1432         * Scripts/old-run-webkit-tests:
1433         * Scripts/test-html5-parser: Removed.
1434
1435 2010-08-24  Kent Tamura  <tkent@chromium.org>
1436
1437         Reviewed by Dimitri Glazkov.
1438
1439         [DRT/Chromium] Fix 28 inspector test crashes
1440         https://bugs.webkit.org/show_bug.cgi?id=44574
1441
1442         Reset DevToolsClient and DevToolsAgent before closing a DevTools
1443         WebView in order to avoid accessing to a deleted WebView instance.
1444
1445         * DumpRenderTree/chromium/TestShell.cpp:
1446         (TestShell::closeDevTools):
1447
1448 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1449
1450         Reviewed by Ojan Vafai.
1451
1452         new-run-webkit-tests: clean up code for test_types, test_failures
1453
1454         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
1455         webkitpy.layout_tests.layout_package.test_failures, and remove
1456         some dead code and otherwise clean up things.
1457
1458         https://bugs.webkit.org/show_bug.cgi?id=44559
1459
1460         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1461         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
1462         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1463         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1464         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1465         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
1466         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1467
1468 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1469
1470         Reviewed by Eric Seidel.
1471
1472         new-run-webkit-tests: revise unit testing strategy for test failures
1473     
1474         This change revamps the way we store test data for new-run-webkit-tests.
1475         Previously we had a few copies of test files from the main test tree.
1476         Now we have a bunch of completely fake test data and use the test
1477         data to generate different kinds of test failures, getting
1478         much better coverage.
1479
1480         https://bugs.webkit.org/show_bug.cgi?id=44556
1481
1482         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
1483         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
1484         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
1485         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
1486         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
1487         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
1488         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
1489         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
1490         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
1491         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
1492         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
1493         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
1494         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
1495         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
1496         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
1497         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
1498         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
1499         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
1500         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
1501         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
1502         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
1503         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
1504         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
1505         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
1506         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
1507         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
1508         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
1509         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
1510         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
1511         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
1512         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
1513         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
1514         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
1515         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
1516         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
1517         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
1518         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
1519         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
1520         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
1521         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
1522         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
1523         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
1524         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
1525         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1526         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
1527         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
1528         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1529         * Scripts/webkitpy/layout_tests/port/test.py:
1530         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1531         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1532
1533 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1534
1535         Reviewed by Eric Seidel.
1536
1537         speed up new-run-webkit-tests unit tests
1538
1539         Add a --no-record-results flag that turns off generating the JSON
1540         results file on every test run. Generating the file requires us to
1541         fetch the old results down from the bots, which can be slow. This
1542         flag is off by default.
1543     
1544         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
1545     
1546         These changes together shorten the test cycle from ~4.5s to ~1.5s
1547         - a 3x speedup.
1548
1549         https://bugs.webkit.org/show_bug.cgi?id=44553
1550
1551         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1552         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1553
1554 2010-08-24  Tony Chang  <tony@chromium.org>
1555
1556         Reviewed by Eric Seidel.
1557
1558         [chromium] fix the platform result fallback order on mac/win
1559         https://bugs.webkit.org/show_bug.cgi?id=44483
1560
1561         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1562
1563 2010-08-24  Xan Lopez  <xlopez@igalia.com>
1564
1565         Reviewed by Martin Robinson.
1566
1567         Set a device to the event struct when building with GTK+ 3.x, it's
1568         mandatory.
1569
1570         * DumpRenderTree/gtk/EventSender.cpp:
1571         (keyDownCallback):
1572
1573 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1574
1575         Reviewed by Xan Lopez.
1576
1577         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1578         https://bugs.webkit.org/show_bug.cgi?id=44534
1579
1580         Fix two double-frees introduced in my previous commit.
1581
1582         * DumpRenderTree/gtk/EventSender.cpp:
1583         (contextClickCallback): Copy the event before using it again.
1584         (keyDownCallback): Ditto.
1585
1586 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1587
1588         Reviewed by Xan Lopez.
1589
1590         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1591         https://bugs.webkit.org/show_bug.cgi?id=44534
1592
1593         * DumpRenderTree/gtk/EventSender.cpp:
1594         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
1595         when setting it on the event. It is dereferenced by gdk_event_free(...).
1596         (contextClickCallback): Ditto.
1597         (mouseDownCallback): Ditto.
1598         (mouseUpCallback): Ditto.
1599         (mouseMoveToCallback): Ditto.
1600         (mouseWheelToCallback): Ditto.
1601         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
1602         (dispatchEvent): Ditto. Also free the event when we are done with it.
1603         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
1604
1605 2010-08-24  Andras Becsi  <abecsi@webkit.org>
1606
1607         [Qt] WebKit2 build fix.
1608
1609         * Scripts/enumerate-included-framework-headers:
1610         Remove stray global option form sed.
1611
1612 2010-08-24  Kent Tamura  <tkent@chromium.org>
1613
1614         Reviewed by Jeremy Orlow.
1615
1616         [DRT/Chromium] Support for IndexedDB tests
1617         https://bugs.webkit.org/show_bug.cgi?id=44490
1618
1619         * DumpRenderTree/chromium/TestShell.cpp:
1620         (TestShell::TestShell): Enable IndexedDB.
1621
1622 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
1623
1624         Reviewed by Gustavo Noronha Silva.
1625
1626         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
1627         https://bugs.webkit.org/show_bug.cgi?id=44465
1628
1629         Initialize the axes field of mouse button and motion events to null.
1630         This is the value that should be used for events originating from the
1631         mouse device.
1632
1633         * DumpRenderTree/gtk/EventSender.cpp:
1634         (prepareMouseButtonEvent): Initalize button event axes field to null.
1635         (mouseMoveToCallback): Initialize motion event axes field to null.
1636
1637 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1638
1639         Unreviewed, rolling out r65703.
1640         http://trac.webkit.org/changeset/65703
1641         https://bugs.webkit.org/show_bug.cgi?id=44460
1642
1643         "Causing lots of crashes on Snow Leopard when running the
1644         layout tests" (Requested by eseidel2 on #webkit).
1645
1646         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1647         (NP_Initialize):
1648         (NP_GetEntryPoints):
1649
1650 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
1651
1652         Layout tests do not run when using WebKitTestRunner in a Debug build.
1653         https://bugs.webkit.org/show_bug.cgi?id=44409
1654
1655         Reviewed by Dan Bernstein.
1656
1657         * WebKitTestRunner/win/TestControllerWin.cpp:
1658         (WTR::TestController::initializeInjectedBundlePath):
1659         Use InjectedBundle_debug.dll when building Debug.
1660
1661 2010-08-23  Xan Lopez  <xlopez@igalia.com>
1662
1663         Reviewed by Martin Robinson.
1664
1665         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
1666         https://bugs.webkit.org/show_bug.cgi?id=42026
1667
1668         If a GTK+ 3.x build is present return that as the library to use,
1669         otherwise fallback to the GTK+ 2.x build.
1670
1671         * Scripts/webkitdirs.pm:
1672
1673 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
1674
1675         Reviewed by Ariya Hidayat.
1676
1677         [Qt] Find needed forwarding headers for WebKit2 automatically
1678         https://bugs.webkit.org/show_bug.cgi?id=44336
1679
1680         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
1681         The new script does not satisfy the needs of this file however using normal includes
1682         is generally better here.
1683         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
1684         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
1685         given frameworks by files in the current directory (and subdirectories).
1686         In the future this needs to be rewritten in perl for being able to use on Windows.
1687
1688 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
1689
1690         Reviewed by Ariya Hidayat.
1691
1692         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
1693         https://bugs.webkit.org/show_bug.cgi?id=43010
1694
1695         * QtTestBrowser/launcherwindow.cpp:
1696         (LauncherWindow::applyPrefs):
1697         * QtTestBrowser/main.cpp:
1698         (LauncherApplication::handleUserOptions):
1699
1700 2010-08-21  Sam Weinig  <sam@webkit.org>
1701
1702         Reviewed by Dan Bernstein.
1703
1704         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
1705         https://bugs.webkit.org/show_bug.cgi?id=44386
1706
1707         * MiniBrowser/mac/AppDelegate.m:
1708         (didRecieveMessageFromInjectedBundle):
1709         (didNavigateWithNavigationData):
1710         (-[BrowserAppDelegate init]):
1711         (-[BrowserAppDelegate applicationWillTerminate:]):
1712         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1713         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1714         (-[BrowserStatisticsWindowController dealloc]):
1715         * MiniBrowser/mac/BrowserWindowController.m:
1716         (-[BrowserWindowController initWithPageNamespace:]):
1717         (-[BrowserWindowController fetch:]):
1718         (-[BrowserWindowController windowWillClose:]):
1719         (-[BrowserWindowController applicationTerminating]):
1720         (closePage):
1721         (runJavaScriptAlert):
1722         (runJavaScriptConfirm):
1723         (runJavaScriptPrompt):
1724         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1725         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1726         (didClearWindowObjectForFrame):
1727         * MiniBrowser/win/BrowserView.cpp:
1728         (BrowserView::goToURL):
1729         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1730         (WTR::PlatformWebView::~PlatformWebView):
1731
1732 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
1733
1734         Reviewed by Kenneth Rohde Christiansen.
1735
1736         WebKit does not build with Python 2.3
1737         https://bugs.webkit.org/show_bug.cgi?id=44373
1738
1739         Replaced the function sorted() by a call to sort()
1740         on the entry list.
1741         The function sorted() has been added to Python 2.4.
1742         The function method sort() of List works with older
1743         versions of Python.
1744
1745         * Scripts/create-html-entity-table:
1746
1747 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
1748
1749         Reviewed by Pavel Feldman.
1750
1751         Web Inspector: Inspector tests were disabled for GTK.
1752         https://bugs.webkit.org/show_bug.cgi?id=43977
1753
1754         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
1755         path before running tests.
1756
1757 2010-08-20  Daniel Bates  <dbates@rim.com>
1758
1759         Reviewed by Eric Seidel.
1760
1761         svn-apply doesn't detect empty line with Windows line endings
1762         after property value
1763         https://bugs.webkit.org/show_bug.cgi?id=43981
1764
1765         Part 2 of 2
1766
1767         Add unit tests that were not landed in the first commit.
1768
1769         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1770           - Added the following test cases:
1771             "SVN: binary file (isBinary true) using Windows line endings"
1772             "SVN: property diff, followed by file change diff using Windows line endings"
1773             "SVN: two consecutive property diffs using Windows line endings"
1774             "SVN: binary file with executable bit change usng Windows line endings"
1775             "SVN: binary file followed by property change on different file using Windows line endings"
1776             "SVN: binary file followed by file change on different file using Windows line endings"
1777             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1778             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1779         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1780           - Added the following test cases:
1781             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1782             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1783             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1784             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1785             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1786             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1787             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1788             "single-line '+' with trailing new line using Windows line endings"
1789             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1790             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1791             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1792         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1793           - Added the following test cases:
1794             "single-line '-' change followed by empty line with Windows line endings"
1795             "multi-line '+' change and start of binary patch with Windows line endings"
1796
1797 2010-08-20  Daniel Bates  <dbates@rim.com>
1798
1799         Reviewed by Eric Seidel.
1800
1801         svn-apply doesn't detect empty line with Windows line endings
1802         after property value
1803         https://bugs.webkit.org/show_bug.cgi?id=43981
1804
1805         Fixes an issue where an empty line following the property value
1806         in an SVN property change diff would not be detected if it had
1807         Windows line endings (i.e. ended in CRLF). Hence it was consumed
1808         as if it was part of a multi-line property value. 
1809
1810         * Scripts/VCSUtils.pm:
1811           - Modified parseSvnPropertyValue() to detect empty line
1812             with Windows line endings.
1813           - Added toWindowsLineEndings().
1814         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1815           - Added the following test cases:
1816             "SVN: binary file (isBinary true) using Windows line endings"
1817             "SVN: property diff, followed by file change diff using Windows line endings"
1818             "SVN: two consecutive property diffs using Windows line endings"
1819             "SVN: binary file with executable bit change usng Windows line endings"
1820             "SVN: binary file followed by property change on different file using Windows line endings"
1821             "SVN: binary file followed by file change on different file using Windows line endings"
1822             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1823             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1824         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1825           - Added the following test cases:
1826             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1827             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1828             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1829             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1830             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1831             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1832             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1833             "single-line '+' with trailing new line using Windows line endings"
1834             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1835             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1836             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1837         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1838           - Added the following test cases:
1839             "single-line '-' change followed by empty line with Windows line endings"
1840             "multi-line '+' change and start of binary patch with Windows line endings"
1841
1842 2010-08-19  David Kilzer  <ddkilzer@apple.com>
1843
1844         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
1845
1846         * MiniBrowser/mac/BrowserWindowController.m:
1847         (decidePolicyForNavigationAction): Updated method signature.
1848         (decidePolicyForNewWindowAction): Updated method signature.
1849
1850 2010-08-19  Adam Roben  <aroben@apple.com>
1851
1852         Test that NP_Initialize and NP_GetEntryPoints are called in the
1853         correct order
1854
1855         The order differs between Mac and Windows (see r38858).
1856
1857         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1858         NP_Initialize when loading QuickTime when running
1859         plugins/embed-attributes-setting.html in WebKit2 on Windows
1860
1861         Reviewed by Sam Weinig.
1862
1863         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1864         a boolean to record whether NP_GetEntryPoints has been called.
1865         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1866         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
1867         if NP_GetEntryPoints has been called already. This matches
1868         Silverlight's behavior.
1869
1870 2010-08-19  Adam Roben  <aroben@apple.com>
1871
1872         Make build-webkittestrunner build TestNetscapePlugIn on Windows
1873
1874         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
1875
1876         Reviewed by Sam Weinig.
1877
1878         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
1879         Threaded it in between ImageDiff and InjectedBundleGenerated.
1880
1881 2010-08-19  Ojan Vafai  <ojan@chromium.org>
1882
1883         Reviewed by Adam Barth.
1884
1885         install rietveld's upload script from a versioned url
1886         https://bugs.webkit.org/show_bug.cgi?id=44291
1887
1888         autoinstall expects the file at a given URL to never change.
1889         In order to be able to update the file, we need to be able to
1890         change the path.
1891
1892         * Scripts/webkitpy/thirdparty/__init__.py:
1893
1894 2010-08-19  Ojan Vafai  <ojan@chromium.org>
1895
1896         Reviewed by Adam Barth.
1897
1898         add --webkit_patch_id to reitveld uploads
1899         https://bugs.webkit.org/show_bug.cgi?id=44289
1900
1901         This is the first step in having rietveld store which
1902         patches have been uploaded and getting rid of the
1903         in-rietveld flag.
1904
1905         * Scripts/webkitpy/common/net/rietveld.py:
1906         * Scripts/webkitpy/tool/mocktool.py:
1907         * Scripts/webkitpy/tool/steps/postcodereview.py:
1908
1909 2010-08-19  Kenneth Russell  <kbr@google.com>
1910
1911         Reviewed by David Levin.
1912
1913         Adjust my status from committer to reviewer
1914         https://bugs.webkit.org/show_bug.cgi?id=44277
1915
1916         * Scripts/webkitpy/common/config/committers.py:
1917
1918 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
1919
1920         Reviewed by Yury Semikhatsky.
1921
1922         Chromium DevTools: remove injected script fetcher from test harness.
1923         https://bugs.webkit.org/show_bug.cgi?id=44266
1924
1925         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1926         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1927
1928 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
1929
1930         Reviewed by Yury Semikhatsky.
1931
1932         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
1933         Now that we populate front-end after its onload handler, we don't need
1934         to install injected script early. Exposing injected script source on the WebCore
1935         level here.
1936         https://bugs.webkit.org/show_bug.cgi?id=44029
1937
1938         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1939         (DRTDevToolsAgent::runtimePropertyChanged):
1940         (DRTDevToolsAgent::delayedFrontendLoaded):
1941         (DRTDevToolsAgent::frontendLoaded):
1942         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1943
1944 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1945
1946         Reviewed by Kenneth Rohde Christiansen.
1947
1948         [Gtk] Enable view mode media feature layout test
1949         https://bugs.webkit.org/show_bug.cgi?id=43278
1950
1951         Add view mode media feature testing infrastructure, and add
1952         placeholder methods for the other platforms'
1953         LayoutTestControllers.
1954
1955         * DumpRenderTree/LayoutTestController.cpp:
1956         (setViewModeMediaFeatureCallback):
1957         (LayoutTestController::staticFunctions):
1958         * DumpRenderTree/LayoutTestController.h:
1959         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1960         (LayoutTestController::setViewModeMediaFeature):
1961         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1962         (LayoutTestController::setViewModeMediaFeature):
1963         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1964         (LayoutTestController::setViewModeMediaFeature):
1965         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1966         (LayoutTestController::setViewModeMediaFeature):
1967
1968 2010-08-18  Mark Rowe  <mrowe@apple.com>
1969
1970         Reviewed by Sam Weinig.
1971
1972         Make it so the WebKit2 test slave runs the WebKit2 tests
1973
1974         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1975
1976 2010-08-18  Sam Weinig  <sam@webkit.org>
1977
1978         Reviewed by Mark Rowe.
1979
1980         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
1981         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
1982         module and the TestNetscapePlugin.
1983
1984         * Scripts/old-run-webkit-tests:
1985
1986 2010-08-18  Adam Roben  <aroben@apple.com>
1987
1988         Fix hang when saving crash logs on Windows
1989
1990         * Scripts/old-run-webkit-tests:
1991         (setUpWindowsCrashLogSaving):
1992         (END):
1993         Pass -s to regtool so it will write the Auto value as a string instead
1994         of as a number. This was causing a "do you want to debug?" dialog to
1995         appear.
1996
1997 2010-08-17  Victor Wang  <victorw@chromium.org>
1998
1999         Unreviewed. Fixed chromium incremental test json upload.
2000         Quote builder name and test results server in url.
2001
2002         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2003
2004 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2005
2006         Reviewed by Ariya Hidayat.
2007
2008         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
2009         https://bugs.webkit.org/show_bug.cgi?id=44124
2010
2011         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
2012         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
2013         Symbian dependencies.
2014
2015         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2016         (WebCore::DumpRenderTree::open):
2017         * QtTestBrowser/launcherwindow.cpp:
2018         (LauncherWindow::init):
2019         (LauncherWindow::toggleFullScreenMode):
2020         (LauncherWindow::showFPS):
2021         (LauncherWindow::updateFPS):
2022         * QtTestBrowser/launcherwindow.h:
2023         (WindowOptions::WindowOptions):
2024         * QtTestBrowser/mainwindow.cpp:
2025         (MainWindow::buildUI):
2026
2027 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2028
2029         Reviewed by David Levin.
2030
2031         new-run-webkit-tests: remove --show-sources option
2032
2033         --show-sources is pretty much obsolete with --trace everything, so
2034         I'm removing it.
2035
2036         Also rename a couple of methods in the TestTextDiff class to make their
2037         intended visibility (private) more obvious.
2038
2039         https://bugs.webkit.org/show_bug.cgi?id=44143
2040
2041         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2042         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2043         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2044         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2045         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2046
2047 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2048
2049         Reviewed by David Levin.
2050
2051         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
2052
2053         This code bit-rotted at some point more than a year ago, and nobody seems
2054         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
2055         should support instead, making this flag unnecessary anyway.
2056
2057         https://bugs.webkit.org/show_bug.cgi?id=44141
2058
2059         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2060         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2061         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
2062
2063 2010-08-17  Victor Wang  <victorw@chromium.org>
2064
2065         Reviewed by Ojan Vafai.
2066
2067         Update json results generator to have incremental json including
2068         results for tests that pass in current run but failed before.
2069
2070         https://bugs.webkit.org/show_bug.cgi?id=44119
2071
2072         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2073         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2074         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2075
2076 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2077
2078         Reviewed by Eric Seidel.
2079
2080         fix test-webkitpy, add easy way to find a checkout root
2081
2082         test-webkitpy currently doesn't work right if run from someplace other
2083         than the checkout root, and it spews a bunch of debug logging because
2084         the deduplicate_tests tests contaminates the test environment.
2085
2086         This patch cleans up the deduplicate_tests unit tests, and creates
2087         two new methods in scm.py: find_checkout_root() and default_scm(),
2088         both of which use a single algorithm for guessing what checkout root
2089         to use if you aren't explicitly told one from a path.
2090
2091         https://bugs.webkit.org/show_bug.cgi?id=44001
2092
2093         * Scripts/deduplicate-tests:
2094         * Scripts/webkitpy/common/checkout/scm.py:
2095         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2096         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2097         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2098         * Scripts/webkitpy/layout_tests/port/test.py:
2099         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2100         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2101         * Scripts/webkitpy/tool/main.py:
2102
2103 2010-08-17  Victor Wang  <victorw@chromium.org>
2104
2105         Reviewed by Ojan Vafai.
2106
2107         Add support to the test results server for downloading json that
2108         contains test list only.
2109
2110         This is for json results generator to generate incremental json
2111         results so that it includes results not only for tests failed in
2112         current run, but also tests failed before.
2113
2114         Also set the results type to "N" (no data) instead of "P" (pass)
2115         if test results cannot be found in incremental json file.
2116
2117         https://bugs.webkit.org/show_bug.cgi?id=44117
2118
2119         * TestResultServer/handlers/testfilehandler.py:
2120         * TestResultServer/model/jsonresults.py:
2121         * TestResultServer/model/jsonresults_unittest.py:
2122
2123 2010-08-17  Adam Roben  <aroben@apple.com>
2124
2125         Use the right path style
2126
2127         * Scripts/old-run-webkit-tests:
2128
2129 2010-08-17  Adam Roben  <aroben@apple.com>
2130
2131         Fix typo
2132
2133         * Scripts/old-run-webkit-tests:
2134
2135 2010-08-17  Adam Roben  <aroben@apple.com>
2136
2137         Don't hang when running run-webkit-tests as a non-Administrator on
2138         Vista/7
2139
2140         * Scripts/old-run-webkit-tests:
2141         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
2142         post-mortem debugger, rather than using NTSD itself. The latter waits
2143         for user input when it fails to set the registry values; the former
2144         does not.
2145
2146 2010-08-17  Adam Roben  <aroben@apple.com>
2147
2148         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
2149         save crash logs on Windows
2150
2151         The crash logs are saved to /tmp/layout-test-results and have names
2152         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
2153
2154         Unfortunately, crashes in the WebKit2 web process are recorded as
2155         time-outs by run-webkit-tests. Fixing this is covered by
2156         <http://webkit.org/b/44121>.
2157
2158         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
2159         DumpRenderTree should save a stack trace and/or dump file when it
2160         crashes
2161
2162         Reviewed by Sam Weinig.
2163
2164         * DumpRenderTree/win/DumpRenderTree.cpp:
2165         (exceptionFilter):
2166         (main):
2167         * WebKitTestRunner/win/TestControllerWin.cpp:
2168         (WTR::exceptionFilter):
2169         (WTR::TestController::platformInitialize):
2170         These changes set up an exception filter that prints #CRASHED to
2171         stderr, then lets the exception propagate normally. This allows
2172         run-webkit-tests to detect when we've crashed even when a post-mortem
2173         debugger attaches to the process.
2174
2175         * Scripts/old-run-webkit-tests:
2176         (top level): Declared some variables used by the crash-log-saving
2177         code.
2178         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
2179         that the post-mortem debugger has access to it.
2180         (toCygwinPath): Added. This is the opposite of toWindowsPath.
2181         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
2182         stderr, consider it a crash.
2183         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
2184         debugger, then sets ntsd as the post-mortem debugger. ntsd is
2185         configured to save a crash log and then quit automatically.
2186         (END): Added. Restores the previous post-mortem debugger when the
2187         script exits.
2188
2189 2010-08-17  Victor Wang  <victorw@chromium.org>
2190
2191         Reviewed by ojan@chromium.org.
2192
2193         Update test results server:
2194         1. Normalize test results and times after merging (prune tests where
2195            all runs pass or do not have data, truncate all test items to max
2196            number of builds)
2197         2. times should be int not string.
2198         3. when inserting a new test item, should keep old data regardless
2199            whether or not they have same item type with new one.
2200
2201         https://bugs.webkit.org/show_bug.cgi?id=43861
2202
2203         * TestResultServer/model/jsonresults.py:
2204         * TestResultServer/model/jsonresults_unittest.py:
2205
2206 2010-08-16  Sam Weinig  <sam@webkit.org>
2207
2208         Reviewed by Mark Rowe.
2209
2210         Add WebKit2 Mac tester to buildbot.
2211
2212         * BuildSlaveSupport/build.webkit.org-config/config.json:
2213         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2214
2215 2010-08-16  Paul Sawaya  <psawaya@apple.com>
2216
2217         Reviewed by Chris Marrin.
2218
2219         Added shader validation via ANGLE
2220         https://bugs.webkit.org/show_bug.cgi?id=42405
2221
2222         Added ANGLE to webkit build
2223
2224         * Scripts/build-webkit:
2225
2226 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
2227
2228         [wx] Build fix, do not build WebCore as a convenience library as this leads to
2229         errors in the Win build w/export symbols and causes problems with DOM bindings
2230         debugging in gdb.
2231
2232         * DumpRenderTree/wscript:
2233         * Scripts/build-webkit:
2234         * wx/browser/wscript:
2235         * wx/build/settings.py:
2236         * wx/build/waf_extensions.py:
2237
2238 2010-08-16  Dan Bernstein  <mitz@apple.com>
2239
2240         Build fix.
2241
2242         * WebKitTestRunner/TestController.cpp:
2243         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
2244         (WTR::TestController::initialize): Ditto.
2245
2246 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2247
2248         Reviewed by Kenneth Rohde Christiansen.
2249
2250         Handle content size change in WebKit2
2251         Re-landing after fix.
2252
2253         https://bugs.webkit.org/show_bug.cgi?id=43198
2254
2255         * MiniBrowser/mac/BrowserWindowController.m:
2256         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2257         * MiniBrowser/win/BrowserView.cpp:
2258         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2259
2260 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2261
2262         Unreviewed, rolling out r65419.
2263         http://trac.webkit.org/changeset/65419
2264         https://bugs.webkit.org/show_bug.cgi?id=44053
2265
2266         Broke the Windows build (Requested by bbandix on #webkit).
2267
2268         * MiniBrowser/mac/BrowserWindowController.m:
2269         (-[BrowserWindowController awakeFromNib]):
2270         * MiniBrowser/win/BrowserView.cpp:
2271         (BrowserView::create):
2272
2273 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2274
2275         Reviewed by Kenneth Rohde Christiansen.
2276
2277         Handle content size change in WebKit2
2278
2279         https://bugs.webkit.org/show_bug.cgi?id=43198
2280
2281         * MiniBrowser/mac/BrowserWindowController.m:
2282         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2283         * MiniBrowser/win/BrowserView.cpp:
2284         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2285
2286 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
2287
2288         Add my new email address to committers.py.
2289
2290         * Scripts/webkitpy/common/config/committers.py:
2291
2292 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
2293
2294         Add my old e-mail addresses to committers.py.
2295
2296         * Scripts/webkitpy/common/config/committers.py:
2297
2298 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2299
2300         WebEditorClient::didBeginEditing is never called in WebKit2
2301         https://bugs.webkit.org/show_bug.cgi?id=42939
2302
2303         Reviewed by Sam Weinig.
2304
2305         * WebKitTestRunner/PlatformWebView.h:
2306         Declare focus().
2307
2308         * WebKitTestRunner/TestController.cpp:
2309         (WTR::TestController::resetStateToConsistentValues):
2310         Focus the PlatformWebView.
2311
2312         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2313         (WTR::PlatformWebView::focus):
2314         Stubbed.
2315
2316         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2317         (WTR::PlatformWebView::focus):
2318         Focus the view.
2319
2320 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2321
2322         run-webkit-tests should not strip editing callbacks when using
2323         WebKitTestRunner on Windows
2324         https://bugs.webkit.org/show_bug.cgi?id=44000
2325
2326         Reviewed by Mark Rowe.
2327
2328         * Scripts/old-run-webkit-tests:
2329         Leave $stripEditingCallbacks undefined until we look for command-line
2330         arguments. If using WebKit2, set it to 0 if not explicity set on the
2331         command line. Later, set it to isCygwin() to match old behavior if it is
2332         not yet defined.
2333
2334 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
2335
2336         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
2337
2338         * wx/build/settings.py:
2339
2340 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
2341
2342         Reviewed by Kenneth Rohde Christiansen.
2343
2344         [GTK] autogen.sh not executed if build-webkit options change
2345         https://bugs.webkit.org/show_bug.cgi?id=42266
2346
2347         Rerun autogen.sh in situations where the arguments to build-webkit have
2348         changed since the previous build. This will fix some issues on the bots
2349         where the build does not notice changes to default build-webkit arguments.
2350
2351         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
2352
2353 2010-08-14  Eric Seidel  <eric@webkit.org>
2354
2355         Unreviewed.  Another fix to support python 2.3.
2356
2357         Add support for MathML entities
2358         https://bugs.webkit.org/show_bug.cgi?id=43949
2359
2360         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
2361          - It looks like our simplejson is version 1.7.3 which
2362            should be python 2.3 compatible.  But someone modified
2363            our copy slightly from the original source.
2364            I've removed the relative import in hopes this fixes
2365            the problem.
2366
2367 2010-08-13  Eric Seidel  <eric@webkit.org>
2368
2369         Unreviewed.  Build fix only.
2370
2371         Add support for MathML entities
2372         https://bugs.webkit.org/show_bug.cgi?id=43949
2373
2374         * Scripts/create-html-entity-table:
2375          - Hack sys.path to avoid executing 2.5 dependent python
2376            on systems (like chromium-win and Tiger) which do not have 2.5 python.
2377
2378 2010-08-13  Adam Barth  <abarth@webkit.org>
2379
2380         Reviewed by Eric Seidel.
2381
2382         Rename some concepts in HTML entity search to be more self-documenting
2383         https://bugs.webkit.org/show_bug.cgi?id=44004
2384
2385         Reflect name change in generator script.
2386
2387         * Scripts/create-html-entity-table:
2388
2389 2010-08-12  Adam Barth  <abarth@webkit.org>
2390
2391         Reviewed by Eric Seidel.
2392
2393         Add support for MathML entities
2394         https://bugs.webkit.org/show_bug.cgi?id=43949
2395
2396         A script for generating the C++ state data structure describing all the
2397         entities from a JSON description.
2398
2399         * Scripts/create-html-entity-table: Added.
2400
2401 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
2402
2403         Reviewed by Eric Seidel.
2404
2405         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
2406         check for exceptions on all threads, not just the first thread.
2407         
2408         This change also changes the logging behavior for wedged threads
2409         to only dump the stacks of threads that are actually wedged.
2410
2411         Refactor the thread classes in the dump_render_tree_thread module
2412         to make the contract between TestRunner and TestShellThread clearer.
2413
2414         Added a bunch of unit tests.
2415         https://bugs.webkit.org/show_bug.cgi?id=38561
2416
2417         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2418         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2419         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2420
2421 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
2422
2423         Reviewed by Shinichiro Hamaji.
2424
2425         Add test_expectations.txt syntax checker to check-webkit-style.
2426         https://bugs.webkit.org/show_bug.cgi?id=43899
2427
2428         Just utilizing layout_tests/layout_package/test_expectations.py for checking
2429         the syntax of test_expectations.txt.
2430         This change also moves tab checking class from style/checkers/text.py to
2431         style/checkers/common.py for sharing code.
2432
2433         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2434         * Scripts/webkitpy/style/checker.py:
2435         * Scripts/webkitpy/style/checkers/common.py:
2436         * Scripts/webkitpy/style/checkers/common_unittest.py:
2437         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
2438         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
2439         * Scripts/webkitpy/style/checkers/text.py:
2440         * Scripts/webkitpy/style_references.py:
2441
2442 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2443
2444         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
2445         https://bugs.webkit.org/show_bug.cgi?id=43945
2446
2447         Reviewed by Sam Weinig.
2448
2449         * WebKitTestRunner/TestInvocation.cpp:
2450         (WTR::sizeWebViewForCurrentTest):
2451         Allow for a Windows-style path.
2452
2453         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2454         (WTR::PlatformWebView::resizeTo):
2455         Call SetWindowPos to resize the view window.
2456
2457 2010-08-12  David Levin  <levin@chromium.org>
2458
2459         Build break fix.
2460
2461         * WebKitTestRunner/TestController.cpp:
2462         (WTR::TestController::resetStateToConsistentValues): Removed usage
2463         of a variable that doesn't exist in the class.
2464
2465 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2466
2467         WebKitTestRunner needs to run tests without using native controls
2468         https://bugs.webkit.org/show_bug.cgi?id=43772
2469
2470         Reviewed by Sam Weinig.
2471
2472         * WebKitTestRunner/TestController.cpp:
2473         (WTR::TestController::initialize):
2474         Call platformInitializeContext().
2475
2476         * WebKitTestRunner/TestController.h:
2477         Declare platformInitializeContext().
2478
2479         * WebKitTestRunner/mac/TestControllerMac.mm:
2480         (WTR::TestController::platformInitializeContext):
2481         Stubbed.
2482
2483         * WebKitTestRunner/win/TestControllerWin.cpp:
2484         (WTR::TestController::platformInitializeContext):
2485         Call WKContextSetShouldPaintNativeControls() to disable native control
2486         drawing.
2487
2488 2010-08-12  Sam Weinig  <sam@webkit.org>
2489
2490         Reviewed by Alexey Proskuryakov.
2491
2492         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
2493         https://bugs.webkit.org/show_bug.cgi?id=43653
2494
2495         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2496         (WTR::InjectedBundle::InjectedBundle):
2497         (WTR::InjectedBundle::didReceiveMessage):
2498         (WTR::InjectedBundle::beginTesting):
2499         (WTR::InjectedBundle::done):
2500         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2501         (WTR::InjectedBundle::isTestRunning):
2502         (WTR::InjectedBundle::):
2503         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2504         (WTR::InjectedBundlePage::stopLoading):
2505         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2506         (WTR::InjectedBundlePage::dump):
2507         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2508         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2509         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2510         (WTR::InjectedBundlePage::didClearWindowForFrame):
2511         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2512         (WTR::InjectedBundlePage::willAddMessageToConsole):
2513         (WTR::InjectedBundlePage::willSetStatusbarText):
2514         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2515         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2516         (WTR::InjectedBundlePage::shouldBeginEditing):
2517         (WTR::InjectedBundlePage::shouldEndEditing):
2518         (WTR::InjectedBundlePage::shouldInsertNode):
2519         (WTR::InjectedBundlePage::shouldInsertText):
2520         (WTR::InjectedBundlePage::shouldDeleteRange):
2521         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2522         (WTR::InjectedBundlePage::shouldApplyStyle):
2523         (WTR::InjectedBundlePage::didBeginEditing):
2524         (WTR::InjectedBundlePage::didEndEditing):
2525         (WTR::InjectedBundlePage::didChange):
2526         (WTR::InjectedBundlePage::didChangeSelection):
2527         Don't do any work if we are not currently running a test.
2528
2529         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2530         * WebKitTestRunner/StringFunctions.h:
2531         (WTR::toCF):
2532         Add conversion function for WKURLRef -> CFURLRef
2533
2534         * WebKitTestRunner/TestController.cpp:
2535         (WTR::TestController::TestController):
2536         (WTR::TestController::initialize):
2537         (WTR::TestController::resetStateToConsistentValues):
2538         (WTR::TestController::runTest):
2539         (WTR::TestController::didFinishLoadForFrame):
2540         * WebKitTestRunner/TestController.h:
2541         (WTR::TestController::):
2542         * WebKitTestRunner/TestInvocation.cpp:
2543         (WTR::TestInvocation::invoke):
2544         * WebKitTestRunner/TestInvocation.h:
2545         Move resetting code to TestController.
2546
2547         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2548         * WebKitTestRunner/mac/TestControllerMac.mm:
2549         (WTR::TestController::runUntil):
2550         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2551         * WebKitTestRunner/win/TestControllerWin.cpp:
2552         (WTR::TestController::runUntil):
2553         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
2554         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2555         Move runUntil to TestController.
2556
2557 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2558
2559         Unreviewed.
2560
2561         Adding myself to the committers list.
2562
2563         * Scripts/webkitpy/common/config/committers.py:
2564
2565 2010-08-12  Hayato Ito  <hayato@chromium.org>
2566
2567         Reviewed by Tony Chang.
2568
2569         Merge pretty printers for gdb.
2570         https://bugs.webkit.org/show_bug.cgi?id=43850
2571
2572         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
2573         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
2574         webcore.py is left for backward compatibility.
2575
2576         * gdb/webcore.py:
2577         * gdb/webkit.py: Added.
2578         * gdb/wtf.py: Removed.
2579
2580 2010-08-11  Tony Chang  <tony@chromium.org>
2581
2582         Reviewed by David Levin.
2583
2584         [chromium] add google-chrome layout test result directories
2585         https://bugs.webkit.org/show_bug.cgi?id=43889
2586
2587         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2588         * Scripts/webkitpy/layout_tests/port/factory.py:
2589         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
2590         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2591
2592 2010-08-11  Kent Tamura  <tkent@chromium.org>
2593
2594         Reviewed by Dimitri Glazkov.
2595
2596         [DRT/Chromium] Disable accelerated compositing
2597         https://bugs.webkit.org/show_bug.cgi?id=43894
2598
2599         Disable accelerated compositing because DRT is not ready for
2600         it. This change fixes hundreds of test crashes on Windows and
2601         Linux.
2602
2603         * DumpRenderTree/chromium/TestShell.cpp:
2604         (TestShell::resetWebSettings):
2605
2606 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2607
2608         Unreviewed. Adding my Collabora personality to the list.
2609
2610         * Scripts/webkitpy/common/config/committers.py:
2611
2612 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
2613
2614         Adding myself as a reviewer.
2615
2616         * Scripts/webkitpy/common/config/committers.py:
2617
2618 2010-08-11  Daniel Bates  <dbates@rim.com>
2619
2620         Reviewed by Darin Adler.
2621
2622         Perl warnings when running commit-log-editor
2623         https://bugs.webkit.org/show_bug.cgi?id=43856
2624
2625         Fixes Perl warnings introduced by the patch for Bug #40548.
2626
2627         Perl doesn't have symbolic names for True/False. Instead, we
2628         should use boolean values. Moreover, the variable installedEditorApplication
2629         is not be used and should be renamed builtEditorApplication so that it
2630         uses the existing machinery to set the commit log editor application.
2631
2632         * Scripts/commit-log-editor:
2633
2634 2010-08-11  Adam Barth  <abarth@webkit.org>
2635
2636         Reviewed by Eric Seidel.
2637
2638         Trying waiting for httpd lock in the EWS
2639         https://bugs.webkit.org/show_bug.cgi?id=43833
2640
2641         If this works, we can probably run the tests on the mac-ews, which
2642         would be very exciting.  :)
2643
2644         * Scripts/webkitpy/tool/steps/runtests.py:
2645
2646 2010-08-11  Marcus Bulach  <bulach@chromium.org>
2647
2648         Reviewed by Eric Seidel.
2649
2650         Check in a script to list redundant test outputs.
2651         https://bugs.webkit.org/show_bug.cgi?id=37630
2652
2653         If e.g. platform/mac-leopard is missing an expected test output, we
2654         fall back on platform/mac.  This means it's possible to grow redundant
2655         test outputs, where we have the same expected data in both a platform
2656         directory and another platform it falls back on.
2657         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
2658
2659         * Scripts/deduplicate-tests: Added.
2660         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
2661         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
2662
2663 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2664
2665         Reviewed by Ariya Hidayat.
2666
2667         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
2668         https://bugs.webkit.org/show_bug.cgi?id=43853
2669
2670         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
2671         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
2672         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
2673         to slots at all.
2674
2675         * QtTestBrowser/launcherwindow.cpp:
2676         (LauncherWindow::createChrome):
2677         (LauncherWindow::animatedFlip):
2678         (LauncherWindow::animatedYFlip):
2679         * QtTestBrowser/launcherwindow.h:
2680
2681 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2682
2683         Reviewed by Simon Hausmann.
2684
2685         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
2686         https://bugs.webkit.org/show_bug.cgi?id=43851
2687
2688         All window options data (including the bool holding if the view is either QWebView or
2689         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
2690         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
2691         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
2692         getting broken.
2693
2694         Patch addresses this issue.
2695
2696         * QtTestBrowser/launcherwindow.cpp:
2697         (LauncherWindow::createChrome):
2698         (LauncherWindow::toggleWebView):
2699         (LauncherWindow::toggleAcceleratedCompositing):
2700
2701 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
2702
2703         Reviewed by Ariya Hidayat.
2704
2705         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
2706         https://bugs.webkit.org/show_bug.cgi?id=43831
2707
2708         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
2709
2710         * QtTestBrowser/webview.cpp:
2711         (WebViewGraphicsBased::WebViewGraphicsBased):
2712         (WebViewGraphicsBased::animatedYFlip):
2713
2714 2010-08-11  Darin Adler  <darin@apple.com>
2715
2716         Reviewed by John Sullivan.
2717
2718         Improved editor options for prepare-ChangeLog and commit-log-editor
2719         https://bugs.webkit.org/show_bug.cgi?id=40548
2720
2721         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
2722         values like "xed --launch --wait" work properly.
2723
2724         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
2725         use a command line tool with the $openChangeLogs feature.
2726
2727 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
2728
2729         Reviewed by Pavel Feldman.
2730
2731         Web Inspector: remove InjectDispatch.js
2732         https://bugs.webkit.org/show_bug.cgi?id=43835
2733
2734         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2735         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2736
2737 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
2738
2739         Reviewed by Eric Seidel.
2740
2741         webkit-patch should refuse to run under Win32 Python
2742         https://bugs.webkit.org/show_bug.cgi?id=40962
2743
2744         Given that there are lots of places in webkit-patch's code that
2745         assume unix-style filenames (forward slashes), webkit-patch fails
2746         with weird file-not-found errors when run under a native windows
2747         Python. It would be nice if we just trapped this and errored out
2748         at the beginning, rather than producing unpredictable errors.
2749
2750         * Scripts/webkit-patch:
2751
2752 2010-08-10  Kent Tamura  <tkent@chromium.org>
2753
2754         Unreviewed, build fix.
2755         
2756         Chromium build fix for r65107.
2757
2758         * DumpRenderTree/chromium/LayoutTestController.cpp:
2759         (LayoutTestController::suspendAnimations):
2760         (LayoutTestController::resumeAnimations):
2761
2762 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
2763
2764         Reviewed by Xan Lopez.
2765
2766         [GTK] http/tests/media/video-cookie.html fails
2767         https://bugs.webkit.org/show_bug.cgi?id=42240
2768
2769         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2770         (LayoutTestController::setAlwaysAcceptCookies): create the
2771         SoupCookieJar if it does not exist. Otherwise the accept policy
2772         won't be set.
2773
2774 2010-08-10  Chris Marrin  <cmarrin@apple.com>
2775
2776         Reviewed by Oliver Hunt.
2777
2778         Add suspendAnimations/resumeAnimation API to DRT
2779         https://bugs.webkit.org/show_bug.cgi?id=43733
2780         
2781         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
2782         Calls functions with the same names on AnimationController for the 
2783         mainFrame.
2784
2785         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2786         * DumpRenderTree/LayoutTestController.cpp:
2787         (suspendAnimationsCallback):
2788         (resumeAnimationsCallback):
2789         (LayoutTestController::staticFunctions):
2790         * DumpRenderTree/LayoutTestController.h:
2791         * DumpRenderTree/chromium/LayoutTestController.cpp:
2792         (LayoutTestController::LayoutTestController):
2793         (LayoutTestController::suspendAnimations):
2794         (LayoutTestController::resumeAnimations):
2795         * DumpRenderTree/chromium/LayoutTestController.h:
2796         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2797         (LayoutTestController::suspendAnimations):
2798         (LayoutTestController::resumeAnimations):
2799         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2800         (LayoutTestController::suspendAnimations):
2801         (LayoutTestController::resumeAnimations):
2802         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2803         (LayoutTestController::suspendAnimations):
2804         (LayoutTestController::resumeAnimations):
2805         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2806         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2807         (LayoutTestController::suspendAnimations):
2808         (LayoutTestController::resumeAnimations):
2809         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2810         (LayoutTestController::suspendAnimations):
2811         (LayoutTestController::resumeAnimations):
2812
2813 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
2814
2815         Reviewed by Ojan Vafai.
2816
2817         [Chromium/DRT] Enable saving layout test results.
2818         https://bugs.webkit.org/show_bug.cgi?id=43796
2819
2820         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
2821             parameters to the new-run-webkit-tests, including the name
2822             of the test results server.
2823
2824 2010-08-10  Jian Li  <jianli@chromium.org>
2825
2826         More chromium build fix.
2827
2828         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2829         (MockSpellCheck::spellCheckWord):
2830         (MockSpellCheck::initializeIfNeeded):
2831         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2832         (NotificationPresenter::grantPermission):
2833         (NotificationPresenter::show):
2834         (NotificationPresenter::checkPermission):
2835
2836 2010-08-10  Jian Li  <jianli@chromium.org>
2837
2838         Chromium build fix.
2839
2840         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2841         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2842
2843 2010-08-10  Victor Wang  <victorw@chromium.org>
2844
2845         Reviewed by Ojan Vafai.
2846
2847         Update test results server merge logic so the aggregated
2848         results and times are updated for tests that are
2849         in aggragated json but not in incremental json.
2850
2851         Also update unittest to test this case.
2852
2853         https://bugs.webkit.org/show_bug.cgi?id=43769
2854
2855         * TestResultServer/model/jsonresults.py:
2856         * TestResultServer/model/jsonresults_unittest.py:
2857
2858 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2859
2860         Reviewed by Ariya Hidayat.
2861
2862         [Qt] QtTestBrowser: proper set scene rect
2863
2864         When resizesToContents is ON scene's rect is set to the boundary of
2865         the mainFrame. However, navigating to other web page should keep resizing
2866         scene's rect according to the new document loaded. Patch addresses this issue.
2867
2868         Now resizesToContents and scrolling properly work on QtTestBrowser.
2869
2870         * QtTestBrowser/webview.cpp:
2871         (WebViewGraphicsBased::setPage):
2872         (WebViewGraphicsBased::contentsSizeChanged):
2873         (WebViewGraphicsBased::setResizesToContents):
2874         (WebViewGraphicsBased::resizeEvent):
2875         * QtTestBrowser/webview.h:
2876
2877 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2878
2879         Reviewed by Ariya Hidayat.
2880
2881         [Qt] QtTestBrowser: Clean up LauncherWindow code.
2882
2883         * QtTestBrowser/launcherwindow.cpp:
2884         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
2885         (LauncherWindow::init): Fixed comments.
2886         (LauncherWindow::applyPrefs): Move the method around.
2887         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
2888
2889 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2890
2891         Reviewed by Ariya Hidayat.
2892
2893         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
2894
2895         It gets control+0 the same visual effect as control++ or control-.
2896
2897         * QtTestBrowser/launcherwindow.cpp:
2898         (LauncherWindow::toggleZoomTextOnly):
2899
2900 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2901
2902         Reviewed by Ariya Hidayat.
2903
2904         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
2905
2906         Not all instances of LauncherWindow need its own m_zoomLevel.
2907
2908         * QtTestBrowser/launcherwindow.cpp:
2909         * QtTestBrowser/launcherwindow.h:
2910
2911 2010-08-09  Sam Weinig  <sam@webkit.org>
2912
2913         Reviewed by Geoffrey Garen.
2914
2915         Add zoom support for injected bundle
2916         https://bugs.webkit.org/show_bug.cgi?id=43759
2917
2918         Use zoom factor SPI to implement zoom related eventSender functions.
2919
2920         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2921         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2922         (WTR::EventSendingController::textZoomIn):
2923         (WTR::EventSendingController::textZoomOut):
2924         (WTR::EventSendingController::zoomPageIn):
2925         (WTR::EventSendingController::zoomPageOut):
2926         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2927         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2928         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
2929
2930 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
2931
2932         Speculative chromium build fix III.
2933
2934         * DumpRenderTree/chromium/MockSpellCheck.h:
2935         * DumpRenderTree/chromium/NotificationPresenter.h:
2936         * DumpRenderTree/chromium/WebViewHost.h:
2937         (WebViewHost::addClearHeader):
2938         (WebViewHost::clearHeaders):
2939
2940 2010-08-09  Ojan Vafai  <ojan@chromium.org>
2941
2942         Reviewed by Tony Chang.
2943
2944         increase the number of test results that we save
2945         https://bugs.webkit.org/show_bug.cgi?id=43763
2946
2947         Now that we do incremental uploads, we can increase the number of
2948         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
2949
2950         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2951
2952 2010-08-09  Evan Martin  <evan@chromium.org>
2953
2954         Reviewed by Tony Chang.
2955
2956         [chromium] DRT error print statement incorrectly tries to print a FILE*
2957         https://bugs.webkit.org/show_bug.cgi?id=43747
2958
2959         * DumpRenderTree/chromium/ImageDiff.cpp:
2960         (writeFile): pass the correct pointer.
2961
2962 2010-08-09  Victor Wang  <victorw@chromium.org>
2963
2964         Reviewed by Ojan Vafai.
2965
2966         Upload incremental test results json to server by default.
2967
2968         https://bugs.webkit.org/show_bug.cgi?id=43743
2969
2970         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2971
2972 2010-08-09  Eric Seidel  <eric@webkit.org>
2973
2974         Reviewed by Adam Barth.
2975
2976         EWS bots wait 2 minutes between patches
2977         https://bugs.webkit.org/show_bug.cgi?id=43731
2978
2979         * Scripts/webkitpy/tool/bot/queueengine.py:
2980          - Don't sleep after failures.  This was a hold-over from
2981            an earlier design.
2982         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2983          - EWS bots were not properly reporting true/false from process_work_item.
2984            They were always returning None, thus false, thus always logging
2985            as a failure and sleeping 2 minutes after each patch.
2986
2987 2010-08-09  Sam Weinig  <sam@webkit.org>
2988
2989         Reviewed by Anders Carlsson.
2990
2991         Stub out EventSender for WebKitTestRunner
2992         https://bugs.webkit.org/show_bug.cgi?id=43703
2993
2994         * WebKitTestRunner/DerivedSources.make:
2995         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2996         Add ability to pass javascript arguments to the wrapped object.
2997
2998         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
2999         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
3000         (WTR::EventSendingController::create):
3001         (WTR::EventSendingController::EventSendingController):
3002         (WTR::EventSendingController::~EventSendingController):
3003         (WTR::EventSendingController::wrapperClass):
3004         (WTR::setExceptionForString):
3005         (WTR::EventSendingController::mouseDown):
3006         (WTR::EventSendingController::mouseUp):
3007         (WTR::EventSendingController::mouseMoveTo):
3008         (WTR::EventSendingController::keyDown):
3009         (WTR::EventSendingController::contextClick):
3010         (WTR::EventSendingController::leapForward):
3011         (WTR::EventSendingController::textZoomIn):
3012         (WTR::EventSendingController::textZoomOut):
3013         (WTR::EventSendingController::zoomPageIn):
3014         (WTR::EventSendingController::zoomPageOut):
3015         (WTR::EventSendingController::makeWindowObject):
3016         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
3017         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3018         (WTR::InjectedBundle::reset):
3019         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3020         (WTR::InjectedBundle::eventSendingController):
3021         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3022         (WTR::InjectedBundlePage::didClearWindowForFrame):
3023         Add stubbed out EventSenderController.
3024
3025         * WebKitTestRunner/InjectedBundle/GCController.h:
3026         Remove incorrect comment.
3027
3028         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3029         * WebKitTestRunner/win/InjectedBundle.vcproj:
3030         Add new files.
3031
3032 2010-08-08  Kent Tamura  <tkent@chromium.org>
3033
3034         Unreviewed, trivial fix.
3035
3036         Fix "WindowsError: [Error 32] The process cannot access the file
3037         because it is being used by another process" introduced by r64959.
3038
3039         * BuildSlaveSupport/test-result-archive:
3040
3041 2010-08-08  Kent Tamura  <tkent@chromium.org>
3042
3043         Reviewed by Tony Chang.
3044
3045         Chromium buildbot: Avoid "zip" command dependency
3046         https://bugs.webkit.org/show_bug.cgi?id=43470
3047
3048         * BuildSlaveSupport/test-result-archive:
3049          For Chromium port, creates a zip archive with zipfile package of Python
3050          instead of external "zip" command. We'd like to avoid additional
3051          command installation.
3052
3053 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
3054
3055         WebKitTestRunner should add the QuickTime dir to the PATH environment
3056         variable
3057         https://bugs.webkit.org/show_bug.cgi?id=43686
3058
3059         Reviewed by Dan Bernstein.
3060
3061         * WebKitTestRunner/win/TestControllerWin.cpp:
3062         (WTR::addQTDirToPATH):
3063         Copied from DRT.
3064         (WTR::TestController::platformInitialize):
3065         Call addQTDirToPath().
3066         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3067         Link to shlwapi.lib for SHGetValue.
3068
3069 2010-08-07  Sam Weinig  <sam@webkit.org>
3070
3071         Reviewed by Maciej Stachowiak.
3072
3073         WebKitTestRunner needs layoutTestController.dumpTitleChanges
3074         <rdar://problem/8213861>
3075         https://bugs.webkit.org/show_bug.cgi?id=42683
3076
3077         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3078         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3079         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3080         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3081         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3082         (WTR::LayoutTestController::LayoutTestController):
3083         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3084         (WTR::LayoutTestController::dumpTitleChanges):
3085         (WTR::LayoutTestController::shouldDumpTitleChanges):
3086
3087 2010-08-07  Sam Weinig  <sam@webkit.org>
3088
3089         Reviewed by Anders Carlsson.
3090
3091         WebKitTestRunner needs to print onunload handler information
3092         <rdar://problem/8213831>
3093         https://bugs.webkit.org/show_bug.cgi?id=42703
3094
3095         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3096         (WTR::operator<<):
3097         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3098
3099 2010-08-07  Sam Weinig  <sam@webkit.org>
3100
3101         Reviewed by Anders Carlsson.
3102
3103         Add additional loader client functions need to complete WebKitTestRunner
3104         https://bugs.webkit.org/show_bug.cgi?id=43684
3105
3106         Remove unnecessary and jarring underscores as well.
3107
3108         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3109         (didClearWindowObjectForFrame):
3110         (didCreatePage):
3111         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3112         (WTR::InjectedBundlePage::InjectedBundlePage):
3113         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3114         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3115         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3116         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3117         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3118         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3119         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3120         (WTR::InjectedBundlePage::didClearWindowForFrame):
3121         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
3122         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
3123         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
3124         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3125         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
3126         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
3127         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
3128         (WTR::InjectedBundlePage::willAddMessageToConsole):
3129         (WTR::InjectedBundlePage::willSetStatusbarText):
3130         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3131         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3132         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3133         (WTR::InjectedBundlePage::shouldBeginEditing):
3134         (WTR::InjectedBundlePage::shouldEndEditing):
3135         (WTR::InjectedBundlePage::shouldInsertNode):
3136         (WTR::InjectedBundlePage::shouldInsertText):
3137         (WTR::InjectedBundlePage::shouldDeleteRange):
3138         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3139         (WTR::InjectedBundlePage::shouldApplyStyle):
3140         (WTR::InjectedBundlePage::didBeginEditing):
3141         (WTR::InjectedBundlePage::didEndEditing):
3142         (WTR::InjectedBundlePage::didChange):
3143         (WTR::InjectedBundlePage::didChangeSelection):
3144         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3145
3146 2010-08-07  Dan Bernstein  <mitz@apple.com>
3147
3148         Build fix.
3149
3150         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
3151         to JSGCController.{cpp,h} relative to the build root.
3152
3153 2010-08-07  Sam Weinig  <sam@webkit.org>
3154
3155         Reviewed by Anders Carlsson.
3156
3157         WebKitTestRunner needs GCController
3158         <rdar://problem/8213834>
3159         https://bugs.webkit.org/show_bug.cgi?id=42701
3160
3161         * WebKitTestRunner/DerivedSources.make:
3162         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
3163         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
3164         (WTR::setProperty):
3165         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
3166         (WTR::GCController::create):
3167         (WTR::GCController::GCController):
3168         (WTR::GCController::~GCController):
3169         (WTR::GCController::wrapperClass):
3170         (WTR::GCController::collect):
3171         (WTR::GCController::collectOnAlternateThread):
3172         (WTR::GCController::getJSObjectCount):
3173         (WTR::GCController::makeWindowObject):
3174         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
3175         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3176         (WTR::InjectedBundle::reset):
3177         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3178         (WTR::InjectedBundle::bundle):
3179         (WTR::InjectedBundle::gcController):
3180         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3181         (WTR::InjectedBundlePage::didClearWindowForFrame):
3182         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3183         (WTR::LayoutTestController::keepWebHistory):
3184         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3185         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3186         * WebKitTestRunner/win/InjectedBundle.vcproj:
3187
3188 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
3189
3190         WebKitTestRunner needs to be able to set the font smoothing type
3191         https://bugs.webkit.org/show_bug.cgi?id=43406
3192
3193         Reviewed by Adam Roben.
3194
3195         * WebKitTestRunner/TestInvocation.cpp:
3196         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3197         Set the font smoothing level to
3198         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
3199
3200 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
3201
3202         Fix a missed variable rename.
3203
3204         Unreviewed.
3205
3206         * Scripts/old-run-webkit-tests:
3207
3208 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
3209
3210         mac-wk2/Skipped should be used on Windows when running regression tests
3211         https://bugs.webkit.org/show_bug.cgi?id=43494
3212
3213         Reviewed by Adam Roben.
3214
3215         * Scripts/old-run-webkit-tests:
3216         If the platform is win-wk2, also read the mac-wk2 skipped list.
3217
3218 2010-08-06  Kent Tamura  <tkent@chromium.org>
3219
3220         Reviewed by Dimitri Glazkov.
3221
3222         [DRT/Chromium] Should revoke scheduled tasks
3223         https://bugs.webkit.org/show_bug.cgi?id=43560
3224
3225         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3226         (DRTDevToolsAgent::reset): Calls RevokeAll().
3227         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3228         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3229         (DRTDevToolsClient::reset): Calls RevokeAll().
3230         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3231         * DumpRenderTree/chromium/EventSender.cpp:
3232         (EventSender::reset): Calls RevokeAll().
3233         * DumpRenderTree/chromium/LayoutTestController.cpp:
3234         (LayoutTestController::reset): Calls RevokeAll().
3235         * DumpRenderTree/chromium/TestShell.cpp:
3236         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
3237
3238 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3239
3240         Reviewed by Antonio Gomes.
3241
3242         [Qt] Fix the DRT build on Mac OS X
3243
3244         * DumpRenderTree/qt/DumpRenderTree.pro:
3245
3246 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
3247
3248         Reviewed by Pavel Feldman.
3249
3250         Rietvield's upload.py moved to a different location.
3251         https://bugs.webkit.org/show_bug.cgi?id=43613
3252
3253         * Scripts/webkitpy/thirdparty/__init__.py:
3254
3255 2010-05-23  Eric Seidel  <eric@webkit.org>
3256
3257         Reviewed by Adam Barth.
3258
3259         QueueStatusServer needs better queue-status pages
3260         https://bugs.webkit.org/show_bug.cgi?id=39562
3261
3262         The primary goal of this patch is to display queue
3263         positions somewhere on the site so that it's easier
3264         for commit-queue users to know when their pach will
3265         be landed.  I also tried to improve the root page
3266         to be more useful than the previous wall of status text.
3267
3268         * QueueStatusServer/handlers/recentstatus.py:
3269         * QueueStatusServer/main.py:
3270         * QueueStatusServer/model/queues.py:
3271         * QueueStatusServer/templates/recentstatus.html:
3272
3273 2010-08-05  Victor Wang  <victorw@chromium.org>
3274
3275         Reviewed by Ojan Vafai.
3276
3277         Add option to generate/upload incremental json results to test result server.
3278         Also refactor the json results generator unittest code to test
3279         incremental and aggregated json results.
3280
3281         https://bugs.webkit.org/show_bug.cgi?id=43519
3282
3283         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3284         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3285         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3286         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3287
3288 2010-08-05  Jian Li  <jianli@chromium.org>
3289
3290         Reviewed by David Levin.
3291
3292         Unify blob related feature defines to ENABLE(BLOB).
3293         https://bugs.webkit.org/show_bug.cgi?id=43081
3294
3295         * Scripts/build-webkit:
3296
3297 2010-08-05  Satish Sampath  <satish@chromium.org>
3298
3299         Reviewed by Jeremy Orlow.
3300
3301         Add speech input controller mock in WebKit and a layout test.
3302         https://bugs.webkit.org/show_bug.cgi?id=43477
3303
3304         Added LayoutTestController::setMockSpeechInputResultCallback method.
3305
3306         * DumpRenderTree/LayoutTestController.cpp:
3307         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
3308         (LayoutTestController::staticFunctions):
3309         * DumpRenderTree/LayoutTestController.h:
3310         * DumpRenderTree/chromium/LayoutTestController.cpp:
3311         (LayoutTestController::LayoutTestController):
3312         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
3313         (LayoutTestController::speechInputController): Creates the mock controller.
3314         * DumpRenderTree/chromium/LayoutTestController.h:
3315         * DumpRenderTree/chromium/WebViewHost.cpp:
3316         (WebViewHost::speechInputController): Creates the mock controller.
3317         * DumpRenderTree/chromium/WebViewHost.h:
3318         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3319         (LayoutTestController::setMockSpeechInputResult): dummy method.
3320         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3321         (LayoutTestController::setMockSpeechInputResult): dummy method.
3322         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3323         (LayoutTestController::setMockSpeechInputResult): dummy method.
3324         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3325         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
3326         (LayoutTestController::setMockSpeechInputResult):
3327         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
3328         (LayoutTestController::setMockSpeechInputResult):
3329
3330 2010-08-04  Adam Roben  <aroben@apple.com>
3331
3332         Fix the path to TestNetscapePlugin's directory on Windows
3333
3334         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
3335         load TestNetscapePlugin
3336
3337         Reviewed by Jon Honeycutt.
3338
3339         * WebKitTestRunner/win/TestControllerWin.cpp:
3340         (WTR::TestController::initializeTestPluginDirectory):
3341         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
3342         next to WebKitTestRunner.exe. Previously we were passing the directory
3343         that contains WebKitTestRunner.exe. Also fixed some leaks.
3344
3345 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
3346
3347         Reviewed by Shinichiro Hamaji.
3348
3349         check-webkit-style returns non-zero when patch is entirely minus lines.
3350         https://bugs.webkit.org/show_bug.cgi?id=38169
3351
3352         * Scripts/check-webkit-style:
3353         Check whether a patch contains modified files that are entirely minus lines.
3354         * Scripts/webkitpy/style/filereader.py:
3355         Add a variable that holds number of files that contain only deleted lines.
3356         * Scripts/webkitpy/style/patchreader.py:
3357         Count up modified files that contain only deleted lines.
3358
3359 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
3360
3361         Reviewed by Yury Semikhatsky.
3362
3363         DevTools: get rid of delayed command dispatching on front-end side.
3364
3365         https://bugs.webkit.org/show_bug.cgi?id=43479
3366
3367         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3368         (DRTDevToolsAgent::detach):
3369         (DRTDevToolsAgent::frontendLoaded):
3370         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3371         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3372         (DRTDevToolsClient::~DRTDevToolsClient):
3373         (DRTDevToolsClient::sendFrontendLoaded):
3374         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3375
3376 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
3377
3378         Reviewed by Shinichiro Hamaji.
3379
3380         Fixes check-webkit-style false positive on "new uint32_t."
3381         https://bugs.webkit.org/show_bug.cgi?id=43077
3382
3383         * Scripts/webkitpy/style/checkers/cpp.py:
3384         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3385
3386 2010-08-04  Kent Tamura  <tkent@chromium.org>
3387
3388         Reviewed by Dimitri Glazkov.
3389
3390         [DRT/Chromium] Remove base/linked_ptr.h dependency
3391         https://bugs.webkit.org/show_bug.cgi?id=43472
3392
3393         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
3394         We need to use RefPtr<> because m_pendingEntry points an object in
3395         m_entries or not in m_entries.
3396
3397         * DumpRenderTree/chromium/TestNavigationController.cpp:
3398         (TestNavigationEntry::create): Added.
3399         (TestNavigationController::activeEntry):
3400         (TestNavigationController::didNavigateToEntry):
3401         (TestNavigationController::discardPendingEntry):
3402         (TestNavigationController::insertEntry):
3403         (TestNavigationController::navigateToPendingEntry):
3404         * DumpRenderTree/chromium/TestNavigationController.h:
3405         * DumpRenderTree/chromium/WebViewHost.cpp:
3406         (WebViewHost::loadURLForFrame):
3407          Use TestNavigationEntry::create().
3408         (WebViewHost::updateURL):
3409          Use RefPtr<>.
3410         (WebViewHost::updateSessionHistory):
3411          Remove unnecessary static_cast<>.
3412
3413 2010-08-04  Kent Tamura  <tkent@chromium.org>
3414
3415         Reviewed by Dimitri Glazkov.
3416
3417         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
3418         https://bugs.webkit.org/show_bug.cgi?id=43333
3419
3420         * BuildSlaveSupport/test-result-archive:
3421           - Make layoutTestResultsDir local and pass it to archiveTestResults()
3422           - Adjust layoutTestResultsDir for Chromium
3423
3424 2010-08-04  Kent Tamura  <tkent@chromium.org>
3425
3426         Reviewed by Dimitri Glazkov.
3427
3428         NRWT: websocket_server startup detection failure
3429         https://bugs.webkit.org/show_bug.cgi?id=43466
3430
3431         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3432          Increase timeout value: 5 second -> 10 second
3433
3434 2010-08-04  Victor Wang  <victorw@chromium.org>
3435
3436         Reviewed by Ojan Vafai.
3437
3438         -. Add result.json incremental merging functionality to test results app engine.
3439         -. blobstore is not suitable for AE data merging and there is no API to
3440            programatically edit existing blob or write a new one yet, so replace blobstore
3441            with datastore. If file is oversize (>1000*1000 bytes), store file data in
3442            multiple datastore entries.
3443         -. Fix styles.
3444
3445         Test: jsonresults_unittest to test merging logics.
3446
3447         https://bugs.webkit.org/show_bug.cgi?id=38599
3448
3449         * TestResultServer/handlers/dashboardhandler.py:
3450         * TestResultServer/handlers/menu.py:
3451         * TestResultServer/handlers/testfilehandler.py:
3452         * TestResultServer/main.py:
3453         * TestResultServer/model/dashboardfile.py:
3454         * TestResultServer/model/datastorefile.py: Added.
3455         * TestResultServer/model/jsonresults.py: Added.
3456         * TestResultServer/model/jsonresults_unittest.py: Added.
3457         * TestResultServer/model/testfile.py:
3458         * TestResultServer/templates/uploadform.html:
3459
3460 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
3461
3462         Reviewed by Kenneth Christiansen.
3463
3464         [Qt] [QtTestBrowser] Remove unneeded QAction class members
3465         https://bugs.webkit.org/show_bug.cgi?id=43518
3466
3467         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
3468         m_flipYAnimated. Also, in initializeView method there are some dead code block
3469         trying to connect them at the wrong time, when they have not been instanciated.
3470
3471         This patch:
3472
3473         - removes the two cited class members in favor of local variables in createChrome method;
3474         - removes the dead code block.
3475
3476         * QtTestBrowser/launcherwindow.cpp:
3477         (LauncherWindow::LauncherWindow):
3478         (LauncherWindow::initializeView):
3479         (LauncherWindow::createChrome):
3480         * QtTestBrowser/launcherwindow.h:
3481
3482 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
3483
3484         Reviewed by Simon Hausmann and Kenneth Christiansen.
3485
3486         [Qt] [QtTestBrowser] Clean up static and global menu state controls
3487         https://bugs.webkit.org/show_bug.cgi?id=43448
3488
3489         After LauncherWindow class was refactored out of from main.cpp, all global variables that
3490         were hanging in main.cpp became temporarily public static class members of newly added
3491         LauncherWindow class. This design was not properly handling the initial purpose of the
3492         global variables: newly created launcher windows should inherit the settings of the originating
3493         one.
3494
3495         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
3496         comprises all data needed to handling the goal described above.
3497
3498         * QtTestBrowser/launcherwindow.cpp:
3499         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
3500                                           holding all user settings configured in the menus and command line.
3501                                           It also receices an optional QGraphicsScene points in case we are doing
3502                                           a "Clone Window".
3503         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
3504                                 value.
3505         (LauncherWindow::initializeView): Ditto.
3506         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
3507         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
3508                                       apply the preferences is provided by m_userData.
3509         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
3510         (LauncherWindow::toggleResizesToContents): Ditto.
3511         (LauncherWindow::toggleWebGL): Ditto.
3512         (LauncherWindow::toggleFrameFlattening): Ditto.
3513         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
3514         (LauncherWindow::changeViewportUpdateMode): Ditto.
3515         (LauncherWindow::showFPS): Ditto.
3516         (LauncherWindow::newWindow): Changed to pass the userData.
3517         (LauncherWindow::cloneWindow): Ditto.
3518         * QtTestBrowser/launcherwindow.h:
3519         (WindowOptions::WindowOptions):
3520         * QtTestBrowser/main.cpp:
3521         (requiresGraphicsView):
3522         (LauncherApplication::handleUserOptions):
3523         (main):
3524
3525 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
3526
3527         [wx] Build fix for gcc not importing all symbols from convenience libraries.
3528         Works on 10.6 only for Mac until the build system is reworked. 
3529
3530         * wx/build/settings.py:
3531
3532 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
3533
3534         Reviewed by Simon Hausmann.
3535
3536         [Qt] Change wording in QtTestBrowser
3537         https://bugs.webkit.org/show_bug.cgi?id=43241
3538
3539         * QtTestBrowser/launcherwindow.cpp:
3540         (LauncherWindow::createChrome):
3541
3542 2010-08-04  Aaron Boodman  <aa@chromium.org>
3543
3544         Reviewed by Eric Seidel.
3545
3546         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
3547         https://bugs.webkit.org/show_bug.cgi?id=43460
3548
3549         * Scripts/prepare-ChangeLog:
3550
3551 2010-08-03  MORITA Hajime  <morrita@google.com>
3552
3553         Reviewed by Tony Chang.
3554
3555         [DRT] Assertion failed when drag and move a draggable element.
3556         https://bugs.webkit.org/show_bug.cgi?id=41695
3557
3558         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
3559         But Cocoa doesn't call mouseDragged() until dragging is done.
3560         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
3561         on UIDelegate failed when mouseDragged() is called during dragging.
3562         This change eliminated the mouseDragged() call when dragging begins,
3563         which is implicated by draggingInfo instance.
3564         
3565         * DumpRenderTree/mac/EventSendingController.mm:
3566         (-[EventSendingController mouseMoveToX:Y:]):
3567
3568         Test: fast/events/dragging-mouse-moves.html
3569         
3570 2010-08-02  Steve Block  <steveblock@google.com>
3571
3572         Reviewed by Alexey Proskuryakov.
3573
3574         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
3575         https://bugs.webkit.org/show_bug.cgi?id=40002
3576
3577         The code in LayoutTestController::setGeolocationPermission() was moved to
3578         setGeolocationPermissionCommon() to allow each port to provide its own
3579         implementation of setGeolocationPermission().
3580
3581         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
3582         new permission, so it can call back to WebCore if permission requests are in
3583         progress and are waiting for a response. A minor fix to the Mac
3584         MockGeolocationProvider was also required to make sure that the mock provider
3585         calls back to WebCore when it is first started.
3586
3587         For other ports, LayoutTestController::setGeolocationPermission() is not
3588         implemented.
3589
3590         * DumpRenderTree/LayoutTestController.cpp:
3591         (LayoutTestController::setGeolocationPermissionCommon):
3592         * DumpRenderTree/LayoutTestController.h:
3593         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3594         (LayoutTestController::setGeolocationPermission):
3595         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3596         (LayoutTestController::setGeolocationPermission):
3597         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3598         (-[MockGeolocationProvider registerWebView:]):
3599         * DumpRenderTree/mac/UIDelegate.h:
3600         * DumpRenderTree/mac/UIDelegate.mm:
3601         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3602         (-[UIDelegate setGeolocationPermission:]):
3603         (-[UIDelegate dealloc]):
3604         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3605         (LayoutTestController::setGeolocationPermission):
3606         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3607         (LayoutTestController::setGeolocationPermission):
3608
3609 2010-08-03  Kent Tamura  <tkent@chromium.org>
3610
3611         Reviewed by Dimitri Glazkov.
3612
3613         [DRT/Chromium] Implement --testshell-startup-dialog
3614         https://bugs.webkit.org/show_bug.cgi?id=40616
3615
3616         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3617         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
3618         if it is specfied.
3619         * DumpRenderTree/chromium/TestShell.h:
3620           Declare openStartUpDialog().
3621         * DumpRenderTree/chromium/TestShellGtk.cpp:
3622         (openStartupDialog):
3623         * DumpRenderTree/chromium/TestShellMac.mm:
3624         (openStartupDialog):
3625         * DumpRenderTree/chromium/TestShellWin.cpp:
3626         (openStartupDialog):
3627
3628 2010-08-03  Kent Tamura  <tkent@chromium.org>
3629
3630         Reviewed by Dimitri Glazkov.
3631
3632         [DRT/Chromium] Remove dependency of base/md5.h
3633         https://bugs.webkit.org/show_bug.cgi?id=43403
3634
3635         * DumpRenderTree/chromium/TestShell.cpp:
3636         (TestShell::dumpImage): Use wtf/MD5.h
3637
3638 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
3639
3640         Reviewed by David Kilzer.
3641
3642         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
3643